GNU bug report logs - #73759
[PATCH] gnu: Upgrade googletest

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73759 in the body.
You can then email your comments to 73759 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: guix-patches <at> gnu.org
Cc: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Subject: [PATCH] gnu: Upgrade googletest
Date: Fri, 11 Oct 2024 21:16:18 -0400

* gnu/packages/check.scm (googletest): Upgrade to 1.15.2
---
 gnu/packages/check.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 8d41996c71..a74052fa35 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -1059,16 +1059,16 @@ (define-public python-gixy
 (define-public googletest
   (package
     (name "googletest")
-    (version "1.12.1")
+    (version "1.15.2")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
              (url "https://github.com/google/googletest")
-             (commit (string-append "release-" version))))
+             (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1cv55x3amwrvfan9pr8dfnicwr8r6ar3yf6cg9v6nykd6m2v3qsv"))))
+        (base32 "0wvivz9hxxs8gdmqx0v4g012lqi43fpzvndwmx6i0wdcwi4pdqnl"))))
     (build-system cmake-build-system)
     (arguments
      `(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")))

base-commit: b8fd792ea267cb920da0651074a533d8abf00488
-- 
2.46.0

Message #8 received at 73759 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: 73759 <at> debbugs.gnu.org
Cc: Aaron Covrig <aarcov <at> gmail.com>
Subject: [PATCH v2] gnu: Upgrade googletest
Date: Fri, 21 Mar 2025 13:38:38 -0400

* gnu/packages/check.scm (googletest): Upgrade to 1.16.0
---
 gnu/packages/check.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 4994a10f11..ab570f25b0 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -1065,16 +1065,16 @@ (define-public python-gixy
 (define-public googletest
   (package
     (name "googletest")
-    (version "1.12.1")
+    (version "1.16.0")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
              (url "https://github.com/google/googletest")
-             (commit (string-append "release-" version))))
+             (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1cv55x3amwrvfan9pr8dfnicwr8r6ar3yf6cg9v6nykd6m2v3qsv"))))
+        (base32 "078c46m4cnd2hdwn57yybphwy076vsy7ga8cyqy7l7kapkscllyk"))))
     (build-system cmake-build-system)
     (arguments
      `(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")))

base-commit: efac1498c15198afc4f9a2bc700408bde1b3b3ed
-- 
2.48.1

Message #11 received at 73759 <at> debbugs.gnu.org (full text, mbox):

From: ngraves <at> ngraves.fr
To: Aaron Covrig <aaron.covrig.us <at> ieee.org>, 73759 <at> debbugs.gnu.org
Cc: Aaron Covrig <aarcov <at> gmail.com>
Subject: Re: [bug#73759] [PATCH v2] gnu: Upgrade googletest
Date: Sat, 26 Apr 2025 17:34:15 +0200

Hi Aaron,

googletest has 6k+ dependent packages, it should be updated in a
dedicated branch (core-packages, or maybe c++).

Please add a proper subject prefix and notify a team ;)

https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html

I'll mark the series as more-info to avoid QA evaluation.

Cheers,

Nicolas

Message #16 received at 73759 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: ngraves <at> ngraves.fr
Cc: 73759 <at> debbugs.gnu.org, Aaron Covrig <aaron.covrig.us <at> ieee.org>,
 Aaron Covrig <aarcov <at> gmail.com>
Subject: Re: [bug#73759] [PATCH v2] gnu: Upgrade googletest
Date: Fri, 9 May 2025 11:53:40 -0400

On Sat, Apr 26, 2025 at 11:35 AM ngraves--- via Guix-patches via
<guix-patches <at> gnu.org> wrote:
>
> Hi Aaron,
>
> googletest has 6k+ dependent packages, it should be updated in a
> dedicated branch (core-packages, or maybe c++).

v1.17.0 has since been released (which would be the third update on this issue).

I would like to put this on a c++ branch but the initial c++-team
branch makes major changes to the cmake build system so library
updates will need to wait for the subsequent branch. It has been
(exactly) 2 months waiting to move up half the queue, with
core-packages (and presumably qt) still to be merged. Then after
merging the c++ branch we'll be waiting for another round of the
queue.

But waiting leaves this issue open, and I have actually already
included it in a local c++-libraries branch, so perhaps I should push
that upstream, mark this issue done, and request a new specification
on CI for both c++-team (which is almost ready) and c++-libraries.

There is still the question of how to publish further patches fixing
broken builds from this update. It's not clear to me that the feature
branch is sufficient.

Greg

Message #21 received at 73759-done <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: ngraves <at> ngraves.fr
Cc: 73759-done <at> debbugs.gnu.org, Aaron Covrig <aaron.covrig.us <at> ieee.org>,
 Aaron Covrig <aarcov <at> gmail.com>
Subject: Re: [bug#73759] [PATCH v2] gnu: Upgrade googletest
Date: Wed, 9 Jul 2025 16:34:14 -0400

On Fri, May 9, 2025 at 11:53 AM Greg Hogan <code <at> greghogan.com> wrote:
>
> On Sat, Apr 26, 2025 at 11:35 AM ngraves--- via Guix-patches via
> <guix-patches <at> gnu.org> wrote:
> >
> > Hi Aaron,
> >
> > googletest has 6k+ dependent packages, it should be updated in a
> > dedicated branch (core-packages, or maybe c++).
>
> v1.17.0 has since been released (which would be the third update on this issue).
>
> I would like to put this on a c++ branch but the initial c++-team
> branch makes major changes to the cmake build system so library
> updates will need to wait for the subsequent branch. It has been
> (exactly) 2 months waiting to move up half the queue, with
> core-packages (and presumably qt) still to be merged. Then after
> merging the c++ branch we'll be waiting for another round of the
> queue.
>
> But waiting leaves this issue open, and I have actually already
> included it in a local c++-libraries branch, so perhaps I should push
> that upstream, mark this issue done, and request a new specification
> on CI for both c++-team (which is almost ready) and c++-libraries.
>
> There is still the question of how to publish further patches fixing
> broken builds from this update. It's not clear to me that the feature
> branch is sufficient.
>
> Greg

This is included in the c++-libraries branch so I am closing the issue.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.