GNU bug report logs - #73749
[PATCH] gnu: Add wtw

Previous Next

To reply to this bug, email your comments to 73749 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thomas Albers Raviola <thomas <at> thomaslabs.org>
To: guix-patches <at> gnu.org
Cc: Thomas Albers Raviola <thomas <at> thomaslabs.org>
Subject: [PATCH] gnu: Add wtw
Date: Fri, 11 Oct 2024 19:58:22 +0200

* gnu/packages/xdisorg.scm (wtw): New variable

Change-Id: Idcb580debda0d26b9e8ee6ec53d6f905415037ba
---
 gnu/packages/xdisorg.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 21681119f1..5baaec3dc7 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -65,6 +65,7 @@
 ;;; Copyright © 2024 Igor Goryachev <igor <at> goryachev.org>
 ;;; Copyright © 2024 Ashish SHUKLA <ashish.is <at> lostca.se>
 ;;; Copyright © 2024 Spencer Peters <spencerpeters <at> protonmail.com>
+;;; Copyright © 2024 Thomas Albers Raviola <thomas <at> thomaslabs.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3959,3 +3960,36 @@ (define-public xxkb
 accepts events from XKB.  That means that it will work with the existing
 setup of your X Server without any modifications.")
     (license license:artistic2.0)))
+
+(define-public wtw
+  (let ((commit "a92feab7bb8e354a9136da82c9b716ffd7cdf08b")
+        (revision "0"))
+    (package
+      (name "wtw")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://codeberg.org/sewn/wtw.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0ni06zbrcp7pqidqfa5fr8dzkd84plf8s9y696g2rdmj8fdgynfj"))))
+      (build-system gnu-build-system)
+      (arguments
+       (list #:tests? #f
+             #:make-flags
+             #~(list
+                (string-append "CC=" #$(cc-for-target))
+                (string-append "PREFIX=" %output))
+             #:phases
+             #~(modify-phases %standard-phases
+                 (delete 'configure))))
+      (inputs (list fcft pixman wayland wayland-protocols))
+      (native-inputs (list pkg-config))
+      (synopsis "Simple text widget for wlroot compositors")
+      (description "Simple text widget for wlroot compositors; ported from stw
+and inheriting it's behavior.")
+      (home-page "https://codeberg.org/sewn/wtw")
+      (license license:expat))))
-- 
2.46.0

Message #8 received at 73749 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 73749 <at> debbugs.gnu.org
Cc: Thomas Albers Raviola <thomas <at> thomaslabs.org>
Subject: [PATCH] gnu: Add wtw
Date: Wed, 30 Oct 2024 20:26:42 +0000

[Message part 1 (text/plain, inline)]

Hi Thomas,

Thank you for the patch, please see some review points.

--8<---------------cut here---------------start------------->8---
+(define-public wtw
+  (let ((commit "a92feab7bb8e354a9136da82c9b716ffd7cdf08b")
+        (revision "0"))
--8<---------------cut here---------------end--------------->8---
No release no version tag? If any open issue mentioned that in upstream
please provide, or even open a new one asking about that ;-).

--8<---------------cut here---------------start------------->8---
+      (version (git-version "0" revision commit))
--8<---------------cut here---------------end--------------->8---
"0" -> "0.0.0" if above is not resolved

--8<---------------cut here---------------start------------->8---
+       (list #:tests? #f
--8<---------------cut here---------------end--------------->8---
Please be specific why: failed (short log), no tests, require network 


--8<---------------cut here---------------start------------->8---
+                (string-append "PREFIX=" %output))
--8<---------------cut here---------------end--------------->8---
%output -> #$output


--8<---------------cut here---------------start------------->8---
+                 (delete 'configure))))
--8<---------------cut here---------------end--------------->8---
Be more specific here as well: no configure, failing etc.

--8<---------------cut here---------------start------------->8---
+      (synopsis "Simple text widget for wlroot compositors")
+      (description "Simple text widget for wlroot compositors; ported from stw
+and inheriting it's behavior.")
+      (home-page "https://codeberg.org/sewn/wtw")
--8<---------------cut here---------------end--------------->8---
Some style pick: place home-page before above synopsis, start
description from the new line.


Looking forward for the v2!

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.