GNU bug report logs - #73734
[PATCH] Fix tmm menu layout

Previous Next

Full log

Message #59 received at 73734 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: rudalics <at> gmx.at, 73734 <at> debbugs.gnu.org
Subject: Re: bug#73734: [PATCH] Fix tmm menu layout
Date: Sat, 12 Oct 2024 19:26:41 +0300

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: rudalics <at> gmx.at,  73734 <at> debbugs.gnu.org
> Date: Sat, 12 Oct 2024 17:56:42 +0200
> 
> >>         - What is the purpose of the "(min 30)"?  Because if the window
> >>           is large enough this will always return 30.
> >
> > First, I didn't write this code and don't consider myself an expert,
> > so what follows are basically my guesses.  (In the code I proposed I
> > simply didn't touch those parts to clearly separate my changes from
> > the rest.)
> >
> > I think the minimum of 30 is there to make sure we don't produce just
> > 2 sets of columns when the window is wide enough to allow more.  This
> > uses the screen real estate more efficiently, so the *Completions*
> > window is not as tall as it would be with just 2 sets of columns.
> 
> Ok, that makes sense.  I was under the impression that 30 is too small
> but you're right that it could (should?) stay the same.
> 
> >>         - Should we use frame-width instead of window-width?  It seems
> >>           that when this function is called (get-buffer-window
> >>           "*Completions*") always returns nil.
> >
> > I think we should fall back to frame-width, but use the width of the
> > *Completions* window if it exists.  I'm quite sure there's a sequence
> > of commands which will leave the *Completions* buffer on display, and
> > in that case the window showing it will be reused.
> 
> Alright, so what about this new version of the patch?  FWIW, I have
> tested it lightly and the only time the keybinding alignment is off is
> when menu entry is quite long and we needed the 2 spaces separation with
> the keybinding.

LGTM, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.