GNU bug report logs - #73734
[PATCH] Fix tmm menu layout

Previous Next

Full log

Message #23 received at 73734 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>, Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 73734 <at> debbugs.gnu.org
Subject: Re: bug#73734: [PATCH] Fix tmm menu layout
Date: Fri, 11 Oct 2024 09:29:45 +0200

>> Here, how I justify the modification of `colwidth':
>>
>>        - I don't think we need the "(min 30)" part since, if the frame is
>>          wide enough, we always get a colwidth of 30.
>>
>>        - I don't think "(window-width)" is what we need since, by
>>          default, the *Completions* buffer will use the full frame width.
>
> Martin, is that guaranteed?

I don't think so.  At least we should check whether the buffer window of
the *Completions* buffer satisfies the 'window-full-width-p' predicate.
But (window-width) which, as Manuel later remarks, returns the width of
the selected window, does look like a bad choice here.  I'm not familiar
with tmm.el but would

(window-width (get-buffer-window "*Completions*"))

be wrong here?

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.