GNU bug report logs - #73730
31.0.50; Support for color fonts on MS-Windows

Previous Next

Full log

Message #64 received at 73730 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Cecilio Pardo <cpardo <at> imayhem.com>
Cc: 73730 <at> debbugs.gnu.org
Subject: Re: bug#73730: 31.0.50; Support for color fonts on MS-Windows
Date: Sun, 20 Oct 2024 21:33:09 +0300

> Date: Sun, 20 Oct 2024 20:20:29 +0200
> From: Cecilio Pardo <cpardo <at> imayhem.com>
> 
> On 20/10/2024 18:17, Eli Zaretskii wrote:
> 
> >> If the case of size <= 0, we are now falling back to
> >> w32font_text_extents.
> > 
> > Maybe it's better to use some default size in text_extents instead?
> > The pixel size of the default font is known (see FRAME_LINE_HEIGHT),
> > so maybe just use it if you get a font of size zero?  That could be a
> > more future-proof fix, since we could get such fonts in other
> > situations as well.
> 
> The reason w32fint_text_extents has a value to return is because when 
> the specified font size is 0:
> 
> "The font mapper uses a default height value when it searches for a match."
> 
> So it gives a font with a size that we cannot know, because when we ask 
> it says it is 0.
> 
> So we may return our own default.

I'm not sure I understand the last sentence above.

It should be easy to modify w32-find-non-USB-fonts to specify a
default value for SIZE if the caller didn't provide it.  I just
thought that other callers could do something similar, and therefore
it would be better to use FRAME_LINE_HEIGHT of the selected frame as
the size internally in text_extents if the caller specified zero.  If
what you say above disagrees with that, please elaborate why you
disagree.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.