GNU bug report logs - #73719
[PATCH] Add imenu support for OpenOffice documents in doc-view

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73719 in the body.
You can then email your comments to 73719 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add imenu support for OpenOffice documents in doc-view
Date: Wed, 09 Oct 2024 19:40:39 +0530

[Message part 1 (text/plain, inline)]

Tags: patch

Hi again, Tassilo!

The attached patch adds imenu index support for docx files.  This is
done by simply passing the PDF file to doc-view--pdf-outline.  This
should be the last patch I have in store for doc-view. Many thanks for
your attention thus far.


In GNU Emacs 31.0.50 (build 13, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.18.0, Xaw scroll bars) of 2024-10-06 built on astatine
Repository revision: 500f5da5fb62cd0bbded8df754d93e3147d1d847
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101011
System Description: Debian GNU/Linux trixie/sid

Configured using:
 'configure --with-sound=alsa --with-x-toolkit=lucid --without-xaw3d
 --without-gconf --without-libsystemd --with-cairo CFLAGS=-g3'

[0001-Add-imenu-support-for-OpenOffice-documents-in-doc-vi.patch (text/patch, attachment)]

Message #8 received at 73719 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 73719 <at> debbugs.gnu.org
Subject: Re: bug#73719: [PATCH] Add imenu support for OpenOffice documents
 in doc-view
Date: Thu, 10 Oct 2024 08:53:54 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

Hi Visuwesh,

> The attached patch adds imenu index support for docx files.

docx is M$ Office, isn't it?  But as far as reading your patch tells me,
we do that for all ODF files which are indeed Libre/OpenOffice and
friends.  And, yes, M$ Office files are also handled by the ODF
transformation chain.

Anyway, I think it would be appropriate to speak of "Open Document
Format files as used by LibreOffice and OpenOffice" in the commit
message, NEWS, and the docs simply because the format is used by more
office suits and OpenOffice is mostly dead nowadays, superseded by
LibreOffice.

Otherwise, the patch is fine. :-)

> This should be the last patch I have in store for doc-view. Many
> thanks for your attention thus far.

We thank you, too!  Those were all very nice features. :-)

Bye,
  Tassilo

Message #11 received at 73719 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: 73719 <at> debbugs.gnu.org
Subject: Re: bug#73719: [PATCH] Add imenu support for OpenOffice documents
 in doc-view
Date: Thu, 10 Oct 2024 14:12:46 +0530

[Message part 1 (text/plain, inline)]

[வியாழன் அக்டோபர் 10, 2024] Tassilo Horn wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
> Hi Visuwesh,
>
>> The attached patch adds imenu index support for docx files.
>
> docx is M$ Office, isn't it?  But as far as reading your patch tells me,
> we do that for all ODF files which are indeed Libre/OpenOffice and
> friends.  And, yes, M$ Office files are also handled by the ODF
> transformation chain.

Yes, in the end, they are all marked as odf.  I tested it with a docx
file so I wrote it as it was still in my mind.

> Anyway, I think it would be appropriate to speak of "Open Document
> Format files as used by LibreOffice and OpenOffice" in the commit
> message, NEWS, and the docs simply because the format is used by more
> office suits and OpenOffice is mostly dead nowadays, superseded by
> LibreOffice.
>
> Otherwise, the patch is fine. :-)

Now done in the attached.

[0001-Add-imenu-support-for-ODF-files-in-doc-view.patch (text/x-diff, attachment)]

Message #16 received at 73719-done <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 73719-done <at> debbugs.gnu.org
Subject: Re: bug#73719: [PATCH] Add imenu support for OpenOffice documents
 in doc-view
Date: Thu, 10 Oct 2024 12:37:57 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

> Yes, in the end, they are all marked as odf.  I tested it with a docx
> file so I wrote it as it was still in my mind.

Understandable.

>> Anyway, I think it would be appropriate to speak of "Open Document
>> Format files as used by LibreOffice and OpenOffice" in the commit
>> message, NEWS, and the docs simply because the format is used by more
>> office suits and OpenOffice is mostly dead nowadays, superseded by
>> LibreOffice.
>>
>> Otherwise, the patch is fine. :-)
>
> Now done in the attached.

Thanks!  Tested and pushed.

Bye,
  Tassilo

Message #19 received at 73719-done <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: 73719-done <at> debbugs.gnu.org
Subject: Re: bug#73719: [PATCH] Add imenu support for OpenOffice documents
 in doc-view
Date: Thu, 10 Oct 2024 16:43:03 +0530

[வியாழன் அக்டோபர் 10, 2024] Tassilo Horn wrote:

Great, thank you!

> Visuwesh <visuweshm <at> gmail.com> writes:
>
>> Yes, in the end, they are all marked as odf.  I tested it with a docx
>> file so I wrote it as it was still in my mind.
>
> Understandable.
>
>>> Anyway, I think it would be appropriate to speak of "Open Document
>>> Format files as used by LibreOffice and OpenOffice" in the commit
>>> message, NEWS, and the docs simply because the format is used by more
>>> office suits and OpenOffice is mostly dead nowadays, superseded by
>>> LibreOffice.
>>>
>>> Otherwise, the patch is fine. :-)
>>
>> Now done in the attached.
>
> Thanks!  Tested and pushed.
>
> Bye,
>   Tassilo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.