GNU bug report logs -
#73699
[PATCH] gnu: nzbget: Update to 24.3. [security fixes]
Previous Next
Reported by: Nicolas Graves <ngraves <at> ngraves.fr>
Date: Tue, 8 Oct 2024 08:27:01 UTC
Severity: normal
Tags: patch
Done: Nicolas Graves <ngraves <at> ngraves.fr>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73699 in the body.
You can then email your comments to 73699 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#73699
; Package
guix-patches
.
(Tue, 08 Oct 2024 08:27:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Nicolas Graves <ngraves <at> ngraves.fr>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Tue, 08 Oct 2024 08:27:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
This fixes CVE-2023-49102.
* gnu/packages/networking.scm (nzbget): Update to 24.3.
[build-system]: Switch to cmake-build-system.
[arguments]<configure-flags>: Update field.
[inputs]: Add boost, openssl.
[native-inputs]: Remove pkg-config.
---
gnu/packages/networking.scm | 22 +++++++---------------
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 3be037ecd7..7e28f053f6 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2843,26 +2843,18 @@ (define-public nethogs
(define-public nzbget
(package
(name "nzbget")
- (version "21.1")
+ (version "24.3")
(source
(origin
(method url-fetch)
- (uri (string-append "https://github.com/nzbget/nzbget/releases"
- "/download/v" version
- "/nzbget-" version "-src.tar.gz"))
+ (uri (string-append "https://github.com/nzbgetcom/nzbget/archive/v"
+ version ".tar.gz"))
(sha256
- (base32 "09900x1k0yf4yi2cc0k093advvadyhrkm8rnd8nszhhdp2zc33sf"))))
+ (base32 "1h3w1g6b52pj43v9cgcdfjal2lc1dqclhyik02zmz0k72gdg03xj"))))
+ (build-system cmake-build-system)
(arguments
- `(#:configure-flags
- (list
- (string-append "--with-libcurses-includes="
- (assoc-ref %build-inputs "ncurses") "/include")
- (string-append "--with-libcurses-libraries="
- (assoc-ref %build-inputs "ncurses") "/lib")
- (string-append "--with-tlslib=GnuTLS"))))
- (build-system gnu-build-system)
- (inputs (list gnutls libxml2 ncurses zlib))
- (native-inputs (list pkg-config))
+ (list #:configure-flags '(list "-DENABLE_TESTS=1")))
+ (inputs (list boost gnutls libxml2 ncurses openssl zlib))
(home-page "https://github.com/nzbget/nzbget")
(synopsis "Usenet binary file downloader")
(description
--
2.46.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#73699
; Package
guix-patches
.
(Wed, 16 Oct 2024 05:20:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 73699 <at> debbugs.gnu.org (full text, mbox):
This fixes CVE-2023-49102.
* gnu/packages/networking.scm (nzbget): Update to 24.3.
[source]: Switch to git-fetch.
[build-system]: Switch to cmake-build-system.
[arguments]<configure-flags>: Update field.
[inputs]: Add boost, openssl.
[native-inputs]: Remove pkg-config, add which.
---
gnu/packages/networking.scm | 27 +++++++++++----------------
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index f209c1e27c..79d3859eb1 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2843,26 +2843,21 @@ (define-public nethogs
(define-public nzbget
(package
(name "nzbget")
- (version "21.1")
+ (version "24.3")
(source
(origin
- (method url-fetch)
- (uri (string-append "https://github.com/nzbget/nzbget/releases"
- "/download/v" version
- "/nzbget-" version "-src.tar.gz"))
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/nzbgetcom/nzbget")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
(sha256
- (base32 "09900x1k0yf4yi2cc0k093advvadyhrkm8rnd8nszhhdp2zc33sf"))))
+ (base32 "13hakpkxqvqfjhk679l088209f54j7mqi3ifi820lyz6b1nvvj0r"))))
+ (build-system cmake-build-system)
(arguments
- `(#:configure-flags
- (list
- (string-append "--with-libcurses-includes="
- (assoc-ref %build-inputs "ncurses") "/include")
- (string-append "--with-libcurses-libraries="
- (assoc-ref %build-inputs "ncurses") "/lib")
- (string-append "--with-tlslib=GnuTLS"))))
- (build-system gnu-build-system)
- (inputs (list gnutls libxml2 ncurses zlib))
- (native-inputs (list pkg-config))
+ (list #:configure-flags '(list "-DENABLE_TESTS=1")))
+ (inputs (list boost gnutls libxml2 ncurses openssl zlib))
+ (native-inputs (list which))
(home-page "https://github.com/nzbget/nzbget")
(synopsis "Usenet binary file downloader")
(description
--
2.46.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#73699
; Package
guix-patches
.
(Thu, 17 Oct 2024 05:04:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 73699 <at> debbugs.gnu.org (full text, mbox):
This fixes CVE-2023-49102.
* gnu/packages/networking.scm (nzbget): Update to 24.3.
[source]: Switch to git-fetch.
[build-system]: Switch to cmake-build-system.
[arguments]<configure-flags>: Update field.
[inputs]: Add boost, openssl.
[native-inputs]: Remove pkg-config, add which.
---
gnu/packages/networking.scm | 27 +++++++++++----------------
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index f209c1e27c..79d3859eb1 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2843,26 +2843,21 @@ (define-public nethogs
(define-public nzbget
(package
(name "nzbget")
- (version "21.1")
+ (version "24.3")
(source
(origin
- (method url-fetch)
- (uri (string-append "https://github.com/nzbget/nzbget/releases"
- "/download/v" version
- "/nzbget-" version "-src.tar.gz"))
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/nzbgetcom/nzbget")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
(sha256
- (base32 "09900x1k0yf4yi2cc0k093advvadyhrkm8rnd8nszhhdp2zc33sf"))))
+ (base32 "13hakpkxqvqfjhk679l088209f54j7mqi3ifi820lyz6b1nvvj0r"))))
+ (build-system cmake-build-system)
(arguments
- `(#:configure-flags
- (list
- (string-append "--with-libcurses-includes="
- (assoc-ref %build-inputs "ncurses") "/include")
- (string-append "--with-libcurses-libraries="
- (assoc-ref %build-inputs "ncurses") "/lib")
- (string-append "--with-tlslib=GnuTLS"))))
- (build-system gnu-build-system)
- (inputs (list gnutls libxml2 ncurses zlib))
- (native-inputs (list pkg-config))
+ (list #:configure-flags '(list "-DENABLE_TESTS=1")))
+ (inputs (list boost gnutls libxml2 ncurses openssl zlib))
+ (native-inputs (list which))
(home-page "https://github.com/nzbget/nzbget")
(synopsis "Usenet binary file downloader")
(description
--
2.46.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#73699
; Package
guix-patches
.
(Thu, 17 Oct 2024 05:04:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 73699 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/networking.scm (nzbget)[arguments]<#:phases>:
Ignore a misconfigured test on aarch64.
---
gnu/packages/networking.scm | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 79d3859eb1..590a9fdeff 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2855,7 +2855,16 @@ (define-public nzbget
(base32 "13hakpkxqvqfjhk679l088209f54j7mqi3ifi820lyz6b1nvvj0r"))))
(build-system cmake-build-system)
(arguments
- (list #:configure-flags '(list "-DENABLE_TESTS=1")))
+ (append (list #:configure-flags '(list "-DENABLE_TESTS=1"))
+ (if (target-aarch64?)
+ (list #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'skip-failing-tests
+ (lambda _
+ (substitute* "tests/system/CMakeLists.txt"
+ (("(.*)SystemInfo.cpp" all)
+ (string-append "#" all)))))))
+ #~((list)))))
(inputs (list boost gnutls libxml2 ncurses openssl zlib))
(native-inputs (list which))
(home-page "https://github.com/nzbget/nzbget")
--
2.46.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#73699
; Package
guix-patches
.
(Thu, 17 Oct 2024 05:41:01 GMT)
Full text and
rfc822 format available.
Message #17 received at 73699 <at> debbugs.gnu.org (full text, mbox):
This fixes CVE-2023-49102.
* gnu/packages/networking.scm (nzbget): Update to 24.3.
[source]: Switch to git-fetch.
[build-system]: Switch to cmake-build-system.
[arguments]<configure-flags>: Update field.
[inputs]: Add boost, openssl.
[native-inputs]: Remove pkg-config, add which.
---
gnu/packages/networking.scm | 27 +++++++++++----------------
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index f209c1e27c..79d3859eb1 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2843,26 +2843,21 @@ (define-public nethogs
(define-public nzbget
(package
(name "nzbget")
- (version "21.1")
+ (version "24.3")
(source
(origin
- (method url-fetch)
- (uri (string-append "https://github.com/nzbget/nzbget/releases"
- "/download/v" version
- "/nzbget-" version "-src.tar.gz"))
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/nzbgetcom/nzbget")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
(sha256
- (base32 "09900x1k0yf4yi2cc0k093advvadyhrkm8rnd8nszhhdp2zc33sf"))))
+ (base32 "13hakpkxqvqfjhk679l088209f54j7mqi3ifi820lyz6b1nvvj0r"))))
+ (build-system cmake-build-system)
(arguments
- `(#:configure-flags
- (list
- (string-append "--with-libcurses-includes="
- (assoc-ref %build-inputs "ncurses") "/include")
- (string-append "--with-libcurses-libraries="
- (assoc-ref %build-inputs "ncurses") "/lib")
- (string-append "--with-tlslib=GnuTLS"))))
- (build-system gnu-build-system)
- (inputs (list gnutls libxml2 ncurses zlib))
- (native-inputs (list pkg-config))
+ (list #:configure-flags '(list "-DENABLE_TESTS=1")))
+ (inputs (list boost gnutls libxml2 ncurses openssl zlib))
+ (native-inputs (list which))
(home-page "https://github.com/nzbget/nzbget")
(synopsis "Usenet binary file downloader")
(description
--
2.46.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#73699
; Package
guix-patches
.
(Thu, 17 Oct 2024 05:41:02 GMT)
Full text and
rfc822 format available.
Message #20 received at 73699 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/networking.scm (nzbget)[arguments]<#:phases>:
Ignore a misconfigured test on aarch64.
---
gnu/packages/networking.scm | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 79d3859eb1..b75aa078ff 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2855,7 +2855,16 @@ (define-public nzbget
(base32 "13hakpkxqvqfjhk679l088209f54j7mqi3ifi820lyz6b1nvvj0r"))))
(build-system cmake-build-system)
(arguments
- (list #:configure-flags '(list "-DENABLE_TESTS=1")))
+ (append (list #:configure-flags '(list "-DENABLE_TESTS=1"))
+ (if (string-prefix? "aarch64" (%current-system))
+ (list #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'skip-failing-tests
+ (lambda _
+ (substitute* "tests/system/CMakeLists.txt"
+ (("(.*)SystemInfo.cpp" all)
+ (string-append "#" all)))))))
+ #~((list)))))
(inputs (list boost gnutls libxml2 ncurses openssl zlib))
(native-inputs (list which))
(home-page "https://github.com/nzbget/nzbget")
--
2.46.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#73699
; Package
guix-patches
.
(Fri, 18 Oct 2024 09:48:02 GMT)
Full text and
rfc822 format available.
Message #23 received at 73699 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi,
Thanks for the patch.
I could build v4 1/1 patch without disabling system tests on aarch64
--8<---------------cut here---------------start------------->8---
./pre-inst-env guix build nzbget --system=aarch64-linux
/gnu/store/cdjbbx3iyrmglg9pbvmb8645bcxv1x33-nzbget-24.3
--8<---------------cut here---------------end--------------->8---
May you provide some reasoning or error log what you see on your end
please?
--
Oleg
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#73699
; Package
guix-patches
.
(Fri, 18 Oct 2024 10:26:01 GMT)
Full text and
rfc822 format available.
Message #26 received at 73699 <at> debbugs.gnu.org (full text, mbox):
On 2024-10-18 10:45, Sharlatan Hellseher wrote:
> Hi,
>
> Thanks for the patch.
>
> I could build v4 1/1 patch without disabling system tests on aarch64
> --8<---------------cut here---------------start------------->8---
> ./pre-inst-env guix build nzbget --system=aarch64-linux
> /gnu/store/cdjbbx3iyrmglg9pbvmb8645bcxv1x33-nzbget-24.3
> --8<---------------cut here---------------end--------------->8---
>
> May you provide some reasoning or error log what you see on your end
> please?
I only relied on QA, which was indicating a failure for this test,
without much more information about why it was failing. IIRC, the
xmlResult was indicating <string></string> instead of <string/> for some
system info (so something is read as an empty string rather than NULL or
something like that probably). It seemed harmless anyway so I proceeded
to ignore the test without much further inquiry.
I still have it in my browser history, here's the link if you want to
investigate further:
https://bordeaux.guix.gnu.org/build/dc3bac03-ee3e-4263-8332-773620005c8c/log
>
> --
> Oleg
--
Best regards,
Nicolas Graves
Information forwarded
to
guix-patches <at> gnu.org
:
bug#73699
; Package
guix-patches
.
(Sun, 20 Oct 2024 15:44:02 GMT)
Full text and
rfc822 format available.
Message #29 received at 73699 <at> debbugs.gnu.org (full text, mbox):
This fixes CVE-2023-49102.
* gnu/packages/networking.scm (nzbget): Update to 24.3.
[source]: Switch to git-fetch.
[build-system]: Switch to cmake-build-system.
[arguments]<configure-flags>: Update field.
[inputs]: Add boost, openssl.
[native-inputs]: Remove pkg-config, add which.
---
gnu/packages/networking.scm | 27 +++++++++++----------------
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index f209c1e27c..79d3859eb1 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2843,26 +2843,21 @@ (define-public nethogs
(define-public nzbget
(package
(name "nzbget")
- (version "21.1")
+ (version "24.3")
(source
(origin
- (method url-fetch)
- (uri (string-append "https://github.com/nzbget/nzbget/releases"
- "/download/v" version
- "/nzbget-" version "-src.tar.gz"))
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/nzbgetcom/nzbget")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
(sha256
- (base32 "09900x1k0yf4yi2cc0k093advvadyhrkm8rnd8nszhhdp2zc33sf"))))
+ (base32 "13hakpkxqvqfjhk679l088209f54j7mqi3ifi820lyz6b1nvvj0r"))))
+ (build-system cmake-build-system)
(arguments
- `(#:configure-flags
- (list
- (string-append "--with-libcurses-includes="
- (assoc-ref %build-inputs "ncurses") "/include")
- (string-append "--with-libcurses-libraries="
- (assoc-ref %build-inputs "ncurses") "/lib")
- (string-append "--with-tlslib=GnuTLS"))))
- (build-system gnu-build-system)
- (inputs (list gnutls libxml2 ncurses zlib))
- (native-inputs (list pkg-config))
+ (list #:configure-flags '(list "-DENABLE_TESTS=1")))
+ (inputs (list boost gnutls libxml2 ncurses openssl zlib))
+ (native-inputs (list which))
(home-page "https://github.com/nzbget/nzbget")
(synopsis "Usenet binary file downloader")
(description
--
2.46.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#73699
; Package
guix-patches
.
(Sun, 20 Oct 2024 15:44:02 GMT)
Full text and
rfc822 format available.
Message #32 received at 73699 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/networking.scm (nzbget)[arguments]<#:phases>:
Ignore a misconfigured test on aarch64.
---
gnu/packages/networking.scm | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 79d3859eb1..a98f11268a 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2855,7 +2855,16 @@ (define-public nzbget
(base32 "13hakpkxqvqfjhk679l088209f54j7mqi3ifi820lyz6b1nvvj0r"))))
(build-system cmake-build-system)
(arguments
- (list #:configure-flags '(list "-DENABLE_TESTS=1")))
+ (append (list #:configure-flags '(list "-DENABLE_TESTS=1"))
+ (if (string=? "aarch64-linux" (%current-system))
+ (list #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'skip-failing-tests
+ (lambda _
+ (substitute* "tests/system/CMakeLists.txt"
+ (("(.*)SystemInfo.cpp" all)
+ (string-append "#" all)))))))
+ '())))
(inputs (list boost gnutls libxml2 ncurses openssl zlib))
(native-inputs (list which))
(home-page "https://github.com/nzbget/nzbget")
--
2.46.0
bug closed, send any further explanations to
73699 <at> debbugs.gnu.org and Nicolas Graves <ngraves <at> ngraves.fr>
Request was from
Nicolas Graves <ngraves <at> ngraves.fr>
to
control <at> debbugs.gnu.org
.
(Tue, 12 Nov 2024 17:07:03 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Wed, 11 Dec 2024 12:24:17 GMT)
Full text and
rfc822 format available.
This bug report was last modified 247 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.