GNU bug report logs - #73692
[PATCH] gnu: timescaledb: Update to 2.16.1. [security fixes]

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Z572 <zhengjunjie <at> iscas.ac.cn>, 73692 <at> debbugs.gnu.org
Subject: [bug#73692] [PATCH v2] gnu: timescaledb: Ignore failing tests.
Date: Wed, 16 Oct 2024 19:19:18 +0200

On 2024-10-16 20:28, Z572 wrote:

> Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> * gnu/packages/databases.scm (timescaledb):
>> [arguments]<#:phases>: Add phase 'patch-failing-tests.
>> ---
>>  gnu/packages/databases.scm | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
>> index 43ec0641a0..80163cfdc0 100644
>> --- a/gnu/packages/databases.scm
>> +++ b/gnu/packages/databases.scm
>> @@ -1502,6 +1502,21 @@ (define-public timescaledb
>>                               "-o" (string-append "-k " pg-data)
>>                               "-l" (string-append pg-data "/db.log")
>>                               "start"))))
>> +               #$@(if (not (target-x86-64?))
>> +                      #~((add-after 'unpack 'patch-failing-tests
>> +                           (lambda _
>> +                             (substitute* "test/CMakeLists.txt"
>> +                               (((format
>> +                                  #f "(~{~a|~})"
>
> I think it's best to keep it simple and not use overly complex
> features.

I agree but this bit is indeed particularly tricky. I can move from
complex format to string-append + string-join, from cons* to append
list, and drop the not, but ultimately I feel selectively ignoring tests
by system is complex in itself. Let's see what QA says, then simplify
that, but if you have a better solution, don't hesitate to put it
forward ;)

>
>> +                                  (cons*
>> +                                   "histogram_test\\.sql\\.in"
>> +                                   #$@(if (target-aarch64?)
>> +                                          #~((list "append\\.sql\\.in"
>> +                                                   "chunk_adaptative\\.sql"))
>> +                                          #~((list)))))
>> +                                 all)
>> +                                (string-append "#" all))))))
>> +                      #~())
>>                 (add-after 'prepare-tests 'check
>>                   (assoc-ref %standard-phases 'check)))))
>>      (inputs (list openssl postgresql))

-- 
Best regards,
Nicolas Graves

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.