Subject: Re: [bug#73692] [PATCH v2] gnu: timescaledb: Ignore failing tests.

From: Z572 <[email-masked]>
Date: Wed, 16 Oct 2024 20:28:48 +0800

Nicolas Graves via Guix-patches via <[email-masked]> writes:

> * gnu/packages/databases.scm (timescaledb):
> [arguments]<#:phases>: Add phase 'patch-failing-tests.
> ---
>  gnu/packages/databases.scm | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index 43ec0641a0..80163cfdc0 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -1502,6 +1502,21 @@ (define-public timescaledb
>                               "-o" (string-append "-k " pg-data)
>                               "-l" (string-append pg-data "/db.log")
>                               "start"))))
> +               #$@(if (not (target-x86-64?))
> +                      #~((add-after 'unpack 'patch-failing-tests
> +                           (lambda _
> +                             (substitute* "test/CMakeLists.txt"
> +                               (((format
> +                                  #f "(~{~a|~})"

I think it's best to keep it simple and not use overly complex
features.

> +                                  (cons*
> +                                   "histogram_test\\.sql\\.in"
> +                                   #$@(if (target-aarch64?)
> +                                          #~((list "append\\.sql\\.in"
> +                                                   "chunk_adaptative\\.sql"))
> +                                          #~((list)))))
> +                                 all)
> +                                (string-append "#" all))))))
> +                      #~())
>                 (add-after 'prepare-tests 'check
>                   (assoc-ref %standard-phases 'check)))))
>      (inputs (list openssl postgresql))