From unknown Sat Aug 16 20:07:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73686 <73686@debbugs.gnu.org> To: bug#73686 <73686@debbugs.gnu.org> Subject: Status: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces Reply-To: bug#73686 <73686@debbugs.gnu.org> Date: Sun, 17 Aug 2025 03:07:52 +0000 retitle 73686 31.0.50; ERC 5.6.1-git: back button gone from describe-face v= ia erc-nicks-list-faces reassign 73686 emacs submitter 73686 "J.P." severity 73686 normal tag 73686 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 22:48:01 2024 Received: (at submit) by debbugs.gnu.org; 8 Oct 2024 02:48:01 +0000 Received: from localhost ([127.0.0.1]:49896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy0GW-0005n5-JT for submit@debbugs.gnu.org; Mon, 07 Oct 2024 22:48:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:39636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy0GU-0005mw-34 for submit@debbugs.gnu.org; Mon, 07 Oct 2024 22:47:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sy0GL-0006LE-Oh for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2024 22:47:49 -0400 Received: from mail-108-mta28.mxroute.com ([136.175.108.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sy0GJ-00008t-LH for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2024 22:47:49 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta28.mxroute.com (ZoneMTA) with ESMTPSA id 1926a067f830003e01.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 08 Oct 2024 02:47:43 +0000 X-Zone-Loop: b01f6c1e887d0cdca3e3ea37849abe3bf9d2b3df0bf3 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CT2Drxr6z/JlrkMKq4dpCAX9YcMS9dQCa1aOjoKMhVc=; b=ar0LEDWfhE8jNROkriF3yloAWx SRwWh/HqyBLFtSzZg0adDifOpu4GQi3LuWQteRBDsX+ePJIHXaF8JEY3GYsNQ8nMfPQKMUJO2n4Yx Lcf/EQKLqPGm46+DJwnaeZpBEGLbwfD3MlPK5hcNzvp4+wNFlE9g9wcOGzjZAYmuHj7h5212iTZ7M rc7p6qqb7KJhtVU7lK6UrwUFFwRGJmaNk6FwpWC6RMMJ8Jwwy/lq1pX3Tr9NwMqdF/G4oTT/pt7Wz ACfZIFvDToYRs5TnhzJXl+6eRVjQBKhqugieS6OZMi6ZMiXyS9fACmvsLIEr7Kp+6za5XFAuTPMH1 ciTFxQGg==; From: "J.P." To: bug-gnu-emacs@gnu.org Subject: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces X-Debbugs-CC: emacs-erc@gnu.org Date: Mon, 07 Oct 2024 19:47:41 -0700 Message-ID: <875xq38g4y.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.28; envelope-from=jp@neverwas.me; helo=mail-108-mta28.mxroute.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) The test `erc-nicks-list-faces' in test/lisp/erc/erc-nicks-tests.el now fails [1]. This appears to be related to a recent change involving the killing of local variables in `help-setup-xref'. e776df2a3eae0454ea85287e15ebba649bf8e918 is the first bad commit commit e776df2a3eae0454ea85287e15ebba649bf8e918 Author: Dmitry Gutov Date: Sun Oct 6 04:31:31 2024 +0300 help-setup-xref: Keep the local values only of some variables ,* lisp/help-mode.el (help-setup-xref): Kill all local variables, saving ones that are known to need to be preserved (bug#73637). lisp/help-mode.el | 37 +++++++++++++------------------------ 1 file changed, 13 insertions(+), 24 deletions(-) The change also affects `list-faces-display' in faces.el, which `erc-nicks-list-faces' depends on. >From emacs -Q: 1. M-x list-faces-display RET 2. TAB TAB RET C-x o (but see below*) 3. l -> (user-error "No previous help buffer") Regarding (2), the Help buffer now opens in a split whereas before it opened in the current window. The failing test expects the old behavior but obviously doesn't have to for Emacs 31+. (That is to say we should ensure the command still works and the test still passes on older Emacs versions.) I may not be able to look into this for a few days. Just filing a bug now so folks will see it's been spotted. Thanks. [1] https://emba.gnu.org/emacs/emacs/-/jobs/90900/raw In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) of 2024-10-07 built on localhost Repository revision: ff4de9eff30ade164655354f71e7cbca48135858 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12401002 System Description: Fedora Linux 40 (Workstation Edition) Configured using: 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3' PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: ERC Minor modes in effect: erc-truncate-mode: t erc-track-mode: t erc-track-minor-mode: t erc-ring-mode: t erc-nicks-mode: t erc-netsplit-mode: t erc-menu-mode: t erc-match-mode: t erc-list-mode: t erc-irccontrols-mode: t erc-keep-place-indicator-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t erc-scrolltobottom-mode: t erc-imenu-mode: t erc-pcomplete-mode: t erc-button-mode: t erc-fill-wrap-mode: t erc-fill-mode: t erc-stamp--date-mode: t erc-stamp--display-margin-mode: t erc-stamp-mode: t erc-autojoin-mode: t erc-networks-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t visual-line-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message yank-media dired dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils facemenu help-fns radix-tree mule-util compile text-property-search comp-run comp-common network-stream puny nsm erc-truncate erc-track erc-ring erc-nicks color erc-netsplit erc-menu erc-match erc-list erc-goodies erc-imenu imenu erc-pcomplete time-date pcomplete comint ansi-osc ansi-color ring erc-button browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util url-parse url-vars mailcap erc-fill erc-stamp erc-join cus-edit pp wid-edit view cus-start cus-load erc derived auth-source eieio eieio-core icons password-cache json map format-spec erc-backend erc-networks easy-mmode byte-opt bytecomp byte-compile erc-common inline cl-extra help-mode erc-compat cl-seq cl-macs gv pcase rx compat subr-x cl-loaddefs cl-lib erc-loaddefs rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 310654 14020) (symbols 48 15823 0) (strings 32 41880 7379) (string-bytes 1 1446301) (vectors 16 22633) (vector-slots 8 247090 18865) (floats 8 201 7029) (intervals 56 5336 0) (buffers 984 20)) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 02:06:41 2024 Received: (at 73686) by debbugs.gnu.org; 8 Oct 2024 06:06:41 +0000 Received: from localhost ([127.0.0.1]:50341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy3Mm-0008UH-Ub for submit@debbugs.gnu.org; Tue, 08 Oct 2024 02:06:41 -0400 Received: from mail-108-mta142.mxroute.com ([136.175.108.142]:44251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy3Mk-0008U9-Ut for 73686@debbugs.gnu.org; Tue, 08 Oct 2024 02:06:39 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta142.mxroute.com (ZoneMTA) with ESMTPSA id 1926abc6ea30003e01.001 for <73686@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 08 Oct 2024 06:06:26 +0000 X-Zone-Loop: a274366291f85970fde00a69556856ed4dd911d5b1fd X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hOxRwMXvSr7/Py51iIT99f+YY+u+7wWzXVf1YNjV73w=; b=c69vgdFz+hxyF2tgbTc1hrYe+U s1YjtLLQrPmeM620/knbL7TKPojUyS6G7hULkiVoOhxUwtc78d8OdPILDmQU+JQODitjgFPLMMlai J77HirbCsVM9ktewJ2QxyVSRRF0k1ONxMMgOo75nVo8DxeswKGMfosh/dXb5Zt1RC+PmMqLbfse04 WD2f7vLE6F0RefwOTkBpCkkvbqWJ/oCqf5lAZlPrfJwcqmJw4P6IpsOwEDH2sqHQAEpse6qXKfWUa moXD2BKAo5bItUkSBB5mVdWg7UF6Pp76cxf3HkpoNkad6ZNSK2+VwWjosJK+7PWRRvRjo87f5sRkE Iv6jifbg==; From: "J.P." To: 73686@debbugs.gnu.org Subject: Re: bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces In-Reply-To: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> (J. P.'s message of "Mon, 07 Oct 2024 19:47:41 -0700") References: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> Date: Mon, 07 Oct 2024 23:06:20 -0700 Message-ID: <87ttdn5dsz.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73686 Cc: emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "J.P." writes: > This appears to be related to a recent change involving the killing of > local variables in `help-setup-xref'. Poking around some, it seems the various `describe-*' commands in help-fns.el run `help-setup-xref' before doing (with-help-window (help-buffer) ...) And because `major-mode' is buffer-local, it gets wiped out with these latest changes before `help-buffer' ever sees it: (defun help-buffer () (buffer-name (if (and help-xref-following (derived-mode-p 'help-mode)) (current-buffer) (get-buffer-create "*Help*")))) (Here, `help-xref-following' is t thanks to `help-do-xref'.) > Regarding (2), the Help buffer now opens in a split whereas before it > opened in the current window. The failing test expects the old behavior This appears to happen when the `help-mode' (turned `fundamental-mode') buffer from which `describe-*' is run isn't named `*Help*', as is the case with `list-faces-display' and `erc-nicks-list-faces'. As for fixing this, I wonder if we can somehow expand the role of `help-buffer-under-preparation' (or `help-xref-following') so that instead of t, it's bound to the last value of `major-mode' prior to `help-setup-xref' running. And then `help-buffer' could first check this stashed value before considering the current `major-mode' (like via `provided-mode-derived-p' or whatever). From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 17:08:06 2024 Received: (at 73686) by debbugs.gnu.org; 8 Oct 2024 21:08:06 +0000 Received: from localhost ([127.0.0.1]:54688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syHR8-0006bk-1J for submit@debbugs.gnu.org; Tue, 08 Oct 2024 17:08:06 -0400 Received: from mail-108-mta59.mxroute.com ([136.175.108.59]:34107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syHR3-0006bH-94 for 73686@debbugs.gnu.org; Tue, 08 Oct 2024 17:08:05 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta59.mxroute.com (ZoneMTA) with ESMTPSA id 1926df5a6c20003e01.001 for <73686@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 08 Oct 2024 21:07:48 +0000 X-Zone-Loop: 41f4f2afea1a29c004f5044b151e694ae4c16a99b770 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cfg4p47W7woUGhczfOxGWusSXPDd7y3ownSpGdJPTtA=; b=MpDDqrNPxxoXuXekvGOmz7Jsln iPZZ/NhvMX15+tC6i3/XzmsnjNHWlnG/IFApYkCCg6bxowMG6geqChU3Kuso6a4noe7CA7JkKaZ1f DSotUpkAd2uRu9DKwTOGdPVktlwaKJVV/tsKl1HCI+t6fNw+OMDrQlJRTg69UykHzlTV0q6l7FYRM gXvwNhmKc/tLN/de/6jDB7aQSGB7QUKTqRQxed/eV38U6smaWav2X9zsXhk007KJkf215t+KFZC5Z aIe5HIt9KVU6IE7/rpti5rpLL0Q0c0nYQc9NPq0kyEwgKcxvmOe/+//2EljUJXT+HMqEEE6pb2PDo CSDytuOg==; From: "J.P." To: 73686@debbugs.gnu.org Subject: Re: bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces In-Reply-To: <87ttdn5dsz.fsf@neverwas.me> (J. P.'s message of "Mon, 07 Oct 2024 23:06:20 -0700") References: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> <87ttdn5dsz.fsf@neverwas.me> Date: Tue, 08 Oct 2024 14:07:46 -0700 Message-ID: <87y12y1exp.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73686 Cc: emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Small correction: > From emacs -Q: > 1. M-x list-faces-display RET > 2. TAB TAB RET C-x o (but see below*) ^ Missing a C-x o here in the original recipe. So I doubt this is directly related, but I'm noticing another peculiarity regarding help buffers not named `*Help*'. As you'd expect, going back via a back button replaces the window buffer with the previous one. And though typing "l" does that as well, it also re-creates the previous buffer in a new window, resulting in different buffers with the same content (the new one being the default "*Help*"). >From emacs -Q (on Emacs 30): 1. M-x list-faces-display RET 2. C-x o TAB TAB RET 3. In the help buffer for `abbrev-table-name': RET 4. In the help buffer for `font-lock-function-name-face': RET 5. Back in `abbrev-table-name': TAB RET (should take you back to "*Faces*") Now start a new session, repeating 1-3. For 4, hit "l" instead, and witness the unwanted default "*Help*" buffer pop up in another window. Superficially, I think the disparity results from `help-xref-following' being t in the base recipe (at the hands of `help-do-xref'): * help-xref-go-back(#) help-do-xref(nil help-xref-go-back (#)) help-button-action(#) button-activate(# nil) push-button(751) Which allows for buffer reuse in `help-buffer'. No such arrangement occurs with the "l" variant: * help-xref-go-back(#) help-go-back() funcall-interactively(help-go-back) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 19:41:20 2024 Received: (at 73686) by debbugs.gnu.org; 8 Oct 2024 23:41:21 +0000 Received: from localhost ([127.0.0.1]:54878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syJpQ-0006P1-CR for submit@debbugs.gnu.org; Tue, 08 Oct 2024 19:41:20 -0400 Received: from mail-108-mta77.mxroute.com ([136.175.108.77]:43837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syJpO-0006Oq-FD for 73686@debbugs.gnu.org; Tue, 08 Oct 2024 19:41:19 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta77.mxroute.com (ZoneMTA) with ESMTPSA id 1926e8204e30003e01.001 for <73686@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 08 Oct 2024 23:41:07 +0000 X-Zone-Loop: 17090254d5e18defeabaf731d0ddf82e5eb8a0487112 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kWyZGxZSzOrRqQYVvi5y9CnA6bRagEOp0DPejvWmYTY=; b=dWO8EfHITQm2o3mlJV5M15IoqB PMe5LHqE+1O+bERGYXyqpbXrD4PmHOSR/ctpf7hDUMZse3ynXZveOyKJ11uUz/Mg1XnfGHMwDHJQr zv7FQtGJBY0ZuVC0qXCZZJHOcIpriLyAS5Kiyw+6UZxncOSPpORGILo8++E3GMnQc+udYaPKPp+9v DaEdmLwt/A6uy5cOleFKei1xQbCJxdKh1f6j6m+YwtDWbJZKwAnfE1tsh8GTqJcg5/UMM3ucSDhgz JC3bRihQ68aoMZ1WiE9ldNtOEkFUcJXk8eOYYOnbCMqkgL5MT2ZA3qgxixRr6e70LTaiiy4gH+Gp+ LFReu0zA==; From: "J.P." To: 73686@debbugs.gnu.org Subject: Re: bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces In-Reply-To: <87y12y1exp.fsf@neverwas.me> (J. P.'s message of "Tue, 08 Oct 2024 14:07:46 -0700") References: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> <87ttdn5dsz.fsf@neverwas.me> <87y12y1exp.fsf@neverwas.me> Date: Tue, 08 Oct 2024 16:41:04 -0700 Message-ID: <87o73uyxgv.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73686 Cc: emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain The attached PoC patch blindly tries to implement the approach loosely theorized about in previous posts. While it seems to solve the issue at hand (in a vacuum), it may well introduce others because I know basically nothing about the help system and how it's meant to work. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-POC-Overload-help-xref-following-for-non-default-hel.patch >From 8acedc71dc1344daac90a79378dad894dcd98bab Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Tue, 8 Oct 2024 15:58:49 -0700 Subject: [PATCH] [POC] Overload help-xref-following for non-default help buffers * lisp/help-mode.el (help-xref-following): Mention in doc that value may be the symbol of a major mode. (help-buffer): When the current buffer is in `fundamental-mode', check to see if the value of `help-xref-following' is the symbol of a major mode deriving from `help-mode' and `help-buffer-under-preparation' is non-nil. If so, return the current buffer. (help-xref-go-back, help-xref-go-forward): Use `help-do-xref' instead of `apply' to call methods. (help-do-xref): Bind `help-xref-following' to the value of `major-mode' instead of t. * test/lisp/help-mode-tests.el (help-mode-tests-help-buffer-current-buffer): Add case for `help-xref-following' being a major-mode rather than t. (Bug#73686) --- lisp/help-mode.el | 23 +++++++++++++++-------- test/lisp/help-mode-tests.el | 14 +++++++++++++- 2 files changed, 28 insertions(+), 9 deletions(-) diff --git a/lisp/help-mode.el b/lisp/help-mode.el index 4ee4f4156a1..f704098b2dc 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -516,19 +516,26 @@ help-setup-xref (setq help-xref-stack-item item))) (defvar help-xref-following nil - "Non-nil when following a help cross-reference.") + "Non-nil when following a help cross-reference. +May be the value of `major-mode' when an instigating button was clicked.") ;;;###autoload (defun help-buffer () "Return the name of a buffer for inserting help. -If `help-xref-following' is non-nil and the current buffer is -derived from `help-mode', this is the name of the current buffer. - +If `help-xref-following' is t and the current buffer is derived from +`help-mode', return the current buffer's name. As a special case, also +do so if these three conditions are met: `help-xref-following' is the +symbol of a major mode deriving from `help-mode', the current buffer is +in `fundamental-mode', and `help-buffer-under-preparation' is non-nil. Otherwise, return \"*Help*\", creating a buffer with that name if it does not already exist." (buffer-name ;for with-output-to-temp-buffer (if (and help-xref-following - (derived-mode-p 'help-mode)) + (if (or (eq help-xref-following t) + (not (and help-buffer-under-preparation + (eq major-mode 'fundamental-mode)))) + (derived-mode-p 'help-mode) ; current buffer + (provided-mode-derived-p help-xref-following '(help-mode)))) (current-buffer) (get-buffer-create "*Help*")))) @@ -792,7 +799,7 @@ help-xref-go-back position (car item) method (cadr item) args (cddr item)))) - (apply method args) + (help-do-xref nil method args) (with-current-buffer buffer (if (get-buffer-window buffer) (set-window-point (get-buffer-window buffer) position) @@ -812,7 +819,7 @@ help-xref-go-forward position (car item) method (cadr item) args (cddr item)))) - (apply method args) + (help-do-xref nil method args) (with-current-buffer buffer (if (get-buffer-window buffer) (set-window-point (get-buffer-window buffer) position) @@ -894,7 +901,7 @@ help-do-xref Things are set up properly so that the resulting help buffer has a proper [back] button." ;; There is a reference at point. Follow it. - (let ((help-xref-following t)) + (let ((help-xref-following major-mode)) (apply function (if (eq function 'info) (append args (list (generate-new-buffer-name "*info*"))) args)))) diff --git a/test/lisp/help-mode-tests.el b/test/lisp/help-mode-tests.el index 2e64b12732e..968ed7da72e 100644 --- a/test/lisp/help-mode-tests.el +++ b/test/lisp/help-mode-tests.el @@ -39,7 +39,19 @@ help-mode-tests-help-buffer-current-buffer (help-mode) (let ((help-xref-following t)) (should (equal (buffer-name (current-buffer)) - (help-buffer)))))) + (help-buffer))))) + + ;; Returns the current `fundamental-mode' buffer when an xref button + ;; is clicked and the resulting action function, such as the various + ;; `describe-*' commands, binds `help-buffer-under-preparation' to + ;; something non-nil. + (should (eq major-mode 'fundamental-mode)) + (let ((help-xref-following 'help-mode) + (help-buffer-under-preparation t)) + (should (equal (buffer-name (current-buffer)) + (help-buffer))) + (with-current-buffer "*scratch*" + (should (equal "*Help*" (help-buffer)))))) (ert-deftest help-mode-tests-make-xrefs () (with-temp-buffer -- 2.46.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 19:42:31 2024 Received: (at control) by debbugs.gnu.org; 8 Oct 2024 23:42:31 +0000 Received: from localhost ([127.0.0.1]:54883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syJqZ-0006RA-17 for submit@debbugs.gnu.org; Tue, 08 Oct 2024 19:42:31 -0400 Received: from mail-108-mta95.mxroute.com ([136.175.108.95]:44041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syJqW-0006Qz-Be for control@debbugs.gnu.org; Tue, 08 Oct 2024 19:42:29 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta95.mxroute.com (ZoneMTA) with ESMTPSA id 1926e8318110003e01.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 08 Oct 2024 23:42:18 +0000 X-Zone-Loop: cbc01de4545480e73bc3d37730574472b75d9b105161 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tmR/rsgyD41ZctJaxd30LEx9EMWzlVSZ1eug3mAmMs0=; b=MXKVneZY6w3IpLgm6BjS7IuB5F 9oy9uqx2YtekAgg0+Itb5EeXoT6fZFcAL2HSnY+nnKNzgS8CUBFkKlmpJkmVvQhXro8YeziYuMhhK 9gdVOTGPEYw0gmjJsPANK7t31u1dSpi4xsaJfSsFVCLbLRQLjubmu3qGTwuW1kEl/90Q3Xqqlm9c0 D1TIeVnLprUl6tORAtt+7FTfiG6AO0sjNjDfDG71anLu++JzfFmWxrOtv1LQL3720YDgz+l87yDvl fDJeRsfdwQc59fRxEtqeuYU0JgS2qkHPZPQkwgmsNnMany8vwNAOy4WhGPzIIa8kzoE3yW/wMeNda vlV/gqkg==; From: "J.P." To: control@debbugs.gnu.org Subject: control message for bug #73686 Date: Tue, 08 Oct 2024 16:42:15 -0700 Message-ID: <87ldyyyxew.fsf@neverwas.me> MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 73686 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 21:00:16 2024 Received: (at 73686) by debbugs.gnu.org; 9 Oct 2024 01:00:16 +0000 Received: from localhost ([127.0.0.1]:54964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syL3n-00022N-B2 for submit@debbugs.gnu.org; Tue, 08 Oct 2024 21:00:16 -0400 Received: from mail-108-mta191.mxroute.com ([136.175.108.191]:45369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syL3k-00020g-N7 for 73686@debbugs.gnu.org; Tue, 08 Oct 2024 21:00:14 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta191.mxroute.com (ZoneMTA) with ESMTPSA id 1926eca322d0003e01.001 for <73686@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 09 Oct 2024 00:59:57 +0000 X-Zone-Loop: b24b071228a5456a83812a50800e79ce6c4a1ec6312c X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xHBQOjXLu26AHrXc77hKwpZFw2xdTL82n+2FbpJApiY=; b=ec+4OVqvNwDxgWsgDt+sVKh0f0 I5L9cI1S6RH6hi6ZyCENW4VQC92Ni3Rj7wz2/Tj7BIx8NRCO28p4J7DlCE6rvOHKUIjO6TeHBOXF8 WtAy2ZiYnLH/Zjmn8eLPtfipmQN6ldfUsp14JKQVhhg8/p/yB/loh3uW7GPHMQpg9eCMHw9iEs8Or qtTRdUsBN30hN3NmxDrRhoaxqckvvmrZUNzv+CMDzL4cWq7/JOmmPsuHr4pEtEz7QAvEtv97D/T6W RjVSa55FZkfUNsehVc/aPkRHM8tnQLUh9X5PDQ1ByeneTC420NgDd6TSinEopSO4chcT9aW6cckJr ORY+ULwQ==; From: "J.P." To: 73686@debbugs.gnu.org Subject: Re: bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces In-Reply-To: <87o73uyxgv.fsf@neverwas.me> (J. P.'s message of "Tue, 08 Oct 2024 16:41:04 -0700") References: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> <87ttdn5dsz.fsf@neverwas.me> <87y12y1exp.fsf@neverwas.me> <87o73uyxgv.fsf@neverwas.me> Date: Tue, 08 Oct 2024 17:59:54 -0700 Message-ID: <8734l6xf91.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73686 Cc: emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Actually, we can't count on `help-buffer-under-preparation' being non-nil in `describe-*' commands (unless we're willing to modify all the ones in which it isn't, which sounds rather dubious). Patch updated. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0000-v1-v2.diff >From 0e19883da585b0105f2340ac7c23764b3ea939c9 Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Tue, 8 Oct 2024 17:33:11 -0700 Subject: [PATCH 0/1] *** NOT A PATCH *** *** BLURB HERE *** F. Jason Park (1): [POC] Overload help-xref-following for non-default help buffers lisp/help-mode.el | 21 +++++++++++++-------- test/lisp/emacs-lisp/package-tests.el | 2 +- test/lisp/help-mode-tests.el | 14 +++++++++++++- 3 files changed, 27 insertions(+), 10 deletions(-) Interdiff: diff --git a/lisp/help-mode.el b/lisp/help-mode.el index f704098b2dc..77473125694 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -524,16 +524,14 @@ help-buffer "Return the name of a buffer for inserting help. If `help-xref-following' is t and the current buffer is derived from `help-mode', return the current buffer's name. As a special case, also -do so if these three conditions are met: `help-xref-following' is the -symbol of a major mode deriving from `help-mode', the current buffer is -in `fundamental-mode', and `help-buffer-under-preparation' is non-nil. +do so if `help-xref-following' is the symbol of a major mode deriving +from `help-mode' and the current buffer is in `fundamental-mode'. Otherwise, return \"*Help*\", creating a buffer with that name if it does not already exist." (buffer-name ;for with-output-to-temp-buffer (if (and help-xref-following (if (or (eq help-xref-following t) - (not (and help-buffer-under-preparation - (eq major-mode 'fundamental-mode)))) + (not (eq major-mode 'fundamental-mode))) (derived-mode-p 'help-mode) ; current buffer (provided-mode-derived-p help-xref-following '(help-mode)))) (current-buffer) diff --git a/test/lisp/emacs-lisp/package-tests.el b/test/lisp/emacs-lisp/package-tests.el index 692d6550250..8236f834b02 100644 --- a/test/lisp/emacs-lisp/package-tests.el +++ b/test/lisp/emacs-lisp/package-tests.el @@ -172,7 +172,7 @@ with-fake-help-buffer `(with-temp-buffer (help-mode) ;; Trick `help-buffer' into using the temp buffer. - (let ((help-xref-following t)) + (let ((help-xref-following major-mode)) ,@body))) (defun package-test-strip-version (dir) -- 2.46.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-POC-Overload-help-xref-following-for-non-default-hel.patch >From 0e19883da585b0105f2340ac7c23764b3ea939c9 Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Tue, 8 Oct 2024 15:58:49 -0700 Subject: [PATCH 1/1] [POC] Overload help-xref-following for non-default help buffers * lisp/help-mode.el (help-xref-following): Mention in doc that value may be the symbol of a major mode. (help-buffer): When the current buffer is in `fundamental-mode', check to see if the value of `help-xref-following' is the symbol of a major mode deriving from `help-mode' before returning the current buffer. This should also probably check whether `help-buffer-under-preparation' is non-nil, but many `describe-*' functions do not bind it. (help-xref-go-back, help-xref-go-forward): Use `help-do-xref' instead of `apply' to call methods. (help-do-xref): Bind `help-xref-following' to the value of `major-mode' instead of t. * test/lisp/emacs-lisp/package-tests.el (with-fake-help-buffer): Use value of `major-mode' instead of t for `help-xref-following'. * test/lisp/help-mode-tests.el (help-mode-tests-help-buffer-current-buffer): Add case for `help-xref-following' being a major-mode rather than t. (Bug#73686) (See also: bug#73637.) --- lisp/help-mode.el | 21 +++++++++++++-------- test/lisp/emacs-lisp/package-tests.el | 2 +- test/lisp/help-mode-tests.el | 14 +++++++++++++- 3 files changed, 27 insertions(+), 10 deletions(-) diff --git a/lisp/help-mode.el b/lisp/help-mode.el index 4ee4f4156a1..77473125694 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -516,19 +516,24 @@ help-setup-xref (setq help-xref-stack-item item))) (defvar help-xref-following nil - "Non-nil when following a help cross-reference.") + "Non-nil when following a help cross-reference. +May be the value of `major-mode' when an instigating button was clicked.") ;;;###autoload (defun help-buffer () "Return the name of a buffer for inserting help. -If `help-xref-following' is non-nil and the current buffer is -derived from `help-mode', this is the name of the current buffer. - +If `help-xref-following' is t and the current buffer is derived from +`help-mode', return the current buffer's name. As a special case, also +do so if `help-xref-following' is the symbol of a major mode deriving +from `help-mode' and the current buffer is in `fundamental-mode'. Otherwise, return \"*Help*\", creating a buffer with that name if it does not already exist." (buffer-name ;for with-output-to-temp-buffer (if (and help-xref-following - (derived-mode-p 'help-mode)) + (if (or (eq help-xref-following t) + (not (eq major-mode 'fundamental-mode))) + (derived-mode-p 'help-mode) ; current buffer + (provided-mode-derived-p help-xref-following '(help-mode)))) (current-buffer) (get-buffer-create "*Help*")))) @@ -792,7 +797,7 @@ help-xref-go-back position (car item) method (cadr item) args (cddr item)))) - (apply method args) + (help-do-xref nil method args) (with-current-buffer buffer (if (get-buffer-window buffer) (set-window-point (get-buffer-window buffer) position) @@ -812,7 +817,7 @@ help-xref-go-forward position (car item) method (cadr item) args (cddr item)))) - (apply method args) + (help-do-xref nil method args) (with-current-buffer buffer (if (get-buffer-window buffer) (set-window-point (get-buffer-window buffer) position) @@ -894,7 +899,7 @@ help-do-xref Things are set up properly so that the resulting help buffer has a proper [back] button." ;; There is a reference at point. Follow it. - (let ((help-xref-following t)) + (let ((help-xref-following major-mode)) (apply function (if (eq function 'info) (append args (list (generate-new-buffer-name "*info*"))) args)))) diff --git a/test/lisp/emacs-lisp/package-tests.el b/test/lisp/emacs-lisp/package-tests.el index 692d6550250..8236f834b02 100644 --- a/test/lisp/emacs-lisp/package-tests.el +++ b/test/lisp/emacs-lisp/package-tests.el @@ -172,7 +172,7 @@ with-fake-help-buffer `(with-temp-buffer (help-mode) ;; Trick `help-buffer' into using the temp buffer. - (let ((help-xref-following t)) + (let ((help-xref-following major-mode)) ,@body))) (defun package-test-strip-version (dir) diff --git a/test/lisp/help-mode-tests.el b/test/lisp/help-mode-tests.el index 2e64b12732e..968ed7da72e 100644 --- a/test/lisp/help-mode-tests.el +++ b/test/lisp/help-mode-tests.el @@ -39,7 +39,19 @@ help-mode-tests-help-buffer-current-buffer (help-mode) (let ((help-xref-following t)) (should (equal (buffer-name (current-buffer)) - (help-buffer)))))) + (help-buffer))))) + + ;; Returns the current `fundamental-mode' buffer when an xref button + ;; is clicked and the resulting action function, such as the various + ;; `describe-*' commands, binds `help-buffer-under-preparation' to + ;; something non-nil. + (should (eq major-mode 'fundamental-mode)) + (let ((help-xref-following 'help-mode) + (help-buffer-under-preparation t)) + (should (equal (buffer-name (current-buffer)) + (help-buffer))) + (with-current-buffer "*scratch*" + (should (equal "*Help*" (help-buffer)))))) (ert-deftest help-mode-tests-make-xrefs () (with-temp-buffer -- 2.46.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 21:05:34 2024 Received: (at 73686) by debbugs.gnu.org; 9 Oct 2024 01:05:34 +0000 Received: from localhost ([127.0.0.1]:54974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syL8s-0002Oy-Jv for submit@debbugs.gnu.org; Tue, 08 Oct 2024 21:05:34 -0400 Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]:46773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syL8n-0002OB-2c for 73686@debbugs.gnu.org; Tue, 08 Oct 2024 21:05:29 -0400 Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id 7ADF511400AF; Tue, 8 Oct 2024 21:05:09 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Tue, 08 Oct 2024 21:05:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1728435909; x=1728522309; bh=mx7V9NdTkw/lN0CvhGLX+R1cTKp26PO8EFkWLAtkiuM=; b= ncDEHaDJHUCnBl48UJ60pTJAczwOD7kYsWpA0Rv87JJL2HIVPCI30vrrQRQ5zMPa r+SxOs5OqNnNlAgzSTedXnyJRWLvIrW4D+TR2PK9hyWmFptcb+toXlcz/e8UP9N/ 2kLtLkWQIL0u8hxCwO9XnEGVib3MTb4j5/x05Z82e+axqxwxF30zfOcM9lsChrnf KgrZxP+451oZE4w+ugd3Io/cwYX/9s8Md3JRaao0e3NzcbDiLBFkdQizq0MQHuNN vMYdWxt3/dwrWaI9WdqhuRroXoOuaYYFjpPHDk+v96ueJeyj0HXm8V8FIiW+PwWo N8ODNxWGTqftg6MgZgKKPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728435909; x= 1728522309; bh=mx7V9NdTkw/lN0CvhGLX+R1cTKp26PO8EFkWLAtkiuM=; b=K /+0zWej2f8mVE7tvD8DjmW0ohszwaunZXS7k5XXKztSXu5udVGQlSBgqjdhtmR7C 8XumeA5O3fCby3rxdHQu0nfz4hvSIu42Wc9Yeq/x9RAFCsPYMFg8QUQw5oDJbp9R Sdh2+R6IhquS6QIBJuY3RaQpsPFkb3krYnOJGLiGMmExBuVJ8mqe9tpibt7AnCw1 hLpJpQxs9YLaDS8T70kJAOfUUY9dB2tFRLRku6M3PrjQ3gGTLkEvx4ppCBctSQZU sW4qngnFkYJbh9L/3IhUe7TKDnJNAUPKVwoo8FFMJtPfQuoydQDXCfTzzAS3tAZd C8y0LE8Y0VGOFscrvbp6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdefvddggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieekueef tddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjphesnhgvvhgvrhifrghsrd hmvgdprhgtphhtthhopeejfeeikeeiseguvggssghughhsrdhgnhhurdhorhhgpdhrtghp thhtohepvghmrggtshdqvghrtgesghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Oct 2024 21:05:07 -0400 (EDT) Message-ID: <38df6195-e438-41c4-b107-3e2e9a20f873@gutov.dev> Date: Wed, 9 Oct 2024 04:05:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces To: "J.P." , 73686@debbugs.gnu.org References: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> <87ttdn5dsz.fsf@neverwas.me> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <87ttdn5dsz.fsf@neverwas.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73686 Cc: emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! On 08/10/2024 09:06, J.P. wrote: > And because `major-mode' is buffer-local, it gets wiped out with these > latest changes before `help-buffer' ever sees it: This is a problem, sorry. The command in question (erc-nicks-list-faces) doesn't really work for me -- it errors with No faces matching "\`erc-nicks-" I've just pushed the patch below to master. Could you try it and see if it helps? diff --git a/lisp/help-mode.el b/lisp/help-mode.el index 4ee4f4156a1..f233633d2ca 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -505,7 +505,8 @@ help-setup-xref because we want to record the \"previous\" position of point so we can restore it properly when going back." (with-current-buffer (help-buffer) - (kill-all-local-variables) + ;; Re-enable major mode, killing all other local vars. + (funcall major-mode) (when help-xref-stack-item (push (cons (point) help-xref-stack-item) help-xref-stack) (setq help-xref-forward-stack nil)) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 21:25:10 2024 Received: (at 73686) by debbugs.gnu.org; 9 Oct 2024 01:25:10 +0000 Received: from localhost ([127.0.0.1]:54993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syLRt-0003H8-Mi for submit@debbugs.gnu.org; Tue, 08 Oct 2024 21:25:09 -0400 Received: from mail-108-mta0.mxroute.com ([136.175.108.0]:46447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syLRq-0003Gx-2W for 73686@debbugs.gnu.org; Tue, 08 Oct 2024 21:25:07 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta0.mxroute.com (ZoneMTA) with ESMTPSA id 1926ee10b7c0003e01.001 for <73686@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 09 Oct 2024 01:24:55 +0000 X-Zone-Loop: 6c1e077d383a67c60a4f9fa7bc469769b24222bcc9d6 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=whH5eeeL6nv4vJjNecmQlKpzY7kleGL9ktQEN7ZDpPY=; b=jayqdSt2UPGTgBj1pa4dNKl+Ij 9ZK3Kk1BA7QoI7XZm02ef2kyh3FFVBn6jEhoGWnQ+2wLFS2hxZdbYZUtF7LwJAvNFJnsFx950mpVA ainwtUI037775jwcZeH6eGQB1JjeVOrmiuFECbQLb8yxI6TZseVjx37UA5EI1jKLvs6HV4gsx5P2+ Z99QHtOmvB2TVVUvnHP2MW56Ve7kbj0Crb+aPltl5E2o71ueySCdeWhmcOsvvq5cnfQIU3NESv+9V UFwQdUvsWpz8sB34S37fPL6lNJetS6INexK/nnPcZhCbjFwinrdReJqyd+kWsKs38t7vJ91AQCkNm wAUQLkYQ==; From: "J.P." To: Dmitry Gutov Subject: Re: bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces In-Reply-To: <38df6195-e438-41c4-b107-3e2e9a20f873@gutov.dev> (Dmitry Gutov's message of "Wed, 9 Oct 2024 04:05:04 +0300") References: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> <87ttdn5dsz.fsf@neverwas.me> <38df6195-e438-41c4-b107-3e2e9a20f873@gutov.dev> Date: Tue, 08 Oct 2024 18:24:52 -0700 Message-ID: <87ploavziz.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73686 Cc: emacs-erc@gnu.org, 73686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > Hi! > > On 08/10/2024 09:06, J.P. wrote: >> And because `major-mode' is buffer-local, it gets wiped out with these >> latest changes before `help-buffer' ever sees it: > > This is a problem, sorry. No worries. > > The command in question (erc-nicks-list-faces) doesn't really work for > me -- it errors with > > No faces matching "\`erc-nicks-" Oh, right. That command only works when `erc-nicks-mode' is enabled. But you just can use `list-faces-display' instead, and then click on one of the "abcdefghijklmnopqrstuvwxyz" buttons. > > I've just pushed the patch below to master. Could you try it and see if > it helps? Seems to fix the issue. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 23:00:57 2024 Received: (at 73686-done) by debbugs.gnu.org; 9 Oct 2024 03:00:57 +0000 Received: from localhost ([127.0.0.1]:55083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syMwb-0008G4-AB for submit@debbugs.gnu.org; Tue, 08 Oct 2024 23:00:57 -0400 Received: from mail-108-mta63.mxroute.com ([136.175.108.63]:38953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syMwY-0008Fr-B8 for 73686-done@debbugs.gnu.org; Tue, 08 Oct 2024 23:00:55 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta63.mxroute.com (ZoneMTA) with ESMTPSA id 1926f38c2f20003e01.001 for <73686-done@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 09 Oct 2024 03:00:43 +0000 X-Zone-Loop: 60bfc38cac0f170dd1c3c64396cfd5d0cd4011c7b928 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Pv6czgXKAfLX6x7sBxE8o+3QYRZgonWE//7OFkRlyp4=; b=mP+E/XPAaSXXX8P6rTIMvLaTrh RFj2lz/oF+RfbezEmjJp6BrPyHwgphP26QSO8GmRCNb1P9pSXr/eIM246FxNPcq9yVl6xTvX+M2Pf JF96lfKBD19HSLQEn4aU6cHbDk3ncCeX5WoWbGJxFytf9l2PyhCJwsjXumw2I6LaTzPHJA2dCxfpM eiIqgtGhHKsQkmXhe3DYWhtlxfMwxELRf+IN+ce3KKJEN0wUqeVKaWAA6pJQm2Mo4s8ks9cQReKmP emMixJJNc4Oggid4CogLeZPxyNmjavSUVN3m8L9/hkGYQOeKMDOj8UuTs2n/gg3JScdicY5fzI59O HFjc0m5g==; From: "J.P." To: 73686-done@debbugs.gnu.org Subject: Re: bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces In-Reply-To: <8734l6xf91.fsf@neverwas.me> (J. P.'s message of "Tue, 08 Oct 2024 17:59:54 -0700") References: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> <87ttdn5dsz.fsf@neverwas.me> <87y12y1exp.fsf@neverwas.me> <87o73uyxgv.fsf@neverwas.me> <8734l6xf91.fsf@neverwas.me> Date: Tue, 08 Oct 2024 20:00:41 -0700 Message-ID: <87bjzuugiu.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73686-done Cc: emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This has been fixed by: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ef87ce0f I will open another bug for the help-go-back stuff mentioned up thread. Thanks and closing. From unknown Sat Aug 16 20:07:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 06 Nov 2024 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator