GNU bug report logs - #73675
[PATCH] Clean up tmm.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73675 in the body.
You can then email your comments to 73675 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Clean up tmm.el
Date: Mon, 07 Oct 2024 10:59:16 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

Hi,

Here is a patch with some clean up in "tmm.el".

Best regards,

In GNU Emacs 31.0.50 (build 15, x86_64-unknown-openbsd7.6, X toolkit) of
 2024-10-07 built on computer
Repository revision: 8c5d69998e65d3ecf5f599bd828bf3330f4f118a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
System Description: OpenBSD computer 7.6 GENERIC.MP#344 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=lucid
 --with-toolkit-scroll-bars=no --without-cairo
 --without-compress-install'

[0001-Clean-up-tmm.el.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Message #8 received at 73675 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 73675 <at> debbugs.gnu.org
Subject: Re: bug#73675: [PATCH] Clean up tmm.el
Date: Mon, 07 Oct 2024 14:40:10 +0300

> Date: Mon, 07 Oct 2024 10:59:16 +0200
> From:  Manuel Giraud via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Here is a patch with some clean up in "tmm.el".

Thanks, but these are public symbols, how do we know no one out there
uses them?  I'd leave them alone, TBH.

Message #11 received at 73675 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73675 <at> debbugs.gnu.org
Subject: Re: bug#73675: [PATCH] Clean up tmm.el
Date: Mon, 07 Oct 2024 14:05:24 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Mon, 07 Oct 2024 10:59:16 +0200
>> From:  Manuel Giraud via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> Here is a patch with some clean up in "tmm.el".
>
> Thanks, but these are public symbols, how do we know no one out there
> uses them?  I'd leave them alone, TBH.

Ok.  What about the following one?  `tmm-mb-map' is not even set
anywhere.

[0001-Clean-up-tmm.el.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Message #14 received at 73675 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 73675 <at> debbugs.gnu.org
Subject: Re: bug#73675: [PATCH] Clean up tmm.el
Date: Mon, 07 Oct 2024 21:38:05 +0300

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: 73675 <at> debbugs.gnu.org
> Date: Mon, 07 Oct 2024 14:05:24 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Thanks, but these are public symbols, how do we know no one out there
> > uses them?  I'd leave them alone, TBH.
> 
> Ok.  What about the following one?  `tmm-mb-map' is not even set
> anywhere.

That's okay, but if you intend to work on improving and developing
tmm.el (which is always welcome), we prefer that such cleanup changes
be done as part of larger, significant changesets, not as separate
changes that modify the code without adding any new or improved
functionality.

In a nutshell, this is like fixing whitespace: we prefer to do it as
part of real changes, not separately.

So if you intend to work on tmm.el, I suggest to install this with
whatever other changes you are planning.

Thanks.

Message #19 received at 73675-done <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73675-done <at> debbugs.gnu.org
Subject: Re: bug#73675: [PATCH] Clean up tmm.el
Date: Tue, 08 Oct 2024 10:13:18 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
>> Cc: 73675 <at> debbugs.gnu.org
>> Date: Mon, 07 Oct 2024 14:05:24 +0200
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > Thanks, but these are public symbols, how do we know no one out there
>> > uses them?  I'd leave them alone, TBH.
>> 
>> Ok.  What about the following one?  `tmm-mb-map' is not even set
>> anywhere.
>
> That's okay, but if you intend to work on improving and developing
> tmm.el (which is always welcome), we prefer that such cleanup changes
> be done as part of larger, significant changesets, not as separate
> changes that modify the code without adding any new or improved
> functionality.

Ok.  I should have done this in my previous patch :-) I may still have
some work on tmm.el.  Anyway, I'm closing this one.
-- 
Manuel Giraud

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.