GNU bug report logs - #73664
libtorrent-rasterbar@1.2: failure in test_ssl

Previous Next

Full log

View this message in rfc822 format

From: Tomas Volf <~@wolfsden.cz>
To: 73664 <at> debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [bug#73664] [PATCH v2 2/2] gnu: libtorrent-rasterbar: Remove special case for test_ssl.
Date: Tue, 28 Jan 2025 20:50:01 +0100

With the release of 2.0.11, the SSL certificates used for tests are valid for
long enough time (~end of year 2297) to no longer require faketime.  With the
removal of faketime, the explicit timeout is also no longer required, since it
does not hang anymore.

This gives us back the validation that SSL works.

* gnu/packages/bittorrent.scm
(libtorrent-rasterbar)[arguments]<#:phases>['check]: Remove test timeout.  Do
not special case test_ssl.

Change-Id: I535c72fec24658a4b2151d2e8794319055c9a278
---
 gnu/packages/bittorrent.scm | 26 ++------------------------
 1 file changed, 2 insertions(+), 24 deletions(-)

diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index d12493c269..667350ad9c 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -448,13 +448,10 @@ (define-public libtorrent-rasterbar
             (lambda* (#:key tests? parallel-tests? #:allow-other-keys)
               (let* ((disabled-tests
                       '(;; Requires a non-localhost IPv4 interface.
-                        "test_upnp"
-                        ;; test_ssl needs to be run separately.
-                        "test_ssl"))
+                        "test_upnp"))
                      (exclude-regex (string-append "^("
                                                    (string-join disabled-tests "|")
                                                    ")$"))
-                     (timeout "600")
                      (jobs (if parallel-tests?
                                (number->string (parallel-job-count))
                                "1")))
@@ -462,26 +459,7 @@ (define-public libtorrent-rasterbar
                   (invoke "ctest"
                           "-E" exclude-regex
                           "-j" jobs
-                          "--timeout" timeout
-                          "--output-on-failure")
-                  ;; test_ssl relies on bundled TLS certificates with a fixed
-                  ;; expiry date.  To ensure succesful builds in the future,
-                  ;; fake the time to be roughly that of the release.
-                  ;;
-                  ;; At the same time, faketime happens to cause
-                  ;; test_fast_extension, test_privacy and test_resolve_links
-                  ;; to hang, even with FAKETIME_ONLY_CMDS.  Not sure why.  So
-                  ;; execute only test_ssl under faketime.
-                  ;;
-                  ;; Note: The test_ssl test times out in the ci.
-                  ;; Temporarily disable it until that is resolved.
-                  ;; (invoke "faketime" "2022-10-24"
-                  ;;         "ctest"
-                  ;;         "-R" "^test_ssl$"
-                  ;;         "-j" jobs
-                  ;;         "--timeout" timeout
-                  ;;         "--output-on-failure")
-                  )))))))
+                          "--output-on-failure"))))))))
     (inputs (list boost openssl))
     (native-inputs
      (list libfaketime
-- 
2.47.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.