GNU bug report logs - #73646
[PATCH] emacs-alchemist: add alchemist-server output

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73646 in the body.
You can then email your comments to 73646 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: bigbookofbug <at> proton.me
To: guix-patches <at> gnu.org
Cc: emma thompson <bigbookofbug <at> proton.me>
Subject: [PATCH] emacs-alchemist: add alchemist-server output
Date: Sat, 05 Oct 2024 21:25:40 +0000

From: emma thompson <bigbookofbug <at> proton.me>

---
 gnu/packages/emacs-xyz.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 09ac57a464..5567c38a3a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4046,6 +4046,15 @@ (define-public emacs-alchemist
     (build-system emacs-build-system)
     (propagated-inputs
      (list emacs-elixir-mode emacs-dash emacs-company emacs-pkg-info))
+    (arguments
+     '(#:phases (modify-phases %standard-phases
+                  (add-after 'install 'install-server
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (server (string-append out "/share/emacs/site-lisp/alchemist-1.8.2/alchemist-server")))
+                        (mkdir-p server)
+                        (copy-recursively "alchemist-server" server)
+                        (delete-file-recursively (string-append server "/test"))))))))
     (home-page "http://www.github.com/tonini/alchemist.el")
     (synopsis "Elixir tooling integration into Emacs")
     (description

base-commit: 002df8abd2f4d7c5d23febb1459b77c880345ca7
-- 
2.46.0

Message #8 received at 73646 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: bigbookofbug <at> proton.me, 73646 <at> debbugs.gnu.org
Subject: Re: [PATCH] emacs-alchemist: add alchemist-server output
Date: Sun, 06 Oct 2024 15:40:03 +0200

Am Samstag, dem 05.10.2024 um 21:25 +0000 schrieb
bigbookofbug <at> proton.me:
> From: emma thompson <bigbookofbug <at> proton.me>
> 
> ---
>  gnu/packages/emacs-xyz.scm | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 09ac57a464..5567c38a3a 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -4046,6 +4046,15 @@ (define-public emacs-alchemist
>      (build-system emacs-build-system)
>      (propagated-inputs
>       (list emacs-elixir-mode emacs-dash emacs-company emacs-pkg-
> info))
> +    (arguments
Prefer the new style, that is (list #:phases ...)
> +     '(#:phases (modify-phases %standard-phases
> +                  (add-after 'install 'install-server
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let* ((out (assoc-ref outputs "out"))
> +                             (server (string-append out
> "/share/emacs/site-lisp/alchemist-1.8.2/alchemist-server")))
Is there a better way to encode this path?  You might also want to look
into #:include, which is already provided by emacs-build-system.
> +                        (mkdir-p server)
> +                        (copy-recursively "alchemist-server" server)
> +                        (delete-file-recursively (string-append
> server "/test"))))))))
Cheers

Message #11 received at 73646 <at> debbugs.gnu.org (full text, mbox):

From: emma <bigbookofbug <at> proton.me>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 73646 <at> debbugs.gnu.org
Subject: Re: [PATCH] emacs-alchemist: add alchemist-server output
Date: Sun, 06 Oct 2024 17:06:57 +0000

[Message part 1 (text/plain, inline)]

"Liliana Marie Prikler" <liliana.prikler <at> gmail.com> writes:

> Am Samstag, dem 05.10.2024 um 21:25 +0000 schrieb
> bigbookofbug <at> proton.me:
>> From: emma thompson <bigbookofbug <at> proton.me>
>>
>> ---
>>  gnu/packages/emacs-xyz.scm | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm 
>> b/gnu/packages/emacs-xyz.scm
>> index 09ac57a464..5567c38a3a 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -4046,6 +4046,15 @@ (define-public emacs-alchemist
>>      (build-system emacs-build-system)
>>      (propagated-inputs
>>       (list emacs-elixir-mode emacs-dash emacs-company 
>> emacs-pkg-
>> info))
>> +    (arguments
> Prefer the new style, that is (list #:phases ...)
>> +     '(#:phases (modify-phases %standard-phases
>> +                  (add-after 'install 'install-server
>> +                    (lambda* (#:key outputs 
>> #:allow-other-keys)
>> +                      (let* ((out (assoc-ref outputs "out"))
>> +                             (server (string-append out
>> "/share/emacs/site-lisp/alchemist-1.8.2/alchemist-server")))
> Is there a better way to encode this path?  You might also want 
> to look
> into #:include, which is already provided by emacs-build-system.
>> +                        (mkdir-p server)
>> +                        (copy-recursively "alchemist-server" 
>> server)
>> +                        (delete-file-recursively 
>> (string-append
>> server "/test"))))))))
> Cheers

hi and thanks for the advice on use of #:include. would the 
following be preferrable? output produced the directory correctly 
(also added info to copyright section as that part had slipped my 
mind:

 ;;; Copyright © 2024 Ashish SHUKLA <ashish.is <at> lostca.se>
 ;;; Copyright © 2024 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
 ;;; Copyright © 2024 Spencer King <spencer.king <at> nursiapress.com>
+;;; Copyright © 2024 emma thompson <bigbookofbug <at> proton.me>
 
 ;;;
 ;;; This file is part of GNU Guix.
@@ -4047,22 +4048,15 @@ (define-public emacs-alchemist
     (propagated-inputs
      (list emacs-elixir-mode emacs-dash emacs-company 
      emacs-pkg-info))
     (arguments
-     '(#:phases (modify-phases %standard-phases
-                  (add-after 'install 'install-server
-                    (lambda* (#:key outputs #:allow-other-keys)
-                      (let* ((out (assoc-ref outputs "out"))
-                             (server (string-append out 
                              "/share/emacs/site-lisp/alchemist-1.8.2/alchemist-server")))
-                        (mkdir-p server)
-                        (copy-recursively "alchemist-server" 
                         server)
-                        (delete-file-recursively (string-append 
                         server "/test"))))))))
-    (home-page "http://www.github.com/tonini/alchemist.el")
-    (synopsis "Elixir tooling integration into Emacs")
-    (description
-     "This package brings you all the Elixir tooling and power 
      inside your Emacs
+     (list #:include '(cons "^alchemist-server/" 
%default-include)))
+     (home-page "http://www.github.com/tonini/alchemist.el")
+     (synopsis "Elixir tooling integration into Emacs")
+     (description
+      "This package brings you all the Elixir tooling and power 
inside your Emacs
 editor.  It comes with commands to compile, execute and test your 
 code, spawn
 an interactive shell, and look up definitions and documentation 
 as well as
 code completion and project management support.")
-    (license license:gpl3+)))
+     (license license:gpl3+)))
 
 (define-public emacs-auto-compile
   (package

-- 
emma
EF515F7D600717781DF9AB2E0FB1CF2867A117F5

[signature.asc (application/pgp-signature, attachment)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: bigbookofbug--- via Guix-patches via <guix-patches <at> gnu.org>
Cc: bigbookofbug <at> proton.me, 73646-done <at> debbugs.gnu.org
Subject: Re: [bug#73646] [PATCH] emacs-alchemist: add alchemist-server output
Date: Tue, 15 Oct 2024 09:20:10 +0200

Hello,

bigbookofbug--- via Guix-patches via <guix-patches <at> gnu.org> writes:

> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 09ac57a464..5567c38a3a 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -4046,6 +4046,15 @@ (define-public emacs-alchemist
>      (build-system emacs-build-system)
>      (propagated-inputs
>       (list emacs-elixir-mode emacs-dash emacs-company emacs-pkg-info))
> +    (arguments
> +     '(#:phases (modify-phases %standard-phases
> +                  (add-after 'install 'install-server
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let* ((out (assoc-ref outputs "out"))
> +                             (server (string-append out "/share/emacs/site-lisp/alchemist-1.8.2/alchemist-server")))
> +                        (mkdir-p server)
> +                        (copy-recursively "alchemist-server" server)
> +                        (delete-file-recursively (string-append server "/test"))))))))

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.