From unknown Sat Jun 21 10:46:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73643 <73643@debbugs.gnu.org> To: bug#73643 <73643@debbugs.gnu.org> Subject: Status: [PATCH 0/2] Fix LibreWolf context menu & livestreaming Reply-To: bug#73643 <73643@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:46:14 +0000 retitle 73643 [PATCH 0/2] Fix LibreWolf context menu & livestreaming reassign 73643 guix-patches submitter 73643 Ian Eure severity 73643 normal tag 73643 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 12:13:37 2024 Received: (at submit) by debbugs.gnu.org; 5 Oct 2024 16:13:38 +0000 Received: from localhost ([127.0.0.1]:39472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx7PV-0008Qe-He for submit@debbugs.gnu.org; Sat, 05 Oct 2024 12:13:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:41934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx7PT-0008QW-Gn for submit@debbugs.gnu.org; Sat, 05 Oct 2024 12:13:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sx7PO-0002WH-FP for guix-patches@gnu.org; Sat, 05 Oct 2024 12:13:30 -0400 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sx7PM-0003fP-Dq for guix-patches@gnu.org; Sat, 05 Oct 2024 12:13:30 -0400 Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id 4259B11401A9; Sat, 5 Oct 2024 12:13:25 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Sat, 05 Oct 2024 12:13:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm1; t=1728144805; x=1728231205; bh=nl aoNGRV+hUeonyiq7gG2l7N0l4Qho23J7aI1yiT++w=; b=WiLO7II5A//Q52uJTP pHZf03nDoCoQG3j0NF1wBr8/Z7GtSC1+HBaF3Acdj5WnYnzJ1yVdNDbJ9xY9u0gi ktTUo6jAQroQLpqKwqpJ8vYrIU6yyucLHYJEdAa5/YWKQPoO46MuiuvxIdumTqhb oUXtGybhS4nPI2oCJ/ATR9bG6eLZVwIknaQE78OAZDk3zL3xA65uKrn47W4ro0rv 1HLGc+B6czsYwoKLz9BUpPYvgnv2EpubERtYJrctVZlcGzYODwvVfVciXU+ylEff +fDy3PW1wSMWFP2m/Uq7JqMxjCfExFdrTCMTw8Al1cjzdgoQSskbEccnQhiQAWki rFzA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1728144805; x=1728231205; bh=nlaoNGRV+hUeo nyiq7gG2l7N0l4Qho23J7aI1yiT++w=; b=g+wlrs2gKnSfy3hDsV4Cyh/NJQ0A2 XOlugFQhk9qNV+jvUESkYGmJ4cikP/SslGM+H/vrHeqtRRbNr6U4sEkB3wOCuOiw RMa8c33XVLHvZ4EJqC34PY2/NGKDAQU7vtOmwlkdgOu+/4qKuOo+OhLpg294/VY2 qo9uCCxfsa9NThTMLKGuxPAUai5P3C9lhy/5wolPWmHvK73GFmyKzwrg/W6eoZMo eX4QXEAzdetMNwC0y5hkrOsNt7/6MFBsCBtW9jBdRvJohEZpAAqLsKq+Hly5QFfv Bb+SvX+WNebWzkjnHHaZPHlgO3vlo1s/yjyU8CZXENicv61mcTtX9RetA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddvhedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf ffkffogggtgfesthekredtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhes rhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpefgueekffejudfgvdevte elteeitdeuuddufffhuefhiefhjeetuefhgfettedvteenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh dpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepghhu ihigqdhprghttghhvghssehgnhhurdhorhhgpdhrtghpthhtohepihgrnhesrhgvthhroh hsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 5 Oct 2024 12:13:24 -0400 (EDT) From: Ian Eure To: guix-patches@gnu.org Subject: [PATCH 0/2] Fix LibreWolf context menu & livestreaming Date: Sat, 5 Oct 2024 09:12:49 -0700 Message-ID: <20241005161305.23985-1-ian@retrospec.tv> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=103.168.172.157; envelope-from=ian@retrospec.tv; helo=fhigh-a6-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) After #73429 merged, I received reports of two problems: - The right-click context menu has manu duplicate and broken entries. This was caused by removing the genai module, but retaining code in the chrome which references it. Until I find a better approach to this, I’ve reverted the change. - Livestreamed video wouldn’t play. This was caused by the patch from #72265. I’ve reverted this, and will look into other approaches. Ian Eure (2): gnu: librewolf: Fix broken context menu. gnu: librewolf: Revert video acceleration fix gnu/packages/librewolf.scm | 25 +++++++++++++------ ...librewolf-add-paths-to-rdd-allowlist.patch | 11 -------- 2 files changed, 17 insertions(+), 19 deletions(-) delete mode 100644 gnu/packages/patches/librewolf-add-paths-to-rdd-allowlist.patch -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 12:19:40 2024 Received: (at 73643) by debbugs.gnu.org; 5 Oct 2024 16:19:40 +0000 Received: from localhost ([127.0.0.1]:39491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx7VL-0000Hx-ME for submit@debbugs.gnu.org; Sat, 05 Oct 2024 12:19:40 -0400 Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144]:54683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx7VJ-0000He-7M for 73643@debbugs.gnu.org; Sat, 05 Oct 2024 12:19:38 -0400 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 2DF6313801A7; Sat, 5 Oct 2024 12:19:27 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Sat, 05 Oct 2024 12:19:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm1; t=1728145167; x=1728231567; bh=w1R+xyHBvywGvnd7LN9X6 ThE7bsG3ta0vhfvpUjo3z4=; b=cLNBQuy+KDcmDtU04WKcH4a2hJj9PxO+8FAXB o7k1O4t5jjv5SLWBLwTN4O1ZBrOPQyOspuoWcIhTVM2PgVUBdxj+/AxauAryd4G1 pkKVHaNAqQXXE5AqY1DPKlNAmDlD/YuboVgjpHWDMJoZT50WmLUKkZewiZPaIREa +kK39E/OT2ncyGFCBWBteMmcDWLdzHWflNMRM4zUdnTNfwmaU+TqjMLSFA5+ajtK h4+jJsZECerrSwVPgJ2HzgC4ddVCmQ7I8MHszc3fx0qIEFqZWMN7zHX1X2Bd/vEn AsM9+SW7SBeW4bLXKnufjsAZk5N9kAh0Hozod7Ka9+XfdLqag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1728145167; x=1728231567; bh=w1R+xyHBvywGvnd7LN9X6ThE7bsG 3ta0vhfvpUjo3z4=; b=VzZMwKxMorqPV62ydYr4U+aFCldbJLP7IdLKo4HmgURq 8BDGef9KjZSe5b9Hz9Ffizr3N9uu4r0DvpjQnlNnQojIHn8IcXibPTuGkpMOCHmV pMiJRCIRfZAth6yL/wt8mFHZ6IwLLPE1AL8nrDGjNuJ5IFyLDju54HxLmCCsFwgO paawk0lWi0crxFYXUQ3fuey4B4HzBoNqr8r/jrCq7R7rSaUk+4/dcq2cuWJgMUCr 1MaBVO0NQMkpZP4HlQ6lyguvtEpnYD6fb9g7Oh8ez7cY06+y0V0LjA2wnsP3F/VC 7O9L5QwJUCIWg1bSzrLwnvDj3i15d/6pbLsNUHarkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddvhedgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf ffkffoggfgsedtkeertdertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehr vghtrhhoshhpvggtrdhtvheqnecuggftrfgrthhtvghrnhephfeiveeliedukeffhefhle eijedtveelleetgefggfehkeeljeehtdeguddvvefgnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhvpd hnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeejfeei geefseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepihgrnhesrhgvthhroh hsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 5 Oct 2024 12:19:26 -0400 (EDT) From: Ian Eure To: 73643@debbugs.gnu.org Subject: [PATCH 1/2] gnu: librewolf: Fix broken context menu. Date: Sat, 5 Oct 2024 09:19:10 -0700 Message-ID: <20241005161911.24298-1-ian@retrospec.tv> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73643 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This patch fixes a reported bug where context (right-click) menus contain many duplicate and incorrect entries. * gnu/packages/librewolf.scm (librewolf): Include genai browser component. Change-Id: I288545ce80b9a7e854edfc26a7ffe43433303458 --- gnu/packages/librewolf.scm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm index 6fd0aa51f1..32b6d13d54 100644 --- a/gnu/packages/librewolf.scm +++ b/gnu/packages/librewolf.scm @@ -212,7 +212,7 @@ (define rust-librewolf rust) ; 1.75 is the default in Guix, 1.65 is the minimum. ;; Update this id with every update to its release date. ;; It's used for cache validation and therefore can lead to strange bugs. ;; ex: date '+%Y%m%d%H%M%S' -(define %librewolf-build-id "20240922110507") +(define %librewolf-build-id "20241003201141") (define-public librewolf (package @@ -324,9 +324,6 @@ (define (write-setting key value) libavcodec))))) (add-after 'unpack 'neuter-genai (lambda* _ - ;; Don't compile the code in. - (substitute* "browser/components/moz.build" - (("\"genai\",") "")) ;; Lock the preferences so they can't be enabled. (substitute* "lw/librewolf.cfg" (("defaultPref\\(\"browser\\.ml\\.") -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 12:19:40 2024 Received: (at 73643) by debbugs.gnu.org; 5 Oct 2024 16:19:40 +0000 Received: from localhost ([127.0.0.1]:39493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx7VM-0000I0-49 for submit@debbugs.gnu.org; Sat, 05 Oct 2024 12:19:40 -0400 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]:53119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx7VJ-0000Hf-U0 for 73643@debbugs.gnu.org; Sat, 05 Oct 2024 12:19:38 -0400 Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id F1C5311401BD; Sat, 5 Oct 2024 12:19:27 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Sat, 05 Oct 2024 12:19:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1728145167; x= 1728231567; bh=/1EOLQSSkmVK5UhDq5ribva2xpKD5I1qke1aVLqKjEE=; b=U NLsQPTZ++BlsD1GxaH/x9G+Vv/X0JczLAo82Ps9Z9wCjBCfoeByKiSfYbGrC7bzH lbWJHFZ/8f66LUE4FI1AviHED7UvyuDKkgtHIqormkPZ9I6uJVr/psbbaYHtqkuQ 8o65QyXkka6B4EuLk2C1l+82ceez70LgNzX/d/gU3eGwyoAWyiUEvGBk1eNYVcda wITMmmJZCoOUcrNXfhVMby++ewknbRzBOloXR7qpg/DUEuR5tCv5myU+zyDDdk0B RPohkZorbBQY8O6Fdp/qws8qUTXXWiVOw35SakAQble8a1N0iDn2i1/3pBR8/jv4 WZxVbyptvihURIGIvC/OA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728145167; x= 1728231567; bh=/1EOLQSSkmVK5UhDq5ribva2xpKD5I1qke1aVLqKjEE=; b=Z OgCqJQwSzCquSJqsMgdVW55dnvz4LciUIdhlm/PFNXLcTm5U2ASvDh7Bl+TXyLVz 2rm4W+Lo+wkfeAnHNK64BSfXumcH1A39okuP0d2ZulhLQpDZl9cOw52mjhTis68M HSYiKRkdhk4SRqnNmOYw0hgY7OUlLsaGynoWqctNzyeKJXiwElfe6otqC07Etdu5 RatWjOc+YCrTN8Tm24O1919x55giaVeruxHCEYavifnA/FsVhsyzmTFwJJ2SqBTR Z88aQs4VjmK+Xc+H/UZNClOMDAq1vpv5cf+KI6Bm0KjB2yEvgnv/HI1l82WUjPa7 Q4MtssldvuYec2qfZpErg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddvhedgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf ffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghn sehrvghtrhhoshhpvggtrdhtvheqnecuggftrfgrthhtvghrnhepvdeugeduveefgeehvd dthefgjeevvddvtefgheegtdfgueeitdehgfduffevjeeinecuffhomhgrihhnpehgihht hhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvhdpnhgspghrtghpthhtohepvddpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepjeefieegfeesuggvsggsuhhgshdrghhnuh drohhrghdprhgtphhtthhopehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 5 Oct 2024 12:19:27 -0400 (EDT) From: Ian Eure To: 73643@debbugs.gnu.org Subject: [PATCH 2/2] gnu: librewolf: Revert video acceleration fix Date: Sat, 5 Oct 2024 09:19:11 -0700 Message-ID: <20241005161911.24298-2-ian@retrospec.tv> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241005161911.24298-1-ian@retrospec.tv> References: <20241005161911.24298-1-ian@retrospec.tv> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73643 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This patch partly reverts #73429, because that change makes livestreaming video refuse to play. * gnu/packages/librewolf.scm (librewolf): Revert video acceleration fix Change-Id: Iaf36c64464cd078538fda677ea4fa7b13e7c110f --- gnu/packages/librewolf.scm | 22 ++++++++++++++----- ...librewolf-add-paths-to-rdd-allowlist.patch | 11 ---------- 2 files changed, 17 insertions(+), 16 deletions(-) delete mode 100644 gnu/packages/patches/librewolf-add-paths-to-rdd-allowlist.patch diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm index 32b6d13d54..31de7a7171 100644 --- a/gnu/packages/librewolf.scm +++ b/gnu/packages/librewolf.scm @@ -212,7 +212,7 @@ (define rust-librewolf rust) ; 1.75 is the default in Guix, 1.65 is the minimum. ;; Update this id with every update to its release date. ;; It's used for cache validation and therefore can lead to strange bugs. ;; ex: date '+%Y%m%d%H%M%S' -(define %librewolf-build-id "20241003201141") +(define %librewolf-build-id "20241005085731") (define-public librewolf (package @@ -223,9 +223,7 @@ (define-public librewolf (inherit (make-librewolf-source #:version version #:firefox-hash "0w4z3fq5zhm63a0wmhvmqrj263bvy962dir25q3z0x5hx6hjawh2" - #:librewolf-hash "0f80pihn375bdjhjmmg2v1w96wpn76zb60ycy39wafwh1dnzybrd")) - (patches - (search-patches "librewolf-add-paths-to-rdd-allowlist.patch")))) + #:librewolf-hash "0f80pihn375bdjhjmmg2v1w96wpn76zb60ycy39wafwh1dnzybrd")))) (build-system gnu-build-system) (arguments (list @@ -592,12 +590,26 @@ (define (runpaths-of-input label) ;; For U2F and WebAuthn "eudev"))) + ;; VA-API is run in the RDD (Remote Data Decoder) sandbox + ;; and must be explicitly given access to files it needs. + ;; Rather than adding the whole store (as Nix had + ;; upstream do, see + ;; and + ;; linked upstream patches), we can just follow the + ;; runpaths of the needed libraries to add everything to + ;; LD_LIBRARY_PATH. These will then be accessible in the + ;; RDD sandbox. + (rdd-whitelist (map (cut string-append <> "/") + (delete-duplicates (append-map + runpaths-of-input + '("mesa" + "ffmpeg"))))) (gtk-share (string-append (assoc-ref inputs "gtk+") "/share"))) (wrap-program (car (find-files lib "^librewolf$")) `("LD_LIBRARY_PATH" prefix - ,libs) + (,@libs ,@rdd-whitelist)) `("XDG_DATA_DIRS" prefix (,gtk-share)) `("MOZ_LEGACY_PROFILES" = diff --git a/gnu/packages/patches/librewolf-add-paths-to-rdd-allowlist.patch b/gnu/packages/patches/librewolf-add-paths-to-rdd-allowlist.patch deleted file mode 100644 index 1bee0bddf5..0000000000 --- a/gnu/packages/patches/librewolf-add-paths-to-rdd-allowlist.patch +++ /dev/null @@ -1,11 +0,0 @@ ---- a/security/sandbox/linux/broker/SandboxBrokerPolicyFactory.cpp -+++ b/security/sandbox/linux/broker/SandboxBrokerPolicyFactory.cpp -@@ -920,6 +920,8 @@ - policy->AddDir(rdonly, "/usr/lib64"); - policy->AddDir(rdonly, "/run/opengl-driver/lib"); - policy->AddDir(rdonly, "/nix/store"); -+ policy->AddDir(rdonly, "/gnu/store"); -+ policy->AddDir(rdonly, "/run/current-system/profile/lib"); - - // Bug 1647957: memory reporting. - AddMemoryReporting(policy.get(), aPid); -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 03:41:04 2024 Received: (at 73643-done) by debbugs.gnu.org; 8 Oct 2024 07:41:04 +0000 Received: from localhost ([127.0.0.1]:50623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy4q7-00052a-RE for submit@debbugs.gnu.org; Tue, 08 Oct 2024 03:41:04 -0400 Received: from mail-pg1-f177.google.com ([209.85.215.177]:53441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy4q5-000521-I3 for 73643-done@debbugs.gnu.org; Tue, 08 Oct 2024 03:41:02 -0400 Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-656d8b346d2so3388786a12.2 for <73643-done@debbugs.gnu.org>; Tue, 08 Oct 2024 00:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728373191; x=1728977991; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3b0sc6qjmjsk5n8bWEVi6T5ViB9Xede0aYl12oCfKng=; b=F5rCtFKO8U5BDTjh6BhWaoVn/cxa6ZSbNLfXFazM04w+x3GvdoZ1dYVSQKdBNYsY9Z SkgCLqd9kdFHbhqjGsKxBnzdB8Bcr5gnpAzOl5tNyVHor/MQTaA3YDlJFekDdpZhzgRI 44/wwUK8qs5O3UYUr0NZxjXuWdE7KUjrcXFnALC5KodeVl5h6Nzn1h/EkoOXbHN4CLxR yhd0zW8ef+9ENKTl2e1OS7HLALa4KYEyM2ocS0YCXUEFZ5gSXaHHWJePOpsWRZoF5WqK JyO3Grbh6xRBO0NpzqJQgTz54+zn2SYR135yi8l1R4rnvxmEG6y811ghHN45JiO3EJQl fciw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728373191; x=1728977991; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3b0sc6qjmjsk5n8bWEVi6T5ViB9Xede0aYl12oCfKng=; b=N5h3rrtoGj4BMt6nh2f+DMAhLEIjjsPUHH0+vXuTSBOl4MXlKAEaBgVnBu10Otm2W1 acfwunR1DqLvxxg7KRVegYWC7uuFJAcA2MyinbXv+rErxeaLgAopkvK2gs8sCvCduoL3 w2HnIniF1riqmQxCwToLteCkr+hx5uXDFVNjLCxvvocMP1wjFPU/BB3iSkk94Va+hJiC VsBIgZdHi1uKBeEyE7pOSt9v7BSwpskX+h7rvchSZZdrW22n/AfnDF1hj6oJq41nOMbP +IkMtv4vRXo1PP5QDG76E58RJEHpj6i6d9wygvXjwpbcvVWcYc4tGst6+3JU8nyI9xSS 3pxA== X-Gm-Message-State: AOJu0YzFIzchQuLMU6R9uEyuDLAl7dvl7N0NCdXPDXw0gzC8x2rcW9wt p76thtcE8g/jTMAihm8Ds5pWPmv3EFF6SbHNg/61CvFBb9rF4UmgMzKHrw== X-Google-Smtp-Source: AGHT+IHGR5zrXMMitGkTt6A9ec5BBTHiHdnleQiL+t4JNKbIskwfV+CzRy5d6HJ4UESkHD5zqE5iBA== X-Received: by 2002:a05:6a20:1a99:b0:1d6:e5d3:3c2c with SMTP id adf61e73a8af0-1d6e5d33c82mr12604366637.4.1728373191002; Tue, 08 Oct 2024 00:39:51 -0700 (PDT) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0d453cesm5562731b3a.101.2024.10.08.00.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 00:39:50 -0700 (PDT) From: Maxim Cournoyer To: Ian Eure Subject: Re: [bug#73643] [PATCH 0/2] Fix LibreWolf context menu & livestreaming In-Reply-To: <20241005161305.23985-1-ian@retrospec.tv> (Ian Eure's message of "Sat, 5 Oct 2024 09:12:49 -0700") References: <20241005161305.23985-1-ian@retrospec.tv> Date: Tue, 08 Oct 2024 16:39:48 +0900 Message-ID: <8734l79h6j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73643-done Cc: 73643-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ian, Ian Eure writes: > After #73429 merged, I received reports of two problems: > > - The right-click context menu has manu duplicate and broken entries. Th= is was caused by removing the genai module, but retaining code in the chrom= e which references it. Until I find a better approach to this, I=E2=80=99v= e reverted the change. > - Livestreamed video wouldn=E2=80=99t play. This was caused by the patch= from #72265. I=E2=80=99ve reverted this, and will look into other approac= hes. > > Ian Eure (2): > gnu: librewolf: Fix broken context menu. > gnu: librewolf: Revert video acceleration fix I've pushed these two fixes, un-registering the removed patch from gnu/local.mk and refining the ChangeLog commit messages; please take a look! Thanks for the fix-up. --=20 Maxim From unknown Sat Jun 21 10:46:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 05 Nov 2024 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator