GNU bug report logs - #73637
[PATCH] New hook 'help-setup-hook'

Previous Next

Full log

Message #25 received at 73637-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eshel Yaron <me <at> eshelyaron.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 73637-done <at> debbugs.gnu.org
Subject: Re: bug#73637: [PATCH] New hook 'help-setup-hook'
Date: Sun, 6 Oct 2024 04:34:38 +0300

On 05/10/2024 16:32, Eshel Yaron wrote:
> Dmitry Gutov<dmitry <at> gutov.dev> writes:
> 
>> Have you tried going in the other direction? Meaning, killing all locals
>> by default but keeping the ones that are really needed.
>>
>> This is less backward compatible, but ultimately a more predictable and
>> common design. This seems to work okay here:
> Stefan Monnier writes:
> 
>> Looking at the patch from a distance it makes me wonder whether we
>> shouldn't call `kill-all-local-variables` instead?
>> IOW instead of listing all the vars that need to be killed, change to
>> code to preserve the few vars that should not be killed.
> SGTM, that works too and it's definitely a simpler approach.

Great! I've pushed that patch, please report any new regressions.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.