GNU bug report logs - #73635
dired-do-query-replace-regexp should check if files are selected first

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73635: closed (dired-do-query-replace-regexp should check if
 files are selected first)
Date: Sat, 19 Oct 2024 07:03:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 19 Oct 2024 10:02:09 +0300
with message-id <865xpomv7y.fsf <at> gnu.org>
and subject line Re: bug#73635: dired-do-query-replace-regexp should check if files are selected first
has caused the debbugs.gnu.org bug report #73635,
regarding dired-do-query-replace-regexp should check if files are selected first
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73635: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73635
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: dired-do-query-replace-regexp should check if files are selected first
Date: Sat, 05 Oct 2024 11:44:56 +0800

dired-do-query-replace-regexp
asks for the replace from value,
then asks for the replace to value,
and only then finally checks if any files are selected in the first
place.

It needs to check first.

E.g., yes there were files selected, but we just did a first run, and
are no longer looking at the dired buffer. We need to go back to the
dired buffer first. Fine. But at least let the user know before they
bother entering the from and to values.

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 73635-done <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#73635: dired-do-query-replace-regexp should check if files are
 selected first
Date: Sat, 19 Oct 2024 10:02:09 +0300

> Cc: 73635 <at> debbugs.gnu.org
> From: Visuwesh <visuweshm <at> gmail.com>
> Date: Sat, 05 Oct 2024 09:52:08 +0530
> 
> [சனி அக்டோபர் 05, 2024] Dan Jacobson wrote:
> 
> > dired-do-query-replace-regexp
> > asks for the replace from value,
> > then asks for the replace to value,
> > and only then finally checks if any files are selected in the first
> > place.
> >
> > It needs to check first.
> >
> > E.g., yes there were files selected, but we just did a first run, and
> > are no longer looking at the dired buffer. We need to go back to the
> > dired buffer first. Fine. But at least let the user know before they
> > bother entering the from and to values.
> 
> It uses the filename under point if there are no marked files like all
> dired commands.

Right, and so I think there's no bug here to fix, and I'm therefore
closing it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.