From unknown Sat Jun 21 02:56:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73635 <73635@debbugs.gnu.org> To: bug#73635 <73635@debbugs.gnu.org> Subject: Status: dired-do-query-replace-regexp should check if files are selected first Reply-To: bug#73635 <73635@debbugs.gnu.org> Date: Sat, 21 Jun 2025 09:56:51 +0000 retitle 73635 dired-do-query-replace-regexp should check if files are selec= ted first reassign 73635 emacs submitter 73635 Dan Jacobson severity 73635 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 23:45:11 2024 Received: (at submit) by debbugs.gnu.org; 5 Oct 2024 03:45:11 +0000 Received: from localhost ([127.0.0.1]:37094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swvjD-0000w3-E5 for submit@debbugs.gnu.org; Fri, 04 Oct 2024 23:45:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:58028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swvjB-0000sg-3M for submit@debbugs.gnu.org; Fri, 04 Oct 2024 23:45:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swvj6-0000tK-GT for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 23:45:04 -0400 Received: from iguana.tulip.relay.mailchannels.net ([23.83.218.253]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swvj4-0002bD-Lc for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 23:45:04 -0400 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 07914181D38 for ; Sat, 5 Oct 2024 03:44:59 +0000 (UTC) Received: from pdx1-sub0-mail-a207.dreamhost.com (100-96-87-216.trex-nlb.outbound.svc.cluster.local [100.96.87.216]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 92DBB181F41 for ; Sat, 5 Oct 2024 03:44:58 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1728099898; a=rsa-sha256; cv=none; b=HPq5ToP5d+RwWGfMeoGgAuJ34o+yjajxGz1V1W/TYNBDKI5Gqxjx4UJhWHuJFSB5cx3Jl5 FxOdkUcNNt1PXdkWppusJszoa2kDpKl23FQmjf+5rMd79LG0C3a2e3ePTlY40kBIirpOKR mMBJzNz6k4TULs03FxPMzZxjY+Yy0jR3jCLNQGSDQaDmKMEGh9i48rBxbWOe0DRcSxm7Sz w2BcfOkyjLjyTa/LhdBTckU7kFXvzv5ge6jruyP4gLwKBpWXAVvylc07dZZW2HBbXgAnBW SQnPHrvUZaR/Wo/AVexNFlsGwxE29Xmvzptlw622RAedVCGezt5RWET9FKRgbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1728099898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: dkim-signature; bh=MB3609t/RgX3OZ8DM2VfhRgBxuhvgtplaxwH7EwhUKs=; b=Zvf4htIrtf5ibsGRMdc+jqsmFF40Qp/sCpJ+Qif26OIh56Qf5aUeoeBjOzq849CnFE/FBt 4QNtOqetvQ10MU3GbaORDZIlHCj5JaU0smnPwF9iqm+K43jyCB/M12nsHSAcKrIa8iGzfl iNjUhFFgdHG23CoJbzSJRNw3SgohshdWIv7sxe2RhG3cfbGQzfAZk+nXzbdcYl4hUQO/8n G3x7aE7zdFReXbD1H7AkpUvs3eRzzHy9QfecNxqAZNVTYRaG6fubImgqWZ4LoK2wJ6wVRR ZO3FR1Ot5RqEOhqbpP43k8SyIsw8iWX147mYqzQizrioPUyZLONtPmBezfBD2g== ARC-Authentication-Results: i=1; rspamd-5778c966d7-rh5xd; auth=pass smtp.auth=dreamhost smtp.mailfrom=jidanni@jidanni.org X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Scare-Shrill: 0987beb152719997_1728099898809_135186992 X-MC-Loop-Signature: 1728099898809:1763207744 X-MC-Ingress-Time: 1728099898808 Received: from pdx1-sub0-mail-a207.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.96.87.216 (trex/7.0.2); Sat, 05 Oct 2024 03:44:58 +0000 Received: from jidanni.org (1-165-161-29.dynamic-ip.hinet.net [1.165.161.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a207.dreamhost.com (Postfix) with ESMTPSA id 4XLBBL3G1SzBW for ; Fri, 4 Oct 2024 20:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jidanni.org; s=dreamhost; t=1728099898; bh=MB3609t/RgX3OZ8DM2VfhRgBxuhvgtplaxwH7EwhUKs=; h=From:To:Subject:Date:Content-Type; b=VaNzhq3MHHOnxEk2zcDlft8qG6HYf1Ffvjxc0qZGSVm79+gHulJS6qmx/jHIPRB4J mMcg1AMKw/Kx0IASJhFQWoQQStr2K+J1Za5Wgju8jGFtBrIp/WWleL2Gi6m1vDogC3 KpuKNdeRnxM9WBGbK/HfJHlbcdF04HNWMAfRXf52q/1yVDuo0EhmfOV0sIA02LadTG aANqF2cKjhYEPrZBHJlhYfy4eL8wYs4SFXKeFMzigJHgh9WLs0pfqGWqAafXnLksrV zeeWeqQWpEtfEgB3orIGE6JEzWqnAh/S67A/vWOm1NWwJnuk4x6BO77rBE7lKxuFry l2QqVT8LJ3lbw== Received: from jidanni by jidanni.org with local (Exim 4.96) (envelope-from ) id 1swviz-0000ZF-1J for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2024 11:44:57 +0800 From: Dan Jacobson To: bug-gnu-emacs@gnu.org Subject: dired-do-query-replace-regexp should check if files are selected first Date: Sat, 05 Oct 2024 11:44:56 +0800 Message-ID: <87frpbb4cn.3.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=23.83.218.253; envelope-from=jidanni@jidanni.org; helo=iguana.tulip.relay.mailchannels.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) dired-do-query-replace-regexp asks for the replace from value, then asks for the replace to value, and only then finally checks if any files are selected in the first place. It needs to check first. E.g., yes there were files selected, but we just did a first run, and are no longer looking at the dired buffer. We need to go back to the dired buffer first. Fine. But at least let the user know before they bother entering the from and to values. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 00:23:26 2024 Received: (at 73635) by debbugs.gnu.org; 5 Oct 2024 04:23:26 +0000 Received: from localhost ([127.0.0.1]:37104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swwKD-0002so-T8 for submit@debbugs.gnu.org; Sat, 05 Oct 2024 00:23:26 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:46414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swwKB-0002sb-Th for 73635@debbugs.gnu.org; Sat, 05 Oct 2024 00:23:24 -0400 Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-20b6458ee37so32313425ad.1 for <73635@debbugs.gnu.org>; Fri, 04 Oct 2024 21:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728102134; x=1728706934; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M5dRcw8bBnd8fSZ+CV2awuTdv0OyEz3HQmXxYIWVnqQ=; b=gdZ3BYJ/uDWlwVj4xHylpaaNHHzU9ei+sJlFtDjPPAHAJpeI1vR4eDzmb0msHU7DUw DiiA+NrC75x5zZ1kASFrjdGzLityigB0y1Wz5n9DdP2sl+WhQlVenpcgB82lxBPVyrlq D/uC/X6Jj+9tyKj9k0fpwpa9PM3QMomA8NhBFEyR+3HfAv/r5rDVSusXLV6IlJegEAcL veCuifbnvX3yiQkBpYYPC294JgJcc5meQcuRaqGkVVS8eWz+VenL2oZOf117bCe9X6fT iRWRrZTkimC4d7RLk/HTR4ZypMNrGRk55+eX7SF7/38UF92Hk5/xULYl9c+WgnIXY/0n sJPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728102134; x=1728706934; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M5dRcw8bBnd8fSZ+CV2awuTdv0OyEz3HQmXxYIWVnqQ=; b=ngLGBejtXDWCxtI0iNSQD5qIvLTQiMppktSG0uTlFkx/mVlO+wFWMi9/UdhAYl6kl8 fTsZYN16UBnnkfFXAgGJax6/PhVRSw1ZsBM9bs94YK8WiXPyGkY6E5rmCeocF9RbN+14 VWR7wP3ZLfggfw3Pua+SjXLGnGLwAqLY4/5XLB/ZRko6umsksXv+Gvk2o8nU6Po9hGb2 /flPMoQvRacpGow+gIpSS1tVS6WPlzd93ojB5e9bKlc9xPahjDU4V+wiWOObksAZEuL4 OzXWAPczBKqbhWzGvKO+K5vWoaylxY+7oDmzWuY8WMmN7kUqDeUsxmnpfPSU34yAKF4s 5w3Q== X-Gm-Message-State: AOJu0YzOn+UU124e1gr0y3FdwtybT05jAqWL7Nr6juL5UoLa1IVX5Hkk QrUuQDUAa6Cx7hXXSDngtS8AqBZ7FB8Y1+wOQRbDi3aV9ycjQ6C2 X-Google-Smtp-Source: AGHT+IEGupLIFbIkzQPZ5YOOPN81UL0oWQLnp8mOsO+liYzuSBvlHv1MxlGLhm7TS3JJd4ywe+HsHQ== X-Received: by 2002:a17:902:f602:b0:20b:7f94:9d35 with SMTP id d9443c01a7336-20bfef3368emr85235435ad.48.1728102133627; Fri, 04 Oct 2024 21:22:13 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c1398ee12sm5867995ad.287.2024.10.04.21.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 21:22:13 -0700 (PDT) From: Visuwesh To: Dan Jacobson Subject: Re: bug#73635: dired-do-query-replace-regexp should check if files are selected first In-Reply-To: <87frpbb4cn.3.fsf@jidanni.org> (Dan Jacobson's message of "Sat, 05 Oct 2024 11:44:56 +0800") References: <87frpbb4cn.3.fsf@jidanni.org> Date: Sat, 05 Oct 2024 09:52:08 +0530 Message-ID: <87v7y7b2mn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73635 Cc: 73635@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=9A=E0=AE=A9=E0=AE=BF =E0=AE=85=E0=AE=95=E0=AF=8D=E0=AE=9F=E0=AF=8B= =E0=AE=AA=E0=AE=B0=E0=AF=8D 05, 2024] Dan Jacobson wrote: > dired-do-query-replace-regexp > asks for the replace from value, > then asks for the replace to value, > and only then finally checks if any files are selected in the first > place. > > It needs to check first. > > E.g., yes there were files selected, but we just did a first run, and > are no longer looking at the dired buffer. We need to go back to the > dired buffer first. Fine. But at least let the user know before they > bother entering the from and to values. It uses the filename under point if there are no marked files like all dired commands. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 09:35:25 2024 Received: (at control) by debbugs.gnu.org; 12 Oct 2024 13:35:26 +0000 Received: from localhost ([127.0.0.1]:43878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szcHF-0007Xg-DK for submit@debbugs.gnu.org; Sat, 12 Oct 2024 09:35:25 -0400 Received: from mail-ej1-f52.google.com ([209.85.218.52]:58551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szcHE-0007XM-1y for control@debbugs.gnu.org; Sat, 12 Oct 2024 09:35:24 -0400 Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a994ecf79e7so457008166b.0 for ; Sat, 12 Oct 2024 06:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728740044; x=1729344844; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=Yzl5HQXBOLXqkMiHts6GIHPx8zQXmELPkkMt4iNqwRc=; b=RbwOUvQkpU7hFkySn9tkhajBMI4vbiw4EzJfHHTGQnR+LQnhNfXUCS361vo4cHxJ6B AgFZURifNCE91kU0bFMRPrl21I3e/8v0FTTUgOt77LlbLPfBJH2r6KdrROpJKg0bhzmP 5UwG8QhZJt00gCKz+/gYrFEqNc8chEm1JZl5NTPyZ3aQMtS1PkWPWnLJhVjK9DIeOoGQ ehjLY2Xveg90f8Ju6vyGUiWGAi8FuYWQ+3bewdl/dIIb6V9rO8o8NKgoUlSHCQjA8iME hzuogldCZDCrwSJF2zxEkp7bQb1HCuvoFBI+xIudyZsshsHcrhyNaLn/DFto9FMyTAXh feQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728740044; x=1729344844; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Yzl5HQXBOLXqkMiHts6GIHPx8zQXmELPkkMt4iNqwRc=; b=bBlLsYYHkGMN5bcbmecKcf6FF6Ai8OQibK+NhFDYw+Wl5TmHFC1b079vwkPruWMBiP qDUbK2PONGzleToEcx31mSso9rcYYkBT8fyOQqfUNv72NProjMK2XdRefjTpBoSKcF4O ghOi7rhXckpNSr2porOZc8RQJeRVsCoLGFaH5bzfXibv+ScpMNyunEuSnu75TetcbhjW T6Q/qXHXPpX8RJ8fwhiO9FznqSh5H1UXAGvj5JXJ+/MKwtXTBZTtmaJQQ3IWLicw5wqN M7NSFohffriyy8LxISy+Zj8XOxeyOVakMJnzQFZ639SRJATCFCB76arpn7VuV4Hekrr9 84mQ== X-Gm-Message-State: AOJu0YxQfovtGTF23pU0mgYSYffolDQJmWQa2T72cw893K3W77P9y9sv ikmR0hdQ29X2/NctNr3SQ/Ss7/SvcyLqscbe+iL3iwCphH3NQBlvPAFB/kICbvYS3s1o1cipTIn a0v8Ls0R4aQ4eadMIZl6wtNIyaYqEsQ== X-Google-Smtp-Source: AGHT+IEy+ATaFWQeDNnvzxP9NKaScUuXpOS6yztFSV1UiTTgcd0PaFQBCPofa5CVVot/Kgys3hcgaVS6IFJfHqie3aE= X-Received: by 2002:a17:907:d29:b0:a99:f4be:7a6c with SMTP id a640c23a62f3a-a99f4be8860mr118171766b.52.1728740044020; Sat, 12 Oct 2024 06:34:04 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 12 Oct 2024 06:34:03 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sat, 12 Oct 2024 06:34:03 -0700 Message-ID: Subject: control message for bug #73635 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 73635 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 19 03:02:44 2024 Received: (at 73635-done) by debbugs.gnu.org; 19 Oct 2024 07:02:44 +0000 Received: from localhost ([127.0.0.1]:41078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t23U3-0006ya-Sf for submit@debbugs.gnu.org; Sat, 19 Oct 2024 03:02:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t23U1-0006yM-PT for 73635-done@debbugs.gnu.org; Sat, 19 Oct 2024 03:02:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t23TY-0000y6-Uq; Sat, 19 Oct 2024 03:02:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2EUopkGf3XhHJvP4j9zkKnt6pRyfaDlLkbmezsQcoU4=; b=XdS93yocqS1ajei+vBxi uvqorOqqZia56Hz1aIMf9uW5HNokZUrh/LA/7di8TQvDWPhhCI4UsF58Gzc14VlQ+2xN3twq4i0d9 DvpxzOTjkueXkm43wURZIrylEQIaeXrkYUgMmYusP68zPze3xCIvc/EJejqJjU1Ie1TvgIzifdNYO vtx/v3ZwFZnFUbpNjzYPAMSvINag2EJOLarmWIyz1OYkidmAPdBX361qofu5zQ7RvLL9PlqlT7uHk xrnzDS6fnwzw015nTpkARUgopT+BtuTHRpt+VxgBl+4mgWFtITbYyuFeG0LuAZPQCgr/vaSr6mBBl qT31xeBJa0n2nw==; Date: Sat, 19 Oct 2024 10:02:09 +0300 Message-Id: <865xpomv7y.fsf@gnu.org> From: Eli Zaretskii To: Visuwesh In-Reply-To: <87v7y7b2mn.fsf@gmail.com> (message from Visuwesh on Sat, 05 Oct 2024 09:52:08 +0530) Subject: Re: bug#73635: dired-do-query-replace-regexp should check if files are selected first References: <87frpbb4cn.3.fsf@jidanni.org> <87v7y7b2mn.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73635-done Cc: 73635-done@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 73635@debbugs.gnu.org > From: Visuwesh > Date: Sat, 05 Oct 2024 09:52:08 +0530 > > [சனி அக்டோபர் 05, 2024] Dan Jacobson wrote: > > > dired-do-query-replace-regexp > > asks for the replace from value, > > then asks for the replace to value, > > and only then finally checks if any files are selected in the first > > place. > > > > It needs to check first. > > > > E.g., yes there were files selected, but we just did a first run, and > > are no longer looking at the dired buffer. We need to go back to the > > dired buffer first. Fine. But at least let the user know before they > > bother entering the from and to values. > > It uses the filename under point if there are no marked files like all > dired commands. Right, and so I think there's no bug here to fix, and I'm therefore closing it. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 25 17:53:54 2024 Received: (at 73635-done) by debbugs.gnu.org; 25 Oct 2024 21:53:54 +0000 Received: from localhost ([127.0.0.1]:39703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4SFm-000310-A0 for submit@debbugs.gnu.org; Fri, 25 Oct 2024 17:53:54 -0400 Received: from glass.ash.relay.mailchannels.net ([23.83.222.70]:59553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4SFk-00030n-Pr for 73635-done@debbugs.gnu.org; Fri, 25 Oct 2024 17:53:53 -0400 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BF77B4549A; Fri, 25 Oct 2024 21:53:18 +0000 (UTC) Received: from pdx1-sub0-mail-a287.dreamhost.com (trex-8.trex.outbound.svc.cluster.local [100.103.220.31]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 751FF45497; Fri, 25 Oct 2024 21:53:18 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1729893198; a=rsa-sha256; cv=none; b=ztmAJvm3LQzF0x203bHyuu+J955x2qQm4c0W+LoGwLO10pSvYwdZdwPzKuVgYM8TBt7iPx FGPkJv+MEJOo3zlqa7/KD4K9/tpbBeljozIj9n/pEyPP0Owe7gIVQzox6SzpYHJYIESb9z yUHPSGy0K+GMx8B4NSl8XKpjQiF9f0rsTW8uudXW6DVYq02hMQwd26ubxqFeQ0rouh5gs1 8rigXCLkwlKrZqAMfFMElgHYfm6H/JecKDz0RFJZizrHAJE6m/1fYdKZjlF6e1S9QyxsRJ KoBEwAGQ5Mx7Srl7J/krBcD6NorGDZiCzXKTJEPq/Vbl8iaxpcCFOhjpUd2iug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1729893198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references:dkim-signature; bh=/9q1Q6J2eZtPJR03hR9/N3HSxQGp2gMS8NObyUvuFDY=; b=lhsmx/VTCxIFWfBmJTR69nwHyWVhzlmvJZ5irswWttpOgvUvRenx4fhQYp5GEPC3gSKUfV r+h7pYr/4wxk+v8UVzASEC9Iehj/DYt7yYLxWLRX7bav2OiDSUO3Ntajm0iQVNYW0luSAh JXcVAO1mJ+pyipzQjsxCdaq8QJMXAVUa9OooVFBrVAe/gJC63fF7kfEC/HqHkwcgf1KCjI CEOSq0SKhwi7CVtvqAAN61mUhlc3kUeHeEwEu1rXleYDfJfvnSp2fLZMcCwVoJlSZfuMif VwhZunXPyVZIevDe3mbr6pdk2BC9ltrOyqCgH2kaJUEhjbuUrmrjkTzrCMd41g== ARC-Authentication-Results: i=1; rspamd-7c89d756bb-ftlwx; auth=pass smtp.auth=dreamhost smtp.mailfrom=jidanni@jidanni.org X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Celery-Towering: 2e6dedaa1a0b7cea_1729893198680_3278483281 X-MC-Loop-Signature: 1729893198680:1735292667 X-MC-Ingress-Time: 1729893198680 Received: from pdx1-sub0-mail-a287.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.220.31 (trex/7.0.2); Fri, 25 Oct 2024 21:53:18 +0000 Received: from jidanni.org (1-165-167-217.dynamic-ip.hinet.net [1.165.167.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a287.dreamhost.com (Postfix) with ESMTPSA id 4XZxNt2C2BzBF; Fri, 25 Oct 2024 14:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jidanni.org; s=dreamhost; t=1729893198; bh=/9q1Q6J2eZtPJR03hR9/N3HSxQGp2gMS8NObyUvuFDY=; h=From:To:Cc:Subject:Date:Content-Type; b=ykT4YJKgoTD5B5N3iB16cZk4veZykK3BMv0bP054oHexYnAW4AJKwcCHmNzJ8J76e 1NiiU53re9vBzKPUNpA4imnsn/aIISU0Qxn5pSSDulR7RfD7IcIveSgONbbAdS/G/L 6gKM8ciGNzIs7Wr9lVF5CuTKDbJLvBIIfl74vKSW0/OPHGiDl0L2D/B4gULqVkIdm2 1mNalOCz+UQMy2kOG6X117QCgHc20r9TV/phErRT3NtE+CzfZYNKY2iNHiGF+LS0sC J7Rx35YdZ/ShJrmLK2XsBWgoluC6FPcURpyquZaTE3bxsyPUXgqvzq6XlE27uPCLEP PNXQaW0y2l9Pg== Received: from jidanni by jidanni.org with local (Exim 4.96) (envelope-from ) id 1t4SF8-0001m2-3B; Sat, 26 Oct 2024 05:53:15 +0800 From: Dan Jacobson To: Eli Zaretskii Subject: Re: bug#73635: dired-do-query-replace-regexp should check if files are selected first References: <87frpbb4cn.3.fsf@jidanni.org> <87v7y7b2mn.fsf@gmail.com> <865xpomv7y.fsf@gnu.org> Date: Sat, 26 Oct 2024 05:53:14 +0800 Message-ID: <878qubsvcl.3.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73635-done Cc: 73635-done@debbugs.gnu.org, Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > E.g., yes there were files selected, but we just did a first run, and >> > are no longer looking at the dired buffer. We need to go back to the >> > dired buffer first. Fine. But at least let the user know before they >> > bother entering the from and to values. >> >> It uses the filename under point if there are no marked files like all >> dired commands. EZ> Right, and so I think there's no bug here to fix, and I'm therefore EZ> closing it. There is no check that the user is staring at the dired buffer first before asking for the two strings. So the user thinks they can mark some files, have a look at one, and then do dired-do-query-replace-regexp... and it asks for the two strings, and then says they have not selected any files. But they did select the files. But they need to be back in the dired buffer before running dired-do-query-replace-regexp. So dired-do-query-replace-regexp should tell them that, instead of asking them for the two strings. In fact what needs to be changed is: dired-do-query-replace-regexp needs to first check if the current buffer is a dired buffer. And if it is not, it needs to say "Must be run in a dired buffer" and quit. (Even if there is only one dired buffer in buffer-list.) From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 26 03:00:23 2024 Received: (at 73635) by debbugs.gnu.org; 26 Oct 2024 07:00:23 +0000 Received: from localhost ([127.0.0.1]:40400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4amd-00041R-5g for submit@debbugs.gnu.org; Sat, 26 Oct 2024 03:00:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4ama-00041A-UH for 73635@debbugs.gnu.org; Sat, 26 Oct 2024 03:00:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4aly-0000Pd-FW; Sat, 26 Oct 2024 02:59:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U/rUb4qLVKDoihu7W2eXR8KZK3Hlho8y7kKejogugdI=; b=Ve5wAeEpbClS GEeLIuf/J47fsYBvFLT1nLI43z0YdlNI83sixfda1OEHVnVnMGlJoxqwsIIoYE4yDT7vuWUOviBLu JEuzfXwPzoMtT1KDEqMX1bc7Rdg4CPKcMprJ7MZ+yT00S02amdFpwPvEk9ZlZD1wmKPNnP4Er6bmL +1j+npf4IYb5yUEeeZyKwVxtTcH4OjrwbjFCUsMz4jtx4PAhbIrHVrIhJxG9gevfVM+7ERDhaaFid hA9dva92vtWkSlN73TUWR2fu6sQlEGrZ7GVF0CzeqAvqN0yADr6Rb+PfoGPHsJAYXe2WCVB3cXIC3 6udcNJcP1aZmffLLojIihw==; Date: Sat, 26 Oct 2024 09:59:39 +0300 Message-Id: <867c9vbb8k.fsf@gnu.org> From: Eli Zaretskii To: Dan Jacobson In-Reply-To: <878qubsvcl.3.fsf@jidanni.org> (message from Dan Jacobson on Sat, 26 Oct 2024 05:53:14 +0800) Subject: Re: bug#73635: dired-do-query-replace-regexp should check if files are selected first References: <87frpbb4cn.3.fsf@jidanni.org> <87v7y7b2mn.fsf@gmail.com> <865xpomv7y.fsf@gnu.org> <878qubsvcl.3.fsf@jidanni.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73635 Cc: 73635@debbugs.gnu.org, visuweshm@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Dan Jacobson > Cc: Visuwesh , 73635-done@debbugs.gnu.org > Date: Sat, 26 Oct 2024 05:53:14 +0800 > > >> > E.g., yes there were files selected, but we just did a first run, and > >> > are no longer looking at the dired buffer. We need to go back to the > >> > dired buffer first. Fine. But at least let the user know before they > >> > bother entering the from and to values. > >> > >> It uses the filename under point if there are no marked files like all > >> dired commands. > > EZ> Right, and so I think there's no bug here to fix, and I'm therefore > EZ> closing it. > > There is no check that the user is staring at the dired buffer first > before asking for the two strings. When this command is invoked, it prompts thusly: Query replace regexp in marked files: Which already says that files should be marked before they could be query-replaced. > In fact what needs to be changed is: > dired-do-query-replace-regexp needs to first check if the current buffer > is a dired buffer. That already happens if you invoke with "M-X" (capital X) or if you customize read-extended-command-predicate to command-completion-default-include-p. We just decided not to make that the default yet. > And if it is not, it needs to say "Must be run in a dired buffer" and > quit. > > (Even if there is only one dired buffer in buffer-list.) I see no reason to complicate the command to cover such made-up scenarios. If and when we decide to make command-completion-default-include-p the default, this will happen automatically. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 26 04:59:36 2024 Received: (at 73635) by debbugs.gnu.org; 26 Oct 2024 08:59:36 +0000 Received: from localhost ([127.0.0.1]:40561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4ce0-0001On-6c for submit@debbugs.gnu.org; Sat, 26 Oct 2024 04:59:36 -0400 Received: from skyblue.cherry.relay.mailchannels.net ([23.83.223.167]:32019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4cdx-0001Of-OT for 73635@debbugs.gnu.org; Sat, 26 Oct 2024 04:59:34 -0400 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C4DB31C1E9D; Sat, 26 Oct 2024 08:58:59 +0000 (UTC) Received: from pdx1-sub0-mail-a259.dreamhost.com (100-99-177-130.trex-nlb.outbound.svc.cluster.local [100.99.177.130]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 77E6C1C14C4; Sat, 26 Oct 2024 08:58:59 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1729933139; a=rsa-sha256; cv=none; b=sxziso3DIcxIlYnwqX8zj3sjNdrAXUul5IX2nW6rFxCLMlpyukMBmgE2M5CaSviJvDkq8H SJV5bwIQ9Poa+6yOVgG5G610OwT/A3csp2BzvuVMWdKTMYJUmy7d+CXrSDqE8TzHg4ELny ZFZZnZ5mKpMl9SaKzj4/EbRys3bGCdBud1+oPxfEqxHQxY3iHzPi5ZBMvV+W7+mZHwb4BV mcJMBVIucdkcLehIq5ZD0xZq5u5UjSGdZqPtzGblXI4AAqrCEatAVg5sDOmwNJD13pa/RW 71Y0TivHCL/fMqzXlnm+gabv7J/AG6tRQpoM4YYul/zzSbh8iiTSsjdXyMZH7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1729933139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references:dkim-signature; bh=RsxR8xn+mdmKRy1QfSvpdjmeN64WmkBfidmwyoHwy5I=; b=aGwrNIL1X7yRQHx2YKsdtJrMki96xW8stuSpSLlstZmM/FowPAid+G9mTXF+nvSWL/6GN3 lzKHqSxkGRSeCOnFDrtf66ghO6gRYQw2R3SJuF3a7w2D1VA56jX7qU+z3HUB5JGd9CmyZR BXN0PcwsHPDY51Tqgni2zVSK8J8WNMUkPInsiTnnzLwFxJxa+S7i3jFNO+6ycwfp+PB+yE yYn8FauuYMupFTiRrJvXUg2+oxtHOzhhTrmss+mNoe9HW42rYTX9+CtKc96P+mf2OEpjAW AS79CrQkCYY1ouYaAv9IxYC5pa/7WIYn5lDkTwZBcarwHh7raqWKmTnzeaEL8A== ARC-Authentication-Results: i=1; rspamd-7fb5679c85-94lbq; auth=pass smtp.auth=dreamhost smtp.mailfrom=jidanni@jidanni.org X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Hook-Language: 36e3c2cb617dc067_1729933139716_164817988 X-MC-Loop-Signature: 1729933139716:1003334898 X-MC-Ingress-Time: 1729933139716 Received: from pdx1-sub0-mail-a259.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.99.177.130 (trex/7.0.2); Sat, 26 Oct 2024 08:58:59 +0000 Received: from jidanni.org (1-165-167-217.dynamic-ip.hinet.net [1.165.167.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a259.dreamhost.com (Postfix) with ESMTPSA id 4XbD8z2NfFzB7; Sat, 26 Oct 2024 01:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jidanni.org; s=dreamhost; t=1729933139; bh=RsxR8xn+mdmKRy1QfSvpdjmeN64WmkBfidmwyoHwy5I=; h=From:To:Cc:Subject:Date:Content-Type; b=HwANkffx4pDJ7dNmMnmwpR1Yaitup/SpvD+06L22bGxYuUZUUsKTImtdNNJkYcLK/ 1Ah6FrISpyBXQOdF6OR7ixwm+Rggim0T9w+y/StA6v01iVoSBT3Ko87N+Qg2jTrOAw gjvtAM30vcpdoxLjHXQnx6acp1kFM5N7I5XX6p/SeXVBN48VvRmEYbYkrcjFb17eY5 R+LHQD0w6oS4OyECOmTzn88yJDRAeF5MsFBVAMdzR93uZfkJ4/Kj1EG+5C2RsU5HsX uslpfRgntN2ZZLKOByqQ7M3gm8rCNVP4+aqpoKf3LoeVpwox30Es100o2zKDg4IZQV LUTN4em95Db/g== Received: from jidanni by jidanni.org with local (Exim 4.96) (envelope-from ) id 1t4cdT-0002DQ-1W; Sat, 26 Oct 2024 16:59:03 +0800 From: Dan Jacobson To: Eli Zaretskii Subject: Re: bug#73635: dired-do-query-replace-regexp should check if files are selected first References: <87frpbb4cn.3.fsf@jidanni.org> <87v7y7b2mn.fsf@gmail.com> <865xpomv7y.fsf@gnu.org> <878qubsvcl.3.fsf@jidanni.org> <867c9vbb8k.fsf@gnu.org> Date: Sat, 26 Oct 2024 16:59:03 +0800 Message-ID: <87sesjnstk.3.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73635 Cc: 73635@debbugs.gnu.org, visuweshm@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> "EZ" == Eli Zaretskii writes: EZ> I see no reason to complicate the command to cover such made-up EZ> scenarios. If and when we decide to make EZ> command-completion-default-include-p the default, this will happen EZ> automatically. OK, it's a deal. From unknown Sat Jun 21 02:56:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 23 Nov 2024 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator