Subject: bug#73635: closed (Re: bug#73635: dired-do-query-replace-regexp should check if files are selected first)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 19 Oct 2024 07:03:02 +0000

Your bug report

#73635: dired-do-query-replace-regexp should check if files are selected first

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
73635: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73635
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#73635: dired-do-query-replace-regexp should check if files are selected first
From: Eli Zaretskii <[email-masked]>
To: Visuwesh <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Sat, 19 Oct 2024 10:02:09 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> Cc: [email-masked]
> From: Visuwesh <[email-masked]>
> Date: Sat, 05 Oct 2024 09:52:08 +0530
> 
> [சனி அக்டோபர் 05, 2024] Dan Jacobson wrote:
> 
> > dired-do-query-replace-regexp
> > asks for the replace from value,
> > then asks for the replace to value,
> > and only then finally checks if any files are selected in the first
> > place.
> >
> > It needs to check first.
> >
> > E.g., yes there were files selected, but we just did a first run, and
> > are no longer looking at the dired buffer. We need to go back to the
> > dired buffer first. Fine. But at least let the user know before they
> > bother entering the from and to values.
> 
> It uses the filename under point if there are no marked files like all
> dired commands.

Right, and so I think there's no bug here to fix, and I'm therefore
closing it.

Subject: dired-do-query-replace-regexp should check if files are selected first
From: Dan Jacobson <[email-masked]>
To: [email-masked]
Date: Sat, 05 Oct 2024 11:44:56 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

dired-do-query-replace-regexp
asks for the replace from value,
then asks for the replace to value,
and only then finally checks if any files are selected in the first
place.

It needs to check first.

E.g., yes there were files selected, but we just did a first run, and
are no longer looking at the dired buffer. We need to go back to the
dired buffer first. Fine. But at least let the user know before they
bother entering the from and to values.