GNU bug report logs - #73604
[PATCH] Properly operate on current fileset revision in vc-hg-print-log

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: dmitry <at> gutov.dev, 73604 <at> debbugs.gnu.org, spwhitton <at> spwhitton.name
Subject: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log
Date: Sat, 12 Oct 2024 10:36:46 +0300

> From: Spencer Baugh <sbaugh <at> janestreet.com>
> Cc: Dmitry Gutov <dmitry <at> gutov.dev>,  Eli Zaretskii <eliz <at> gnu.org>,
>    73604 <at> debbugs.gnu.org
> Date: Fri, 11 Oct 2024 16:53:29 -0400
> 
>  (defun vc-hg-print-log (files buffer &optional shortlog start-revision limit)
>    "Print commit log associated with FILES into specified BUFFER.
>  If SHORTLOG is non-nil, use a short format based on `vc-hg-root-log-format'.
> -If START-REVISION is non-nil, it is the newest revision to show.
> -If LIMIT is non-nil, show no more than this many entries."
> +If LIMIT is non-nil, show no more than this many entries.

This should say that LIMIT must be a positive integer number.

> +If START-REVISION is nil, the commit log is printed starting from the
                             ^^^^^^^^^^^^^^^^^^^^^^^^^
Passive tense alert!

> +working directory parent (revset \".\").  If START-REVISION is non-nil,
> +the log is printed starting from that revision."
       ^^^^^^^^^^^^^^
Same here.  In addition, I'm guessing START-REVISION must be a string,
right?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.