From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 15:21:28 2024 Received: (at submit) by debbugs.gnu.org; 2 Oct 2024 19:21:28 +0000 Received: from localhost ([127.0.0.1]:59272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw4ue-0003GT-4e for submit@debbugs.gnu.org; Wed, 02 Oct 2024 15:21:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:53958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw4uc-0003GL-G1 for submit@debbugs.gnu.org; Wed, 02 Oct 2024 15:21:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sw4ua-0002h0-TT for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2024 15:21:24 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sw4uY-0005vN-Lf for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2024 15:21:24 -0400 From: Spencer Baugh To: bug-gnu-emacs@gnu.org Subject: [PATCH] Properly operate on current fileset revision in vc-hg-print-log Date: Wed, 02 Oct 2024 15:21:20 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1727896881; bh=jyTCAaowMhfyGHTQatCbNNE7jFciaMRx0uXXTtSclkY=; h=From:To:Subject:Date; b=pswmJGBQwYGsYjJHosriNxDLPKlCJyVGX0typbU1m27fXzLNR5oGqxVRKzB/tRtT+ jY7RxVfQADODvnpySMGTRRMmrYSlQ+UG4xRqxGd6QNJ5na6DzIu1sV3bjLhzFKjH3l gAgx88c70lMnQdzEmTdbxo+5Zzdr1XcsblhMkWjMzib4l4dmmLefpHICD3CriXXCWl 0LG6doVWju5m6ciTAWiZgSkPOtiv5FeApa6p0B3bI8sKoTEqJfOLg9xsUUrQvpeiqn DFhus16a3P7eAJKhyL4blhLuGexUi3W4TlNh7L8yJ1GhHxfPzzR55qi4ruSAjGTXSF sxLddbYX6Z6CQ== Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@janestreet.com; helo=mxout5.mail.janestreet.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch If hg log doesn't receive a -r argument, it logs starting from the most recent commit created anywhere ("tip"). But vc-print-log is supposed to log starting from the working revision ("."). Those are usually the same, but not always; the current fileset might not even exist in "tip". Fix this by just logging "." if no START-REVISION is passed to vc-hg-print-log. * lisp/vc/vc-hg.el (vc-hg-print-log): If start-revision is nil, reliably log the working revision. In GNU Emacs 29.2.50 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.12, Xaw scroll bars) of 2024-09-23 built on igm-qws-u22796a Repository revision: 340ed90ce4518de238610461047b6c8767ca0cdc Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Rocky Linux 8.10 (Green Obsidian) Configured using: 'configure --with-x-toolkit=lucid --without-gpm --without-gconf --without-selinux --without-imagemagick --with-modules --with-gif=no --with-tree-sitter --with-native-compilation=aot PKG_CONFIG_PATH=/usr/local/home/garnish/libtree-sitter/0.22.6-1/lib/pkgconfig/' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Properly-operate-on-current-fileset-revision-in-vc-h.patch >From 2af767a869fd9ac5b959bc5382ac09e38fc735af Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Wed, 2 Oct 2024 15:20:31 -0400 Subject: [PATCH] Properly operate on current fileset revision in vc-hg-print-log If hg log doesn't receive a -r argument, it logs starting from the most recent commit created anywhere ("tip"). But vc-print-log is supposed to log starting from the working revision ("."). Those are usually the same, but not always; the current fileset might not even exist in "tip". Fix this by just logging "." if no START-REVISION is passed to vc-hg-print-log. * lisp/vc/vc-hg.el (vc-hg-print-log): If start-revision is nil, reliably log the working revision. --- lisp/vc/vc-hg.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el index c0afb225871..58a2df3469f 100644 --- a/lisp/vc/vc-hg.el +++ b/lisp/vc/vc-hg.el @@ -408,8 +408,8 @@ vc-hg-print-log (with-current-buffer buffer (apply #'vc-hg-command buffer 'async files "log" + (format "-r%s:0" (or start-revision ".")) (nconc - (when start-revision (list (format "-r%s:0" start-revision))) (when limit (list "-l" (format "%s" limit))) (when (eq vc-log-view-type 'with-diff) (list "-p")) -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 22:16:54 2024 Received: (at 73604) by debbugs.gnu.org; 3 Oct 2024 02:16:54 +0000 Received: from localhost ([127.0.0.1]:59554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swBOc-0000oC-RA for submit@debbugs.gnu.org; Wed, 02 Oct 2024 22:16:54 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:43404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swBOa-0000nv-Je for 73604@debbugs.gnu.org; Wed, 02 Oct 2024 22:16:49 -0400 DKIM-Signature: a=rsa-sha256; b=tAoQOLUtHv6PxntdsFHCuMdfuu1ZFrAAbIGIIJAAkAtJUjJ9n+/cbLhDdJvrI7OtIX7mCLpnFAALlm5wKaUBtM3fyp1kIx7sfsnWT+i/vhg38BNORZXFEoaY4qBkaPJ41b4dxVWjAEaYV01RMVw+DJ546ughxIotzQ/+1KVzi7baWKmVfl2LSnbmtbLNE4TDLMBJCzFzhfOeGRZ5DEc2m9swo/hA3p9D6kkNTVE+wXujHLqdUeelyLT/pUgNC4soJBXNwo58DlavwwDr+GpQcQbWT/ctcmzr+p8pkP1lutaHU+8mjuuThGo+N8I2QdoI5xg4EyvuGsbc7yeRrm9yAA==; s=purelymail2; d=spwhitton.name; v=1; bh=H5NhV1bdSu6e813k4dOqs3vHq4S+IGxQUHmOpMe/dcc=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=b3zfYqH7DoIC7bOe/W61Lzwn8nPazu0jOo28XEnEdBxIJw3B5TdNh4SRGWCvCR4mFOQdRy6YCW8bLVz5vMZ4AoFQx8bOdAFMpK4X9FF0o/gqbRzEbsw2Gia7MHWvvNSUAxoQ7/oIx4aNrc/6rQh2eFozjZcopHRuKsPUm6OR4UK1RturyiXWu37T0aIsES35+tCbKl8awSywRQy3zfRUhuH9hp2OxX5wqq7ezuSPmbLBbcxhR6iErEsjI7G/KTFJNWHjnsVag+98vgPTe4QhntweMK5dEViPhPDeGJ8cE4Bwse6PSesO6dEnAcMAbTjgevEz0GEGvnhF1V+1wbDXqQ==; s=purelymail2; d=purelymail.com; v=1; bh=H5NhV1bdSu6e813k4dOqs3vHq4S+IGxQUHmOpMe/dcc=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73604@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 536067493; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 03 Oct 2024 02:16:36 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 7BEEB7E3B8A; Thu, 3 Oct 2024 10:16:33 +0800 (CST) From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log In-Reply-To: (Spencer Baugh via's message of "Wed, 02 Oct 2024 15:21:20 -0400") References: Date: Thu, 03 Oct 2024 10:16:33 +0800 Message-ID: <87o7422any.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73604 Cc: Spencer Baugh , 73604@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli, can this go on emacs-30? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 02:51:13 2024 Received: (at 73604) by debbugs.gnu.org; 3 Oct 2024 06:51:13 +0000 Received: from localhost ([127.0.0.1]:59789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swFg9-0008RE-CK for submit@debbugs.gnu.org; Thu, 03 Oct 2024 02:51:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swFg5-0008R0-Te for 73604@debbugs.gnu.org; Thu, 03 Oct 2024 02:51:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swFfw-0000Oy-Ty; Thu, 03 Oct 2024 02:51:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pRdyPdI7/TpNuelTVATMhQFTtqz1MkWaTn4JdSlUcHM=; b=qhnCmeu/+sUb e4xGuVpYzaZ88dE0Ne6y/cRRQ+VQ9/JcLc4SH4GgqKe7m2IxU6v5pJAz4OrQg1Wav7KcWSpzhruc4 9Sssg3NuFuwk7Rfs7jtAAc0olV6jpl+SKHpJjRtIYfEcL1V9qC+8Vi5+zllM756kLYPlJemTJba6h mLeEFZSR7NZnChkGOEjvYdmfGgsBb4jMLTx07xr2JOQmOEaiBI4sh2WkhjA8Va1Fy3DWFnIBsCgGr M1pd01Odo1UGoNGdmSrLorDHn3TquQZows54GGCJ469ZQ80GBn0lzxuYcETnuCZlDOyJVJCmdKbFY Cg7VsY4enSX4BSNIVyKj2g==; Date: Thu, 03 Oct 2024 09:50:56 +0300 Message-Id: <86o741znlb.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton , Dmitry Gutov In-Reply-To: <87o7422any.fsf@melete.silentflame.com> (message from Sean Whitton on Thu, 03 Oct 2024 10:16:33 +0800) Subject: Re: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log References: <87o7422any.fsf@melete.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73604 Cc: sbaugh@janestreet.com, 73604@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Cc: Spencer Baugh , 73604@debbugs.gnu.org > Date: Thu, 03 Oct 2024 10:16:33 +0800 > > Eli, can this go on emacs-30? Why is it important enough to install on emacs-30? The situation sounds quite rare to me. Moreover, I'm not sure the change is correct in general. If you invoke "C-x v l" with an argument, the prompt says "...(default: last revision)". It says "last", and doesn't say anything about the working revision. So I don't understand why you say the current operation of the command is incorrect even when the tip and the current working revision are different. I think this is precisely a use case where the user should invoke the command with a prefix arg and specify the revision from which to start. Am I missing something? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 03:05:07 2024 Received: (at 73604) by debbugs.gnu.org; 3 Oct 2024 07:05:07 +0000 Received: from localhost ([127.0.0.1]:59811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swFtb-0000gh-2N for submit@debbugs.gnu.org; Thu, 03 Oct 2024 03:05:07 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:56010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swFtY-0000eL-J2 for 73604@debbugs.gnu.org; Thu, 03 Oct 2024 03:05:05 -0400 DKIM-Signature: a=rsa-sha256; b=dJY34sACHZSKJe1CTt50ScXRO0vtxNjXFqqaWltvJ2pUPEctDTrn9G5VAmCakBP/foWozM2Fcz5PoZb/BpoKyJfEziQKnaymPoH3omxmJO2sF851Vy8NTB1rISgzZfgzCez+A00c9S2vW/VzrViDmB+xXtsKoyQ1KkJgjL8lei7L/xajcl9mj7BYjMf7NWjf4hh7NToTC+8kDVSPjEmbguD9ANjDQRaJTkf0lx0Fp2KTi2tluPdx945NFyenqhv3Wd9hgnkgMvRsaScRTldm/DiltHirEPrbAqmZuV0HQ9LwxZfwu+kAJeklRRYvjfTuR9OB/ICG5uPulmUS6YkYGw==; s=purelymail2; d=spwhitton.name; v=1; bh=rIqyqUVGwxByME0l9+LUBdjmaBQeuFILGWDp+Bio5YM=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=CxLVwBKUo/5MPYCNohqghbAhYXmUwzBK2W2ufcofvU29MU+VIY4xoFCSGlwQLiHsIw5g1jYxsawHd+sh9cl5y1EbViGXWXgBNknTvq6GjhUOF+8kSv0aym6e1rgpUJygnzyyS6yZj3NLogtP4dAMsojw6DrGBDNLBJylyjfYhCrHxpgCgWyQV2lfqcy2CNpGPnJ/f48u2ZZFoOxfcPKdroq3bsO2T7pdyxAuyWVsPGUDy9YslPglIy847tV/js4IAfDVwLXcm32l+8d0cAkapI/a+Rn5/CO7AS6BxPWYGEhecKOdw0uDYodf6H29rKzvEErCvvPS7SKqhmbK+cmXag==; s=purelymail2; d=purelymail.com; v=1; bh=rIqyqUVGwxByME0l9+LUBdjmaBQeuFILGWDp+Bio5YM=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73604@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1414736344; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 03 Oct 2024 07:04:56 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id B23427E0C67; Thu, 3 Oct 2024 15:04:51 +0800 (CST) From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log In-Reply-To: <86o741znlb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 03 Oct 2024 09:50:56 +0300") References: <87o7422any.fsf@melete.silentflame.com> <86o741znlb.fsf@gnu.org> Date: Thu, 03 Oct 2024 15:04:51 +0800 Message-ID: <87o741zmy4.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73604 Cc: Dmitry Gutov , 73604@debbugs.gnu.org, sbaugh@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Thu 03 Oct 2024 at 09:50am +03, Eli Zaretskii wrote: >> From: Sean Whitton >> Cc: Spencer Baugh , 73604@debbugs.gnu.org >> Date: Thu, 03 Oct 2024 10:16:33 +0800 >> >> Eli, can this go on emacs-30? > > Why is it important enough to install on emacs-30? The situation > sounds quite rare to me. Yeah, it's relatively rare, but I was thinking that it would be appropriate because of the simplicity of the fix. Anyway, master is fine, I just wanted to ask. > Moreover, I'm not sure the change is correct in general. If you > invoke "C-x v l" with an argument, the prompt says "...(default: last > revision)". It says "last", and doesn't say anything about the > working revision. So I don't understand why you say the current > operation of the command is incorrect even when the tip and the > current working revision are different. I think this is precisely a > use case where the user should invoke the command with a prefix arg > and specify the revision from which to start. Well, the description of C-x v l is Show in another window the VC change history of the current fileset. If the current fileset doesn't exist in tip, then we'd better not just log tip. Possibly the prompt should also change. Let's see what Spencer thinks. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 11:18:47 2024 Received: (at 73604) by debbugs.gnu.org; 3 Oct 2024 15:18:47 +0000 Received: from localhost ([127.0.0.1]:33743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swNbL-0001j0-Bm for submit@debbugs.gnu.org; Thu, 03 Oct 2024 11:18:47 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:55089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swNbJ-0001il-7N for 73604@debbugs.gnu.org; Thu, 03 Oct 2024 11:18:45 -0400 From: Spencer Baugh To: Sean Whitton Subject: Re: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log In-Reply-To: <87o741zmy4.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 03 Oct 2024 15:04:51 +0800") References: <87o7422any.fsf@melete.silentflame.com> <86o741znlb.fsf@gnu.org> <87o741zmy4.fsf@melete.silentflame.com> Date: Thu, 03 Oct 2024 11:18:37 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1727968717; bh=6cEmlXtnI5pPRrhrXINRPsqu+PPUWFfD2PaMD69WNaQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=ljvJTwmsn2liOWtEwqFxXgff9g8m8042NV+jhkqQVVNK+PLDaWpItLF/3j3UtS+Xl i9EnAPaNlIl9NXcXgZQ0gx1Yj11fFDNgFkRSF9idLxyKfUhAayvyZg52BhoHhcO74L fjzG5T+LAyeQPK3v5Ax2fIsQq/bLF6950+PXw878q+MhvsW1KUDcz5DOoM+787kEBE 9d7vaEVrV++xdMgGGK3mszpIu5WzOLxksPcq9vgkfucygR+L3uePRok1mCOaFB98YP 7CQ16ITDzsFAkskLuLcTdtIPsSthJ9ZVlo5kSlqFnB3DpWKpqk5xvjdQVBqvHMwZlg lU1VotikpjhvQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73604 Cc: Dmitry Gutov , Eli Zaretskii , 73604@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > Hello, > > On Thu 03 Oct 2024 at 09:50am +03, Eli Zaretskii wrote: > >>> From: Sean Whitton >>> Cc: Spencer Baugh , 73604@debbugs.gnu.org >>> Date: Thu, 03 Oct 2024 10:16:33 +0800 >>> >>> Eli, can this go on emacs-30? >> >> Why is it important enough to install on emacs-30? The situation >> sounds quite rare to me. > > Yeah, it's relatively rare, but I was thinking that it would be > appropriate because of the simplicity of the fix. Anyway, master is > fine, I just wanted to ask. I'm in no rush to put this on emacs-30 (I've already backported it for my users anyway) >> Moreover, I'm not sure the change is correct in general. If you >> invoke "C-x v l" with an argument, the prompt says "...(default: last >> revision)". It says "last", and doesn't say anything about the >> working revision. So I don't understand why you say the current >> operation of the command is incorrect even when the tip and the >> current working revision are different. I think this is precisely a >> use case where the user should invoke the command with a prefix arg >> and specify the revision from which to start. > > Well, the description of C-x v l is > > Show in another window the VC change history of the current fileset. > > If the current fileset doesn't exist in tip, then we'd better not just > log tip. > > Possibly the prompt should also change. Let's see what Spencer thinks. I think you both may be misinterpreting this prompt - the typed-in revision doesn't actually specify where the log starts. It doesn't affect what goes in the buffer at all; the value typed in doesn't get passed to 'print-log at all. The prompt is just about where point goes in the buffer - "last revision" just means that point starts at point-min. Typing a revision at the prompt just moves point to that revision. (This is of course extremely confusing; I have definitely typed revisions in the vc-print-log prompt and expected them to change the log output. Maybe this prompt and command should be changed in other ways, but let's defer that for other bugs. Also note that this is very different behavior from M-1 C-x v L (vc-print-root-log), where typing a revision at the prompt *does* change what's logged.) So, anyway, that prompt says nothing about what actual logs should print with vc-print-log. And (potentially) including commits which don't even contain the current fileset seems very wrong. Note also that the print-log docs also say: ;; If START-REVISION is given, then show the log starting from that ;; revision ("starting" in the sense of it being the _newest_ ;; revision shown, rather than the working revision, which is normally ;; the case). vc-print-log always passes nil for START-REVISION, so it seems we expect to start from the working revision. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 11 00:43:29 2024 Received: (at 73604) by debbugs.gnu.org; 11 Oct 2024 04:43:29 +0000 Received: from localhost ([127.0.0.1]:32969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sz7Uv-0007qW-2g for submit@debbugs.gnu.org; Fri, 11 Oct 2024 00:43:29 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:46520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sz7Us-0007qB-LM for 73604@debbugs.gnu.org; Fri, 11 Oct 2024 00:43:27 -0400 DKIM-Signature: a=rsa-sha256; b=XWXs31SU+zoZiAdt3uWnzwc7xqYnULbzfrmG/S+PCFeYUtIgS/B6cjFgL7fDEH1ZhfiBmsprz6wMgL3tsyAZkBhbjB1qPpbXN2ujkU4fEm8DiAK9HUezgObOhuJ+JWtxH0kqrj9I2nqy9a77umX4nPcliLvpNd9B7b50A/+7cFf9Gel4dU7Ye6spYWhwkVpXLwfbwyjLnVKlbtwLlrO3XbuvKw3Tg67tK5TIN708FATIDUAqUxiszdDUOsGPqer5ih8HkD1iOcvl/CdmSRtxD+K1B6o6KIyzDuL4bhiUFoyZEvDGEnjFnlyfVWEgm5uH1VDm1MAJdnT+HbVDLoSkew==; s=purelymail3; d=spwhitton.name; v=1; bh=RXFDKeyxI0xzDlLekgw8qRKua9ZpL4UxffZgUZhjYHc=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=cR8lFvWd0A+8dxhUJpCF4L3rAx8YfZGa1DGxOxyeF/JD2wBEFoelWsA0qNCNQIWoNKJr74ggYkT2XSEVZBBzQ5BxMH9oMBE+Y5GZQ6vVk13tW+aW0ClfF+iOYHVVhifD5cVfxgcSOnNdK7Njz0436N+yEX3l63Yfq9VyRxVeoOj1Tucq/Q7dtBN7K9kw6L3ehlMR+2Aog8XQvcj2rs0SEs523pzx0fPko3xs8HOaQxxN1NyGXY9bYy9xGzxdWBVfWglTS47Y4yTSiauBh01r+i+M9CQaYim+WCBTB1LzoV257gA+mDXQ77KK31NCq45WsvbZ6CZATbtLwze0qzSzkg==; s=purelymail3; d=purelymail.com; v=1; bh=RXFDKeyxI0xzDlLekgw8qRKua9ZpL4UxffZgUZhjYHc=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73604@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1363127593; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 11 Oct 2024 04:43:07 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id E35E97E7EBE; Fri, 11 Oct 2024 12:43:02 +0800 (CST) From: Sean Whitton To: Spencer Baugh Subject: Re: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log In-Reply-To: (Spencer Baugh's message of "Thu, 03 Oct 2024 11:18:37 -0400") References: <87o7422any.fsf@melete.silentflame.com> <86o741znlb.fsf@gnu.org> <87o741zmy4.fsf@melete.silentflame.com> Date: Fri, 11 Oct 2024 12:43:02 +0800 Message-ID: <875xpz45d5.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73604 Cc: Dmitry Gutov , Eli Zaretskii , 73604@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Thu 03 Oct 2024 at 11:18am -04, Spencer Baugh wrote: > I think you both may be misinterpreting this prompt - the typed-in > revision doesn't actually specify where the log starts. It doesn't > affect what goes in the buffer at all; the value typed in doesn't get > passed to 'print-log at all. > > The prompt is just about where point goes in the buffer - "last > revision" just means that point starts at point-min. Typing a revision > at the prompt just moves point to that revision. > > (This is of course extremely confusing; I have definitely typed > revisions in the vc-print-log prompt and expected them to change the log > output. Maybe this prompt and command should be changed in other ways, > but let's defer that for other bugs. Also note that this is very > different behavior from M-1 C-x v L (vc-print-root-log), where typing a > revision at the prompt *does* change what's logged.) > > So, anyway, that prompt says nothing about what actual logs should print > with vc-print-log. And (potentially) including commits which don't even > contain the current fileset seems very wrong. > > Note also that the print-log docs also say: > > ;; If START-REVISION is given, then show the log starting from that > ;; revision ("starting" in the sense of it being the _newest_ > ;; revision shown, rather than the working revision, which is normally > ;; the case). > > vc-print-log always passes nil for START-REVISION, so it seems we expect > to start from the working revision. Thanks. Based on this explanation I'd like to install your patch, but can you move the substantive commentary in the commit message into the code as a comment, please? Generally that is preferred in this repo. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 11 16:53:52 2024 Received: (at 73604) by debbugs.gnu.org; 11 Oct 2024 20:53:52 +0000 Received: from localhost ([127.0.0.1]:35470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szMdz-00018O-IP for submit@debbugs.gnu.org; Fri, 11 Oct 2024 16:53:51 -0400 Received: from mxout6.mail.janestreet.com ([64.215.233.21]:50453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szMdw-000189-UI for 73604@debbugs.gnu.org; Fri, 11 Oct 2024 16:53:50 -0400 From: Spencer Baugh To: Sean Whitton Subject: Re: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log In-Reply-To: <875xpz45d5.fsf@melete.silentflame.com> (Sean Whitton's message of "Fri, 11 Oct 2024 12:43:02 +0800") References: <87o7422any.fsf@melete.silentflame.com> <86o741znlb.fsf@gnu.org> <87o741zmy4.fsf@melete.silentflame.com> <875xpz45d5.fsf@melete.silentflame.com> Date: Fri, 11 Oct 2024 16:53:29 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1728680009; bh=aV6ICKKjSKE5n1HPxfXnmW95PZaYDUgnZ5putFe7TcM=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=SQgJInYgFx5XVSYasW5aGe/33atrwTTP7We4eu4/deu6VH8XpY4m1CK6IFpRn0CJh 1DPme35t/KNZbL5UP76SzNi0CDb3MsaWVM0dCmRjYHps9GM6lFHBmfXnOEdM1pP2IH 6ajq2IvE+KEOa4v5ZRA8OyY5JVuqcUaWCI2UQFSq+CtOiNSxLKN+M4yaY6NSMVa9YJ UzeOUrG2rALmV1o2q+AiUb4d4kNOTP84IqNibtm4kG/wCxfdPUV7dCAhgAaZ7hmb4k woc/29cOjEM83N7F4j8u+08bqZMDyVqnxYgdI/kF1gqhphdJBd+N9sggZ3IakLgyLt kFWUu1EG30Mag== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73604 Cc: Dmitry Gutov , Eli Zaretskii , 73604@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Sean Whitton writes: > Hello, > > On Thu 03 Oct 2024 at 11:18am -04, Spencer Baugh wrote: > >> I think you both may be misinterpreting this prompt - the typed-in >> revision doesn't actually specify where the log starts. It doesn't >> affect what goes in the buffer at all; the value typed in doesn't get >> passed to 'print-log at all. >> >> The prompt is just about where point goes in the buffer - "last >> revision" just means that point starts at point-min. Typing a revision >> at the prompt just moves point to that revision. >> >> (This is of course extremely confusing; I have definitely typed >> revisions in the vc-print-log prompt and expected them to change the log >> output. Maybe this prompt and command should be changed in other ways, >> but let's defer that for other bugs. Also note that this is very >> different behavior from M-1 C-x v L (vc-print-root-log), where typing a >> revision at the prompt *does* change what's logged.) >> >> So, anyway, that prompt says nothing about what actual logs should print >> with vc-print-log. And (potentially) including commits which don't even >> contain the current fileset seems very wrong. >> >> Note also that the print-log docs also say: >> >> ;; If START-REVISION is given, then show the log starting from that >> ;; revision ("starting" in the sense of it being the _newest_ >> ;; revision shown, rather than the working revision, which is normally >> ;; the case). >> >> vc-print-log always passes nil for START-REVISION, so it seems we expect >> to start from the working revision. > > Thanks. Based on this explanation I'd like to install your patch, but > can you move the substantive commentary in the commit message into the > code as a comment, please? Generally that is preferred in this repo. Sure - even better, I put it in the docstring. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Properly-operate-on-current-fileset-revision-in-vc-h.patch >From d353b8eef6134cd2a25e0a778d9ac9cd7fcae50f Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Wed, 2 Oct 2024 15:20:31 -0400 Subject: [PATCH] Properly operate on current fileset revision in vc-hg-print-log * lisp/vc/vc-hg.el (vc-hg-print-log): If start-revision is nil, reliably log the working revision. (bug#73604) --- lisp/vc/vc-hg.el | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el index c0afb225871..677cb3fd166 100644 --- a/lisp/vc/vc-hg.el +++ b/lisp/vc/vc-hg.el @@ -397,8 +397,11 @@ vc-hg-log-format (defun vc-hg-print-log (files buffer &optional shortlog start-revision limit) "Print commit log associated with FILES into specified BUFFER. If SHORTLOG is non-nil, use a short format based on `vc-hg-root-log-format'. -If START-REVISION is non-nil, it is the newest revision to show. -If LIMIT is non-nil, show no more than this many entries." +If LIMIT is non-nil, show no more than this many entries. + +If START-REVISION is nil, the commit log is printed starting from the +working directory parent (revset \".\"). If START-REVISION is non-nil, +the log is printed starting from that revision." ;; `vc-do-command' creates the buffer, but we need it before running ;; the command. (vc-setup-buffer buffer) @@ -408,8 +411,8 @@ vc-hg-print-log (with-current-buffer buffer (apply #'vc-hg-command buffer 'async files "log" + (format "-r%s:0" (or start-revision ".")) (nconc - (when start-revision (list (format "-r%s:0" start-revision))) (when limit (list "-l" (format "%s" limit))) (when (eq vc-log-view-type 'with-diff) (list "-p")) -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 03:37:09 2024 Received: (at 73604) by debbugs.gnu.org; 12 Oct 2024 07:37:10 +0000 Received: from localhost ([127.0.0.1]:36177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szWgX-0002ar-Iq for submit@debbugs.gnu.org; Sat, 12 Oct 2024 03:37:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szWgV-0002ad-Oe for 73604@debbugs.gnu.org; Sat, 12 Oct 2024 03:37:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szWgC-00046H-8J; Sat, 12 Oct 2024 03:36:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7yuD3vA/ezug7ea/hBce+C5B3yTZfKh3J426fxnGUPA=; b=UDaMYw7/nBF3 /uwxTIk/LfmY2woF7enCGxWmMmmHtMVmyJ19muIrTyZC3Na383eo2hs6DadChMINtb9qM5w1xj6Qb OhHLB20cujEBz4gjgM6ooEF7iHWK9QwuYAc/oziPuY9CQEWlt2M6ygCppUPwjrzaqYh1+EWqH21Y3 OSlFFoGC2KigW3qxgzAiEHmXkal9VWKyzpUYDlgishkBq5TECS+hwKs7d1vsZQeC7keKf/d+m3C+c DbBQ+jLcCSd2l4HVhEgmVT3rTArd+vN0PMGZbmsacmjsQRnX9ECxfOMwH33m/FWaaEwN3kqdryLmz dXDboitLv00HXdAl/bl3+Q==; Date: Sat, 12 Oct 2024 10:36:46 +0300 Message-Id: <861q0lzsa9.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh In-Reply-To: (message from Spencer Baugh on Fri, 11 Oct 2024 16:53:29 -0400) Subject: Re: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log References: <87o7422any.fsf@melete.silentflame.com> <86o741znlb.fsf@gnu.org> <87o741zmy4.fsf@melete.silentflame.com> <875xpz45d5.fsf@melete.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73604 Cc: dmitry@gutov.dev, 73604@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Cc: Dmitry Gutov , Eli Zaretskii , > 73604@debbugs.gnu.org > Date: Fri, 11 Oct 2024 16:53:29 -0400 > > (defun vc-hg-print-log (files buffer &optional shortlog start-revision limit) > "Print commit log associated with FILES into specified BUFFER. > If SHORTLOG is non-nil, use a short format based on `vc-hg-root-log-format'. > -If START-REVISION is non-nil, it is the newest revision to show. > -If LIMIT is non-nil, show no more than this many entries." > +If LIMIT is non-nil, show no more than this many entries. This should say that LIMIT must be a positive integer number. > +If START-REVISION is nil, the commit log is printed starting from the ^^^^^^^^^^^^^^^^^^^^^^^^^ Passive tense alert! > +working directory parent (revset \".\"). If START-REVISION is non-nil, > +the log is printed starting from that revision." ^^^^^^^^^^^^^^ Same here. In addition, I'm guessing START-REVISION must be a string, right? From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 04:57:18 2024 Received: (at 73604-done) by debbugs.gnu.org; 12 Oct 2024 08:57:18 +0000 Received: from localhost ([127.0.0.1]:36273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szXw5-0006jr-Ti for submit@debbugs.gnu.org; Sat, 12 Oct 2024 04:57:18 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:36910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szXw2-0006jX-NC for 73604-done@debbugs.gnu.org; Sat, 12 Oct 2024 04:57:16 -0400 DKIM-Signature: a=rsa-sha256; b=Dovi6p41TBSoFJSnhgkUJcZ+SV0pHMOO/FS21DAcyardPJ7ueHT7aKHhF/0kflnXuA2Ga6dNiSPYyXtkRLUQDuoRgQ+hQ+m1m+1Mvu/ngnl6NAYoKN0q4jhNP5PXrB7kpRykkSAom2w922oUo1FhbXqW9xB6XKlWn5BfSYjHgtyRMTkko6V8JcEv+MIySgqnxjIhM0Iicvhz/n+m/52DjVMyACbIO+I8s5c2W7W4a5ZZbIR0YfaCPUbBm+EkuCNG+ngutQR4ChrzBYypu9TSIyjQbKAaCTlHIv1yV9ZIYtMYnOJ3vfkncaJCGNqflMOpqmctYj9p+58kdX2HDZigAw==; s=purelymail3; d=spwhitton.name; v=1; bh=sZSyzYvKPd91cCdPwLajws4W6VTxFwh/kRPTYLhxXww=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=VOwxwzeq5KtRUpRt7qXbZuOQnyZSMccqCdAEuO6OBLQZFjfe4hg1w2GnAhllzvBXrbylnV/HYqwmaDOSlvUL2/IWllR0KF/k1tHH8CA3g39fS/5QgbC5bdbd7SQqZ9ceC4C6WAWo7OqzwOuEtWGxJuq4M4yiawLRi6LfK6y8P3ncokMNlwiiWwSQyIjJ8emxROE8WhwP3d2Oepyr+C5gUc00IAAZgVD2tGf+Xjb9YOzbPhv2REiM9Vu9JoGR1yD6K/xFX+hPKLKll/ObGEhoHNKxBfgvYUUSD6UNEI6HhwOBydIFohJZV7flIE4+N9N109p2DCb855CssBfh3nEgjA==; s=purelymail3; d=purelymail.com; v=1; bh=sZSyzYvKPd91cCdPwLajws4W6VTxFwh/kRPTYLhxXww=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73604-done@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 276983236; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 12 Oct 2024 08:56:49 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 462EE7E6874; Sat, 12 Oct 2024 16:56:44 +0800 (CST) From: Sean Whitton To: Spencer Baugh Subject: Re: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log In-Reply-To: (Spencer Baugh's message of "Fri, 11 Oct 2024 16:53:29 -0400") References: <87o7422any.fsf@melete.silentflame.com> <86o741znlb.fsf@gnu.org> <87o741zmy4.fsf@melete.silentflame.com> <875xpz45d5.fsf@melete.silentflame.com> Date: Sat, 12 Oct 2024 16:56:44 +0800 Message-ID: <87y12t1yyb.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73604-done Cc: Dmitry Gutov , Eli Zaretskii , 73604-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Installed and closing -- thanks! -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 04:59:00 2024 Received: (at 73604) by debbugs.gnu.org; 12 Oct 2024 08:59:00 +0000 Received: from localhost ([127.0.0.1]:36285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szXxk-0006n2-3s for submit@debbugs.gnu.org; Sat, 12 Oct 2024 04:59:00 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:43298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szXxh-0006mo-PN for 73604@debbugs.gnu.org; Sat, 12 Oct 2024 04:58:58 -0400 DKIM-Signature: a=rsa-sha256; b=O+myHRL/qO0ArY3hWZ6cLNcSVjSPDdABqnaRXhAFUpAmX6HwU+BzQ/prq4Li9Hbve8hmPlyoPWSR9WwrIsUCLrAAxjitkvlKkpNlGF21FHfeLqlt71areEyujh2PVOYAidYhSOelOHa6ZMcSNX6SQrQLGg7FYmDcm9Lt61lb/Wf47rlaJkvrHjmwNX45mvrevt9yx622BF50F7kJyglX62ZbLMFMEFjaDIQ2JLigoIgT6xtpZeyJx27ho77GkPbaOgtigkunngUqDZvZEAWEP4PWFAUboocmLCy3UXYB0nMp4BmQgfuGoRUv6EAvpSwDhgirc2yJXmvSroQNs7RVAg==; s=purelymail3; d=spwhitton.name; v=1; bh=0eeJsrA9VO3m0u+8X5TX4/ysPmhtUMNbvUjd9VGhHtM=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=iKX2ReI/RzbwNRXbVyAaVF6Oqi0TM/jgmPB/q7U6SvqHZIXG5PCfANCtijXmE322cGUhxhObKTzylqGu2hHP4YaDYerFpT4mHRGg9//h8OHkvyagZOxIGznCzFhYXkEX2oFmtPhlHu8lp3cPpgWcGzAJUft+An74KBnuYnsOj5NMO+JN3ORu2e+fe84X1U6a2qzbBpq/W491eaN3nQcLQ6UvLFEKGB49JcJ/e+NgHdrok8f0yOfyorm8PAHaEKreB5kPQeVzBRmzyAIciUr5hDuNQc7vA8YoWfNRr6l4qHNbE+DmHFOMvUahxZDrL6fTgO9aIYdknlXlaOBmN72Nwg==; s=purelymail3; d=purelymail.com; v=1; bh=0eeJsrA9VO3m0u+8X5TX4/ysPmhtUMNbvUjd9VGhHtM=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73604@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -831275962; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 12 Oct 2024 08:58:35 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 7EB0D7E6874; Sat, 12 Oct 2024 16:58:33 +0800 (CST) From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log In-Reply-To: <861q0lzsa9.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Oct 2024 10:36:46 +0300") References: <87o7422any.fsf@melete.silentflame.com> <86o741znlb.fsf@gnu.org> <87o741zmy4.fsf@melete.silentflame.com> <875xpz45d5.fsf@melete.silentflame.com> <861q0lzsa9.fsf@gnu.org> Date: Sat, 12 Oct 2024 16:58:33 +0800 Message-ID: <87ttdh1yva.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73604 Cc: Spencer Baugh , 73604@debbugs.gnu.org, dmitry@gutov.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Sat 12 Oct 2024 at 10:36am +03, Eli Zaretskii wrote: >> From: Spencer Baugh >> Cc: Dmitry Gutov , Eli Zaretskii , >> 73604@debbugs.gnu.org >> Date: Fri, 11 Oct 2024 16:53:29 -0400 >> >> (defun vc-hg-print-log (files buffer &optional shortlog start-revision limit) >> "Print commit log associated with FILES into specified BUFFER. >> If SHORTLOG is non-nil, use a short format based on `vc-hg-root-log-format'. >> -If START-REVISION is non-nil, it is the newest revision to show. >> -If LIMIT is non-nil, show no more than this many entries." >> +If LIMIT is non-nil, show no more than this many entries. > > This should say that LIMIT must be a positive integer number. > >> +If START-REVISION is nil, the commit log is printed starting from the > ^^^^^^^^^^^^^^^^^^^^^^^^^ > Passive tense alert! > >> +working directory parent (revset \".\"). If START-REVISION is non-nil, >> +the log is printed starting from that revision." > ^^^^^^^^^^^^^^ > Same here. In addition, I'm guessing START-REVISION must be a string, > right? Sorry, missed this message. I've made these revisions. -- Sean Whitton From unknown Sun Jun 22 17:10:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 09 Nov 2024 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator