From unknown Thu Aug 14 21:45:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73572 <73572@debbugs.gnu.org> To: bug#73572 <73572@debbugs.gnu.org> Subject: Status: 31.0.50; defface warnings Reply-To: bug#73572 <73572@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:45:02 +0000 retitle 73572 31.0.50; defface warnings reassign 73572 emacs submitter 73572 Arash Esbati severity 73572 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 16:15:55 2024 Received: (at submit) by debbugs.gnu.org; 30 Sep 2024 20:15:56 +0000 Received: from localhost ([127.0.0.1]:46823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svMoF-0006Ta-7E for submit@debbugs.gnu.org; Mon, 30 Sep 2024 16:15:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:53382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svMoD-0006TO-7D for submit@debbugs.gnu.org; Mon, 30 Sep 2024 16:15:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svMnb-0002Sh-6o for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 16:15:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svMnZ-0006K3-Kv for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 16:15:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=3BrWxQZFLtBpNussAkSnbtMXcKefzlOyNoX/W2kzM2s=; b=AE9ALi8kRsLrNI eU90nZa6z9jbi82Ozv1OOSv22+1QAJBCoRbxK1jE4DJTCMYveuff3fS9CY8xFdkpuwbGWiF6t/jFY MOP7LODdmtDENiX7cfQ3hyrx6YfqRn3afg5tSWerk8qgPcU/q5KDlj+NtZyouYhFNaB4xYo3IrLZu 6ifFA02Q8Cv7938g/HeVcUwd1aXuudO/znG3fyhJQR9EuFplliVxmPVCyrY3QkZb4nbOt6ydYRrq1 V3hHgxGuC7w/nGT2vGRGJde22DxQDZ455+uvi1IdVNOoiafBO8vTOnGB6ZvkqGuorLT/JPC4TzgwV Gdo0lyjGHJI3TM/M6jhA==; From: Arash Esbati To: "emacs-bugs" Subject: 31.0.50; defface warnings Date: Mon, 30 Sep 2024 22:14:46 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi all, I'm not sure if these warnings are due to Mattias' recent changes, but when building Emacs from master (685ec273ec), I get: --8<---------------cut here---------------start------------->8--- In toplevel form: shell.el:1662:18: Warning: in defface for =E2=80=98shell-highlight-undef-defined-face=E2=80=99: Value for face attrib= ute =E2=80=98:inherit=E2=80=99 should not be quoted shell.el:1668:18: Warning: in defface for =E2=80=98shell-highlight-undef-undefined-face=E2=80=99: Value for face attr= ibute =E2=80=98:inherit=E2=80=99 should not be quoted shell.el:1674:18: Warning: in defface for =E2=80=98shell-highlight-undef-alias-face=E2=80=99: Value for face attribut= e =E2=80=98:inherit=E2=80=99 should not be quoted In toplevel form: net/dictionary.el:339:7: Warning: in defface for =E2=80=98dictionary-word-entry-face=E2=80=99: =E2=80=98:inverse=E2=80=99 is= not a valid face attribute keyword In toplevel form: net/sieve-mode.el:70:35: Warning: in defface for =E2=80=98sieve-tagged-arguments=E2=80=99: Non-keyword in face attribute lis= t: =E2=80=98face=E2=80=99 In toplevel form: vc/smerge-mode.el:84:24: Warning: in defface for =E2=80=98smerge-upper=E2= =80=99: Missing face attribute =E2=80=98:extend=E2=80=99 value vc/smerge-mode.el:95:26: Warning: in defface for =E2=80=98smerge-lower=E2= =80=99: Missing face attribute =E2=80=98:extend=E2=80=99 value --8<---------------cut here---------------end--------------->8--- The following patch should fix the warnings for 1, 3 and 4. I'm not sure what's the right approach for 2. --8<---------------cut here---------------start------------->8--- diff --git a/lisp/net/sieve-mode.el b/lisp/net/sieve-mode.el index 4fbdd183973..a648cf1e1e0 100644 --- a/lisp/net/sieve-mode.el +++ b/lisp/net/sieve-mode.el @@ -67,7 +67,7 @@ sieve-test-commands "Face used for Sieve Test Commands.") (defface sieve-tagged-arguments - '((t :inherit font-lock-keyword face)) + '((t :inherit font-lock-keyword-face)) "Face used for Sieve Tagged Arguments.") diff --git a/lisp/shell.el b/lisp/shell.el index 4d92fe71df4..14f073d6a61 100644 --- a/lisp/shell.el +++ b/lisp/shell.el @@ -1659,19 +1659,19 @@ shell-highlight-undef-aliases :version "29.1") (defface shell-highlight-undef-defined-face - '((t :inherit 'font-lock-function-name-face)) + '((t :inherit font-lock-function-name-face)) "Face used for existing shell commands." :group 'shell :version "29.1") (defface shell-highlight-undef-undefined-face - '((t :inherit 'font-lock-warning-face)) + '((t :inherit font-lock-warning-face)) "Face used for non-existent shell commands." :group 'shell :version "29.1") (defface shell-highlight-undef-alias-face - '((t :inherit 'font-lock-variable-name-face)) + '((t :inherit font-lock-variable-name-face)) "Face used for shell command aliases." :group 'shell :version "29.1") diff --git a/lisp/vc/smerge-mode.el b/lisp/vc/smerge-mode.el index a16c7871ff9..aad3e302826 100644 --- a/lisp/vc/smerge-mode.el +++ b/lisp/vc/smerge-mode.el @@ -81,7 +81,7 @@ smerge-upper (((class color) (min-colors 88) (background dark)) :background "#553333" :extend t) (((class color)) - :foreground "red" :extend)) + :foreground "red" :extend t)) "Face for the `upper' version of a conflict.") (define-obsolete-face-alias 'smerge-mine 'smerge-upper "26.1") (defvar smerge-upper-face 'smerge-upper) @@ -92,7 +92,7 @@ smerge-lower (((class color) (min-colors 88) (background dark)) :background "#335533" :extend t) (((class color)) - :foreground "green" :extend)) + :foreground "green" :extend t)) "Face for the `lower' version of a conflict.") (define-obsolete-face-alias 'smerge-other 'smerge-lower "26.1") (defvar smerge-lower-face 'smerge-lower) --8<---------------cut here---------------end--------------->8--- Best, Arash From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 06:43:02 2024 Received: (at 73572-done) by debbugs.gnu.org; 5 Oct 2024 10:43:02 +0000 Received: from localhost ([127.0.0.1]:37365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx2FZ-00075r-Ka for submit@debbugs.gnu.org; Sat, 05 Oct 2024 06:43:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx2FY-00075f-79 for 73572-done@debbugs.gnu.org; Sat, 05 Oct 2024 06:43:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sx2FD-0004R0-Cg for 73572-done@debbugs.gnu.org; Sat, 05 Oct 2024 06:42:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xl0kgSoIObgd0MlGz/s0e8+iLbixyviLA9F/bL9Knp4=; b=ODgII4bSOWHpj/sqFqLz Ccx1wW/UL7q0ICdB10xVmDVcHM56HL73ixWSNMmGYX3uHhZspvwYFlS5ZVDNZuMlf9w3RGKX9oYi+ EEQjxHMrktUR1MUW49JruVSI5VcV27cD71AHi1J/r4QFn4sJ5D41/UWoP5Bji+ZMgotnVGL+Goc8B xqCEmixlQ/rs0udIxnWwp0RP4lyEvudklwL1cv9mV2xbyPfnJjSh+bz6ZCoEJDmHo2sPfjuM656TY yZ55ZO352eK8clsPmd3beH4hnsDBFGfUIj9y8tq61BspUKfCWxBr+SXH0Tp4A8GHMjxojPN5W+VrO /6ydDjfNzIB3Eg==; Date: Sat, 05 Oct 2024 13:42:36 +0300 Message-Id: <86frpax23n.fsf@gnu.org> From: Eli Zaretskii To: Arash Esbati In-Reply-To: (message from Arash Esbati on Mon, 30 Sep 2024 22:14:46 +0200) Subject: Re: bug#73572: 31.0.50; defface warnings References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73572-done Cc: 73572-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Arash Esbati > Date: Mon, 30 Sep 2024 22:14:46 +0200 > > I'm not sure if these warnings are due to Mattias' recent changes, but > when building Emacs from master (685ec273ec), I get: > > --8<---------------cut here---------------start------------->8--- > In toplevel form: > shell.el:1662:18: Warning: in defface for > ‘shell-highlight-undef-defined-face’: Value for face attribute > ‘:inherit’ should not be quoted > shell.el:1668:18: Warning: in defface for > ‘shell-highlight-undef-undefined-face’: Value for face attribute > ‘:inherit’ should not be quoted > shell.el:1674:18: Warning: in defface for > ‘shell-highlight-undef-alias-face’: Value for face attribute ‘:inherit’ > should not be quoted > > In toplevel form: > net/dictionary.el:339:7: Warning: in defface for > ‘dictionary-word-entry-face’: ‘:inverse’ is not a valid face attribute > keyword > > In toplevel form: > net/sieve-mode.el:70:35: Warning: in defface for > ‘sieve-tagged-arguments’: Non-keyword in face attribute list: ‘face’ > > In toplevel form: > vc/smerge-mode.el:84:24: Warning: in defface for ‘smerge-upper’: Missing > face attribute ‘:extend’ value > vc/smerge-mode.el:95:26: Warning: in defface for ‘smerge-lower’: Missing > face attribute ‘:extend’ value > --8<---------------cut here---------------end--------------->8--- > > The following patch should fix the warnings for 1, 3 and 4. I'm not > sure what's the right approach for 2. Thanks, these appear to have been fixed on master, so I'm now closing the bug. From unknown Thu Aug 14 21:45:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 02 Nov 2024 11:24:15 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator