GNU bug report logs - #73562
[PATCH] committer: Fix for inputs that are lists by using object->string.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73562 in the body.
You can then email your comments to 73562 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: attila.lendvai <at> gmail.com
To: guix-patches <at> gnu.org
Cc: Attila Lendvai <attila <at> lendvai.name>
Subject: [PATCH] committer: Fix for inputs that are lists by using
 object->string.
Date: Mon, 30 Sep 2024 10:00:42 +0200

From: Attila Lendvai <attila <at> lendvai.name>

* etc/committer.scm.in (change-commit-message): Use object->string to deal
with more complex dependency specifications.

Change-Id: Ieee39709fd3eb26368df400a9228d77aa97a9d9d
---
 etc/committer.scm.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/etc/committer.scm.in b/etc/committer.scm.in
index c49935da600..9b128c8f1e7 100755
--- a/etc/committer.scm.in
+++ b/etc/committer.scm.in
@@ -301,8 +301,9 @@ (define* (change-commit-message file-name old new #:optional (port (current-outp
                       (format port
                               "[~a]: ~a~%" field
                               (break-string
-                               (match (list (map symbol->string removed)
-                                            (map symbol->string added))
+                               ;; A dependency can be a list of (pkg output).
+                               (match (list (map object->string removed)
+                                            (map object->string added))
                                  ((() added)
                                   (format #f "Add ~a."
                                           (listify added)))

base-commit: d74fc6c8e6428c37a5bfad85b08999ff47000208
prerequisite-patch-id: 69604c6ecc6bc38af1f4d570957913136e47a744
prerequisite-patch-id: 0191b92812f5c7df75e6aa67ea7dddfcf69ba5ad
prerequisite-patch-id: 246a683ad6063f26d3164b70a25946d0ff195493
-- 
2.46.0

Message #10 received at 73562-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: attila.lendvai <at> gmail.com
Cc: Attila Lendvai <attila <at> lendvai.name>, 73562-done <at> debbugs.gnu.org
Subject: Re: [bug#73562] [PATCH] committer: Fix for inputs that are lists by
 using object->string.
Date: Tue, 15 Oct 2024 18:22:33 +0200

attila.lendvai <at> gmail.com skribis:

> From: Attila Lendvai <attila <at> lendvai.name>
>
> * etc/committer.scm.in (change-commit-message): Use object->string to deal
> with more complex dependency specifications.
>
> Change-Id: Ieee39709fd3eb26368df400a9228d77aa97a9d9d

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.