Subject: [bug#73529] [PATCH core] gnu: patchelf: Build from git sources.

From: Attila Lendvai <[email-masked]>
Date: Mon, 30 Sep 2024 08:14:17 +0000

> > + (file-name (git-file-name "patchelf" version))
> 
> 
> i think should "(git-file-name name version)" ?

hrm. i tried that at first, but it errored out with `name` being undefined. i retried it just now to double check, and now it works. i must have been confused by something.

the updated patch will have `name` in there.

> > + (sha256
> > + (base32
> > + "1v5mh8wdax4a97hw79nvzy0dixkbs0h487xkskkljkkdamq4rj5z"))))
> > (build-system gnu-build-system)
> > (arguments
> > '(#:phases
> > (modify-phases %standard-phases
> > - (add-after 'unpack 'fix-tests
> > + (add-after 'bootstrap 'fix-tests
> 
> 
> Just a question, why do you need to change to bootstrap here?

because the last substitute* touches `tests/Makefile.in` which is generated by the bootstrap phase (by the auto* tools).

but now that you asked, i've changed it to target `tests/Makefile.am` instead.

> > (native-inputs
> > - `(("gcc:lib" ,gcc "lib")))
> > + (list
> > + autoconf
> > + automake
> > + (list gcc "lib")))
> 
> 
> It would be nice to mention removing labels and adding new dependencies
> in the submission, and etc/committer.scm maybe useful.

ok, i'll send an updated patch soon.

BTW, etc/committer.scm broke on this package. i've sent a patch to fix that:

https://issues.guix.gnu.org/73562

-- 
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“Where there are rulers, there are no rules, only interest-serving opinions enforced by violence. To want rulers is to beg for chaos.”
	— Brandon Roark