GNU bug report logs - #73520
[PATCH 0/2] Potential fix for the latest xdg-desktop-portal

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73520: closed ([PATCH 0/2] Potential fix for the latest
 xdg-desktop-portal)
Date: Wed, 05 Mar 2025 05:34:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 05 Mar 2025 14:33:02 +0900
with message-id <875xkohwj5.fsf <at> gmail.com>
and subject line Re: [bug#73520] [PATCH gnome-team v2] gnu: xdg-desktop-portal: Fix configuration file search.
has caused the debbugs.gnu.org bug report #73520,
regarding [PATCH 0/2] Potential fix for the latest xdg-desktop-portal
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73520: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73520
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Rodion Goritskov <rodion.goritskov <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Rodion Goritskov <rodion.goritskov <at> gmail.com>
Subject: [PATCH 0/2] Potential fix for the latest xdg-desktop-portal
Date: Fri, 27 Sep 2024 23:17:16 +0400

Hello!

The problem with the xdg-desktop-portal is due to the configuration changes introduced in this commit [1].
Now it relies on using the configuration file to decide which xdg-desktop-portal implementation to use. However, as Guix uses XDG_DESKTOP_PORTAL_DIR to specify the portal (not the xdg-portal-configuration) directory, the newest xdg-desktop-portal skip configuration search at all [2].
If we patch the process of configuration search a little bit - just to continue searching in case the XDG_DESKTOP_PORTAL_DIR is specified, but doesn't contain any {*}-portals.conf files (our case), we will have the right configuration files (at least for KDE I have tested this changes on) to be read by xdg-desktop-portal according to priorities (XDG_DATA_DIRS in our case) [3] (so they could be even overridden in users' home directory).

It's a bit hacky, but works fine.

[1]: https://github.com/flatpak/xdg-desktop-portal/commit/939f0b0fcec6a42c1acdc397986547e9805359ff
[2]: https://github.com/flatpak/xdg-desktop-portal/blob/1b5a16932493324fa0f21cfb1c3f9c1d16cb6a19/src/portal-impl.c#L441
[3]: https://github.com/flatpak/xdg-desktop-portal/blob/main/doc/portals.conf.rst.in

Rodion Goritskov (2):
  gnu: xdg-desktop-portal-next: Fix configuration file search.
  gnu: xdg-desktop-portal: Update to 1.18.4.

 gnu/local.mk                                  |  1 +
 gnu/packages/freedesktop.scm                  | 77 ++++++-------------
 ...al-disable-configuration-search-exit.patch | 28 +++++++
 gnu/packages/telegram.scm                     |  2 +-
 4 files changed, 55 insertions(+), 53 deletions(-)
 create mode 100644 gnu/packages/patches/xdg-desktop-portal-disable-configuration-search-exit.patch


base-commit: 9a141b5bd633227ea31776b9ce7ca40928de2442
-- 
2.46.0

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: aurtzy <aurtzy <at> gmail.com>
Cc: John Kehayias <john.kehayias <at> protonmail.com>, 73520-done <at> debbugs.gnu.org,
 Rodion Goritskov <rodion.goritskov <at> gmail.com>
Subject: Re: [bug#73520] [PATCH gnome-team v2] gnu: xdg-desktop-portal: Fix
 configuration file search.
Date: Wed, 05 Mar 2025 14:33:02 +0900

Hi,

aurtzy <aurtzy <at> gmail.com> writes:

> From: Rodion Goritskov <rodion.goritskov <at> gmail.com>
>
> * gnu/local.mk: Add patch.
> * gnu/packages/freedesktop.scm (xdg-desktop-portal): Add patch.
> * gnu/packages/patches/xdg-desktop-portal-disable-configuration-search-exit.patch: New file
>
> Change-Id: Idd637f5613e7d1403fc3a0feeff53a7931e68fc6

Applied, thanks to Rodion and you!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.