From unknown Fri Jun 20 20:08:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73495 <73495@debbugs.gnu.org> To: bug#73495 <73495@debbugs.gnu.org> Subject: Status: [PATCH] gnu: dyninst: Remove patch-bad-logic phase. Reply-To: bug#73495 <73495@debbugs.gnu.org> Date: Sat, 21 Jun 2025 03:08:35 +0000 retitle 73495 [PATCH] gnu: dyninst: Remove patch-bad-logic phase. reassign 73495 guix-patches submitter 73495 Nguy=E1=BB=85n Gia Phong severity 73495 normal tag 73495 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 05:25:21 2024 Received: (at submit) by debbugs.gnu.org; 26 Sep 2024 09:25:21 +0000 Received: from localhost ([127.0.0.1]:52968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stkkS-0008MH-Jw for submit@debbugs.gnu.org; Thu, 26 Sep 2024 05:25:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:37452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stkhf-0008BT-9E for submit@debbugs.gnu.org; Thu, 26 Sep 2024 05:22:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stkhE-0001nR-1H for guix-patches@gnu.org; Thu, 26 Sep 2024 05:22:00 -0400 Received: from layka.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1stkhB-0000r2-QC for guix-patches@gnu.org; Thu, 26 Sep 2024 05:21:59 -0400 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 8D51C23DF7; Thu, 26 Sep 2024 11:21:53 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id s9sd2EdI6PwD; Thu, 26 Sep 2024 11:21:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1727342512; bh=WblPy4rKzb6ZOqrTtLVeEWRTJjxONAX6FL0hvoESRdI=; h=From:To:Cc:Subject:Date; b=WqvI+fbZPPPyFW54Xbp0bAZYXJQXuJ+3s2Dq6xCtUogR6+z7y95cXfLMfHdDRZWul J4ntdAVNpznleCLIyeH36nPJnH4YpxYDDLoaoba934kb3jLKn8uFSBlYEytYGoZbQK aSP/1XeaEU5nJGs8gtvNJxWwx6bzuAMcnx6NzQMsos8rGzRasnRlTopH4C68oKe2oX HNcwiXn1DXsuycOi/osmjgQ09+Pp/8ymeYb0ajF/HR8ZnESKHO11y1IjXeJMGuKrKc R2kFGTV03ZEf4CZBmjX4hIfn/G5myap/g9qTyTtP5F6aT65q/aXznXTs28yz27taMX lFxIkBG3UVM7g== From: =?UTF-8?q?Nguy=E1=BB=85n=20Gia=20Phong?= To: guix-patches@gnu.org Subject: [PATCH] gnu: dyninst: Remove patch-bad-logic phase. Date: Thu, 26 Sep 2024 18:21:29 +0900 Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=mcsinyx@disroot.org; helo=layka.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Nguy=E1=BB=85n=20Gia=20Phong?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) The short circuit logic (return failure to resolve library path if ldconfig not found) is no longer present on Dyninst 13. * gnu/packages/instrumentation.scm (dyninst): Remove patch-bad-logic phase. Fixes: 254c8f2c8cbb ("gnu: dyninst: Update to 13.0.0.") References: https://github.com/dyninst/dyninst/pull/1362 Change-Id: I021ec71416da90d11705ef04fba7c170558ef3c6 --- gnu/packages/instrumentation.scm | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/gnu/packages/instrumentation.scm b/gnu/packages/instrumentation.scm index 1b99399913ef..86436130c9e1 100644 --- a/gnu/packages/instrumentation.scm +++ b/gnu/packages/instrumentation.scm @@ -222,23 +222,8 @@ (define-public dyninst ;; source. #:configure-flags (list "-DSTERILE_BUILD=ON") - ;; NOTE: dyninst needs to search for shared libraries that are linked - ;; against the instrumented binary in order to rebuild the entire - ;; program. For this purpose, one can use LD_LIBRARY_PATH or - ;; DYNISNT_REWRITER_PATHS environment variables to add paths for dyinst - ;; to search. However, dyninst also tries to be smart by executing - ;; ldconfig, which is not portable. If ldconfig is not available on - ;; the system, dyinst wrongly assumes that the shared libraries can not - ;; be found, even though it can. This bad logic is still there with - ;; newer versions of dyinst. Thus, this substitution makes the bad - ;; code path unreachable. #:phases (modify-phases %standard-phases - (add-after 'unpack 'patch-bad-logic - (lambda _ - (substitute* "dyninstAPI/src/linux.C" - (("if\\(fgets\\(buffer, buffer_size, ldconfig\\)\\)") - "fgets(buffer, buffer_size, ldconfig); if (true)")))) (add-after 'unpack 'adjust-supported-platform-name (lambda _ ;; That file checks for "i386" but base-commit: f6715a4715eaed485300dffffa1b5e182ded3cea -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 12:58:56 2024 Received: (at 73495-done) by debbugs.gnu.org; 30 Sep 2024 16:58:56 +0000 Received: from localhost ([127.0.0.1]:45865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svJjb-00052J-Li for submit@debbugs.gnu.org; Mon, 30 Sep 2024 12:58:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svJjX-00050d-3v for 73495-done@debbugs.gnu.org; Mon, 30 Sep 2024 12:58:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svJiu-00084m-Bd; Mon, 30 Sep 2024 12:58:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=kWmY+qqVnkEY/uwsGB/pvDiWhaqKIlsPvjniaNSBY+w=; b=mumvsNHFhMtXgdoAxaNS KzT/Zl79wH80eGrBJv6G7o2Bi8I0zAAkrq0cpuvVwwo5D7KvWulNUk6xom3cBJr4wKu8uyP/QJlcz J+gsVjdrWB0esa5GrDjFr6aHCuATj6O+Ub8yVSBPhpFthb0aUnChIUXUEcP2np2apfQbj5Cuxg0QU OtH+mK5411TcuvTLzLUX3JDvywO5ePPBkIoCjYQ585PS9vib8B+LLtqoExcEc4uJhIxfK2qV+6dWt QizrwWXkc89Fro0S3EMhvW5Yyx/2yzuXZo7cdQNdXd9jTJaCXRdU+WArr5wPJ7Zr796dhc25CRB0z NMLFTBGC8Sk8dA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?Nguy=E1=BB=85n?= Gia Phong Subject: Re: [bug#73495] [PATCH] gnu: dyninst: Remove patch-bad-logic phase. In-Reply-To: (=?utf-8?Q?=22Nguy=E1=BB=85n?= Gia Phong"'s message of "Thu, 26 Sep 2024 18:21:29 +0900") References: Date: Mon, 30 Sep 2024 18:58:07 +0200 Message-ID: <874j5x6puo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73495-done Cc: 73495-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Nguy=E1=BB=85n Gia Phong skribis: > The short circuit logic (return failure to resolve library path > if ldconfig not found) is no longer present on Dyninst 13. > > * gnu/packages/instrumentation.scm (dyninst): > Remove patch-bad-logic phase. > > Fixes: 254c8f2c8cbb ("gnu: dyninst: Update to 13.0.0.") > References: https://github.com/dyninst/dyninst/pull/1362 > Change-Id: I021ec71416da90d11705ef04fba7c170558ef3c6 Applied, thanks! From unknown Fri Jun 20 20:08:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 29 Oct 2024 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator