From unknown Tue Jun 17 01:44:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73494 <73494@debbugs.gnu.org> To: bug#73494 <73494@debbugs.gnu.org> Subject: Status: [PATCH 0/2] tmpfs /run. Reply-To: bug#73494 <73494@debbugs.gnu.org> Date: Tue, 17 Jun 2025 08:44:01 +0000 retitle 73494 [PATCH 0/2] tmpfs /run. reassign 73494 guix-patches submitter 73494 Hilton Chain severity 73494 normal tag 73494 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 03:02:45 2024 Received: (at submit) by debbugs.gnu.org; 26 Sep 2024 07:02:45 +0000 Received: from localhost ([127.0.0.1]:48270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stiWS-0007UH-So for submit@debbugs.gnu.org; Thu, 26 Sep 2024 03:02:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:60570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stiWQ-0007U2-4C for submit@debbugs.gnu.org; Thu, 26 Sep 2024 03:02:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stiGi-0006kj-L3 for guix-patches@gnu.org; Thu, 26 Sep 2024 02:46:28 -0400 Received: from mail.boiledscript.com ([144.168.59.46]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stiGh-0007F7-42 for guix-patches@gnu.org; Thu, 26 Sep 2024 02:46:28 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1727333181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DG5ISkxihGJNtJxV/8QDlRPuAuAPx55GC8e98W8DwuM=; b=avlE8wvqVmWLh2RxRXMC7fqpi520IiNEj1Di5qTZT5D+X4P4Pd7Alg6zo2FEfJnTAK8G+8 si04IaX15olk/9goVxIHgj6IVc1Nri3oodOafr8JOKZ3SNiA0uJ5menyYFQwDupBJf+hHr 05JtGWKXyUN6MbzVhff/OHD1tFLkVmmMyksne2eWTHys3Bp05nHxlTYGaDTgjGferSKY+A Z9rRDa1cSMvsF8YrNFqNF2w+zXt9NzkYVA82esGCWnY13jWeYOnNqgglurj0h6KlD8vMKR zlpJUlAKjOEDqZ7uGm8FRJxTeb5LL8PdW/vQVm49ZMhOdd/c+scQaOzCZXtwsA== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space To: guix-patches@gnu.org Subject: [PATCH 0/2] tmpfs /run. Date: Thu, 26 Sep 2024 14:44:52 +0800 Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: - Received-SPF: pass client-ip=144.168.59.46; envelope-from=hako@ultrarare.space; helo=mail.boiledscript.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Guix, This series adds a tmpfs /run to %base-file-systems and symlinks /var/run to it. Mount options are taken from Systemd[1], OpenRC also uses the same ones[2]. (Except no-suid since we have /run/privileged/bin.) Thanks [1]: https://github.com/systemd/systemd/blob/v256.6/src/shared/mount-setup.c#L102 [2]: https://github.com/OpenRC/openrc/blob/0.55.1/sh/init.sh.Linux.in#L74 Hilton Chain (2): file-systems: %base-file-systems: Add tmpfs /run. services: cleanup: Make /var/run a symlink of /run. doc/guix.texi | 5 +++++ gnu/services.scm | 6 +----- gnu/services/dbus.scm | 31 ------------------------------- gnu/system/file-systems.scm | 15 ++++++++++++++- 4 files changed, 20 insertions(+), 37 deletions(-) base-commit: 8576aaf5f90db9b385ea8cf6dc98bf3c062959dc -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 03:06:35 2024 Received: (at 73494) by debbugs.gnu.org; 26 Sep 2024 07:06:35 +0000 Received: from localhost ([127.0.0.1]:48520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stiaB-0007oJ-2W for submit@debbugs.gnu.org; Thu, 26 Sep 2024 03:06:35 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:59252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stia8-0007no-UX for 73494@debbugs.gnu.org; Thu, 26 Sep 2024 03:06:33 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1727334359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nClfNoWWXK7aIuSy56LXRhmr7QMEWyW0hyV2TaoNQmA=; b=kRbfh0GcL/tjS/yFb5RMlUpovAw9+9RXodGF5Vsru5HeCB7axPwY0j+1y9quI1wjlvzmMS 0hZn0cObX/vxAD+o10tZFJT7pEirWqLRAylKA1PtWl3+ZpRGUNb0SMMb7Q3eieZCh0juw+ qt5nVW+AA5YNzoyA6cS9FUfcR5vqvvoddjKOkJ1hQhjCJD3zZHtl5tkiNB5j1EZtI5ADUx t8Ll/oU4W/nKyKE8uUzr+HCrUHpOa2+/aG9WWLGuDpXIiUkmSqjWjiT2OAmPIsMQ8kndcZ OygnlQjCJ6KCEf8p74nmt0e90u3IzhlFR66oTjq7kH+jZOHprihtY0RmvwKKlg== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space To: 73494@debbugs.gnu.org Subject: [PATCH 1/2] file-systems: %base-file-systems: Add tmpfs /run. Date: Thu, 26 Sep 2024 15:05:28 +0800 Message-ID: <9769cf0f812d5e7e9fe38ed664809974101821e0.1727334105.git.hako@ultrarare.space> In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Florian Pelz , Ludovic Courtès , Maxim Cournoyer Content-Transfer-Encoding: 8bit X-Spamd-Bar: ----- X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/system/file-systems (%runtime-variable-data): New variable. (%base-file-systems): Add it. * doc/guix.texi (File Systems): Document it. * gnu/services.scm (cleanup-gexp): Adjust accordingly. Change-Id: I3a95e49d396fbb2577026aefc247cfe996c5f267 --- doc/guix.texi | 5 +++++ gnu/services.scm | 5 +---- gnu/system/file-systems.scm | 15 ++++++++++++++- 3 files changed, 20 insertions(+), 5 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 52e36e4354..54edd14d1b 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -17988,6 +17988,11 @@ File Systems read-write in its own ``name space.'' @end defvar +@defvar %runtime-variable-data +This file system is mounted as @file{/run} and contains system +information data describing the system since it was booted. +@end defvar + @defvar %binary-format-file-system The @code{binfmt_misc} file system, which allows handling of arbitrary executable file types to be delegated to user space. This requires the diff --git a/gnu/services.scm b/gnu/services.scm index 8a4002e072..ea855ad193 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -632,7 +632,7 @@ (define (cleanup-gexp _) #~(begin (use-modules (guix build utils)) - ;; Clean out /tmp, /var/run, and /run. + ;; Clean out /tmp and /var/run. ;; ;; XXX This needs to happen before service activations, so it ;; has to be here, but this also implicitly assumes that /tmp @@ -663,15 +663,12 @@ (define (cleanup-gexp _) (setlocale LC_CTYPE "en_US.utf8") (delete-file-recursively "/tmp") (delete-file-recursively "/var/run") - (delete-file-recursively "/run") ;; Note: The second argument to 'mkdir' is and'ed with umask, ;; hence the 'chmod' calls. (mkdir "/tmp" #o1777) (chmod "/tmp" #o1777) (mkdir "/var/run" #o755) - (chmod "/var/run" #o755) - (mkdir "/run" #o755) (chmod "/var/run" #o755)))))) (define cleanup-service-type diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 4ea8237c70..65704d7681 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -82,6 +82,7 @@ (define-module (gnu system file-systems) %pseudo-terminal-file-system %tty-gid %immutable-store + %runtime-variable-data %control-groups %elogind-file-systems @@ -448,6 +449,17 @@ (define %immutable-store (check? #f) (flags '(read-only bind-mount no-atime)))) +(define %runtime-variable-data + (file-system + (type "tmpfs") + (mount-point "/run") + (device "tmpfs") + (flags '(no-dev strict-atime)) + (options "mode=0755,nr_inodes=800k,size=20%") + (needed-for-boot? #t) + (check? #f) + (create-mount-point? #t))) + (define %control-groups ;; The cgroup2 file system. (list (file-system @@ -497,7 +509,8 @@ (define %base-file-systems %debug-file-system %shared-memory-file-system %efivars-file-system - %immutable-store)) + %immutable-store + %runtime-variable-data)) (define %base-live-file-systems ;; This is the bare minimum to use live file-systems. base-commit: 8576aaf5f90db9b385ea8cf6dc98bf3c062959dc -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 03:06:36 2024 Received: (at 73494) by debbugs.gnu.org; 26 Sep 2024 07:06:36 +0000 Received: from localhost ([127.0.0.1]:48522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stiaB-0007oP-Hm for submit@debbugs.gnu.org; Thu, 26 Sep 2024 03:06:35 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:59268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stia9-0007nr-Cs for 73494@debbugs.gnu.org; Thu, 26 Sep 2024 03:06:33 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1727334360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jaLqm29VvpujE2iRYM/aR5/gCESFcKJPCcy/9lrEw/o=; b=xkerDelgUz8TvuEpwwPN/GMAI7ssrYXtQUhoEnqWtdoFGUFgzgDb8ZX/nL72UEtQHwBXo8 3BGZgEV8ndliWnuZBxIWaCA758xFTbV/sfnJuHbIwLr9TcTnG+mbYP5QPXy7feaSTmJ0Uj P6/degKFYKIi7hRlTiSWxkMxSe42eqWf7Kvhynhx9q8F/T9AmRfdmWBH/pw9HwDeNJn3Om v128xsXoFR07/TsIHR5bFgP1KNs6WCntRsb6m6dpPKF5aFWXR1NLB3KSXihUfpu+w9ygwx 3zNKInSVr6jtaXWpKCLv9NdArS8jfY1ticK6gtbsTir9PU7TQxTpRq0bsea8xg== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space To: 73494@debbugs.gnu.org Subject: [PATCH 2/2] services: cleanup: Make /var/run a symlink of /run. Date: Thu, 26 Sep 2024 15:05:29 +0800 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: ----- X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services.scm (cleanup-gexp): Make /var/run a symlink of /run. * gnu/services/dbus.scm (dbus-activation): Adjust accordingly. Change-Id: I7b94d3e2fe1bef66f435e84bc77f32311dddd0ce --- gnu/services.scm | 3 +-- gnu/services/dbus.scm | 31 ------------------------------- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a/gnu/services.scm b/gnu/services.scm index ea855ad193..50af5f56b6 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -668,8 +668,7 @@ (define (cleanup-gexp _) ;; hence the 'chmod' calls. (mkdir "/tmp" #o1777) (chmod "/tmp" #o1777) - (mkdir "/var/run" #o755) - (chmod "/var/run" #o755)))))) + (symlink "/run" "/var/run")))))) (define cleanup-service-type ;; Service that cleans things up in /tmp and similar. diff --git a/gnu/services/dbus.scm b/gnu/services/dbus.scm index 76e04bf221..9292172e01 100644 --- a/gnu/services/dbus.scm +++ b/gnu/services/dbus.scm @@ -190,37 +190,6 @@ (define (dbus-activation config) ;; world-readable. (mkdir-p/perms "/run/dbus" user #o755)) - (catch 'system-error - (lambda () - (symlink "/run/dbus" "/var/run/dbus")) - (lambda args - (let ((errno (system-error-errno args))) - (cond - ((= errno EEXIST) - (let ((existing-name - (false-if-exception - (readlink "/var/run/dbus")))) - (unless (equal? existing-name "/run/dbus") - ;; Move the content of /var/run/dbus to /run/dbus, and - ;; retry. - (let ((dir (opendir "/var/run/dbus"))) - (let loop ((next (readdir dir))) - (cond - ((eof-object? next) (closedir dir)) - ((member next '("." "..")) (loop (readdir dir))) - (else - (begin - (rename-file (string-append "/var/run/dbus/" next) - (string-append "/run/dbus/" next)) - (loop (readdir dir))))))) - (rmdir "/var/run/dbus") - (symlink "/run/dbus" "/var/run/dbus")))) - (else - (format (current-error-port) - "Failed to symlink /run/dbus to /var/run/dbus: ~s~%" - (strerror errno)) - (error "cannot create /var/run/dbus")))))) - (unless (file-exists? "/etc/machine-id") (format #t "creating /etc/machine-id...~%") (invoke (string-append #$(dbus-configuration-dbus config) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 28 23:19:18 2024 Received: (at 73494) by debbugs.gnu.org; 29 Sep 2024 03:19:18 +0000 Received: from localhost ([127.0.0.1]:58867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sukSr-0004jE-PL for submit@debbugs.gnu.org; Sat, 28 Sep 2024 23:19:18 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:58480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sukSp-0004iw-Rq for 73494@debbugs.gnu.org; Sat, 28 Sep 2024 23:19:16 -0400 Date: Sun, 29 Sep 2024 11:18:21 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1727579917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TSCso4CQhRPqtedEgjdJpUZWe28A9Hq8WFzhFMZ0f+8=; b=CsrCO4UAHC50h4WvTrGqAHrFBE7pigLmEi9o3x+4xdqmHkIrFFybrbW/xNAXix9Wy0u2bh llTp/wKr11Ww3CezfT7w1xDRO+2LaslbTZKbDVEjAS7CbOT8IC8FMq000Ke16vlcrYpBP8 QiWStZ488B2m6pbVnxaKglmzrxBeiSJPv6BaV35zjK+qQqnYuOR3TMJ0+xndcG31sL9DSG POPYlUc9TjR9hfQC1IsxKW/sjiB1uBsRnetIRcTz/xUo5GBdpHbvgF4cfROIQFtAQW4mt/ 8JvypokVU+8GEgHMjDc1chwqOj6XZ12ngaTW6sNi6M2XckbvqbjcmnYoD9QFnA== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Message-ID: <87cyknm9ky.wl-hako@ultrarare.space> From: Hilton Chain To: 73494@debbugs.gnu.org Subject: Re: [PATCH 0/2] tmpfs /run. In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: -- X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73494 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 26 Sep 2024 14:44:52 +0800, Hilton Chain wrote: > > Hi Guix, > > This series adds a tmpfs /run to %base-file-systems and symlinks /var/run to > it. > > Mount options are taken from Systemd[1], OpenRC also uses the same ones[2]. > (Except no-suid since we have /run/privileged/bin.) > > Thanks > > [1]: https://github.com/systemd/systemd/blob/v256.6/src/shared/mount-setup.c#L102 > [2]: https://github.com/OpenRC/openrc/blob/0.55.1/sh/init.sh.Linux.in#L74 > > Hilton Chain (2): > file-systems: %base-file-systems: Add tmpfs /run. > services: cleanup: Make /var/run a symlink of /run. > > doc/guix.texi | 5 +++++ > gnu/services.scm | 6 +----- > gnu/services/dbus.scm | 31 ------------------------------- > gnu/system/file-systems.scm | 15 ++++++++++++++- > 4 files changed, 20 insertions(+), 37 deletions(-) > > > base-commit: 8576aaf5f90db9b385ea8cf6dc98bf3c062959dc > -- > 2.46.0 As adding mount point to /run requires an immediate reboot after reconfiguring from a system without it, I'll also add a news entry for the change. Merging /var/run and /run is the easiest part, since they are supposed to be cleaned upon booting and nothing will break with the change. However there're many references to both directories in our codebase. I'm not sure if these references should be unified as well. I won't hurry on pushing this change, please leave a comment if you want the change or there's any concern about it. Thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 30 02:38:52 2024 Received: (at 73494) by debbugs.gnu.org; 30 Oct 2024 06:38:52 +0000 Received: from localhost ([127.0.0.1]:33435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t62Lz-0004i3-QD for submit@debbugs.gnu.org; Wed, 30 Oct 2024 02:38:52 -0400 Received: from mail-pf1-f173.google.com ([209.85.210.173]:53573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t62Lw-0004hx-Rh for 73494@debbugs.gnu.org; Wed, 30 Oct 2024 02:38:50 -0400 Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-71e953f4e7cso4616217b3a.3 for <73494@debbugs.gnu.org>; Tue, 29 Oct 2024 23:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730270267; x=1730875067; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=QktPSaSpD1Sk+DFbCrZfqBOmDI2hkaJcuYGZ+POw2ew=; b=dPbT839mBCATQN+dCqXdCMFGnyg6fhlCn1hhAYSVCPopsT2437j+vKVBecLCcanaqb dVY/Azty2DHJHmGGg8lfnhfbFLyZsbRS+LF2EpaDTOxwpH4KbQhEASQGX/CwGnl55/nL t0yRv4MmUxwlNvbihHktwWD91JXHMF0OAY1odt/16e+eEmKtWYWFZp4tQ3/+HmF4CKaL eUhXTKMM3B0AfW0gOFv4iZEr79wrtkMHupnhz4K6fyfr9iRusGn/lH+LDlD779+6XnIY IJe9VjzD6pApzviYZiP0CcKUO9NQxoNDEoqMhbURCWZAR81mRTY4VcHNNcBsYgkXZpMB Ao4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730270267; x=1730875067; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QktPSaSpD1Sk+DFbCrZfqBOmDI2hkaJcuYGZ+POw2ew=; b=nPJLvyvNBYnCEk27h6iryCTszFYCtxa0j5fZ3QeUEu8Hhsac9CV7SA8vO5/Ojph2m7 3rre9Mho68YmhqEvDXGvHdW9c89lbbQwAJlLb8ln1acwZnazEV9Yg6LQLEE02Ci4104G wQTXATZDRubFYEK+jjHqBnyafScFKHzJvNtzPzyYSZCNBPVPSXiymbZUDAlTS2qO261Z dy/IrGdIUy0AvuISUtTL4JKvCzDDtU9ZI+R1eNeC/V+yED/AG9dg84pmWl7uqe4Ipd8Q Zd7EQOqNorAMtKQHXIoWNBHFftjAXS3D0LgQu1AO8oLAoW4lZA0RMYWjcYLxIg0C8Thi 4/Ig== X-Gm-Message-State: AOJu0Yy6vBZPHHK/5+yRNzbpRyo4jiHiUKYLLRaj2nSAeo3B7q52mC8H FaHzXu3ZWxCSIApFFl3Yiak4Ei537dcUcUYp7gmFVdz0DRazrv4F8C9Qug== X-Google-Smtp-Source: AGHT+IFDKYRkx3MLeIUTX8BPACDexbzltw5rJ5XopjaFY6/QBj0Xi91Pr83BmZCnsDMviwQl7C0Jpg== X-Received: by 2002:a05:6a00:3d4d:b0:71e:a3:935b with SMTP id d2e1a72fcca58-7206306ebbfmr20617108b3a.25.1730270267227; Tue, 29 Oct 2024 23:37:47 -0700 (PDT) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057a0b7basm8603007b3a.109.2024.10.29.23.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 23:37:46 -0700 (PDT) From: Maxim Cournoyer To: Hilton Chain Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87cyknm9ky.wl-hako@ultrarare.space> (Hilton Chain's message of "Sun, 29 Sep 2024 11:18:21 +0800") References: <87cyknm9ky.wl-hako@ultrarare.space> Date: Wed, 30 Oct 2024 15:37:39 +0900 Message-ID: <87h68ujdu4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Hilton, Hilton Chain writes: > On Thu, 26 Sep 2024 14:44:52 +0800, > Hilton Chain wrote: >> >> Hi Guix, >> >> This series adds a tmpfs /run to %base-file-systems and symlinks /var/run to >> it. >> >> Mount options are taken from Systemd[1], OpenRC also uses the same ones[2]. >> (Except no-suid since we have /run/privileged/bin.) >> >> Thanks >> >> [1]: https://github.com/systemd/systemd/blob/v256.6/src/shared/mount-setup.c#L102 >> [2]: https://github.com/OpenRC/openrc/blob/0.55.1/sh/init.sh.Linux.in#L74 >> >> Hilton Chain (2): >> file-systems: %base-file-systems: Add tmpfs /run. >> services: cleanup: Make /var/run a symlink of /run. >> >> doc/guix.texi | 5 +++++ >> gnu/services.scm | 6 +----- >> gnu/services/dbus.scm | 31 ------------------------------- >> gnu/system/file-systems.scm | 15 ++++++++++++++- >> 4 files changed, 20 insertions(+), 37 deletions(-) >> >> >> base-commit: 8576aaf5f90db9b385ea8cf6dc98bf3c062959dc >> -- >> 2.46.0 > > As adding mount point to /run requires an immediate reboot after reconfiguring > from a system without it, I'll also add a news entry for the change. > > Merging /var/run and /run is the easiest part, since they are supposed to be > cleaned upon booting and nothing will break with the change. However there're > many references to both directories in our codebase. I'm not sure if these > references should be unified as well. > > I won't hurry on pushing this change, please leave a comment if you want the > change or there's any concern about it. I think it's a worthwhile change. It'd be neat to unify every reference to /var/run to /run in the doc/code too. I'll be trying this on the build farm as there's an annoying problem with anonip that creates FIFOs under /run/anonip, and these currently become plain files upon reboot, breaking the anonip-service services. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 03 10:46:45 2024 Received: (at 73494) by debbugs.gnu.org; 3 Nov 2024 15:46:45 +0000 Received: from localhost ([127.0.0.1]:32960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7coO-0003Ft-OG for submit@debbugs.gnu.org; Sun, 03 Nov 2024 10:46:45 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:48036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7coM-0003Fn-Gh for 73494@debbugs.gnu.org; Sun, 03 Nov 2024 10:46:44 -0500 Date: Sun, 03 Nov 2024 23:45:15 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1730648795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eKE53M8I93LC9V/oDzqhK0EBlMPihhJiQCXm3qTjebg=; b=LzEKrOpH7ZLcN3uiMZIHVv3fQWI/cRNOE4S5TrLJd0z/7m7FCStjnoLEljeaPVhh7vJWtU tmbbKIZi0nXknxQQNXOZPna+lnydqmMqev/cmr3MCms44J/6OPK9k1KqUmFgnzSERyolaS fHg4RiaxMCYkALur4Tu9kVpY6YARhsQ1wifQyCZUTvNc0rvSCDPcWH5ehCtXzxWIJqX7sG jC8DC7C73duQkbf3SCSTMFZl9cUdYGk6DCDSA8M724kmzF5BrzXzknnriUv+0A9RqrXX0+ ZTdqO698xXisK4peEwi8dL2NEYMYyzb7nEuc12LwvcrmUtM5kmlBgGSbLNIl/A== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Message-ID: <87o72w1fuc.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87h68ujdu4.fsf@gmail.com> References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: -- X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Wed, 30 Oct 2024 14:37:39 +0800, Maxim Cournoyer wrote: > I think it's a worthwhile change. It'd be neat to unify every reference > to /var/run to /run in the doc/code too. Thank you, I'm now thinking of unifying them without the tmpfs change, since the tmpfs is not strictly necessary. > I'll be trying this on the build farm as there's an annoying problem > with anonip that creates FIFOs under /run/anonip, and these currently > become plain files upon reboot, breaking the anonip-service services. Won't these files be deleted (c250033aa69f: services: cleanup: Delete /run upon boot.) at boot? From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 04 07:13:21 2024 Received: (at 73494) by debbugs.gnu.org; 4 Nov 2024 12:13:21 +0000 Received: from localhost ([127.0.0.1]:39464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7vxR-0000Jd-Fx for submit@debbugs.gnu.org; Mon, 04 Nov 2024 07:13:21 -0500 Received: from mail-pf1-f179.google.com ([209.85.210.179]:61786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7vxN-0000JV-7B for 73494@debbugs.gnu.org; Mon, 04 Nov 2024 07:13:20 -0500 Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-71e79f73aaeso3390263b3a.3 for <73494@debbugs.gnu.org>; Mon, 04 Nov 2024 04:13:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730722336; x=1731327136; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8yEFdU3DJHxgA4RZLdAdaBWF/BJs1zchnYNRzdz//xI=; b=EUN90ED3D74lzyaIui3yYps1noOxbIOJYSREFPH+XF8fENlvScfLIzqCd/YY22NlcW KjBp8ztq4UBNb/ZpB/A51wLr2R65F+0mNiZ21LEfb5DDAv/4gstYgATWslmi8hq3iqUc ui7slHqHpRdNTJDMZ5dG/j/ao+WufQLfODtSqVinPkhhJq6b0sjju7jZBMFUzIVI3JL9 vM53xPj4ARp61IOW9G9KZMbhZ8++JgF7McH8LLkeXenMRmp2+pkNHgKB61GN8+cTcKts n8JBqXcHYZQNW+EieKGMilySQbZDySur/mTITjEWGVXGE/JI6kCBI396F1tu28jnhZ6b IOrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730722336; x=1731327136; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8yEFdU3DJHxgA4RZLdAdaBWF/BJs1zchnYNRzdz//xI=; b=ng3LK1clTs2Ki4kWG+i1pb5h2JHN17JgmPNYpGgDvbTubgtkt3u7fpUkGbAej68ndm astYyngYhg8wR9BnfIUhPLS/goYwz28L2tsQhSM79sRrYf7C5YbM/AFljCeWFeFqTVmB JgyTlTkqCB9UT7UaLE4V6upIlJclo9j4EMR1aSe03kVNsgykV3nKQeVFeJ9vMOmTXotr ++7WIMzFRpT/WYeQyoN4WX99nNrDdEi4O1d0MikY8u1Kr/FB2GegBiwSNyzypkEu1oY9 hOcW4ThMX7dFjTWCKCIRMaxqErXMsekr2XoWMl+IfwRPpL/Xxl0R0/8PQwPmwKymCtUE +tqA== X-Gm-Message-State: AOJu0YyNyl7/2RrGyov7Q+7zYXLIfAOZ6ek19Q3zFXh0AsECv5efLVc8 DmHts8jlKd9oOqr5DM1ZX6Loy4ve74etN19Bv/rwToeGck1cbOo+ffRUkA== X-Google-Smtp-Source: AGHT+IGAuivwxqpHZ9EsI3oxKqlnjyrf0sXsvwEREgGd+LPhFVP0q2pENNnc2HdfJg3umn/43GqHzw== X-Received: by 2002:a05:6a00:80c:b0:71e:5d1d:1aa0 with SMTP id d2e1a72fcca58-72062f4e529mr43243855b3a.6.1730722335408; Mon, 04 Nov 2024 04:12:15 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720bc1ed42fsm7277991b3a.78.2024.11.04.04.12.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 04:12:14 -0800 (PST) From: Maxim Cournoyer To: Hilton Chain Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87o72w1fuc.wl-hako@ultrarare.space> (Hilton Chain's message of "Sun, 03 Nov 2024 23:45:15 +0800") References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> Date: Mon, 04 Nov 2024 21:12:10 +0900 Message-ID: <87cyjbw63p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Hilton, Hilton Chain writes: > Hi Maxim, > > On Wed, 30 Oct 2024 14:37:39 +0800, > Maxim Cournoyer wrote: >> I think it's a worthwhile change. It'd be neat to unify every reference >> to /var/run to /run in the doc/code too. > > Thank you, I'm now thinking of unifying them without the tmpfs change, since the > tmpfs is not strictly necessary. > >> I'll be trying this on the build farm as there's an annoying problem >> with anonip that creates FIFOs under /run/anonip, and these currently >> become plain files upon reboot, breaking the anonip-service services. > > Won't these files be deleted (c250033aa69f: services: cleanup: Delete /run upon > boot.) at boot? Yes, they should, but I didn't want to take anything for granted. I've come up with a reproducer (system tests) and a fix (already pushed) for it in the series https://issues.guix.gnu.org/74151 -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 04 07:13:59 2024 Received: (at 73494) by debbugs.gnu.org; 4 Nov 2024 12:13:59 +0000 Received: from localhost ([127.0.0.1]:39469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7vy2-0000K8-SD for submit@debbugs.gnu.org; Mon, 04 Nov 2024 07:13:59 -0500 Received: from mail-pf1-f177.google.com ([209.85.210.177]:44189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7vy0-0000K0-Me for 73494@debbugs.gnu.org; Mon, 04 Nov 2024 07:13:57 -0500 Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-723db2798caso573513b3a.0 for <73494@debbugs.gnu.org>; Mon, 04 Nov 2024 04:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730722375; x=1731327175; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hzU8w3gH+1ePi2il05/WychRBK4QSF2HFNDTZ2X1Y94=; b=g7asYM/GLKkaEbUXr15X0TU8AfgPUOAY/H/UG21UnNPhENexAxIYCu+9cUtvso9i1t KLF2Q87z1Q9ic8eWOWMdabLlue9oNKoxbdnrN8fqEiMQEdQb1DnHIzelhpUhHNtZYhD8 vLnyzTSJblOiOMJKf818dfG5OQWyl2QDBe2coGTNvg1mEeVcWfa/RbF5I/tWXxfZHe0r LY7S21JggP+CN/M+SAp3jAvaEVny+cxpB0B4Eikhpg8SPNQWfvf93M3nF5NZhfsIVjX8 +kd6nXLXMOn23znnm7OLIeLOKf3yHx9DaFxSdjQw60d6H7IPhZ4PrdOTywCXYsRQGExl QwgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730722375; x=1731327175; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hzU8w3gH+1ePi2il05/WychRBK4QSF2HFNDTZ2X1Y94=; b=Sd/ABeCF+wEFbCQRI3+Rt2YGwkb5XTzy+0kpSUPSEyHg0iONsBqtVpfG5EJsTOdDpf JsV0GLM6dfiB6pvqXry/H5PgrnTMxZkMvgT8MgwiB8HJZcZd7MLeRd9mBOcZPZOAJFm3 aAUf+CT6+1kR/HE/WtmsKSJLxo0yYBIuGU6i461TTepziGae/c8cUkh4YXagnZsfHB02 4Y3Jzyd1cY6Q2bKG7x37UQoOMY3kgHv1oLjldCAbbRngoUAPCcWVhWy6MilfM4I3d2cq e+g3ky3RiYARIoi4Hr1oudhDSbqvwEahIqcryElYLQad/OFv2+b7ghPImCKZnbzMwoZO 8+sA== X-Gm-Message-State: AOJu0YzcpZ7Cu7zENJscCUm1yc4QsZ5yI5FapnDRdrlNYlw0GhZjebDB 1r/p2zdXlDawxqSA2HlgcWNe50Bklji8zusiJMSx7AerxMxQoNH5Hv1H1w== X-Google-Smtp-Source: AGHT+IHrsNBVuc0JvsLUb791l6lVjOm9YQB2uv9kF+0rmMBxS3fnioUBp0j2SH71TCER+z7r5Xttzg== X-Received: by 2002:a05:6a00:27a0:b0:71d:f510:b791 with SMTP id d2e1a72fcca58-720ab3c6d19mr26582971b3a.12.1730722375447; Mon, 04 Nov 2024 04:12:55 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720bc2c3e08sm7204596b3a.105.2024.11.04.04.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 04:12:54 -0800 (PST) From: Maxim Cournoyer To: Hilton Chain Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87o72w1fuc.wl-hako@ultrarare.space> (Hilton Chain's message of "Sun, 03 Nov 2024 23:45:15 +0800") References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> Date: Mon, 04 Nov 2024 21:12:50 +0900 Message-ID: <878qtzw62l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Hilton Chain writes: > Hi Maxim, > > On Wed, 30 Oct 2024 14:37:39 +0800, > Maxim Cournoyer wrote: >> I think it's a worthwhile change. It'd be neat to unify every reference >> to /var/run to /run in the doc/code too. > > Thank you, I'm now thinking of unifying them without the tmpfs change, since the > tmpfs is not strictly necessary. > >> I'll be trying this on the build farm as there's an annoying problem >> with anonip that creates FIFOs under /run/anonip, and these currently >> become plain files upon reboot, breaking the anonip-service services. > > Won't these files be deleted (c250033aa69f: services: cleanup: Delete /run upon > boot.) at boot? Another thought; is tmpfs implemented on the Hurd? -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 11:35:12 2024 Received: (at 73494) by debbugs.gnu.org; 15 Dec 2024 16:35:12 +0000 Received: from localhost ([127.0.0.1]:51764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMraK-0006rm-7R for submit@debbugs.gnu.org; Sun, 15 Dec 2024 11:35:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMraG-0006qP-4D for 73494@debbugs.gnu.org; Sun, 15 Dec 2024 11:35:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMraA-0007ek-QO; Sun, 15 Dec 2024 11:35:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=EAVkznljMZ99QI4h1o+QkUCbDpv+6fntuSc7jJfwfHo=; b=ergN7hjrIGe9SnysNYkB tdk2b7IVS84CIVrZBCoaSe9JVKaPymjxHpfGI12aeV6F3f7ZTkR4rzoKihJkMZiweoMfAO53VlfTT Jl7Jpr3pOD/+E0WE/ZfXbfP8sPO/IdUZinS8d3PMVFy0SGYCjAX3g3YILYEubjNkw4853+SAXyfWD VOFQAfSnt9lUlyMG0D9Bzvi3j4sbijrSGD4RtXm+SfQaAdOfvTfIIwIMgNteqrGXZMXS+K2NIxxVv RJdG9ed6c3bm96sDeD33HpHef0XXQ8v0rhsWs2aOHE5BWvPSXkEhAeM1DlSw4egyrvgX69W5qVjOh wA0KM8KwgHnVKA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <878qtzw62l.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 04 Nov 2024 21:12:50 +0900") References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> <878qtzw62l.fsf@gmail.com> Date: Sun, 15 Dec 2024 17:35:00 +0100 Message-ID: <87cyhsj45n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain , 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: > Another thought; is tmpfs implemented on the Hurd? Yes, perhaps it=E2=80=99s even older than on Linux, but our file system mou= nting code won=E2=80=99t work there (libc does not provide the =E2=80=98mount=E2= =80=99 function on the Hurd). Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 04:14:49 2024 Received: (at 73494) by debbugs.gnu.org; 16 Dec 2024 09:14:49 +0000 Received: from localhost ([127.0.0.1]:53476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tN7Bg-0004x7-KV for submit@debbugs.gnu.org; Mon, 16 Dec 2024 04:14:48 -0500 Received: from mail-pf1-f175.google.com ([209.85.210.175]:58763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tN7Bf-0004wy-9S for 73494@debbugs.gnu.org; Mon, 16 Dec 2024 04:14:47 -0500 Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7242f559a9fso4878055b3a.1 for <73494@debbugs.gnu.org>; Mon, 16 Dec 2024 01:14:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734340426; x=1734945226; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wOfeA8SvGf1jG+aMmTHMMef82ynSZpkK0D0N0SiLjno=; b=lsg8WMD3XWCouUfDj5fVFKlP01EMJesLurx9ACG+bjS6ABuc6m/jWIw7/lIzSMqMe6 D95VBl5I5z4lUHqwoqJ+9mjQPfgQ2SJWwDQi5drWq8kZ3m5Cfa3sC4Mowt9AdlvXruZ+ ndTJ3SXGT9ujFozc8+PIgtjbt/qxRTN5Pnz/M6qWvT1MYX92XIANi+NMMoCsd4OegUH0 7pGj2aY4K/dGs5XW73Erl+0uY/bLbrdAVGkeLf9LLtJkrgqNsUzdRWN8W6z5jZuvXARw TGWThx/1U/AhIwaKCc3u9ObAcT6z7upCakyWgmfdHeG7Bj+g3KhqwO8mr+pYK08G5rTE koIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734340426; x=1734945226; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wOfeA8SvGf1jG+aMmTHMMef82ynSZpkK0D0N0SiLjno=; b=qHDMeDA6xhogmpXXCVJ1T4smuPtzn5NkSWG44gKpMkjto/7P2Op2T4e/XrCqT+/LOj f4n/vLbbha9H9DoDbW2za9a6w094XwTSIOKuSjkSnq0ZiN2acTM4xcMwvSv2EP0/SzWw MlWEM9V0/HWz1m5v2luhdJx0xINv26mDDF1yQBcZDSNn28ERJ/lU5s5fFASk3jpGHgwv iUJ+guBFrIsZHAPU6C3cw1EpzOCWt8P4gjxM3LrkCPiwlg5KgfApvEg6skbn5oJ8c7op wEOGWVJa/e6zm+YwjwltJ0MyhFEslZyBkckSjyWRdni6Wxg4KjeIAyZF4SbIXsa5Re6E APTg== X-Forwarded-Encrypted: i=1; AJvYcCVVBjG9nziD3rP2qLL4ATYjQHUSiTBKrdVJ7DEOh0BNxeKR81srkPfYqm5ToWu9b/JCWYCQdA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzEwBfO51CgAza5P+8m4+aWClvyLvyQ+QrOlflQVxyMv5ZSrFiW GXmaJ1SJJE7HH2ogC4qg/OsUnCt9K7cL0uUM6y1f5vW3ToHzmwX/FeGnDyZn X-Gm-Gg: ASbGncujwXor00XzNuGMoxYJbFQVcB+LxNoryXBpHRXdZMor4Bjma91jRWvdyDy2GGz Y9FYZldRNawzcR/fcp8K6gHM/YeKPQ9mQ4qzGHGlEiw1i1OIby2fQEmvY8t7K4r6NrCY+canewK FrG5mfvO6luLNJ9Dj+kPJe0izCTe52oOb/McoRpa0e2TTJ3hevyk11UIz8y4Kgmy0nKEXui4Ab5 MUrRAp6/pwrkjYg4XOAKfIJDrr1leEodhAv2E3H+HhbQjBnkGrUOQ== X-Google-Smtp-Source: AGHT+IFpfMnxfPQ+s+JEZWgwz0hjVdU0btarlYpdF9pOp5gX+4VJVdML2B3elPo3vgwPPkMwWVG05A== X-Received: by 2002:a17:90b:3807:b0:2ee:aed6:9ec2 with SMTP id 98e67ed59e1d1-2f28fb700e5mr18869801a91.14.1734340425828; Mon, 16 Dec 2024 01:13:45 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-801d5c0f5fdsm3711685a12.54.2024.12.16.01.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 01:13:45 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87cyhsj45n.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 15 Dec 2024 17:35:00 +0100") References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> <878qtzw62l.fsf@gmail.com> <87cyhsj45n.fsf@gnu.org> Date: Mon, 16 Dec 2024 18:13:35 +0900 Message-ID: <87zfkwt2gw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain , 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> Another thought; is tmpfs implemented on the Hurd? > > Yes, perhaps it=E2=80=99s even older than on Linux, but our file system m= ounting > code won=E2=80=99t work there (libc does not provide the =E2=80=98mount= =E2=80=99 function on the > Hurd). I see; so it's not any more a blocker than the current situation, since we already have some issue with our current code on Hurd. Hilton, I think this series is fine to apply. As you previously mentioned, a news entry will be necessary to let Guix System users to reboot after a reconfiguration past this change. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 10:24:34 2024 Received: (at 73494) by debbugs.gnu.org; 20 Dec 2024 15:24:34 +0000 Received: from localhost ([127.0.0.1]:43637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOeri-0006j4-3B for submit@debbugs.gnu.org; Fri, 20 Dec 2024 10:24:34 -0500 Received: from mx.boiledscript.com ([88.99.243.112]:47922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOere-0006ip-5z for 73494@debbugs.gnu.org; Fri, 20 Dec 2024 10:24:32 -0500 Date: Fri, 20 Dec 2024 23:23:29 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1734708238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=//0wLtEO2jhvGi+6EINaLw4KUuFRWDESdXwQpoVinlE=; b=TF0s0tCffCD4O5oR3kh4AfoX2dIklcTftrJ+bskzgAoWYyJ4A3BhO6Uq0d61S6ngCrW7Co reztwi1OcZ6SRbGWeaAEW0160d1fU0g8poD8XLnPvaWthehbp5Vwz+V5yduqne9GFchHs6 mq8JTLszeLKZHQuRxksi4xAig3mx4fsAoYkuLEiFLewtexZVZDsGD2V5Mab2UUrFPL7jYV YW/pZY103/NUyiJslMPgTLSGlfZC1YxArn59SIUjU0nEiYGSHbJyrEDHwU0Dyhg64n21HM 7nk+a/+AVQT4755RK46iWgT3ovbBmEXKi0l5Gfi6D2awyYwy95xeQJ2s3xjjrg== Message-ID: <87bjx6js3y.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87zfkwt2gw.fsf@gmail.com> References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> <878qtzw62l.fsf@gmail.com> <87cyhsj45n.fsf@gnu.org> <87zfkwt2gw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: base64 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= , 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) T24gTW9uLCAxNiBEZWMgMjAyNCAxNzoxMzozNSArMDgwMCwNCk1heGltIENvdXJub3llciB3cm90 ZToNCj4NCj4gSGksDQo+DQo+IEx1ZG92aWMgQ291cnSoqHMgPGx1ZG9AZ251Lm9yZz4gd3JpdGVz Og0KPg0KPiA+IE1heGltIENvdXJub3llciA8bWF4aW0uY291cm5veWVyQGdtYWlsLmNvbT4gc2ty aWJpczoNCj4gPg0KPiA+PiBBbm90aGVyIHRob3VnaHQ7IGlzIHRtcGZzIGltcGxlbWVudGVkIG9u IHRoZSBIdXJkPw0KPiA+DQo+ID4gWWVzLCBwZXJoYXBzIGl0oa9zIGV2ZW4gb2xkZXIgdGhhbiBv biBMaW51eCwgYnV0IG91ciBmaWxlIHN5c3RlbSBtb3VudGluZw0KPiA+IGNvZGUgd29uoa90IHdv cmsgdGhlcmUgKGxpYmMgZG9lcyBub3QgcHJvdmlkZSB0aGUgoa5tb3VudKGvIGZ1bmN0aW9uIG9u IHRoZQ0KPiA+IEh1cmQpLg0KPg0KPiBJIHNlZTsgc28gaXQncyBub3QgYW55IG1vcmUgYSBibG9j a2VyIHRoYW4gdGhlIGN1cnJlbnQgc2l0dWF0aW9uLCBzaW5jZQ0KPiB3ZSBhbHJlYWR5IGhhdmUg c29tZSBpc3N1ZSB3aXRoIG91ciBjdXJyZW50IGNvZGUgb24gSHVyZC4NCj4NCj4gSGlsdG9uLCBJ IHRoaW5rIHRoaXMgc2VyaWVzIGlzIGZpbmUgdG8gYXBwbHkuICBBcyB5b3UgcHJldmlvdXNseQ0K PiBtZW50aW9uZWQsIGEgbmV3cyBlbnRyeSB3aWxsIGJlIG5lY2Vzc2FyeSB0byBsZXQgR3VpeCBT eXN0ZW0gdXNlcnMgdG8NCj4gcmVib290IGFmdGVyIGEgcmVjb25maWd1cmF0aW9uIHBhc3QgdGhp cyBjaGFuZ2UuDQoNClRoYW5rcyEgIEkgdHJpZWQgdGhpcyBjaGFuZ2UgYWdhaW4gYW5kIG5vdyBp dCBzZWVtcyB0aGUgbmV3bHktYWRkZWQgZmlsZXN5c3RlbQ0Kd29uJ3QgYmUgYXV0b21hdGljYWxs eSBtb3VudGVkLg0KDQpBbm90aGVyIGNvbmNlcm4gSSBoYXZlIGlzLCB3aXRoIC9ydW4gYW5kIC92 YXIvcnVuIHVuaWZpZWQsDQqhrmd1aXggc3lzdGVtIHJvbGwtYmFja6GvIGFuZCChrmd1aXggc3lz dGVtIHN3aXRjaC1nZW5lcmF0aW9uoa8gY2FuJ3QgZmluaXNoIHRoZQ0KYWN0aXZhdGlvbiBzdGFn ZSBiZWNhdXNlIG9mIHRoZSBlcnJvciBoYW5kbGluZyBpbiBkYnVzLWFjdGl2YXRpb24gZnJvbSBw cmV2aW91cw0KZ2VuZXJhdGlvbnMuDQoNCi0tODwtLS0tLS0tLS0tLS0tLS1jdXQgaGVyZS0tLS0t LS0tLS0tLS0tLXN0YXJ0LS0tLS0tLS0tLS0tLT44LS0tDQokIGd1aXggc3lzdGVtIGRlc2NyaWJl DQpHZW5lcmF0aW9uIDcJRGVjIDIwIDIwMjQgMjM6MTA6MDUJKGN1cnJlbnQpDQpbLi4uXQ0KJCBz dWRvIGd1aXggc3lzdGVtIHJvbGwtYmFjaw0KWy4uLl0NCnN3aXRjaGVkIGZyb20gZ2VuZXJhdGlv biA3IHRvIDYNClsuLi5dDQpndWl4IHN5c3RlbTogZXJyb3I6IHJtZGlyOiBEaXJlY3Rvcnkgbm90 IGVtcHR5DQokIGd1aXggc3lzdGVtIGRlc2NyaWJlDQpHZW5lcmF0aW9uIDYJRGVjIDIwIDIwMjQg MjI6NTc6MTkJKGN1cnJlbnQpDQotLTg8LS0tLS0tLS0tLS0tLS0tY3V0IGhlcmUtLS0tLS0tLS0t LS0tLS1lbmQtLS0tLS0tLS0tLS0tLS0+OC0tLQ0KDQpEbyB3ZSBoYXZlIGEgd2F5IHRvIGZpeCB0 aGlzPw0K From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 10:41:27 2024 Received: (at 73494) by debbugs.gnu.org; 20 Dec 2024 15:41:27 +0000 Received: from localhost ([127.0.0.1]:43697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOf82-0007Zu-RR for submit@debbugs.gnu.org; Fri, 20 Dec 2024 10:41:27 -0500 Received: from mx.boiledscript.com ([88.99.243.112]:58538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOf80-0007Zl-UA for 73494@debbugs.gnu.org; Fri, 20 Dec 2024 10:41:25 -0500 Date: Fri, 20 Dec 2024 23:40:46 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1734709253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IBrv1etWgbamvgFg+ra7YHt2GckLMCqXTxsBHNcfzPQ=; b=Smp7Jvix7EXQvwHPW99tGYmWylgutHhwU9XaCJzpuvCyI/DY9bL/Lqtypb6ARyaRjhop4w BOtQSaRt35jDstI5fBgXisZ/lUbv6k13Gjay47MojrkkWZWy2FsTTSjHGpmgbmW7WwS1md gXn7AbEILaID3mn1Hjj8mxKQNR+nR79GbMk6/YvgjUGguGlux9er5CZ+r/RdFy7qOBIM5M cAcv9uXQz5dLzdrprR7+5MKw6fLTdIG3mn14v/1qX6/HKFhRMVQQGekYWpWCCd7c0pcuuZ w6FbTRiPMctufWGbOCNy0OvEJ5+Fu4vFRijVNDyEljGoji0Npvu9GSs0meO1Yg== Message-ID: <87a5cqjrb5.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87bjx6js3y.wl-hako@ultrarare.space> References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> <878qtzw62l.fsf@gmail.com> <87cyhsj45n.fsf@gnu.org> <87zfkwt2gw.fsf@gmail.com> <87bjx6js3y.wl-hako@ultrarare.space> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= , 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, 20 Dec 2024 23:23:29 +0800, Hilton Chain wrote: > > Thanks! I tried this change again and now it seems the newly-added filesystem > won't be automatically mounted. won't be automatically mounted so that an immediate reboot is not required* From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 10:12:14 2025 Received: (at 73494) by debbugs.gnu.org; 2 Jan 2025 15:12:14 +0000 Received: from localhost ([127.0.0.1]:46097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTMrt-00065Q-WD for submit@debbugs.gnu.org; Thu, 02 Jan 2025 10:12:14 -0500 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:52640) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTMrs-00065B-Jg for 73494@debbugs.gnu.org; Thu, 02 Jan 2025 10:12:13 -0500 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-21661be2c2dso142370755ad.1 for <73494@debbugs.gnu.org>; Thu, 02 Jan 2025 07:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735830725; x=1736435525; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/ahOLDFafx28zr9ImY63cINWg58HdCIc66nFcjQR5FU=; b=IeLh4+0asfhkX9gyk1shdebL57l0t3wcOKrBjSrC9DOx0kImIvQQ2pzAzNgJD4NFcp cofBRJAz9CIIoPK903AFtrBwm85WGg0uoVmTqvKwl8Y3wNJiISqpwQ47Cr5c7QdwCy/c Bo8uQifaLL7qa7E6tk+WejLAKKsM9iJuT8YwFT9UZKr0Bzn+m8aqnQAH1l03lNjxcKZ8 C8UbprA298laydyIBqBNjK5jiGy2N1FriAQe/ZHhM8q1IbA8tQnOVPjoSg8XiV90Me6M nO0dt0IBC+KUbbzrce1uqMboDNN8HzAB3qCbf2xKgKRP1AP8JsB6MLKxe96pMXM9+Oyj kEYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735830725; x=1736435525; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/ahOLDFafx28zr9ImY63cINWg58HdCIc66nFcjQR5FU=; b=LWymDjt4vMBI+RzfjwYd8yOcHSECd+wdDTLFnXPP4j220Vvo1wa488ozGojsI8MeIq TgO8EoD01ZqFjl+86WZhgUcDETTSX45jWtAiDuyvRrb3I/mk3QcxAKTi61uCDE6xnLpm i0USSL2cp1KYGVr+hSOerDhUjP0VGd3ahSBp7sPLUwRDAaI4egbo5F3VcKcOe1ulGiWb cc8ocgBOBTKdrBUzcWDhkFClkS0jVTQjpCiLTqCAjaPjatmyx2YW1mBu+FVlsWSMc0mx Dld8xpoFlFjcejCg8GiBTCu3+n2eSYDshemAdzENYIJFRoxVVY1p+H4deamQQk3ZEvb2 02Bg== X-Forwarded-Encrypted: i=1; AJvYcCWi5OeoPCkEnA3fJdhHJCTtF97ZfOOtgIZGw0KQrXF7TTqkkC1RLzMRsrGKhWsMcyRsu+YMyw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yyoc0OH+wd9c64BAKHDEQn4eftt/M/GyBK+lU17Bfc607VgMK48 DJQ/7mQyVNW3+mQifbm4dCZZvbifh1Gze60nTWNoxsD0iTgA9N5lzexZMBQr X-Gm-Gg: ASbGncu7mhLvuKlf5HATekR8KDIUIu/uBIUWTwvwOz8h1BLHroOOuVrN2ACroha3OG7 nUj8aCzSN2b7WeJpetiGAF7WGbbcjBEh83fsBhqRsLwkIc3WqY3qGOHTQsKfPrWp+fsMnZv0Ccf eQHUas9nZ8egRzrfMIXnLHwBQpIGZvwNDyx4YSqn1ScCBZBq+WcFlQEJZDTu870C6SXOQdtemGT aw85s/i3nf416MqHWgsutC7N3v38BwgMbxtM+9uN5t08IKpXKvSCw== X-Google-Smtp-Source: AGHT+IH5TL2hvQ9Wds8IMHjqc05DH/LRccrXhlHFteMUmy2KuNkPdulxZzm9sgZLDuXV+jOTWz2mrw== X-Received: by 2002:a17:903:234c:b0:215:5a53:edee with SMTP id d9443c01a7336-219e6e85b25mr662860465ad.9.1735830725526; Thu, 02 Jan 2025 07:12:05 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f4a2csm230037865ad.175.2025.01.02.07.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2025 07:12:04 -0800 (PST) From: Maxim Cournoyer To: Hilton Chain Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87bjx6js3y.wl-hako@ultrarare.space> (Hilton Chain's message of "Fri, 20 Dec 2024 23:23:29 +0800") References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> <878qtzw62l.fsf@gmail.com> <87cyhsj45n.fsf@gnu.org> <87zfkwt2gw.fsf@gmail.com> <87bjx6js3y.wl-hako@ultrarare.space> Date: Fri, 03 Jan 2025 00:11:54 +0900 Message-ID: <87o70p45dx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Hilton, Sorry for the delay. Hilton Chain writes: [...] > Another concern I have is, with /run and /var/run unified, > =E2=80=98guix system roll-back=E2=80=99 and =E2=80=98guix system switch-g= eneration=E2=80=99 can't finish the > activation stage because of the error handling in dbus-activation from pr= evious > generations. > > $ guix system describe > Generation 7 Dec 20 2024 23:10:05 (current) > [...] > $ sudo guix system roll-back > [...] > switched from generation 7 to 6 > [...] > guix system: error: rmdir: Directory not empty > $ guix system describe > Generation 6 Dec 20 2024 22:57:19 (current) > > Do we have a way to fix this? It's not clear to me where it fails exactly, so I'm not sure, but in the worst case a fat warning as a NEWS entry could do, perhaps? Would it break dbus on a reboot (activation runs at reboot too, right?), or just print this otherwise innocuous error at roll-back/switch-generation time? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 10:30:55 2025 Received: (at 73494) by debbugs.gnu.org; 4 Jan 2025 15:30:55 +0000 Received: from localhost ([127.0.0.1]:56718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU674-0006RM-Op for submit@debbugs.gnu.org; Sat, 04 Jan 2025 10:30:55 -0500 Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:46618) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU66w-0006R6-ES for 73494@debbugs.gnu.org; Sat, 04 Jan 2025 10:30:49 -0500 Date: Sat, 04 Jan 2025 23:23:41 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1736004233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BZ27vVUxuWiPsskm25u0HG4Q0HMG4MK354kEiI/etKM=; b=h4h0X3Eq+La1AyJL2q29F1l6pY7CrwvG/a0i3ArBzlRQ2+F1UtW2O2QliNrdRcl98AllXA 7uuEca56RoGYiNsmBcxTK/dRCL5nXLlfnIQjr3WauUgbVYc+AqsikIGr7q0Ok+gWcEUXzL 4a00lhkPiAtNdqc0FnCCaG65pCvMhBVhctOKi6BCR4Zuajklc/sXosP0q/vxUywQc2b7Q1 B0sB+nBsVA79ZpjGDKCo+bK2OWfZoCtO2HIr7nH/N14aRr3CAmaT2KmNX8cdnJ62nuGrtH Mpl6NMcCO/nusxGkHwYnDbrc4NyVYZ/LO7X56YqmxuBYAwbcRiBt57Em7F2WCw== Message-ID: <87msg6mwle.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87o70p45dx.fsf@gmail.com> References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> <878qtzw62l.fsf@gmail.com> <87cyhsj45n.fsf@gnu.org> <87zfkwt2gw.fsf@gmail.com> <87bjx6js3y.wl-hako@ultrarare.space> <87o70p45dx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= , 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Thu, 02 Jan 2025 23:11:54 +0800, Maxim Cournoyer wrote: > > Hi Hilton, > > Sorry for the delay. > > Hilton Chain writes: > > [...] > > > Another concern I have is, with /run and /var/run unified, > > =A1guix system roll-back=A2 and =A1guix system switch-generation=A2 can= 't finish the > > activation stage because of the error handling in dbus-activation from = previous > > generations. > > > > $ guix system describe > > Generation 7 Dec 20 2024 23:10:05 (current) > > [...] > > $ sudo guix system roll-back > > [...] > > switched from generation 7 to 6 > > [...] > > guix system: error: rmdir: Directory not empty > > $ guix system describe > > Generation 6 Dec 20 2024 22:57:19 (current) > > > > Do we have a way to fix this? > > It's not clear to me where it fails exactly, so I'm not sure, but in the It comes from error handling code in (@@ (gnu services dbus) dbus-activatio= n), dbus-activation. > worst case a fat warning as a NEWS entry could do, perhaps? Would it > break dbus on a reboot (activation runs at reboot too, right?), or just > print this otherwise innocuous error at roll-back/switch-generation > time? Yes, it only affects roll-back/switch-generation and is harmless to dbus se= rvice since the activation should be done already. However I'm afraid its failure may break the activation process: --8<---------------cut here---------------start------------->8--- (for-each primitive-load '("...-activate-service.scm" ...)) --8<---------------cut here---------------end--------------->8--- Can we run this primitive-load with false-if-exception? From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 23:17:15 2025 Received: (at 73494) by debbugs.gnu.org; 21 Jan 2025 04:17:15 +0000 Received: from localhost ([127.0.0.1]:52849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta5hS-0007bS-MQ for submit@debbugs.gnu.org; Mon, 20 Jan 2025 23:17:14 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:50423) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ta5hQ-0007b7-0D for 73494@debbugs.gnu.org; Mon, 20 Jan 2025 23:17:12 -0500 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-216426b0865so87225225ad.0 for <73494@debbugs.gnu.org>; Mon, 20 Jan 2025 20:17:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737433025; x=1738037825; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jQmy9Y88bV4rDzRZrkxG80x153VEthkGMPZMhtwSVak=; b=ioFBE5Sna93AKCU+EFkQihWd0md00Lvq/J84GKM6mq6PrQ8jsmzEzxMsKm9ccaNrcY UOQqrerpW6A/TJ1Xs/VPJ9X9tME3XMsJkhAjDUMGtw88rnKLH4cRN7qgsa6tdPeCtsLe MXoFR8uLeSVIe7fW1Kq5K3zJ0j5fFz0DZ+8nxQb7ZQyBMoCJJW+B5eXoXS0GBhyoSpeB NTtG/ol/l93PrrTX6MOSpiKq/+ssj4vLGfSekzQxR682t+w/uK0yjgZB+wR1cvQMXpD+ HXSYIHCNR4wxoxlF9N4OPQpYwT3H38AprnyHVAcSTy1w2Kdusu4XGQN2g/cRQJUzXVbd TaDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737433025; x=1738037825; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jQmy9Y88bV4rDzRZrkxG80x153VEthkGMPZMhtwSVak=; b=jzT84KYaX8dLL0eaaOaLoFPPL8Yn9NQuOxPbbs+mGfSXzTkvHuYXKqYMW6hDE2vJWl nlc6R2vhMscOUidZ+/dacio4u8igX1XOMxcfX32++GKMaELGtoNxz9Aohw0i27nrfjSF oSsg/CgH59aUDMYghkL3VqT3NWXzc/vOol3CCrtjziwg4tHROsNWrgO6AybBo3GDJD76 /zGtGcnRPeboh1o0U5MUnW1Z/s69BWMwSAXjKgj7vrr1/5mixPiimyp9R4sEZy9xfudo MHBeF/vLz22aeC8gb9qw8MyZulkE/qtaUmi7tkncNVGxfLDedk4cmv3o3aDjC0PkWfMw x7nQ== X-Forwarded-Encrypted: i=1; AJvYcCXSpt8HnyALqER6K/t9PTivxeJXF2hYdjt6IxSNslsfLbri/CBveYtUkFGtcoR3NDJqzmFlaQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxVfMPt9v1hZAVSAG5sjk6SnnoOyKdOd2ytYmNElWkh4OLRVEBu 4ZPnbe6siqLMJejR3ahsb4HiEq5Wo7oF6V1RZAQbXrrlfqxBix9n7qPIeY2vQHE= X-Gm-Gg: ASbGncsvOOnZVE1m2a4t0qrReK82uQ7+sANR9vkMN64/AXyo7fZVM8n+qwMz1MH1A4r l49464DwNv69d2gBMIYJ/qbIxJ0aN8gNpDRH06db4EG5nMg9BqjUFYvtHS1W6KPK2f0/icgx3vI ekMWOizCWBStoGInyP9MdniwZwGgIr77SGv5J1bRPX28iKo0HFybMZs/FSfj75U2yTWS9qHOjwm Swqz3sPJzBiwCgOecpRL31FIOkm0Z1InUS5XBP3i6Vmd6oYapYMHNp97KpyuXzMsQc= X-Google-Smtp-Source: AGHT+IHw2f1XwHxNlJGJyiFttza3hjirHuic2gm58qmk6PEFvfIzproi8eUS3lOHFxQzi4fuNUmoww== X-Received: by 2002:a17:903:1111:b0:21a:5501:938 with SMTP id d9443c01a7336-21c3560766cmr206222955ad.52.1737433024818; Mon, 20 Jan 2025 20:17:04 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2d3b841bsm67840695ad.146.2025.01.20.20.17.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 20:17:04 -0800 (PST) From: Maxim Cournoyer To: Hilton Chain Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87msg6mwle.wl-hako@ultrarare.space> (Hilton Chain's message of "Sat, 04 Jan 2025 23:23:41 +0800") References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> <878qtzw62l.fsf@gmail.com> <87cyhsj45n.fsf@gnu.org> <87zfkwt2gw.fsf@gmail.com> <87bjx6js3y.wl-hako@ultrarare.space> <87o70p45dx.fsf@gmail.com> <87msg6mwle.wl-hako@ultrarare.space> Date: Tue, 21 Jan 2025 13:16:52 +0900 Message-ID: <875xm8by2z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Hilton, Sorry for the delay. Hilton Chain writes: > Hi Maxim, > On Thu, 02 Jan 2025 23:11:54 +0800, > Maxim Cournoyer wrote: >> >> Hi Hilton, >> >> Sorry for the delay. >> >> Hilton Chain writes: >> >> [...] >> >> > Another concern I have is, with /run and /var/run unified, >> > =E2=80=98guix system roll-back=E2=80=99 and =E2=80=98guix system switc= h-generation=E2=80=99 can't finish the >> > activation stage because of the error handling in dbus-activation from= previous >> > generations. >> > >> > $ guix system describe >> > Generation 7 Dec 20 2024 23:10:05 (current) >> > [...] >> > $ sudo guix system roll-back >> > [...] >> > switched from generation 7 to 6 >> > [...] >> > guix system: error: rmdir: Directory not empty >> > $ guix system describe >> > Generation 6 Dec 20 2024 22:57:19 (current) >> > >> > Do we have a way to fix this? >> >> It's not clear to me where it fails exactly, so I'm not sure, but in the > > It comes from error handling code in (@@ (gnu services dbus) dbus-activat= ion), > dbus-activation. > >> worst case a fat warning as a NEWS entry could do, perhaps? Would it >> break dbus on a reboot (activation runs at reboot too, right?), or just >> print this otherwise innocuous error at roll-back/switch-generation >> time? > > Yes, it only affects roll-back/switch-generation and is harmless to dbus = service > since the activation should be done already. > > However I'm afraid its failure may break the activation process: > > (for-each primitive-load > '("...-activate-service.scm" ...)) > > Can we run this primitive-load with false-if-exception? I guess we could do that; extra points if the error is caught and logged (but otherwise neutralized). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 01 07:37:33 2025 Received: (at 73494) by debbugs.gnu.org; 1 Mar 2025 12:37:33 +0000 Received: from localhost ([127.0.0.1]:35010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1toM61-0003Yq-GT for submit@debbugs.gnu.org; Sat, 01 Mar 2025 07:37:33 -0500 Received: from mx.boiledscript.com ([88.99.243.112]:44138) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1toM5y-0003Yd-H0 for 73494@debbugs.gnu.org; Sat, 01 Mar 2025 07:37:31 -0500 Date: Sat, 01 Mar 2025 20:36:58 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1740832648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CAqHmV/xHnsG/t6+eR0j5Hjjbur6BmABYX8+t53oWAc=; b=TmMTGP0yQpGViAFWsxNOIQACYSsTc//6DowvFu0TGGq1uCpD6W8YP/5rQJTm8qEQ1BOrBd CQ5MSkRoBKqau/MOzpr7FbZbZLzTa02Bu4osJuM18rh/C3Ucvt08wtTwGWR2nCtJu8J8FK dug1IQQt/dwr9eZ6OY6cx+e2CWhonE6VgjfHOY2T8zNdSqXyXRKAvyBrYkCNWQwiAaG2WN wv2Sz9GDqGQFWw0S2cXfGc/jKRCjbKT0ule80NuTqZ6v/0Wlo/Kqc3I7fin72+MtrRU8pJ SNduvt+BI+EcwReeg98a4/GMzdiWIAwk8JPd2pY9+lWarBRV4rjgR+6xmk7mrQ== Message-ID: <87bjul2ahh.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <875xm8by2z.fsf@gmail.com> References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> <878qtzw62l.fsf@gmail.com> <87cyhsj45n.fsf@gnu.org> <87zfkwt2gw.fsf@gmail.com> <87bjx6js3y.wl-hako@ultrarare.space> <87o70p45dx.fsf@gmail.com> <87msg6mwle.wl-hako@ultrarare.space> <875xm8by2z.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= , 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 21 Jan 2025 12:16:52 +0800, Maxim Cournoyer wrote: > > > However I'm afraid its failure may break the activation process: > > > > (for-each primitive-load > > '("...-activate-service.scm" ...)) > > > > Can we run this primitive-load with false-if-exception? > > I guess we could do that; extra points if the error is caught and logged > (but otherwise neutralized). --8<---------------cut here---------------start------------->8--- building /gnu/store/fyn7ymd24k8v4ar2rqvp4yk75qcclv7q-switch-to-system.scm.drv... making '/var/guix/profiles/system-98-link' the current system... populating /etc from /gnu/store/svdqdysmfb5sz3s0qvfd2c9hiidrsabs-etc... setting up privileged programs in '/run/privileged/bin'... guix system: warning: failed to activate '/gnu/store/mkl7gr24xrdjm9gdr1jhzadc9pksg4f2-activate-service.scm': In procedure rmdir: Directory not empty The following derivation will be built: /gnu/store/fgr7dafbxlcfvdh47kcd2bax0dva0yy6-install-bootloader.scm.drv building /gnu/store/fgr7dafbxlcfvdh47kcd2bax0dva0yy6-install-bootloader.scm.drv... guix system: bootloader successfully installed on '(/efi)' --8<---------------cut here---------------end--------------->8--- Does this warning look good to you? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 04 09:25:40 2025 Received: (at 73494) by debbugs.gnu.org; 4 Mar 2025 14:25:40 +0000 Received: from localhost ([127.0.0.1]:56580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpTDI-0006Oj-1f for submit@debbugs.gnu.org; Tue, 04 Mar 2025 09:25:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44226) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tpTDF-0006OP-P3 for 73494@debbugs.gnu.org; Tue, 04 Mar 2025 09:25:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tpTD9-0005fV-42; Tue, 04 Mar 2025 09:25:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=yTSKYhgtp1hhDq2G6rwoLpnH708TDYGzYJFTeajk5Sk=; b=QABhWuLkBx0sQBaylm1C gPUkuYexFSyXBwlarBxQ1vMko8FkMH8PSWVhFhapKGd5fosUwmMljiQ0gH2Fxjv4Tn5EvDkCQJoXN 8Gy/xz3U8t4lS9d8mAy6d8cB/dRc1OdOKYKwE4rOc/fs0puvvp530Drp9jQ5nIYx0FRnfFEPpGLlQ oxgF686NDOmGzgIuKS104ohYFUFTil/ipGB0hUHhmg5Ubr6t/drljcSvN7jsSGTJC4exbWt2pgWh7 NK+l2bPmrkJ7nBdN5edlGsA7FU/eAZoIz+mMzwQ6kB9zBM+OI2su/MlOE7+LxvmtmEXdbVUpMR4CE 5a0iZhXEOjeZjQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Hilton Chain Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87bjul2ahh.wl-hako@ultrarare.space> (Hilton Chain's message of "Sat, 01 Mar 2025 20:36:58 +0800") References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> <878qtzw62l.fsf@gmail.com> <87cyhsj45n.fsf@gnu.org> <87zfkwt2gw.fsf@gmail.com> <87bjx6js3y.wl-hako@ultrarare.space> <87o70p45dx.fsf@gmail.com> <87msg6mwle.wl-hako@ultrarare.space> <875xm8by2z.fsf@gmail.com> <87bjul2ahh.wl-hako@ultrarare.space> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 14 =?utf-8?Q?Vent=C3=B4se?= an 233 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du =?utf-8?Q?V=C3=A9lar?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 04 Mar 2025 15:25:28 +0100 Message-ID: <87o6ygc1pj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73494 Cc: 73494@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hilton Chain skribis: > On Tue, 21 Jan 2025 12:16:52 +0800, > Maxim Cournoyer wrote: >>=20 >> > However I'm afraid its failure may break the activation process: >> > >> > (for-each primitive-load >> > '("...-activate-service.scm" ...)) >> > >> > Can we run this primitive-load with false-if-exception? >>=20 >> I guess we could do that; extra points if the error is caught and logged >> (but otherwise neutralized). > > building /gnu/store/fyn7ymd24k8v4ar2rqvp4yk75qcclv7q-switch-to-system.scm= .drv... > making '/var/guix/profiles/system-98-link' the current system... > populating /etc from /gnu/store/svdqdysmfb5sz3s0qvfd2c9hiidrsabs-etc... > setting up privileged programs in '/run/privileged/bin'... > guix system: warning: failed to activate '/gnu/store/mkl7gr24xrdjm9gdr1jh= zadc9pksg4f2-activate-service.scm': In procedure rmdir: Directory not empty > The following derivation will be built: > /gnu/store/fgr7dafbxlcfvdh47kcd2bax0dva0yy6-install-bootloader.scm.drv > > building /gnu/store/fgr7dafbxlcfvdh47kcd2bax0dva0yy6-install-bootloader.s= cm.drv... > guix system: bootloader successfully installed on '(/efi)' > > Does this warning look good to you? Yes, sounds reasonable. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 04 21:04:00 2025 Received: (at 73494) by debbugs.gnu.org; 5 Mar 2025 02:04:00 +0000 Received: from localhost ([127.0.0.1]:33730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpe76-00077e-CI for submit@debbugs.gnu.org; Tue, 04 Mar 2025 21:04:00 -0500 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:52445) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tpe70-00077K-BA for 73494@debbugs.gnu.org; Tue, 04 Mar 2025 21:03:57 -0500 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-22349bb8605so121961285ad.0 for <73494@debbugs.gnu.org>; Tue, 04 Mar 2025 18:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741140228; x=1741745028; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sjx2HZ6rUnXka7hCPspATG+qXypiEBWz7iBZd/K2F8c=; b=cXAoQeeHZx9l03BkcFZBkFrVbpGxAo6uR9ervFNmJmm2K7kktABtr/mUOw3cQsw1Me faAdo3rzVKU90xODTNUWrNuynPyF/vsMF7MaT6SUIZhSPjuv8BWNq1t4mMJuuppEYObM Us+OzCf1wyzyRMLJ+Ouk6RMq1mvjDoH0HP/bge1xyZyqGrUbCMDpChDWTrkkaIzoxHVJ NNDsGU+xUGOqMkOtGkCovOE00JMAGB1JJSDSHqPZ+xbptxFIFtGW4Jeoyx+omI7lchgz vxgOMDA8ShzYgPaL4rTO5s+l4J41GxTVWq5JbopGI7qOq7s6ekQOORPq20bkklD6htoh qKzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741140228; x=1741745028; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Sjx2HZ6rUnXka7hCPspATG+qXypiEBWz7iBZd/K2F8c=; b=hl3cs6sssMNm6eAi4rLLcjJZKTzGa0Z/3n1hEbQUc7sHbMJ9SsU51fS4jcP0J8bDJo G67Zfge+HPcZNBx7DNN7KHQ8le9KioqGnwMGOQcyGLO2G/fcXY1oTxbYMT8Hmfoxo9+Q /rthiwgoxSSSv28MjkuPq5gUYGAoywXOQ55GqLcXFVzEvo/1S8Jzst4Z2XIixcY77fwl hHKBlm5mJWt25eP23LXZCaWuCm/GqEB9WhhphMEfJspub3TNIVSGLc/L9KEIzXeZfN2s 3aY6Z5ooCqPKW5QmhAe8YY9PCRzpd7IiDnNFon0x2QmTlOCgsruNn4MlAyJZJyyAmxsd 1yFQ== X-Forwarded-Encrypted: i=1; AJvYcCVyF0SC6Mmm4lfxT55k7aKt2IjXc0Sj3WW9DtX7hsnn0geY7xngy7XWOtqZeomzI0sDV+sIBw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx6vKbxM0mF6jwXeVLDfCfDKAv89+cP1dl+3SYmXcPK9OVGPWg0 SuG4KOZop6uQzHE8R2xnc9hRpXkvPs/BPGuOQnviwaXmwNsymXhCnE9+1JKs X-Gm-Gg: ASbGncsBuiWIUHRWgnvW3s6AHeazV0bmOgMiVcDMkYY5trHCxQcVcCPkDAvOXp8cB0H LAeZnPNQOUqQUUGZheaVmWk04FChV1Qbcwnuv5OQnuRffIp91R8eSZMJEIrEMPiluOALsGwhxMq ov7EH4bRfBkQHM8TriowaA7qXpnCCQTRDzdcYOVphTiGjXkMa7PRmHZbmJXxrIJYIlA7ycyeW+U 6bhjYuSLwzqFeo+PpGJSuKKPSqe+zrZqQiyvfuQL43reZiqS7yUZhbpZ0zR129b+c5RNyNN834P hqsSM9gmkJdx3DgyYkmJ3ip09n9pQx0vvXQ692yJ18I= X-Google-Smtp-Source: AGHT+IHVOIA2PUZ1en72MOWxEKTf9aBJV5L5pMZYAubLlD3W18Stqdv/jX9ioij3GO+PedYRQN5QBQ== X-Received: by 2002:a17:903:32c2:b0:223:66bc:f1e6 with SMTP id d9443c01a7336-223f1c6afa6mr26428795ad.5.1741140227608; Tue, 04 Mar 2025 18:03:47 -0800 (PST) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c5a33sm102483915ad.153.2025.03.04.18.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 18:03:46 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#73494] [PATCH 0/2] tmpfs /run. In-Reply-To: <87o6ygc1pj.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 04 Mar 2025 15:25:28 +0100") References: <87cyknm9ky.wl-hako@ultrarare.space> <87h68ujdu4.fsf@gmail.com> <87o72w1fuc.wl-hako@ultrarare.space> <878qtzw62l.fsf@gmail.com> <87cyhsj45n.fsf@gnu.org> <87zfkwt2gw.fsf@gmail.com> <87bjx6js3y.wl-hako@ultrarare.space> <87o70p45dx.fsf@gmail.com> <87msg6mwle.wl-hako@ultrarare.space> <875xm8by2z.fsf@gmail.com> <87bjul2ahh.wl-hako@ultrarare.space> <87o6ygc1pj.fsf@gnu.org> Date: Wed, 05 Mar 2025 11:03:33 +0900 Message-ID: <87cyewi68a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain , 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Ludovic Court=C3=A8s writes: [...] >>> I guess we could do that; extra points if the error is caught and logged >>> (but otherwise neutralized). >> >> building /gnu/store/fyn7ymd24k8v4ar2rqvp4yk75qcclv7q-switch-to-system.sc= m.drv... >> making '/var/guix/profiles/system-98-link' the current system... >> populating /etc from /gnu/store/svdqdysmfb5sz3s0qvfd2c9hiidrsabs-etc... >> setting up privileged programs in '/run/privileged/bin'... >> guix system: warning: failed to activate >> '/gnu/store/mkl7gr24xrdjm9gdr1jhzadc9pksg4f2-activate-service.scm': >> In procedure rmdir: Directory not empty >> The following derivation will be built: >> /gnu/store/fgr7dafbxlcfvdh47kcd2bax0dva0yy6-install-bootloader.scm.drv >> >> building /gnu/store/fgr7dafbxlcfvdh47kcd2bax0dva0yy6-install-bootloader.= scm.drv... >> guix system: bootloader successfully installed on '(/efi)' >> >> Does this warning look good to you? > > Yes, sounds reasonable. I wanted to apply this change, but 'make check-system TESTS=3Djami' now crashes at boot in gnu/build/activation.scm: --8<---------------cut here---------------start------------->8--- In gnu/build/activation.scm: 102:9 1 (retry) In ice-9/boot-9.scm: 1685:16 0 (raise-exception _ #:continuable? _) In procedure open-fdes-at: Not a directory [ 0.978773] Kernel panic - not syncing: Attempted to kill init! exitcode= =3D0x00000000 [ 0.978994] CPU: 0 UID: 0 PID: 1 Comm: init Not tainted 6.13.5-gnu #1 c1= 88f1cb5be905eaa0f98c5aa10913ea17baaded [ 0.979289] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS = 1.16.2/GNU Guix 04/01/2014 [ 0.979538] Call Trace: [ 0.979612] [ 0.979677] dump_stack_lvl+0x2b/0xa0 [ 0.979786] dump_stack+0x14/0x20 [ 0.979884] panic+0x364/0x390 [ 0.979974] ? raw_spin_rq_unlock+0x14/0x40 [ 0.980095] do_exit+0x926/0xa90 [ 0.980187] do_group_exit+0x38/0x90 [ 0.980293] __x64_sys_exit_group+0x1c/0x20 [ 0.980407] x64_sys_call+0x10d5/0x26f0 [ 0.980513] do_syscall_64+0x74/0x160 [ 0.980616] entry_SYSCALL_64_after_hwframe+0x76/0x7e [ 0.980754] RIP: 0033:0x572f95 [ 0.980840] Code: ff ff 0f 1f 00 64 41 83 3c 24 02 75 bf eb b8 66 0f 1f = 44 00 00 48 c7 c6 b0 ff ff ff ba e7 00 00 00 eb 03 66 90 f4 89 d0 0f 05 <48= > 3d 00 f0 ff ff 76 f3 f7 d8 64 89 06 eb ec 66 2e 0f 1f 84 00 00 [ 0.981330] RSP: 002b:00007ffe13646448 EFLAGS: 00000206 ORIG_RAX: 000000= 00000000e7 [ 0.981539] RAX: ffffffffffffffda RBX: 00000000007b3378 RCX: 00000000005= 72f95 [ 0.981738] RDX: 00000000000000e7 RSI: ffffffffffffffb0 RDI: 00000000000= 00000 [ 0.981939] RBP: 0000000000000000 R08: 0000000000000000 R09: 00000000000= 00000 [ 0.982138] R10: 0000000000446870 R11: 0000000000000206 R12: 00000000008= 05768 [ 0.982328] R13: 0000000000511b00 R14: 0000000000000003 R15: 00000000008= 05780 [ 0.982518] [ 0.982663] Kernel Offset: 0x30000000 from 0xffffffff81000000 (relocatio= n range: 0xffffffff80000000-0xffffffffbfffffff) [ 0.982948] Rebooting in 1 seconds.. --8<---------------cut here---------------end--------------->8--- Hilton, would you mind taking a look? And because of commit 5074871043 ("build: marionette: Make it possible to reboot VM during tests.") this causes an infinite reboot loop. That's a bad fault enough that it shouldn't happen, but I'm wondering if I shouldn't revert 5074871043 to avoid hanging tests in the odd cases where this happens? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 00:35:07 2025 Received: (at 73494) by debbugs.gnu.org; 5 Mar 2025 05:35:07 +0000 Received: from localhost ([127.0.0.1]:34129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tphPO-0001Nn-Ml for submit@debbugs.gnu.org; Wed, 05 Mar 2025 00:35:06 -0500 Received: from mail-qv1-xf2b.google.com ([2607:f8b0:4864:20::f2b]:55346) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tphPM-0001Mg-Sx for 73494@debbugs.gnu.org; Wed, 05 Mar 2025 00:35:05 -0500 Received: by mail-qv1-xf2b.google.com with SMTP id 6a1803df08f44-6e891e447dcso1060406d6.2 for <73494@debbugs.gnu.org>; Tue, 04 Mar 2025 21:35:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741152899; x=1741757699; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=G/8xqFz6b2Wd74jRDLsnM8ddbBz2rVw0w5GXLgi27qI=; b=mllMWr5pK/9SYNnv4YHcvvTqBBprWOm+9qkT8kWd5Q+AUTrlJTE3KLY7jcAfbmwhdG xwcwrEHxgbxePzgC1SgfMysfxM39826u44XvGjwiwOGz2butN3kTZG6PF/7ynebRJWI6 AHEG9QjZBplUf4c2iygvqLFgJ7u9TAPO7liLX1duNbiVtVz8PEIQc1kV9D7STGtr8XlN /9lUA/CyuEB2Xxb4aVahfqYwx2kaps4Zw3tIXOoMdIRvdCAN7ZWz7N34pzeBIqyx5Dz6 u45Ixlp5bmaXZNfmBpf/pdEjgraM9nOV6VG0b/BUcGPgSaJCeGXFdw7H1eqM09bCWpSl htZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741152899; x=1741757699; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G/8xqFz6b2Wd74jRDLsnM8ddbBz2rVw0w5GXLgi27qI=; b=oVy6eEP+eF4zdc4v1Sm+ghTaJWsxsUp9VM15ifXX++cn9OTbGhy1SxEAwnWw8Dzd/t gaQDbj+mfFtvBrLu6uk4xra1ZUlkyUrEJuJukilOD98rBluD8v1fPIu/qaDqIlrExBXL puEiRslZSMflZX2kDrtQKB4ZkKphDtT6x++aaOIOk8a7vrMiwVhzjL8TtHSh42de7lkR T1H12rG+i1a2HDriCmRbt9yN4O6HeYBDN4fabdzK5e8A1K4YY2hc2UrbirMdOm2fxYcB CYOq+zzafA9wIIHQ+t/oAgLGXB25wtJRhqfNxrwWceCgLUPUtcsG/63YjEruh/ah8Q6t ccvg== X-Gm-Message-State: AOJu0YylBcYVuxe1W6iOMgPUD2vAs5YUCJJcP0GM6wKqY141wuWzMGgL pkcwDQuCiDPitFBf7RvvCUl5VB1YysDX0wVIjESMn2nKapa35DTz33il+NunSKg= X-Gm-Gg: ASbGncsH8QqUEMze5+CNAcE466qdYyRICYUIiW6AUZK/wzBMTW98sUmZDt8bU0o+g5L /ZQ+sS8/jDKTeoPNx1QGVSk6YGazI013N1UNs88TrHLhUZboQgDYUk7Pooeg20/xLPFFr+twKio 3jXqLqrVViWdXmhxJTtYr2Cv3GvaxREGUf8bekggQQybwADTBdwt/EvWDsV/Egkn+7hwAkPACZW /EOhujrS0LMvaV9lZsLoQCEBbPRCcHXjbn1YJAiaRaz6CgjmDQAPa234VpTMrWatI8ybZQsEQJz oC0EQOR1tJMM4b6Oc/AYnUj+N3CDsSYv4OanIgcuH5PzZTxwxbLXOMWj9NqsaLQWRA== X-Google-Smtp-Source: AGHT+IEBw9DfArks1xpXrnZ9w38+qYAdti0i8LRZQ26rabRKJMEsh1cP0XNMSuv2IDJRls++x/3n0w== X-Received: by 2002:ad4:5d64:0:b0:6e2:4859:f062 with SMTP id 6a1803df08f44-6e8e6cfda82mr32904986d6.21.1741152898719; Tue, 04 Mar 2025 21:34:58 -0800 (PST) Received: from terra (vps-6234970c.vps.ovh.ca. [51.222.13.224]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e89766120esm75572926d6.54.2025.03.04.21.34.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 21:34:57 -0800 (PST) From: Maxim Cournoyer To: Hilton Chain Subject: Re: [bug#73494] [PATCH 2/2] services: cleanup: Make /var/run a symlink of /run. In-Reply-To: (Hilton Chain's message of "Thu, 26 Sep 2024 15:05:29 +0800") References: Date: Wed, 05 Mar 2025 14:34:42 +0900 Message-ID: <87wmd4ghvx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Hilton Chain writes: > * gnu/services.scm (cleanup-gexp): Make /var/run a symlink of /run. > * gnu/services/dbus.scm (dbus-activation): Adjust accordingly. I pushed 1/2 but not this one until we figure out how to fix the jami system test that it breaks. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 01:58:23 2025 Received: (at 73494) by debbugs.gnu.org; 5 Mar 2025 06:58:24 +0000 Received: from localhost ([127.0.0.1]:34457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpihz-0000qT-KY for submit@debbugs.gnu.org; Wed, 05 Mar 2025 01:58:23 -0500 Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:43244) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tpihu-0000q7-GE for 73494@debbugs.gnu.org; Wed, 05 Mar 2025 01:58:22 -0500 Date: Wed, 05 Mar 2025 14:57:46 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741157896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M2fgn81vjCtSUdPhGDULA+7rNjQMio6xnIQzGwI82Ow=; b=Cqr4AdRg2kINLzRHIsRLaW+J7BwA0a5fhLvsFw7gZPV//tSXA7L66uBqBbOImyHNSyZjX2 IpN8AoY7PzoTcburngK4czTTREuKBLbIuWn4TPIreeBnVgW3//k1Enp+2MxC0MmqXqKrnX fM4JpnJiDzAYQkc15PhJ4kMMvH4fMv/ocQlx0VYfl+I8NBA985qyvxgEOqNSfBMsTuy6HT j+HVshHhWUHWs1ObEN3Z/wnxMMcuPhNaxaBRlwsoRrzSA3J+yScMaA30OvDd9XeDLJ39bQ ZdKwEbaP6+eqxcyXicKLoOhSf0yTuapzpFSTFJowt4dQbEYbbuX4WQyvQ/16Yg== Message-ID: <87ikoot15h.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH 2/2] services: cleanup: Make /var/run a symlink of /run. In-Reply-To: <87wmd4ghvx.fsf@gmail.com> References: <87wmd4ghvx.fsf@gmail.com> MIME-Version: 1.0 X-MS-Reactions: disallow Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 05 Mar 2025 13:34:42 +0800, Maxim Cournoyer wrote: > > Hi, > > Hilton Chain writes: > > > * gnu/services.scm (cleanup-gexp): Make /var/run a symlink of /run. > > * gnu/services/dbus.scm (dbus-activation): Adjust accordingly. > > I pushed 1/2 but not this one until we figure out how to fix the jami > system test that it breaks. Sorry, I have reverted this commit, since without applying 2/2 dbus-service-type will be broken. 1/2 can't live alone. Let's reapply it after solving all issues :) From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 03:58:18 2025 Received: (at 73494) by debbugs.gnu.org; 5 Mar 2025 08:58:18 +0000 Received: from localhost ([127.0.0.1]:35046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpka2-0007OZ-0e for submit@debbugs.gnu.org; Wed, 05 Mar 2025 03:58:18 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:57500) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tpkZz-0007OK-Dw for 73494@debbugs.gnu.org; Wed, 05 Mar 2025 03:58:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1741165087; bh=65C6lmNRF8LSf/4K+CMV5EFYytOdQfDM+gbm+cRiARM=; h=From:To:Cc:Subject:Date:From; b=mvr5PDJefEa3T8a/PDbYDcnvFqmwDJWkkt3dRIW7SrqWmHuglAKFo4qNblUO+W0zK R0YDEnkGMw3Q87pQcYzPh0Q28mjUXPFFT5UPxZGoU7mfcobcMY/tHLPMnvTSzAMSNA KJPZmGGV1hW/anz4rDfkTAcplg9mDPqu2ThvzueqszYUCSzlbpaSXLjlM1Tua5a8Ja srBF4ku5tbICw2dQrs5mzJPE+fJvCePyXoiDzZkxo2SnpOwYXQdZVjIh5xfgkFLAJM 0jC1mGGZ8tGcDEzY/ZQ2CYkMQztJihP+5xEPQmwuTaJhGHxBj69gdZbn5X+bO7u6/t MLohZSS6TwH8g== Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) by cascadia.aikidev.net (Postfix) with ESMTPSA id 899D6171C; Wed, 5 Mar 2025 00:58:07 -0800 (PST) From: Vagrant Cascadian To: Hilton Chain Subject: mixup with tmpfs /run patch? Date: Wed, 05 Mar 2025 00:57:38 -0800 Message-ID: <878qpj4zy5.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: 73494@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain I noticed the commit: e88018be70ffb8ea35819a4c95d44ec20868ca59 file-systems: %base-file-systems: Add tmpfs /run. Which was then reverted: 2bb8ecbfbf20efb126670ec92a7cdd88a4805902 Revert "file-systems: %base-file-systems: Add tmpfs /run." ...strangely the patch contained no-suid flags, even though the original patch submitted intentionally did not have this and was explicitly mentioned, as it breaks e.g. /run/privleged-programs/bin/sudo ... +(define %runtime-variable-data + (file-system + (type "tmpfs") + (mount-point "/run") + (device "tmpfs") + (flags '(no-suid no-dev strict-atime)) ^^^^^^^ It might be worth re-testing with the no-suid part removed as originally intended, as it might be breaking other things too... (e.g. if a service relies on setuid bits or something?) I looked forward to tmpfs /run that works! :) live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ8gSAgAKCRDcUY/If5cW qgYUAQD+WDH1fFtyiqPDZZigbSpE+NAyLJjVOCGrDsr1w7VYiQEAoi1H4fPP39Nz rZjmu6S0I7rWQeCOki8a966pL4MtNQc= =WCOe -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 09:07:31 2025 Received: (at 73494) by debbugs.gnu.org; 5 Mar 2025 14:07:31 +0000 Received: from localhost ([127.0.0.1]:36272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tppPG-0006WM-Ot for submit@debbugs.gnu.org; Wed, 05 Mar 2025 09:07:31 -0500 Received: from mx.boiledscript.com ([88.99.243.112]:56464) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tppPD-0006WC-BA for 73494@debbugs.gnu.org; Wed, 05 Mar 2025 09:07:28 -0500 Date: Wed, 05 Mar 2025 22:07:17 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741183645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nOMbFbPn7/iNCuF+10Dvdf3NtszkETma7OMa8v33n68=; b=KF3B21nF7q7bpN1BhCRQq+ASBTMCSgjXZdjXH+yjuEas4Qh/8uY4Z5unBsYSZFrH9wEeQP MH2xWyy8Y73qHwIm1Y2aVsEySiegsz9rW9l6Pkm4304YtepG9r+uf7QTCg6NIW4IW0fqaI Dy4TE9pnXwXUIsN7eQnIoz8xLrQL6sG1nEluyWs4GdxUbvai5uRuzZSCURucJ1Fw5KfN3l ZC2Nuu5N6kx7mwJZZ3abAA2Jp2htQp68eYVkLEjibxqGLWWAYXnpNKpTcNatYKLiKEpY7u +oBzdczDCSr8tNDwQkB9YYREDPKty5nZPlKd/Jp5vtp1gleV+faK5uzmZJQ5pQ== Message-ID: <87frjrtvu2.wl-hako@ultrarare.space> From: Hilton Chain To: Vagrant Cascadian Subject: Re: mixup with tmpfs /run patch? In-Reply-To: <878qpj4zy5.fsf@wireframe> References: <878qpj4zy5.fsf@wireframe> MIME-Version: 1.0 X-MS-Reactions: disallow Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: 73494@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 05 Mar 2025 16:57:38 +0800, Vagrant Cascadian wrote: > > [1 ] > I noticed the commit: > > e88018be70ffb8ea35819a4c95d44ec20868ca59 > file-systems: %base-file-systems: Add tmpfs /run. > > Which was then reverted: > > 2bb8ecbfbf20efb126670ec92a7cdd88a4805902 > Revert "file-systems: %base-file-systems: Add tmpfs /run." > > ...strangely the patch contained no-suid flags, even though the original > patch submitted intentionally did not have this and was explicitly > mentioned, as it breaks e.g. /run/privleged-programs/bin/sudo ... > > +(define %runtime-variable-data > + (file-system > + (type "tmpfs") > + (mount-point "/run") > + (device "tmpfs") > + (flags '(no-suid no-dev strict-atime)) > ^^^^^^^ > > It might be worth re-testing with the no-suid part removed as originally > intended, as it might be breaking other things too... (e.g. if a service > relies on setuid bits or something?) > > > I looked forward to tmpfs /run that works! :) :) I aimed at doing minimum work for this patch series, but we still need to consider what to do next. I have thought about three options: 1. Change all references of /var/run to /run. This will be a lot of work and will force all users who have touched the change to update and reboot. 2. Keep existing references but change new packages / services. We need to ensure new references are consistent for one package otherwise it won't work on systems with separate /var/run and /run (older Guix System and some foreign distros maybe), we can't find such issue easily either after switching to unified /var/run and /run. 3. Don't change references, use what upstream uses. Since we are currently using separate /var/run and /run, we don't have to deal with any issue other than currently encountered ones for finishing this patch series. I think I would go for 3, which requires less to no effort :) and is unlikely to introduce breakage. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 19:15:49 2025 Received: (at 73494) by debbugs.gnu.org; 6 Mar 2025 00:15:49 +0000 Received: from localhost ([127.0.0.1]:40401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpytw-0003eP-Ta for submit@debbugs.gnu.org; Wed, 05 Mar 2025 19:15:49 -0500 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:47297) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tpytu-0003eA-0P for 73494@debbugs.gnu.org; Wed, 05 Mar 2025 19:15:46 -0500 Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-2ff4a4f901fso166070a91.2 for <73494@debbugs.gnu.org>; Wed, 05 Mar 2025 16:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741220139; x=1741824939; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=mZfPAakp6F5Oi4ihOBvmfne6ykCVfXhDe6MisaRwzGk=; b=cP9q1oFS6k8H7GkmH4t91G5021kmy9HCoQbFQk6myMgtdCV8feNaVG4sEIBJO3J2Kb YM8RVS37NtHGoNMBg+Y8twa7avhyEJor1BZrMp60RCdHmVmspKLqSDZLQbuNmYUsC/4U tckVJeXVW93Frc5tgDyjALIlAIdNI3CgGkXVb5bWvxRxbQBEDalVyH2YbMmY+InqvRkI Fkwhn9FoVnaRVXYhJRwcHQo47BjMbiBQOD7YX4LuxkeWQ/ewoVQN4OEg20LqAmO0313N 5bWH0vXaoiJp64d/y20fAUqTlQMjE3mb/jh9mYpeUbZ0lj5QgNvYPQt5gYgN3y9Kigz4 X8+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741220139; x=1741824939; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mZfPAakp6F5Oi4ihOBvmfne6ykCVfXhDe6MisaRwzGk=; b=RzNwFRoSxt2fwNo3qXMR+ubbi21E8dfLp9TlNE0dTSiRpxTZFBxs6DaxYLCnBmMWuZ InrWKN6k6psEmiHrfNQlBrVToEkOdMbxWK1xiHoZOmVvKft/A19igzHg1+f7yyKHxObM yvVT5dPktJHZ8Zwuko/Aaha+T7+cvS2yrZaSN/8rPxSvm6D3yj57m47eUz5Fk8Zoy9wl rAASbKmAPgYwQJQwuphpZ2H32YFWrQ2p1RGx3UdmkuklAG/QHg6ykeO0mY2VvAc1UfGr POX8aMzOh7Ym55GQA0pZVcVytY2meF+4KggrJG/sbwZd5B11oWtAf0M23qx4Z34cs6Jx tonA== X-Forwarded-Encrypted: i=1; AJvYcCU8OG7CbrvRQwbdtmn6NFUmIeWWfVWHKcG0CS1HMBJAuA9xm0zl+htX1HDOPXn8qRhrwVJAaw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy1SD7VYOHRd59fN0kynhow+EnJBBqyI6V++i6EHwzODOorBWhP lw98C+AzmemtboBgpp771zw1mPBoJMxqnQRpa4oOpBhkY4i5nwpD4Z3QLYtpgHE8Nw== X-Gm-Gg: ASbGncstyVgoxpApsy5+NxzsxlwZcXWr4g0VuJ6RUoTlfOZvrg21suBtqGkXOxg0DtA 9NzKxgC+L9nyDV6Foofpv3/s0hSY+IBZVfSFA3wJa90lXuJGVQDflXFCUOxrUpKwpKo6OF6eB7Q nFy816fIBZXahc297O64fUAEwZ2eEGjfAZtY6A4xp/U+MrK3x8ha+xS1SV/mRlBixyUq/SbJMZn eO+rJfm7YBwP0BdxgKyGlJ3Vu3GenF+gnSq47OWVNnNw1Gj1vgV98wLB8FmuirlwOWKeZoOYw12 xOOv0c/yxK8W4OUA+hD6g7JoXA6m6DmnEBykio/2hng= X-Google-Smtp-Source: AGHT+IH2OunKiZFymeK8lU4Wcmw+WARsIwtSwX5bnjtkD9y69Qg71xLsrAYnXml44LPLrbmm7BwyBA== X-Received: by 2002:a17:90b:1a8f:b0:2fe:994d:613b with SMTP id 98e67ed59e1d1-2ff49800110mr8580730a91.35.1741220138633; Wed, 05 Mar 2025 16:15:38 -0800 (PST) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ff4e789392sm1935970a91.28.2025.03.05.16.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 16:15:37 -0800 (PST) From: Maxim Cournoyer To: Hilton Chain Subject: Re: mixup with tmpfs /run patch? In-Reply-To: <87frjrtvu2.wl-hako@ultrarare.space> (Hilton Chain's message of "Wed, 05 Mar 2025 22:07:17 +0800") References: <878qpj4zy5.fsf@wireframe> <87frjrtvu2.wl-hako@ultrarare.space> Date: Thu, 06 Mar 2025 09:15:23 +0900 Message-ID: <875xkn6mlg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Hilton, Hilton Chain writes: [...] >> +(define %runtime-variable-data >> + (file-system >> + (type "tmpfs") >> + (mount-point "/run") >> + (device "tmpfs") >> + (flags '(no-suid no-dev strict-atime)) >> ^^^^^^^ >> >> It might be worth re-testing with the no-suid part removed as originally >> intended, as it might be breaking other things too... (e.g. if a service >> relies on setuid bits or something?) Good call! That was me adding this last minute after inspecting how /run is mounted on a Fedora VM, without giving much thought about our own /run/privileged binaries, ah. >> I looked forward to tmpfs /run that works! :) Me too! > I aimed at doing minimum work for this patch series, but we still need to > consider what to do next. I have thought about three options: > > 1. Change all references of /var/run to /run. > > This will be a lot of work and will force all users who have touched the > change to update and reboot. > > 2. Keep existing references but change new packages / services. > > We need to ensure new references are consistent for one package otherwise it > won't work on systems with separate /var/run and /run (older Guix System and > some foreign distros maybe), we can't find such issue easily either after > switching to unified /var/run and /run. This could be necessary for some containerized services, I think. For example in jami-service-type, "/var/run/jami" is exposed to the container. I'm not sure how file-system-mapping handles that, but I assume it doesn't resolve the link first so wouldn't actually share /run/jami. > 3. Don't change references, use what upstream uses. > > Since we are currently using separate /var/run and /run, we don't have to deal > with any issue other than currently encountered ones for finishing this patch > series. > > I think I would go for 3, which requires less to no effort :) and is unlikely to > introduce breakage. I think 3., doing required minimum to get this working is the better path forward; it's already tricky enough :-). I'll try investigating why 'make check-system TESTS=jami' fails with patch 2/2 of this series. We should run all system tests and see if there are other new failures too. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 21:39:18 2025 Received: (at 73494) by debbugs.gnu.org; 6 Mar 2025 02:39:18 +0000 Received: from localhost ([127.0.0.1]:40582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tq18n-00022i-Vs for submit@debbugs.gnu.org; Wed, 05 Mar 2025 21:39:18 -0500 Received: from mx.boiledscript.com ([88.99.243.112]:37808) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tq18k-00022U-Tt for 73494@debbugs.gnu.org; Wed, 05 Mar 2025 21:39:15 -0500 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741228752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6QMOhbghGWXEI3kdONo6wZ29YMqZ52ZnSScPgdrE2fE=; b=Ijjfse/8WP/C/wYbWcGe2v9SAe3/N0plz4VBcGdXvEl4KYt/GvVqyJE0KBVwIyQRT42SuU 26S81C/UCk86d3CibjjuHh9kJDFNdkjUAMZy9JpZTtkQaP9dcjqFehUz2wKVgAF+ySvGbx 3eclLCvBBqSWgTlUfo9aZloQ5Uj3kRicUsPQGXrYb+zlgpVH21snFUhAjVWvkpffNOIRT4 WJ1A/sHaDe3HxeTF1uCVow7H2CTlFvigd0H/RqG00LP5B5XkUCmVcTXo/LX2chuaPgkQr3 vhnB2zS8W2TXoxrzkg/+yEuI01ErlxlQP+Er9EDXmn+Qfv9bzd1pauBJQnRJuQ== To: 73494@debbugs.gnu.org Subject: [PATCH v2 0/3] tmpfs /run Date: Thu, 6 Mar 2025 10:38:38 +0800 Message-ID: MIME-Version: 1.0 X-MS-Reactions: disallow Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) V1->V2: - use canonicalized source for file-system-mapping->bind-mount. I haven't tested yet but this should address service issues we were facing. - run activation scripts with ‘invoke’. For backtraces and avoid scripts changing the activation environment. Hilton Chain (3): file-systems: %base-file-systems: Add tmpfs /run. services: cleanup: Make /var/run a symlink of /run. services: activation: Continue on exceptions. doc/guix.texi | 8 +++++++ gnu/services.scm | 42 +++++++++++++++++++++++++++---------- gnu/services/dbus.scm | 31 --------------------------- gnu/system/file-systems.scm | 19 +++++++++++++++-- 4 files changed, 56 insertions(+), 44 deletions(-) base-commit: 18e6031f7405b8b9c38255db1957e1eb064d4632 prerequisite-patch-id: d239751bbc956c6055d0a7c7caf8b3bb3ec6a623 -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 21:39:21 2025 Received: (at 73494) by debbugs.gnu.org; 6 Mar 2025 02:39:21 +0000 Received: from localhost ([127.0.0.1]:40585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tq18r-000235-7e for submit@debbugs.gnu.org; Wed, 05 Mar 2025 21:39:21 -0500 Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:37896) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tq18o-00022h-J3 for 73494@debbugs.gnu.org; Wed, 05 Mar 2025 21:39:19 -0500 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741228756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+hYgIql8O1QiQx7epT66Kt9Jlij3iQazqc+pwblRp6c=; b=HKTE9bx+I4p7/ijHXzMBofhOUehlV/j6d9e3C7us2nWM/569hL57QIvKjDs4DGkU16/TPi oi+5c6ZD3FPvkS4CJTZx0adGv/q0Ft0zDSxtn0o0rRXG01XFekEGYskQhSeLsi0X96joi4 5GD2sJZ8I9Ho+OBzzjHpE5IYyFZ/fYB5xML7dMG2Hmh5ARWPbEM1wuPAgvbp4BOPWxCZnS /che0nqoxaldvnqPBs2A+tKlM9gIHhmKLI5yIX22v3o6UkZq/1oblgs2JLKkXIMKHMvFkZ lP4FZh/lrr5vARnzs6EUL1aGVMe+FkrAWqXhfU8pcUXs9J8RN8bX9KkgzPqgfQ== To: 73494@debbugs.gnu.org Subject: [PATCH v2 1/3] file-systems: %base-file-systems: Add tmpfs /run. Date: Thu, 6 Mar 2025 10:38:39 +0800 Message-ID: <54efe155f37a018298290a7816eb56e34dcde838.1741228110.git.hako@ultrarare.space> In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/system/file-systems (%runtime-variable-data): New variable. (%base-file-systems): Add it. * doc/guix.texi (File Systems): Document it. * gnu/services.scm (cleanup-gexp): Adjust accordingly. Change-Id: I3a95e49d396fbb2577026aefc247cfe996c5f267 Modified-by: Maxim Cournoyer --- doc/guix.texi | 5 +++++ gnu/services.scm | 5 +---- gnu/system/file-systems.scm | 17 ++++++++++++++++- 3 files changed, 22 insertions(+), 5 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 6844470ce2..70e5db4156 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18228,6 +18228,11 @@ File Systems read-write in its own ``name space.'' @end defvar +@defvar %runtime-variable-data +This file system is mounted as @file{/run} and contains system +information data describing the system since it was booted. +@end defvar + @defvar %binary-format-file-system The @code{binfmt_misc} file system, which allows handling of arbitrary executable file types to be delegated to user space. This requires the diff --git a/gnu/services.scm b/gnu/services.scm index 8a4002e072..ea855ad193 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -632,7 +632,7 @@ (define (cleanup-gexp _) #~(begin (use-modules (guix build utils)) - ;; Clean out /tmp, /var/run, and /run. + ;; Clean out /tmp and /var/run. ;; ;; XXX This needs to happen before service activations, so it ;; has to be here, but this also implicitly assumes that /tmp @@ -663,15 +663,12 @@ (define (cleanup-gexp _) (setlocale LC_CTYPE "en_US.utf8") (delete-file-recursively "/tmp") (delete-file-recursively "/var/run") - (delete-file-recursively "/run") ;; Note: The second argument to 'mkdir' is and'ed with umask, ;; hence the 'chmod' calls. (mkdir "/tmp" #o1777) (chmod "/tmp" #o1777) (mkdir "/var/run" #o755) - (chmod "/var/run" #o755) - (mkdir "/run" #o755) (chmod "/var/run" #o755)))))) (define cleanup-service-type diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 4ea8237c70..b2766707a3 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -82,6 +82,7 @@ (define-module (gnu system file-systems) %pseudo-terminal-file-system %tty-gid %immutable-store + %runtime-variable-data %control-groups %elogind-file-systems @@ -448,6 +449,19 @@ (define %immutable-store (check? #f) (flags '(read-only bind-mount no-atime)))) +(define %runtime-variable-data + (file-system + (type "tmpfs") + (mount-point "/run") + (device "tmpfs") + ;; Don't use no-suid here as /run/privileged/bin may contain SUID + ;; executables. + (flags '(no-dev strict-atime)) + (options "mode=0755,nr_inodes=800k,size=20%") + (needed-for-boot? #t) + (check? #f) + (create-mount-point? #t))) + (define %control-groups ;; The cgroup2 file system. (list (file-system @@ -497,7 +511,8 @@ (define %base-file-systems %debug-file-system %shared-memory-file-system %efivars-file-system - %immutable-store)) + %immutable-store + %runtime-variable-data)) (define %base-live-file-systems ;; This is the bare minimum to use live file-systems. -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 21:39:24 2025 Received: (at 73494) by debbugs.gnu.org; 6 Mar 2025 02:39:24 +0000 Received: from localhost ([127.0.0.1]:40588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tq18t-00023L-Qt for submit@debbugs.gnu.org; Wed, 05 Mar 2025 21:39:24 -0500 Received: from mx.boiledscript.com ([88.99.243.112]:37814) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tq18r-00022z-BH for 73494@debbugs.gnu.org; Wed, 05 Mar 2025 21:39:21 -0500 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741228759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F4AfId5d2Y9z2u4YgwOqrdZZLaNSI6q68+8WMmQUl5M=; b=YARPLnlAoGe6/5Ye8aBFYPqkr3dZ6oZ8AFFqsNL7a9uhkBKr8zw9g89rnC6AbRE2M9YFPV FQKjKITiOfN9SmCwzKFuEGKqRJXAOianw2uYRJGhtN+OueJfNSZOA5ZrVHCtL1ng+XkSJk 9jOFqMipiKNlKUnAaeeiMuCok89Jle+RO7Tx3Jk/4icpVcE6KR+dVK+I0aKtlXQNYL3877 ZEp6d4lESlBcxvZtLR2TnuuYyQX66PO1mnuP8SRLMqQaqNKpxQH/ffHxBS90zozRQyYPk9 pnoUoaw+G1Hn5+5Z/rxEb8GHX/XcNHhP+fb9OEgi+JwB/TuIOhWe/qmQUKzspA== To: 73494@debbugs.gnu.org Subject: [PATCH v2 2/3] services: cleanup: Make /var/run a symlink of /run. Date: Thu, 6 Mar 2025 10:38:40 +0800 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services.scm (cleanup-gexp): Make /var/run a symlink of /run. * doc/guix.texi (File Systems): Document it. * gnu/system/file-systems.scm (file-system-mapping->bind-mount): Use canonicalized source path. * gnu/services/dbus.scm (dbus-activation): Adjust accordingly. Change-Id: I7b94d3e2fe1bef66f435e84bc77f32311dddd0ce --- doc/guix.texi | 3 +++ gnu/services.scm | 5 +++-- gnu/services/dbus.scm | 31 ------------------------------- gnu/system/file-systems.scm | 2 +- 4 files changed, 7 insertions(+), 34 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 70e5db4156..3cec887591 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18231,6 +18231,9 @@ File Systems @defvar %runtime-variable-data This file system is mounted as @file{/run} and contains system information data describing the system since it was booted. + +Additionally, another directory with same role, @file{/var/run}, is +implemented as a symlink to @file{/run}. @end defvar @defvar %binary-format-file-system diff --git a/gnu/services.scm b/gnu/services.scm index ea855ad193..7805cae971 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -668,8 +668,9 @@ (define (cleanup-gexp _) ;; hence the 'chmod' calls. (mkdir "/tmp" #o1777) (chmod "/tmp" #o1777) - (mkdir "/var/run" #o755) - (chmod "/var/run" #o755)))))) + ;; /run is implemented as tmpfs mounted at early boot. + (mkdir-p "/var") + (symlink "/run" "/var/run")))))) (define cleanup-service-type ;; Service that cleans things up in /tmp and similar. diff --git a/gnu/services/dbus.scm b/gnu/services/dbus.scm index 76e04bf221..9292172e01 100644 --- a/gnu/services/dbus.scm +++ b/gnu/services/dbus.scm @@ -190,37 +190,6 @@ (define (dbus-activation config) ;; world-readable. (mkdir-p/perms "/run/dbus" user #o755)) - (catch 'system-error - (lambda () - (symlink "/run/dbus" "/var/run/dbus")) - (lambda args - (let ((errno (system-error-errno args))) - (cond - ((= errno EEXIST) - (let ((existing-name - (false-if-exception - (readlink "/var/run/dbus")))) - (unless (equal? existing-name "/run/dbus") - ;; Move the content of /var/run/dbus to /run/dbus, and - ;; retry. - (let ((dir (opendir "/var/run/dbus"))) - (let loop ((next (readdir dir))) - (cond - ((eof-object? next) (closedir dir)) - ((member next '("." "..")) (loop (readdir dir))) - (else - (begin - (rename-file (string-append "/var/run/dbus/" next) - (string-append "/run/dbus/" next)) - (loop (readdir dir))))))) - (rmdir "/var/run/dbus") - (symlink "/run/dbus" "/var/run/dbus")))) - (else - (format (current-error-port) - "Failed to symlink /run/dbus to /var/run/dbus: ~s~%" - (strerror errno)) - (error "cannot create /var/run/dbus")))))) - (unless (file-exists? "/etc/machine-id") (format #t "creating /etc/machine-id...~%") (invoke (string-append #$(dbus-configuration-dbus config) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index b2766707a3..8b11489968 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -594,7 +594,7 @@ (define (file-system-mapping->bind-mount mapping) (($ source target writable?) (file-system (mount-point target) - (device source) + (device (canonicalize-path source)) (type "none") (flags (if writable? '(bind-mount) -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 21:39:26 2025 Received: (at 73494) by debbugs.gnu.org; 6 Mar 2025 02:39:26 +0000 Received: from localhost ([127.0.0.1]:40591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tq18w-00023b-D5 for submit@debbugs.gnu.org; Wed, 05 Mar 2025 21:39:26 -0500 Received: from mx.boiledscript.com ([88.99.243.112]:39496) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tq18u-00023K-EH for 73494@debbugs.gnu.org; Wed, 05 Mar 2025 21:39:24 -0500 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741228763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P3mvAwJunBrnjKMclNXpGdabxdtITDWXuNcI0K+g+OU=; b=WH+5rXXknsSPkeuJQNmIgiDXVnTCzZgZAEItkXkvueCHllAKhK0IgaYOy1Aa2pfwCrG016 FE2sxAuwsNzm+kCJmXQbcymHcK6vmEWERcn/JVQ5SJZegGdKhwma90amnJLUIi2KFMYdYs PMsC1wLg/v/IAfY3prHgxY6RSNaptgrZkFLXlpTPvUxIClt9JBg+KBlub9z5ohjKIFr1Kb 4uIg7m77p8dk3a1aDOZZ6azvV1DUkWbZpygWUJ9AmBg7Fx9xiFTE3aFUDvmq4Hjd4hgUSi mpdgOm2v825IW4KCLRwY5ALlP6msjXkjFFOcm/9pDWKMIRgtWfpb62lG4q/74g== To: 73494@debbugs.gnu.org Subject: [PATCH v2 3/3] services: activation: Continue on exceptions. Date: Thu, 6 Mar 2025 10:38:41 +0800 Message-ID: <317ca0d525d3f2c668a9ec2c5357b3ca924ee1a7.1741228110.git.hako@ultrarare.space> In-Reply-To: References: MIME-Version: 1.0 X-MS-Reactions: disallow Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Use ‘invoke’ for backtraces and avoid changing environment. * gnu/services.scm (activation-script): Execute activation scripts in ‘invoke’. Warn about failed activation scripts. Change-Id: I89be31433fbb46d0c4a9dc6115ab167910840b6f --- gnu/services.scm | 32 +++++++++++++++++++++++++++----- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/gnu/services.scm b/gnu/services.scm index 7805cae971..3a511a42e5 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -690,15 +690,28 @@ (define* (activation-service->script service) (define (activation-script gexps) "Return the system's activation script, which evaluates GEXPS." (define actions - (map (cut program-file "activate-service.scm" <>) gexps)) + (map (lambda (action) + (program-file "activate-service.scm" + (with-imported-modules (source-module-closure + '((gnu build activation) + (guix build utils))) + #~(begin + (use-modules (gnu build activation) + (guix build utils)) + #$action)))) + gexps)) (program-file "activate.scm" (with-imported-modules (source-module-closure '((gnu build activation) - (guix build utils))) + (guix build utils) + (guix diagnostics) + (guix i18n))) #~(begin (use-modules (gnu build activation) - (guix build utils)) + (guix build utils) + (guix diagnostics) + (guix i18n)) (mkdir-p "/var/run") ;; Make sure the user accounting database exists. If it @@ -717,8 +730,17 @@ (define (activation-script gexps) (activate-current-system) ;; Run the services' activation snippets. - ;; TODO: Use 'load-compiled'. - (for-each primitive-load '#$actions))))) + (for-each (lambda (action) + ;; Don't block activation process when one + ;; action fails. + (catch #t + (lambda () + (invoke action)) + (lambda _ + (warning + (G_ "failed to activate '~a'.~%") + action)))) + '#$actions))))) (define (gexps->activation-gexp gexps) "Return a gexp that runs the activation script containing GEXPS." -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 06 01:23:20 2025 Received: (at 73494) by debbugs.gnu.org; 6 Mar 2025 06:23:20 +0000 Received: from localhost ([127.0.0.1]:41005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tq4dc-0002b6-5f for submit@debbugs.gnu.org; Thu, 06 Mar 2025 01:23:20 -0500 Received: from mx.boiledscript.com ([88.99.243.112]:57720) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tq4dZ-0002av-10 for 73494@debbugs.gnu.org; Thu, 06 Mar 2025 01:23:18 -0500 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741242195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7UVe/F6XQFKaBcwvplnLvV1vNrzMxCT1uzXlQrvP4A0=; b=j4NO79eN7ljD7j2cdcfbgwWdQB8B3fMGLzRLdJf6gzbo9Y1otcL+HCYP0XYNF0OExYzbaJ ChkDhJvRu0mAQcv4bmE2qcDaJurtW6l5WA/YR4EBwFQCi47ZaaiRRmK7vSuBhJXdmItGcp R7XkR4lrvIqxH+00OVTub8wIwBiIlBkDfzcDIvecczrsJaabQ6H4mZoK/Tqi18PLO2ikjH ZuhfJaTS13h4yY58yjIPyLHAtM10T2lSDsf4s43tNIbiWFB2Khn/eu/KaZ+Ge7DU6hd5IS fSo+0iPHGIXIGre8RWUARJtNoGQVEn6ahQC97C83zO5C9ORPfg8o3siRxH8sVQ== To: 73494@debbugs.gnu.org Subject: [PATCH v3 0/3] tmpfs /run Date: Thu, 6 Mar 2025 14:22:41 +0800 Message-ID: MIME-Version: 1.0 X-MS-Reactions: disallow Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) V2 -> V3: For file-system-mapping->bind-mount, drop the first 4 characters in source when it's a string starting with "/var/run", instead of using canonicalized source (as in V2), since the source can't be ensured to exist at evaluation time. Hilton Chain (3): file-systems: %base-file-systems: Add tmpfs /run. services: cleanup: Make /var/run a symlink of /run. services: activation: Continue on exceptions. doc/guix.texi | 8 +++++++ gnu/services.scm | 42 +++++++++++++++++++++++++++---------- gnu/services/dbus.scm | 31 --------------------------- gnu/system/file-systems.scm | 24 +++++++++++++++++++-- 4 files changed, 61 insertions(+), 44 deletions(-) base-commit: 18e6031f7405b8b9c38255db1957e1eb064d4632 prerequisite-patch-id: d239751bbc956c6055d0a7c7caf8b3bb3ec6a623 -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 06 01:23:24 2025 Received: (at 73494) by debbugs.gnu.org; 6 Mar 2025 06:23:24 +0000 Received: from localhost ([127.0.0.1]:41008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tq4df-0002bO-IX for submit@debbugs.gnu.org; Thu, 06 Mar 2025 01:23:24 -0500 Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:59382) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tq4dd-0002b5-KB for 73494@debbugs.gnu.org; Thu, 06 Mar 2025 01:23:22 -0500 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741242199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+hYgIql8O1QiQx7epT66Kt9Jlij3iQazqc+pwblRp6c=; b=iKmj5SQ8dgbEnoJV0kEcYd62HeBq9mjLQb8IvH8ub+92VRiQ2mCbGmp8/D2+Oaeuc+/XBn buX9AXL1CP0FBc8OXuoe78iVBF3nigrYaHQ9ZrCc88mJwvtNyPbfQUXlWSqjZCSRAjVtbZ k3R/MjBKKTepLSq6zGUGC2DhV4uYMqjl9pXUZ+eZauuIG7ZrPWXYfYlvQKlfeY7k0vG8i3 xvur2zT2s4EUn3PyR/H9R4sXUgWbCTayJwEIe8qJ5yxR6sndglkRq6rD8BKd55vQT8XukY aqqiyOEj6bL9baO0nusu+GGe6K5/kYggiAjM7M1R6INdb+opPCGhUgzS5RMGfA== To: 73494@debbugs.gnu.org Subject: [PATCH v3 1/3] file-systems: %base-file-systems: Add tmpfs /run. Date: Thu, 6 Mar 2025 14:22:42 +0800 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/system/file-systems (%runtime-variable-data): New variable. (%base-file-systems): Add it. * doc/guix.texi (File Systems): Document it. * gnu/services.scm (cleanup-gexp): Adjust accordingly. Change-Id: I3a95e49d396fbb2577026aefc247cfe996c5f267 Modified-by: Maxim Cournoyer --- doc/guix.texi | 5 +++++ gnu/services.scm | 5 +---- gnu/system/file-systems.scm | 17 ++++++++++++++++- 3 files changed, 22 insertions(+), 5 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 6844470ce2..70e5db4156 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18228,6 +18228,11 @@ File Systems read-write in its own ``name space.'' @end defvar +@defvar %runtime-variable-data +This file system is mounted as @file{/run} and contains system +information data describing the system since it was booted. +@end defvar + @defvar %binary-format-file-system The @code{binfmt_misc} file system, which allows handling of arbitrary executable file types to be delegated to user space. This requires the diff --git a/gnu/services.scm b/gnu/services.scm index 8a4002e072..ea855ad193 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -632,7 +632,7 @@ (define (cleanup-gexp _) #~(begin (use-modules (guix build utils)) - ;; Clean out /tmp, /var/run, and /run. + ;; Clean out /tmp and /var/run. ;; ;; XXX This needs to happen before service activations, so it ;; has to be here, but this also implicitly assumes that /tmp @@ -663,15 +663,12 @@ (define (cleanup-gexp _) (setlocale LC_CTYPE "en_US.utf8") (delete-file-recursively "/tmp") (delete-file-recursively "/var/run") - (delete-file-recursively "/run") ;; Note: The second argument to 'mkdir' is and'ed with umask, ;; hence the 'chmod' calls. (mkdir "/tmp" #o1777) (chmod "/tmp" #o1777) (mkdir "/var/run" #o755) - (chmod "/var/run" #o755) - (mkdir "/run" #o755) (chmod "/var/run" #o755)))))) (define cleanup-service-type diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 4ea8237c70..b2766707a3 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -82,6 +82,7 @@ (define-module (gnu system file-systems) %pseudo-terminal-file-system %tty-gid %immutable-store + %runtime-variable-data %control-groups %elogind-file-systems @@ -448,6 +449,19 @@ (define %immutable-store (check? #f) (flags '(read-only bind-mount no-atime)))) +(define %runtime-variable-data + (file-system + (type "tmpfs") + (mount-point "/run") + (device "tmpfs") + ;; Don't use no-suid here as /run/privileged/bin may contain SUID + ;; executables. + (flags '(no-dev strict-atime)) + (options "mode=0755,nr_inodes=800k,size=20%") + (needed-for-boot? #t) + (check? #f) + (create-mount-point? #t))) + (define %control-groups ;; The cgroup2 file system. (list (file-system @@ -497,7 +511,8 @@ (define %base-file-systems %debug-file-system %shared-memory-file-system %efivars-file-system - %immutable-store)) + %immutable-store + %runtime-variable-data)) (define %base-live-file-systems ;; This is the bare minimum to use live file-systems. -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 06 01:23:27 2025 Received: (at 73494) by debbugs.gnu.org; 6 Mar 2025 06:23:27 +0000 Received: from localhost ([127.0.0.1]:41011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tq4dj-0002bf-6Z for submit@debbugs.gnu.org; Thu, 06 Mar 2025 01:23:27 -0500 Received: from mx.boiledscript.com ([88.99.243.112]:37248) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tq4df-0002bM-Qh for 73494@debbugs.gnu.org; Thu, 06 Mar 2025 01:23:24 -0500 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741242202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wM8I+shtBwD47dxcxMU2gngWqYsqlrGUfiNhO6FIccQ=; b=Q+TbHfb980gIg/Vh0N+Qvb9gJmLKTNtOaZLrsiN6ZY/GRvQ/OHGgsFWddrczyKNPM/c9Gy YRdMsNUzNqagL2zWEpzDp6Y7PUrhL2G7muh1AAX1XRxkKtxsP+VtS5xMEGqQiLeMmb1UFA nxjR9m2CFGbVZCEK6AXi2q3Bj2fir/+dNTqhcJGoGRVx8Ipgcci/imnvM5hlJLdUzDL7CU e7uYALbPjl9Owi28YTC/UdnBiteH1b5sd5/Hghl46qj4ghmNifWLuxc/tD04Zu7VLkmuCV xZWy2BNp3fbqgIZYLQt+jEpqnyC7BNGkkfWHU/rbua0DY5scLymIXkaVmbFHpg== To: 73494@debbugs.gnu.org Subject: [PATCH v3 2/3] services: cleanup: Make /var/run a symlink of /run. Date: Thu, 6 Mar 2025 14:22:43 +0800 Message-ID: <830b6fd522e9fc0e5c0008560dd9877c44d18d35.1741241800.git.hako@ultrarare.space> In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services.scm (cleanup-gexp): Make /var/run a symlink of /run. * doc/guix.texi (File Systems): Document it. * gnu/system/file-systems.scm (file-system-mapping->bind-mount): Replace /var/run in source path with /run. * gnu/services/dbus.scm (dbus-activation): Adjust accordingly. Change-Id: I7b94d3e2fe1bef66f435e84bc77f32311dddd0ce --- doc/guix.texi | 3 +++ gnu/services.scm | 5 +++-- gnu/services/dbus.scm | 31 ------------------------------- gnu/system/file-systems.scm | 7 ++++++- 4 files changed, 12 insertions(+), 34 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 70e5db4156..3cec887591 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18231,6 +18231,9 @@ File Systems @defvar %runtime-variable-data This file system is mounted as @file{/run} and contains system information data describing the system since it was booted. + +Additionally, another directory with same role, @file{/var/run}, is +implemented as a symlink to @file{/run}. @end defvar @defvar %binary-format-file-system diff --git a/gnu/services.scm b/gnu/services.scm index ea855ad193..7805cae971 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -668,8 +668,9 @@ (define (cleanup-gexp _) ;; hence the 'chmod' calls. (mkdir "/tmp" #o1777) (chmod "/tmp" #o1777) - (mkdir "/var/run" #o755) - (chmod "/var/run" #o755)))))) + ;; /run is implemented as tmpfs mounted at early boot. + (mkdir-p "/var") + (symlink "/run" "/var/run")))))) (define cleanup-service-type ;; Service that cleans things up in /tmp and similar. diff --git a/gnu/services/dbus.scm b/gnu/services/dbus.scm index 76e04bf221..9292172e01 100644 --- a/gnu/services/dbus.scm +++ b/gnu/services/dbus.scm @@ -190,37 +190,6 @@ (define (dbus-activation config) ;; world-readable. (mkdir-p/perms "/run/dbus" user #o755)) - (catch 'system-error - (lambda () - (symlink "/run/dbus" "/var/run/dbus")) - (lambda args - (let ((errno (system-error-errno args))) - (cond - ((= errno EEXIST) - (let ((existing-name - (false-if-exception - (readlink "/var/run/dbus")))) - (unless (equal? existing-name "/run/dbus") - ;; Move the content of /var/run/dbus to /run/dbus, and - ;; retry. - (let ((dir (opendir "/var/run/dbus"))) - (let loop ((next (readdir dir))) - (cond - ((eof-object? next) (closedir dir)) - ((member next '("." "..")) (loop (readdir dir))) - (else - (begin - (rename-file (string-append "/var/run/dbus/" next) - (string-append "/run/dbus/" next)) - (loop (readdir dir))))))) - (rmdir "/var/run/dbus") - (symlink "/run/dbus" "/var/run/dbus")))) - (else - (format (current-error-port) - "Failed to symlink /run/dbus to /var/run/dbus: ~s~%" - (strerror errno)) - (error "cannot create /var/run/dbus")))))) - (unless (file-exists? "/etc/machine-id") (format #t "creating /etc/machine-id...~%") (invoke (string-append #$(dbus-configuration-dbus config) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index b2766707a3..697fcf4f82 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -594,7 +594,12 @@ (define (file-system-mapping->bind-mount mapping) (($ source target writable?) (file-system (mount-point target) - (device source) + (device + ;; /var/run is implemented as a symlink to /run. + (if (and (string? source) + (string-prefix? "/var/run" source)) + (string-drop source 4) + source)) (type "none") (flags (if writable? '(bind-mount) -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 06 01:23:30 2025 Received: (at 73494) by debbugs.gnu.org; 6 Mar 2025 06:23:30 +0000 Received: from localhost ([127.0.0.1]:41014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tq4dl-0002bt-PJ for submit@debbugs.gnu.org; Thu, 06 Mar 2025 01:23:30 -0500 Received: from mx.boiledscript.com ([88.99.243.112]:37260) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tq4dj-0002be-Ek for 73494@debbugs.gnu.org; Thu, 06 Mar 2025 01:23:27 -0500 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741242206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P3mvAwJunBrnjKMclNXpGdabxdtITDWXuNcI0K+g+OU=; b=BThbFg9yZy7AcZzQA1sYsEl1g5zZo1xJ5sLa5UnK2jCPK8KTmvKchWbz6o7pklQhK99iAF NsMdV4dnZbMdsa6PTApWrs+9iUc8a3F+qwo7BBpqqmUaAi+pSMes47G/paIS4Nk27DT5W5 0I6y2BwDGzZJRzG6ij2CE3/rdZn77klOOQWrqfW/GkfQH7bYgu/SFzPDERD2194gpUtZZg vetrmjBwOdmWjOLENpOL4wIA8lORrqH0JNHlmFruk/9thYSLl/ohfQ8nTrdFUq+22uDCTW hW1mihqbytj//2+nvw5NkzqDICC6WfNirVQD8W5uqgUieTYy8jWg8cVVCuZ+SA== To: 73494@debbugs.gnu.org Subject: [PATCH v3 3/3] services: activation: Continue on exceptions. Date: Thu, 6 Mar 2025 14:22:44 +0800 Message-ID: <18ba6d18420c9ac93dcdab6b349e1050d6ca3a6a.1741241800.git.hako@ultrarare.space> In-Reply-To: References: MIME-Version: 1.0 X-MS-Reactions: disallow Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Use ‘invoke’ for backtraces and avoid changing environment. * gnu/services.scm (activation-script): Execute activation scripts in ‘invoke’. Warn about failed activation scripts. Change-Id: I89be31433fbb46d0c4a9dc6115ab167910840b6f --- gnu/services.scm | 32 +++++++++++++++++++++++++++----- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/gnu/services.scm b/gnu/services.scm index 7805cae971..3a511a42e5 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -690,15 +690,28 @@ (define* (activation-service->script service) (define (activation-script gexps) "Return the system's activation script, which evaluates GEXPS." (define actions - (map (cut program-file "activate-service.scm" <>) gexps)) + (map (lambda (action) + (program-file "activate-service.scm" + (with-imported-modules (source-module-closure + '((gnu build activation) + (guix build utils))) + #~(begin + (use-modules (gnu build activation) + (guix build utils)) + #$action)))) + gexps)) (program-file "activate.scm" (with-imported-modules (source-module-closure '((gnu build activation) - (guix build utils))) + (guix build utils) + (guix diagnostics) + (guix i18n))) #~(begin (use-modules (gnu build activation) - (guix build utils)) + (guix build utils) + (guix diagnostics) + (guix i18n)) (mkdir-p "/var/run") ;; Make sure the user accounting database exists. If it @@ -717,8 +730,17 @@ (define (activation-script gexps) (activate-current-system) ;; Run the services' activation snippets. - ;; TODO: Use 'load-compiled'. - (for-each primitive-load '#$actions))))) + (for-each (lambda (action) + ;; Don't block activation process when one + ;; action fails. + (catch #t + (lambda () + (invoke action)) + (lambda _ + (warning + (G_ "failed to activate '~a'.~%") + action)))) + '#$actions))))) (define (gexps->activation-gexp gexps) "Return a gexp that runs the activation script containing GEXPS." -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 09 03:35:23 2025 Received: (at 73494) by debbugs.gnu.org; 9 Mar 2025 07:35:23 +0000 Received: from localhost ([127.0.0.1]:58000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trBBy-0004cL-P5 for submit@debbugs.gnu.org; Sun, 09 Mar 2025 03:35:23 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:46566) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1trBBv-0004c1-5X for 73494@debbugs.gnu.org; Sun, 09 Mar 2025 03:35:20 -0400 Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-2ff784dc055so3860812a91.1 for <73494@debbugs.gnu.org>; Sat, 08 Mar 2025 23:35:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741505713; x=1742110513; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=cDF34lGM13FyGz+kBBI2YwTqVpVaSp0AfW/IvrOCbK4=; b=dwI8HEjPVerMKcQmsK8rKFpZ2doGmgLZAxzBc8uzZGUfg7YtL18YfY8squyhKXfIzE 9bHJ9BgmQSL5EwJwX6gyJ18JDn3b9Xh4cvY5MatLAkHiUQs2cRi2pECu7IxCgfywnQJV 71F1Vml1LIyC35Na+QLUS3rR0mbtYR0Fs+Kpsv5AmpriDnz7N/GjIZWkiWSnWEYsWees VEh1yNM0gormAb8BW2BZdLK/jFysgCVda6QjD0tQkXPPbwqQzXiyOw+IAUxrOxIYXS5Y P0OE25q8UzmfLgi58TkzaoR/ScJyLl2xYUPfAKPbzuUVd7HhC2AZPM4CsxhSh5CkD0sa k/ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741505713; x=1742110513; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cDF34lGM13FyGz+kBBI2YwTqVpVaSp0AfW/IvrOCbK4=; b=MnDWNugadV1SOoRsKuopaUaAR6nBmVawT8NArTVzeUPtRV/nU+epnKZslYSM5hlyHN 3GpDLed3DS1Qi8ihX0bDoeRXzHBFbxC3ipPbGFtHVmE93+iI+FyHL04uxm/JVcp1A67c g8rJXRM7ZHMhKTjcyE1qaFG7a8NooE8LtpyC5TKs3qMIkU8rjYetoup51jf6xvvhK67k tG3t+MZOxdpibkOBKVUBy8JzcUR7tQaAyCfQIWpKUwfEfyX55UBhH3r48a0PX40kDDiF ECGHQY4csCx3TrgoL05b4uuQ3NIv26fBUXpvf5aTiyP/TaVXozaviIoOst9nTaPshXyE Baag== X-Gm-Message-State: AOJu0Yzl2iNEOOKJqWtHhV0mJK3WAOkySW6WRY2EGcQzC22fF6dovw8x d5g9kVuDXm7Ptuc0UaafceE/i52vRXwiTzp4qHGxCUnbamQEAgux X-Gm-Gg: ASbGnctsfigqAdMLIx6zL1OxLHjMKveG6QHPNmMfl99mW5jGePASaSNiQrfZ90vM0yq TM2w1+ZY2bqA5S10pP1IbuOtO8BwMq9UxTBk6oa/7G07ocOvUPHcHqbH1pkFf5t3MVDuNL6iD/M rdkdcAeymR34/gYzBPN74ja69qpiluTl57xjWQUT9yofcP+jaEtLBDdBobiG501/xEiuK2g5sUi zYfh+dZWQoy5fgwitjUjUG9AatDb4rVyg82YJclHG0AGXNvFZfQ6gmJalMeJk9BZAnj7kKRLqeQ gpLovEU6XSjH0d/hMe5f4CO+s1iOm5D7gw1bJf3hkSU= X-Google-Smtp-Source: AGHT+IGkM9ncHvfu5pIhJk6RrvD3EjX4Kn0myEfdpaDNVge2LyQCfjHDwXHOXV41D3kstRepJolXZg== X-Received: by 2002:a17:90a:e7c2:b0:2ee:aed2:c15c with SMTP id 98e67ed59e1d1-2ff7cef5ce5mr14283698a91.28.1741505712803; Sat, 08 Mar 2025 23:35:12 -0800 (PST) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ff4e789311sm7648566a91.27.2025.03.08.23.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Mar 2025 23:35:12 -0800 (PST) From: Maxim Cournoyer To: Hilton Chain Subject: Re: [bug#73494] [PATCH v3 0/3] tmpfs /run In-Reply-To: (Hilton Chain's message of "Thu, 6 Mar 2025 14:22:41 +0800") References: Date: Sun, 09 Mar 2025 16:34:58 +0900 Message-ID: <8734fmu065.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Hilton Chain writes: > V2 -> V3: > > For file-system-mapping->bind-mount, drop the first 4 characters in source > when it's a string starting with "/var/run", instead of using canonicalized > source (as in V2), since the source can't be ensured to exist at evaluation > time. > > Hilton Chain (3): > file-systems: %base-file-systems: Add tmpfs /run. This one looks good to me. > services: cleanup: Make /var/run a symlink of /run. This still has the jami system test failing (make check-system TESTS=jami). This must be resolved before we can merge this. > services: activation: Continue on exceptions. I like it, but I think you can't use the i18n or diagnostics user-facing modules on the build side, as their closure is too big to be reasonably imported. Most modules intended to be used on the builder side are namespaced under (guix build ...), but there are a few excptions. I'll try to understand the jami test failure, but my last experiments were not successful. Help welcome. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 12 22:28:07 2025 Received: (at 73494) by debbugs.gnu.org; 13 Mar 2025 02:28:07 +0000 Received: from localhost ([127.0.0.1]:52546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsYIo-0003ip-PV for submit@debbugs.gnu.org; Wed, 12 Mar 2025 22:28:07 -0400 Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:40660) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsYIm-0003ie-68 for 73494@debbugs.gnu.org; Wed, 12 Mar 2025 22:28:04 -0400 Date: Thu, 13 Mar 2025 10:06:35 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741832881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wXS5EWZWV44qePj3YyFnqY8eBwwiLsOe1Grt9uLj4T4=; b=EpmcBUWCPBrujpZ2GBhUa9hbWdsPIvhCr4iD6omrJhMtScpdwDEnPBvKagIWUMorn4DUKn gO1Vy8szgivkJla845csKsAvon94EsInjSbkoLGn4e6e6Qb5aZQG8FGPXe3LOjUSRWEMCs se9KQXdoJ0p9SZ/5JfsOo38u6SMOne2MfGHD4jEOKRYW01PDpyNkmMZUQ+FT1evzhgI1bb tJuILzrNsS1WlwM+7v5rG5606CRq0413tREoAFFPYwFCj8alJUDjGHVxoGUEbpnrVQXCvQ YiOWPK0MST1COsUHJtjae+UNVGhAmzeCyN2MABC+B9rr8hfbflsUh4Zgp7bp0w== Message-ID: <874izxit04.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH v3 0/3] tmpfs /run In-Reply-To: <8734fmu065.fsf@gmail.com> References: <8734fmu065.fsf@gmail.com> MIME-Version: 1.0 X-MS-Reactions: disallow Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Ludovic =?ISO-8859-1?Q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, 09 Mar 2025 15:34:58 +0800, Maxim Cournoyer wrote: > > Hi, > > Hilton Chain writes: > > > V2 -> V3: > > > > For file-system-mapping->bind-mount, drop the first 4 characters in source > > when it's a string starting with "/var/run", instead of using canonicalized > > source (as in V2), since the source can't be ensured to exist at evaluation > > time. > > > > Hilton Chain (3): > > file-systems: %base-file-systems: Add tmpfs /run. > > This one looks good to me. > > > services: cleanup: Make /var/run a symlink of /run. > > This still has the jami system test failing (make check-system > TESTS=jami). This must be resolved before we can merge this. > > > services: activation: Continue on exceptions. > > I like it, but I think you can't use the i18n or diagnostics user-facing > modules on the build side, as their closure is too big to be reasonably > imported. Most modules intended to be used on the builder side are > namespaced under (guix build ...), but there are a few excptions. Just checked, these two modules are already inside (gnu build activation)'s closure. > I'll try to understand the jami test failure, but my last experiments > were not successful. Help welcome. Did your have a luck with the dbus change you mentioned on IRC? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 08:21:29 2025 Received: (at 73494) by debbugs.gnu.org; 13 Mar 2025 12:21:29 +0000 Received: from localhost ([127.0.0.1]:54054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tshZ2-0004rV-S0 for submit@debbugs.gnu.org; Thu, 13 Mar 2025 08:21:29 -0400 Received: from mx.boiledscript.com ([88.99.243.112]:55662) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tshZ0-0004rL-A4 for 73494@debbugs.gnu.org; Thu, 13 Mar 2025 08:21:26 -0400 Date: Thu, 13 Mar 2025 20:18:57 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741868484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uoVGOUxCz7w9oYUNBTKk5/PHLB7DQdC31iFbQwP9vJo=; b=Hf3xqDgguEH4jFN5hIi9QaGtsEkkju76SZd818fmvKQFoXX3WAiPQ1fkWCizQdKmzOiNxq mRJtttEgQW8uA6eyeL4lt0U4z391GiY5RvFoX1dsDeukYexlEHzAbBThb7niYBrHvfFegT AHxWg+rlDz2OXrGY3FvDz8NiPjIHJmZ85tZoJtTAsO7AKNE6NN2IzejVSHtZoXT2nMtRox 7dFg/e4QgdnNBaXOSgIra5Ua6IMMV7iGnS8In1zhCSzsOUjAduy87kY4vG4ThCMzsuLGHP 8I+DGW52zA05klZxSyNK4sKPlnbQi7mWFxiR4+Hvmy7EJdILXgE+/vhosa+1ig== Message-ID: <87msdp6s3y.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH v3 0/3] tmpfs /run In-Reply-To: <874izxit04.wl-hako@ultrarare.space> References: <8734fmu065.fsf@gmail.com> <874izxit04.wl-hako@ultrarare.space> MIME-Version: 1.0 X-MS-Reactions: disallow Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Ludovic =?ISO-8859-1?Q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 13 Mar 2025 10:06:35 +0800, Hilton Chain wrote: > > > I'll try to understand the jami test failure, but my last experiments > > were not successful. Help welcome. > > Did your have a luck with the dbus change you mentioned on IRC? Found out it's =A1mkdir-p/perms=A2 failed, from its docstring: "Additionall= y, verify no component of DIRECTORY is a symbolic link". Changing it to mkdir-p + chown + chmod passes the test. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 09:21:05 2025 Received: (at 73494) by debbugs.gnu.org; 13 Mar 2025 13:21:06 +0000 Received: from localhost ([127.0.0.1]:54135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsiUj-0007aD-Di for submit@debbugs.gnu.org; Thu, 13 Mar 2025 09:21:05 -0400 Received: from mail-yb1-xb29.google.com ([2607:f8b0:4864:20::b29]:61696) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tsiUg-0007ZR-4C for 73494@debbugs.gnu.org; Thu, 13 Mar 2025 09:21:03 -0400 Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-e4930eca0d4so782051276.3 for <73494@debbugs.gnu.org>; Thu, 13 Mar 2025 06:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741872056; x=1742476856; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jvTEAZgDjTPFkJA+HZyueuyOj3KLcljIHjJcJacryCw=; b=aLF6Df/NGkshyMxKseA9QLbXrNpbpOAJPXNFdFQpBw3FCaC5PtEETNIdcXcqnm6BE6 IRgI/CR2lA4jhAgRp3yU4Ad37W3kUOMPMJNUrwZoMMl4lefFhEbYHT1FA7LqL/18rcqJ jgLNA4pMyVC4NopXZVoQqo+7GYoBQzZLRMTT/KIK56IA0IanjjE0g3faIBaMWM23acn3 c6BhrTi1P0YZaTIHcUV7mhWT984O6NIS0v+yGixi6sLuQO+OBd1qEoRhxHZCHzpVyIkM kSuIwYL8/XuobxHgoxAky4xH7GEzWYtfy2LlV4HNYdI9ntMoXXz32/fdnYX+FUWkb5Gw vYNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741872056; x=1742476856; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jvTEAZgDjTPFkJA+HZyueuyOj3KLcljIHjJcJacryCw=; b=lCy9jge1yMSiAAYZWwGqXW4vr5Q1T7RX9LBWTJL08wMJTEAS6Azb9FHepKZWkM4efP FDf1JYdZX+Jizb3BAYyI6fQJ6bdg5wYCPh1M9ag9FuOS2JRM3huY7aIm9NN+ToIxAPDN 89pUSdr02OrIGTpNSkMJ6k8oL8l23FUUSWEc3UMAiIo+rqKQknfDOFY4yAYFxhNDbN7/ vbDooTrrQxVvyUGd7j4tselKEYg71BWcSJMf2lOdRd0M2EWC62swj//cgpDxfONM5V17 ZxPawdHhxlx4Nkyc1BPR0GuFCdWwk0QWROTvvc/EZ72e+V6qMUVhJiAN+P1OEEvww4Kl RPdw== X-Gm-Message-State: AOJu0YxqgDIfenbH7iffExWQyFnnpqqQDQUB+mo/ToqldxDb9TCBqUsZ 6AB+1aZeMO+1MhXOTAXSbhkfUz4PbMTfay2xWH7osbXKC3H0a32z X-Gm-Gg: ASbGncuNXTGM2fsHnY/0ZDVwZmvUP4cExfsCq5rafuJv2WyjFdbzCNJRrj3ibzkRHEw KpxYHd0MxLNW11hYAqE3cwL/0QbSlmozsFGZsLvV1C+LrHoaYL3J89Ha0a9cZSS8Z/9am6c7rXl m6JCPe9sF9sQngxHMwxM80i2MYiWjKejLz0IQVkieB1NMO1f5VVRbIadRYdukOSDfAbvDWL4/X+ bZHb2YvfoVmp76VQcNS50CCVStyISK+/MeGY4b28R3IWQq5QsUYTG6OE0Dt3PwW9QLKEEU3hr6J aE4/CeZg4Utx+/eGBCpRjTy8RlRWeGyrrLBuuRhtP4E0rZp6NqA+WMVhapr9bRgLFg== X-Google-Smtp-Source: AGHT+IGggSU137w3pcu28JfW22CgjCTwOl8RIa5hRMwsZRwc5uuP9lGBL3kSfR51beNBlR1Rjhelpw== X-Received: by 2002:a05:6902:161e:b0:e63:6f6a:ab03 with SMTP id 3f1490d57ef6-e63720da68cmr26786051276.22.1741872056127; Thu, 13 Mar 2025 06:20:56 -0700 (PDT) Received: from terra (vps-6234970c.vps.ovh.ca. [51.222.13.224]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e63e555243bsm318232276.46.2025.03.13.06.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 06:20:55 -0700 (PDT) From: Maxim Cournoyer To: Hilton Chain Subject: Re: [bug#73494] [PATCH v3 0/3] tmpfs /run In-Reply-To: <874izxit04.wl-hako@ultrarare.space> (Hilton Chain's message of "Thu, 13 Mar 2025 10:06:35 +0800") References: <8734fmu065.fsf@gmail.com> <874izxit04.wl-hako@ultrarare.space> Date: Thu, 13 Mar 2025 22:20:40 +0900 Message-ID: <87bju5dq3b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Hilton Chain writes: [...] >> I like it, but I think you can't use the i18n or diagnostics user-facing >> modules on the build side, as their closure is too big to be reasonably >> imported. Most modules intended to be used on the builder side are >> namespaced under (guix build ...), but there are a few excptions. > > Just checked, these two modules are already inside (gnu build activation)= 's > closure. Oh, indeed: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> (set! %load-hook (lambda (filename) (format #t "Loading ~a ...\n" filename))) scheme@(guile-user)> ,use (gnu build activation) Loading /run/current-system/profile/share/guile/site/3.0/gnu/build/activati= on.scm ... Loading /run/current-system/profile/share/guile/site/3.0/gnu/system/account= s.scm ... Loading /run/current-system/profile/share/guile/site/3.0/guix/records.scm .= .. Loading /run/current-system/profile/share/guile/site/3.0/gnu/system/privile= ge.scm ... Loading /run/current-system/profile/share/guile/site/3.0/gnu/build/accounts= .scm ... Loading /run/current-system/profile/share/guile/site/3.0/guix/combinators.s= cm ... Loading /gnu/store/ylwk2vn18dkzkj0nxq2h4vjzhz17bm7c-guile-3.0.9/share/guile= /3.0/srfi/srfi-19.scm ... [...] Loading /run/current-system/profile/share/guile/site/3.0/gnu/build/file-sys= tems.scm ... Loading /run/current-system/profile/share/guile/site/3.0/gnu/system/uuid.sc= m ... Loading /run/current-system/profile/share/guile/site/3.0/gnu/system/file-sy= stems.scm ... Loading /gnu/store/ylwk2vn18dkzkj0nxq2h4vjzhz17bm7c-guile-3.0.9/share/guile= /3.0/srfi/srfi-2.scm ... Loading /run/current-system/profile/share/guile/site/3.0/guix/diagnostics.s= cm ... Loading /run/current-system/profile/share/guile/site/3.0/guix/colors.scm ... Loading /run/current-system/profile/share/guile/site/3.0/guix/memoization.s= cm ... Loading /run/current-system/profile/share/guile/site/3.0/guix/profiling.scm= ... Loading /run/current-system/profile/share/guile/site/3.0/guix/i18n.scm ... [...] --8<---------------cut here---------------end--------------->8--- It comes from (gnu system file-systems), which has in a comment: --8<---------------cut here---------------start------------->8--- ;;; Note: this file system is used both in the Shepherd and on the "host ;;; side", so it must not include (gnu packages =E2=80=A6) modules. --8<---------------cut here---------------end--------------->8--- I guess that's fine then. >> I'll try to understand the jami test failure, but my last experiments >> were not successful. Help welcome. > > Did your have a luck with the dbus change you mentioned on IRC? The jami-dbus-session service now runs, but it errors starting the actual jami service. To be investigated. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 14 08:49:06 2025 Received: (at 73494) by debbugs.gnu.org; 14 Mar 2025 12:49:06 +0000 Received: from localhost ([127.0.0.1]:60560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tt4TK-0001fH-0q for submit@debbugs.gnu.org; Fri, 14 Mar 2025 08:49:06 -0400 Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:56152) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tt4TF-0001ei-Oq for 73494@debbugs.gnu.org; Fri, 14 Mar 2025 08:49:03 -0400 Date: Fri, 14 Mar 2025 20:48:31 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1741956538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hVFgkZp4hmRMZF3f9xmdQ3xOAKcAVEW4BHmxP6nlNEU=; b=fRIvR76yyYc6cJiBDP5N3rS9g8E1a19RuJP1zelPIROgMI3P7AYo5DmYbiWKr1dzofhZ6y YyiGNa6lhOWC+M/VKhukG9seTp0kW0Sb7oH8dItbMzFS3xZsbk3xpKvySpGepTODh3JHlE ESYMdk8NMq45AtCBDXrCVbuCe5Hnwp5lExW9Bq62XwyDw+FgfZb8a1aYj/gI7hkeBAaNTw WEgmnnLmSaSkBXNUHWseKR4tW8rwIKZ69hHC/7kSHW3GgvswVI3Aw5oIbHTqUop6fAP3lA Df6FMranKtsFaQmEeUD4ZV+AQwLDt+NMoyzV0akLQMLqRplb1T+JkWLt639PqQ== Message-ID: <87jz8rixr4.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH v3 0/3] tmpfs /run In-Reply-To: <87bju5dq3b.fsf@gmail.com> References: <8734fmu065.fsf@gmail.com> <874izxit04.wl-hako@ultrarare.space> <87bju5dq3b.fsf@gmail.com> MIME-Version: 1.0 X-MS-Reactions: disallow Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Ludovic =?ISO-8859-1?Q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 13 Mar 2025 21:20:40 +0800, Maxim Cournoyer wrote: > > >> I'll try to understand the jami test failure, but my last experiments > >> were not successful. Help welcome. > > > > Did your have a luck with the dbus change you mentioned on IRC? > > The jami-dbus-session service now runs, but it errors starting the > actual jami service. To be investigated. I think we can actually get rid of the symlink issue, by using a bind mount. I actually thought about this even before trying to use a symlink, but it fails at initrd stage, not sure why. I just tried to add the bind mount in cleanup-service-type, which is executed after initrd and before activation, and succeeded :) From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 26 11:04:09 2025 Received: (at 73494) by debbugs.gnu.org; 26 Apr 2025 15:04:09 +0000 Received: from localhost ([127.0.0.1]:34035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8h4b-0002N8-6F for submit@debbugs.gnu.org; Sat, 26 Apr 2025 11:04:09 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:54341) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u8h4Y-0002MP-FP for 73494@debbugs.gnu.org; Sat, 26 Apr 2025 11:04:07 -0400 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-b061a775ac3so3274912a12.0 for <73494@debbugs.gnu.org>; Sat, 26 Apr 2025 08:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745679840; x=1746284640; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=U4SIr+KSBJcyVCQOizvTc+FFbO2+AD6KJjL/RElXgew=; b=NF77lv4aUPeBOhUVrdCDfMNf7Yy3DpKAqBSKzBJT8alYdAi8Z+0VkAgXlW32jaffX1 fEgD1rGvAfjn/P89Jjy8J+1yu15FSRNXyrWK3pFIkDA1Q0KzgBqGhG+0qrIkBYsE3Klg Jx94Px6/6ePjQbbdZbnLaBz0QXdvotJonxLxqbztdMFKPukk+Tch4cp2GeZxk2rRAMi5 7B3sdaEwF8ieOGwbkQN4e9+SHFZqNIuITQksLiJuXavKefnWO1C/MkKe8Z8UmTbIiGVu +RwM6l1ZJYzTl6mAPG7xGxIpKm6pArjLPhacENNmBBPLLn7kotgWtcz5k6fKR6lfcKSu mQAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745679840; x=1746284640; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U4SIr+KSBJcyVCQOizvTc+FFbO2+AD6KJjL/RElXgew=; b=v6i8q5JqQuRfxx772w6ix3KolG3/1TJf6N5mgtnj02Ju34g/ZEmixXZsQtNxtEq6Dc aSAduGAwtqPLBD//+npbKfY7psOK1fQssTNhjMkyh1cVu52U3n7MR36zBk4nWl2Luke4 s4W8uFUWPpBBxIysvNIuzPLgV53bJwsEa18lg6fbbeI6H17IJWSm63lhspXwsUy2h8Fw geGejq8I9VAiM/2en4+rUnm+yL3WT9Itg+mn/btVH0oVNO4UQ3FphojLim8tRlPYYjFD u7Jq0y9sAtvUwm7783qw1IDy2ye53xMGh8QnzuETKfVKcumZtrKnfrsiQvHb6WCRCtQ0 XuQA== X-Gm-Message-State: AOJu0YxvRkVl7H9f6rpjcCNAtTpF7cHZ6pkNIojljKvM3zIFaemlf/KV VPc41mr9UZN4Is/rhJuDWuHY87fxLERBLRMMrCotAwi2mqZ2l15Y X-Gm-Gg: ASbGnctLgvwV1U4Jnpu0T9whQLyR4FQ4m3e1j/D2ZjtZMvqmEbLOqdhBw9M+C3oOL2G XSvponSkU9GJvPgEstG9OG/dPtGhfiTkL+mFffDamnCUEa2TE2cGI+GH6NaUQTKImSQ9CcZBFol /FQzYDgo8DPaxpSHpwlY5/TT+nbrr+vQup8/GysxDjDFtyszmQAZWD0UPnaZaUyl7xxGZ2WLbCR 3tRA9ZvazHE6YM81nDF8mX2ew0vBxj4uef+PFmSO/5yd2wim0OkVS75X9exSFVmvf8vGgCHDaKC EtGX9hSlGX4mlsn+Qe9R0hbGjpQirqJVgJlN110= X-Google-Smtp-Source: AGHT+IHHndHEOsUIoJcbAqAiI0BQGCInjqFxJQ3pIxD0dkm3LvnCktw/C/ctslJLzTa6xZkh/j0mzA== X-Received: by 2002:a17:902:ce07:b0:227:e74a:a063 with SMTP id d9443c01a7336-22dc6a68f4emr48127645ad.37.1745679840326; Sat, 26 Apr 2025 08:04:00 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4dbb204sm50656455ad.57.2025.04.26.08.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Apr 2025 08:03:59 -0700 (PDT) From: Maxim Cournoyer To: Hilton Chain Subject: Re: [bug#73494] [PATCH v3 2/3] services: cleanup: Make /var/run a symlink of /run. In-Reply-To: <830b6fd522e9fc0e5c0008560dd9877c44d18d35.1741241800.git.hako@ultrarare.space> (Hilton Chain's message of "Thu, 6 Mar 2025 14:22:43 +0800") References: <830b6fd522e9fc0e5c0008560dd9877c44d18d35.1741241800.git.hako@ultrarare.space> Date: Sun, 27 Apr 2025 00:03:56 +0900 Message-ID: <87v7qrdkwz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Hilton, Hilton Chain writes: > * gnu/services.scm (cleanup-gexp): Make /var/run a symlink of /run. > * doc/guix.texi (File Systems): Document it. > * gnu/system/file-systems.scm (file-system-mapping->bind-mount): Replace > /var/run in source path with /run. > * gnu/services/dbus.scm (dbus-activation): Adjust accordingly. [...] > --- a/gnu/system/file-systems.scm > +++ b/gnu/system/file-systems.scm > @@ -594,7 +594,12 @@ (define (file-system-mapping->bind-mount mapping) > (($ source target writable?) > (file-system > (mount-point target) > - (device source) > + (device > + ;; /var/run is implemented as a symlink to /run. > + (if (and (string? source) > + (string-prefix? "/var/run" source)) > + (string-drop source 4) > + source)) > (type "none") > (flags (if writable? > '(bind-mount) I'd really prefer avoiding having to resort to the above hack, even if that means grafting dbus with a variant that is built to use /run instead of /var/run. The jami test still fails with the current v3 too, that still needs investigation. It's annoying that I keep running out of steam on this series; if you can continue pushing it forward, I'll have a look! -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 26 12:37:55 2025 Received: (at 73494) by debbugs.gnu.org; 26 Apr 2025 16:37:55 +0000 Received: from localhost ([127.0.0.1]:34438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8iXK-000262-Kc for submit@debbugs.gnu.org; Sat, 26 Apr 2025 12:37:55 -0400 Received: from mail.boiledscript.com ([49.12.134.184]:38364) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u8iXI-00025t-Nv for 73494@debbugs.gnu.org; Sat, 26 Apr 2025 12:37:53 -0400 Date: Sun, 27 Apr 2025 00:36:54 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1745685470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4VL95pQ9d2rN89ffmUqqDnzsLSYDtTTNJBAS8dFrUVE=; b=j7mR8vqA4J3dXD2CFY6NRS3s1+Q/skCjBc7aVwknLn7/jlOY0BVnjM+7XORkDklmLZE8U4 YWIbSDh2j/PvUxITe3/CiBF6e5FG1NTvYDB6UATIF/1/odI5CTi8aQixXHfiiOuVunTASH XyChN8YS/Gy07kiCILoTOO0U4+ILisS/9v0Av5TUdkn5mK09cO5nlM7qxbndak21Ac5iiv yvdfX4x/6uPufVoqdF7URUgGwD6PE8flEuNs3Ib0dWn1TBhxppertb8lbIhBOnqzJnoG1D ZRQFRWb4dAv3t0+qAq+X4wtNIJoasEfyYFSvDCYXDkAiXFGtFr2e7YAazlsCBA== Message-ID: <87bjsix4k9.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH v3 2/3] services: cleanup: Make /var/run a symlink of /run. In-Reply-To: <87v7qrdkwz.fsf@gmail.com> References: <830b6fd522e9fc0e5c0008560dd9877c44d18d35.1741241800.git.hako@ultrarare.space> <87v7qrdkwz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Ludovic =?ISO-8859-1?Q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, 26 Apr 2025 23:03:56 +0800, Maxim Cournoyer wrote: > > Hi Hilton, > > Hilton Chain writes: > > > * gnu/services.scm (cleanup-gexp): Make /var/run a symlink of /run. > > * doc/guix.texi (File Systems): Document it. > > * gnu/system/file-systems.scm (file-system-mapping->bind-mount): Replace > > /var/run in source path with /run. > > * gnu/services/dbus.scm (dbus-activation): Adjust accordingly. > > [...] > > > --- a/gnu/system/file-systems.scm > > +++ b/gnu/system/file-systems.scm > > @@ -594,7 +594,12 @@ (define (file-system-mapping->bind-mount mapping) > > (($ source target writable?) > > (file-system > > (mount-point target) > > - (device source) > > + (device > > + ;; /var/run is implemented as a symlink to /run. > > + (if (and (string? source) > > + (string-prefix? "/var/run" source)) > > + (string-drop source 4) > > + source)) > > (type "none") > > (flags (if writable? > > '(bind-mount) > > I'd really prefer avoiding having to resort to the above hack, even if > that means grafting dbus with a variant that is built to use /run > instead of /var/run. > > The jami test still fails with the current v3 too, that still needs > investigation. > > It's annoying that I keep running out of steam on this series; if you > can continue pushing it forward, I'll have a look! As said in [1], I have changed to use bind mount instead, currently locally and available in [2]. This approach should get rid of symlink issues. --- [1]: https://issues.guix.gnu.org/73494#35 [2]: https://git.boiledscript.com/hako/guix/commit/7e2ea69a2b2d2f2148591484075f56cd44ec62b3 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 28 21:26:53 2025 Received: (at 73494) by debbugs.gnu.org; 29 Apr 2025 01:26:53 +0000 Received: from localhost ([127.0.0.1]:41087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9ZkL-0003sY-1p for submit@debbugs.gnu.org; Mon, 28 Apr 2025 21:26:53 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:54767) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9ZkG-0003qp-4G for 73494@debbugs.gnu.org; Mon, 28 Apr 2025 21:26:50 -0400 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-306b6ae4fb3so6091567a91.1 for <73494@debbugs.gnu.org>; Mon, 28 Apr 2025 18:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745890002; x=1746494802; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=w+eRMGZLZcjSOHiythdiBaRdXxuLtEZ5CY8roL+ErxQ=; b=iSwCRRVvhXugOXSADRU6l7pcdTdwRpTx/f9k6uYctPSSpKqYb2X6Q644qflUw+ivdi jSP+1UG5Ba/9dPmOunMRy5kPHClTypX7hmLbYCvuMVmAfYbOPQk/Sl3NI8uHb2i2wW6j o9P7yFcVG8Fh+yQLzhPGaFlBxim95TANmup3TG7CYxivCJEYtRanbw74tgM4nmnubO/B V+hDjkkXpuNvZv21CZWmcgS32eCOqPfuSA84huega3PY3eLhQZZVNLJnHitTwyEL90Hm 5Yvnb+kgz7GpeWqeCRopRhylAJSB0dOLCrl9cyI1baVWlZxVRrpy1EbBq+rEstbbFwNv TEfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745890002; x=1746494802; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w+eRMGZLZcjSOHiythdiBaRdXxuLtEZ5CY8roL+ErxQ=; b=ZcpNaF+C5hcg20Lxb1yYCcIgNY8nfVl7Ru9SnEdU9nqndCNJT0u6pq/CNo2IK9sB/N PpNgMAYYQUyMaBz0WAHQv/RAkscGlwRJgWE8UFOlOAy/yUSYsMovi/dTGMvO63jNB1+n 1F+3Z2Lbosr8uKl6bYfpXuvo4DcMRY0g9B1IVppm0KSFmMYMmDs8jVy3F9k0ZI7MgMWT Lo/oDPHAsQSJcDU5R2JUNdQ6/cpRWLArxq8Okne2dIMpC6zC0UwXH8Gy0qLzVwAohR44 DCRVowukMLHoPNiyT6Q6a56RaLyaCxCCxzziZI28YkPTW4efuxwNLUxiyjnVZ1J4hNq8 Tugg== X-Gm-Message-State: AOJu0Yz9oMbi6CduXKSr6cxwOYWE92Oy9/TJV8ofw2mK/+aZSP6DmiD6 IgqFkxjj13Pw01eP7AVf1y/NBXPbsU8c/yYuEQfLG8iHNhnRWckFglkppVfO X-Gm-Gg: ASbGncuPfCku82a9azzQuX1GKUGdyvQbZE0dOl0x7lwpDPPj8e7ODETpUGnswIqB+1V zai0zlvJN/q0q4939yBv/MHzZNnNacXcYRPMr1EZA+xM9LDWVxS9Sx6RKR1JnmlrfpPDLhAnhPY 7YpBh7Kpbwl6x/+VJgA43LbCM4RGTqfZ4s2eCqQ2T12QBgmQYQsvSvDvLXwIDipfCsIw/SjnSUV 6V888hjDstRZ7na4YJSYfcKottmiiNChpKv8/9bpgrhaD+kweaPiqSQ4fctKyCRy0wvXRZ9QHTT coOJExjdCqiZl+LLzfoysXP3QHanqqkqIET3svc= X-Google-Smtp-Source: AGHT+IGrOmnzbJvBUohB8W1vzvO5O2hadt3I/jKLzyyzW+BGdd7A2J47+94AA3OjkXsz0MkB8YpMig== X-Received: by 2002:a17:90b:586e:b0:305:2d27:7ca7 with SMTP id 98e67ed59e1d1-30a0133b15fmr17425508a91.16.1745890001804; Mon, 28 Apr 2025 18:26:41 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309ef14a363sm9771493a91.49.2025.04.28.18.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 18:26:41 -0700 (PDT) From: Maxim Cournoyer To: Hilton Chain Subject: Re: [bug#73494] [PATCH v3 2/3] services: cleanup: Make /var/run a symlink of /run. In-Reply-To: <87bjsix4k9.wl-hako@ultrarare.space> (Hilton Chain's message of "Sun, 27 Apr 2025 00:36:54 +0800") References: <830b6fd522e9fc0e5c0008560dd9877c44d18d35.1741241800.git.hako@ultrarare.space> <87v7qrdkwz.fsf@gmail.com> <87bjsix4k9.wl-hako@ultrarare.space> Date: Tue, 29 Apr 2025 10:26:37 +0900 Message-ID: <87wmb3bvw2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Hilton, Hilton Chain writes: [...] > As said in [1], I have changed to use bind mount instead, currently locally and > available in [2]. This approach should get rid of symlink issues. As mentioned on IRC, I've tried all these, but I'm still left with a broken 'jami-provisioning' system test. It still needs investigating to understand what is at cause. I've tried many things such as having our dbus use /run instead of /var/run (via a graft -- I hope this was in effect in the system tests, it looks like it should), but the problem persisted. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 00:47:41 2025 Received: (at 73494) by debbugs.gnu.org; 29 Apr 2025 04:47:41 +0000 Received: from localhost ([127.0.0.1]:44390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9cse-0003Jz-UR for submit@debbugs.gnu.org; Tue, 29 Apr 2025 00:47:41 -0400 Received: from mail.z572.online ([88.99.160.180]:49200) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9csX-0003IO-JJ for 73494@debbugs.gnu.org; Tue, 29 Apr 2025 00:47:38 -0400 Received: from m ( [115.198.129.146]) by mail.z572.online (OpenSMTPD) with ESMTPSA id abcac660 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 29 Apr 2025 04:54:14 +0000 (UTC) From: Z572 To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH v3 2/3] services: cleanup: Make /var/run a symlink of /run. In-Reply-To: <87wmb3bvw2.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 29 Apr 2025 10:26:37 +0900") References: <830b6fd522e9fc0e5c0008560dd9877c44d18d35.1741241800.git.hako@ultrarare.space> <87v7qrdkwz.fsf@gmail.com> <87bjsix4k9.wl-hako@ultrarare.space> <87wmb3bvw2.fsf@gmail.com> User-Agent: mu4e 1.12.9; emacs 30.0.92 Date: Tue, 29 Apr 2025 12:47:24 +0800 Message-ID: <87plgv8tgj.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , Hilton Chain , 73494@debbugs.gnu.org, Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Maxim Cournoyer writes: > Hi Hilton, > > Hilton Chain writes: > > [...] > >> As said in [1], I have changed to use bind mount instead, currently >> locally and >> available in [2]. This approach should get rid of symlink issues. > > As mentioned on IRC, I've tried all these, but I'm still left with a > broken 'jami-provisioning' system test. It still needs investigating to > understand what is at cause. I've tried many things such as having our > dbus use /run instead of /var/run (via a graft -- I hope this was in > effect in the system tests, it looks like it should), but the problem > persisted. mkdir-p/perms does not accept symlinks[1], adjust mkdir-p/perms to ``` (mkdir-p "/var/run/jami") (chown "/var/run/jami" (passwd:uid user) (passwd:gid user)) (chmod "/var/run/jami" #o700) ``` can work and (@@ (gnu tests telephony) make-jami-os) need remove shepherd-system-log-service-type and add syslog-service-type can successed. A rough modification is as follows. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-quickfix.patch Content-Transfer-Encoding: quoted-printable From=20af0588f980006381c3f8e14f6502183a3d39a1b8 Mon Sep 17 00:00:00 2001 Message-ID: From: Zheng Junjie Date: Tue, 29 Apr 2025 12:46:01 +0800 Subject: [PATCH] quickfix Change-Id: I6996b5627d732d1c261ae453da5d0916637b0288 =2D-- gnu/services/telephony.scm | 4 +++- gnu/tests/telephony.scm | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gnu/services/telephony.scm b/gnu/services/telephony.scm index 9926f4107de..a54fab7c4ac 100644 =2D-- a/gnu/services/telephony.scm +++ b/gnu/services/telephony.scm @@ -309,7 +309,9 @@ (define (jami-dbus-session-activation config) #~(begin (use-modules (gnu build activation)) (let ((user (getpwnam "jami"))) =2D (mkdir-p/perms "/var/run/jami" user #o700) + (mkdir-p "/var/run/jami") + (chown "/var/run/jami" (passwd:uid user) (passwd:gid user)) + (chmod "/var/run/jami" #o700) ;; Customize the D-Bus policy to allow 'root' to access other us= ers' ;; session bus. Also modify the location of the written PID fil= e, ;; from the default '/var/run/dbus/pid' location. This file is = only diff --git a/gnu/tests/telephony.scm b/gnu/tests/telephony.scm index f03ea963f7e..219cb421647 100644 =2D-- a/gnu/tests/telephony.scm +++ b/gnu/tests/telephony.scm @@ -30,6 +30,7 @@ (define-module (gnu tests telephony) #:use-module (gnu services telephony) #:use-module (guix gexp) #:use-module (guix modules) + #:use-module (gnu services shepherd) #:export (%test-jami %test-jami-provisioning %test-jami-provisioning-partial)) @@ -116,7 +117,9 @@ (define* (make-jami-os #:key provisioning? partial?) (openssh-configuration (permit-root-login #t) (allow-empty-passwords? #t))) =2D %base-services)) + (service syslog-service-type) + (modify-services %base-services + (delete shepherd-system-log-service-type)))) (packages (cons* (specification->package "recutils") (specification->package "strace") %base-packages)))) base-commit: f76b9c4fdf88cbab81e3cac27841a6c56e3e32c9 prerequisite-patch-id: fabc087075461a425f06083732136418b4940e6d prerequisite-patch-id: b59e27442300208442b59900e844855b9ed63d96 prerequisite-patch-id: 701e20f8b287553c49ece96290e71dd7ef145b6c =2D-=20 2.49.0 --=-=-= Content-Type: text/plain [1] https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/build/activation.scm?h=master#n92 and https://issues.guix.gnu.org/47584 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmgQWdwACgkQO1qpk+Gi 3/CScA//QUItSmp+MSks0lukiGPGY9NQq4gr8uSerG0t1kySQZ8YnFNVHfKOOMis AYC/jjmxlFcFWc3W3oJ1Keotr45diyigeGoDoafQLTfcWeRQGx3gbrjtvn5wLaoi M/yv/4AX6qMfcg9ZDcPKwK/i9tpX8iC9tInesyFxyBP8p6wbwfBpJ9HXNz8taoq/ vQAF1lWozX/w6eOeiqsJoszEZQb8hbKkUOEzXBDGSn9Ipfbe5Ilf1YLAYzfduBRu drosWRhm+DNasD8jLzmlxa4o+QqJehbVfI+/Xk86p+P0bNNtML/i3iHg4goP920+ Pr8Saj1aV2UyiCNdzvRGU9Zx6FojUYWkfRK/CDDkYBXB06pUTEXoTNC3DPbE3cLK s+jTjb/TYzoCzeAiJgKW9Mq2czULnS6U5MdrSFI+dH26SnhJVMRcgTwDjNaLAHuM rMc3YaEK+wrABLzUm+nA1fNWAViPwPr5gxxBa6IjZlKd7ly0oCdRZ27PN7EDL4Vq 2A/kRLucVtQ2rvnB8uTTlPQbDK7j+kxslIsJtMcUSj6dqKsFd2o0CfI2dmZPpj/K gBE+y7esPI8lrgSt15GRAvINKIXE0nlK8/6qhRFtUViC+YEC2q/Bl/O/kkNhU8Q3 ggcEH6Dixwr6TSrNnLOg1ptu/03M0gn9oNh1/qYtLZ09Kufbv40= =ppq1 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 02:29:22 2025 Received: (at 73494) by debbugs.gnu.org; 29 Apr 2025 06:29:23 +0000 Received: from localhost ([127.0.0.1]:46165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9eT4-0007dP-Jj for submit@debbugs.gnu.org; Tue, 29 Apr 2025 02:29:22 -0400 Received: from mail.boiledscript.com ([2a01:4f8:242:4aeb::42]:35294) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9eT2-0007d9-7O for 73494@debbugs.gnu.org; Tue, 29 Apr 2025 02:29:21 -0400 Date: Tue, 29 Apr 2025 14:28:29 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1745908158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2R7EvzCZ5RrLe8BFlvvcRhfzPbYrVWZ2JZRJbE/FIKs=; b=g6xNRyq44cLAy+ygET97wbV5Ffkp58AZBoT+oNdzccGTf/Ms4K9KZd3C6TN7QHN8WkcAL/ 2A/DUUimSdgJ+plCDmplpx7WbZOF+H6T9ABruYKF/iiwJQH7Xp/KEihxcMfSvSF2pK9iNY +rbSBweYNTmDksc3/sck8rMUDWcT/inQXkPtDfN+lc3HrJHzVxYDqsh7P4RIqX1pg/jr7c HQw1FZQI6CFmfuM+KgL6hSUAVPluGutuL/vltjhljOIBOVzw7OkFxMRLILpOI9ePXQybOr D0pEkFUnR6y2ciRgFSW3FiTqR6Au4PBjX1X2UzFToM20hNrPiaems8P2ipq+qg== Message-ID: <878qnjwkfm.wl-hako@ultrarare.space> From: Hilton Chain To: Z572 Subject: Re: [bug#73494] [PATCH v3 2/3] services: cleanup: Make /var/run a symlink of /run. In-Reply-To: <87plgv8tgj.fsf@iscas.ac.cn> References: <830b6fd522e9fc0e5c0008560dd9877c44d18d35.1741241800.git.hako@ultrarare.space> <87v7qrdkwz.fsf@gmail.com> <87bjsix4k9.wl-hako@ultrarare.space> <87wmb3bvw2.fsf@gmail.com> <87plgv8tgj.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Ludovic =?ISO-8859-1?Q?Court?= =?ISO-8859-1?Q?=E8s?= , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 29 Apr 2025 12:47:24 +0800, Z572 wrote: > > [1 ] > [1.1 ] > Maxim Cournoyer writes: > > > Hi Hilton, > > > > Hilton Chain writes: > > > > [...] > > > >> As said in [1], I have changed to use bind mount instead, currently > >> locally and > >> available in [2]. This approach should get rid of symlink issues. > > > > As mentioned on IRC, I've tried all these, but I'm still left with a > > broken 'jami-provisioning' system test. It still needs investigating to > > understand what is at cause. I've tried many things such as having our > > dbus use /run instead of /var/run (via a graft -- I hope this was in > > effect in the system tests, it looks like it should), but the problem > > persisted. > > > mkdir-p/perms does not accept symlinks[1], > > adjust mkdir-p/perms to > > ``` > (mkdir-p "/var/run/jami") > (chown "/var/run/jami" (passwd:uid user) (passwd:gid user)) > (chmod "/var/run/jami" #o700) > ``` Using a bind mount should get rid of symlink issues, there're more usage of mkdir-p/perms and mounting /var/run into container currently. > can work > > and (@@ (gnu tests telephony) make-jami-os) need remove > shepherd-system-log-service-type and add syslog-service-type can > successed. Thanks, this does pass the tests. Do you know why this is needed? From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 02:49:47 2025 Received: (at 73494) by debbugs.gnu.org; 29 Apr 2025 06:49:47 +0000 Received: from localhost ([127.0.0.1]:46508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9emo-0004mr-Vd for submit@debbugs.gnu.org; Tue, 29 Apr 2025 02:49:47 -0400 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]:58665) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9emj-0004kz-AQ for 73494@debbugs.gnu.org; Tue, 29 Apr 2025 02:49:43 -0400 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2ff799d99dcso5732529a91.1 for <73494@debbugs.gnu.org>; Mon, 28 Apr 2025 23:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745909375; x=1746514175; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=nR/rySBKo4cw4+PEXEFb0rxKKKHuzdf2RbuOvoJgzGM=; b=Jfbn1SOzaSKJE4OrL/z7bxBnRLwkZo/kYdnJ1TbU6ofeP75+e/u8kyOfa6u1IqiWF1 v998a2JMXmuDHv++/h9xxdHZex72ADGnw3hxfCW3QmSCk1wV48LuZvLEKgaobgltt/yx xO8Th0L9Q0I1HH1oOdKBbFB912i2Qp+FX6PcoRPe6vwI1sB5mU3DElA1YFBciDd7dGYD kCJOtNi4DpEgw7SOEsrG0GcUCFRbZtOU2cVBys5KiTKEHVOOFQq87nibbl4febxqbbbh PWu9DzDXK4yEZuBt2egdIusClnz0Qfi4ZBabJcBG7bJ8YW0Htdg+yNjOYOv3kjCqTl1/ f83g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745909375; x=1746514175; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nR/rySBKo4cw4+PEXEFb0rxKKKHuzdf2RbuOvoJgzGM=; b=QGTYAgIUKOx6XYXHHwU5eb8jxO7gW8O6k3BsJ7P3ZlQTS1MBKpztIjHxwkbhnYpVi9 TJjygxaBcNHGNogNZ5xUy9xPh3iprBC6gnnexrjgnkwG/MhUzxgzlRor7VU4lJI7OING Vd9o+dgIA+gyVvjWHlbXZDnCknm3OIy05MWc8zjM/hnnELaAsoAGVzhNkf7NcyjPmegt /tcp0Num9AfKG9RovIadDQLgydQxfek6NdwbciHRJajS+raDd8tA3wgd+FozZdCsK8IB QrGMc7V3kPC2uWnl/Q59ru3cUNnIDOX9rxfYvBB089bTtrLX6SGYslwJdBKIk73WfJdA T3+A== X-Forwarded-Encrypted: i=1; AJvYcCVCiGsxN1FNt5HuOFYT5PnbsvqdlceSAx9q5+5W/OXTuIHkiXZZZJKy/qk8xqb6JjzGNeYshA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy8x9lEMKF1bALn8QFqQp7i1mZ4MmReFn2QnTWbE0BsTUhXBHA3 E+p+8O30cBGTHQ1Gys9h/NpSn6JLAsUZA3wG2yrEPyQdZykNVwtw X-Gm-Gg: ASbGncvvHnwqgJAORSZ8e6kJ5dYn8ScrQm8E508Eb5ixqfd4r64S21rD5aMoEPq5K+u IIeEnZEj9foYLLkqOJ9vvXfb00ajgIk2XvBlW9nH2+QAHDJevHUWimoOT9njMnQH/eiBLuNu7ht 8V8zcmY/Veti3YM/AbOHKkjO78J+nmc/9yUGJMJ7+9eA2zVgWjMpuVCDo4HNjK2r3s67KGk5Iq1 Ac73D2YiZX1DDm8H5a9OrgzXp6+uGfTjTMttpWlCWWO97L2kZ6qoCQGVS7fA7zfg8CdSejROcQQ kw4fQ11khEwpzuRkkH47YDJwT/UmpGuFTqt40oW5JOctw2vhzA== X-Google-Smtp-Source: AGHT+IHGHckPolKSyjqBcmvogS4r1wllftePBMgwO6h9SSlDl5k3EV6Kugj6lrbFG1lPI0Gpcv+iXA== X-Received: by 2002:a17:90b:1d48:b0:2f4:4003:f3d4 with SMTP id 98e67ed59e1d1-30a2159bec5mr3351487a91.30.1745909375255; Mon, 28 Apr 2025 23:49:35 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309ef061b11sm10331193a91.15.2025.04.28.23.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:49:34 -0700 (PDT) From: Maxim Cournoyer To: Z572 Subject: Re: [bug#73494] [PATCH v3 2/3] services: cleanup: Make /var/run a symlink of /run. In-Reply-To: <87plgv8tgj.fsf@iscas.ac.cn> (zhengjunjie@iscas.ac.cn's message of "Tue, 29 Apr 2025 12:47:24 +0800") References: <830b6fd522e9fc0e5c0008560dd9877c44d18d35.1741241800.git.hako@ultrarare.space> <87v7qrdkwz.fsf@gmail.com> <87bjsix4k9.wl-hako@ultrarare.space> <87wmb3bvw2.fsf@gmail.com> <87plgv8tgj.fsf@iscas.ac.cn> Date: Tue, 29 Apr 2025 15:49:31 +0900 Message-ID: <87frhrbgxw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , Hilton Chain , 73494@debbugs.gnu.org, Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Zheng, Z572 writes: [...] > and (@@ (gnu tests telephony) make-jami-os) need remove > shepherd-system-log-service-type and add syslog-service-type can > successed. > > A rough modification is as follows. Wow, this works! How did you find out? And why is shepherd-system-log-service-type not a compatible replacement of syslog-service-type here? Thank you! -- Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 03:14:41 2025 Received: (at 73494) by debbugs.gnu.org; 29 Apr 2025 07:14:41 +0000 Received: from localhost ([127.0.0.1]:46952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9fAu-0007yP-NI for submit@debbugs.gnu.org; Tue, 29 Apr 2025 03:14:40 -0400 Received: from mail.z572.online ([88.99.160.180]:34524) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9fAq-0007yB-TA for 73494@debbugs.gnu.org; Tue, 29 Apr 2025 03:14:38 -0400 Received: from m ( [115.198.129.146]) by mail.z572.online (OpenSMTPD) with ESMTPSA id 93db8ff4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 29 Apr 2025 07:21:16 +0000 (UTC) From: Z572 To: Hilton Chain Subject: Re: [bug#73494] [PATCH v3 2/3] services: cleanup: Make /var/run a symlink of /run. In-Reply-To: <878qnjwkfm.wl-hako@ultrarare.space> (Hilton Chain's message of "Tue, 29 Apr 2025 14:28:29 +0800") References: <830b6fd522e9fc0e5c0008560dd9877c44d18d35.1741241800.git.hako@ultrarare.space> <87v7qrdkwz.fsf@gmail.com> <87bjsix4k9.wl-hako@ultrarare.space> <87wmb3bvw2.fsf@gmail.com> <87plgv8tgj.fsf@iscas.ac.cn> <878qnjwkfm.wl-hako@ultrarare.space> User-Agent: mu4e 1.12.9; emacs 30.0.92 Date: Tue, 29 Apr 2025 15:14:22 +0800 Message-ID: <87jz738mnl.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Hilton Chain writes: >> >> and (@@ (gnu tests telephony) make-jami-os) need remove >> shepherd-system-log-service-type and add syslog-service-type can >> successed. > > Thanks, this does pass the tests. Do you know why this is needed? I guess it may be that system-log-service-type does not implement some features of syslogd, or it is inconsistent with some features of syslogd. This test failed for some time[1], so I think this test failure should not affect the merge of this patch series. [1] https://ci.guix.gnu.org/build/9557293/details --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmgQfE4ACgkQO1qpk+Gi 3/DS9RAAtq8HfxnF6u/a9NQx85dCpAVMaU7EqXAnqARFoUvWMZgB8FT470SQ4BT0 k5YxC4vRkKs60Le7EBbbOvunNoLvy7MeYc6F3a/XS6vdsET355FhjOzZJdNWlXQu RFgYK0OxVAsVEVCHTbYb0PRC+P6VLpIYVA4Ov/WL1hPkwLRdyQmP/6vhkLrx0tRA vY2yHwjN1NmVAnfrKZoSHpeOUwSYP0p6mwxfvxMseMlt79HzFimqAQUREhvUfWwc vOb72Ymip4szmhQSHdmtG9OIGhutOGcA5xMQ7+NeY3pFFEa5h8NKb3qGhfNtZS6j P9LYoLsQZjiGwsgtu4pv+fgRPsR1BR6bBqbG0tw0LxYH33ZvBsMhKM+zYX4KtNRv KAIlloMpB39Vg4gMj9mPdwxhlKXENSN6pyoTsM9oX6zCMPNH1zH67m/apj6zdzBB dfLyxFzWxhovH2RZgZ8wlVLpA9xf2nSSayLhahwX23/B6skrKMju8v9RS9jkjWfv PqrFC+QitjlD6wQxAUKFsAKwAheO/xZYekuIH3vhJNH0H75iOsufy1VvIzW4saPz Pa8iUdwt/ivVzmFRIHLl7tPs1Vx6Xz2AFTSSZzZUYF2oGe4761gyzjeI7Ml5t4X3 IDJ4CPuHCH4DnH2nfWmQGznngeKqyFHhruB/CQoiC5oicVdPf0U= =IDAI -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 03:18:28 2025 Received: (at 73494) by debbugs.gnu.org; 29 Apr 2025 07:18:28 +0000 Received: from localhost ([127.0.0.1]:47028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9fEa-0008Uz-1o for submit@debbugs.gnu.org; Tue, 29 Apr 2025 03:18:28 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:52658) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9fEU-0008TC-PK for 73494@debbugs.gnu.org; Tue, 29 Apr 2025 03:18:26 -0400 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-223fd89d036so70092125ad.1 for <73494@debbugs.gnu.org>; Tue, 29 Apr 2025 00:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745911095; x=1746515895; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Eyfe1YI2mIOVWjgmSEgA1PXm1vkqddx825qOEpXQNV0=; b=b/4lVeENZRi9a6D6a9lwYVmeCvxQBwrsAtJQWI5A0/RXubvBVvc4HYP+fr/SMDWrBg UpvMqImwU/4GmxvLtC60HRJ0sNikSBhxdZ0f0li/IID2jQBYOjr/FL7IxiEAonKajhM+ 8Jx411bOmfzBgn5kjuRAnLYO+Bj/Z0YLkftw/tM69O8Qo7tXcRPR8rIIE6+jM5fbOmyG grMzEx06UqkkE0Jo04QI/JujiekcWJsajuaHEC9gxIwiu8aRn5FVZt+QA8NyrHTelGQe 9bboHmXRZ25ab2ernM73E0j5SjbBmzCEdH7xAvnuG0hIkpdDsmBf+azf+AVHfgCP9G4c vn2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745911095; x=1746515895; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Eyfe1YI2mIOVWjgmSEgA1PXm1vkqddx825qOEpXQNV0=; b=Hv0GKXh6lZPgYTNHw2j+Hx3scaNw8LN1F/78G9CTBGx3iRfDwbEA7TRgfJysgtj9Sc 3I6T+QR80QVidE20Yxr8dGf18x9aubVGvOlfT3kSeF4GxuCyMPxOl4JJUtY3cAN4Y4wk FN+fOKGz9L7S20qh3nyJPZHi/deHesitmdjb0kWwugPFjLxczcxVjikrmnP0sk03GWsY pE64HBRptQ2jammD8rBKU2aJPo+jqzSsGAXUjaj+piB6ztWsxLiv2qrSTSfVtaqxDc4Y SC1HVbfdw6pteZDKVqJy/G6NrWluFlKUKlz+7eA6WbHcLVC0QTDqiU4519FknWbu/VUv 96DA== X-Gm-Message-State: AOJu0YzJJEnaAEcraTNhBaIlbiCZCnGza8doObbqrJ9D5SrSImM3zXqk jlNI7QA3cQoxNo6m+OjkDzkrP+zpFRxe8RaVr2IlDRCNMZCmNBuhkUbyGA== X-Gm-Gg: ASbGncv2ojXH2wWkLVqiBLkSrHhG5NEotLUQVF/KSdbdUmQvp5A09ZgdSvrSL5LSJ0n uts4MlvHkVrJzAIA/J/iJ4gO4c6jwGewT3TqGQ8N9f4cwJ9RlQUvDgTqaZZ8bt2VeJBqmyPHP+o vw2/tzbn4PR32y3YrBbgXWwwHCTyU+0XNnO2wN9Wy4HaBwgQvenSGzkVJhXRg0m7pT921Sfwc4q WnP4Exk/qTzkJVyYq3MBlTQNZ21sbcCQpPxxvt2C7Z6Sy8iyUmOAEwy9ulus36h9AQFlF6wYlQO CrdoLxNxHl9SiCZ7RXd4LAXmnN94imubv9oYGa1q6ySeCgy1b2f0a0RaVYpt X-Google-Smtp-Source: AGHT+IFRfFf4dakQhyoNsUljwFjPZptVIHKRl7nlO97TS6dwWuy5zXg8ordoJ8a48OhZZ1pKsnF+BA== X-Received: by 2002:a17:903:2a86:b0:224:1221:1ab4 with SMTP id d9443c01a7336-22dc6a095ccmr214022165ad.22.1745911095287; Tue, 29 Apr 2025 00:18:15 -0700 (PDT) Received: from localhost.localdomain ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4d76f4bsm95399495ad.49.2025.04.29.00.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 00:18:14 -0700 (PDT) From: Maxim Cournoyer To: 73494@debbugs.gnu.org Subject: [PATCH v4 1/3] services: activation: Continue on exceptions. Date: Tue, 29 Apr 2025 16:17:43 +0900 Message-ID: <597361035150296c6051f6f78fc8cc8ff3af8b61.1745911065.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian , Z572 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Hilton Chain Use ‘invoke’ for backtraces and avoid changing environment. * gnu/services.scm (activation-script): Execute activation scripts in ‘invoke’. Warn about failed activation scripts. Change-Id: I89be31433fbb46d0c4a9dc6115ab167910840b6f Signed-off-by: Maxim Cournoyer --- gnu/services.scm | 32 +++++++++++++++++++++++++++----- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/gnu/services.scm b/gnu/services.scm index 8a4002e0724..ed17981ffdd 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -692,15 +692,28 @@ (define* (activation-service->script service) (define (activation-script gexps) "Return the system's activation script, which evaluates GEXPS." (define actions - (map (cut program-file "activate-service.scm" <>) gexps)) + (map (lambda (action) + (program-file "activate-service.scm" + (with-imported-modules (source-module-closure + '((gnu build activation) + (guix build utils))) + #~(begin + (use-modules (gnu build activation) + (guix build utils)) + #$action)))) + gexps)) (program-file "activate.scm" (with-imported-modules (source-module-closure '((gnu build activation) - (guix build utils))) + (guix build utils) + (guix diagnostics) + (guix i18n))) #~(begin (use-modules (gnu build activation) - (guix build utils)) + (guix build utils) + (guix diagnostics) + (guix i18n)) (mkdir-p "/var/run") ;; Make sure the user accounting database exists. If it @@ -719,8 +732,17 @@ (define (activation-script gexps) (activate-current-system) ;; Run the services' activation snippets. - ;; TODO: Use 'load-compiled'. - (for-each primitive-load '#$actions))))) + (for-each (lambda (action) + ;; Don't block activation process when one + ;; action fails. + (catch #t + (lambda () + (invoke action)) + (lambda _ + (warning + (G_ "failed to activate '~a'.~%") + action)))) + '#$actions))))) (define (gexps->activation-gexp gexps) "Return a gexp that runs the activation script containing GEXPS." base-commit: 2b4680c6c17bd6470f78a1f39d2f7af8b05e279f -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 03:18:32 2025 Received: (at 73494) by debbugs.gnu.org; 29 Apr 2025 07:18:32 +0000 Received: from localhost ([127.0.0.1]:47032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9fEe-0008VH-3d for submit@debbugs.gnu.org; Tue, 29 Apr 2025 03:18:32 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:50345) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9fEX-0008TV-EF for 73494@debbugs.gnu.org; Tue, 29 Apr 2025 03:18:27 -0400 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-22c33e5013aso67244685ad.0 for <73494@debbugs.gnu.org>; Tue, 29 Apr 2025 00:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745911099; x=1746515899; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NnwFb4SwueYZqVnITeYzLBrkzbN5D9MX3frq+axuH7c=; b=WG6keXPAQQ+6FDOwupjt9J3i7Ku3kJKdAPKw001xiPasQ2OgU8h7NOTLNxjYUUw3sL hye0rqZsLK1BB2iqpUSmnhcJaGmGFvZV12tGIZjaOZy0W2bMaqaiasur7yueObljlhmX yslAeSkh+T+tL5e8yphWe8iiZ2ri+HSrHPer04nywjKgM69Tma7xrIAmjho2BFwImbwa awhE6rVdJRkhB1sY4tqA8WTKoeEMgktrawQ6RF43DFn19sXZmlnvPfTZs3NOQgBdK73M FtA9WorWXj8VLwkt3Vkd+YTL/htRdvW4TxQa1Kghq9UxcHe3CijhfuptpyjHp+cCyX8F iijA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745911099; x=1746515899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NnwFb4SwueYZqVnITeYzLBrkzbN5D9MX3frq+axuH7c=; b=uJBgHnBa8r7m1T+IXgWH2Zthil434v0DAG2M33bjyo01PtUfCMkC83Fly/YBkxSgnk GLd0YJWSaCjdguS+1S8bJLc8p2OWacITOpgVIABoY5iv0bVAWpf53z8wRiPD6ake1/vY ozjzi0phZ2dpCHomXJ7hwd4vbuBW2t3qeoVChFXKwq2nvJ1IQCvIacLhpDURWaVXU5gc S5q9tugF5zS/PmMRwnj1htKkAhSJdLArWPWPPWr2vkKLirzTmK2QxBy3xKgIo2myrjvX g99VTqbPtZh5TezlB7miaoZmSTp/F9DmiP0aKDww/eWIvmKrfAho45KbFNZFtNjjgcms XJsw== X-Gm-Message-State: AOJu0Ywtoe1rZEiS5q3vthbng0QawwG94WXTQbgPkYseyDrFDjLsiwxE Kb57thCnOOpttUlxjynobbz0KucXnICcovQwPbuzFy7RZSlFqpcATLINLQ== X-Gm-Gg: ASbGnct/aVPvJ7QJeGspPLHzSD/4+kW2zvdX2cw9I4B201wQnY8OnXXR6k0cCZ/rIDH s7Aagiz0Jcxtey9dEikDXjljb9UV05/OILqy2DzK0m9ZFZlCtX0wuqaUmgVvGLPHUDO63kmPKJ2 adlGSbAVKBJ41aGz5gzHyJybAOvQMbhi0E/C9N+xFCLYaVMYl+GL2KGzZpc9Tk8to0nnZDDe6BK TOzVTHi2E02f4+JZ6RAUPWvPc3U8tIRDYVDlIQE28b8iWpJN8vQ/kpQuKW48AajIi+ehXD84ORr saA5Xrohm+F+xvLHW4kWKv8g6mKSrrh0Wj+YG+0yOLAyzs6VIl+LqEBESsoW X-Google-Smtp-Source: AGHT+IERKDigj1RlG5mbgLn2K6DjAy9GeI1AuKtgbaiYluKXh7dNDAXVCFkR2xHoT2/veq6PG6gYGQ== X-Received: by 2002:a17:903:1aab:b0:216:53fa:634f with SMTP id d9443c01a7336-22dc6a8977cmr193501125ad.48.1745911098643; Tue, 29 Apr 2025 00:18:18 -0700 (PDT) Received: from localhost.localdomain ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4d76f4bsm95399495ad.49.2025.04.29.00.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 00:18:17 -0700 (PDT) From: Maxim Cournoyer To: 73494@debbugs.gnu.org Subject: [PATCH v4 2/3] services: cleanup: Bind mount /var/run to /run. Date: Tue, 29 Apr 2025 16:17:44 +0900 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: <597361035150296c6051f6f78fc8cc8ff3af8b61.1745911065.git.maxim.cournoyer@gmail.com> References: <597361035150296c6051f6f78fc8cc8ff3af8b61.1745911065.git.maxim.cournoyer@gmail.com> MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian , Z572 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Hilton Chain * gnu/system/file-systems.scm (%runtime-variable-data) (%runtime-variable-data/bind-mount): New variables. * gnu/system/file-systems.scm (%base-file-systems): Register %runtime-variable-data. * gnu/services.scm (cleanup-gexp): Bind mount /var/run to /run. Remove now extraneous cleanups. * doc/guix.texi (File Systems): Document it. Change-Id: Ie462347935569acddfba68441cf58815a5087cff Modified-by: Maxim Cournoyer --- doc/guix.texi | 7 +++++++ gnu/services.scm | 21 +++++++++++++-------- gnu/services/dbus.scm | 31 ------------------------------- gnu/system/file-systems.scm | 29 +++++++++++++++++++++++++++-- 4 files changed, 47 insertions(+), 41 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 7b418a40892..7c8903dcdf7 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18379,6 +18379,13 @@ File Systems read-write in its own ``name space.'' @end defvar +@defvar %runtime-variable-data +This file system is mounted as @file{/run} and contains system +information data describing the system since it was booted. +@file{/var/run} is bind mounted to @file{/run}, for backward +compatibility. +@end defvar + @defvar %binary-format-file-system The @code{binfmt_misc} file system, which allows handling of arbitrary executable file types to be delegated to user space. This requires the diff --git a/gnu/services.scm b/gnu/services.scm index ed17981ffdd..e07b3c24626 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -628,9 +628,14 @@ (define (system-provenance system) (define (cleanup-gexp _) "Return a gexp to clean up /tmp and similar places upon boot." - (with-imported-modules '((guix build utils)) + (with-imported-modules (source-module-closure + '((guix build utils) + (gnu build file-systems) + (gnu system file-systems))) #~(begin - (use-modules (guix build utils)) + (use-modules (guix build utils) + (gnu build file-systems) + (gnu system file-systems)) ;; Clean out /tmp, /var/run, and /run. ;; @@ -662,17 +667,17 @@ (define (cleanup-gexp _) "/lib/locale")) (setlocale LC_CTYPE "en_US.utf8") (delete-file-recursively "/tmp") - (delete-file-recursively "/var/run") - (delete-file-recursively "/run") ;; Note: The second argument to 'mkdir' is and'ed with umask, ;; hence the 'chmod' calls. (mkdir "/tmp" #o1777) (chmod "/tmp" #o1777) - (mkdir "/var/run" #o755) - (chmod "/var/run" #o755) - (mkdir "/run" #o755) - (chmod "/var/run" #o755)))))) + + ;; XXX: It'd be cleaner if we could simply register + ;; %runtime-variable-data/bind-mount in %base-file-systems, that + ;; fails with: 'statfs-raw: No such file or directory' when + ;; checking for "/run". + (mount-file-system %runtime-variable-data/bind-mount #:root "/")))))) (define cleanup-service-type ;; Service that cleans things up in /tmp and similar. diff --git a/gnu/services/dbus.scm b/gnu/services/dbus.scm index 76e04bf2215..9292172e01a 100644 --- a/gnu/services/dbus.scm +++ b/gnu/services/dbus.scm @@ -190,37 +190,6 @@ (define (dbus-activation config) ;; world-readable. (mkdir-p/perms "/run/dbus" user #o755)) - (catch 'system-error - (lambda () - (symlink "/run/dbus" "/var/run/dbus")) - (lambda args - (let ((errno (system-error-errno args))) - (cond - ((= errno EEXIST) - (let ((existing-name - (false-if-exception - (readlink "/var/run/dbus")))) - (unless (equal? existing-name "/run/dbus") - ;; Move the content of /var/run/dbus to /run/dbus, and - ;; retry. - (let ((dir (opendir "/var/run/dbus"))) - (let loop ((next (readdir dir))) - (cond - ((eof-object? next) (closedir dir)) - ((member next '("." "..")) (loop (readdir dir))) - (else - (begin - (rename-file (string-append "/var/run/dbus/" next) - (string-append "/run/dbus/" next)) - (loop (readdir dir))))))) - (rmdir "/var/run/dbus") - (symlink "/run/dbus" "/var/run/dbus")))) - (else - (format (current-error-port) - "Failed to symlink /run/dbus to /var/run/dbus: ~s~%" - (strerror errno)) - (error "cannot create /var/run/dbus")))))) - (unless (file-exists? "/etc/machine-id") (format #t "creating /etc/machine-id...~%") (invoke (string-append #$(dbus-configuration-dbus config) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 4ea8237c70d..c75ef39377f 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -2,7 +2,7 @@ ;;; Copyright © 2013-2022 Ludovic Courtès ;;; Copyright © 2020 Google LLC ;;; Copyright © 2020 Jakub Kądziołka -;;; Copyright © 2020, 2021 Maxim Cournoyer +;;; Copyright © 2020, 2021, 2025 Maxim Cournoyer ;;; Copyright © 2021 Tobias Geerinckx-Rice ;;; Copyright © 2022 Oleg Pykhalov ;;; @@ -82,6 +82,8 @@ (define-module (gnu system file-systems) %pseudo-terminal-file-system %tty-gid %immutable-store + %runtime-variable-data + %runtime-variable-data/bind-mount %control-groups %elogind-file-systems @@ -448,6 +450,28 @@ (define %immutable-store (check? #f) (flags '(read-only bind-mount no-atime)))) +(define %runtime-variable-data + (file-system + (type "tmpfs") + (mount-point "/run") + (device "tmpfs") + ;; Don't use no-suid here as /run/privileged/bin may contain SUID + ;; executables. + (flags '(no-dev strict-atime)) + (options "mode=0755,nr_inodes=800k,size=20%") + (needed-for-boot? #t) + (check? #f) + (create-mount-point? #t))) + +(define %runtime-variable-data/bind-mount + (file-system + (device "/run") + (mount-point "/var/run") + (type "tmpfs") + (flags '(bind-mount)) + (check? #f) + (create-mount-point? #t))) + (define %control-groups ;; The cgroup2 file system. (list (file-system @@ -497,7 +521,8 @@ (define %base-file-systems %debug-file-system %shared-memory-file-system %efivars-file-system - %immutable-store)) + %immutable-store + %runtime-variable-data)) (define %base-live-file-systems ;; This is the bare minimum to use live file-systems. -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 03:18:33 2025 Received: (at 73494) by debbugs.gnu.org; 29 Apr 2025 07:18:33 +0000 Received: from localhost ([127.0.0.1]:47034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9fEe-0008VK-Qc for submit@debbugs.gnu.org; Tue, 29 Apr 2025 03:18:33 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:52296) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9fEa-0008UB-DK for 73494@debbugs.gnu.org; Tue, 29 Apr 2025 03:18:29 -0400 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-227c7e57da2so47859015ad.0 for <73494@debbugs.gnu.org>; Tue, 29 Apr 2025 00:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745911102; x=1746515902; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HUHzk6qlaLHDtYw2JU9kk+MvMI8WIE0d5Re5Z6OswmU=; b=eHzvAlvcSVCF9dDrGhVfiHV9OxpWYXVCujqxvm8EVa6A9RJPgI1b1ojH1OGQlygAS+ C+duFdKPeiMn7Gx2EHQ10fyX6IASOhn+OO+e6o+g1qzUDoxweyJJ9HPEX/Wuk7MQ6l8b P2NFQp6RPn4OfiYA3hIuvbLkORzTRs1tWgKagwa9Yg6R0Te2h63VfOqW0HWz5DeyzopC Vz4mQOFr94ZvhcynEC6kqbY/aKme0iwo8OyZkNf+0baS86YBV5xUalWjzaSxMluDp9GG oUtX9KR0WJE1V1R/z+3J3Sst3hdoXWnVN3IvYNSUl4vCXHBqN4AkzNDY0W9McucZIWZT V7EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745911102; x=1746515902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HUHzk6qlaLHDtYw2JU9kk+MvMI8WIE0d5Re5Z6OswmU=; b=WH6AJKmWiuIilB/kAv2v7ETmp1gWHT9eQH2wHrOKH3LNuKm/jrlbycTwY87ViUXBkY Tohbk437dMnY3X1Hg18OeAqTYEGDJGVcOQBukFWAwfEf98DTlOxcBdrMzZ46RZo66S0Y vtfYL7Xf9nJ5FNSrNg17zW+HySguKAU71Z8gjSz9lav2f1xWAEeAzX/QgkkLaKScYNt2 eWbTYodDTKgENTkeF4Y5wFE0OjDlyhJQi+0tcduZgjucyhIcG0d/DxuFnH+k5g0FEto3 ixT0tfidjin6yOuHlyjhFTPqU4MBBTnu4unJ5bkZ7QaW6CI2QoF1WJZocCxYcZzexGCU 9ncA== X-Gm-Message-State: AOJu0YwbTbshzYLoVaB09ExbD5yKXerf8Ds4SIzccZa4RT5c+9X46Hv2 J/tP2EnS20d+Ci+xaaSDtNz5rqgZa6oMXEvITKaGkrukLYx6Rtr6PzVutA== X-Gm-Gg: ASbGncstflm7GmKTpnM7kFuJQ2dAB2YzUMjuQAkRZZNXAICYFSqSrEbveA6D9tlwXNi vVjyoQzqZbScuZlvtI1qXLyfksFkBnzEyj6pl4phh4yQVt2dIHfdyIEarawnxB1qiyv+WWIFUDY iPgJbfSaXcW/Zrrm/47eDCzJS9od9E2yM7CIc1DgAe1beiHsueCuWKeen27qdGB+62CBKyTxONq rJ9+dSax3GiPaowZNZCxCfqBWVRKIG3ozpBbCdiNmt5UXvL3RMlQVbxpyXSPWMzFTm1dx9ZO78M DSRNVVFjuj2lN3n70cmu+XMgvVxU1coLXoWw+2ruDYCdD5O+uKc+s3I/3CEd X-Google-Smtp-Source: AGHT+IHKUR8qKZunCdCRf0sDn2y7PFDgaQowTdnDvhdqwfaAQ18VgudOAkxr27lO8Ql2soM22ap1Pw== X-Received: by 2002:a17:902:d491:b0:223:4341:a994 with SMTP id d9443c01a7336-22dc69efa2bmr171221015ad.9.1745911101972; Tue, 29 Apr 2025 00:18:21 -0700 (PDT) Received: from localhost.localdomain ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4d76f4bsm95399495ad.49.2025.04.29.00.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 00:18:21 -0700 (PDT) From: Maxim Cournoyer To: 73494@debbugs.gnu.org Subject: [PATCH v4 3/3] WIP: Fix jami-provisioning test. Date: Tue, 29 Apr 2025 16:17:45 +0900 Message-ID: <7c7e983d742f74cece3bf87fe6e593947dc58a8f.1745911065.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <597361035150296c6051f6f78fc8cc8ff3af8b61.1745911065.git.maxim.cournoyer@gmail.com> References: <597361035150296c6051f6f78fc8cc8ff3af8b61.1745911065.git.maxim.cournoyer@gmail.com> MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian , Z572 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Zheng Junjie , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Zheng Junjie TODO: Investigate why this is needed. Do not commit. Change-Id: I6996b5627d732d1c261ae453da5d0916637b0288 Signed-off-by: Maxim Cournoyer --- gnu/tests/telephony.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/tests/telephony.scm b/gnu/tests/telephony.scm index f03ea963f7e..219cb421647 100644 --- a/gnu/tests/telephony.scm +++ b/gnu/tests/telephony.scm @@ -30,6 +30,7 @@ (define-module (gnu tests telephony) #:use-module (gnu services telephony) #:use-module (guix gexp) #:use-module (guix modules) + #:use-module (gnu services shepherd) #:export (%test-jami %test-jami-provisioning %test-jami-provisioning-partial)) @@ -116,7 +117,9 @@ (define* (make-jami-os #:key provisioning? partial?) (openssh-configuration (permit-root-login #t) (allow-empty-passwords? #t))) - %base-services)) + (service syslog-service-type) + (modify-services %base-services + (delete shepherd-system-log-service-type)))) (packages (cons* (specification->package "recutils") (specification->package "strace") %base-packages)))) -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 12:20:29 2025 Received: (at 73494) by debbugs.gnu.org; 29 Apr 2025 16:20:29 +0000 Received: from localhost ([127.0.0.1]:58982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9nh7-0003zA-9o for submit@debbugs.gnu.org; Tue, 29 Apr 2025 12:20:29 -0400 Received: from mail.boiledscript.com ([2a01:4f8:242:4aeb::42]:58294) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9nh4-0003yz-NJ for 73494@debbugs.gnu.org; Tue, 29 Apr 2025 12:20:27 -0400 Date: Wed, 30 Apr 2025 00:19:55 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1745943625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MSbvrHcyMG1vYSfDs2Zn6V5e/yyeA14Js5mePdvwKEU=; b=SLLZtgiTxDderjVtoZkBC9aMqkOQrYSGe+mHwy4NXQG+2b9w+NU26U9LSGUEHV1a+mWRUc rR/zma342YXTkXdVQZbLguPVzv+fouFVgWa2LCK9Pftmyoq5BZcQAqRJhx/hHEXVpG4EKk 0a2mPOH+ohqg0z8MU9hSi6ZF3FioP842p0XRIegqgT2iU0DDH8TcyTxrCi6aV6ijtX2pMa DN/KP9PAbJG8UOD41FGMUzg3BqkVC06J+ieBzvLmSt8IVKROrcW3TsqNURM31Ki6Flmaps w9PwpAHpupClRQeFFmPmJqlfLY4daWCuagmkDd1x6OlfcK9fox/r8kpe7S6k0Q== Message-ID: <87o6wf3pp0.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH v4 1/3] services: activation: Continue on exceptions. In-Reply-To: <597361035150296c6051f6f78fc8cc8ff3af8b61.1745911065.git.maxim.cournoyer@gmail.com> References: <597361035150296c6051f6f78fc8cc8ff3af8b61.1745911065.git.maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Z572 , Ludovic =?ISO-8859-1?Q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 29 Apr 2025 15:17:43 +0800, Maxim Cournoyer wrote: > > From: Hilton Chain > > Use =A1invoke=A2 for backtraces and avoid changing environment. > > * gnu/services.scm (activation-script): Execute activation scripts in > =A1invoke=A2. > Warn about failed activation scripts. > > Change-Id: I89be31433fbb46d0c4a9dc6115ab167910840b6f > Signed-off-by: Maxim Cournoyer > --- > gnu/services.scm | 32 +++++++++++++++++++++++++++----- > 1 file changed, 27 insertions(+), 5 deletions(-) I think this patch needs updating for 76698. Will take a look later. From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 16:14:01 2025 Received: (at 73494) by debbugs.gnu.org; 2 May 2025 20:14:02 +0000 Received: from localhost ([127.0.0.1]:33691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAwll-0008VQ-GS for submit@debbugs.gnu.org; Fri, 02 May 2025 16:14:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53104) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uAwli-0008Uj-PT for 73494@debbugs.gnu.org; Fri, 02 May 2025 16:13:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAwlZ-0007xX-GY; Fri, 02 May 2025 16:13:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=zyBGjHlwZ1A+Kc4qdzFoxOeAM8CrMpl0wzbNxUBTr5A=; b=UQqljoOFfd/A8vXYUUEV MSIwbcim9KMbMfEpOiZE8bLKqfnWxs7SEL5syoVyeh3ZCFmX/4U5uDr7oiktYe3lNiPUF7OrPsmQc +3K1yz6uNEX0D1VLn2MVzahq3y0e/xfzvUHXVoc8UtzPKN3qsmMPe4T7/GLgypGT829jDTZjh5tXb SieqNva1D3bddnvMo4B2lhj9VI0cvLX7errRDjptbC6U68Q6JXtsCPIrct137e1f404wPX8P1Tc32 PmcdUrXbUwOEsP0wdyr2GGRZjUcRVb2oOtr9aH9qRPT2SB6g/chXTeJbaofcYGFBYkphvr3Lx7Tps EJpk23c0av/1Ug==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH v4 1/3] services: activation: Continue on exceptions. In-Reply-To: <597361035150296c6051f6f78fc8cc8ff3af8b61.1745911065.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Tue, 29 Apr 2025 16:17:43 +0900") References: <597361035150296c6051f6f78fc8cc8ff3af8b61.1745911065.git.maxim.cournoyer@gmail.com> User-Agent: mu4e 1.12.9; emacs 29.4 X-URL: https://people.bordeaux.inria.fr/lcourtes/ X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu X-Revolutionary-Date: Tridi 13 =?utf-8?Q?Flor=C3=A9al?= an 233 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du =?utf-8?Q?B=C3=A2ton-d'or?= Date: Fri, 02 May 2025 18:17:23 +0200 Message-ID: <87y0vf9ecs.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , Hilton Chain , 73494@debbugs.gnu.org, Z572 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) Hello, Maxim Cournoyer writes: > From: Hilton Chain > > Use =E2=80=98invoke=E2=80=99 for backtraces and avoid changing environmen= t. > > * gnu/services.scm (activation-script): Execute activation scripts in > =E2=80=98invoke=E2=80=99. > Warn about failed activation scripts. > > Change-Id: I89be31433fbb46d0c4a9dc6115ab167910840b6f > Signed-off-by: Maxim Cournoyer [...] > ;; Run the services' activation snippets. > - ;; TODO: Use 'load-compiled'. > - (for-each primitive-load '#$actions))))) > + (for-each (lambda (action) > + ;; Don't block activation process when= one > + ;; action fails. > + (catch #t > + (lambda () > + (invoke action)) > + (lambda _ > + (warning > + (G_ "failed to activate '~a'.~%") > + action)))) > + '#$actions))))) As I suggested upthread (or elsewhere? I=E2=80=99m lost!), I think it would= be enough to keep loading these files in the main process (as opposed to spawning one short-lived process for each activation) and simply catch exceptions: (for-each (lambda (file) (guard (c =E2=80=A6) (save-module-excursion =E2=80=A6))) '#$actions) I think it would do what we want while avoiding the overhead. I don=E2=80= =99t think it qualifies as =E2=80=9Cpremature optimization=E2=80=9D because it= =E2=80=99s already in place and the semantics are well-defined. Thoughts? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat May 03 10:23:57 2025 Received: (at 73494) by debbugs.gnu.org; 3 May 2025 14:23:57 +0000 Received: from localhost ([127.0.0.1]:41974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBDmW-0001sh-Fs for submit@debbugs.gnu.org; Sat, 03 May 2025 10:23:57 -0400 Received: from mail.boiledscript.com ([2a01:4f8:242:4aeb::42]:45044) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uBDmS-0001sQ-HY for 73494@debbugs.gnu.org; Sat, 03 May 2025 10:23:53 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1746282230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=WByI1DIdG1bNx0FIIvWgQU2GABJ6bTKmQrDJRPcIi90=; b=YwRt71gtih2SJqrGmmfC0z/ugtA785R/pqpnEC0qgkFJPGpGGzGh6GNkd5HNtMxIYJ1SV7 HT3TRyL2+hG3ZTvzLZigDoGB5sJo4k27Fd5ppvq/Cl3heLABiR7w+8eWcUNGHISi4+tFoM qX1++wkFiHuUZhj0njnmGNCVWUJei48RW4eUBweYFGkqsfq0HJ1mUvQVpHJFmE7B79Qb+l G1Sv4CmDvD0mES8qNE1kRD0zH+Phv/hhs7Wa00bPM8vDmqWHJlxVjLLeCo5enqFByl6812 A6F576dF4YpAeiLe2x0u7LzuY7RH4Pqf1zHgMWbzLxsMzoWZzrUmDRfxRDQw0g== To: 73494@debbugs.gnu.org Subject: [PATCH v5 1/3] services: activation: Continue on exceptions. Date: Sat, 3 May 2025 22:22:55 +0800 Message-ID: MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian , Z572 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services.scm (activation-script): Restore current module after execution. Catch exception and print the error. Warn about failed activation script. Change-Id: I89be31433fbb46d0c4a9dc6115ab167910840b6f --- gnu/services.scm | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/gnu/services.scm b/gnu/services.scm index 8a4002e072..6865c7560f 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -697,10 +697,15 @@ (define (activation-script gexps) (program-file "activate.scm" (with-imported-modules (source-module-closure '((gnu build activation) - (guix build utils))) + (guix build utils) + (guix diagnostics) + (guix i18n))) #~(begin (use-modules (gnu build activation) - (guix build utils)) + (guix build utils) + (guix diagnostics) + (guix i18n) + (srfi srfi-34)) (mkdir-p "/var/run") ;; Make sure the user accounting database exists. If it @@ -720,7 +725,22 @@ (define (activation-script gexps) ;; Run the services' activation snippets. ;; TODO: Use 'load-compiled'. - (for-each primitive-load '#$actions))))) + (for-each (lambda (action) + ;; Don't block activation process when one + ;; action fails. + (guard (condition + (else + (format (current-error-port) "~a~%" + condition) + (warning + (G_ "failed to activate '~a'~%") + action))) + (save-module-excursion + (lambda () + (set-current-module + (resolve-module '(guile-user))) + (primitive-load action))))) + '#$actions))))) (define (gexps->activation-gexp gexps) "Return a gexp that runs the activation script containing GEXPS." base-commit: f76b9c4fdf88cbab81e3cac27841a6c56e3e32c9 prerequisite-patch-id: cc1917ae421a9d5e5e737ab0d7d64eafb80c66ea prerequisite-patch-id: f25b46e1e08ed9a23bafd4547b30559e87aafc83 prerequisite-patch-id: ebfbf78c71e216e14009a9c619502d515bd301e9 prerequisite-patch-id: 4debf0c53a034e80221112c95ed3572f436ed5b6 prerequisite-patch-id: 4e2979d172c82620e1f423201034aa00610ea22f prerequisite-patch-id: c411a74b430b78540a70d5516623bd92508e1505 prerequisite-patch-id: eb5d2e8f4679f970898c2b0f1a0caf6dc941712a prerequisite-patch-id: 1ad337c9c9741592793782f97db490bba02d3c4b prerequisite-patch-id: 9cdff9105c25033e7eabe7e3af945b73a6e27baf prerequisite-patch-id: 9c9fb5429cf6568ca848ab804448a2149f861dcd prerequisite-patch-id: a5c937590b38c4fb5c75a5098f15d2d3d0825a1d prerequisite-patch-id: fc9f5e958c9f6fcd546278cb2682c0eada7fe99c prerequisite-patch-id: a1f459ba99139e5a6c6948f9ce783f4e2fa96131 prerequisite-patch-id: 663bb408102bcb62ea42fe8d36ef68c1aacf677a prerequisite-patch-id: 47cad111e0bfc95219c9884929699f8976defa8d prerequisite-patch-id: 4c10ae2199d139567a4ac6a22826824d009087b2 prerequisite-patch-id: 6622dcd13c5613309b5a13b4afcc409071940e73 prerequisite-patch-id: 56f9b4474c3aed2ce6b70db5dbf2dddc65636e84 prerequisite-patch-id: 22ae8c4ef90cc288ad4708d82fc01eb51ac751c7 prerequisite-patch-id: 425ed1686582d84d0dd9413e1f599a1154a96cf8 prerequisite-patch-id: e04b6297ce6f820e5a85ed4536d031cd3e6ec4eb prerequisite-patch-id: 0b35242341e3757c7c4bd1ca9f2cdf25e277d14f prerequisite-patch-id: ce9b1c2e1ae5360fd5251fd07de5ba268ddaef7a prerequisite-patch-id: b5225a119bad4fdf39d06f5701e3e49ffc066998 prerequisite-patch-id: 6d4f77830ff3ebda5ed6c7f44418d6408b31a37b prerequisite-patch-id: 5cb39fe4ecd79203f047f28213fba8e02a848c56 prerequisite-patch-id: 387e1203c97c955dfb5401e0aea691728efdc8ec prerequisite-patch-id: 6b92abaf6d03b37b9c58bb31285976020b8e2660 prerequisite-patch-id: 56445d57ac941146c2072128c1687464e368c3a6 prerequisite-patch-id: 530734d3059fda18c4c451205f9d87f00082311c prerequisite-patch-id: f3d353c1a0485f92f2a6c4313d81658f221eb1e0 prerequisite-patch-id: 8b69b664302b49b18bd1471896caa8cde85d47aa prerequisite-patch-id: b6b409d970f76ec2d7e5c7afe8b9cffa098d9ed9 prerequisite-patch-id: c95d325c498d84ccfa0e89d4203f382c96d69e94 prerequisite-patch-id: 392d2d9a75b67487c555ec8ba3a4421e876e439a prerequisite-patch-id: ba73d2e1125336400aa53df28bba9f8abadf8160 prerequisite-patch-id: daede4456cc6b3762235fb18cf66358fa7753c6c prerequisite-patch-id: 72156f437e320f38d277a77acc6c01028a9e4478 prerequisite-patch-id: 275225a32b3c0e811f8d29f7553b1e2564bf05c1 prerequisite-patch-id: 5cda15241e08cc131f2a9e2dad6fadf7cb9aa401 prerequisite-patch-id: 35ab532c7ebece8b456f887db0b73d6c4ecf6123 prerequisite-patch-id: 408888e0206e5b48ffe7ee3cdb310cbd60af6c9d prerequisite-patch-id: 21823b7c985ebd2c8fe851dee70e6ee446d52722 prerequisite-patch-id: 58104871305201643f59467c8099ccb0d81e9b46 prerequisite-patch-id: 5a24da7fc42b031cb7ba6a8e357bc5784eb1eeb8 prerequisite-patch-id: 6cfcc714847ea9f1cdbaa383a4627748e7489c0b prerequisite-patch-id: c7df92a41a01831efd7d95b768a86792237d27e8 prerequisite-patch-id: 8231dfd1b56d91e60552f1c69eaecfdb80d56d0e prerequisite-patch-id: 615a0e10ba14ea1ad96e4400c010897969286d4f prerequisite-patch-id: 7e751f2eea2a12308b31912317f362dca5eedb2d prerequisite-patch-id: 5ef7b38b8ff16a89acc64aa0b081667e2eab7f59 prerequisite-patch-id: 9f7a85f3af0e0de60a15c53fcc2e7312504b22da prerequisite-patch-id: 4f54871424a11496b6f22047879b7b1a879cdd0b prerequisite-patch-id: 5f587eb497b401e4d1cb36ef125a2ad771383d94 prerequisite-patch-id: 3fe2d0a7bec6162ae31bea45170c7a08c74aef03 prerequisite-patch-id: 6822c6afc981afcc328a8038acf108936f3c2ad5 prerequisite-patch-id: aa54cee74f45c3bb993390f27193ded97f1c1ba4 prerequisite-patch-id: c8240934ebb565784a0fc1e71ffad3c4044f6fc0 prerequisite-patch-id: 7b3bb6304aaaec5d1e274a67d974de67235452e6 prerequisite-patch-id: 7d14bd158b6175ca2916a61d766098074b143b86 prerequisite-patch-id: b1e103461e0cde61d52f926bc32a08c17bd17d91 prerequisite-patch-id: 5c21ad1387f40f38112e4338f1a312335bcdcdaa prerequisite-patch-id: ba2bf871c24b0b3fc05a667e10aedacef9aade39 prerequisite-patch-id: 52ab7ff09e74a4907a71c58c8650d2ae2072507f prerequisite-patch-id: bbb0491c7dc5558dfcf61ba5915d9ad012603964 prerequisite-patch-id: fc52339c9691de95241ea1e4369b57da5c441305 prerequisite-patch-id: 5beb416f1849eb118a8c93d2d03ac27421f08595 prerequisite-patch-id: 850d5ee576bfe0a0c7748191f8bce69b182563ab prerequisite-patch-id: 90722f3add5e2fcc1ffc8b4949f05f7177c19df5 prerequisite-patch-id: 71f74cca72acd19e7a376d54b513b449ddf09035 prerequisite-patch-id: 9fca97c11c8f8610c90ec65212415174a5f4d27f prerequisite-patch-id: 8053b17aa3e33a530e6b0d37badd49ee7a4db2b0 prerequisite-patch-id: f598c9df66d0b752ee63c6730878febbab2a4ab5 prerequisite-patch-id: ae8e3ea6167758962874d9ceefb17cbfc9cd7617 prerequisite-patch-id: 49565ed5626e3cec6c489d1b6fa15a267fd46f03 prerequisite-patch-id: a8ed40466ed7f9e7527af1f10d69618a88169618 prerequisite-patch-id: 106fa00c2c8f69a514960e08701f44040c581844 prerequisite-patch-id: 53ea387ee17ac942f8270920b53033020731f460 prerequisite-patch-id: 14f7b49fc8ec1630c683b5e001b8c2ebf85ce1ba prerequisite-patch-id: f095ac3675af165fb246161e06589ace2875ff3f prerequisite-patch-id: dc224dc9c801c3210385e736b2a528f0b68afb45 prerequisite-patch-id: 6e1ab62a449d025fc4818aa99293b3e9156bef85 prerequisite-patch-id: 1f35d1a714a8cd90cbae9e73a7e453202109d9ed prerequisite-patch-id: 8cb1e632d490cede7604d7257038e1e426a8161f prerequisite-patch-id: 515e8ecd478fe4c1310b9b216e8ea42afd926755 prerequisite-patch-id: b60a2334fa8f170ea438edb187f4d8be9368207c prerequisite-patch-id: f0c49685e76400d3f64afedcbfa0b8fb7c45f0ee prerequisite-patch-id: b057f699ecb836566cf28875aa42295f37f6dbb7 prerequisite-patch-id: e05e6e7a1ed5ab6147c519f3ac36cd8f940a96a7 prerequisite-patch-id: ed0aced460ded457e9cfb41888dbfec3a25ed6d2 prerequisite-patch-id: 831f8c91f388bcecc0a034fede60158c5f1cccc8 prerequisite-patch-id: a5727ce793701715b7d0a4682d05d023d254f360 prerequisite-patch-id: c2b41659d7d020860185d57381e96ba441f2b779 prerequisite-patch-id: 15d4803752c74f543d3b745d61f86d467b89985c prerequisite-patch-id: 34df6318e5191dec8c1e3f2a0c8f2050e5833f7d prerequisite-patch-id: a1d9f6e8f6161e30b3cd11daa26a34b38b7b1658 prerequisite-patch-id: 3bb01cdf4161cb014244f345d2aca3a938188eb8 prerequisite-patch-id: 6c902676ca56fb76bbfc1368ad30e483bc2c94b7 prerequisite-patch-id: ad4774cf4068760dd724ed1a0d6742b5509042f2 prerequisite-patch-id: 3788e077c27eb99e1799b9a0c5c408e0f864bf2c prerequisite-patch-id: bcbaa96fcd93929f76f14ace875131c2bc4dae58 prerequisite-patch-id: 8113d0eea6ce2db54089db233b1de6d3bb5f69b8 prerequisite-patch-id: b5e000ca84ff45d17becf29a255c23270f46cf8e prerequisite-patch-id: 1be61c03da01808178b244c961536595d68b0b06 prerequisite-patch-id: 482d1be0fcbf2870d1f62dc36541e4c4e1f8b11a prerequisite-patch-id: e04264a9dd5a997604f738caaaebd72855ea957a prerequisite-patch-id: 386b738a5326bc9c1bb85cd0749373d8be5ee576 prerequisite-patch-id: aea5ef9868b8f1e5816859411bfc540e34f9f48d prerequisite-patch-id: f964e86b1b95a9b42399246681a7dadd85b5c187 prerequisite-patch-id: f6dba43ca3b68af313363c6fef72785d457a0667 prerequisite-patch-id: 5aff308e00a975de66f8706a10f76f2c9faa6af8 prerequisite-patch-id: 97b70657b34fe0e82da07aeb5f64957ccfda1442 prerequisite-patch-id: 57ccd7f162b05697106c297f7d76abf0de11e18e prerequisite-patch-id: 33a8250abf7eeeda92945a647dbea327647e8455 prerequisite-patch-id: 32a51f7bc1baf5cf58397fd0c99bb85b36de9830 prerequisite-patch-id: 3212ab9cf9c4e1dac5c5ced21ce46b126cbfa1cb prerequisite-patch-id: 211bd0d1a9e6b293f491eced9e4af9843bf3b287 prerequisite-patch-id: 9883bd0d0c6755d6c4e3e3187d89aa072b0b97af prerequisite-patch-id: d1157e346fb2aabee7d7c169f44f4ab0bf005c4c prerequisite-patch-id: 43fd2d4ade95aebf0723d0e5015efd26533617d3 prerequisite-patch-id: 5c4cee47c975c28c734dde626519abc41933b195 prerequisite-patch-id: b18bb968707bfadfe1ecc1487c89dfd436479aee prerequisite-patch-id: e80367a498f5a20eb853973f611d2f69e5ebc5ee prerequisite-patch-id: c5fd8e7f7f96c87ea0e3827faffa07fa71304728 prerequisite-patch-id: cfc02bc484870a43f2c804fa849abbc3f0512d50 prerequisite-patch-id: 2e03948dc975c98730ac3814ed5702acca7a6fdf prerequisite-patch-id: 6cd3353026dafeb79460257c2e60703554a447c5 prerequisite-patch-id: 4111053abab6f41ebda2958d4d7d73ea16eb5283 prerequisite-patch-id: be434332d589b9075b1ac1367c3fd3aa98cf767e prerequisite-patch-id: eb1ad1c2b4bc1ae02ca7a1d1c4935d5c8e7387db prerequisite-patch-id: be03d391071cf7080a0bd0e306f5bca71171071b prerequisite-patch-id: 4174704d944afa67dd97270c34eda6e9e3af8a2b prerequisite-patch-id: 849103845d254fc50290a02e597e76977cc27bc9 prerequisite-patch-id: e34ea950e22895e60f0c6785a61a26c30f5b5b7c prerequisite-patch-id: 2901b0d5cc3c44b1a2cac1b0389cc905f552ae73 prerequisite-patch-id: 61f4d2df2b695a9a7bca127e8abb406f87f6bcbd prerequisite-patch-id: 1c0de8f100ef0d2b0c087cacf3e61d426d17355e prerequisite-patch-id: c0f22ac952516dc9c92767c1b1362d2c7ecde0f8 prerequisite-patch-id: e945542c050b7792775e301930ee4aca13f19ef5 prerequisite-patch-id: dd90058fdafed0cfabe398f2f4685a9c06f48102 prerequisite-patch-id: 55c89258f5b3aab45902904aab1198994012c546 prerequisite-patch-id: 6bae0c4b7d121accaf1b772fc8eef9011f6290cc prerequisite-patch-id: d8993f4ad264e89c3e3c8417b309798382532bec prerequisite-patch-id: 13e40673865c0f57e5b8be99047166ed82250e3f prerequisite-patch-id: 38c9ea11080cc107addf8eb43fed800fec7e650c prerequisite-patch-id: 43d07afd567e55d35643c2a59bfd27a88c5b8c33 prerequisite-patch-id: 3a87236411d1231ff88579e2049db124dfb13fbc prerequisite-patch-id: 0d323a6fdd6b3f4d7ff54eeb161d8d1aec5c3095 prerequisite-patch-id: 27c6d434d2ce44528cd18e35a6e35e1519356f4f prerequisite-patch-id: ca6c92c390a3088479121fe41529bbaa50e696d1 prerequisite-patch-id: 5b60c7f4831891c18dbf65a02cfc3f2128450b23 prerequisite-patch-id: 13158067cff07251a1beee6337a6fda6abd065b7 prerequisite-patch-id: 92fa2a1323787511222459ff6304e1ec89e1dca9 prerequisite-patch-id: a2374551976025342d152f9cb2997c2df43e69d1 prerequisite-patch-id: 372afb9a7bcfbaa7c2db0093b7a9cf68e5b6fefd prerequisite-patch-id: a3b0542e81db2a78bb0cfa478e2fc350b5cbdf96 prerequisite-patch-id: dd6cfd93eb2401fc7d7855c8d9323d39ab8fe605 prerequisite-patch-id: a585bc3d58dfa3366a71b89d46c9d49ce3ddebb1 prerequisite-patch-id: dd7459c37315f6394c6813673f5447f9f5561dd2 prerequisite-patch-id: cf5d250aaad218c44cc6c83f6fb289754de96602 prerequisite-patch-id: 511b60f1388e57dc1a7fabcba4e79eb0a7ace588 prerequisite-patch-id: 4467b67459fe5bb46df30eabd9488139f2f999be prerequisite-patch-id: cbad6cb30c3ea52876c2f16cb1602f5cb7d686f4 prerequisite-patch-id: b1a6a2bfda1255caa968436ecc4ba62e2ed0255d prerequisite-patch-id: 6e17d044199dd8b53d8453df2f41ce2404d4838a prerequisite-patch-id: 9be0aab247366f6db440d26cdab7579466d1f0bf prerequisite-patch-id: 93f8e6f53779eaaee1a12472f5bb845e18c74a6a prerequisite-patch-id: cb3ac50fb870cf197a4e3ed2ccfb45a6a28400f1 prerequisite-patch-id: 2579801cc89f3e3e022074a0425fba3d38bbe1de prerequisite-patch-id: 7174912f7b05011468bc47b2ba8167b0e617a70b prerequisite-patch-id: 08fa38ca1e61c773052671339b78799f19fb7f60 prerequisite-patch-id: b68df6ad7528101d3fbb1fd44f94472a9c8f4f0a prerequisite-patch-id: 58297e005e4ad0988bd5dc73cd0149637d5c7032 prerequisite-patch-id: 2c09773480fbfd323433986ec528fcb8019273f9 prerequisite-patch-id: e2846320c8b391ff3fec09e51c31578ee6057268 prerequisite-patch-id: 538047ea2f029dd135319c02ba569c4aab9af38d prerequisite-patch-id: 4fb73799b5ea902d69ecf15b72e1fecc9903d0bc prerequisite-patch-id: a3a0146e6686bf6f7804192e1a383239c118717b prerequisite-patch-id: 8de6616d86785be0088bc210202d375b6d0cf5eb prerequisite-patch-id: 2f32dcab8b97a4fd210ab5b29b6ebf327861be36 prerequisite-patch-id: 081be41a50854a1397ad6574d995ba444b927a7f prerequisite-patch-id: 2a631555713d3b74f953673f94877e579045f99c prerequisite-patch-id: b3d778b43f667e73692e1bd8b8945eaf69540fda -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Sat May 03 10:23:59 2025 Received: (at 73494) by debbugs.gnu.org; 3 May 2025 14:23:59 +0000 Received: from localhost ([127.0.0.1]:41976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBDmY-0001su-DB for submit@debbugs.gnu.org; Sat, 03 May 2025 10:23:59 -0400 Received: from mail.boiledscript.com ([2a01:4f8:242:4aeb::42]:45050) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uBDmV-0001sa-A0 for 73494@debbugs.gnu.org; Sat, 03 May 2025 10:23:56 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1746282234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sal8SDRuIHwT7zsIU6PojSGHVB2VF9Bdobkupid51Co=; b=ZRvjqtcR62Q4Fe48CbH4opzgdIgjqPsPsM6q5CejIuvKiuhArDyBtRJ4SrFQdOllCBBsHM 77SOGsK58u4lePBb7s19MoD2O7EBR1O8WCM6/8kNWrGXkTWiLPoEDWAc5DOy5j1MEd4e0R 8WOg/1KyZnfoJerJrBcjUhpqhDossea8P/Hp8jvfgM1OSJO6R2deRlTjWmU8yj9sKtxY3V dfRQZfvug789yCtUz76zh2uaCGgOc1/XyD5lvKG7DXQRdi6lvaJm2RF2u3/MjDyU8rmKRw phAZAjftnOw4CB3s8SHuDZpkcLQUV7uE/zRDM9m4QKJ74lyoyHZbrDAaeEFrhg== To: 73494@debbugs.gnu.org Subject: [PATCH v5 2/3] services: cleanup: Bind mount /var/run to /run. Date: Sat, 3 May 2025 22:22:56 +0800 Message-ID: <4b536e1414e4c6f62e0bdaea88fe3c809c06de87.1746281900.git.hako@ultrarare.space> In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian , Z572 , Gabriel Wicki Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/system/file-systems.scm (%runtime-variable-data) (%runtime-variable-data/bind-mount): New variables. * gnu/system/file-systems.scm (%base-file-systems): Register %runtime-variable-data. * gnu/services.scm (cleanup-gexp): Bind mount /var/run to /run. Remove now extraneous cleanups. * doc/guix.texi (File Systems): Document it. Change-Id: Ie462347935569acddfba68441cf58815a5087cff Modified-by: Maxim Cournoyer --- doc/guix.texi | 7 +++++++ gnu/services.scm | 21 +++++++++++++-------- gnu/services/dbus.scm | 31 ------------------------------- gnu/system/file-systems.scm | 29 +++++++++++++++++++++++++++-- 4 files changed, 47 insertions(+), 41 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 0537cae87d..eb8dd39c89 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18383,6 +18383,13 @@ File Systems read-write in its own ``name space.'' @end defvar +@defvar %runtime-variable-data +This file system is mounted as @file{/run} and contains system +information data describing the system since it was booted. +@file{/var/run} is bind mounted to @file{/run}, for backward +compatibility. +@end defvar + @defvar %binary-format-file-system The @code{binfmt_misc} file system, which allows handling of arbitrary executable file types to be delegated to user space. This requires the diff --git a/gnu/services.scm b/gnu/services.scm index 6865c7560f..700966c4c2 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -628,9 +628,14 @@ (define (system-provenance system) (define (cleanup-gexp _) "Return a gexp to clean up /tmp and similar places upon boot." - (with-imported-modules '((guix build utils)) + (with-imported-modules (source-module-closure + '((guix build utils) + (gnu build file-systems) + (gnu system file-systems))) #~(begin - (use-modules (guix build utils)) + (use-modules (guix build utils) + (gnu build file-systems) + (gnu system file-systems)) ;; Clean out /tmp, /var/run, and /run. ;; @@ -662,17 +667,17 @@ (define (cleanup-gexp _) "/lib/locale")) (setlocale LC_CTYPE "en_US.utf8") (delete-file-recursively "/tmp") - (delete-file-recursively "/var/run") - (delete-file-recursively "/run") ;; Note: The second argument to 'mkdir' is and'ed with umask, ;; hence the 'chmod' calls. (mkdir "/tmp" #o1777) (chmod "/tmp" #o1777) - (mkdir "/var/run" #o755) - (chmod "/var/run" #o755) - (mkdir "/run" #o755) - (chmod "/var/run" #o755)))))) + + ;; XXX: It'd be cleaner if we could simply register + ;; %runtime-variable-data/bind-mount in %base-file-systems, that + ;; fails with: 'statfs-raw: No such file or directory' when + ;; checking for "/run". + (mount-file-system %runtime-variable-data/bind-mount #:root "/")))))) (define cleanup-service-type ;; Service that cleans things up in /tmp and similar. diff --git a/gnu/services/dbus.scm b/gnu/services/dbus.scm index 76e04bf221..9292172e01 100644 --- a/gnu/services/dbus.scm +++ b/gnu/services/dbus.scm @@ -190,37 +190,6 @@ (define (dbus-activation config) ;; world-readable. (mkdir-p/perms "/run/dbus" user #o755)) - (catch 'system-error - (lambda () - (symlink "/run/dbus" "/var/run/dbus")) - (lambda args - (let ((errno (system-error-errno args))) - (cond - ((= errno EEXIST) - (let ((existing-name - (false-if-exception - (readlink "/var/run/dbus")))) - (unless (equal? existing-name "/run/dbus") - ;; Move the content of /var/run/dbus to /run/dbus, and - ;; retry. - (let ((dir (opendir "/var/run/dbus"))) - (let loop ((next (readdir dir))) - (cond - ((eof-object? next) (closedir dir)) - ((member next '("." "..")) (loop (readdir dir))) - (else - (begin - (rename-file (string-append "/var/run/dbus/" next) - (string-append "/run/dbus/" next)) - (loop (readdir dir))))))) - (rmdir "/var/run/dbus") - (symlink "/run/dbus" "/var/run/dbus")))) - (else - (format (current-error-port) - "Failed to symlink /run/dbus to /var/run/dbus: ~s~%" - (strerror errno)) - (error "cannot create /var/run/dbus")))))) - (unless (file-exists? "/etc/machine-id") (format #t "creating /etc/machine-id...~%") (invoke (string-append #$(dbus-configuration-dbus config) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 4ea8237c70..c75ef39377 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -2,7 +2,7 @@ ;;; Copyright © 2013-2022 Ludovic Courtès ;;; Copyright © 2020 Google LLC ;;; Copyright © 2020 Jakub Kądziołka -;;; Copyright © 2020, 2021 Maxim Cournoyer +;;; Copyright © 2020, 2021, 2025 Maxim Cournoyer ;;; Copyright © 2021 Tobias Geerinckx-Rice ;;; Copyright © 2022 Oleg Pykhalov ;;; @@ -82,6 +82,8 @@ (define-module (gnu system file-systems) %pseudo-terminal-file-system %tty-gid %immutable-store + %runtime-variable-data + %runtime-variable-data/bind-mount %control-groups %elogind-file-systems @@ -448,6 +450,28 @@ (define %immutable-store (check? #f) (flags '(read-only bind-mount no-atime)))) +(define %runtime-variable-data + (file-system + (type "tmpfs") + (mount-point "/run") + (device "tmpfs") + ;; Don't use no-suid here as /run/privileged/bin may contain SUID + ;; executables. + (flags '(no-dev strict-atime)) + (options "mode=0755,nr_inodes=800k,size=20%") + (needed-for-boot? #t) + (check? #f) + (create-mount-point? #t))) + +(define %runtime-variable-data/bind-mount + (file-system + (device "/run") + (mount-point "/var/run") + (type "tmpfs") + (flags '(bind-mount)) + (check? #f) + (create-mount-point? #t))) + (define %control-groups ;; The cgroup2 file system. (list (file-system @@ -497,7 +521,8 @@ (define %base-file-systems %debug-file-system %shared-memory-file-system %efivars-file-system - %immutable-store)) + %immutable-store + %runtime-variable-data)) (define %base-live-file-systems ;; This is the bare minimum to use live file-systems. -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Sat May 03 10:24:01 2025 Received: (at 73494) by debbugs.gnu.org; 3 May 2025 14:24:01 +0000 Received: from localhost ([127.0.0.1]:41979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBDmb-0001t9-5R for submit@debbugs.gnu.org; Sat, 03 May 2025 10:24:01 -0400 Received: from mail.boiledscript.com ([2a01:4f8:242:4aeb::42]:45054) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uBDmY-0001ss-RG for 73494@debbugs.gnu.org; Sat, 03 May 2025 10:23:59 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1746282237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnivMKwX4oAX6D86QppmjsudQiGF7Hv9GNhRpl5J8lE=; b=kv/wk42lik/AeweC7A8CJmWo6kojdaTdRt53g5JgO8S8xFjWq29K+RJIMpfSagI/TVDAby 7YolGq+hq/+Ng9DSYyRawaxoBMqQ41ZtLGxlljvFDaXPeQIWHTmCWyoWQbERHSj//tNjZ/ mOWrGQzbAt4EMc3klzR5RneNmyH4oEyRh7MqB1jmc+MluiDBd/qrlVKCxXSe+4ky6yOLmy w+yRr9hnAJxIpzwoJjAh9sh05JA+XIdev9wy6JpDeCEam2JyDFOjM5MHqWne+zmUeVw4X7 Rr87Bb/hyigzcyezsJ6xibKM23bLwd0lRJGLfhfx3c5kFwBHfIJ9VLb1NoLGBQ== To: 73494@debbugs.gnu.org Subject: [PATCH v5 3/3] WIP: Fix jami-provisioning test. Date: Sat, 3 May 2025 22:22:57 +0800 Message-ID: <5041c77cf40adcf8bf500ccc7c413f762d5a8355.1746281900.git.hako@ultrarare.space> In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian , Z572 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Zheng Junjie , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Zheng Junjie TODO: Investigate why this is needed. Do not commit. Change-Id: I6996b5627d732d1c261ae453da5d0916637b0288 Signed-off-by: Maxim Cournoyer --- gnu/tests/telephony.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/tests/telephony.scm b/gnu/tests/telephony.scm index f03ea963f7..219cb42164 100644 --- a/gnu/tests/telephony.scm +++ b/gnu/tests/telephony.scm @@ -30,6 +30,7 @@ (define-module (gnu tests telephony) #:use-module (gnu services telephony) #:use-module (guix gexp) #:use-module (guix modules) + #:use-module (gnu services shepherd) #:export (%test-jami %test-jami-provisioning %test-jami-provisioning-partial)) @@ -116,7 +117,9 @@ (define* (make-jami-os #:key provisioning? partial?) (openssh-configuration (permit-root-login #t) (allow-empty-passwords? #t))) - %base-services)) + (service syslog-service-type) + (modify-services %base-services + (delete shepherd-system-log-service-type)))) (packages (cons* (specification->package "recutils") (specification->package "strace") %base-packages)))) -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Sat May 03 10:39:22 2025 Received: (at 73494) by debbugs.gnu.org; 3 May 2025 14:39:22 +0000 Received: from localhost ([127.0.0.1]:42118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBE1R-0002mE-It for submit@debbugs.gnu.org; Sat, 03 May 2025 10:39:22 -0400 Received: from mail.boiledscript.com ([49.12.134.184]:50612) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uBE1O-0002lr-8Y for 73494@debbugs.gnu.org; Sat, 03 May 2025 10:39:19 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1746283156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=A35hReIphueLp4780qm3YeTXhvPe//rP+T3l7O8fBvw=; b=C72TGmQJwnUVmCMYicAOJiNnhdRFSSI3BuUllrsjvGzomIx5v6Qp+A+LoteSsyT/fS96DU YZnqqMLO1EV/m2D/yaanL5fNtsjwrj0PhETsWxUD3nblCDVBQZkuOFdjVh4guSg3O+r5Qn 9tgc6miJQnG2mHx+nffZEhFlgX2HSb2r0mEcn3LWRQgg5uwBMe9knNEKUT5x1XMcWLjDdl hNy8tqBa8Henfw71Y8eaNrYxvGfqjt8gn3yW5AExnwKxKYGqVBygpFnzX/i1GBYGDhtKWK 25GSKmsvfktLA0pG46oedhp3IcnywLqwkAzu6YSPmzj6L+MllKNsHl4OQ9rNzQ== To: 73494@debbugs.gnu.org Subject: [PATCH v6 1/3] services: activation: Continue on exceptions. Date: Sat, 3 May 2025 22:38:28 +0800 Message-ID: MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian , Z572 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services.scm (activation-script): Reset environment before loading activation script. Catch exception and print the error. Warn about failed activation script. Change-Id: I89be31433fbb46d0c4a9dc6115ab167910840b6f --- gnu/services.scm | 39 +++++++++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/gnu/services.scm b/gnu/services.scm index 8a4002e072..af054339fd 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -692,15 +692,31 @@ (define* (activation-service->script service) (define (activation-script gexps) "Return the system's activation script, which evaluates GEXPS." (define actions - (map (cut program-file "activate-service.scm" <>) gexps)) + ;; TODO: Instead of importing modules here, let users of activation service + ;; add them explicitly. See . + (map (lambda (action) + (program-file "activate-service.scm" + (with-imported-modules (source-module-closure + '((gnu build activation) + (guix build utils))) + #~(begin + (use-modules (gnu build activation) + (guix build utils)) + #$action)))) + gexps)) (program-file "activate.scm" (with-imported-modules (source-module-closure '((gnu build activation) - (guix build utils))) + (guix build utils) + (guix diagnostics) + (guix i18n))) #~(begin (use-modules (gnu build activation) - (guix build utils)) + (guix build utils) + (guix diagnostics) + (guix i18n) + (srfi srfi-34)) (mkdir-p "/var/run") ;; Make sure the user accounting database exists. If it @@ -720,7 +736,22 @@ (define (activation-script gexps) ;; Run the services' activation snippets. ;; TODO: Use 'load-compiled'. - (for-each primitive-load '#$actions))))) + (for-each (lambda (action) + ;; Don't block activation process when one + ;; action fails. + (guard (condition + (else + (format (current-error-port) "~a~%" + condition) + (warning + (G_ "failed to activate '~a'~%") + action))) + (save-module-excursion + (lambda () + (set-current-module + (make-fresh-user-module)) + (primitive-load action))))) + '#$actions))))) (define (gexps->activation-gexp gexps) "Return a gexp that runs the activation script containing GEXPS." base-commit: 415e3d98d6faf5fd3d1b7b3daa2f20636e4ff822 prerequisite-patch-id: cb3ac50fb870cf197a4e3ed2ccfb45a6a28400f1 prerequisite-patch-id: 2579801cc89f3e3e022074a0425fba3d38bbe1de prerequisite-patch-id: 7174912f7b05011468bc47b2ba8167b0e617a70b prerequisite-patch-id: 08fa38ca1e61c773052671339b78799f19fb7f60 prerequisite-patch-id: b68df6ad7528101d3fbb1fd44f94472a9c8f4f0a prerequisite-patch-id: 58297e005e4ad0988bd5dc73cd0149637d5c7032 prerequisite-patch-id: 2c09773480fbfd323433986ec528fcb8019273f9 prerequisite-patch-id: e2846320c8b391ff3fec09e51c31578ee6057268 prerequisite-patch-id: 538047ea2f029dd135319c02ba569c4aab9af38d prerequisite-patch-id: 4fb73799b5ea902d69ecf15b72e1fecc9903d0bc prerequisite-patch-id: a3a0146e6686bf6f7804192e1a383239c118717b prerequisite-patch-id: 8de6616d86785be0088bc210202d375b6d0cf5eb prerequisite-patch-id: 2f32dcab8b97a4fd210ab5b29b6ebf327861be36 prerequisite-patch-id: 081be41a50854a1397ad6574d995ba444b927a7f prerequisite-patch-id: 2a631555713d3b74f953673f94877e579045f99c prerequisite-patch-id: b3d778b43f667e73692e1bd8b8945eaf69540fda -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Sat May 03 10:39:24 2025 Received: (at 73494) by debbugs.gnu.org; 3 May 2025 14:39:24 +0000 Received: from localhost ([127.0.0.1]:42121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBE1U-0002mS-4K for submit@debbugs.gnu.org; Sat, 03 May 2025 10:39:24 -0400 Received: from mail.boiledscript.com ([2a01:4f8:242:4aeb::42]:58328) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uBE1S-0002m6-4X for 73494@debbugs.gnu.org; Sat, 03 May 2025 10:39:22 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1746283160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KP8lDAIMcsizeYgeZgTk67WVPAtf4yakFpsgydngz7w=; b=Pv+PRLtYjK7ucGCotD4B0bPJ98YnoBxmH7EPx4txi7DjumkH9EvWZLln+BY8lve/NVp+ZB nYJw83UtnJ4dFaD+pDCNc5ltKm6xExgunwlFAD3nHL12CcJx4dzN1tQc53q/FMdB8G9x9+ GRUUdb2uDUkikASl8EWrk9elcIGvPUiJBJrlbIdKTKdTr2CaO7faUXuqL8hLdn1cmOPdWc yVdwNSeivDluBA3PDeRa5kwSeIpaoPSk345BqpQZf0oodkNuJ82RgxnMniXZ9rlpI9tvHv sw25ivjCVZlWkZE+X97zgroRaADJkOJcvXs0HDOW3cMu8jD79Kho8OWFtJlWoQ== To: 73494@debbugs.gnu.org Subject: [PATCH v6 2/3] services: cleanup: Bind mount /var/run to /run. Date: Sat, 3 May 2025 22:38:29 +0800 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian , Z572 , Gabriel Wicki Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Hilton Chain , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/system/file-systems.scm (%runtime-variable-data) (%runtime-variable-data/bind-mount): New variables. * gnu/system/file-systems.scm (%base-file-systems): Register %runtime-variable-data. * gnu/services.scm (cleanup-gexp): Bind mount /var/run to /run. Remove now extraneous cleanups. * doc/guix.texi (File Systems): Document it. Change-Id: Ie462347935569acddfba68441cf58815a5087cff Modified-by: Maxim Cournoyer --- doc/guix.texi | 7 +++++++ gnu/services.scm | 21 +++++++++++++-------- gnu/services/dbus.scm | 31 ------------------------------- gnu/system/file-systems.scm | 29 +++++++++++++++++++++++++++-- 4 files changed, 47 insertions(+), 41 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 0537cae87d..eb8dd39c89 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18383,6 +18383,13 @@ File Systems read-write in its own ``name space.'' @end defvar +@defvar %runtime-variable-data +This file system is mounted as @file{/run} and contains system +information data describing the system since it was booted. +@file{/var/run} is bind mounted to @file{/run}, for backward +compatibility. +@end defvar + @defvar %binary-format-file-system The @code{binfmt_misc} file system, which allows handling of arbitrary executable file types to be delegated to user space. This requires the diff --git a/gnu/services.scm b/gnu/services.scm index af054339fd..09515a467f 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -628,9 +628,14 @@ (define (system-provenance system) (define (cleanup-gexp _) "Return a gexp to clean up /tmp and similar places upon boot." - (with-imported-modules '((guix build utils)) + (with-imported-modules (source-module-closure + '((guix build utils) + (gnu build file-systems) + (gnu system file-systems))) #~(begin - (use-modules (guix build utils)) + (use-modules (guix build utils) + (gnu build file-systems) + (gnu system file-systems)) ;; Clean out /tmp, /var/run, and /run. ;; @@ -662,17 +667,17 @@ (define (cleanup-gexp _) "/lib/locale")) (setlocale LC_CTYPE "en_US.utf8") (delete-file-recursively "/tmp") - (delete-file-recursively "/var/run") - (delete-file-recursively "/run") ;; Note: The second argument to 'mkdir' is and'ed with umask, ;; hence the 'chmod' calls. (mkdir "/tmp" #o1777) (chmod "/tmp" #o1777) - (mkdir "/var/run" #o755) - (chmod "/var/run" #o755) - (mkdir "/run" #o755) - (chmod "/var/run" #o755)))))) + + ;; XXX: It'd be cleaner if we could simply register + ;; %runtime-variable-data/bind-mount in %base-file-systems, that + ;; fails with: 'statfs-raw: No such file or directory' when + ;; checking for "/run". + (mount-file-system %runtime-variable-data/bind-mount #:root "/")))))) (define cleanup-service-type ;; Service that cleans things up in /tmp and similar. diff --git a/gnu/services/dbus.scm b/gnu/services/dbus.scm index 76e04bf221..9292172e01 100644 --- a/gnu/services/dbus.scm +++ b/gnu/services/dbus.scm @@ -190,37 +190,6 @@ (define (dbus-activation config) ;; world-readable. (mkdir-p/perms "/run/dbus" user #o755)) - (catch 'system-error - (lambda () - (symlink "/run/dbus" "/var/run/dbus")) - (lambda args - (let ((errno (system-error-errno args))) - (cond - ((= errno EEXIST) - (let ((existing-name - (false-if-exception - (readlink "/var/run/dbus")))) - (unless (equal? existing-name "/run/dbus") - ;; Move the content of /var/run/dbus to /run/dbus, and - ;; retry. - (let ((dir (opendir "/var/run/dbus"))) - (let loop ((next (readdir dir))) - (cond - ((eof-object? next) (closedir dir)) - ((member next '("." "..")) (loop (readdir dir))) - (else - (begin - (rename-file (string-append "/var/run/dbus/" next) - (string-append "/run/dbus/" next)) - (loop (readdir dir))))))) - (rmdir "/var/run/dbus") - (symlink "/run/dbus" "/var/run/dbus")))) - (else - (format (current-error-port) - "Failed to symlink /run/dbus to /var/run/dbus: ~s~%" - (strerror errno)) - (error "cannot create /var/run/dbus")))))) - (unless (file-exists? "/etc/machine-id") (format #t "creating /etc/machine-id...~%") (invoke (string-append #$(dbus-configuration-dbus config) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 4ea8237c70..c75ef39377 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -2,7 +2,7 @@ ;;; Copyright © 2013-2022 Ludovic Courtès ;;; Copyright © 2020 Google LLC ;;; Copyright © 2020 Jakub Kądziołka -;;; Copyright © 2020, 2021 Maxim Cournoyer +;;; Copyright © 2020, 2021, 2025 Maxim Cournoyer ;;; Copyright © 2021 Tobias Geerinckx-Rice ;;; Copyright © 2022 Oleg Pykhalov ;;; @@ -82,6 +82,8 @@ (define-module (gnu system file-systems) %pseudo-terminal-file-system %tty-gid %immutable-store + %runtime-variable-data + %runtime-variable-data/bind-mount %control-groups %elogind-file-systems @@ -448,6 +450,28 @@ (define %immutable-store (check? #f) (flags '(read-only bind-mount no-atime)))) +(define %runtime-variable-data + (file-system + (type "tmpfs") + (mount-point "/run") + (device "tmpfs") + ;; Don't use no-suid here as /run/privileged/bin may contain SUID + ;; executables. + (flags '(no-dev strict-atime)) + (options "mode=0755,nr_inodes=800k,size=20%") + (needed-for-boot? #t) + (check? #f) + (create-mount-point? #t))) + +(define %runtime-variable-data/bind-mount + (file-system + (device "/run") + (mount-point "/var/run") + (type "tmpfs") + (flags '(bind-mount)) + (check? #f) + (create-mount-point? #t))) + (define %control-groups ;; The cgroup2 file system. (list (file-system @@ -497,7 +521,8 @@ (define %base-file-systems %debug-file-system %shared-memory-file-system %efivars-file-system - %immutable-store)) + %immutable-store + %runtime-variable-data)) (define %base-live-file-systems ;; This is the bare minimum to use live file-systems. -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Sat May 03 10:39:28 2025 Received: (at 73494) by debbugs.gnu.org; 3 May 2025 14:39:28 +0000 Received: from localhost ([127.0.0.1]:42124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBE1Y-0002mr-0N for submit@debbugs.gnu.org; Sat, 03 May 2025 10:39:28 -0400 Received: from mail.boiledscript.com ([2a01:4f8:242:4aeb::42]:58332) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uBE1V-0002mW-3Q for 73494@debbugs.gnu.org; Sat, 03 May 2025 10:39:25 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1746283163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnivMKwX4oAX6D86QppmjsudQiGF7Hv9GNhRpl5J8lE=; b=PzCVJQryzmjUrYj3uStJPeKY68XgoGgr+zEo/epn/p4cEmd5OSxmLUP0kdXIzfquOvDBXo VIBbFE/dUEIiS3CYckycBbpGSlHJ1FEUYWy2M9/eyRGjuiIL7luftRl4Xxp8/zLW5cOmRL jYZCT4SnzvgtPbw1C4tgwkTt0DXKmJ07G/IZ1sOeQyL9F8+1cNPaQhpJ4b5OtCLelvg0R8 vu2SeR4xEe3K35KGShQs7PcGWCq/3YXz3XTduMZRi38NPprWeRSfvIvJhxDkHX0uo1n79n 9H2uG6x4mCLpXFXMVDBIDOpJL4MaGHv0TBykFqamGAJL7iwEtmgGPA8U2Vgqfw== To: 73494@debbugs.gnu.org Subject: [PATCH v6 3/3] WIP: Fix jami-provisioning test. Date: Sat, 3 May 2025 22:38:30 +0800 Message-ID: <51d0b0c2cb1bc7ad70ac1b35f1b9c2a72047b39a.1746283044.git.hako@ultrarare.space> In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Hilton Chain , Maxim Cournoyer , Ludovic Courtès , Vagrant Cascadian , Z572 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Zheng Junjie , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Zheng Junjie TODO: Investigate why this is needed. Do not commit. Change-Id: I6996b5627d732d1c261ae453da5d0916637b0288 Signed-off-by: Maxim Cournoyer --- gnu/tests/telephony.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/tests/telephony.scm b/gnu/tests/telephony.scm index f03ea963f7..219cb42164 100644 --- a/gnu/tests/telephony.scm +++ b/gnu/tests/telephony.scm @@ -30,6 +30,7 @@ (define-module (gnu tests telephony) #:use-module (gnu services telephony) #:use-module (guix gexp) #:use-module (guix modules) + #:use-module (gnu services shepherd) #:export (%test-jami %test-jami-provisioning %test-jami-provisioning-partial)) @@ -116,7 +117,9 @@ (define* (make-jami-os #:key provisioning? partial?) (openssh-configuration (permit-root-login #t) (allow-empty-passwords? #t))) - %base-services)) + (service syslog-service-type) + (modify-services %base-services + (delete shepherd-system-log-service-type)))) (packages (cons* (specification->package "recutils") (specification->package "strace") %base-packages)))) -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Sat May 03 11:03:44 2025 Received: (at 73494) by debbugs.gnu.org; 3 May 2025 15:03:45 +0000 Received: from localhost ([127.0.0.1]:42328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBEP2-0004Bj-IA for submit@debbugs.gnu.org; Sat, 03 May 2025 11:03:44 -0400 Received: from mail.boiledscript.com ([49.12.134.184]:51492) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uBEOz-0004BX-Dr for 73494@debbugs.gnu.org; Sat, 03 May 2025 11:03:42 -0400 Date: Sat, 03 May 2025 22:44:13 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1746284619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H9Cl/qOGzAeISiWA4CcjLe/H94RIacFvX5MIRjm9JFI=; b=AnFjtwI0360k5Xy7QYJeGCsDc/AGL8fy3jLhkG8nw5XUXQ+TsqjXAapTnHPY4Fp7WYr8xr zEcVcjsnaSRh1vWrVDhJiN0uBaK/MVThzEg8V09LziNCJ7XP38RoGU96li0oClvCgCZxDp R+kBRUj3E0jpRDYE9Wl7LJ03DL+mvO0g6lKuHhppJJhCg4zL1KcnjoD9lGPXbPBhWRlkQy /LfKln8ZDAXlpNPS0sJn8+VaNNzuqFnbQh6dDmsaMl0bOKBCBvkrNl6G2pv01PvUsHh5vv iEP9QzKX2BWbRie8fACB1vVb/aNZQcYjDvSrHzcfIgpH4wl8nbBzS5rk+to/lg== Message-ID: <87tt61n48y.wl-hako@ultrarare.space> From: Hilton Chain To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: [bug#73494] [PATCH v4 1/3] services: activation: Continue on exceptions. In-Reply-To: <87y0vf9ecs.fsf@gnu.org> References: <597361035150296c6051f6f78fc8cc8ff3af8b61.1745911065.git.maxim.cournoyer@gmail.com> <87y0vf9ecs.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: base64 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Z572 , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) T24gU2F0LCAwMyBNYXkgMjAyNSAwMDoxNzoyMyArMDgwMCwNCkx1ZG92aWMgQ291cnSoqHMgd3Jv dGU6DQo+DQo+IEhlbGxvLA0KPg0KPiBNYXhpbSBDb3Vybm95ZXIgPG1heGltLmNvdXJub3llckBn bWFpbC5jb20+IHdyaXRlczoNCj4NCj4gPiBGcm9tOiBIaWx0b24gQ2hhaW4gPGhha29AdWx0cmFy YXJlLnNwYWNlPg0KPiA+DQo+ID4gVXNlIKGuaW52b2tloa8gZm9yIGJhY2t0cmFjZXMgYW5kIGF2 b2lkIGNoYW5naW5nIGVudmlyb25tZW50Lg0KPiA+DQo+ID4gKiBnbnUvc2VydmljZXMuc2NtIChh Y3RpdmF0aW9uLXNjcmlwdCk6IEV4ZWN1dGUgYWN0aXZhdGlvbiBzY3JpcHRzIGluDQo+ID4goa5p bnZva2Whry4NCj4gPiBXYXJuIGFib3V0IGZhaWxlZCBhY3RpdmF0aW9uIHNjcmlwdHMuDQo+ID4N Cj4gPiBDaGFuZ2UtSWQ6IEk4OWJlMzE0MzNmYmI0NmQwYzRhOWRjNjExNWFiMTY3OTEwODQwYjZm DQo+ID4gU2lnbmVkLW9mZi1ieTogTWF4aW0gQ291cm5veWVyIDxtYXhpbS5jb3Vybm95ZXJAZ21h aWwuY29tPg0KPg0KPiBbLi4uXQ0KPg0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgOzsgUnVu IHRoZSBzZXJ2aWNlcycgYWN0aXZhdGlvbiBzbmlwcGV0cy4NCj4gPiAtICAgICAgICAgICAgICAg ICAgICAgIDs7IFRPRE86IFVzZSAnbG9hZC1jb21waWxlZCcuDQo+ID4gLSAgICAgICAgICAgICAg ICAgICAgICAoZm9yLWVhY2ggcHJpbWl0aXZlLWxvYWQgJyMkYWN0aW9ucykpKSkpDQo+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAoZm9yLWVhY2ggKGxhbWJkYSAoYWN0aW9uKQ0KPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgRG9uJ3QgYmxvY2sgYWN0aXZhdGlvbiBw cm9jZXNzIHdoZW4gb25lDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7 OyBhY3Rpb24gZmFpbHMuDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo Y2F0Y2ggI3QNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxhbWJk YSAoKQ0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChpbnZva2Ug YWN0aW9uKSkNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxhbWJk YSBfDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdhcm5pbmcN Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKEdfICJmYWlsZWQg dG8gYWN0aXZhdGUgJ35hJy5+JSIpDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGFjdGlvbikpKSkNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAnIyRhY3Rpb25zKSkpKSkNCj4NCj4gQXMgSSBzdWdnZXN0ZWQgdXB0aHJlYWQgKG9yIGVsc2V3 aGVyZT8gSaGvbSBsb3N0ISksIEkgdGhpbmsgaXQgd291bGQgYmUNCj4gZW5vdWdoIHRvIGtlZXAg bG9hZGluZyB0aGVzZSBmaWxlcyBpbiB0aGUgbWFpbiBwcm9jZXNzIChhcyBvcHBvc2VkIHRvDQo+ IHNwYXduaW5nIG9uZSBzaG9ydC1saXZlZCBwcm9jZXNzIGZvciBlYWNoIGFjdGl2YXRpb24pIGFu ZCBzaW1wbHkgY2F0Y2gNCj4gZXhjZXB0aW9uczoNCj4NCj4gICAoZm9yLWVhY2ggKGxhbWJkYSAo ZmlsZSkNCj4gICAgICAgICAgICAgICAoZ3VhcmQgKGMgoa0pDQo+ICAgICAgICAgICAgICAgICAo c2F2ZS1tb2R1bGUtZXhjdXJzaW9uDQo+ICAgICAgICAgICAgICAgICAgIKGtKSkpDQo+ICAgICAg ICAgICAgICcjJGFjdGlvbnMpDQo+DQo+IEkgdGhpbmsgaXQgd291bGQgZG8gd2hhdCB3ZSB3YW50 IHdoaWxlIGF2b2lkaW5nIHRoZSBvdmVyaGVhZC4gIEkgZG9uoa90DQo+IHRoaW5rIGl0IHF1YWxp ZmllcyBhcyChsHByZW1hdHVyZSBvcHRpbWl6YXRpb26hsSBiZWNhdXNlIGl0oa9zIGFscmVhZHkg aW4NCj4gcGxhY2UgYW5kIHRoZSBzZW1hbnRpY3MgYXJlIHdlbGwtZGVmaW5lZC4NCg0KSW1wbGVt ZW50ZWQgaW4gdjYuDQo= From debbugs-submit-bounces@debbugs.gnu.org Sat May 03 12:32:31 2025 Received: (at 73494) by debbugs.gnu.org; 3 May 2025 16:32:31 +0000 Received: from localhost ([127.0.0.1]:42797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBFmw-0000gV-TC for submit@debbugs.gnu.org; Sat, 03 May 2025 12:32:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50484) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uBFmu-0000fu-7G for 73494@debbugs.gnu.org; Sat, 03 May 2025 12:32:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uBFmn-0007KM-V4; Sat, 03 May 2025 12:32:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=c2uDj2K6DJOCPZKL0qNURHtz3cQiqyCJCXkHlc2HMgg=; b=FdfpMEzNjzD4EscpZvcr rftoiRT9AFXzcE/+AOcDi9Zn+kX0TspgK2rHvcDBeX4Lq4DBf6uZ4mBsq3mmahEn7KbrfjQQbIJak eUCRVzz+90NCUl6Rj+eVwaCI1z31hBetIEsJJKEZct8ikaBkM2frPH8mIUHE6x5fm1Uai2YDn56j+ JqGTmfbWC7j0F1mSwGEiAfzG6OMiUBZPxfmr3sqqWf3OhqVYmM8OcsR/9vENNajPzT5VekRrkaktu UOeMoJ+xDSj1CU4jOZBjvFGe0mj+I59XaseHrmnNQ0WWzZGLjKc4IH0YpXcJOzv4oGT3ui2JxoKs6 +5GpPRF28JdGBg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Hilton Chain Subject: Re: [bug#73494] [PATCH v6 1/3] services: activation: Continue on exceptions. In-Reply-To: (Hilton Chain's message of "Sat, 3 May 2025 22:38:28 +0800") References: User-Agent: mu4e 1.12.9; emacs 29.4 X-URL: https://people.bordeaux.inria.fr/lcourtes/ X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu X-Revolutionary-Date: Quartidi 14 =?utf-8?Q?Flor=C3=A9al?= an 233 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du =?utf-8?Q?Cham=C3=A9risier?= Date: Sat, 03 May 2025 17:48:40 +0200 Message-ID: <87jz6xae5j.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Z572 , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hilton Chain writes: > * gnu/services.scm (activation-script): Reset environment before loading > activation script. > Catch exception and print the error. > Warn about failed activation script. > > Change-Id: I89be31433fbb46d0c4a9dc6115ab167910840b6f [...] > + (for-each (lambda (action) > + ;; Don't block activation process when one > + ;; action fails. > + (guard (condition > + (else > + (format (current-error-port) "~a~%" > + condition) > + (warning > + (G_ "failed to activate '~a'~%") > + action))) > + (save-module-excursion > + (lambda () > + (set-current-module > + (make-fresh-user-module)) > + (primitive-load action))))) > + '#$actions))))) LGTM. Ludo'. From debbugs-submit-bounces@debbugs.gnu.org Sat May 03 12:32:32 2025 Received: (at 73494) by debbugs.gnu.org; 3 May 2025 16:32:32 +0000 Received: from localhost ([127.0.0.1]:42799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBFmx-0000gi-FT for submit@debbugs.gnu.org; Sat, 03 May 2025 12:32:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50498) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uBFmv-0000fw-1X for 73494@debbugs.gnu.org; Sat, 03 May 2025 12:32:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uBFml-0007Jt-Kl; Sat, 03 May 2025 12:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Wpq56HwKNFWDUhCwzAHrroHCbeVaer6cmP9o0tZ3rdM=; b=lXjY1l5ANYdNNlExyPQe K4jJ11nxtzWHVLJOx9nV5uLonMGOOoMaUbDxAeiloGU9GbAauqGcIAEKuNxyhtyCEZ/3IkLE3/+L0 RnPprkGksYFcpRitdmDyA6ahqg/VV8N4xL9UcZsG7CtAP3kiMJkv3QVfLJTyUjEfcse7MxGmL2T8W GoGREmNhfzSflizb2Sa9KQlBP7rVu5kR9t+iAEcP+8OVFycjqz9fOVXKz0kzGDtRTYWHSQ0jYLALb o8ncl/YB8nnAkbgsw0Hbwxkp2Wo3TrAPHzUMpMERTwKCAxvFFm3UJV14mCNqgzZhorfTWzHH98tgc mPMSJV8jKcu6YQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Hilton Chain Subject: Re: [bug#73494] [PATCH v6 2/3] services: cleanup: Bind mount /var/run to /run. In-Reply-To: (Hilton Chain's message of "Sat, 3 May 2025 22:38:29 +0800") References: User-Agent: mu4e 1.12.9; emacs 29.4 X-URL: https://people.bordeaux.inria.fr/lcourtes/ X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu X-Revolutionary-Date: Quartidi 14 =?utf-8?Q?Flor=C3=A9al?= an 233 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du =?utf-8?Q?Cham=C3=A9risier?= Date: Sat, 03 May 2025 17:47:11 +0200 Message-ID: <87plgpae80.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , 73494@debbugs.gnu.org, Gabriel Wicki , Z572 , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Hilton Chain writes: > * gnu/system/file-systems.scm (%runtime-variable-data) > (%runtime-variable-data/bind-mount): New variables. > * gnu/system/file-systems.scm (%base-file-systems): Register > %runtime-variable-data. > * gnu/services.scm (cleanup-gexp): Bind mount /var/run to /run. Remove n= ow > extraneous cleanups. > * doc/guix.texi (File Systems): Document it. > > Change-Id: Ie462347935569acddfba68441cf58815a5087cff > Modified-by: Maxim Cournoyer [...] > @@ -662,17 +667,17 @@ (define (cleanup-gexp _) > "/lib/locale")) > (setlocale LC_CTYPE "en_US.utf8") > (delete-file-recursively "/tmp") > - (delete-file-recursively "/var/run") > - (delete-file-recursively "/run") >=20=20 > ;; Note: The second argument to 'mkdir' is and'ed with umask, > ;; hence the 'chmod' calls. > (mkdir "/tmp" #o1777) > (chmod "/tmp" #o1777) > - (mkdir "/var/run" #o755) > - (chmod "/var/run" #o755) > - (mkdir "/run" #o755) > - (chmod "/var/run" #o755)))))) > + > + ;; XXX: It'd be cleaner if we could simply register > + ;; %runtime-variable-data/bind-mount in %base-file-systems, t= hat > + ;; fails with: 'statfs-raw: No such file or directory' when > + ;; checking for "/run". > + (mount-file-system %runtime-variable-data/bind-mount #:root "= /")))))) Could you try to get a backtrace or something? =E2=80=98statfs-raw=E2=80=99 is the C primitive used by the statically-link= ed Guile in the initrd, so before shepherd is spawned. Normally, upon error, you get a Guile prompt where you can type =E2=80=9C,bt=E2=80=9D for a backtrace. Thanks for working on it! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu May 08 01:54:44 2025 Received: (at 73494) by debbugs.gnu.org; 8 May 2025 05:54:44 +0000 Received: from localhost ([127.0.0.1]:52564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uCuDU-0006WB-68 for submit@debbugs.gnu.org; Thu, 08 May 2025 01:54:44 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:60897) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uCuDR-0006Vh-V3 for 73494@debbugs.gnu.org; Thu, 08 May 2025 01:54:42 -0400 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-b07d607dc83so424079a12.1 for <73494@debbugs.gnu.org>; Wed, 07 May 2025 22:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746683676; x=1747288476; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u/ZZzPRWperipQ0jlEE2nFueKF6N/16q9JeR4XdlsyM=; b=ejEVkOBQiYE0V0yOdANimf4fWS+y2oOmO3RvoHM+uv3rnftbgYmCgFybCTKU7LqIrh o5/22cMFGFQq7WFGFqVm/4Rd1W4YcFZMk1yYqMWBUVWFJ+oKN8CTQZyCWHv+Sss1Ux7u 1Dd8fMOEq6v4vrfXdu4vqNLCR1fJd7zlPa8AMc/l7DZgtTbfCLVGIUv3weDanvBQua/h zT/ZUhGsIgqfqGAov6gxMapbOfvoQ8OV6AeCFrGPNJbZSSubAOAvH07C9Ns73QABXX6y fPkilS4Vz4Rcab7qdzBVG5e04AigxUbNoN+Q5ntyNh8wcRIx6qgVb0pk7bU1q25RbkuI QZXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746683676; x=1747288476; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=u/ZZzPRWperipQ0jlEE2nFueKF6N/16q9JeR4XdlsyM=; b=QX8080oRoTQkeEFkJEMuAteC3nD6cqkSk4uEPaNAkIM1ejYeEXGrCV0QGQ3yS6hURo Zf5snUraJXzK86qmRN/wmquIAnEPqqHZHvBuq6Wl3x7pwTimnTvG6R4oj9VtcYV93klI kWBXN37KmYCo+odgT0zigmvdyQ2m1D9O3YtwK8kVZCm2v7KQ+IGC0Ui6TD/Sdf+jmhPk 8xxygNVINIA/BUrwQe4Nc99yhADa/YoHuzrLLVmVxV8o7GQDg1ZZ0rZWKJj2s2oqeGrj jBbpOkQ7cHShsfD1gviPmznAr/l/FuLri6GxkuHe1IWXp4DqvDCYgMpXUdy3UK4YAE45 OJKw== X-Forwarded-Encrypted: i=1; AJvYcCXBraS1EQwL8+zGVP72HNKtT4OUE2j3gqf2rer0yFCX6ELMUuIJsbqoVldFvZVIebSj4KZ+zQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyvAznuViQB4N6UzQ5NkPbtTjE73gJBy2zJEBIVWTfr7SzzxnQm nB4ajPK461oeJevpgZTl43ULUHkApRLGRYJoUPyESLmc3b3sxfVD X-Gm-Gg: ASbGncudqYskhqquCvgnBcQ8430eGJZAioihmIMxlWg8sWJc56QHbQ/uGQAARXYWLfV 0jizGwlRP/QZAo8l1DlR9zZOl+mv57JdoAhyTP6cYjITwDktBsaX6TY25Dk7VlRiTu2h192h0ZX FnbgpqHOOTyyuC9jxIyq+hekbiQn17YQv26DjOHl2qpPTD2w+4tKYPQsxOnqp8bUMVBVTn0SGRy p20oLfYtW2BotpbW2nY8DJhp7cOqAGNT/RnsYebsXlRua2CiCTE9nwrYUh1v/t3Z7RAm3DKt7ly cJxZ8hDhqmYFyw8B7rve5o85dkSWeAg9uptyLFg= X-Google-Smtp-Source: AGHT+IGbrkmte4/R/0aSeayWk6ZFdShriz4iN7qi1zv/uRRLbLGOYlVqCf+lFYfBL6y4DnkUtGLixQ== X-Received: by 2002:a05:6a21:c91:b0:1f5:8220:7452 with SMTP id adf61e73a8af0-2159afa7a44mr3356971637.24.1746683675896; Wed, 07 May 2025 22:54:35 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b1fb3b820bcsm10490275a12.43.2025.05.07.22.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 22:54:35 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#73494] [PATCH v6 1/3] services: activation: Continue on exceptions. In-Reply-To: <87jz6xae5j.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sat, 03 May 2025 17:48:40 +0200") References: <87jz6xae5j.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Thu, 08 May 2025 14:54:30 +0900 Message-ID: <87r00ztzop.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , Hilton Chain , 73494@debbugs.gnu.org, Z572 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Ludovic Court=C3=A8s writes: > Hilton Chain writes: > >> * gnu/services.scm (activation-script): Reset environment before loading >> activation script. >> Catch exception and print the error. >> Warn about failed activation script. >> >> Change-Id: I89be31433fbb46d0c4a9dc6115ab167910840b6f > > [...] > >> + (for-each (lambda (action) >> + ;; Don't block activation process whe= n one >> + ;; action fails. >> + (guard (condition >> + (else >> + (format (current-error-port)= "~a~%" >> + condition) >> + (warning >> + (G_ "failed to activate '~a= '~%") >> + action))) >> + (save-module-excursion >> + (lambda () >> + (set-current-module >> + (make-fresh-user-module)) >> + (primitive-load action))))) >> + '#$actions))))) > > LGTM. Thanks. I've pushed just this 1/3 patch so far. We still need to understand why the use of shepherd-system-log-service hangs the jami service (dbus daemon), *only* when /run is mounted on a tmpfs (!). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu May 08 01:58:27 2025 Received: (at 73494) by debbugs.gnu.org; 8 May 2025 05:58:27 +0000 Received: from localhost ([127.0.0.1]:52622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uCuH5-0006mm-55 for submit@debbugs.gnu.org; Thu, 08 May 2025 01:58:27 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:42178) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uCuH2-0006mZ-Uz for 73494@debbugs.gnu.org; Thu, 08 May 2025 01:58:25 -0400 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-22e16234307so7573565ad.0 for <73494@debbugs.gnu.org>; Wed, 07 May 2025 22:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746683899; x=1747288699; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jl1iIG3R6VBULM0UXg0qmWc8CYuKn90jgQOn3vy+uq0=; b=kVoBeK99utGw/hpnacTeIMbqyGLvADo2NbUNTwL9//5G+B7zmjdfnF2gd4dFcZ6+Aw ATC9ln32ap7j2vNBm1upYcakaC92uNx1LaR/jCxpJ7lSj3Lei7QvAmqxDCUPY+VPb9/o IzuAIbGoZmfkd8sr6U24WUr2rXQYzHx8hFQW8oAc9gxKJUD+dkefyXjBSeMMhttRh8qW HvArC7TaIvWdz01tS1W3UOuOsuo4G5Loh5MQ7ZdHW9pS93PSm6VU1TpdExUWCCxxZ74d nNBGw19shpH4bx2lkvP7+Kv01u3X9IYjjgt8QmEOUyY6bZeibpeProtvIxdTvlkzubv7 +R7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746683899; x=1747288699; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Jl1iIG3R6VBULM0UXg0qmWc8CYuKn90jgQOn3vy+uq0=; b=ShkXTNgz5/Jgh+JPwcufDmHCpsmpN3Jafubkf49hs1vHnKvamjAq3/m+u4f5UsmMJz hspWhkwx202d353CFSXGS89/d8nlCG3A9xrysxoXTXw+VIFgLghMs3Ik8IF4T5+i3Y33 Vert7jhZDJ/IXsSuLzBzUIkSyribhavMFnROc8gMptvdEejq+RhoaNGHhIs95MONPzcY KvrIk7ZMIFjkAf5p7Eo+PNnL89Jmq5tjdW9HnrlFTmiMPLGB2/trWnBMH+k8loKIwgln E5IIfegV3/L+aZ+EBvHN1v/Rqb/aUVDFwzr6Amwal0PoW0KELrmjSqIh61VGfUOSkOgK iIgA== X-Forwarded-Encrypted: i=1; AJvYcCWjlx7YXINPPyaFleT/UZSR8qtalvITv5MnKET+jl4DeKEEy1xIWpkddOP8OGpckhqqJA8mkg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxP/Wn5HdjS8LfE7fbOZfBOBTNZWanQ6q/nWszt+sLiqeSitZdP 3faDz511z0oOIwBIbnaGoXQEbgSFlsnMfk9kEnDSXF4vdKexRupJ X-Gm-Gg: ASbGncsOOggrm1hxE2pxIFdtz2wMbnyvzkx30XGygSXtKomzVXAbaGpi/vGs2c351A/ zrsFHETysV6zkOYHfh6G6qd4CnVGICfftdFpvKSzltB2TTKfWkJFdxZGFhe/jEeaLZTifG9wuGc UTkp4dQId8g6Cq7Y1vQ4hvgVzOkcnowoZ1TZFMq1bofUenik+UzT9bhrwAAkDfFQw+aU4Ifrloo iNVdw1VwPqLFhLqCDEIQikDqCAXRv1ObgsieYmjLD3MVao0l+BUC22tVy6aP7Exb/OdIT8a5DKI Fk7EpcnrdveoOzwX6BNuG4kUWVpjQU0siBtY+i0= X-Google-Smtp-Source: AGHT+IGYTbJfTeExENlrZ+z/+ssmlIVwYuPqoUT+AC4439cekE2LPY1bZhvYAt8A02/+sZiHMHVwPQ== X-Received: by 2002:a17:902:ce86:b0:22e:5a9c:2853 with SMTP id d9443c01a7336-22e847358e8mr32054345ad.12.1746683898839; Wed, 07 May 2025 22:58:18 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22e6a1210b4sm22860425ad.251.2025.05.07.22.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 22:58:18 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#73494] [PATCH v6 2/3] services: cleanup: Bind mount /var/run to /run. In-Reply-To: <87plgpae80.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sat, 03 May 2025 17:47:11 +0200") References: <87plgpae80.fsf@gnu.org> Date: Thu, 08 May 2025 14:58:14 +0900 Message-ID: <87msbntzih.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , Hilton Chain , 73494@debbugs.gnu.org, Gabriel Wicki , Z572 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: [...] >> @@ -662,17 +667,17 @@ (define (cleanup-gexp _) >> "/lib/locale")) >> (setlocale LC_CTYPE "en_US.utf8") >> (delete-file-recursively "/tmp") >> - (delete-file-recursively "/var/run") >> - (delete-file-recursively "/run") >>=20=20 >> ;; Note: The second argument to 'mkdir' is and'ed with umask, >> ;; hence the 'chmod' calls. >> (mkdir "/tmp" #o1777) >> (chmod "/tmp" #o1777) >> - (mkdir "/var/run" #o755) >> - (chmod "/var/run" #o755) >> - (mkdir "/run" #o755) >> - (chmod "/var/run" #o755)))))) >> + >> + ;; XXX: It'd be cleaner if we could simply register >> + ;; %runtime-variable-data/bind-mount in %base-file-systems, = that >> + ;; fails with: 'statfs-raw: No such file or directory' when >> + ;; checking for "/run". >> + (mount-file-system %runtime-variable-data/bind-mount #:root = "/")))))) > > Could you try to get a backtrace or something? > > =E2=80=98statfs-raw=E2=80=99 is the C primitive used by the statically-li= nked Guile in > the initrd, so before shepherd is spawned. Normally, upon error, you > get a Guile prompt where you can type =E2=80=9C,bt=E2=80=9D for a backtra= ce. I think perhaps it could be because the file-system 'dependencies' field is not honored in the early boot? /run mount be mounted as tmpfs before we can bind mount /var/run to it. I'm not sure though, so I'll have to try what you suggest. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat May 10 09:49:45 2025 Received: (at 73494) by debbugs.gnu.org; 10 May 2025 13:49:45 +0000 Received: from localhost ([127.0.0.1]:45340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uDkaG-0001M1-45 for submit@debbugs.gnu.org; Sat, 10 May 2025 09:49:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53268) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uDka9-0001LP-Bd for 73494@debbugs.gnu.org; Sat, 10 May 2025 09:49:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDka2-0006gf-4u; Sat, 10 May 2025 09:49:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Bven+7iemWgr6AfhroE5ovGCYici6qaEdiEH8XDH9sw=; b=NUzfNg5aqWBw2KpuVhlf WAbPpB+9+yt+k7zrWHZ22ROOG3UTaaRn3EeCk68b1+vCNUTgA968jQXWpxC0JHXanf4+X+FviP358 RTc0V41sp8bZI84I+sLf4UX5CclEI3JPmhqv31uJuAqnt6X4vfZxTVPIf9gyuZTQeU1SFLSeeroOO gndHy2k+VirikvT794cU3AcrfJuzNYX/PDxu5uotQHCLG1BN88ng207drOKzKIUXhMWnE33JD6MeT w3fd2wmT0O/R6EbtLaMTIDfs//QkeyjkAEROv7uJHyFuG2pv+nwg2Kf1+WNY1rEvou8Cvd68SGC9z yolkAAbk830xCg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH v6 1/3] services: activation: Continue on exceptions. In-Reply-To: <87r00ztzop.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 08 May 2025 14:54:30 +0900") References: <87jz6xae5j.fsf@gnu.org> <87r00ztzop.fsf@gmail.com> User-Agent: mu4e 1.12.9; emacs 29.4 X-URL: https://people.bordeaux.inria.fr/lcourtes/ X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu X-Revolutionary-Date: Primidi 21 =?utf-8?Q?Flor=C3=A9al?= an 233 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Statice Date: Sat, 10 May 2025 15:48:58 +0200 Message-ID: <87msbk4lv9.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , Hilton Chain , 73494@debbugs.gnu.org, Z572 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Maxim Cournoyer writes: > Thanks. I've pushed just this 1/3 patch so far. We still need to > understand why the use of shepherd-system-log-service hangs the jami > service (dbus daemon), *only* when /run is mounted on a tmpfs (!). I missed that part of the discussion. How do we know shepherd-system-log-service is at fault? Does Jami log over syslog? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat May 10 11:03:34 2025 Received: (at 73494) by debbugs.gnu.org; 10 May 2025 15:03:34 +0000 Received: from localhost ([127.0.0.1]:48061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uDljh-0006Yn-UX for submit@debbugs.gnu.org; Sat, 10 May 2025 11:03:34 -0400 Received: from mail.z572.online ([88.99.160.180]:51892) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uDljd-0006Yb-KW for 73494@debbugs.gnu.org; Sat, 10 May 2025 11:03:31 -0400 Received: from m (mail1.85362086.com [107.174.64.25]) by mail.z572.online (OpenSMTPD) with ESMTPSA id 4517359a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 10 May 2025 15:10:23 +0000 (UTC) From: Z572 To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#73494] [PATCH v6 1/3] services: activation: Continue on exceptions. In-Reply-To: <87msbk4lv9.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sat, 10 May 2025 15:48:58 +0200") References: <87jz6xae5j.fsf@gnu.org> <87r00ztzop.fsf@gmail.com> <87msbk4lv9.fsf@gnu.org> User-Agent: mu4e 1.12.9; emacs 30.0.92 Date: Sat, 10 May 2025 23:03:08 +0800 Message-ID: <875xi8fqz7.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , Hilton Chain , 73494@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello, > > Maxim Cournoyer writes: > >> Thanks. I've pushed just this 1/3 patch so far. We still need to >> understand why the use of shepherd-system-log-service hangs the jami >> service (dbus daemon), *only* when /run is mounted on a tmpfs (!). > > I missed that part of the discussion. How do we know > shepherd-system-log-service is at fault? Does Jami log over syslog? I checked the test log on ci and found that the Jami-related test failed after switching to shepherd-system-log-service by default. After trying to switch shepherd-system-log-service back to syslog, the test succeeded. > > Thanks, > Ludo=E2=80=99. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmgfaqwACgkQO1qpk+Gi 3/D2+Q//asuWoxhR1y5SR/V2f4TqemRWjWbPxQh3TkGUidr0PRvEQTij1YjZgdFH Y6lut7jLFpb4pD+q35he/GaJ4PHnngJsZD1El1Q6VEuZc802JD5buc/yKKVnzapD Z7hwng4P0z3/SurXA3JQ/CMvKHzdI4f7ao8NrHt0t0NM7VZBni7ZLPUw9JBMV7oh WR5bKZr2wD+4NKw/Rgvd6fC0Zo2+Sxl7MquqIw5GARe4924fLjwvAo7yadczkVJE lbhwTzyZrL1mQg0+3G0bAW+rJ/6H3khXQyzKan1tAa4685A7Tm19ZfBAyIvWM7WV irlx4y3Xigv4Gz/KLYIIp0YFqewUUQmApKYgPez86cd08dzm2Wt5549iFJpLAJMG W+XBk+Bgq2Y3sXHla270BxbEPbYqVYE9DlJOv+fQsWTCOpFJqO3Zx8OhKDRT9FQW 8ejwqbzr1BnP4XBbbBWfFfGY0BgwINHrP6NKp1wt1Vv/QwG+5jk2GZ5xWqBVdfRe Ec80bZkUAV5Qvd7aKBI6xVQGE6sbmAxMkuFbW8Uoo3KZGsRb+37LHIxk3vCcr/RM dw7JLhAdYMbR5uvrUqPSS/D9sZxbHD8TErsH1Ij/i6UgGr4ji0nvzwNi+YYme9Da b85hvvEAvn3r/Fskc1uHuV7rhooRosjh/IbTiSujZ7zpCijHVBU= =hR/a -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 03:56:45 2025 Received: (at 73494) by debbugs.gnu.org; 12 May 2025 07:56:45 +0000 Received: from localhost ([127.0.0.1]:49775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uEO1j-0000jP-J9 for submit@debbugs.gnu.org; Mon, 12 May 2025 03:56:45 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:47223) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uEO1h-0000j3-3K for 73494@debbugs.gnu.org; Mon, 12 May 2025 03:56:41 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-74248a3359fso1907771b3a.2 for <73494@debbugs.gnu.org>; Mon, 12 May 2025 00:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747036595; x=1747641395; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4wbqIGFpwpjXJNNZke5iN8a+A75AY4ilTF7K/aVO1sA=; b=HYb8DYtjVmHPrlxOyTpiJhcCegljzzhPy1mEhkPav5RIxuWf3uh+1EM1ygaRyNeGf/ DazLJuFKebdlfTyj3JsZmd2+uI/lECFX6kCUePS2tarC/lt9KA5ucwk1Yl4OyJRIOLSs L7IWqr3pnzY5UL+4HnP5S4b4lglT6UkQdQOU6O8fDX7MPhkCmhNgMN6+l9gmk13Nz+FA iqvIS64MNUQXBsxLpMuSXUnEKwCu/CCNmzdXzYak/wWe2UiSsbJx8pVHgw1v/bYq8FL4 f42LQrncGZ5bE2ItY4LMO9YSxmnhn3k3jH9NAvP/WZs7jZaEIc+0Ko5IQf+i5OWRadXq FPAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747036595; x=1747641395; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4wbqIGFpwpjXJNNZke5iN8a+A75AY4ilTF7K/aVO1sA=; b=fzQfmRpXIXwKvVd6IOCHATWID+xZ9/8V5HftTiZxrMd0UDzcknRPUnSrLvjflQ62Ag EqsJpRrFXZ70Kq6IdPaMt2fweVRCwzhsQZ0Zl7N8kyBsIo3BAME60CmKjQYxlmqrEoM4 +nht6Jq49sLqKCqPJRvpH+YVBAdfLXZ/OJemOdM3ZwNdeYxHao8A40rz/bE1sy/gLw96 yRrJ46Bv0vKzHMp/woZkBKYjg8+hxfB57rQRiiDXoaPqwsfVYiFCyH+lrZMIDY0Kf7AB 8uRUz/Bw7evQBUYvrurg0e5jctnITCwsXLYYqAL6rcYM2kUYItMc9WxImrSKRfTEppFA YeHw== X-Forwarded-Encrypted: i=1; AJvYcCWm9KDDlpsCyA+dNPmca+7U4Azmd7BU2hmvgoE7cnrNCvhD4VBbqbnbLmetoYPua6hcz2huVA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx/El4tLz6nJVJSykYxZ0IAG7mEugtVhOzSVwgnGZmlUJEJE+aj +voq2waUws9e2M4Fg2o9cu0WMbV/iAL0s0Abk5v9XcyvLhCvpvVJa0xT5f+f X-Gm-Gg: ASbGncuETsHSKMm4u/v80dJH47exAwdRzoeliwbvVaAZTmJvMxVDbD6pPCHrEKHlW/H aJz32F82DYPkomnw3YCdlB9sOkfsj6yaLOCnk1D6DLyU4oGx5sehDB1bWibbF0Pdfpb1Z08+gCm OZ/bIxIXfNJjqCGuI70++a1fQeMmVJfbWwEEFzzAQjyccFrl3lK4GPsXJG2k7weByw/uqfYt7s2 FsUUY1jmsmYVgsUWv8pMSYYVPFF9ma6hZAsQY/2WBh8jcO7ygxWbKWWvmKxDtPQjchpZaiFqnJa OsCQw6btNkQPiPTBzo+E8UBRt2V27wEDFWEXYceEQQgzuyw1uQ== X-Google-Smtp-Source: AGHT+IFQx5wi9V3fIYNxUfwWgjmcwzWm9ENHPlffAQaVAMuEL1EzwY9PaTEr2ldf6di4qAMNZQjTdg== X-Received: by 2002:a17:90b:3908:b0:2fe:99cf:f566 with SMTP id 98e67ed59e1d1-30c3cefe5cfmr19266721a91.13.1747036594849; Mon, 12 May 2025 00:56:34 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30c39e61083sm6053991a91.30.2025.05.12.00.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 00:56:34 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#73494] [PATCH v6 1/3] services: activation: Continue on exceptions. In-Reply-To: <87msbk4lv9.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sat, 10 May 2025 15:48:58 +0200") References: <87jz6xae5j.fsf@gnu.org> <87r00ztzop.fsf@gmail.com> <87msbk4lv9.fsf@gnu.org> Date: Mon, 12 May 2025 16:56:31 +0900 Message-ID: <87frhaqn2o.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , Hilton Chain , 73494@debbugs.gnu.org, Z572 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Hello, > > Maxim Cournoyer writes: > >> Thanks. I've pushed just this 1/3 patch so far. We still need to >> understand why the use of shepherd-system-log-service hangs the jami >> service (dbus daemon), *only* when /run is mounted on a tmpfs (!). > > I missed that part of the discussion. How do we know > shepherd-system-log-service is at fault? Does Jami log over syslog? By trial and error (I assume?), Z572 discovered that if we replace shepherd-system-log-service by shepherd-syslog-service the hang goes away. See the WIP patch 3/3 of this series that does this replacement and where the problem disappears. And yes, the Jami daemon logs to syslog by default with our current service definition. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue May 13 00:24:10 2025 Received: (at 73494) by debbugs.gnu.org; 13 May 2025 04:24:10 +0000 Received: from localhost ([127.0.0.1]:56934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uEhBa-0007wL-A8 for submit@debbugs.gnu.org; Tue, 13 May 2025 00:24:10 -0400 Received: from mail.z572.online ([88.99.160.180]:55148) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uEhBW-0007vy-4T for 73494@debbugs.gnu.org; Tue, 13 May 2025 00:24:08 -0400 Received: from m ( [125.119.189.205]) by mail.z572.online (OpenSMTPD) with ESMTPSA id 511b38d9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 13 May 2025 04:30:57 +0000 (UTC) From: Z572 To: Maxim Cournoyer Subject: Re: [bug#73494] [PATCH v6 1/3] services: activation: Continue on exceptions. In-Reply-To: <87frhaqn2o.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 12 May 2025 16:56:31 +0900") References: <87jz6xae5j.fsf@gnu.org> <87r00ztzop.fsf@gmail.com> <87msbk4lv9.fsf@gnu.org> <87frhaqn2o.fsf@gmail.com> User-Agent: mu4e 1.12.9; emacs 30.0.92 Date: Tue, 13 May 2025 12:23:47 +0800 Message-ID: <87a57hdtpo.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: 73494 Cc: Vagrant Cascadian , Hilton Chain , Ludovic =?utf-8?Q?Court=C3=A8s?= , 73494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Maxim Cournoyer writes: > Hi Ludovic, > > Ludovic Court=C3=A8s writes: > >> Hello, >> >> Maxim Cournoyer writes: >> >>> Thanks. I've pushed just this 1/3 patch so far. We still need to >>> understand why the use of shepherd-system-log-service hangs the jami >>> service (dbus daemon), *only* when /run is mounted on a tmpfs (!). >> >> I missed that part of the discussion. How do we know >> shepherd-system-log-service is at fault? Does Jami log over syslog? > > By trial and error (I assume?), Z572 discovered that if we replace Thanks to ci.guix.gnu.org. I just checked the corresponding build. Jami tests failed after switching to shepherd-system-log-service by default. In the future, we should run system tests when sending patches for improving services to avoid failures after merging without anyone noticing > shepherd-system-log-service by shepherd-syslog-service the hang goes > away. See the WIP patch 3/3 of this series that does this replacement > and where the problem disappears. > > And yes, the Jami daemon logs to syslog by default with our current > service definition. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmgiyVMACgkQO1qpk+Gi 3/DHCw//Yjbd9QazcRGuH/wZVapgfpp7ryo8gN1otSO+WLdKB3l0m5VM24O/plWv V7I+F7eFfkjkloYUxWTjFoqb8OgxCrVtmAufl62w7Pe5CCVkuSCkuRG8vFxL3voy 3pVEkI0JbUv+6K54rUzSHm2Mg29PiXlmIJBSf1Y8dhv+EDokq27yju4X9ra5HzVG BPNd35pSr4WUGqQdQihFVg7Bnd+3BmN2ovVDYOF4ZhW/novq6BLNs5O5Lk8smz1W gBo6XGglDHot+kVGMuY/WG/U7BfcdJKDE01vkD9mUf8DaOHe4b2ewBfrpIxHF7S0 H8RVibvuJhADFuVKJU+hQHHg9m/4Sl4xRfEfO30omuNm1KgLUkxoU1G+J9w7PXQE gWPocovcmztQx1byBRgltpI+pquqMfydjcg/207QCbkzS1qj8dR0b+ELkZhOXnM+ pkYnVptmyKc2G4w+xyvCxQX6ksjGpXArzP7pVv9dXw9t7t9HSRyRykJkz8fnBQhp fFxcj0rFp7CqwrY58oJX9VtP95ekorrzloEJCtrEYctKyJt7F//aP9mL7uQ+DLEB JnmYIVAWANs9L5GB3goV3IOGpT5PRCjgPAYrErnieTU798uMPe/hzv9v47HnNRGh GhHGfdSpKCYEwye0y3wcXiCAwbGFS8KEipWQs0VJiK3twmdfT3U= =Uovl -----END PGP SIGNATURE----- --=-=-=--