Subject: [bug#73494] [PATCH v6 1/3] services: activation: Continue on exceptions.

From: Maxim Cournoyer <[email-masked]>
Date: Thu, 08 May 2025 14:54:30 +0900

Hi,

Ludovic Courtès <[email-masked]> writes:

> Hilton Chain <[email-masked]> writes:
>
>> * gnu/services.scm (activation-script): Reset environment before loading
>> activation script.
>> Catch exception and print the error.
>> Warn about failed activation script.
>>
>> Change-Id: I89be31433fbb46d0c4a9dc6115ab167910840b6f
>
> [...]
>
>> +                      (for-each (lambda (action)
>> +                                  ;; Don't block activation process when one
>> +                                  ;; action fails.
>> +                                  (guard (condition
>> +                                          (else
>> +                                           (format (current-error-port) "~a~%"
>> +                                                   condition)
>> +                                           (warning
>> +                                            (G_ "failed to activate '~a'~%")
>> +                                            action)))
>> +                                    (save-module-excursion
>> +                                     (lambda ()
>> +                                       (set-current-module
>> +                                        (make-fresh-user-module))
>> +                                       (primitive-load action)))))
>> +                                '#$actions)))))
>
> LGTM.

Thanks.  I've pushed just this 1/3 patch so far.  We still need to
understand why the use of shepherd-system-log-service hangs the jami
service (dbus daemon), *only* when /run is mounted on a tmpfs (!).

-- 
Thanks,
Maxim