GNU bug report logs - #7349
24.0.50; "e" should work in vc-dir-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7349 in the body.
You can then email your comments to 7349 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: rogers-emacs <at> rgrjr.dyndns.org
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; "e" should work in vc-dir-mode
Date: Sat, 6 Nov 2010 17:20:51 -0400

   It has long annoyed me that "e" finds the file in dired-mode, but
just beeps in vc-dir-mode.  The patch below rectifies the situation.

					-- Bob Rogers
					   http://www.rgrjr.com/

------------------------------------------------------------------------
diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
index 4397251..5c8b690 100644
--- a/lisp/vc/vc-dir.el
+++ b/lisp/vc/vc-dir.el
@@ -266,6 +266,7 @@ See `run-hooks'."
     (define-key map [C-up] 'vc-dir-previous-directory)
     ;; The remainder.
     (define-key map "f" 'vc-dir-find-file)
+    (define-key map "e" 'vc-dir-find-file)	;; dired-mode compatibility.
     (define-key map "\C-m" 'vc-dir-find-file)
     (define-key map "o" 'vc-dir-find-file-other-window)
     (define-key map "\C-c\C-c" 'vc-dir-kill-dir-status-process)

Message #12 received at 7349-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 7349-done <at> debbugs.gnu.org
Subject: Re: 24.0.50; "e" should work in vc-dir-mode
Date: Thu, 03 Mar 2011 02:32:55 -0500

Version: 24.1

rogers-emacs <at> rgrjr.dyndns.org wrote:

>    It has long annoyed me that "e" finds the file in dired-mode, but
> just beeps in vc-dir-mode.  The patch below rectifies the situation.

OK, be annoyed no longer.

Message #15 received at 7349 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 7349 <at> debbugs.gnu.org
Cc: rgm <at> gnu.org
Subject: Re: bug#7349: 24.0.50; "e" should work in vc-dir-mode
Date: Thu, 03 Mar 2011 23:33:27 -0500

>> It has long annoyed me that "e" finds the file in dired-mode, but
>> just beeps in vc-dir-mode.

vc-dir-mode lacks many of dired bindings.  That's one of the reasons to
have a different mode.


        Stefan

Message #18 received at 7349 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 7349 <at> debbugs.gnu.org
Subject: Re: bug#7349: 24.0.50; "e" should work in vc-dir-mode
Date: Fri, 04 Mar 2011 00:08:38 -0500

Stefan Monnier wrote:

> vc-dir-mode lacks many of dired bindings.  That's one of the reasons to
> have a different mode.

Don't know what that means. Feel free to revert and tag this wontfix.
(Being small-minded, I like consistency.)

Message #21 received at 7349 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 7349 <at> debbugs.gnu.org
Subject: Re: bug#7349: 24.0.50; "e" should work in vc-dir-mode
Date: Fri, 04 Mar 2011 22:59:05 -0500

>> vc-dir-mode lacks many of dired bindings.  That's one of the reasons to
>> have a different mode.
> Don't know what that means. Feel free to revert and tag this wontfix.
> (Being small-minded, I like consistency.)

That it's also good to keep keys open for future use.
I'm not asking to revert the change, just pointing out that we should
not do those things too lightly.  VC-dir hasn't seen much improvement
and is still *very* primitive, sadly, but there's a lot of room for
improvement and this might end up wanting a lot of keys.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.