From unknown Sat Jul 26 08:55:17 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73487 <73487@debbugs.gnu.org> To: bug#73487 <73487@debbugs.gnu.org> Subject: Status: [PATCH] ; * src/cm.c (cmgoto): Add function documentation Reply-To: bug#73487 <73487@debbugs.gnu.org> Date: Sat, 26 Jul 2025 15:55:17 +0000 retitle 73487 [PATCH] ; * src/cm.c (cmgoto): Add function documentation reassign 73487 emacs submitter 73487 Jeremy Bryant severity 73487 normal tag 73487 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 17:33:38 2024 Received: (at submit) by debbugs.gnu.org; 25 Sep 2024 21:33:38 +0000 Received: from localhost ([127.0.0.1]:56919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stZdi-0003fd-3L for submit@debbugs.gnu.org; Wed, 25 Sep 2024 17:33:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:57052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stZdg-0003fT-JG for submit@debbugs.gnu.org; Wed, 25 Sep 2024 17:33:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stZdF-0007If-6a for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2024 17:33:09 -0400 Received: from out-174.mta0.migadu.com ([2001:41d0:1004:224b::ae]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stZdC-0002qG-DE for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2024 17:33:08 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1727299981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=jpox58Z50krgBJd+FZ+rNnosZwJbaq+EPkntxKHO98I=; b=rhejqsrajUcC5ZkYUeHHI4MEN7LwwPSv4WCxngOZ3rEX62MqBrQtzdwIjp/Xo9PEZnNRMl 9my3gRSxglsh1n5OTg1kX8tPTXgSWyXWDh8e/ThJyTupg+tQ4PbAgvepSnoufd70SEV7TZ CpqoRHNGf1QCHUViNaQa1V3aW6TQt7QjD+vmOcId6bGpewXKoUtXMLIXYEmQrWCvRkPqmz BDzk/6q7uGUaeKoORX/6lpZCm1eN6p4MRK/z39qp2kuUHXTZEUGuij9TElRDhZ87oHAUn0 /re5plbYe5ja1NfjoYBcT07XPfdrsvqby2iiVQO6+q8HWJDfY8fjJIs3ygM6Lw== From: Jeremy Bryant To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; * src/cm.c (cmgoto): Add function documentation Date: Wed, 25 Sep 2024 22:32:56 +0100 Message-ID: <87msjvo1vb.fsf@jeremybryant.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::ae; envelope-from=jb@jeremybryant.net; helo=out-174.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain This proposed patch adds a function documentation where there was none. Please install on master or provide feedback for further work. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-src-cm.c-cmgoto-Add-function-documentation.patch >From 436d482337ad1a88436973337650473e6d7ace41 Mon Sep 17 00:00:00 2001 From: Jeremy Bryant Date: Wed, 25 Sep 2024 22:28:04 +0100 Subject: [PATCH] ; * src/cm.c (cmgoto): Add function documentation --- src/cm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cm.c b/src/cm.c index ad419ce0af1..0832eaf84b5 100644 --- a/src/cm.c +++ b/src/cm.c @@ -317,6 +317,10 @@ #define USEHOME 1 #define USELL 2 #define USECR 3 +/* + * Move the cursor to (row, col), by computing the optimal way. + */ + void cmgoto (struct tty_display_info *tty, int row, int col) { -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 03:23:21 2024 Received: (at 73487) by debbugs.gnu.org; 26 Sep 2024 07:23:21 +0000 Received: from localhost ([127.0.0.1]:49413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stiqP-0000Vm-0j for submit@debbugs.gnu.org; Thu, 26 Sep 2024 03:23:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stiqN-0000VS-I0 for 73487@debbugs.gnu.org; Thu, 26 Sep 2024 03:23:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stipq-00038j-R3; Thu, 26 Sep 2024 03:22:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=F5Hlrphkk5DkJ8ca74rBxQtAVEGExHSxlCnwIz3tq+4=; b=l17gkxXV73eG 9bi9JB8UiR1paWD0MoQJOr5FIAuIVXAymuCyHpeCBi2GWhbmnh410GjiGo3LtVM6L653kM1ApENuV U66cPUwW7iqBNCejDcta2lgSj+RUQ1JuZiHDPuUpUdb8LaUC9PjBQrhSWvuw7IE6fRGeqQoTIJb25 Bv49xmfOMKf5xN1eubv+zUfFutYbMTg8bf2QumCWGHZnthKYQrBfGVcy1jCQUkTtEdtBBDl4AmEL+ 6RGqezY0lasBZxJYBoUP2sdzMVq0qFte5L3ED51cIHv9ahawnThNry0UeINifFG63c1LRR94xvwHc 9IvsULk0d2FbRbEFTzuXhw==; Date: Thu, 26 Sep 2024 10:22:42 +0300 Message-Id: <868qvec20t.fsf@gnu.org> From: Eli Zaretskii To: Jeremy Bryant In-Reply-To: <87msjvo1vb.fsf@jeremybryant.net> (bug-gnu-emacs@gnu.org) Subject: Re: bug#73487: [PATCH] ; * src/cm.c (cmgoto): Add function documentation References: <87msjvo1vb.fsf@jeremybryant.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73487 Cc: 73487@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 25 Sep 2024 22:32:56 +0100 > From: Jeremy Bryant via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This proposed patch adds a function documentation where there was none. > > Please install on master or provide feedback for further work. We usually prefer non-block comments, certainly when the comment is short. Can you use that in this case? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 18:02:52 2024 Received: (at 73487) by debbugs.gnu.org; 26 Sep 2024 22:02:52 +0000 Received: from localhost ([127.0.0.1]:55660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stwZY-0001C3-Fb for submit@debbugs.gnu.org; Thu, 26 Sep 2024 18:02:52 -0400 Received: from out-173.mta1.migadu.com ([95.215.58.173]:57698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stwZW-0001Bd-5z for 73487@debbugs.gnu.org; Thu, 26 Sep 2024 18:02:51 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1727387679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uT4UUvJyFMUmERxDQHs822tEeBkKni6atz/lVqXqLec=; b=jbHVLw+MreeweGTVpT2gpGEsFR2evjaW1HskdsUmq5i6iQ//TOy3ZOQQYG+O0c0QPgX7Gd 4NGLTM4jUOlRslI1KjjmVUtRFhf1P/w4JOlXcO1ygUq4zu4jZKjCuXzvN2y58BqtxCPDni bKyab/9jsgonEw1tl0QP7HyK5wF1jS1eilUsL86yE/L8QjjLF4zhgf6KXFKCZ1mC7t0RIc Jt5Qf2267IFWWlqLD3pn2NYM9k+DJrTJOdEghYduG89b6tEfmArrzVydR82DoX4Ww0iZbn jFGu4ZNWOa02ZfJrs+hDXJsXSWiewZsAwuVvna5N2izgi807XA67bzqlhLWU7g== From: Jeremy Bryant To: Eli Zaretskii Subject: Re: bug#73487: [PATCH] ; * src/cm.c (cmgoto): Add function documentation In-Reply-To: <868qvec20t.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 26 Sep 2024 10:22:42 +0300") References: <87msjvo1vb.fsf@jeremybryant.net> <868qvec20t.fsf@gnu.org> Date: Thu, 26 Sep 2024 22:54:36 +0100 Message-ID: <87bk0ankrn.fsf@jeremybryant.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73487 Cc: 73487@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Date: Wed, 25 Sep 2024 22:32:56 +0100 >> From: Jeremy Bryant via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> This proposed patch adds a function documentation where there was none. >> >> Please install on master or provide feedback for further work. > > We usually prefer non-block comments, certainly when the comment is > short. Can you use that in this case? > > Thanks. Yes, sure. Revised patch attached with the comment in a single line, rather than a block. (I tried to match the style of the surrounding areas of the file but now realise this was from 1992) Please install on master or provide feedback for further work. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-src-cm.c-cmgoto-Add-function-documentation.patch >From afc9916447528682d72a6bd9429b2a6e91d4d28a Mon Sep 17 00:00:00 2001 From: Jeremy Bryant Date: Wed, 25 Sep 2024 22:28:04 +0100 Subject: [PATCH] ; * src/cm.c (cmgoto): Add function documentation --- src/cm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cm.c b/src/cm.c index ad419ce0af1..e1014af5298 100644 --- a/src/cm.c +++ b/src/cm.c @@ -317,6 +317,8 @@ #define USEHOME 1 #define USELL 2 #define USECR 3 +/* Move the cursor to (row, col), by computing the optimal way. */ + void cmgoto (struct tty_display_info *tty, int row, int col) { -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 27 02:21:40 2024 Received: (at 73487-done) by debbugs.gnu.org; 27 Sep 2024 06:21:40 +0000 Received: from localhost ([127.0.0.1]:45274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1su4MG-0000H5-3F for submit@debbugs.gnu.org; Fri, 27 Sep 2024 02:21:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1su4MB-0000GP-Qk for 73487-done@debbugs.gnu.org; Fri, 27 Sep 2024 02:21:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1su4Le-0004eT-4m; Fri, 27 Sep 2024 02:21:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rkzhAn7Yy+hsLDxVIamUR6Pw1kYljMa/JjNeyUewwzc=; b=Z6asuPmEJPLP H1Nfo9PPyr5/IJkCQa04kOL4fs1cfT9tapGYcdwhQ3klabwK8UVtSMwsoWUCzxV8cD+16QQQSxbRc F7V3tY7VU0UEJ5J3ycxlb4Fg+NrFQOGEb+CdMQ6GBrAWszQr/BOF7zUJBk0DJf658ezxrSUUg9TVi kSURuf3UIxoM4oUO5LQR5g9GUXt5iSJk4DLCEcTJou2xX5FvAbearN6lNSzD4d4iKwNdVHzEYOfAp Ku9bgZJGFwKemQx5QfHkCukW/jwD2Y/2DIfD5QzH64PoxQeLTuta4RnYWI5pfK86IaWMI78vEf1jr 9UCcBicOgG3HQ6tnUnpDAg==; Date: Fri, 27 Sep 2024 09:20:58 +0300 Message-Id: <86zfnt8vn9.fsf@gnu.org> From: Eli Zaretskii To: Jeremy Bryant In-Reply-To: <87bk0ankrn.fsf@jeremybryant.net> (message from Jeremy Bryant on Thu, 26 Sep 2024 22:54:36 +0100) Subject: Re: bug#73487: [PATCH] ; * src/cm.c (cmgoto): Add function documentation References: <87msjvo1vb.fsf@jeremybryant.net> <868qvec20t.fsf@gnu.org> <87bk0ankrn.fsf@jeremybryant.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73487-done Cc: 73487-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jeremy Bryant > Cc: 73487@debbugs.gnu.org > Date: Thu, 26 Sep 2024 22:54:36 +0100 > > > We usually prefer non-block comments, certainly when the comment is > > short. Can you use that in this case? > > > > Thanks. > > Yes, sure. Revised patch attached with the comment in a single line, > rather than a block. Thanks, installed, with 2 more nits I failed to mention. > (I tried to match the style of the surrounding areas of the file but now > realise this was from 1992) Yeah, this is WIP... From unknown Sat Jul 26 08:55:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Oct 2024 11:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator