Subject: bug#73487: closed (Re: bug#73487: [PATCH] ; * src/cm.c (cmgoto): Add function documentation)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 27 Sep 2024 06:22:02 +0000

Your bug report

#73487: [PATCH] ; * src/cm.c (cmgoto): Add function documentation

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
73487: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73487
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#73487: [PATCH] ; * src/cm.c (cmgoto): Add function documentation
From: Eli Zaretskii <[email-masked]>
To: Jeremy Bryant <[email-masked]>
Cc: [email-masked]
Date: Fri, 27 Sep 2024 09:20:58 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Jeremy Bryant <[email-masked]>
> Cc: [email-masked]
> Date: Thu, 26 Sep 2024 22:54:36 +0100
> 
> > We usually prefer non-block comments, certainly when the comment is
> > short.  Can you use that in this case?
> >
> > Thanks.
> 
> Yes, sure.  Revised patch attached with the comment in a single line,
> rather than a block.

Thanks, installed, with 2 more nits I failed to mention.

> (I tried to match the style of the surrounding areas of the file but now
> realise this was from 1992)

Yeah, this is WIP...

Subject: [PATCH] ; * src/cm.c (cmgoto): Add function documentation
From: Jeremy Bryant <[email-masked]>
To: [email-masked]
Date: Wed, 25 Sep 2024 22:32:56 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

This proposed patch adds a function documentation where there was none.

Please install on master or provide feedback for further work.

>From 436d482337ad1a88436973337650473e6d7ace41 Mon Sep 17 00:00:00 2001
From: Jeremy Bryant <[email-masked]>
Date: Wed, 25 Sep 2024 22:28:04 +0100
Subject: [PATCH] ; * src/cm.c (cmgoto): Add function documentation

---
 src/cm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/cm.c b/src/cm.c
index ad419ce0af1..0832eaf84b5 100644
--- a/src/cm.c
+++ b/src/cm.c
@@ -317,6 +317,10 @@ #define	USEHOME	1
 #define	USELL	2
 #define	USECR	3
 
+/*
+ * Move the cursor to (row, col), by computing the optimal way.
+ */
+
 void
 cmgoto (struct tty_display_info *tty, int row, int col)
 {
-- 
2.45.2