From unknown Fri Jul 25 05:51:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73485: [PATCH] * ; src/cm.c (calccost): Improve comment readability Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Sep 2024 21:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73485 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 73485@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172729944311174 (code B ref -1); Wed, 25 Sep 2024 21:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Sep 2024 21:24:03 +0000 Received: from localhost ([127.0.0.1]:56244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stZUQ-0002u4-HF for submit@debbugs.gnu.org; Wed, 25 Sep 2024 17:24:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:40018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stZUO-0002ta-Jd for submit@debbugs.gnu.org; Wed, 25 Sep 2024 17:24:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stZTv-0005r8-HX for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2024 17:23:32 -0400 Received: from out-177.mta0.migadu.com ([2001:41d0:1004:224b::b1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stZTt-0001kD-Mu for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2024 17:23:31 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1727299405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=llC3yt8cXni0HPTHLBf2smSvRWxIB9n9n2KeufeWXh4=; b=ovz4dXkgrdIbWeNu9HdczGEcPiwvmlELQFcfbYAl3P1Z2psvd0+IkU4x/lqZBoi+0u6OWI WiD8qIfN28OW4NTQo8VONjejtdje8Nlq1J0QEWlUzy9Hzld/oaVwMpQffbLEmWk35uaL/v VIXzCCZTk1b80+YJ2mV84KXGmG6eFUteLbYqOerJZ7hJNsHnu9aA5iX18X1xoPtMEYFCW5 /mXBCtH7sHEZP2COXYtKGVUjCx7C/6T0Kx+ZClUBczutBTINLlkvwgfD+bh6qZl+DeIxrZ f0RqoCLJwSRKch3MM2JbJmMr/346oQzF7yXwXxCJuzBUG2PlXv5dwoCjV5xjvA== From: Jeremy Bryant Date: Wed, 25 Sep 2024 22:23:10 +0100 Message-ID: <87v7yjo2bl.fsf@jeremybryant.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::b1; envelope-from=jb@jeremybryant.net; helo=out-177.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain This patch is to improve comment readability and correct an apparent typo. Please install on master or provide feedback for further work. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-src-cm.c-calccost-Improve-comment-readability.patch >From 72854046e50e1d2e833ee8b2a2ced4fdaa665b05 Mon Sep 17 00:00:00 2001 From: Jeremy Bryant Date: Wed, 25 Sep 2024 22:04:23 +0100 Subject: [PATCH] * ; src/cm.c (calccost): Improve comment readability --- src/cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cm.c b/src/cm.c index 67fafa29bcc..ad419ce0af1 100644 --- a/src/cm.c +++ b/src/cm.c @@ -193,7 +193,7 @@ calccost (struct tty_display_info *tty, tabcost; register const char *p; - /* If have just wrapped on a terminal with xn, + /* If we have just wrapped on a terminal with xn, don't believe the cursor position: give up here and force use of absolute positioning. */ -- 2.45.2 --=-=-=-- From unknown Fri Jul 25 05:51:26 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jeremy Bryant Subject: bug#73485: closed (Re: bug#73485: [PATCH] * ; src/cm.c (calccost): Improve comment readability) Message-ID: References: <87v7yjo2bl.fsf@jeremybryant.net> X-Gnu-PR-Message: they-closed 73485 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 73485@debbugs.gnu.org Date: Wed, 25 Sep 2024 23:50:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1727308202-17949-1" This is a multi-part message in MIME format... ------------=_1727308202-17949-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #73485: [PATCH] * ; src/cm.c (calccost): Improve comment readability which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 73485@debbugs.gnu.org. --=20 73485: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73485 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1727308202-17949-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 73485-done) by debbugs.gnu.org; 25 Sep 2024 23:49:05 +0000 Received: from localhost ([127.0.0.1]:35384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stbkm-0004dh-KW for submit@debbugs.gnu.org; Wed, 25 Sep 2024 19:49:04 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:60880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stbkl-0004dA-7m for 73485-done@debbugs.gnu.org; Wed, 25 Sep 2024 19:49:04 -0400 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4280ca0791bso3226915e9.1 for <73485-done@debbugs.gnu.org>; Wed, 25 Sep 2024 16:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727308051; x=1727912851; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=JP/BCuETGk3Yaehofh9fI1KD68GrvcFHzzI8Gjwy2rU=; b=ODHobbDMGU1c3lAvfVrXdLABPm1OOt/EcQ+/PfOcR/VRAfMwhsKtmUfFEP+rp9pIg2 dl8fuqoRiWje8uQevhXOJ1f9KvSKkmRjd6vLa/VBZWFOMfcRrMg7WId340TdRrzZM7J/ lpwS9j3bbhhp31crgv2ygcTg6P++lqY1nMRTMADgA9rdElUZVTkkHOcyZK0so9JlrNHa Qo6Oe2xgD0HaHeC/jmkRZf0RyiX9XZysrC3pyFKruv4biOvpx7XRVOpqxkpaMg53lI+W QvI4tR098aPz0k/ZFSJk05SVcztecXgT+AEzvLv7L1BHDP/lWL0cQIOFtuNxED1KQjHS hLFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727308051; x=1727912851; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JP/BCuETGk3Yaehofh9fI1KD68GrvcFHzzI8Gjwy2rU=; b=klTVOrUx1a7VlQoN1boAZbFMWVwglzpHQ5B7E695cxRThSf9qt5qoXa/WGUhHsjKRF QUlr/DetBS6tSsV8PcuQdtZ1xa3pPhEJ7CqBtMQbcIMthQMljtMnzgVXmUOwyzzRvZRO mWWjpUX+Jm1SEFaeDQWQplW4LZnW6qTTqu3Q2vFKSEd7iyZmhkmh3SnoK+04Ca5OrAOT /T8HBIwcu5pU1pMjGu58LsWd2XUUXnaYM5xxT4RBEA2ayZwDvZLfspUR0boPy/cBofCW Xlo4efNQfSG/e1J45XthSdapAUSuXdlUcsbjIwH9H82HHXt6//knquYIrRB22XkvvOjL M/fQ== X-Forwarded-Encrypted: i=1; AJvYcCXBB0mUjwFvCL+iR8ag6BK6tIwv5sMcvUqRSxCb/LplG07QJV/QUrdHPfj9Zs9JGfkaKfROnh3lNtUN@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzrk/I4omd+YddhlrWKsGr414vSuaRzQ1teNYFAP2yR9Gs7v0u0 0L/uK1eqNLqC8sUouI6whvGsQcd5r2iKuI9kPfXTREgLbS0LjEMGUW+fd5Bk9hiEuBH9m4+DpJF PzmfDj+hrpsPmoHomXHQ7QtUxk/c= X-Google-Smtp-Source: AGHT+IEVFYgXVn9Mn/Qx0uvaEk747BUo/GO9fPE9hzmy25j69j93e3U4gvgUtGXgcz4LY0qjx9PGn3vDwlqSdQVWkm4= X-Received: by 2002:a05:6000:1fa4:b0:374:c7a3:3349 with SMTP id ffacd0b85a97d-37cc24c7355mr3302209f8f.51.1727308050643; Wed, 25 Sep 2024 16:47:30 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 25 Sep 2024 16:47:30 -0700 From: Stefan Kangas In-Reply-To: <87v7yjo2bl.fsf@jeremybryant.net> References: <87v7yjo2bl.fsf@jeremybryant.net> MIME-Version: 1.0 Date: Wed, 25 Sep 2024 16:47:30 -0700 Message-ID: Subject: Re: bug#73485: [PATCH] * ; src/cm.c (calccost): Improve comment readability To: Jeremy Bryant , 73485-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73485-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > This patch is to improve comment readability and correct an apparent > typo. > > Please install on master or provide feedback for further work. Thanks, installed on master (commit 0c861b820b7). I'm therefore closing this bug report. ------------=_1727308202-17949-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Sep 2024 21:24:03 +0000 Received: from localhost ([127.0.0.1]:56244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stZUQ-0002u4-HF for submit@debbugs.gnu.org; Wed, 25 Sep 2024 17:24:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:40018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stZUO-0002ta-Jd for submit@debbugs.gnu.org; Wed, 25 Sep 2024 17:24:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stZTv-0005r8-HX for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2024 17:23:32 -0400 Received: from out-177.mta0.migadu.com ([2001:41d0:1004:224b::b1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stZTt-0001kD-Mu for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2024 17:23:31 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1727299405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=llC3yt8cXni0HPTHLBf2smSvRWxIB9n9n2KeufeWXh4=; b=ovz4dXkgrdIbWeNu9HdczGEcPiwvmlELQFcfbYAl3P1Z2psvd0+IkU4x/lqZBoi+0u6OWI WiD8qIfN28OW4NTQo8VONjejtdje8Nlq1J0QEWlUzy9Hzld/oaVwMpQffbLEmWk35uaL/v VIXzCCZTk1b80+YJ2mV84KXGmG6eFUteLbYqOerJZ7hJNsHnu9aA5iX18X1xoPtMEYFCW5 /mXBCtH7sHEZP2COXYtKGVUjCx7C/6T0Kx+ZClUBczutBTINLlkvwgfD+bh6qZl+DeIxrZ f0RqoCLJwSRKch3MM2JbJmMr/346oQzF7yXwXxCJuzBUG2PlXv5dwoCjV5xjvA== From: Jeremy Bryant To: bug-gnu-emacs@gnu.org Subject: [PATCH] * ; src/cm.c (calccost): Improve comment readability Date: Wed, 25 Sep 2024 22:23:10 +0100 Message-ID: <87v7yjo2bl.fsf@jeremybryant.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::b1; envelope-from=jb@jeremybryant.net; helo=out-177.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain This patch is to improve comment readability and correct an apparent typo. Please install on master or provide feedback for further work. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-src-cm.c-calccost-Improve-comment-readability.patch >From 72854046e50e1d2e833ee8b2a2ced4fdaa665b05 Mon Sep 17 00:00:00 2001 From: Jeremy Bryant Date: Wed, 25 Sep 2024 22:04:23 +0100 Subject: [PATCH] * ; src/cm.c (calccost): Improve comment readability --- src/cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cm.c b/src/cm.c index 67fafa29bcc..ad419ce0af1 100644 --- a/src/cm.c +++ b/src/cm.c @@ -193,7 +193,7 @@ calccost (struct tty_display_info *tty, tabcost; register const char *p; - /* If have just wrapped on a terminal with xn, + /* If we have just wrapped on a terminal with xn, don't believe the cursor position: give up here and force use of absolute positioning. */ -- 2.45.2 --=-=-=-- ------------=_1727308202-17949-1--