GNU bug report logs - #73474
Bug in factor utility of coreutils

Previous Next

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Pádraig Brady <P <at> draigBrady.com>, anasonov <at> astralinux.ru
Cc: 73474-done <at> debbugs.gnu.org
Subject: bug#73474: Bug in factor utility of coreutils
Date: Fri, 27 Sep 2024 17:50:51 -0700

[Message part 1 (text/plain, inline)]

On 2024-09-25 13:48, Pádraig Brady wrote:
> 
> Note factor does give the correct result on amd64 at least
> without the asserts:

Yes, as far as I know the existing code works correctly on all practical 
platforms. It's only pedantic/checking platforms, where shifts by 
negative or by too-large result in crashes or diagnostics, where the 
existing code fails.

The bug is easy to fix and the fixdoesn't hurt performance 
significantly, so I installed the attached. Closing the bug report.

While looking into this I got seduced by the prospect of making 'factor' 
a bit better (e.g., eliminate some recursion and fix some buffering 
issues) and installed a bunch of followup patches for 'factor'. Yeah, 
yeah, I should know better....

[0001-factor-port-to-platforms.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.