GNU bug report logs - #73472
[PATCH] Substitute quotation marks in Eglot messages

Previous Next

Full log

Message #58 received at 73472 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Thomas Voss <mail <at> thomasvoss.com>, 73472 <at> debbugs.gnu.org
Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages
Date: Thu, 12 Dec 2024 10:57:48 +0000

On Thu, Dec 12, 2024 at 10:50 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> > Date: Mon, 09 Dec 2024 19:01:28 +0100
> > From: "Thomas Voss" <mail <at> thomasvoss.com>
> >
> > Apologies for the long delay; I have been super busy recently.
> >
> > > Ping!
> > >
> > > > Thanks.  João, any comments?
> > > >
> > > > My only comment is that the log message says "format-prompt", but the
> > > > code actually uses substitute-quotes.
> >
> > Uh… are we looking at the same patch?  The log message in the patch I
> > last sent does say ‘substitute-quotes’ for all the places where I used
> > that function, and only says ‘format-prompt’ for the place where I used
> > that function (‘eglot-rename’).
> >
> > Just in case, I attached the patch again to this email.
>
> Thanks.
>
> João, are you okay with me installing this?

Just had a look. The patch won't break anything, but it has some problems
around the part where substitute quotes isn't around a literal, but wraps
a bigger block.  I'll try to fix it.  It would also be great to have some file
local symbol-shortening mechanism to avoid that long name, but I'm
not going to worry about that.

João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.