From unknown Fri Jun 20 07:14:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73472 <73472@debbugs.gnu.org> To: bug#73472 <73472@debbugs.gnu.org> Subject: Status: [PATCH] Substitute quotation marks in Eglot messages Reply-To: bug#73472 <73472@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:14:01 +0000 retitle 73472 [PATCH] Substitute quotation marks in Eglot messages reassign 73472 emacs submitter 73472 "Thomas Voss" severity 73472 wishlist tag 73472 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 10:04:26 2024 Received: (at submit) by debbugs.gnu.org; 25 Sep 2024 14:04:26 +0000 Received: from localhost ([127.0.0.1]:38510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stScz-0004tJ-Qi for submit@debbugs.gnu.org; Wed, 25 Sep 2024 10:04:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:45972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stScx-0004t2-7U for submit@debbugs.gnu.org; Wed, 25 Sep 2024 10:04:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stScT-00075V-IZ for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2024 10:03:55 -0400 Received: from out-176.mta0.migadu.com ([2001:41d0:1004:224b::b0]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stScO-0007mY-CA for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2024 10:03:53 -0400 Content-Type: multipart/mixed; boundary=470923daacce4f2043053d4283737707a8449f77d8f326103c1ed619128c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thomasvoss.com; s=key1; t=1727273024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=fCOm5ZDNBMzC1WIvYiPv1Yu3rW0Iw3I1CX3PIxe+8qs=; b=Ivx7hHJBZNL14mYhVQi4hljMQv1QOvNgKmOSEJn883XtjhaavfW5YbePIjnVG3xC9eEJUr bL39OYDTNgdDwUfIQuFWsL6Z7YrUge4dzHpeL2+9w14KhQZoiK64FjxPzOCyQlA+6278iQ OjtDQOApNX+FTm2uqTgm4spzfVzMt95g7eh2yQ3sH/d5dogwYGEWmOkLeZh30QscvJ010X 7/czlRAx10eFNxzvNgBiXYrRekLurcfUUGGzu+6npcWiFy0Dh1Ul/QFMnSkmGcAywW+HBh dmNsZVNq00Tc+cTtt5BA2xUXawCys7qXxNeGPl+xm+ZMzaqYaxl6rSyHcq0Z2Q== Date: Wed, 25 Sep 2024 16:03:32 +0200 Message-Id: Subject: [PATCH] Substitute quotation marks in Eglot messages X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Thomas Voss" To: Mime-Version: 1.0 X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::b0; envelope-from=mail@thomasvoss.com; helo=out-176.mta0.migadu.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --470923daacce4f2043053d4283737707a8449f77d8f326103c1ed619128c Content-Type: multipart/alternative; boundary=9ff7980ce531d5fb9aa2c8a2c969667a3d4d247e51fb6da2ce32374e6c24 --9ff7980ce531d5fb9aa2c8a2c969667a3d4d247e51fb6da2ce32374e6c24 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-Type: text/plain; charset=UTF-8 Hi all, Another quick patch from myself. This patch makes it so that the diagnostics and interactive prompts from Eglot (such as the prompt you iteract with when renaming a symbol) properly respect =E2=80=98text-quoting-style=E2=80=99. --=20 =E2=80=94 Thomas --9ff7980ce531d5fb9aa2c8a2c969667a3d4d247e51fb6da2ce32374e6c24-- --470923daacce4f2043053d4283737707a8449f77d8f326103c1ed619128c Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Substitute-quotation-marks-in-Eglot-messages.patch Content-Type: text/x-patch; charset=utf-8; name=0001-Substitute-quotation-marks-in-Eglot-messages.patch RnJvbSAyMDM4Yjk4M2E3NTFhMmUyNmMyZThhMGI4ZDU1YWRlMjlmYjM5NGZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgVm9zcyA8bWFpbEB0aG9tYXN2b3NzLmNvbT4KRGF0 ZTogV2VkLCAyNSBTZXAgMjAyNCAxNTo1MTozNiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFN1YnN0 aXR1dGUgcXVvdGF0aW9uIG1hcmtzIGluIEVnbG90IG1lc3NhZ2VzCgoqIGxpc3AvcHJvZ21vZGVz L2VnbG90LmVsIChlZ2xvdC0tZXJyb3IpIChlZ2xvdC0tbWVzc2FnZSk6IFdyYXAgdGhlCm1lc3Nh Z2UgaW4gYHN1YnN0aXR1dGUtcXVvdGVzJy4KKiBsaXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbCAoZWds b3QtcmVuYW1lKTogRm9ybWF0IHRoZSBwcm9tcHQgdXNpbmcKYGZvcm1hdC1wcm9tcHQnIGFzIG9w cG9zZWQgdG8gYGZvcm1hdCcuCgpDb3B5cmlnaHQtcGFwZXJ3b3JrLWV4ZW1wdDogeWVzCi0tLQog bGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwgfCA4ICsrKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBp bnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVz L2VnbG90LmVsIGIvbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwKaW5kZXggYTM1OGI4Mi4uZWU1Mjc2 NyAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwKKysrIGIvbGlzcC9wcm9nbW9k ZXMvZWdsb3QuZWwKQEAgLTE2OTgsMTEgKzE2OTgsMTEgQEAgZWdsb3QtLWNvbm5lY3QKIDs7Owog KGRlZnVuIGVnbG90LS1lcnJvciAoZm9ybWF0ICZyZXN0IGFyZ3MpCiAgICJFcnJvciBvdXQgd2l0 aCBGT1JNQVQgd2l0aCBBUkdTLiIKLSAgKGVycm9yICJbZWdsb3RdICVzIiAoYXBwbHkgIydmb3Jt YXQgZm9ybWF0IGFyZ3MpKSkKKyAgKGVycm9yICJbZWdsb3RdICVzIiAoc3Vic3RpdHV0ZS1xdW90 ZXMgKGFwcGx5ICMnZm9ybWF0IGZvcm1hdCBhcmdzKSkpKQogCiAoZGVmdW4gZWdsb3QtLW1lc3Nh Z2UgKGZvcm1hdCAmcmVzdCBhcmdzKQogICAiTWVzc2FnZSBvdXQgd2l0aCBGT1JNQVQgd2l0aCBB UkdTLiIKLSAgKG1lc3NhZ2UgIltlZ2xvdF0gJXMiIChhcHBseSAjJ2Zvcm1hdCBmb3JtYXQgYXJn cykpKQorICAobWVzc2FnZSAiW2VnbG90XSAlcyIgKHN1YnN0aXR1dGUtcXVvdGVzIChhcHBseSAj J2Zvcm1hdCBmb3JtYXQgYXJncykpKSkKIAogKGRlZnVuIGVnbG90LS13YXJuIChmb3JtYXQgJnJl c3QgYXJncykKICAgIldhcm5pbmcgbWVzc2FnZSB3aXRoIEZPUk1BVCBhbmQgQVJHUy4iCkBAIC0z NzA0LDggKzM3MDQsOCBAQCBlZ2xvdC1yZW5hbWUKICAgIlJlbmFtZSB0aGUgY3VycmVudCBzeW1i b2wgdG8gTkVXTkFNRS4iCiAgIChpbnRlcmFjdGl2ZQogICAgKGxpc3QgKHJlYWQtZnJvbS1taW5p YnVmZmVyCi0gICAgICAgICAgKGZvcm1hdCAiUmVuYW1lIGAlcycgdG86ICIgKG9yICh0aGluZy1h dC1wb2ludCAnc3ltYm9sIHQpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICJ1bmtub3duIHN5bWJvbCIpKQorICAgICAgICAgIChmb3JtYXQtcHJvbXB0ICJSZW5hbWUg YCVzJyB0byIgbmlsIChvciAodGhpbmctYXQtcG9pbnQgJ3N5bWJvbCB0KQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAidW5rbm93biBzeW1ib2wiKSkK ICAgICAgICAgICBuaWwgbmlsIG5pbCBuaWwKICAgICAgICAgICAoc3ltYm9sLW5hbWUgKHN5bWJv bC1hdC1wb2ludCkpKSkpCiAgIChlZ2xvdC1zZXJ2ZXItY2FwYWJsZS1vci1sb3NlIDpyZW5hbWVQ cm92aWRlcikKLS0gCjIuNDYuMgoK --470923daacce4f2043053d4283737707a8449f77d8f326103c1ed619128c-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 12:02:17 2024 Received: (at 73472) by debbugs.gnu.org; 25 Sep 2024 16:02:17 +0000 Received: from localhost ([127.0.0.1]:43519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stUT2-0004cr-Up for submit@debbugs.gnu.org; Wed, 25 Sep 2024 12:02:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stUT0-0004cY-OQ for 73472@debbugs.gnu.org; Wed, 25 Sep 2024 12:02:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stUSV-0007fi-Do; Wed, 25 Sep 2024 12:01:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Ch21CkHcw4qoY3lFyfnJRU5OpRldB4HHNPL1BPdpUHI=; b=QxZ3DGW3O04pJHyPL4Hc P55HVtVOzoz+fbsC3B+VtT4z5xSG+MFiz64RXhpORJklJ8DAmwJc2zN1oJpEK41nMnrDQ5+o/3KWV +srObjHlDx2z/gmyWNTZOf/0XF/MyyVHF9o8uzZs+XmWO+75+R4aKoHPbku1MOfllTSwgLBzPCIby rJ9BnVKVAKIjfGa/loQRI04+pcqCjVz0d7P39Yx7bTJHuvO4RNVKI6giJpymSxaT1j7Hr4xGd+rvk wtzNBrdw1wqxSZu1AuRjIAWlOWymtOWP2SXKovFph2eS6Pd9LGz8XZoiGH0t7N4w5Xt/KZxnp5pDr zitQwOy2GFl15A==; Date: Wed, 25 Sep 2024 19:01:32 +0300 Message-Id: <86setnbu3n.fsf@gnu.org> From: Eli Zaretskii To: "Thomas Voss" , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 25 Sep 2024 16:03:32 +0200 > From: "Thomas Voss" via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Another quick patch from myself. This patch makes it so that the > diagnostics and interactive prompts from Eglot (such as the prompt you > iteract with when renaming a symbol) properly respect > ‘text-quoting-style’. Thanks. > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -1698,11 +1698,11 @@ eglot--connect > ;;; > (defun eglot--error (format &rest args) > "Error out with FORMAT with ARGS." > - (error "[eglot] %s" (apply #'format format args))) > + (error "[eglot] %s" (substitute-quotes (apply #'format format args)))) > > (defun eglot--message (format &rest args) > "Message out with FORMAT with ARGS." > - (message "[eglot] %s" (apply #'format format args))) > + (message "[eglot] %s" (substitute-quotes (apply #'format format args)))) > > (defun eglot--warn (format &rest args) > "Warning message with FORMAT and ARGS." > @@ -3704,8 +3704,8 @@ eglot-rename > "Rename the current symbol to NEWNAME." > (interactive > (list (read-from-minibuffer > - (format "Rename `%s' to: " (or (thing-at-point 'symbol t) > - "unknown symbol")) > + (format-prompt "Rename `%s' to" nil (or (thing-at-point 'symbol t) > + "unknown symbol")) > nil nil nil nil > (symbol-name (symbol-at-point))))) > (eglot-server-capable-or-lose :renameProvider) Hmm... in the first two changes, how do we know that the quote characters are indeed quoting stuff in the context where we substitute quotes according to quoting-style? Those functions get strings they know nothing about, so it looks a bit risky to blindly convert any quoting characters there. Or what am I missing? From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 14:04:38 2024 Received: (at 73472) by debbugs.gnu.org; 25 Sep 2024 18:04:39 +0000 Received: from localhost ([127.0.0.1]:48586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stWNQ-0006Qy-H2 for submit@debbugs.gnu.org; Wed, 25 Sep 2024 14:04:38 -0400 Received: from out-180.mta1.migadu.com ([95.215.58.180]:44138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stWNJ-0006Oq-5E for 73472@debbugs.gnu.org; Wed, 25 Sep 2024 14:04:33 -0400 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thomasvoss.com; s=key1; t=1727287405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lMJBXIYcjWDZG0HFdbvS0uyYjdrGdoLXMEN1Pdw+6eQ=; b=4GMcHMtGpU4DdiysVGvxslDU0QNrGRk6ajIaskKdSVGBqSrHq/FEOjzGuSag+LRrxlDKFx HAJjPJM4PxzUWpg0OxkVXZqqbIIVqALKbfR6kNh/pIKiDVB6GgCm2Enavllqoq/XaMuN9E 9mct2ThXcWd6hmHqXN1mXKyVOUUighLxi8DIzGuFCJbKtMuhFFUgfSLgMd//IqafXAny8q 1Ni269TVy5O1kOfsGfs2TGZPbHAMVz7+D5nVbLyNAwJYXirP6ltpC9Cz8Db5fWG19lLado mLHqq3W/pF/z6ODmcO5jFKdr/O3nhv85RFiYm9XqvoxTT8LnCVOyoYI8EpymaA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 25 Sep 2024 20:03:20 +0200 Message-Id: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Thomas Voss" To: "Eli Zaretskii" , =?utf-8?q?Jo=C3=A3o_T=C3=A1vora?= Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: <86setnbu3n.fsf@gnu.org> In-Reply-To: <86setnbu3n.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Eli, On Wed Sep 25, 2024 at 6:01 PM CEST, Eli Zaretskii wrote: > > --- a/lisp/progmodes/eglot.el > > +++ b/lisp/progmodes/eglot.el > > @@ -1698,11 +1698,11 @@ eglot--connect > > ;;; > > (defun eglot--error (format &rest args) > > "Error out with FORMAT with ARGS." > > - (error "[eglot] %s" (apply #'format format args))) > > + (error "[eglot] %s" (substitute-quotes (apply #'format format args))= )) > > =20 > > (defun eglot--message (format &rest args) > > "Message out with FORMAT with ARGS." > > - (message "[eglot] %s" (apply #'format format args))) > > + (message "[eglot] %s" (substitute-quotes (apply #'format format args= )))) > > =20 > > (defun eglot--warn (format &rest args) > > "Warning message with FORMAT and ARGS." > > @@ -3704,8 +3704,8 @@ eglot-rename > > "Rename the current symbol to NEWNAME." > > (interactive > > (list (read-from-minibuffer > > - (format "Rename `%s' to: " (or (thing-at-point 'symbol t) > > - "unknown symbol")) > > + (format-prompt "Rename `%s' to" nil (or (thing-at-point 'sym= bol t) > > + "unknown symbol")) > > nil nil nil nil > > (symbol-name (symbol-at-point))))) > > (eglot-server-capable-or-lose :renameProvider) > > Hmm... in the first two changes, how do we know that the quote > characters are indeed quoting stuff in the context where we substitute > quotes according to quoting-style? Those functions get strings they > know nothing about, so it looks a bit risky to blindly convert any > quoting characters there. Or what am I missing? You=E2=80=99re right that it may be risky; I iterated through the usages of= these functions and nothing stood out to me as a potential location where some unexpected behaviour might occur, although it is true that there is the possibility. Not sure why I didn=E2=80=99t think of this when creating the patch, but it= =E2=80=99s probably a much better idea to change this: (substitute-quotes (apply #'format format args)) to this: (apply #'format (substitute-quotes format) args) This limits the scope of the substitution to just the format strings, where we know no funny business is going on. Unless you have any other reservations I could submit a v2 of the patch to do that. --=20 =E2=80=94 Thomas From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 01:54:53 2024 Received: (at 73472) by debbugs.gnu.org; 26 Sep 2024 05:54:53 +0000 Received: from localhost ([127.0.0.1]:44126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sthSn-0002R4-E4 for submit@debbugs.gnu.org; Thu, 26 Sep 2024 01:54:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sthSl-0002QZ-L6 for 73472@debbugs.gnu.org; Thu, 26 Sep 2024 01:54:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sthQ8-00014V-1q; Thu, 26 Sep 2024 01:52:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=FmI455X4npbnHIFV4QU1T3iFzd7MMcGCbOTzb7WJ16s=; b=I55tZ5q57kJfrnVniSnY STmt9rmhmhMfJ+THtOzV/FF7eAFavrrBdkcZt1aZRDMcEQCtrmduQZA7lDBQQ+0qhguPFC+ptswQ8 JCNFgjjw7L0RVYyaLnCUg5bLId2WDSlHBSZXL16piwKiPzVm4zA7rpU+eUAppOn8jnoENUgk2O0Ux geEN92HeMFRGg4Oa9uzYijHQMczUbds+HVZfo6O1en+Mhz5tvK1tZuZGHkLrfPHM4Pl+v+Fv1mu+3 FX4/dueBqGoK7CL8ePJCRpIG9XwKUh9bkCt5a1jMbQ255GJGEDQCf5bB514meI/ygofXiNwNGoYCB ZRG8FridUlBt2w==; Date: Thu, 26 Sep 2024 08:52:06 +0300 Message-Id: <86ldzfarnd.fsf@gnu.org> From: Eli Zaretskii To: "Thomas Voss" In-Reply-To: (mail@thomasvoss.com) Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: <86setnbu3n.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 25 Sep 2024 20:03:20 +0200 > From: "Thomas Voss" > Cc: <73472@debbugs.gnu.org> > > Not sure why I didn’t think of this when creating the patch, but it’s > probably a much better idea to change this: > > (substitute-quotes (apply #'format format args)) > > to this: > > (apply #'format (substitute-quotes format) args) > > This limits the scope of the substitution to just the format strings, > where we know no funny business is going on. That is of course better, but do we indeed know that format will never use quote characters for something that is not quoting? I think the caller should itself use substitute-quotes where appropriate. And I'd like to hear João's opinion as well. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 02:12:52 2024 Received: (at 73472) by debbugs.gnu.org; 26 Sep 2024 06:12:52 +0000 Received: from localhost ([127.0.0.1]:45297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sthkC-0003qA-6K for submit@debbugs.gnu.org; Thu, 26 Sep 2024 02:12:52 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:48143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sthk9-0003pi-Tp for 73472@debbugs.gnu.org; Thu, 26 Sep 2024 02:12:50 -0400 Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-710dead5d2aso369490a34.0 for <73472@debbugs.gnu.org>; Wed, 25 Sep 2024 23:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727331077; x=1727935877; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=N9uuVzMkIsb1oDstVHPsaMFoSV9KaOMfHpMq7S6z7KU=; b=SihB9NtXrhcAy+VFnEZ96LrNl+IErSiWlblVUcRK7uPiPC4Gbd7xi5yj1eSzMXz0QF jhhsz9J24qSvq4TCcqBtJf0eakJ/jpbMePnavqEPuXkL3rSLs5+/dZDgVlOIc7iY224+ Bybhx6zXhF/5cV3wBjiK2L+a72MEa1G15W8GrMFtZL7K9YoZ276A2vBaJCHc5jUXDDwA 4ttiG6Y8wTPC7fTSDkj0/fIIkbB0jH4iCi9rengQ6HQK/x+vucyyMOjmIpuV3O+e7ZJ6 KwPkwi19yNi7WYbjat91crGjf9AlGKig/j2Aa3qB7TByhhR7Q5Utckj87xC1s1SMCu22 Owvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727331077; x=1727935877; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N9uuVzMkIsb1oDstVHPsaMFoSV9KaOMfHpMq7S6z7KU=; b=PaiMOZlit2OY2DK7ndMGrZBFmVU/5jLDgZ/WrYOMs22UENlo1dTyq2qQnLdVFhX1ZG 6LcaT4vzEuC7RhlW+4L0bR3E0zx2L3gKxZovoAegua8ftPEI13cUCt0FWkdXD2Qihcy4 oWNdObzVGnGFmmdLyIYzENDvBJuHdQ0xVWXAJRzKgppc2yNJQFtzbzCcSvGg/hq/8zOB GXI6rTsvIjcp1EYZUJkm9Rh/IbYSD97OGTym7TTHmSCQSzN7JPF5EGttXmfnWQwWn6qO 5BjHK2NlG1Bv+nDIUvmWitkjgpvXgnf43QIMbqjEf6ViBo1mFNf+i9sbW+gN3rCKx7WN SU+A== X-Forwarded-Encrypted: i=1; AJvYcCXzZuvGodoOqQFgRhk6oktv7y6GmElYfRzUZmZyYH7z0EpWMxCuL7gGxvRofGwgdTNP4h3JKw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzRimeW4dDD3ZkSFUKajMFPrxC/hXRrPv9cEMixtQyZ91NlmVMu cTeiIpEdWNXBFZzywoYFOP9LCahAZUd9z5DCxJq0GGIJUzzK3B9xNXYdiZsSM2Uti6pWuMbMcYb eRI5q/DO9vjy4xlCQza2Htu+Zap8= X-Google-Smtp-Source: AGHT+IFwe0Eq610QlkrMv3WYzILUOcNlRB8qFW/79gO5AcPq0/b7SFAKlT1XmSu7wPK6GSY0+zUmd4N+xs50L++xkac= X-Received: by 2002:a05:6871:4ca:b0:27b:2e84:fedc with SMTP id 586e51a60fabf-286e143361cmr4006822fac.21.1727331076929; Wed, 25 Sep 2024 23:11:16 -0700 (PDT) MIME-Version: 1.0 References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> In-Reply-To: <86ldzfarnd.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Thu, 26 Sep 2024 07:11:05 +0100 Message-ID: Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000003fffd20622ff9bd0" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73472 Cc: Thomas Voss , 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003fffd20622ff9bd0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 26, 2024, 06:52 Eli Zaretskii wrote: I think the caller should itself use substitute-quotes where > appropriate. > > And I'd like to hear Jo=C3=A3o's opinion as well. > I think I think so too. What Eglot format strings are affected by this quote substitution? I.e. what problem is being solved here? Jo=C3=A3o > --0000000000003fffd20622ff9bd0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Sep 26, 2024, 06:52 Eli Zaretskii <eliz@gnu.org> wrote:

I think the caller should itself use substitute-quotes where
appropriate.

And I'd like to hear Jo=C3=A3o's opinion as well.
<= /div>

I think I think so= too. What Eglot format strings are affected by this quote substitution? I.= e. what problem is being solved here?=C2=A0

Jo=C3=A3o
--0000000000003fffd20622ff9bd0-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 29 21:36:38 2024 Received: (at control) by debbugs.gnu.org; 30 Sep 2024 01:36:39 +0000 Received: from localhost ([127.0.0.1]:43464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv5L4-0007rL-7A for submit@debbugs.gnu.org; Sun, 29 Sep 2024 21:36:38 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:46138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv5L2-0007qW-Jj for control@debbugs.gnu.org; Sun, 29 Sep 2024 21:36:37 -0400 Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5c8952f7f95so958228a12.0 for ; Sun, 29 Sep 2024 18:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727660099; x=1728264899; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=z1gMYweAcJ6XA7Av2B1DGqE9d4spupTYVwZEdm8Ik0A=; b=R0G7b0wd2uIS1CQo46IynagkFScMuED8vb1ZvWctMcoaS0D1U1dpHhTESsVK1JUgGI 52wgvnOP5tINEk3voy8VsBrRXhWLTmWOqWpcaWXbwBiwyDzTC5tQ/cmilWt0P9Suxo+j SqORylQwnN8+q4zKN6oMtyiahgEgtnW6zCYfUXJv3lBVff3rEShnmYTei6SCyAuPXKcG PtKZdAMmYRv4KsmC4I6J+nQa3cF0T5axwgy3mB91BM0z3zFdAN376LRTg8vEgGI3hCNO O7LtxyJCJP9OcMLQIbHxvPJs+65q5yZRPX++9vEc4EvU3gj/Lr+y58RW9cdcZxQYLcMB uQmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727660099; x=1728264899; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=z1gMYweAcJ6XA7Av2B1DGqE9d4spupTYVwZEdm8Ik0A=; b=ua0R2jok+UWrlgQDUsbXDk9+betMyxYhey4T4RUJGRqzH8pzCTbTSYr71cce5DVO/M VznluqIqgz5ut1IAwHTPrLYm7Vdfn32M8WL/gt7RZdhiSXUGCF+UOelqIO9tfw0E54qj 3UgSC2yF6jzpg7rVKT+Y7VbLjya+wQSubM4ZL5cZOvZ5LiKLKncgvYrpgUrww4+TUFFB WrsF/KmPp60bwDmZRW0jCScy8SNuxQfCRNTLrQnn4fTB6aEBqkIAS5XKkoeVklA06oVt xnYLbRGR+QuwgJbFlksIxS+jp1u5YjCuy0/kNANLricalpLjsbEs99+WIDmopeYTIoxv A9mw== X-Gm-Message-State: AOJu0Ywq54VM8TZ1sZaZ38m17KlDWiX5uBuQ6SfTHQpSzI8fJb3Mb4+x y0sCfFfrpSff5MSmXDGJHQwZ0p/Ec+O/L0IwlrY0M818Zcqw+iRqTs+fWPMJhbOJfx1gOqvYd2s 3lZtKl3E3ryV3e0dwul7p9CYcSh37dg== X-Google-Smtp-Source: AGHT+IEHCHVhdIFavW58wBaSpEAWgU5A2DhVT7xmhPyJMc8k+1acDRzbVEpfbtrGUrRQdeWo+5Nzkmlo5HDpJSp4H/8= X-Received: by 2002:a05:6402:3588:b0:5c2:7740:b3bd with SMTP id 4fb4d7f45d1cf-5c8825fe806mr9798645a12.14.1727660098775; Sun, 29 Sep 2024 18:34:58 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 29 Sep 2024 18:34:58 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 29 Sep 2024 18:34:58 -0700 Message-ID: Subject: control message for bug #73472 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) severity 73472 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 06:14:54 2024 Received: (at 73472) by debbugs.gnu.org; 5 Oct 2024 10:14:54 +0000 Received: from localhost ([127.0.0.1]:37313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx1oM-00050L-Dr for submit@debbugs.gnu.org; Sat, 05 Oct 2024 06:14:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx1oK-000506-VA for 73472@debbugs.gnu.org; Sat, 05 Oct 2024 06:14:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sx1oB-0001I1-6q; Sat, 05 Oct 2024 06:14:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7leF4BUkvoTdBSb115e9bC1KWSQZF51U0kxevsTZ4r8=; b=V28e0mXRZna9k8kryC2z IgcEW0EBAf5b3D6s5bGjKl23zTHm+AmQJ+kfac38y0bAjL4YzIMwaAnd/ibrTp9+xXVO8tF0m3aST aylQFulS9fBG/xvBtFiVuzEDo9YxdPg8RumNQxipedx+htcth1vSjs5qyX+WWzWbRTbf/0tx1XnQA YvWT8WazaSFFgcuWCWFx0ZbtBDSfE6Iu+Dq/0o7F4+EGbKr30viQBSY0Uwu0+UFTE3RJ/H9ipIAjy IfHkaCEqR4x1EjVanzEUb6OTvgWscN0Y+v4q95mO3TGptdS+R8Uq8d3ZHVSAoU/2xT0SWEp06AFl+ gdYOSNl819Zu1w==; Date: Sat, 05 Oct 2024 13:14:40 +0300 Message-Id: <86ploex3e7.fsf@gnu.org> From: Eli Zaretskii To: mail@thomasvoss.com, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Thu, 26 Sep 2024 07:11:05 +0100) Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Thu, 26 Sep 2024 07:11:05 +0100 > Cc: Thomas Voss , 73472@debbugs.gnu.org > > On Thu, Sep 26, 2024, 06:52 Eli Zaretskii wrote: > > I think the caller should itself use substitute-quotes where > appropriate. > > And I'd like to hear João's opinion as well. > > I think I think so too. What Eglot format strings are affected by this quote substitution? I.e. what problem is > being solved here? Ping! Thomas, could you please answer João's questions? From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 08:48:40 2024 Received: (at 73472) by debbugs.gnu.org; 5 Oct 2024 12:48:40 +0000 Received: from localhost ([127.0.0.1]:37465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx4D9-0005FB-Oa for submit@debbugs.gnu.org; Sat, 05 Oct 2024 08:48:39 -0400 Received: from mail-oo1-f42.google.com ([209.85.161.42]:59752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx4D7-0005Ex-Kr for 73472@debbugs.gnu.org; Sat, 05 Oct 2024 08:48:38 -0400 Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5e7aec9e15fso1536487eaf.3 for <73472@debbugs.gnu.org>; Sat, 05 Oct 2024 05:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728132447; x=1728737247; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vt+lAB/A84gVYFp2xIYz9Lj6zzGcM5IR+4orW1iev7o=; b=dkkSjCEbsnLvDRTNqYO9B8M3vYB75wgPjMFV+LnQp/bttetTJT76daC/aFgs9RA2s6 Waw6cdvXr6G4aTx4RUWzjlxKQdVZ+ljLU39IGqetKxmPycliMQBvrLuNchMil2rusON9 WixUS8URB59hLoDy5nOK29nmHoeuwvkF9g9vYZ5zw+a1IjpPdLWXHlsnonzN2EGjsD00 gBB8bSQbXF27SLGQhO1++eHChnaMDBTaXUMf1FdX4Icb8ctuXm/FPETPykVUD9FPrP2R 4QZy/2J+ehu6EUc/sxPC2hp4iLjZklQF3h5QLW9vAIl/VBbVO5SM00gA2UzbMHS29Sax 37ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728132447; x=1728737247; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vt+lAB/A84gVYFp2xIYz9Lj6zzGcM5IR+4orW1iev7o=; b=UBI1MWbR4rOI8vAB5DJhRNFV42T01vycQj1vuNnOtFFhQZ2nIIPBzu1+rdE2lsUyVJ r4VKSOTJIduShiqiphBNQmqIrMMZzTxiiPG07iKO5yhKVflhCICIFxVlvuVCHRRCO5t6 UFXE1AmNE+IlpEkQoyzGNy+7+EnYEVkLtrPTcm9qe/XLu8FtiHXS7RlD+9N/H80muZsj Z0xezdttVKgYFYWAJpyVJ4htPGAmpXvfq8tFYLaVcnowykpgZVzB8FuD2wEmymDmiyar zbaO7cPVuplLl6+nMyKcCQIbbyHxQH2mlqLa83tVNc7w4rehTxdOVHDPSrIb2yvGm2iV tHlw== X-Forwarded-Encrypted: i=1; AJvYcCUw8h6tvJZkCz4dlwuQ3oJElQt/XKlXmBl76Q+rCjY3rk3/P0WUcvGLG9AoEtSa68F2HRPexQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YySxnpXzD3YrYnZCIT+GRG5dJ6Y6ar0pPJmYQfjgWQ5XmaHbNhS bC5YTlWOyDZu7JF4xozI7hBfmiNBo1LjuNqSGJeMAmxhinWFSTFnsfa8A9knqxOv/YIN6ikL07r q0RLVTIc+f57uNFw3j5C6aoC/zXE= X-Google-Smtp-Source: AGHT+IH6CPdMHCC5CIBxs+ZoxqDbJEn/85uyMUqvzulpCwbKP7WX4bqsB92Grb163Np+S9O3EkfjsbvMBtRpoeiaGcQ= X-Received: by 2002:a05:6871:ca02:b0:270:c1e:41ad with SMTP id 586e51a60fabf-287c2295745mr3266442fac.35.1728132447293; Sat, 05 Oct 2024 05:47:27 -0700 (PDT) MIME-Version: 1.0 References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> In-Reply-To: <86ploex3e7.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 5 Oct 2024 13:48:57 +0100 Message-ID: Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73472 Cc: mail@thomasvoss.com, 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thomas already answered, but only to me, I see: > There are a number of them. For example by simply enabling eglot-mode > you=E2=80=99ll see a message in your minibuffer using `these quotes' whic= h looks > very out-of-place when the rest of the system is using =E2=80=98these quo= tes=E2=80=99. So, if you can enumerate them, what about using quote substitution for only those? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 04:12:52 2024 Received: (at 73472) by debbugs.gnu.org; 7 Oct 2024 08:12:52 +0000 Received: from localhost ([127.0.0.1]:44555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxirM-000409-Hk for submit@debbugs.gnu.org; Mon, 07 Oct 2024 04:12:52 -0400 Received: from out-177.mta0.migadu.com ([91.218.175.177]:15290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxirJ-0003zs-1w for 73472@debbugs.gnu.org; Mon, 07 Oct 2024 04:12:51 -0400 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thomasvoss.com; s=key1; t=1728288725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2mPbKvhIfn/sqsIPtk06noCGZ9VugPl8en5PrZHKhtI=; b=0slqZXZwARKYRqa/tbvhYjZmrk3R2slyajXS+45VkLUq/AYZh6ekKkdZ0hSOB3fccLjA2i NGttTlimnP1qklEHyFZnA/iIJL/JCZTo9s1r9+wxFS98QRmq8nP7BGr7N6FaSmB6V9zX8x Pa/7sQ+Annel9i4dOxzVu3csAH4BAEpncT1zdcS5qh4/xDKczd/5DXJpkm3xqvM1L1G9No lsSk5LjmdN8gflTTPBcLRuq1pMspTSty01dNb92+cml/MFEg56pb7ab+EsMVbwQljL0u7X JWSrF+uOOaeSOzKaEvu8DI+w6KZWSTk0hQ7NXs+KXED26W9iAuVFYJM1DjkENg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 07 Oct 2024 10:12:00 +0200 Message-Id: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Thomas Voss" To: =?utf-8?q?Jo=C3=A3o_T=C3=A1vora?= , "Eli Zaretskii" Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, > > There are a number of them. For example by simply enabling eglot-mode > > you=E2=80=99ll see a message in your minibuffer using `these quotes' wh= ich looks > > very out-of-place when the rest of the system is using =E2=80=98these q= uotes=E2=80=99. > > So, if you can enumerate them, what about using quote substitution for > only those? I can do that. I refrained from it at first because my original patch seemed like a much simpler solution, but I do agree that this is probably a better approach. When I have the time I can send through a patch for that. --=20 =E2=80=94 Thomas From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 07:32:27 2024 Received: (at 73472) by debbugs.gnu.org; 7 Oct 2024 11:32:28 +0000 Received: from localhost ([127.0.0.1]:45183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxlyV-0006S8-KA for submit@debbugs.gnu.org; Mon, 07 Oct 2024 07:32:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxlyT-0006Rw-VV for 73472@debbugs.gnu.org; Mon, 07 Oct 2024 07:32:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxlyH-0002PD-Dx; Mon, 07 Oct 2024 07:32:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=MB4UaGI7BpqmUFia8+s+okYk06f61VvFe1NP+n5rLLQ=; b=Q4/X92hozPVE4wbLOhjI No9Tp0W35hGtTeGOezsCXLj2JShL/453jbWWOfQJa/yaodJBy9J4/AEzDWh72lwZLKlUyDEIy/xzJ TRTIu8k1zP3UUG7hc7bShMoxrGe846h6bgkzujL/BQp2Tk+maL9zYJuW8YexemsMJj69vhr/Ge+7D otnAwOlzSKQkBCsC8nEw997AWzxEp0sDYTlUn6J93Y8J7qExIS14BQO7WBRdy4mMY3zR1tRk/o938 J92QXiK33Ac9cDtgsN+F9y4GVL06aMGyn8JRiB19e4CpWweoTWw1zd9HvyKp+MaOUspqzoen7992M Y/XQBDEGhNQAPg==; Date: Mon, 07 Oct 2024 14:32:11 +0300 Message-Id: <86r08stah0.fsf@gnu.org> From: Eli Zaretskii To: "Thomas Voss" In-Reply-To: (mail@thomasvoss.com) Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 07 Oct 2024 10:12:00 +0200 > Cc: <73472@debbugs.gnu.org> > From: "Thomas Voss" > > > > There are a number of them. For example by simply enabling eglot-mode > > > you’ll see a message in your minibuffer using `these quotes' which looks > > > very out-of-place when the rest of the system is using ‘these quotes’. > > > > So, if you can enumerate them, what about using quote substitution for > > only those? > > I can do that. I refrained from it at first because my original patch > seemed like a much simpler solution, but I do agree that this is probably > a better approach. When I have the time I can send through a patch for > that. Thanks, please do. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 19 03:08:15 2024 Received: (at 73472) by debbugs.gnu.org; 19 Oct 2024 07:08:16 +0000 Received: from localhost ([127.0.0.1]:41103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t23ZP-0007EM-GU for submit@debbugs.gnu.org; Sat, 19 Oct 2024 03:08:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t23ZN-0007E6-0G for 73472@debbugs.gnu.org; Sat, 19 Oct 2024 03:08:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t23Yu-0001W1-5T; Sat, 19 Oct 2024 03:07:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=jrtsNzuaAcuPaU3wrcfWovpB1CL0K8IIFTAZ4XAJLg4=; b=g5HMG0autRoW6VKV5azY 4zCR2TQVKBQ9SpcghZgptcY6lNLomeiMAneK+w2tdQIWibzyANIfUstNHjQNQUkIlySxi36MR6qEO 0SMrP69IyIR/Lfb5i4zfUxSoCZmFrZOYrQmQwxen0lvgOzM6TNWf+j+noz7En5xeweZiPaYnn0W6J t8XL+8xRACKX4JVkrzZy/OGr9plkxom+asgtgpP1gTmF7+apay5im1jIy5dtXZOsOZKu6evr2ZH8q endnbR77j9nKMS2xcETzyMjipZrBo2iD05/zQDiV3UXi2y8N75R0F5Z1yhFKG5KekfJq0mYvU5NBE Ml2ggVniK5dS6A==; Date: Sat, 19 Oct 2024 10:07:41 +0300 Message-Id: <86zfn0lgea.fsf@gnu.org> From: Eli Zaretskii To: mail@thomasvoss.com In-Reply-To: <86r08stah0.fsf@gnu.org> (message from Eli Zaretskii on Mon, 07 Oct 2024 14:32:11 +0300) Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 73472@debbugs.gnu.org, joaotavora@gmail.com > Date: Mon, 07 Oct 2024 14:32:11 +0300 > From: Eli Zaretskii > > > Date: Mon, 07 Oct 2024 10:12:00 +0200 > > Cc: <73472@debbugs.gnu.org> > > From: "Thomas Voss" > > > > > > There are a number of them. For example by simply enabling eglot-mode > > > > you’ll see a message in your minibuffer using `these quotes' which looks > > > > very out-of-place when the rest of the system is using ‘these quotes’. > > > > > > So, if you can enumerate them, what about using quote substitution for > > > only those? > > > > I can do that. I refrained from it at first because my original patch > > seemed like a much simpler solution, but I do agree that this is probably > > a better approach. When I have the time I can send through a patch for > > that. > > Thanks, please do. Ping! From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 19 04:34:24 2024 Received: (at 73472) by debbugs.gnu.org; 19 Oct 2024 08:34:24 +0000 Received: from localhost ([127.0.0.1]:41338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t24ul-0002sg-Vp for submit@debbugs.gnu.org; Sat, 19 Oct 2024 04:34:24 -0400 Received: from out-180.mta1.migadu.com ([95.215.58.180]:48798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t24uj-0002sQ-4n for 73472@debbugs.gnu.org; Sat, 19 Oct 2024 04:34:22 -0400 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thomasvoss.com; s=key1; t=1729326800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZK0PWTaRvk+U/+GAbCTUUBxxyjD16e8ywrF+NfwkD7E=; b=gN8v5dV9KAQu9S0R3kZUAEgpaVVzzS/v2fjGO1s+WK+E+ZldYWkb/o42RdpJck3aWRoB9x YI5/FsvcPR8p1HLH6nWeVub0+ASxLyOeg12okyw6O68sVw5fz40E8pLNdyvAmq6VCHbNgJ XAtjh9nKYDZby3oN1uaUpa4YC36CaFlHXMOXDqQLSRWrXoU10Kew+vS8r6MfipqvZzWqt1 4OkJzkRDHLsPWBFPKzQg0QWJuVb4iXxz/XK0Vey5IxIBwP0JzVrNFk+ebnNPkQKYdleFyg s44I8GfMsilM/PHLOmPnIy2PbvvxWliUxnMUPaw26vUU3urn2tSLZ+UARfFn5g== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 19 Oct 2024 10:33:14 +0200 Message-Id: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Thomas Voss" To: "Eli Zaretskii" Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> In-Reply-To: <86zfn0lgea.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > > I can do that. I refrained from it at first because my original patc= h > > > seemed like a much simpler solution, but I do agree that this is prob= ably > > > a better approach. When I have the time I can send through a patch f= or > > > that. > >=20 > > Thanks, please do. > > Ping! I=E2=80=99ll see if I can send through a patch this weekend. I=E2=80=99ve = been a bit busy with life things (I moved countries recently) but I=E2=80=99ve got mos= t of everything sorted now. --=20 =E2=80=94 Thomas From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 21 17:59:25 2024 Received: (at 73472) by debbugs.gnu.org; 21 Oct 2024 21:59:25 +0000 Received: from localhost ([127.0.0.1]:53825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t30Qu-0000UI-Q3 for submit@debbugs.gnu.org; Mon, 21 Oct 2024 17:59:25 -0400 Received: from out-171.mta1.migadu.com ([95.215.58.171]:38155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t30Qr-0000Ty-UM for 73472@debbugs.gnu.org; Mon, 21 Oct 2024 17:59:23 -0400 Content-Type: multipart/mixed; boundary=b39508a0ee60a0c293eaa3f7dbf214f0472d3b32d0ba3c069882f3785138 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thomasvoss.com; s=key1; t=1729547928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5loMAKzztk1210VQ2nZKnUd6K+jklv1eitpBhBIthDA=; b=9gWuNZmLeJgaUq7gHIonQLA8XgV/mAaKijIY2TLfuEi5zztrhHP8exjiz23PoHUhGtsUNj EPIIZnDOtZIeaVSPu1ifRD3wySOGEcSkncbs/SWcefC8OKWowy0DsmBrLs1g9dIp+i1+XF AnMkFcVfex548x0Z7PLKeU+fQ/PXXdUKTRf++UZd2j1wZaBtod1+FkjbFrdwE9q64QrmyV R1+2bgmI0Ji68QERZGWx+pEK1gqnWNqvCMjW7CVeE2fv9eYO7XtZw5CXaIHJiSZlQIETnM sgfa+n309evprI8zQ1SfHNsSs9QV1mK5vWmo1dS3Yo19BabJC3rmFHaJAd/hNg== Mime-Version: 1.0 Date: Mon, 21 Oct 2024 23:58:42 +0200 Message-Id: Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Thomas Voss" To: "Thomas Voss" , "Eli Zaretskii" References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --b39508a0ee60a0c293eaa3f7dbf214f0472d3b32d0ba3c069882f3785138 Content-Type: multipart/alternative; boundary=8e2b86508b142185fb6cd3ee3987081cc0df9bc23180183f9ea2299faa52 --8e2b86508b142185fb6cd3ee3987081cc0df9bc23180183f9ea2299faa52 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-Type: text/plain; charset=UTF-8 On Sat Oct 19, 2024 at 10:33 AM CEST, Thomas Voss wrote: > > > > I can do that. I refrained from it at first because my original pa= tch > > > > seemed like a much simpler solution, but I do agree that this is pr= obably > > > > a better approach. When I have the time I can send through a patch= for > > > > that. > > >=20 > > > Thanks, please do. > > > > Ping! > > I=E2=80=99ll see if I can send through a patch this weekend. I=E2=80=99v= e been a bit > busy with life things (I moved countries recently) but I=E2=80=99ve got m= ost of > everything sorted now. Hi, I had some time today to quickly put together a patch. You can find it attachted to this email. --=20 =E2=80=94 Thomas --8e2b86508b142185fb6cd3ee3987081cc0df9bc23180183f9ea2299faa52-- --b39508a0ee60a0c293eaa3f7dbf214f0472d3b32d0ba3c069882f3785138 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v2-0001-Substitute-quotation-marks-in-Eglot-messages.patch Content-Type: text/x-patch; charset=utf-8; name=v2-0001-Substitute-quotation-marks-in-Eglot-messages.patch RnJvbSA1MTIxNzM0NDI4ZTNlMzcwNjM3OGIxZjFhZjQ5ZTk0NGYyYjQ4NjU4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgVm9zcyA8bWFpbEB0aG9tYXN2b3NzLmNvbT4KRGF0 ZTogU2F0LCAxOSBPY3QgMjAyNCAxMToxMjozMCArMDIwMApTdWJqZWN0OiBbUEFUQ0ggdjJdIFN1 YnN0aXR1dGUgcXVvdGF0aW9uIG1hcmtzIGluIEVnbG90IG1lc3NhZ2VzCgoqIGxpc3AvcHJvZ21v ZGVzL2VnbG90LmVsCiAgKGVnbG90LS1jaGVjay1vYmplY3QpCiAgKGVnbG90LXJlZ2lzdGVyLWNh cGFiaWxpdHkpCiAgKGVnbG90LXVucmVnaXN0ZXItY2FwYWJpbGl0eSkKICAoZWdsb3Qtc2VydmVy LWNhcGFibGUtb3ItbG9zZSkKICAoZWdsb3QtLWd1ZXNzLWNvbnRhY3QpCiAgKGVnbG90LS1jb25u ZWN0KQogIChlZ2xvdC1oYW5kbGUtbm90aWZpY2F0aW9uKQogIChlZ2xvdC0tYXBwbHktdGV4dC1l ZGl0cyk6IFdyYXAgdXNlci1mYWNpbmcKICBtZXNzYWdlcyBpbiBgc3Vic3RpdHV0ZS1xdW90ZXMn LgoqIGxpc3AvcHJvZ21vZGVzL2VnbG90LmVsIChlZ2xvdC1yZW5hbWUpOiBGb3JtYXQgdGhlIHBy b21wdCB1c2luZwogIGBmb3JtYXQtcHJvbXB0Jy4KCkNvcHlyaWdodC1wYXBlcndvcmstZXhlbXB0 OiB5ZXMKLS0tCiBsaXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbCB8IDg2ICsrKysrKysrKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygr KSwgMzYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwg Yi9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbAppbmRleCAwYTE0MTQ2Li5mMDJhMWQ4IDEwMDY0NAot LS0gYS9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5l bApAQCAtNzEzLDE5ICs3MTMsMjIgQEAgZWdsb3QtLWNoZWNrLW9iamVjdAogICAgICh3aGVuLWxl dCAoKG1pc3NpbmcgKGFuZCBlbmZvcmNlLXJlcXVpcmVkCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChjbC1zZXQtZGlmZmVyZW5jZSByZXF1aXJlZC1rZXlzCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZWdsb3QtLXBsaXN0LWtleXMgb2JqZWN0 KSkpKSkKLSAgICAgIChlZ2xvdC0tZXJyb3IgIkEgYCVzJyBtdXN0IGhhdmUgJXMiIGludGVyZmFj ZS1uYW1lIG1pc3NpbmcpKQorICAgICAgKGVnbG90LS1lcnJvciAoc3Vic3RpdHV0ZS1xdW90ZXMg IkEgYCVzJyBtdXN0IGhhdmUgJXMiKQorICAgICAgICAgICAgICAgICAgICBpbnRlcmZhY2UtbmFt ZSBtaXNzaW5nKSkKICAgICAod2hlbi1sZXQgKChleGNlc3MgKGFuZCBkaXNhbGxvdy1ub24tc3Rh bmRhcmQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2wtc2V0LWRpZmZlcmVuY2UKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGVnbG90LS1wbGlzdC1rZXlzIG9iamVjdCkKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFwcGVuZCByZXF1aXJlZC1rZXlzIG9wdGlvbmFs LWtleXMpKSkpKQotICAgICAgKGVnbG90LS1lcnJvciAiQSBgJXMnIG11c3RuJ3QgaGF2ZSAlcyIg aW50ZXJmYWNlLW5hbWUgZXhjZXNzKSkKKyAgICAgIChlZ2xvdC0tZXJyb3IgKHN1YnN0aXR1dGUt cXVvdGVzICJBIGAlcycgbXVzdG4ndCBoYXZlICVzIikKKyAgICAgICAgICAgICAgICAgICAgaW50 ZXJmYWNlLW5hbWUgZXhjZXNzKSkKICAgICAod2hlbiBjaGVjay10eXBlcwogICAgICAgKGNsLWxv b3AKICAgICAgICBmb3IgKGsgdikgb24gb2JqZWN0IGJ5ICMnY2RkcgogICAgICAgIGZvciB0eXBl ID0gKG9yIChjZHIgKGFzc29jIGsgdHlwZXMpKSB0KSA7OyBGSVhNRTogZW5mb3JjZSBuaWwgdHlw ZT8KICAgICAgICB1bmxlc3MgKGNsLXR5cGVwIHYgdHlwZSkKLSAgICAgICBkbyAoZWdsb3QtLWVy cm9yICJBIGAlcycgbXVzdCBoYXZlIGEgJXMgYXMgJXMsIGJ1dCBoYXMgJXMiCi0gICAgICAgICAg ICAgICAgICAgICAgICBpbnRlcmZhY2UtbmFtZSkpKQorICAgICAgIGRvIChlZ2xvdC0tZXJyb3IK KyAgICAgICAgICAgKHN1YnN0aXR1dGUtcXVvdGVzICJBIGAlcycgbXVzdCBoYXZlIGEgJXMgYXMg JXMsIGJ1dCBoYXMgJXMiKQorICAgICAgICAgICBpbnRlcmZhY2UtbmFtZSkpKQogICAgIHQpKQog CiAoZXZhbC1hbmQtY29tcGlsZQpAQCAtOTE3LDE1ICs5MjAsMTcgQEAgZWdsb3QtcmVnaXN0ZXIt Y2FwYWJpbGl0eQogICAiQXNrIFNFUlZFUiB0byByZWdpc3RlciBjYXBhYmlsaXR5IE1FVEhPRCBt YXJrZWQgd2l0aCBJRC4iCiAgICg6bWV0aG9kCiAgICAoX3MgbWV0aG9kIF9pZCAmcmVzdCBfcGFy YW1zKQotICAgKGVnbG90LS13YXJuICJTZXJ2ZXIgdHJpZWQgdG8gcmVnaXN0ZXIgdW5zdXBwb3J0 ZWQgY2FwYWJpbGl0eSBgJXMnIgotICAgICAgICAgICAgICAgIG1ldGhvZCkpKQorICAgKGVnbG90 LS13YXJuCisgICAgKHN1YnN0aXR1dGUtcXVvdGVzICJTZXJ2ZXIgdHJpZWQgdG8gcmVnaXN0ZXIg dW5zdXBwb3J0ZWQgY2FwYWJpbGl0eSBgJXMnIikKKyAgICBtZXRob2QpKSkKIAogKGNsLWRlZmdl bmVyaWMgZWdsb3QtdW5yZWdpc3Rlci1jYXBhYmlsaXR5IChzZXJ2ZXIgbWV0aG9kIGlkICZyZXN0 IHBhcmFtcykKICAgIkFzayBTRVJWRVIgdG8gcmVnaXN0ZXIgY2FwYWJpbGl0eSBNRVRIT0QgbWFy a2VkIHdpdGggSUQuIgogICAoOm1ldGhvZAogICAgKF9zIG1ldGhvZCBfaWQgJnJlc3QgX3BhcmFt cykKLSAgIChlZ2xvdC0td2FybiAiU2VydmVyIHRyaWVkIHRvIHVucmVnaXN0ZXIgdW5zdXBwb3J0 ZWQgY2FwYWJpbGl0eSBgJXMnIgotICAgICAgICAgICAgICAgIG1ldGhvZCkpKQorICAgKGVnbG90 LS13YXJuCisgICAgKHN1YnN0aXR1dGUtcXVvdGVzICJTZXJ2ZXIgdHJpZWQgdG8gdW5yZWdpc3Rl ciB1bnN1cHBvcnRlZCBjYXBhYmlsaXR5IGAlcyciKQorICAgIG1ldGhvZCkpKQogCiAoY2wtZGVm Z2VuZXJpYyBlZ2xvdC1jbGllbnQtY2FwYWJpbGl0aWVzIChzZXJ2ZXIpCiAgICJXaGF0IHRoZSBF Z2xvdCBMU1AgY2xpZW50IHN1cHBvcnRzIGZvciBTRVJWRVIuIgpAQCAtMTE0NCw4ICsxMTQ5LDkg QEAgZWdsb3Qtc2VydmVyLWNhcGFibGUtb3ItbG9zZQogICAiTGlrZSBgZWdsb3Qtc2VydmVyLWNh cGFibGUnLCBidXQgbWF5YmUgZXJyb3Igb3V0LiIKICAgKGxldCAoKHJldHZhbCAoYXBwbHkgIydl Z2xvdC1zZXJ2ZXItY2FwYWJsZSBmZWF0cykpKQogICAgICh1bmxlc3MgcmV0dmFsCi0gICAgICAo ZWdsb3QtLWVycm9yICJVbnN1cHBvcnRlZCBvciBpZ25vcmVkIExTUCBjYXBhYmlsaXR5IGAlcyci Ci0gICAgICAgICAgICAgICAgICAgIChtYXBjb25jYXQgIydzeW1ib2wtbmFtZSBmZWF0cyAiICIp KSkKKyAgICAgIChlZ2xvdC0tZXJyb3IKKyAgICAgICAoc3Vic3RpdHV0ZS1xdW90ZXMgIlVuc3Vw cG9ydGVkIG9yIGlnbm9yZWQgTFNQIGNhcGFiaWxpdHkgYCVzJyIpCisgICAgICAgKG1hcGNvbmNh dCAjJ3N5bWJvbC1uYW1lIGZlYXRzICIgIikpKQogICAgIHJldHZhbCkpCiAKIAwKQEAgLTEyOTAs NyArMTI5Niw5IEBAIGVnbG90LS1ndWVzcy1jb250YWN0CiAgICAgICAgICAgICAgIChtYXBjYXIg IydzeW1ib2wtbmFtZSAoZWdsb3QtLWFsbC1tYWpvci1tb2RlcykpIG5pbCB0CiAgICAgICAgICAg ICAgIGd1ZXNzZWQtbW9kZS1uYW1lIG5pbCBndWVzc2VkLW1vZGUtbmFtZSBuaWwpKSkKICAgICAg ICAgICAgKChub3QgZ3Vlc3NlZC1tb2RlKQotICAgICAgICAgICAgKGVnbG90LS1lcnJvciAiQ2Fu J3QgZ3Vlc3MgbW9kZSB0byBtYW5hZ2UgZm9yIGAlcyciIChjdXJyZW50LWJ1ZmZlcikpKQorICAg ICAgICAgICAgKGVnbG90LS1lcnJvcgorICAgICAgICAgICAgIChzdWJzdGl0dXRlLXF1b3RlcyAi Q2FuJ3QgZ3Vlc3MgbW9kZSB0byBtYW5hZ2UgZm9yIGAlcyciKQorICAgICAgICAgICAgIChjdXJy ZW50LWJ1ZmZlcikpKQogICAgICAgICAgICAodCBndWVzc2VkLW1vZGUpKSkKICAgICAgICAgIChs YW5ndWFnZXMtYW5kLWNvbnRhY3QgKGVnbG90LS1sb29rdXAtbW9kZSBtYWluLW1vZGUpKQogICAg ICAgICAgKG1hbmFnZWQtbW9kZXMgKG1hcGNhciAjJ2NhciAoY2FyIGxhbmd1YWdlcy1hbmQtY29u dGFjdCkpKQpAQCAtMTMyMCwyNCArMTMyOCwyNSBAQCBlZ2xvdC0tZ3Vlc3MtY29udGFjdAogICAg ICAgICAgICAgICAgKGNvbWJpbmUtYW5kLXF1b3RlLXN0cmluZ3MgZ3Vlc3MpKSkKICAgICAgICAg IChwcm9tcHQKICAgICAgICAgICAoYW5kIGJhc2UtcHJvbXB0Ci0gICAgICAgICAgICAgICAoY29u ZCAoY3VycmVudC1wcmVmaXgtYXJnIGJhc2UtcHJvbXB0KQotICAgICAgICAgICAgICAgICAgICAg KChudWxsIGd1ZXNzKQotICAgICAgICAgICAgICAgICAgICAgIChmb3JtYXQgIltlZ2xvdF0gQ291 bGRuJ3QgZ3Vlc3MgTFNQIHNlcnZlciBmb3IgYCVzJ1xuJXMiCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBtYWluLW1vZGUgYmFzZS1wcm9tcHQpKQotICAgICAgICAgICAgICAgICAgICAg KChhbmQgcHJvZ3JhbQotICAgICAgICAgICAgICAgICAgICAgICAgICAgKG5vdCAoZmlsZS1uYW1l LWFic29sdXRlLXAgcHJvZ3JhbSkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAobm90IChj b21wYXQtY2FsbCBleGVjdXRhYmxlLWZpbmQgcHJvZ3JhbSB0KSkpCi0gICAgICAgICAgICAgICAg ICAgICAgKGlmIGZ1bGwtcHJvZ3JhbS1pbnZvY2F0aW9uCi0gICAgICAgICAgICAgICAgICAgICAg ICAgIChjb25jYXQgKGZvcm1hdCAiW2VnbG90XSBJIGd1ZXNzIHlvdSB3YW50IHRvIHJ1biBgJXMn IgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZnVsbC1wcm9ncmFt LWludm9jYXRpb24pCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGZvcm1hdCAi LCBidXQgSSBjYW4ndCBmaW5kIGAlcycgaW4gUEFUSCEiCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBwcm9ncmFtKQotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICJcbiIgYmFzZS1wcm9tcHQpCi0gICAgICAgICAgICAgICAgICAgICAgICAoZWdsb3Qt LWVycm9yCi0gICAgICAgICAgICAgICAgICAgICAgICAgKGNvbmNhdCAiYCVzJyBub3QgZm91bmQg aW4gUEFUSCwgYnV0IGNhbid0IGZvcm0iCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAiIGFuIGludGVyYWN0aXZlIHByb21wdCBmb3IgaGVscCB5b3UgZml4IgotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIiB0aGlzLiIpCi0gICAgICAgICAgICAgICAgICAgICAgICAg cHJvZ3JhbSBndWVzcykpKSkpKQorICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUtcXVvdGVzCisg ICAgICAgICAgICAgICAgKGNvbmQgKGN1cnJlbnQtcHJlZml4LWFyZyBiYXNlLXByb21wdCkKKyAg ICAgICAgICAgICAgICAgICAgICAoKG51bGwgZ3Vlc3MpCisgICAgICAgICAgICAgICAgICAgICAg IChmb3JtYXQgIltlZ2xvdF0gQ291bGRuJ3QgZ3Vlc3MgTFNQIHNlcnZlciBmb3IgYCVzJ1xuJXMi CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWFpbi1tb2RlIGJhc2UtcHJvbXB0KSkK KyAgICAgICAgICAgICAgICAgICAgICAoKGFuZCBwcm9ncmFtCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKG5vdCAoZmlsZS1uYW1lLWFic29sdXRlLXAgcHJvZ3JhbSkpCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKG5vdCAoY29tcGF0LWNhbGwgZXhlY3V0YWJsZS1maW5kIHByb2dy YW0gdCkpKQorICAgICAgICAgICAgICAgICAgICAgICAoaWYgZnVsbC1wcm9ncmFtLWludm9jYXRp b24KKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChjb25jYXQgKGZvcm1hdCAiW2VnbG90XSBJ IGd1ZXNzIHlvdSB3YW50IHRvIHJ1biBgJXMnIgorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGZ1bGwtcHJvZ3JhbS1pbnZvY2F0aW9uKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAoZm9ybWF0ICIsIGJ1dCBJIGNhbid0IGZpbmQgYCVzJyBpbiBQ QVRIISIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcm9ncmFt KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiXG4iIGJhc2UtcHJvbXB0KQor ICAgICAgICAgICAgICAgICAgICAgICAgIChlZ2xvdC0tZXJyb3IKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgKGNvbmNhdCAiYCVzJyBub3QgZm91bmQgaW4gUEFUSCwgYnV0IGNhbid0IGZvcm0i CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIiBhbiBpbnRlcmFjdGl2ZSBwcm9t cHQgZm9yIGhlbHAgeW91IGZpeCIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi IHRoaXMuIikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgcHJvZ3JhbSBndWVzcykpKSkpKSkK ICAgICAgICAgIChpbnB1dCAoYW5kIHByb21wdCAocmVhZC1zaGVsbC1jb21tYW5kIHByb21wdAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZnVsbC1wcm9n cmFtLWludm9jYXRpb24KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICdlZ2xvdC1jb21tYW5kLWhpc3RvcnkpKSkKQEAgLTE2NjEsMTIgKzE2NzAsMTMgQEAg ZWdsb3QtLWNvbm5lY3QKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAobnVsbCBlZ2xvdC1hdXRvcmVjb25uZWN0KSkpKSkpKQogICAgICAgICAgICAgICAgICAgICAg ICAgICAocnVuLWhvb2std2l0aC1hcmdzICdlZ2xvdC1jb25uZWN0LWhvb2sgc2VydmVyKQogICAg ICAgICAgICAgICAgICAgICAgICAgICAoZWdsb3QtLW1lc3NhZ2UKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICJDb25uZWN0ZWQhIFNlcnZlciBgJXMnIG5vdyBtYW5hZ2luZyBgJXMnIGJ1ZmZl cnMgXAorICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUtcXVvdGVzCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIkNvbm5lY3RlZCEgU2VydmVyIGAlcycgbm93IG1hbmFn aW5nIGAlcycgYnVmZmVycyBcCiBpbiBwcm9qZWN0IGAlcycuIgogICAgICAgICAgICAgICAgICAg ICAgICAgICAgKG9yIChwbGlzdC1nZXQgc2VydmVySW5mbyA6bmFtZSkKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoanNvbnJwYy1uYW1lIHNlcnZlcikpCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICBtYW5hZ2VkLW1vZGVzCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAoZWds b3QtcHJvamVjdC1uaWNrbmFtZSBzZXJ2ZXIpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg KGVnbG90LXByb2plY3Qtbmlja25hbWUgc2VydmVyKSkpCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICh3aGVuIHRhZyAodGhyb3cgdGFnIHQpKSkpCiAgICAgICAgICAgICAgICAgICAgICAgOnRp bWVvdXQgZWdsb3QtY29ubmVjdC10aW1lb3V0CiAgICAgICAgICAgICAgICAgICAgICAgOmVycm9y LWZuIChlZ2xvdC0tbGFtYmRhICgoUmVzcG9uc2VFcnJvcikgY29kZSBtZXNzYWdlKQpAQCAtMTY4 OSw3ICsxNjk5LDggQEAgZWdsb3QtLWNvbm5lY3QKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbmlsIGVnbG90LWNvbm5lY3QtdGltZW91dCkpKSkpKSkKICAgICAgICAgICAg ICAgKHBjYXNlIHJldHZhbAogICAgICAgICAgICAgICAgIChgKGVycm9yIC4gLG1zZykgKGVnbG90 LS1lcnJvciBtc2cpKQotICAgICAgICAgICAgICAgIChgbmlsIChlZ2xvdC0tbWVzc2FnZSAiV2Fp dGluZyBpbiBiYWNrZ3JvdW5kIGZvciBzZXJ2ZXIgYCVzJyIKKyAgICAgICAgICAgICAgICAoYG5p bCAoZWdsb3QtLW1lc3NhZ2UgKHN1YnN0aXR1dGUtcXVvdGVzCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAiV2FpdGluZyBpbiBiYWNrZ3JvdW5kIGZvciBzZXJ2ZXIgYCVz JyIpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChqc29ucnBjLW5hbWUg c2VydmVyKSkKICAgICAgICAgICAgICAgICAgICAgICBuaWwpCiAgICAgICAgICAgICAgICAgKF8g c2VydmVyKSkpCkBAIC0yMzMyLDcgKzIzNDMsOSBAQCBlZ2xvdC1oYW5kbGUtbm90aWZpY2F0aW9u CiAgICJIYW5kbGUgdW5rbm93biBub3RpZmljYXRpb24uIgogICAodW5sZXNzIChvciAoc3RyaW5n LXByZWZpeC1wICIkIiAoZm9ybWF0ICIlcyIgbWV0aG9kKSkKICAgICAgICAgICAgICAgKG5vdCAo bWVtcSAnZGlzYWxsb3ctdW5rbm93bi1tZXRob2RzIGVnbG90LXN0cmljdC1tb2RlKSkpCi0gICAg KGVnbG90LS13YXJuICJTZXJ2ZXIgc2VudCB1bmtub3duIG5vdGlmaWNhdGlvbiBtZXRob2QgYCVz JyIgbWV0aG9kKSkpCisgICAgKGVnbG90LS13YXJuIChzdWJzdGl0dXRlLXF1b3RlcworICAgICAg ICAgICAgICAgICAgIlNlcnZlciBzZW50IHVua25vd24gbm90aWZpY2F0aW9uIG1ldGhvZCBgJXMn IikKKyAgICAgICAgICAgICAgICAgbWV0aG9kKSkpCiAKIChjbC1kZWZtZXRob2QgZWdsb3QtaGFu ZGxlLXJlcXVlc3QKICAgKF9zZXJ2ZXIgbWV0aG9kICZrZXkgJmFsbG93LW90aGVyLWtleXMpCkBA IC0zNTg2LDcgKzM1OTksOCBAQCBlZ2xvdC0tYXBwbHktdGV4dC1lZGl0cwogICAgICAgICAgICAo aG93bWFueSAobGVuZ3RoIGVkaXRzKSkKICAgICAgICAgICAgKHJlcG9ydGVyICh1bmxlc3Mgc2ls ZW50CiAgICAgICAgICAgICAgICAgICAgICAgIChtYWtlLXByb2dyZXNzLXJlcG9ydGVyCi0gICAg ICAgICAgICAgICAgICAgICAgICAoZm9ybWF0ICJbZWdsb3RdIGFwcGx5aW5nICVzIGVkaXRzIHRv IGAlcycuLi4iCisgICAgICAgICAgICAgICAgICAgICAgICAoZm9ybWF0IChzdWJzdGl0dXRlLXF1 b3RlcworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIltlZ2xvdF0gYXBwbHlpbmcg JXMgZWRpdHMgdG8gYCVzJy4uLiIpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhv d21hbnkgKGN1cnJlbnQtYnVmZmVyKSkKICAgICAgICAgICAgICAgICAgICAgICAgIDAgaG93bWFu eSkpKQogICAgICAgICAgICAoZG9uZSAwKSkKQEAgLTM3MDgsOCArMzcyMiw4IEBAIGVnbG90LXJl bmFtZQogICAiUmVuYW1lIHRoZSBjdXJyZW50IHN5bWJvbCB0byBORVdOQU1FLiIKICAgKGludGVy YWN0aXZlCiAgICAobGlzdCAocmVhZC1mcm9tLW1pbmlidWZmZXIKLSAgICAgICAgICAoZm9ybWF0 ICJSZW5hbWUgYCVzJyB0bzogIiAob3IgKHRoaW5nLWF0LXBvaW50ICdzeW1ib2wgdCkKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInVua25vd24gc3ltYm9sIikpCisg ICAgICAgICAgKGZvcm1hdC1wcm9tcHQgIlJlbmFtZSBgJXMnIHRvIiBuaWwgKG9yICh0aGluZy1h dC1wb2ludCAnc3ltYm9sIHQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICJ1bmtub3duIHN5bWJvbCIpKQogICAgICAgICAgIG5pbCBuaWwgbmlsIG5p bAogICAgICAgICAgIChzeW1ib2wtbmFtZSAoc3ltYm9sLWF0LXBvaW50KSkpKSkKICAgKGVnbG90 LXNlcnZlci1jYXBhYmxlLW9yLWxvc2UgOnJlbmFtZVByb3ZpZGVyKQotLSAKMi40Ny4wCgo= --b39508a0ee60a0c293eaa3f7dbf214f0472d3b32d0ba3c069882f3785138-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 04:09:55 2024 Received: (at 73472) by debbugs.gnu.org; 9 Nov 2024 09:09:56 +0000 Received: from localhost ([127.0.0.1]:53381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9hTf-0001Bc-HI for submit@debbugs.gnu.org; Sat, 09 Nov 2024 04:09:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9hTd-0001BL-ST for 73472@debbugs.gnu.org; Sat, 09 Nov 2024 04:09:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9hTY-00019w-IT; Sat, 09 Nov 2024 04:09:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HIuo+BGjm0u4y5OkGUUZ1y+Xp8jL+/X0vOhg8NEGfF0=; b=rBlFqPb1VyYZvkruqULA zbjzs2UrtM8n975dhXHsXzeOaQIXYbOA6M0/f5xhEw+wEicGoz5AIasjQl2MeB1w00w7ukTZT6/rF BOLXHLS7N42H2ltSj9qMB8uPFW8wTOqcp8ArtMcuZ3JjVj/QgdszcBage8eUZ6YvGvmYzkUVLEtwz Rg7dcW+9Itf/TgVWfaInExPTOSWAzmA2cALAdzFDBqquUEnvaUyKkWsK8rMovmIzZBDY+VZBow0DT mCRTpVcyeTsTOq96POk8DnLJwsD6wa6N0VqKrtXVbDR/jmxKqnuZ5qYvKGyyxNDOicofNYjy2mbna H+kJsLK9Sbph5Q==; Date: Sat, 09 Nov 2024 11:09:33 +0200 Message-Id: <865xowojsi.fsf@gnu.org> From: Eli Zaretskii To: "Thomas Voss" , joaotavora@gmail.com In-Reply-To: (mail@thomasvoss.com) Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73472 Cc: mail@thomasvoss.com, 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 21 Oct 2024 23:58:42 +0200 > Cc: <73472@debbugs.gnu.org>, > From: "Thomas Voss" > > On Sat Oct 19, 2024 at 10:33 AM CEST, Thomas Voss wrote: > > > > > I can do that. I refrained from it at first because my original patch > > > > > seemed like a much simpler solution, but I do agree that this is probably > > > > > a better approach. When I have the time I can send through a patch for > > > > > that. > > > > > > > > Thanks, please do. > > > > > > Ping! > > > > I’ll see if I can send through a patch this weekend. I’ve been a bit > > busy with life things (I moved countries recently) but I’ve got most of > > everything sorted now. > > Hi, > > I had some time today to quickly put together a patch. You can find it > attachted to this email. Thanks. João, any comments? My only comment is that the log message says "format-prompt", but the code actually uses substitute-quotes. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 04:21:26 2024 Received: (at 73472) by debbugs.gnu.org; 9 Nov 2024 09:21:26 +0000 Received: from localhost ([127.0.0.1]:53425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9heo-0001mH-GA for submit@debbugs.gnu.org; Sat, 09 Nov 2024 04:21:26 -0500 Received: from out-174.mta1.migadu.com ([95.215.58.174]:51187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9hem-0001m3-Ac for 73472@debbugs.gnu.org; Sat, 09 Nov 2024 04:21:25 -0500 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thomasvoss.com; s=key1; t=1731144046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CAoMWG2GgR4h2B/0AT1L9MJirrBLO8eXgF9it6DX6Iw=; b=gvXgBQhmuA2LqTKS9byWxvSw3QHGFqEUTQAOQ645dLujRS6vqsAVzkdXUZ+WYO1piNxEJt qD+Dm2tY+XWAedEXFlKMy2WF93OYeP9TccsJsZp3W+bkYR7OTi0zoIIDA8fUrNtncIdC99 dqzEkaN8O5M0Tby1JEbmYhOAZrrPEq4+pyjM1cLuK2hp/l27DXsKCe35TalHzqTX1vllyP 3wfQqHKgpzbaq47Tvx2m+xcI/6NEhuy56e6DuEwOhoYgggINB1S4FVjre+kLoWLSG8+Wzq E46hCZFD5dcZJnHvARjiDbcpBMQ0zrUa/SPEgkKDaulxEnmQimnipMNekcTuyA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 09 Nov 2024 10:20:43 +0100 Message-Id: To: "Eli Zaretskii" , Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Thomas Voss" References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> In-Reply-To: <865xowojsi.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > My only comment is that the log message says "format-prompt", but the > code actually uses substitute-quotes. Ah my bad there. The Emacs-style of commit messages is still strange to me so I just copy+pasted my prior commit message to make sure I got it right. I guess I forgot to update the text with the correct function name. =E2=80=94 Thomas From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 07:11:49 2024 Received: (at 73472) by debbugs.gnu.org; 23 Nov 2024 12:11:49 +0000 Received: from localhost ([127.0.0.1]:56932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEozM-0003Im-L6 for submit@debbugs.gnu.org; Sat, 23 Nov 2024 07:11:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEozL-0003IZ-29 for 73472@debbugs.gnu.org; Sat, 23 Nov 2024 07:11:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEozE-0004Ce-O1; Sat, 23 Nov 2024 07:11:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=hSyiKU46UzB6snTaNU9RZghFaKmokab6eVVDV7+Z5NA=; b=o18EuOQkiw2eLopPeVdW 2Q7iyHNtrMJukhCIubaA7OgRMvCudqo8nJhJ0wNRynmcotgzU6xZbBqvI+OE2TACqv4gG9a/kd3sU bv31MlOXAP8e80+ybgqdViciOzYx8XqhVRdNHb1zQKn6eGMFYITO49qYQNxwCxCQ1PeXavhKeKowT QYA95e/Ohfxy9Y7Rtwy2GYqL4qaeKC+zcSiS4Usy5CPvwjJjRve5DgIvVWIzD9BFjK3BWnpi+39ue b57bsq6eH5aLmOID1eZ3hYQ4y2vp5sHYIimGpopZhOW5OFcQJWMTGtM6xwhuhgziKS+tbgYwFS57V JsaQ2v3rowNg4A==; Date: Sat, 23 Nov 2024 14:11:38 +0200 Message-Id: <86frnim9ol.fsf@gnu.org> From: Eli Zaretskii To: joaotavora@gmail.com In-Reply-To: <865xowojsi.fsf@gnu.org> (message from Eli Zaretskii on Sat, 09 Nov 2024 11:09:33 +0200) Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73472 Cc: mail@thomasvoss.com, 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! > Cc: mail@thomasvoss.com, 73472@debbugs.gnu.org > Date: Sat, 09 Nov 2024 11:09:33 +0200 > From: Eli Zaretskii > > > Date: Mon, 21 Oct 2024 23:58:42 +0200 > > Cc: <73472@debbugs.gnu.org>, > > From: "Thomas Voss" > > > > On Sat Oct 19, 2024 at 10:33 AM CEST, Thomas Voss wrote: > > > > > > I can do that. I refrained from it at first because my original patch > > > > > > seemed like a much simpler solution, but I do agree that this is probably > > > > > > a better approach. When I have the time I can send through a patch for > > > > > > that. > > > > > > > > > > Thanks, please do. > > > > > > > > Ping! > > > > > > I’ll see if I can send through a patch this weekend. I’ve been a bit > > > busy with life things (I moved countries recently) but I’ve got most of > > > everything sorted now. > > > > Hi, > > > > I had some time today to quickly put together a patch. You can find it > > attachted to this email. > > Thanks. João, any comments? > > My only comment is that the log message says "format-prompt", but the > code actually uses substitute-quotes. > > > > From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 03:27:59 2024 Received: (at 73472) by debbugs.gnu.org; 29 Nov 2024 08:27:59 +0000 Received: from localhost ([127.0.0.1]:40868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGwM2-00026q-NE for submit@debbugs.gnu.org; Fri, 29 Nov 2024 03:27:59 -0500 Received: from out-180.mta1.migadu.com ([95.215.58.180]:15466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGwM0-00026W-8m for 73472@debbugs.gnu.org; Fri, 29 Nov 2024 03:27:57 -0500 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thomasvoss.com; s=key1; t=1732868870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XWMfvO7phm8qKbL6UW8jovjzKG5m/OqBlkcuH91NtWU=; b=mlaJpox5WFwqLdielINdsQcCboNDTQBt7uj9uy8tWz/TmvVfS1b1bV0lSwwPCP8I30FJQW ywjNaPeYvdNrPdZ8qYhfr+c0Lq91FZF4reJCV9hKONILAl4aEE2LNaAfVjwceN5kMplIrN 62JelW9yPhaA9wURNUnZogWtEfDw7d99t7VE++NmK8PUpMwVSesfPPgqbL+UicvNcvEue9 UL9eEAuEzciHKA+wfT1+tU35Z0CPcK/qTCGcIHAY1YIlOKRC5ztB+G4cVuTXDKG11qbbmx qs3obMmGwX+WxzkfchfP51TaKXg0aQmh+LjALt++DGJD8EywKSAVRXy6sitemQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 29 Nov 2024 09:27:44 +0100 Message-Id: To: "Eli Zaretskii" , Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Thomas Voss" References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> In-Reply-To: <86frnim9ol.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, sorry for the delay. I=E2=80=99m a bit busy at the moment but I=E2=80= =99ll get to this soon. =E2=80=94 Thomas From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 12 05:50:10 2024 Received: (at 73472) by debbugs.gnu.org; 12 Dec 2024 10:50:10 +0000 Received: from localhost ([127.0.0.1]:37811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLglm-0008PL-4B for submit@debbugs.gnu.org; Thu, 12 Dec 2024 05:50:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLglk-0008Jx-Bu for 73472@debbugs.gnu.org; Thu, 12 Dec 2024 05:50:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLglf-0005kZ-0s; Thu, 12 Dec 2024 05:50:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=jNKE52Cpi63WAxWznCXuR8GjharKGe4xLTTu6MUwA5s=; b=kcQYUOeCrgaw3Ghio5Jo XaUVtplq3gD47DSJ4ZfR/hz+CiY/QVExoYo6FwJP7PnwwsZ7sVvdWPxkxvNSOBGBALZbIS0TUhOhi yfPw9WE12fco157hj30+OMVNAzm20jn7h/oLadB5y+F90PVeogFRmZTsHB1f3ZskhbUIS84fxH4nm +uJWXDFX4CYIrVxynUkU9rxDiafHIlZAieN2ZG/xuS3M5PklI2UVkTb/ZW43XbXBrFR84tX/m4Oyp 0nSV6DCBP47hwHmiCRpJsEzNOG00/j7m5WNeZFlNhoPZOfI4XEFs3wk9GPG9yyn/HsbUSOHdMQa2H cW0iFYERczMZIQ==; Date: Thu, 12 Dec 2024 12:49:59 +0200 Message-Id: <86y10lyy3s.fsf@gnu.org> From: Eli Zaretskii To: "Thomas Voss" In-Reply-To: (mail@thomasvoss.com) Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73472 Cc: 73472@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 09 Dec 2024 19:01:28 +0100 > From: "Thomas Voss" > > Apologies for the long delay; I have been super busy recently. > > > Ping! > > > > > Thanks. João, any comments? > > > > > > My only comment is that the log message says "format-prompt", but the > > > code actually uses substitute-quotes. > > Uh… are we looking at the same patch? The log message in the patch I > last sent does say ‘substitute-quotes’ for all the places where I used > that function, and only says ‘format-prompt’ for the place where I used > that function (‘eglot-rename’). > > Just in case, I attached the patch again to this email. Thanks. João, are you okay with me installing this? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 12 05:59:10 2024 Received: (at 73472) by debbugs.gnu.org; 12 Dec 2024 10:59:10 +0000 Received: from localhost ([127.0.0.1]:37825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLguT-0000Lm-M3 for submit@debbugs.gnu.org; Thu, 12 Dec 2024 05:59:10 -0500 Received: from mail-oo1-f49.google.com ([209.85.161.49]:48458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLguQ-0000L0-4R for 73472@debbugs.gnu.org; Thu, 12 Dec 2024 05:59:08 -0500 Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5f2c51478e5so197779eaf.1 for <73472@debbugs.gnu.org>; Thu, 12 Dec 2024 02:59:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734001079; x=1734605879; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Xww+ybNJIOZPFWFqcbsE7LuBaIB4gOLkm+owyzgGheY=; b=Xwa2XrqizTNem9mMjHWBMcEik7h82StKuYjWUZZKX5oGCm056Ar0B/ltkF58MNCgHv YhnvzHxsS03LtXDE24AADO6amMd8g1CEMCV699ck2ZI8FYg3srG4799OZe614LqnZTc0 s5QJfSnnMwSxPvmwhHefBW2Pz9oKnGgoedfBGZwy1Bk8iNPd0RNK9PGEKbAL+BXiS9AN f50XLHDgFbdSNH3tV6AkJKWIOeenOIi6UfOtQSqyOZqQqllgvfZbj0GOfpk3BWP1l1Jn N/Rl33WY3EmR6RL/CgwMaMwb/xwa2Oiw5kDjh6r8wlHPdeIGE/dYDZZrnZJ1RLUSQRZF erEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734001079; x=1734605879; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xww+ybNJIOZPFWFqcbsE7LuBaIB4gOLkm+owyzgGheY=; b=g0QxrriT5RwdpcmgZhd/5f9qCsai1Q7Y9SrAV/ufZRQsiLA1lQFjUH+iEZ6FTOMrlQ cqhj71Nc0L7d56u1FCN0Rs3lqwOOyEVYtX7/RvRqlX9IKxbbuLi9uvAwX0QpHiqOwcbz 7EmDvP/hoqddgv56g9U1XxXAjMT7fXPL3KbUXaccn/qGlsmYDtmHrTIDESYFDMCkD63H d6ruMCg408sbl9Nc0S1LfwxAgE2Bs7/IfiO6F4g+mHnYDZ/bX5/SEFWTTkCWSKzXAG76 FgkZzYcbxOvUfdX67S1PGXF0jvHomhPNOkhNd2TMXjdwdPt/IPMjVwVZ4uQdemtYOp5Z M3dQ== X-Forwarded-Encrypted: i=1; AJvYcCWAtETu1xYU63JG9/3T5BPnyKdALTQ7zah+Po64Bs/kBiid9EIrHzP7N/m7M0LVex6lgT7gxQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxoaC3k657ms20YV5tMXpJgqalADpIvSbA9PeaohBw09ZRHd8Eu RtNR+TVvXYI3cgeiTal18o24OmRXvdWmtLhVih47WF5OLz7YL7VMGndGE8PazM3zF7FDm9/1GmF UYupCEUc+IR8GpN7M9UcWZ7xs6Eg= X-Gm-Gg: ASbGncssBvR3GSeGNTuLSvtQQyN34w4WEFmXd0OWB+dohqSQu8W4WYmlzmLBNXkBnYr CCWonsjYl2uSQs+kzAIHWhA351+aIdBhG1+2qcg== X-Google-Smtp-Source: AGHT+IE4lKZX9McnrzFT4GYR7RuoIKEL6YtTs6uV7UeCYCkkwTfx3hu6dIscGL1PWHsTLcKWGgwPQE38M94IYWhUXSw= X-Received: by 2002:a05:6870:1491:b0:29e:4340:b1b with SMTP id 586e51a60fabf-2a012baff1amr3903222fac.9.1734001079314; Thu, 12 Dec 2024 02:57:59 -0800 (PST) MIME-Version: 1.0 References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> <86y10lyy3s.fsf@gnu.org> In-Reply-To: <86y10lyy3s.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Thu, 12 Dec 2024 10:57:48 +0000 Message-ID: Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73472 Cc: Thomas Voss , 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii wrote= : > > > Date: Mon, 09 Dec 2024 19:01:28 +0100 > > From: "Thomas Voss" > > > > Apologies for the long delay; I have been super busy recently. > > > > > Ping! > > > > > > > Thanks. Jo=C3=A3o, any comments? > > > > > > > > My only comment is that the log message says "format-prompt", but t= he > > > > code actually uses substitute-quotes. > > > > Uh=E2=80=A6 are we looking at the same patch? The log message in the p= atch I > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for all the plac= es where I used > > that function, and only says =E2=80=98format-prompt=E2=80=99 for the pl= ace where I used > > that function (=E2=80=98eglot-rename=E2=80=99). > > > > Just in case, I attached the patch again to this email. > > Thanks. > > Jo=C3=A3o, are you okay with me installing this? Just had a look. The patch won't break anything, but it has some problems around the part where substitute quotes isn't around a literal, but wraps a bigger block. I'll try to fix it. It would also be great to have some f= ile local symbol-shortening mechanism to avoid that long name, but I'm not going to worry about that. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 06:00:31 2024 Received: (at 73472) by debbugs.gnu.org; 28 Dec 2024 11:00:31 +0000 Received: from localhost ([127.0.0.1]:48920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRUYY-00065J-Pm for submit@debbugs.gnu.org; Sat, 28 Dec 2024 06:00:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRUYW-000654-MK for 73472@debbugs.gnu.org; Sat, 28 Dec 2024 06:00:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRUYQ-0003gd-Ez; Sat, 28 Dec 2024 06:00:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3x1dPN5RoDodccu3ErbtPAeIH5s76M6Rd6osTSYisMI=; b=hCn+6PJoYtWS8+iSrXRf bSzB+dEvX1AUqlZth/8hx5ij2h3jMaigNy51BMAbW74nS0CkNgIL/C94z+zk+MThitK3C/Om4yH7d sh7zM0o/QzmfUtlmyMR861uyNIWmvgyYNjS3TNCZWWsOf3nno9BrISzBwy6p6epR4cplS4Q4VAcD1 XGgYgs/ISwLdiijuPQEybOue5BDUToenaAbYbb/EO0+/CmDezPiMDbeX4/J2BVNHi+u3dtRsVSftE arjZJnJ5Sp3TXrDtV1LSBgLwwdfOLaj577B14f73SfFhCZWsv5M1HP+6IK02XcZOoHH0CY6tCcXQS K9UY7A/6gQGB3w==; Date: Sat, 28 Dec 2024 13:00:19 +0200 Message-Id: <861pxsul6k.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Thu, 12 Dec 2024 10:57:48 +0000) Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> <86y10lyy3s.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73472 Cc: mail@thomasvoss.com, 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Thu, 12 Dec 2024 10:57:48 +0000 > Cc: Thomas Voss , 73472@debbugs.gnu.org > > On Thu, Dec 12, 2024 at 10:50 AM Eli Zaretskii wrote: > > > > > Date: Mon, 09 Dec 2024 19:01:28 +0100 > > > From: "Thomas Voss" > > > > > > Apologies for the long delay; I have been super busy recently. > > > > > > > Ping! > > > > > > > > > Thanks. João, any comments? > > > > > > > > > > My only comment is that the log message says "format-prompt", but the > > > > > code actually uses substitute-quotes. > > > > > > Uh… are we looking at the same patch? The log message in the patch I > > > last sent does say ‘substitute-quotes’ for all the places where I used > > > that function, and only says ‘format-prompt’ for the place where I used > > > that function (‘eglot-rename’). > > > > > > Just in case, I attached the patch again to this email. > > > > Thanks. > > > > João, are you okay with me installing this? > > Just had a look. The patch won't break anything, but it has some problems > around the part where substitute quotes isn't around a literal, but wraps > a bigger block. I'll try to fix it. It would also be great to have some file > local symbol-shortening mechanism to avoid that long name, but I'm > not going to worry about that. Ping! Did you have time to look into this? From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 08:31:03 2024 Received: (at 73472) by debbugs.gnu.org; 28 Dec 2024 13:31:03 +0000 Received: from localhost ([127.0.0.1]:49790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRWuE-0005Af-Lm for submit@debbugs.gnu.org; Sat, 28 Dec 2024 08:31:03 -0500 Received: from mail-oa1-f49.google.com ([209.85.160.49]:56425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRWuD-0005AD-DZ for 73472@debbugs.gnu.org; Sat, 28 Dec 2024 08:31:02 -0500 Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-29fc424237bso3621377fac.0 for <73472@debbugs.gnu.org>; Sat, 28 Dec 2024 05:31:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735392596; x=1735997396; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RNd2BlHCxpHc9ZNDtqMO4xfbt03eaGXAEYtJJOyRcCM=; b=L6GPvs1NnSBgG5/J30JcuNaV/uoygMPRGAMq+Zf6mYdeANrLA2cfqsabBXo4FT3vop HwvGCH4KkP8PNBW67YFrCGkNuyoWMu+m947zDInvedK28yCFr7ZIZzAtfUZIRv+6fqDd CUsKLA/CL2siGxxHn4DR4nrcKzqFZ1kxTq0ZtTiMY6nGZ3Cxrl4a7VGeAI75E4G+sF52 WHK2cgi7gUCfMe0Ft3UE84TmTv3RL1oWezXIoJjqA3zWlcnqWBxjOWd+Gc3RmEVi52LC Fm1S7KyBaBmvPytPDWYEvokWtERI7wM4v9SuFnDgzMc2gPVAbOPMyZgdT0tDXkPdXWoH Oitg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735392596; x=1735997396; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RNd2BlHCxpHc9ZNDtqMO4xfbt03eaGXAEYtJJOyRcCM=; b=E+uUJ3LReE9XKxJizVZSwdBCJsde6Zw4Mu4SXber3yoowplTJN9UEqbtwQ04IRxhhO mfOOJgWRrwFGQH9bUWqT1h3ye+H/asV78oF2EX2hdfvvgxWt/kaL/vCJCxIcxstuqs/Y bZV/460hSMaZALZtiOqlQ331Ra7FOQTVG+K/vc5Xog4GRjYt0XtjaS4riv7qFUPVNqFU aCKQgMsIcj8ds224ry44M815eDtYsrfufkLpcUfqvWLa03hmise++zb5NOvatgE8WoCC PA6fPsr/mYUC2aZtHS9KthETfxPcRJLTstH3u4ZBLFqndphgn53uetWqfmpfVb/9UAB5 6JTA== X-Forwarded-Encrypted: i=1; AJvYcCXUXM3hXQBwtolgyjF7sqLdY/vj4Eo5dyIMFusVlbjwR6KKn1tJJ55CwiNHRRqj15LnUwRfcA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyVQFe5cYgjzCnQwCIF0VIWXwm+9suIoqaWk0BYfwgOGpOcOx8m 5TZh82dfqc3JMkaACG0P0Rtgp6iJfR34qf/uSnEF3d33Wpr2nDdhazdY35jGdm4mA7RweS/zGKQ zpf7cYr7H1O33LkO1D0hh96zBvLChYg== X-Gm-Gg: ASbGnctCqWthVkA7rlzbHo+WPBQHYUndwBP60SgFY++On5+O9rRYS5ENnpz6MA6mEqT wKEbwR6rZD2Hs+AxKoO7jV6rCpvV0pGvnc+qX X-Google-Smtp-Source: AGHT+IFm16ncnKqkZHE8Sz4zxfBL6T+uc2JQmV6dcW6R9Dc3Y/fzT8OcqR0LDac2klOQ4GysrtKBIJB1Uu7INHN7h38= X-Received: by 2002:a05:6871:e7c8:b0:29d:c624:7c3d with SMTP id 586e51a60fabf-2a7fb2ea736mr13116230fac.32.1735392595977; Sat, 28 Dec 2024 05:29:55 -0800 (PST) MIME-Version: 1.0 References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> <86y10lyy3s.fsf@gnu.org> <861pxsul6k.fsf@gnu.org> In-Reply-To: <861pxsul6k.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 28 Dec 2024 13:29:44 +0000 Message-ID: Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000003ab0c0062a5493db" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73472 Cc: Thomas Voss , 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003ab0c0062a5493db Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Dec 28, 2024, 11:00 Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Thu, 12 Dec 2024 10:57:48 +0000 > > Cc: Thomas Voss , 73472@debbugs.gnu.org > > > > On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii w= rote: > > > > > > > Date: Mon, 09 Dec 2024 19:01:28 +0100 > > > > From: "Thomas Voss" > > > > > > > > Apologies for the long delay; I have been super busy recently. > > > > > > > > > Ping! > > > > > > > > > > > Thanks. Jo=C3=A3o, any comments? > > > > > > > > > > > > My only comment is that the log message says "format-prompt", > but the > > > > > > code actually uses substitute-quotes. > > > > > > > > Uh=E2=80=A6 are we looking at the same patch? The log message in t= he patch I > > > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for all the = places where I > used > > > > that function, and only says =E2=80=98format-prompt=E2=80=99 for th= e place where I > used > > > > that function (=E2=80=98eglot-rename=E2=80=99). > > > > > > > > Just in case, I attached the patch again to this email. > > > > > > Thanks. > > > > > > Jo=C3=A3o, are you okay with me installing this? > > > > Just had a look. The patch won't break anything, but it has some proble= ms > > around the part where substitute quotes isn't around a literal, but wra= ps > > a bigger block. I'll try to fix it. It would also be great to have > some file > > local symbol-shortening mechanism to avoid that long name, but I'm > > not going to worry about that. > > Ping! Did you have time to look into this? > No sorry. Fixed a much more serious but though. Early 2025 I will fix this patch, it's easy. Jo=C3=A3o --0000000000003ab0c0062a5493db Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, Dec 28, 2024, 11:00 Eli Zaretskii <eliz@gnu.org<= /a>> wrote:
&= gt; From: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com&g= t;
> Date: Thu, 12 Dec 2024 10:57:48 +0000
> Cc: Thomas Voss <mail@thomasvoss.com>, 73472@debbugs.gnu.org
>
> On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii <eliz@g= nu.org> wrote:
> >
> > > Date: Mon, 09 Dec 2024 19:01:28 +0100
> > > From: "Thomas Voss" <mail@thomasvos= s.com>
> > >
> > > Apologies for the long delay; I have been super busy recentl= y.
> > >
> > > > Ping!
> > > >
> > > > > Thanks.=C2=A0 Jo=C3=A3o, any comments?
> > > > >
> > > > > My only comment is that the log message says "= ;format-prompt", but the
> > > > > code actually uses substitute-quotes.
> > >
> > > Uh=E2=80=A6 are we looking at the same patch?=C2=A0 The log = message in the patch I
> > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for a= ll the places where I used
> > > that function, and only says =E2=80=98format-prompt=E2=80=99= for the place where I used
> > > that function (=E2=80=98eglot-rename=E2=80=99).
> > >
> > > Just in case, I attached the patch again to this email.
> >
> > Thanks.
> >
> > Jo=C3=A3o, are you okay with me installing this?
>
> Just had a look. The patch won't break anything, but it has some p= roblems
> around the part where substitute quotes isn't around a literal, bu= t wraps
> a bigger block.=C2=A0 I'll try to fix it.=C2=A0 It would also be g= reat to have some file
> local symbol-shortening mechanism to avoid that long name, but I'm=
> not going to worry about that.

Ping!=C2=A0 Did you have time to look into this?

No sorry. Fixed a much more= serious but though. Early 2025 I will fix this patch, it's easy.=C2=A0=

Jo=C3=A3o
--0000000000003ab0c0062a5493db-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 10:53:24 2024 Received: (at 73472) by debbugs.gnu.org; 28 Dec 2024 15:53:24 +0000 Received: from localhost ([127.0.0.1]:52364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRZ7z-0003ql-J8 for submit@debbugs.gnu.org; Sat, 28 Dec 2024 10:53:24 -0500 Received: from mail-oa1-f53.google.com ([209.85.160.53]:60919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRZ7x-0003qX-GC for 73472@debbugs.gnu.org; Sat, 28 Dec 2024 10:53:22 -0500 Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-2a3d8857a2bso3856331fac.1 for <73472@debbugs.gnu.org>; Sat, 28 Dec 2024 07:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735401136; x=1736005936; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HiJWVOy+VbC0Eh2EeBmMwfvKNuuGmbdT5Tno0dfKdfc=; b=W07cHj6lZ8+uazhH5QMH61vPXA+cUBUxrP4QShbhvuPrbiLsW3pY/sbzRhufiploM3 A5rTyqAjVilK8tlKmqUgVKLKaGdeLv/0O4vIg0rECg7Qjqdiurt2Ajv1K6jNS7bd4ZaP K3iiQ8kfFDcnjdn8Hg8vMYdsjX5m2qDt9OMy6dVRdsXIWG2lXxI7/XHLTjcnXsioHA8m j67M3480MODMqm0FxELMHG/8U428r+FUB80KH8KjPO3uLTcB+sJkA3LvV4H0Jh1PBYMI nLBYtiCgaQ04UrY0iCnHKSQoXP/ciYvHAPGHm8tZhoDCfhvfS4sseJ1Uzyrp+nxO5eGC 0fwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735401136; x=1736005936; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HiJWVOy+VbC0Eh2EeBmMwfvKNuuGmbdT5Tno0dfKdfc=; b=o8RQcLPxTXjxmqJk30dDbgXtYiBf89Yk36uX88mHRFo3KQaF6yGeYuXa2DKWTsTjZj +gCSLFAW0H6a7moShIhYBuurlgN/s8D2rKVewY+NnKDZ7L4UFcQrgRQ5hBRB+E2+0Wj8 mjpZb+cvKhqwYiD7bjt7+KunAABiLqKw21maP8XnxQBPXxxG4l/AnJbPEBd8Va8cRJJK zBe3yjqCE0UTNwsEiHVLRtiwlJVAUM/BywRwr6u3Q/TXyGI3ECox/0AfkSBu+hr2Ujwq OfyXp0jLLeLK7tDpxKpeMd/rZ7sEH48lZvYePbj+uBD1rw+RGDqlaUcLON81B7CEadGf md7w== X-Forwarded-Encrypted: i=1; AJvYcCVOXLlPk/jFKlwEJMcPSc0XYtxnpNcM5k3ietyNEIFonG+Y+3ed7NZU0sJWnx8E+NVHC7gEtQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy7a/FAqCXiSUh0liSh4a1c1oGi1qfhWmvWlh/3d6i7bHBXNRnK ANZTbxRx92RPmcN1LEQJhTIPgaPK7e5yYlO8sQOXoO07oJ35se/CsbX1tizJXidmY+fbsv67o+J tiDDX60l+EKgv4Jq3pBNz8fK5Z4c= X-Gm-Gg: ASbGnctSKd4nowCRC346jgiJNlLFiaqA4hefFGtJ2KS4L6UI7D+wBNUcyyzz3HVhRdh ZoYYRD3sAhQvCEUeKsK3OyyNqYKRjD95mSJXr X-Google-Smtp-Source: AGHT+IF9hfh4Whg3LEJCFSJVrl5f77o+QeIpGtrpLPodI1OnwgCzT8ADb4bKaeiD3ElTwCQV1Z/7B51xr9Zy45vzEKY= X-Received: by 2002:a05:6870:3c10:b0:295:ed0a:8061 with SMTP id 586e51a60fabf-2a7fb553bf8mr16223222fac.39.1735401135739; Sat, 28 Dec 2024 07:52:15 -0800 (PST) MIME-Version: 1.0 References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> <86y10lyy3s.fsf@gnu.org> <861pxsul6k.fsf@gnu.org> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 28 Dec 2024 15:52:04 +0000 Message-ID: Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000003d1d8c062a56909c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73472 Cc: Thomas Voss , 73472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003d1d8c062a56909c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry, I meant to write "fixed a much more serious one". Jo=C3=A3o On Sat, Dec 28, 2024, 13:29 Jo=C3=A3o T=C3=A1vora wr= ote: > > > On Sat, Dec 28, 2024, 11:00 Eli Zaretskii wrote: > >> > From: Jo=C3=A3o T=C3=A1vora >> > Date: Thu, 12 Dec 2024 10:57:48 +0000 >> > Cc: Thomas Voss , 73472@debbugs.gnu.org >> > >> > On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii = wrote: >> > > >> > > > Date: Mon, 09 Dec 2024 19:01:28 +0100 >> > > > From: "Thomas Voss" >> > > > >> > > > Apologies for the long delay; I have been super busy recently. >> > > > >> > > > > Ping! >> > > > > >> > > > > > Thanks. Jo=C3=A3o, any comments? >> > > > > > >> > > > > > My only comment is that the log message says "format-prompt", >> but the >> > > > > > code actually uses substitute-quotes. >> > > > >> > > > Uh=E2=80=A6 are we looking at the same patch? The log message in = the patch >> I >> > > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for all the= places where I >> used >> > > > that function, and only says =E2=80=98format-prompt=E2=80=99 for t= he place where I >> used >> > > > that function (=E2=80=98eglot-rename=E2=80=99). >> > > > >> > > > Just in case, I attached the patch again to this email. >> > > >> > > Thanks. >> > > >> > > Jo=C3=A3o, are you okay with me installing this? >> > >> > Just had a look. The patch won't break anything, but it has some >> problems >> > around the part where substitute quotes isn't around a literal, but >> wraps >> > a bigger block. I'll try to fix it. It would also be great to have >> some file >> > local symbol-shortening mechanism to avoid that long name, but I'm >> > not going to worry about that. >> >> Ping! Did you have time to look into this? >> > > No sorry. Fixed a much more serious but though. Early 2025 I will fix thi= s > patch, it's easy. > > Jo=C3=A3o > --0000000000003d1d8c062a56909c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry, I meant to write "fixed a much more seri= ous one". Jo=C3=A3o=C2=A0


On Sat, Dec 28, 2024,= 13:29 Jo=C3=A3o T=C3=A1vora <jo= aotavora@gmail.com> wrote:


On Sat, Dec 28, 2024, 11:00 Eli Zare= tskii <eliz@gnu.org> wrote:
> From: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>
> Date: Thu, 12 Dec 2024 10:57:48 +0000
> Cc: Thomas Voss <mail@thomasvoss.com>= , 73472@debbugs.gnu.org
>
> On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > > Date: Mon, 09 Dec 2024 19:01:28 +0100
> > > From: "Thomas Voss" <mai= l@thomasvoss.com>
> > >
> > > Apologies for the long delay; I have been super busy recentl= y.
> > >
> > > > Ping!
> > > >
> > > > > Thanks.=C2=A0 Jo=C3=A3o, any comments?
> > > > >
> > > > > My only comment is that the log message says "= ;format-prompt", but the
> > > > > code actually uses substitute-quotes.
> > >
> > > Uh=E2=80=A6 are we looking at the same patch?=C2=A0 The log = message in the patch I
> > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for a= ll the places where I used
> > > that function, and only says =E2=80=98format-prompt=E2=80=99= for the place where I used
> > > that function (=E2=80=98eglot-rename=E2=80=99).
> > >
> > > Just in case, I attached the patch again to this email.
> >
> > Thanks.
> >
> > Jo=C3=A3o, are you okay with me installing this?
>
> Just had a look. The patch won't break anything, but it has some p= roblems
> around the part where substitute quotes isn't around a literal, bu= t wraps
> a bigger block.=C2=A0 I'll try to fix it.=C2=A0 It would also be g= reat to have some file
> local symbol-shortening mechanism to avoid that long name, but I'm=
> not going to worry about that.

Ping!=C2=A0 Did you have time to look into this?

No sorry. Fixed a much more= serious but though. Early 2025 I will fix this patch, it's easy.=C2=A0=

Jo=C3=A3o
--0000000000003d1d8c062a56909c-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 05:53:54 2025 Received: (at 73472-done) by debbugs.gnu.org; 6 Jan 2025 10:53:54 +0000 Received: from localhost ([127.0.0.1]:36881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUkk6-0004TJ-69 for submit@debbugs.gnu.org; Mon, 06 Jan 2025 05:53:54 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:61761) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUkk3-0004T4-HF for 73472-done@debbugs.gnu.org; Mon, 06 Jan 2025 05:53:52 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4368a293339so109135905e9.3 for <73472-done@debbugs.gnu.org>; Mon, 06 Jan 2025 02:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736160824; x=1736765624; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HkHzn3yQHCEdupz+1hngw++zpGNhg9KhoTWzWH7UGzk=; b=Wh8Jx23+S2wbn7qhCe8aQnHyGAgPj6SENK4s2HuwC5I9iP4Bdzrm7+pqTVnvW9bk+x jZ84pAPojmF2RlzvJL2gUk1jp0ju2xfhWPtd8vSxXQVhW0jKrZ66lQgNDVVwLyQMp9ly JZeMGTmRrC9PdXZshmVcP01xTIyniV4PehE4T1ZKUVX9tQ6qIp/xzJvslwuIw7SOH1fz l+E7+k8AODw7vN4FRN7lCS2m+xPqyFMTqh6/EnaAcv2g7WJOZa1smA/0rIaG6N4Kj9dC GadNIg+wITwZo/mrb5rgyP6ZW8+NwJBXYJelVQhCFvoxkmqPR3agVUrfhDY45yOt8Ql9 LlGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736160824; x=1736765624; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HkHzn3yQHCEdupz+1hngw++zpGNhg9KhoTWzWH7UGzk=; b=BjkMErMwOj87x7eRwSgEJWP7mrtmh4FuSD/B+DvL3yg48qelX7SP1Fj6Z4D+Q3l8Ct 8Hyga9if2UphNae0hQR1cjrN11zxNXkjQ79fLBJnangVjBKUUzGc/QkNk4Xfl7XD1WqP ocN/PKT+65QlE6NERnnmkG2WHD4V1AtxxAKVSMPmWIYSalHoFCWMQz2/qNUaur8MVUah YK4GnWD/zRbTvR5ti7upFB6zjhMJKDRyK9+fvunC5i79QZ9ZKuWStmj4NGIfIhbR8mHY d0ntrJKUiWX8O6oVeaMWWmbz4Rh6MMa3STAGaBr8ydnSTNt21qvzAnN1LpFZV6flN2pv JXgA== X-Forwarded-Encrypted: i=1; AJvYcCUSyOomSCKyJqbI3GJaU1P427VEhZWbXfGF8wOiWHgq0nKPOavSZvh5G4jfcA7V/tHP8bb5kBshxZOT@debbugs.gnu.org X-Gm-Message-State: AOJu0YyDNhFsVZGgP4yLzTjpctvuv653GzS/E0OHhogY03Cv8FgTl+Em /vbSUN39K+c3sevRzkzqWkeApHkcibFOc9+cKx+kNTxzBhn8xM8qrURrwg== X-Gm-Gg: ASbGncs7ypi+gbFezpYQCyWbpDwi9iYHo1r4lvNAbYxUsh9boNK4SdpKq8gWClVTdnP 3r8h6HeNag11HSFHg8IVjYTDjnFc4iWGe5IVc/e0AY1FEsoald0nXNPUoV6wlLhFXemsLmQbXnJ IcXNJJmxdXu8Jhkp3ix0gsLBCUV4kQzE++uK+XOfMBoa2Wgudp45a+/OtQwKd+egaKsAwa2aGhh WfuIEkx7fCZuccgac/JzJx7l4mieigwdGytZDXIE6Jx97c= X-Google-Smtp-Source: AGHT+IEyT6I4YseHh9tjUve8tFhHFtR0CGLQoqi9+1zMxie+YfNvcMeAkOIEFY58IDuiLvFpG7v5aw== X-Received: by 2002:a05:6000:470a:b0:386:3825:2c3b with SMTP id ffacd0b85a97d-38a221eaa0bmr35605305f8f.18.1736160824375; Mon, 06 Jan 2025 02:53:44 -0800 (PST) Received: from krug ([62.28.172.234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c828a8dsm47936134f8f.2.2025.01.06.02.53.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 02:53:43 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Eli Zaretskii Subject: Re: bug#73472: [PATCH] Substitute quotation marks in Eglot messages In-Reply-To: <861pxsul6k.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 Dec 2024 13:00:19 +0200") References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> <86y10lyy3s.fsf@gnu.org> <861pxsul6k.fsf@gnu.org> Date: Mon, 06 Jan 2025 10:53:47 +0000 Message-ID: <87msg4kybo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73472-done Cc: mail@thomasvoss.com, 73472-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Jo=C3=A3o T=C3=A1vora >> Date: Thu, 12 Dec 2024 10:57:48 +0000 >> Cc: Thomas Voss , 73472@debbugs.gnu.org >>=20 >> On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii wr= ote: >> > >> > > Date: Mon, 09 Dec 2024 19:01:28 +0100 >> > > From: "Thomas Voss" >> > > >> > > Apologies for the long delay; I have been super busy recently. >> > > >> > > > Ping! >> > > > >> > > > > Thanks. Jo=C3=A3o, any comments? >> > > > > >> > > > > My only comment is that the log message says "format-prompt", bu= t the >> > > > > code actually uses substitute-quotes. >> > > >> > > Uh=E2=80=A6 are we looking at the same patch? The log message in th= e patch I >> > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for all the p= laces where I used >> > > that function, and only says =E2=80=98format-prompt=E2=80=99 for the= place where I used >> > > that function (=E2=80=98eglot-rename=E2=80=99). >> > > >> > > Just in case, I attached the patch again to this email. >> > >> > Thanks. >> > >> > Jo=C3=A3o, are you okay with me installing this? >>=20 >> Just had a look. The patch won't break anything, but it has some problems >> around the part where substitute quotes isn't around a literal, but wraps >> a bigger block. I'll try to fix it. It would also be great to have som= e file >> local symbol-shortening mechanism to avoid that long name, but I'm >> not going to worry about that. > > Ping! Did you have time to look into this? Alright. I finally looked into Thomas' patch properly, and fixed the problems it had. I can produce that patch if anyone's interested. But looking at it, it's just way too verbose: the long 'substitute-quotes' sprinkled everywhere is hideos, shame we can't use shorthands or have a reader macro for that. So I opted to bring `substitute-quotes` into a new `eglot--format` helper and use it in eglot--error, eglot--warn, etc. Which is ugly in itself (I don't like my helpers to do this kind of stuff), but given the situation and my want to kill this bug, it'll do. Closing the bug. Jo=C3=A3o From unknown Fri Jun 20 07:14:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 03 Feb 2025 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator