GNU bug report logs - #73465
[PATCH] Wireguard: Rename field private-key to private-key-file

Previous Next

Package: guix-patches;

Reported by: Apoorv Singh <apoorvs569 <at> gmail.com>

Date: Wed, 25 Sep 2024 05:47:02 UTC

Severity: normal

Tags: patch

Full log


View this message in rfc822 format

From: Richard Sent <richard <at> freakingpenguin.com>
To: Apoorv Singh <apoorvs569 <at> gmail.com>
Cc: 73465 <at> debbugs.gnu.org
Subject: [bug#73465] Wireguard: Deprecate and rename fields
Date: Mon, 09 Dec 2024 12:05:22 -0500
With #73955, private-key better supports g-exp based command redirection,
e.g.

--8<---------------cut here---------------start------------->8---
;; A config of
(wireguard-configuration
  ...
  (private-key (string-append "(<" my-custom-script ">")))

;; Results in
PostUp = ... set %i private-key <(/gnu/store/...-my-custom-script) ...
--8<---------------cut here---------------end--------------->8---

(This was also supported before but was more limited.)

Given that, I think renaming it to private-key-file is more confusing
than keeping it as private-key. Same for preshared-key.

Perhaps we can somehow check the field, see if the user enters a
WG-compatible key literally, and emit a warning? I'm not fluent on the
format to determine the best way for that.
-- 
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.




This bug report was last modified 243 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.