Subject: bug#73448: closed (Re: [bug#73448] [PATCH] gnu: netcdf-parallel-openmpi: Build shared library.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 30 Sep 2024 19:45:02 +0000

Your bug report

#73448: [PATCH] gnu: netcdf-parallel-openmpi: Build shared library.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
73448: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73448
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#73448] [PATCH] gnu: netcdf-parallel-openmpi: Build shared library.
From: Ludovic Courtès <[email-masked]>
To: Romain GARBAGE <[email-masked]>
Cc: [email-masked]
Date: Mon, 30 Sep 2024 21:43:10 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Romain GARBAGE <[email-masked]> skribis:

> * gnu/packages/maths.scm (netcdf-parallel-openmpi) [arguments]: Enable
> building of shared library.
>
> Change-Id: I6e901d5939108421e041252207f10f4800890e97

Applied, thanks!

Subject: [PATCH] gnu: netcdf-parallel-openmpi: Build shared library.
From: Romain GARBAGE <[email-masked]>
To: [email-masked]
Cc: [email-masked], Romain GARBAGE <[email-masked]>
Date: Tue, 24 Sep 2024 13:12:27 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/maths.scm (netcdf-parallel-openmpi) [arguments]: Enable
building of shared library.

Change-Id: I6e901d5939108421e041252207f10f4800890e97
---
The parallel version of the netcdf package was build without shared
libraries, which were not supported at the time the package was written
for parallel I/O. This doesn't seem to be the case anymore: the
documentation talks about both parallel and shared library support, e.g.
at
https://docs.unidata.ucar.edu/nug/current/getting_and_building_netcdf.html#build_pnetcdf_from_source.
---
 gnu/packages/maths.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 5f47d5e390..03fa4d2fae 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -2363,8 +2363,9 @@ (define-public netcdf-parallel-openmpi
        ((#:configure-flags flags)
         `(cons* "CC=mpicc" "CXX=mpicxx"
                 "--enable-parallel-tests"
-                ;; Shared libraries not supported with parallel IO.
-                "--disable-shared" "--with-pic"
+                ;; NetCDF supports both parallel and shared library building
+                ;; See https://docs.unidata.ucar.edu/nug/current/getting_and_building_netcdf.html#build_parallel
+                "--enable-shared" "--with-pic"
                 ,flags))
        ((#:phases phases '%standard-phases)
         `(modify-phases ,phases

base-commit: 1c088531cf0be8fe6706c4624a920fca2ab2fee0
-- 
2.46.0