GNU bug report logs - #73443
29.4; ERC 5.6.1-git: erc-track mode line face color broken with left timestamps

Previous Next

Full log

Message #20 received at 73443 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Trevor Arjeski <tmarjeski <at> gmail.com>
Cc: emacs-erc <at> gnu.org, 73443 <at> debbugs.gnu.org
Subject: Re: Fwd: bug#73443: 29.4; ERC 5.6.1-git: erc-track mode line face
 color broken with left timestamps
Date: Tue, 24 Sep 2024 17:36:10 -0700

[Message part 1 (text/plain, inline)]

Trevor Arjeski <tmarjeski <at> gmail.com> writes:

> "J.P." <jp <at> neverwas.me> writes:
>
>> You could start by "bisecting" the non-ERC parts of your config or the
>> non-ERC modes listed in the gathered facts from your initial report
>> (default stuff commented out):
>
> After a bisect, I was able to find the culprit:
>
>       (erc-fill-function 'erc-fill-static)
>
> Toggling this to and from the default - 'erc-fill-variable - allows me
> to reproduce the issue consistently.

Thanks for getting to the bottom of this. I was indeed able to reproduce
it with user options alone.

>
> My guess is that the track parser does not like the extra padding
> between the timestamp and nick, but I haven't yet looked into the code.

Yes, that's essentially what's happening. The new internal function that
extracts all faces in a message acted too aggressively in abandoning its
search after encountering a region without any face properties. So while
this issue is most visible when using `nicks' highlighting, it's
actually always present and therefore somewhat pernicious. The attached
patch should fix the problem.

[0001-5.6.1-Skip-indentation-when-gathering-faces-in-erc-t.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.