From unknown Mon Jun 16 23:21:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73443 <73443@debbugs.gnu.org> To: bug#73443 <73443@debbugs.gnu.org> Subject: Status: 29.4; ERC 5.6.1-git: erc-track mode line face color broken with left timestamps Reply-To: bug#73443 <73443@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:21:39 +0000 retitle 73443 29.4; ERC 5.6.1-git: erc-track mode line face color broken wi= th left timestamps reassign 73443 emacs submitter 73443 tmarjeski@gmail.com severity 73443 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 23 16:05:28 2024 Received: (at submit) by debbugs.gnu.org; 23 Sep 2024 20:05:28 +0000 Received: from localhost ([127.0.0.1]:44723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sspJH-0002pi-GW for submit@debbugs.gnu.org; Mon, 23 Sep 2024 16:05:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:38284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sspJD-0002oq-UQ for submit@debbugs.gnu.org; Mon, 23 Sep 2024 16:05:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sspIq-0000wd-A9 for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2024 16:05:00 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sspIn-0006la-2k for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2024 16:04:59 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-378c16a4d3eso5171226f8f.1 for ; Mon, 23 Sep 2024 13:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727121895; x=1727726695; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=9P9LKRxNvYHcXU5hJIRIQEHpKv0WONYuTI9UgMdOg7s=; b=MS5oCsKrGxPVIbmDEGdMSM0DTjapTuNBErVSFq3M5Xfssu1e+B94s2eciHEYDlKga9 QLieI4+zWZJ7dO87pmbjMpAOJiEwtfE+PutcMYtt0jJAw8LvTFgJB2/MJxxb8ijmfqDE mXwpQHiUpGpRSz+KxjAkp7FfhKZVw70wQGiwUpDNlZ/YqAduQa5Ic7aX/EwKAutsxBAx nWbXsb/OlhIfQ1KbOkZ/6BVBFgcIbbKSaB7wkAdDfEy5rwXQXt7puye2v5HF+xMgxSyT WS3RMfcrtysQJ09kVEAC8zmlk1OXbliTeI1+D2HlY+TEGOZufzHtzVvQ5jWpOGSyCQjC l3wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727121895; x=1727726695; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9P9LKRxNvYHcXU5hJIRIQEHpKv0WONYuTI9UgMdOg7s=; b=OqIBaw2DYQ0/f85UUnudlyEf/j8gDnqYHBkywUmADsU7dOUTaeCCAZ43eTv7iw1H+V L6kLk5ZWlqH8tjZpMm9c5wVnyrzFlAzBN6sxWcWl1z+aLgZ11Nh+rg4rvUotC3QMkNFt HOOgVqJvaFsb6CeOGwkDYfLBBYdYQVwjgcld5A1Zb/MOCCC5eLNG0DaJdcvO3THXs9YE 4IIbBjWfzW3rrFNnthwqkjE5e21aCSGuxpm9WO616X3IX5NjqFm6yLMEh91mOQwPGq14 rzRQmUiljDwVihQMNs7MrosBv2F0ZW3cIQx3hFCNW12SGqJkRo5F0mXcZEcADQOb0Yyv trQQ== X-Gm-Message-State: AOJu0YyCmAcuQWklIuFgzGFAHfiWPoM2ZHo7w6+TiUWd18aojc2k8dEf 9M9RvflsiDDyysc9ZMxF5LXcuTA+RI6eK8uB1D7gjKK5EDZpx5ColZn1JQ== X-Google-Smtp-Source: AGHT+IHDuvzALfdiRNxyf3kf/mD1aKbDEl5fPvcQHwkXyJHT2Jm7pCEF7soHyJKI6ZztPYUrbG+KtA== X-Received: by 2002:a05:6000:18ca:b0:374:c11c:c5ca with SMTP id ffacd0b85a97d-37a42367bd7mr9658645f8f.46.1727121894220; Mon, 23 Sep 2024 13:04:54 -0700 (PDT) Received: from localhost (109-252-33-9.nat.spd-mgts.ru. [109.252.33.9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e71f051esm25210162f8f.12.2024.09.23.13.04.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 13:04:53 -0700 (PDT) From: tmarjeski@gmail.com To: bug-gnu-emacs@gnu.org Subject: 29.4; ERC 5.6.1-git: erc-track mode line face color broken with left timestamps X-Debbugs-CC: emacs-erc@gnu.org Date: Mon, 23 Sep 2024 23:04:52 +0300 Message-ID: <87h6a63zmj.fsf@trevarch.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=tmarjeski@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When setting erc-insert-timestamp-function to 'erc-insert-timestamp-left the erc-track channel names in the mode line do not respect the nick face color of whoever sent the message. The result is that the face color is white or the color of the timestamp face, whereas with 'erc-insert-timestamp-right the color is of the nick that sent a message. Reproduction steps: 1. emacs -Q 2. (setq erc-insert-timestamp-function 'erc-insert-timestamp-left erc-timestamp-format "[%H:%M") ;; possibly unnecessary (erc-track-mode) ;; enable track mode in mode line 3. Connect to ERC 4. Join a few channels so the names are legible 5. Go to scratch or irc server buffer, wait for a message on a channel 6. Notice that the channel name is not the color of the nick who sent the message In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 System Description: Arch Linux Configured using: 'configure --with-x-toolkit=gtk3 --with-native-compilation=aot --sysconfdir=/etc --prefix=/usr --libexecdir=/usr/lib --with-tree-sitter --localstatedir=/var --with-cairo --disable-build-details --with-harfbuzz --with-libsystemd --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/build/emacs/src=/usr/src/debug/emacs -flto=auto' 'LDFLAGS=-Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,-z,pack-relative-relocs -flto=auto' 'CXXFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wp,-D_GLIBCXX_ASSERTIONS -g -ffile-prefix-map=/build/emacs/src=/usr/src/debug/emacs -flto=auto'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 value of $LC_CTYPE: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ERC Minor modes in effect: erc-ring-mode: t erc-nicks-mode: t erc-netsplit-mode: t erc-menu-mode: t erc-list-mode: t erc-imenu-mode: t erc-pcomplete-mode: t erc-button--phantom-users-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-autojoin-mode: t erc-irccontrols-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t erc-scrolltobottom-mode: t erc-spelling-mode: t flyspell-mode: t erc-track-mode: (t erc-nicks--setup-track-integration) erc-track-minor-mode: t erc-match-mode: t erc-networks-mode: t diff-hl-flydiff-mode: t global-diff-hl-mode: t electric-pair-mode: t apheleia-global-mode: t global-treesit-auto-mode: t corfu-popupinfo-mode: t global-corfu-mode: t corfu-mode: t marginalia-mode: t vertico-mode: t which-key-mode: t global-ligature-mode: t ligature-mode: t global-auto-revert-mode: t global-display-line-numbers-mode: t desktop-save-mode: t recentf-mode: t save-place-mode: t straight-use-package-mode: t straight-package-neutering-mode: t override-global-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/trev/.emacs.d/straight/build/external-completion/external-completion hides /usr/share/emacs/29.4/lisp/external-completion /home/trev/.emacs.d/straight/build/transient/transient hides /usr/share/emacs/29.4/lisp/transient /home/trev/.emacs.d/straight/build/jsonrpc/jsonrpc hides /usr/share/emacs/29.4/lisp/jsonrpc /home/trev/.emacs.d/straight/build/eglot/eglot hides /usr/share/emacs/29.4/lisp/progmodes/eglot /home/trev/.emacs.d/straight/build/xref/xref hides /usr/share/emacs/29.4/lisp/progmodes/xref /home/trev/.emacs.d/straight/build/project/project hides /usr/share/emacs/29.4/lisp/progmodes/project /home/trev/.emacs.d/straight/build/flymake/flymake hides /usr/share/emacs/29.4/lisp/progmodes/flymake /home/trev/.emacs.d/straight/build/erc/erc-button hides /usr/share/emacs/29.4/lisp/erc/erc-button /home/trev/.emacs.d/straight/build/erc/erc-backend hides /usr/share/emacs/29.4/lisp/erc/erc-backend /home/trev/.emacs.d/straight/build/erc/erc-ibuffer hides /usr/share/emacs/29.4/lisp/erc/erc-ibuffer /home/trev/.emacs.d/straight/build/erc/erc-compat hides /usr/share/emacs/29.4/lisp/erc/erc-compat /home/trev/.emacs.d/straight/build/erc/erc-capab hides /usr/share/emacs/29.4/lisp/erc/erc-capab /home/trev/.emacs.d/straight/build/erc/erc hides /usr/share/emacs/29.4/lisp/erc/erc /home/trev/.emacs.d/straight/build/erc/erc-status-sidebar hides /usr/share/emacs/29.4/lisp/erc/erc-status-sidebar /home/trev/.emacs.d/straight/build/erc/erc-identd hides /usr/share/emacs/29.4/lisp/erc/erc-identd /home/trev/.emacs.d/straight/build/erc/erc-replace hides /usr/share/emacs/29.4/lisp/erc/erc-replace /home/trev/.emacs.d/straight/build/erc/erc-sasl hides /usr/share/emacs/29.4/lisp/erc/erc-sasl /home/trev/.emacs.d/straight/build/erc/erc-speedbar hides /usr/share/emacs/29.4/lisp/erc/erc-speedbar /home/trev/.emacs.d/straight/build/erc/erc-notify hides /usr/share/emacs/29.4/lisp/erc/erc-notify /home/trev/.emacs.d/straight/build/erc/erc-pcomplete hides /usr/share/emacs/29.4/lisp/erc/erc-pcomplete /home/trev/.emacs.d/straight/build/erc/erc-list hides /usr/share/emacs/29.4/lisp/erc/erc-list /home/trev/.emacs.d/straight/build/erc/erc-autoaway hides /usr/share/emacs/29.4/lisp/erc/erc-autoaway /home/trev/.emacs.d/straight/build/erc/erc-xdcc hides /usr/share/emacs/29.4/lisp/erc/erc-xdcc /home/trev/.emacs.d/straight/build/erc/erc-networks hides /usr/share/emacs/29.4/lisp/erc/erc-networks /home/trev/.emacs.d/straight/build/erc/erc-page hides /usr/share/emacs/29.4/lisp/erc/erc-page /home/trev/.emacs.d/straight/build/erc/erc-truncate hides /usr/share/emacs/29.4/lisp/erc/erc-truncate /home/trev/.emacs.d/straight/build/erc/erc-lang hides /usr/share/emacs/29.4/lisp/erc/erc-lang /home/trev/.emacs.d/straight/build/erc/erc-sound hides /usr/share/emacs/29.4/lisp/erc/erc-sound /home/trev/.emacs.d/straight/build/erc/erc-fill hides /usr/share/emacs/29.4/lisp/erc/erc-fill /home/trev/.emacs.d/straight/build/erc/erc-loaddefs hides /usr/share/emacs/29.4/lisp/erc/erc-loaddefs /home/trev/.emacs.d/straight/build/erc/erc-ring hides /usr/share/emacs/29.4/lisp/erc/erc-ring /home/trev/.emacs.d/straight/build/erc/erc-join hides /usr/share/emacs/29.4/lisp/erc/erc-join /home/trev/.emacs.d/straight/build/erc/erc-desktop-notifications hides /usr/share/emacs/29.4/lisp/erc/erc-desktop-notifications /home/trev/.emacs.d/straight/build/erc/erc-stamp hides /usr/share/emacs/29.4/lisp/erc/erc-stamp /home/trev/.emacs.d/straight/build/erc/erc-netsplit hides /usr/share/emacs/29.4/lisp/erc/erc-netsplit /home/trev/.emacs.d/straight/build/erc/erc-goodies hides /usr/share/emacs/29.4/lisp/erc/erc-goodies /home/trev/.emacs.d/straight/build/erc/erc-track hides /usr/share/emacs/29.4/lisp/erc/erc-track /home/trev/.emacs.d/straight/build/erc/erc-ezbounce hides /usr/share/emacs/29.4/lisp/erc/erc-ezbounce /home/trev/.emacs.d/straight/build/erc/erc-common hides /usr/share/emacs/29.4/lisp/erc/erc-common /home/trev/.emacs.d/straight/build/erc/erc-imenu hides /usr/share/emacs/29.4/lisp/erc/erc-imenu /home/trev/.emacs.d/straight/build/erc/erc-services hides /usr/share/emacs/29.4/lisp/erc/erc-services /home/trev/.emacs.d/straight/build/erc/erc-spelling hides /usr/share/emacs/29.4/lisp/erc/erc-spelling /home/trev/.emacs.d/straight/build/erc/erc-match hides /usr/share/emacs/29.4/lisp/erc/erc-match /home/trev/.emacs.d/straight/build/erc/erc-menu hides /usr/share/emacs/29.4/lisp/erc/erc-menu /home/trev/.emacs.d/straight/build/erc/erc-dcc hides /usr/share/emacs/29.4/lisp/erc/erc-dcc /home/trev/.emacs.d/straight/build/erc/erc-log hides /usr/share/emacs/29.4/lisp/erc/erc-log /home/trev/.emacs.d/straight/build/eldoc/eldoc hides /usr/share/emacs/29.4/lisp/emacs-lisp/eldoc /home/trev/.emacs.d/straight/build/seq/seq hides /usr/share/emacs/29.4/lisp/emacs-lisp/seq Features: (shadow sort mail-extr emacsbug message yank-media dired dired-loaddefs rfc822 mml mml-sec gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cape orderless project consult bookmark text-property-search pp ace-window avy markdown-mode thingatpt noutline outline network-stream puny nsm erc-ring erc-nicks color erc-netsplit erc-menu erc-list erc-imenu imenu erc-pcomplete pcomplete comint ansi-osc ansi-color ring erc-button browse-url erc-fill erc-stamp erc-join erc-goodies erc-spelling flyspell ispell erc-track erc-match epa-file epa derived epg rfc6068 epg-config erc format-spec erc-backend erc-networks erc-common erc-compat erc-loaddefs comp comp-cstr warnings icons mule-util jka-compr time-date diff-hl-flydiff diff diff-hl log-view pcvs-util vc-dir ewoc vc vc-git diff-mode vc-dispatcher parinfer-rust-mode parinfer-rust-changes parinfer-rust track-changes parinfer-rust-helper url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util url-parse auth-source eieio eieio-core password-cache json map url-vars mailcap elec-pair rainbow-delimiters init erc-init erc-autoloads markdown-mode-autoloads geiser-guile-autoloads geiser-autoloads rust-mode-autoloads parinfer-rust-mode-autoloads eglot-autoloads track-changes-autoloads jsonrpc-autoloads flymake-autoloads project-autoloads xref-autoloads external-completion-autoloads vterm-autoloads nerd-icons-dired-autoloads nerd-icons-autoloads diff-hl-autoloads magit-autoloads magit-section-autoloads git-commit-autoloads with-editor-autoloads dash-autoloads rainbow-mode-autoloads apheleia-autoloads casual-ibuffer-autoloads casual-avy-autoloads use-package-ensure casual-dired-autoloads casual-lib-autoloads transient-autoloads envrc-autoloads inheritenv-autoloads editorconfig-autoloads rainbow-delimiters-autoloads ws-butler-autoloads treesit-auto treesit treesit-auto-autoloads cape-autoloads corfu-doc-terminal-autoloads corfu-doc-autoloads corfu-terminal-autoloads popon-autoloads orderless-autoloads corfu-popupinfo byte-opt corfu corfu-autoloads consult-autoloads marginalia marginalia-autoloads vertico compat vertico-autoloads compat-autoloads info seq-autoloads undo-fu-autoloads ace-window-autoloads avy-autoloads which-key which-key-autoloads diminish diminish-autoloads doom-themes-ext-org doom-nord-theme pcase doom-themes doom-themes-base doom-themes-autoloads finder-inf rx ligature ligature-autoloads eldoc-autoloads use-package-diminish autorevert filenotify display-line-numbers desktop frameset recentf tree-widget wid-edit saveplace edmacro kmacro straight-autoloads straight subr-x cl-extra help-mode cl-macs gv use-package-bind-key bind-key easy-mmode cl-seq use-package-core cl-loaddefs cl-lib bytecomp byte-compile early-init rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 399747 508253) (symbols 48 22267 36) (strings 32 77737 66785) (string-bytes 1 3078055) (vectors 16 46549) (vector-slots 8 1193570 637516) (floats 8 514 1662) (intervals 56 6087 28924) (buffers 984 21)) From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 23 21:22:55 2024 Received: (at 73443) by debbugs.gnu.org; 24 Sep 2024 01:22:55 +0000 Received: from localhost ([127.0.0.1]:44958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssuGV-0003P0-0J for submit@debbugs.gnu.org; Mon, 23 Sep 2024 21:22:55 -0400 Received: from mail-108-mta180.mxroute.com ([136.175.108.180]:46777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssuGR-0003Op-Mw for 73443@debbugs.gnu.org; Mon, 23 Sep 2024 21:22:53 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta180.mxroute.com (ZoneMTA) with ESMTPSA id 192219f5ea50003e01.001 for <73443@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 24 Sep 2024 01:22:25 +0000 X-Zone-Loop: dc8549bfe345d5b090cbe2c8712138fc40fe7e813ca3 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IaIWdrYXE1W1qwbymolY6PFRzg9DLleRQLJHWpyryF8=; b=AUfMwYgrvCrcrtSAUVzk7pXxos ulCDvG3fUInZGvEspqHFjFg+uCCyHBoR3oCwMizYh9PcQOKpZkgDDvhLHax3/16DLMcpC7XcX7KLR xDKeHX9c2HfNtYFoHbxC/6X4IiKRPvMLV6DCGaDj/bHmdIwiMu0BJMrogapfN3nZwxE6zPrpBmgtb /+5K0+l4Xqr7vWADcy4nMjO5dgK+cgoq89Chk4PGi0Djc2X+Q4T7pV1pohi9PEpXWGaemULTHLCas Vg7Y0UUbhiIHhyaIPLCoIVPQtZsfeRiTKORd3AzwWe12s/Kz3LMQxfnyb1NCUMWJlFFnCFuX75yKO OmqWLkYQ==; From: "J.P." To: tmarjeski@gmail.com Subject: Re: bug#73443: 29.4; ERC 5.6.1-git: erc-track mode line face color broken with left timestamps In-Reply-To: <87h6a63zmj.fsf@trevarch.mail-host-address-is-not-set> (tmarjeski@gmail.com's message of "Mon, 23 Sep 2024 23:04:52 +0300") References: <87h6a63zmj.fsf@trevarch.mail-host-address-is-not-set> Date: Mon, 23 Sep 2024 18:22:22 -0700 Message-ID: <87tte5zvzl.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 73443 Cc: emacs-erc@gnu.org, 73443@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hi, tmarjeski@gmail.com writes: > When setting erc-insert-timestamp-function to 'erc-insert-timestamp-left > the erc-track channel names in the mode line do not respect the nick > face color of whoever sent the message. The result is that the face > color is white or the color of the timestamp face, whereas with > 'erc-insert-timestamp-right the color is of the nick that sent a > message. > > Reproduction steps: > 1. emacs -Q > 2. (setq erc-insert-timestamp-function 'erc-insert-timestamp-left > erc-timestamp-format "[%H:%M") ;; possibly unnecessary > (erc-track-mode) ;; enable track mode in mode line > 3. Connect to ERC > 4. Join a few channels so the names are legible > 5. Go to scratch or irc server buffer, wait for a message on a channel > 6. Notice that the channel name is not the color of the nick who sent > the message Unfortunately, I've not (yet) been able to reproduce this. > In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, > cairo version 1.18.0) Complicating things slightly is this bit from the subject line: "29.4; ERC 5.6.1-git" Those two don't normally jive. Typically, when you install the devel version from GNU ELPA, ERC reports its version as something like "5.6.1snapshot0.20240813.11230" If straight.el is using its own non-tarball snapshots [1], it'd be nice to get the actual version string (you mentioned something like this in the Libera channel). If you're feeling lucky, please try (and-let* ((straight--default-directory (straight--repos-dir "erc")) (ref (straight-vc 'get-commit 'git "erc")) (output (straight--process-output "git" "show" "--stat" ref)) (pat (rx bol (* ?\s) "Sourced from erc version " (group (+ (in "0-9.a-z-"))) " on GNU ELPA Devel")) ((string-match pat output)) ((match-string 1 output)))) and share the result (if it doesn't bork your Emacs first). [1] https://github.com/emacs-straight/erc.git Also, in your description above, "the color of the nick that sent a message" appears to suggest you want the `nicks' module loaded (it's not by default and isn't part of the ERC that ships with Emacs 29.4). Anyway, perhaps the recipe should contain something like (setopt erc-modules (add-to-list 'erc-modules 'nicks)) or similar. > Major mode: ERC > > Minor modes in effect: > erc-ring-mode: t > erc-nicks-mode: t ^~~~~~~~~~~~~~~~~ I realize this list of modes is merely gleaned from the Emacs process that generated the bug report and not necessarily the one exhibiting the bug. Nevertheless, I'm compelled to wonder if your straight.el configuration isn't somehow inadvertently "contaminating" the session launched from your emacs -Q recipe behind the scenes? > erc-scrolltobottom-mode: t > erc-spelling-mode: t > flyspell-mode: t > erc-track-mode: (t erc-nicks--setup-track-integration) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ BTW, this strange value is definitely a bug (that I believe I can fix). But it's likely unrelated to your issue, sadly. > Load-path shadows: [...] > /home/trev/.emacs.d/straight/build/erc/erc-fill hides > /usr/share/emacs/29.4/lisp/erc/erc-fill > /home/trev/.emacs.d/straight/build/erc/erc-loaddefs hides > /usr/share/emacs/29.4/lisp/erc/erc-loaddefs If these load paths or ones like it are in fact generated from the suspected straight.el snapshots mentioned above _and_ are meant to be present in your -Q recipe's session, please specify something like emacs -Q -L /home/trev/.emacs.d/straight/build/erc -l /home/trev/.emacs.d/straight/build/erc/erc-autoloads.el if possible. Better still would be a full recipe for a clean install from scratch. For example: 1. $ mkdir -p /tmp/bug73443/.emacs.d/ 2. Put this in /tmp/bug73443/.emacs.d/init.el: ;; -*- lexical-binding: t; -*- ;; straight.el boilerplate (defvar bootstrap-version) (let ((bootstrap-file (expand-file-name "straight/repos/straight.el/bootstrap.el" (or (bound-and-true-p straight-base-dir) user-emacs-directory))) (bootstrap-version 7)) (unless (file-exists-p bootstrap-file) (with-current-buffer (url-retrieve-synchronously "https://raw.githubusercontent.com/radian-software/straight.el/develop/install.el" 'silent 'inhibit-cookies) (goto-char (point-max)) (eval-print-last-sexp))) (load bootstrap-file nil 'nomessage)) (straight-use-package 'use-package) (setq straight-use-package-by-default t) ;; Config for ERC recipe (use-package erc :defer t :config (setopt erc-modules (seq-union '(nicks scrolltobottom spelling) erc-modules)) :custom (erc-insert-timestamp-function #'erc-insert-timestamp-left)) 3. $ HOME=/tmp/bug73443 emacs 4. M-x restart-emacs RET 5. M-x erc-tls RET ... RET FWIW, using the above setup, I don't notice the behavior described nor any difference in the mode line with `erc-insert-timestamp-function' set to 'erc-insert-timestamp-right' or its default. If you're able to confirm this, then perhaps we can assume there's indeed been some kind of "contamination," at which point it may be worth adding `use-package' declarations for some of the other built-in modes and packages present when the bug occurred. If you're able to narrow it down to an unfavorable combination, perhaps we can teach ERC to integrate better with those culprits. Cheers. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 24 02:55:18 2024 Received: (at 73443) by debbugs.gnu.org; 24 Sep 2024 06:55:19 +0000 Received: from localhost ([127.0.0.1]:45146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sszSA-0004pL-BE for submit@debbugs.gnu.org; Tue, 24 Sep 2024 02:55:18 -0400 Received: from mail-yb1-f182.google.com ([209.85.219.182]:52671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sszS2-0004oN-Ig for 73443@debbugs.gnu.org; Tue, 24 Sep 2024 02:55:11 -0400 Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-e1a989bd17aso4415463276.1 for <73443@debbugs.gnu.org>; Mon, 23 Sep 2024 23:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727160821; x=1727765621; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=p6KfydeKh9UwxiazdsV9+/ObmcV6+wKpkfA2cubZ5Vc=; b=htYtoW+AIUZYFWx7QcMmkIr3qoyWhCtROz/tZE54ToLaH4+ZxBq2t/4MJBRlk4jocV nfFiH3Ex9VCYEvPOfwNb8rMNxR3YgmMwwhhXhhDyDrTK4ETA4K6QCj33UAgOv1d4Jc0J VdP4NHjpCKX/XHz3CGqKTUOBhCauykGIu3HNfTUlRxBA4AcvhwOdXz5jWnocr9GUMEn7 YO/UctNDC+qWP5AVdIsv11ZR5UTJUkyRkg75m7Pvrj/GUoPNhkz3Bnq2JcVTHKpmg/i+ YxI6j9LWYE+V5ZNaXDNQresdndoKDGML9fM3a5+rGaFK6uFTykkmeveQ6vtkTG/PPktr wY3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727160821; x=1727765621; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p6KfydeKh9UwxiazdsV9+/ObmcV6+wKpkfA2cubZ5Vc=; b=CJAolcFW5ZIYWS6hBec7+49mxbUrynMWCXCSoPdDfcfqKCS2tcNQPS1lGiPuzJtNx7 9K54pdzXlprO8GT1oPvSRuOHu/obdictHFbOMiHgOsuBPmGPL8F+V3azo3Ia4xEJqJRl +S4JYAChS3ckhpKhpGq3flLd5FWJ3TkEhEQDkfcMChA7oWW47e3bLGKubUdrpauREZwX ezc/C/stiTToD7znsHIbPWLjYC2HYWBx9f1BJ9DZZSiBnz6tNURRmZW+f+JHddR2b+5Y fKaoEMVLpio/EIT/68sf1jvPYeseLpIaz6FhS4Rr197MkN7YLwQJeGiG6fDmpoTSwncg J1Og== X-Gm-Message-State: AOJu0YyJP5k6VRlNoKjffsSwJ6jJk3c0a/XoEoYHJ9r111oPR1+cKQle 2hKA37sGPWqje/IKhXRipURJtJqmGLCVhHc1982l1skEhF6wqRgZpNF/ZDa1hv4qEILgCzo2AIv oUKkOqdkXqqq6sEbkKEYKh9bTGCI= X-Google-Smtp-Source: AGHT+IG9+CrqnVnPAvtmJAUkFtOOjg7ji0npBAxGif0YUQeWjxWo8clcp4X+L6fsd10+GFaoSxoKUAdOPf6ggRkNfEM= X-Received: by 2002:a05:6902:1022:b0:e22:4f30:5d6c with SMTP id 3f1490d57ef6-e2250c28adfmr11544956276.6.1727160820682; Mon, 23 Sep 2024 23:53:40 -0700 (PDT) MIME-Version: 1.0 References: <87h6a63zmj.fsf@trevarch.mail-host-address-is-not-set> <87tte5zvzl.fsf@neverwas.me> <87r0998tqe.fsf@trevarch.mail-host-address-is-not-set> In-Reply-To: <87r0998tqe.fsf@trevarch.mail-host-address-is-not-set> From: Trevor Arjeski Date: Tue, 24 Sep 2024 09:53:29 +0300 Message-ID: Subject: Fwd: bug#73443: 29.4; ERC 5.6.1-git: erc-track mode line face color broken with left timestamps To: "J.P." Content-Type: multipart/alternative; boundary="0000000000002fdfc00622d7f785" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73443 Cc: emacs-erc@gnu.org, 73443@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002fdfc00622d7f785 Content-Type: text/plain; charset="UTF-8" "J.P." writes: > Complicating things slightly is this bit from the subject line: > > "29.4; ERC 5.6.1-git" > Agreed. I don't even really want to begin debugging this. Perhaps we should consider the issue moot unless verifiable on Emacs 30+ or master. > FWIW, using the above setup, I don't notice the behavior described nor > any difference in the mode line with `erc-insert-timestamp-function' set > to 'erc-insert-timestamp-right' or its default. I was not able to reproduce the issue either with your provided config using 'erc-insert-timestamp-left (also needed to turn on erc-track-mode). Thanks for looking into this. --0000000000002fdfc00622d7f785 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


"J.P." <jp@neverwas.me> writes:

> Complicating things slightly is this bit from the subject line:
>
>=C2=A0 =C2=A0"29.4; ERC 5.6.1-git"
>

Agreed. I don't even really want to begin debugging this. Perhaps we should consider the issue moot unless verifiable on Emacs 30+ or master.
> FWIW, using the above setup, I don't notice the behavior described= nor
> any difference in the mode line with `erc-insert-timestamp-function= 9; set
> to 'erc-insert-timestamp-right' or its default.

I was not able to reproduce the issue either with your provided config
using 'erc-insert-timestamp-left (also needed to turn on erc-track-mode= ).

Thanks for looking into this.
--0000000000002fdfc00622d7f785-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 24 03:04:25 2024 Received: (at 73443) by debbugs.gnu.org; 24 Sep 2024 07:04:25 +0000 Received: from localhost ([127.0.0.1]:45151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sszay-0005Lm-Of for submit@debbugs.gnu.org; Tue, 24 Sep 2024 03:04:25 -0400 Received: from mail-108-mta79.mxroute.com ([136.175.108.79]:39137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sszaw-0005Ld-KS for 73443@debbugs.gnu.org; Tue, 24 Sep 2024 03:04:23 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta79.mxroute.com (ZoneMTA) with ESMTPSA id 19222d805610003e01.001 for <73443@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 24 Sep 2024 07:03:55 +0000 X-Zone-Loop: a451cc90a3d2b86de2d55c0d3b7fd36bc30f1ce3d511 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8rdxf1+WWFMJ7BVvus6j9ZkIiWGnEEHHiA49zQaQBW4=; b=ajfQG+Zf5v+wQ9hJ89zXeI2pwx 3tL8xvev4iTwJZv6zfau+K+WUgj4ITGo3oeFpOK6OpXrnnfex2ZPHOiSeju4IC3TFJ9uUq7dk0vRT xUn0Io5mcOpHSgJcp2fpCB6jDiL/iy7l+qGB5NAnkvw9SOQ8LHMiK2tGeDkYz615INF4Py7270J86 TkEDTua15zVyK8ZbCoxSabYLBGLT6cZg5K3Y/MiwoTOdiYpRw6I2VqG8BfxkIE840JjFSQGhoEJ3s 6tC9QiRnB7kl9Iu9/WYaOp7L1x28cH1N6EV66+CLBTFJN+Z4lpkMl4kOX4M/F9h1VzzuM8bHCNz0X zkFvUdPA==; From: "J.P." To: Trevor Arjeski Subject: Re: Fwd: bug#73443: 29.4; ERC 5.6.1-git: erc-track mode line face color broken with left timestamps In-Reply-To: (Trevor Arjeski's message of "Tue, 24 Sep 2024 09:53:29 +0300") References: <87h6a63zmj.fsf@trevarch.mail-host-address-is-not-set> <87tte5zvzl.fsf@neverwas.me> <87r0998tqe.fsf@trevarch.mail-host-address-is-not-set> Date: Tue, 24 Sep 2024 00:03:52 -0700 Message-ID: <871q19y1lz.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73443 Cc: emacs-erc@gnu.org, 73443@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Trevor Arjeski writes: > "J.P." writes: > >> Complicating things slightly is this bit from the subject line: >> >> "29.4; ERC 5.6.1-git" >> > The version output with your snippet: 5.6.1snapshot0.20240813.11230 OK, that's what I get when I install straight.el from scratch. So at least we're synced. > > Agreed. I don't even really want to begin debugging this. Perhaps we > should consider the issue moot unless verifiable on Emacs 30+ or master. You could start by "bisecting" the non-ERC parts of your config or the non-ERC modes listed in the gathered facts from your initial report (default stuff commented out): // erc-ring-mode: t // erc-nicks-mode: t // config // erc-netsplit-mode: t // erc-menu-mode: t // erc-list-mode: t // erc-imenu-mode: t // erc-pcomplete-mode: t // erc-button--phantom-users-mode: t // erc-button-mode: t // erc-fill-mode: t // erc-stamp-mode: t // erc-autojoin-mode: t // erc-irccontrols-mode: t // erc-move-to-prompt-mode: t // erc-readonly-mode: t // erc-scrolltobottom-mode: t // config // erc-spelling-mode: t // config // flyspell-mode: t // config (spell module) // erc-track-mode: t // erc-track-minor-mode: t // erc-match-mode: t // erc-networks-mode: t diff-hl-flydiff-mode: t global-diff-hl-mode: t electric-pair-mode: t apheleia-global-mode: t global-treesit-auto-mode: t corfu-popupinfo-mode: t global-corfu-mode: t corfu-mode: t marginalia-mode: t vertico-mode: t which-key-mode: t global-ligature-mode: t ligature-mode: t global-auto-revert-mode: t global-display-line-numbers-mode: t desktop-save-mode: t recentf-mode: t save-place-mode: t // straight-use-package-mode: t // config // straight-package-neutering-mode: t // config override-global-mode: t // global-eldoc-mode: t // show-paren-mode: t // electric-indent-mode: t // mouse-wheel-mode: t // file-name-shadow-mode: t // global-font-lock-mode: t // font-lock-mode: t // blink-cursor-mode: t column-number-mode: t // line-number-mode: t // transient-mark-mode: t // auto-composition-mode: t // auto-encryption-mode: t // auto-compression-mode: t So, essentially, you'd just be adding like half of these to the base config from my previous reply, e.g., (use-package diff-hl ...) ; where "..." means "your config details" (use-package elec-pair :straight nil :init (electric-pair-mode +1)) (use-package apheleia ...) ;; [...] (use-package vertico ...) And if the bug is still present, remove half of those, and so on. But if it's absent, switch to the other half and test again. Let me know if that doesn't make sense. (And apologies if you're already familiar with this method.) > >> FWIW, using the above setup, I don't notice the behavior described nor >> any difference in the mode line with `erc-insert-timestamp-function' set >> to 'erc-insert-timestamp-right' or its default. > > I was not able to reproduce the issue either with your provided config > using 'erc-insert-timestamp-left (also needed to turn on erc-track-mode). FYI, you actually don't _need_ to explicitly activate any minor modes for modules that appear in `erc-modules', which `track' (i.e., `erc-track-mode') does by default. I know the ";;; Commentary" front matter atop ERC's libraries makes it seem otherwise, but that's because they're ancient and were never updated. Sorry about that (good first issue, though). So, yeah, rule of thumb: if `erc-modules' contains some module `foo', you almost never need (erc-foo-mode +1) in your config, at least not for built-in modules. That said, doing so is superfluous and basically benign. > > Thanks for looking into this. No problem! From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 24 04:09:44 2024 Received: (at 73443) by debbugs.gnu.org; 24 Sep 2024 08:09:44 +0000 Received: from localhost ([127.0.0.1]:45206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1st0cC-0000V1-58 for submit@debbugs.gnu.org; Tue, 24 Sep 2024 04:09:44 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:42128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1st0cA-0000Um-SH for 73443@debbugs.gnu.org; Tue, 24 Sep 2024 04:09:43 -0400 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-42ca6ba750eso33098855e9.0 for <73443@debbugs.gnu.org>; Tue, 24 Sep 2024 01:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727165293; x=1727770093; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=G5+bxpBokt0OzR0966iyFtc1L2Bdg6kq7r2h1Sj5+7Q=; b=WLzwc3dX1HoVUql7nlWc+ODWmMVppPOOgsmGwd7vTpg3TIoR48yRFZLzZPcsN0vmnf XzN2XIPU73pdMBUtIm7QnLimnmVZNOPO6g5vYZvSh43IdypvCNQcMkmHZehs99ham7wN er7WWWmhus7lmNKW6/yGShtGCt2QAr733B9fxZZdWjYUtA6c+udzetXvx2aiTNtgqOH/ 4neiNWNDPd6YHM5a2QAlvNQCAfSMEaic27jRSoYh3EvcRLCk4QJv8eiWjSHJLevg1kJU kjAi0EDWHO0x9AGXKiQNhrOpbAOq6LkZYyMf0q9EIyCY2oCX+HK3scAzqYqcojw+kmOX Bvcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727165293; x=1727770093; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G5+bxpBokt0OzR0966iyFtc1L2Bdg6kq7r2h1Sj5+7Q=; b=HoA7qzX1+AU77XC4NlrCFuybkyf6ymSbavt15iYvXZFXLkFx5doVCXqvZiDMGbSwWX DuQf8rrd1qZDJErw6/rlBUfTfL+jTMSpVd7jCX6o6UQphnyKZUPz4zzn9ikRHhu9y1kK 0QPzo+7GVtk4xTNVw+0N8ukBM4NQbvh7zrhxP0MJ0WRBIlRSoIYktj3WNqpRJmwrOwRr sISQPKcVPYrPaXG45hkfxbpkZK8KhduBvRwuCaaYtsqceRzDrcSbCUhTzMuOB129tS4a JR8q9UkWa1Npg204oFRekydOu3fsMkxxFfx3AvFdL0ehXDYgBajCnyO0DMRzWKeSEN9p yBtg== X-Gm-Message-State: AOJu0Yzyk9I/MwmAbGNl9LraYAxEPRaGsyKuwu8YOyZyMr0X3IVFj6hx +r6eiDibzZa40nBJf56YvuUFBJ1/UFy14AZ1g9YPLnnvovIaC55b X-Google-Smtp-Source: AGHT+IFmFORfwoKbGpzeFfxwJqcs33q8nLbzFHgpfuvo+lxzVG+gZOK2L4k3ceUNJ0Ehkww+zBNRWQ== X-Received: by 2002:a05:600c:1386:b0:42c:b826:a26c with SMTP id 5b1f17b1804b1-42e8f34c889mr12438265e9.8.1727165291229; Tue, 24 Sep 2024 01:08:11 -0700 (PDT) Received: from trevarch (109-252-33-9.nat.spd-mgts.ru. [109.252.33.9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e902b67adsm13784895e9.34.2024.09.24.01.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 01:08:10 -0700 (PDT) From: Trevor Arjeski To: "J.P." Subject: Re: Fwd: bug#73443: 29.4; ERC 5.6.1-git: erc-track mode line face color broken with left timestamps In-Reply-To: <871q19y1lz.fsf@neverwas.me> (J. P.'s message of "Tue, 24 Sep 2024 00:03:52 -0700") References: <87h6a63zmj.fsf@trevarch.mail-host-address-is-not-set> <87tte5zvzl.fsf@neverwas.me> <87r0998tqe.fsf@trevarch.mail-host-address-is-not-set> <871q19y1lz.fsf@neverwas.me> Date: Tue, 24 Sep 2024 11:08:09 +0300 Message-ID: <87ed59o4nq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73443 Cc: emacs-erc@gnu.org, 73443@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "J.P." writes: > You could start by "bisecting" the non-ERC parts of your config or the > non-ERC modes listed in the gathered facts from your initial report > (default stuff commented out): After a bisect, I was able to find the culprit: (erc-fill-function 'erc-fill-static) Toggling this to and from the default - 'erc-fill-variable - allows me to reproduce the issue consistently. My guess is that the track parser does not like the extra padding between the timestamp and nick, but I haven't yet looked into the code. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 24 20:40:16 2024 Received: (at 73443) by debbugs.gnu.org; 25 Sep 2024 00:40:16 +0000 Received: from localhost ([127.0.0.1]:53710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stG4m-0006gY-0d for submit@debbugs.gnu.org; Tue, 24 Sep 2024 20:40:16 -0400 Received: from mail-108-mta206.mxroute.com ([136.175.108.206]:42675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stG1Q-0006Xm-0G for 73443@debbugs.gnu.org; Tue, 24 Sep 2024 20:36:49 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta206.mxroute.com (ZoneMTA) with ESMTPSA id 192269b7c590003e01.001 for <73443@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 25 Sep 2024 00:36:17 +0000 X-Zone-Loop: 901402d6eb84d0f12bc7146ba5b850750f5aeabe3696 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=t5nTlBf7VDqNeey+MSheRFbR2Nf92uTZ6UN/NuaRUeg=; b=ZifjTJ+yVR72wWq+jw5KbaPi31 YYf0Mgr7PeKOwMUR8k4GxGhBCPwLA/sfKnAN0TB3Xzm8B4foXk50mv+APNPHBF+B83Khsqmfcg7U1 zOGiMvDMnOhfqChNqXQh+I3paAmrgbuUUvP/zn8DMUKHQWsWK3dyF+34v1vobbDgHYYcwSBdMSPli WT87UDE6eL6Yzyq6YUKtX+lpeJ/cm56g5AFxxH0h1h/G3qDuu0AWhsiL5SuUcZqmMky5A4UTqV155 9IHyDmwVLOSV+z0IP6JlG9a1zc/xNeupuN/M5xr3IhHivFO4TJjmNOzAh2YstQIzGG18/pSGhj5Wa 6bkyit5g==; From: "J.P." To: Trevor Arjeski Subject: Re: Fwd: bug#73443: 29.4; ERC 5.6.1-git: erc-track mode line face color broken with left timestamps In-Reply-To: <87ed59o4nq.fsf@gmail.com> (Trevor Arjeski's message of "Tue, 24 Sep 2024 11:08:09 +0300") References: <87h6a63zmj.fsf@trevarch.mail-host-address-is-not-set> <87tte5zvzl.fsf@neverwas.me> <87r0998tqe.fsf@trevarch.mail-host-address-is-not-set> <871q19y1lz.fsf@neverwas.me> <87ed59o4nq.fsf@gmail.com> Date: Tue, 24 Sep 2024 17:36:10 -0700 Message-ID: <87v7ykvabp.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Authenticated-Id: masked@neverwas.me X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73443 Cc: emacs-erc@gnu.org, 73443@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Trevor Arjeski writes: > "J.P." writes: > >> You could start by "bisecting" the non-ERC parts of your config or the >> non-ERC modes listed in the gathered facts from your initial report >> (default stuff commented out): > > After a bisect, I was able to find the culprit: > > (erc-fill-function 'erc-fill-static) > > Toggling this to and from the default - 'erc-fill-variable - allows me > to reproduce the issue consistently. Thanks for getting to the bottom of this. I was indeed able to reproduce it with user options alone. > > My guess is that the track parser does not like the extra padding > between the timestamp and nick, but I haven't yet looked into the code. Yes, that's essentially what's happening. The new internal function that extracts all faces in a message acted too aggressively in abandoning its search after encountering a region without any face properties. So while this issue is most visible when using `nicks' highlighting, it's actually always present and therefore somewhat pernicious. The attached patch should fix the problem. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-5.6.1-Skip-indentation-when-gathering-faces-in-erc-t.patch >From c9c74f6f3691ffe9a35558bcbd764381d127f36d Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Mon, 23 Sep 2024 13:48:19 -0700 Subject: [PATCH] [5.6.1] Skip indentation when gathering faces in erc-track * lisp/erc/erc-nicks.el (erc-nicks-mode, erc-nicks-enable) (erc-nicks-disable): Use correct name for `track' module hook. * lisp/erc/erc-track.el (erc-make-mode-line-buffer-name): Don't error when optional COUNT is nil. (erc-track-modified-channels): Use new name for face-finding function. (erc-track--get-faces-in-current-message, erc-track--collect-faces-in): Rename former to latter to better reflect expanded utility, which can span gaps, including newlines and indentation that don't have face-related properties. * test/lisp/erc/erc-track-tests.el (erc-track--collect-faces-in): New test. (Bug#73443) --- lisp/erc/erc-nicks.el | 3 +- lisp/erc/erc-track.el | 42 +++++------ test/lisp/erc/erc-track-tests.el | 126 ++++++++++++++++++++++++++++++- 3 files changed, 148 insertions(+), 23 deletions(-) diff --git a/lisp/erc/erc-nicks.el b/lisp/erc/erc-nicks.el index ccf65f15abd..65a12c927bd 100644 --- a/lisp/erc/erc-nicks.el +++ b/lisp/erc/erc-nicks.el @@ -580,7 +580,7 @@ nicks (setf (alist-get "Edit face" erc-button--nick-popup-alist nil nil #'equal) #'erc-nicks-customize-face) (erc-nicks--setup-track-integration) - (add-hook 'erc-track-mode #'erc-nicks--setup-track-integration 50 t) + (add-hook 'erc-track-mode-hook #'erc-nicks--setup-track-integration 50 t) (advice-add 'widget-create-child-and-convert :filter-args #'erc-nicks--redirect-face-widget-link)) ((kill-local-variable 'erc-nicks--face-table) @@ -598,6 +598,7 @@ nicks #'erc-nicks--highlight-button) (remove-function (local 'erc-track--alt-normals-function) #'erc-nicks--check-normals) + (remove-hook 'erc-track-mode-hook #'erc-nicks--setup-track-integration t) (setf (alist-get "Edit face" erc-button--nick-popup-alist nil 'remove #'equal) nil) diff --git a/lisp/erc/erc-track.el b/lisp/erc/erc-track.el index 39a4775ddca..f40960e4a22 100644 --- a/lisp/erc/erc-track.el +++ b/lisp/erc/erc-track.el @@ -768,7 +768,7 @@ erc-make-mode-line-buffer-name ;; (really?), 3. the defun needs to switch to BUFFER, so we would ;; need to save that value somewhere. (let ((map (make-sparse-keymap)) - (name (if erc-track-showcount + (name (if (and count erc-track-showcount) (concat string erc-track-showcount-string (int-to-string count)) @@ -992,7 +992,7 @@ erc-track-modified-channels (when-let ((faces (if erc-track-ignore-normal-contenders-p (erc-faces-in (buffer-string)) - (erc-track--get-faces-in-current-message))) + (erc-track--collect-faces-in))) (normals erc-track--normal-faces) (erc-track-faces-priority-list `(,@erc-track--attn-faces ,@erc-track-faces-priority-list)) @@ -1057,25 +1057,25 @@ erc-faces-in (defvar erc-track--face-reject-function nil "Function called with face in current buffer to massage or reject.") -(defun erc-track--get-faces-in-current-message () - "Collect all faces in the narrowed buffer. -Return a cons of a hash table and a list ordered from most -recently seen to earliest seen." - (let ((i (text-property-not-all (point-min) (point-max) 'font-lock-face nil)) - (seen (make-hash-table :test #'equal)) - ;; - (rfaces ()) - (faces (make-hash-table :test #'equal))) - (while-let ((i) - (cur (get-text-property i 'face))) - (unless (gethash cur seen) - (puthash cur t seen) - (when erc-track--face-reject-function - (setq cur (funcall erc-track--face-reject-function cur))) - (when cur - (push cur rfaces) - (puthash cur t faces))) - (setq i (next-single-property-change i 'font-lock-face))) +(defun erc-track--collect-faces-in () + "Collect all faces in the (presumably narrowed) current buffer. +Return a cons cell of a hash table and a list ordered from most recently +seen to least." + (let* ((prop (if noninteractive 'font-lock-face 'face)) + (p (text-property-not-all (point-min) (point-max) prop nil)) + (seen (and p (make-hash-table :test #'equal))) + (faces (make-hash-table :test #'equal)) + (rfaces ())) + (while p + (when-let ((cur (get-text-property p prop))) + (unless (gethash cur seen) + (puthash cur t seen) + (when erc-track--face-reject-function + (setq cur (funcall erc-track--face-reject-function cur))) + (when cur + (push cur rfaces) + (puthash cur t faces)))) + (setq p (next-single-property-change p prop))) (cons faces rfaces))) ;;; Buffer switching diff --git a/test/lisp/erc/erc-track-tests.el b/test/lisp/erc/erc-track-tests.el index 3288c42a42e..8149138a971 100644 --- a/test/lisp/erc/erc-track-tests.el +++ b/test/lisp/erc/erc-track-tests.el @@ -22,8 +22,12 @@ ;;; Code: -(require 'ert) (require 'erc-track) +(require 'ert-x) +(eval-and-compile + (let ((load-path (cons (ert-resource-directory) load-path))) + (require 'erc-tests-common))) + (ert-deftest erc-track--shorten-aggressive-nil () "Test non-aggressive erc track buffer name shortening." @@ -286,4 +290,124 @@ erc-track--select-mode-line-face (a b (b a)) (a b (a b))))) +(ert-deftest erc-track--collect-faces-in () + (with-current-buffer (get-buffer-create "*erc-track--get-faces-in*") + (erc-tests-common-prep-for-insertion) + (goto-char (point-min)) + (skip-chars-forward "\n") + + (let ((ts #("[04:37]" + 0 1 ( erc--msg 0 field erc-timestamp + font-lock-face erc-timestamp-face) + 1 7 ( field erc-timestamp + font-lock-face erc-timestamp-face))) + bounds) + + (with-silent-modifications + + (push (list (point)) bounds) + (insert ; JOIN + ts " " ; iniital `fill' indentation lacks properties + #("*** You have joined channel #chan" 0 33 + (font-lock-face erc-notice-face)) + "\n") + (setcdr (car bounds) (point)) + + (push (list (point)) bounds) + (insert ; 353 + ts " " + #("*** Users on #chan: bob alice dummy tester" + 0 30 (font-lock-face erc-notice-face) + 30 35 (font-lock-face erc-current-nick-face) + 35 42 (font-lock-face erc-notice-face)) + "\n" #(" @fsbot" ; but intervening HAS properties + 0 23 (font-lock-face erc-notice-face))) + (setcdr (car bounds) (point)) + + (push (list (point)) bounds) + (insert ; PRIVMSG + "\n" ts " " + #(" bob: Thou canst not come to me: I come to" + 0 1 (font-lock-face erc-default-face) + ;; erc-dangerous-host-face -> erc-nicks-alice-face (undefined) + 1 6 (font-lock-face (erc-dangerous-host-face erc-nick-default-face)) + 6 8 (font-lock-face erc-default-face) + ;; erc-pal-face -> erc-nicks-bob-face (undefined) + 8 11 (font-lock-face (erc-pal-face erc-default-face)) + 11 49 (font-lock-face erc-default-face)) + "\n" #(" thee." + 0 22 (font-lock-face erc-default-face)) + "\n") + (setcdr (car bounds) (point))) + + (goto-char (point-max)) + (should (equal (setq bounds (nreverse bounds)) + '((3 . 50) (50 . 129) (129 . 212)))) + + ;; For these result assertions, the insertion order of the table + ;; elements should mirror that of the consed lists. + + ;; Baseline + (narrow-to-region 1 3) + (let ((result (erc-track--collect-faces-in))) + (should-not (map-pairs (car result))) + (should-not (cdr result))) + + ;; JOIN + (narrow-to-region (car (nth 0 bounds)) (cdr (nth 0 bounds))) + (let ((result (erc-track--collect-faces-in))) + (should (seq-set-equal-p + (map-pairs (car result)) '((erc-timestamp-face . t) + (erc-notice-face . t)))) + (should (equal (cdr result) '(erc-notice-face erc-timestamp-face)))) + + ;; 353 + (narrow-to-region (car (nth 1 bounds)) (cdr (nth 1 bounds))) + (let ((result (erc-track--collect-faces-in))) + (should (seq-set-equal-p (map-pairs (car result)) + '((erc-timestamp-face . t) + (erc-notice-face . t) + (erc-current-nick-face . t)))) + (should (equal (cdr result) '(erc-current-nick-face + erc-notice-face + erc-timestamp-face)))) + + ;; PRIVMSG + (narrow-to-region (car (nth 2 bounds)) (cdr (nth 2 bounds))) + (let ((result (erc-track--collect-faces-in))) + (should (seq-set-equal-p + (map-pairs (car result)) + '((erc-timestamp-face . t) + (erc-default-face . t) + ((erc-dangerous-host-face erc-nick-default-face) . t) + ((erc-pal-face erc-default-face) . t)))) + (should (equal (cdr result) + '((erc-pal-face erc-default-face) + (erc-dangerous-host-face erc-nick-default-face) + erc-default-face + erc-timestamp-face)))) + + ;; Entire buffer. + (narrow-to-region (car (nth 0 bounds)) erc-insert-marker) + (let ((result (erc-track--collect-faces-in))) + (should (seq-set-equal-p + (map-pairs (car result)) + '((erc-timestamp-face . t) + (erc-notice-face . t) + (erc-current-nick-face . t) + (erc-default-face . t) + ((erc-dangerous-host-face erc-nick-default-face) . t) + ((erc-pal-face erc-default-face) . t)))) + (should (equal (cdr result) + '((erc-pal-face erc-default-face) + (erc-dangerous-host-face erc-nick-default-face) + erc-default-face + erc-current-nick-face + erc-notice-face + erc-timestamp-face))))) + + (widen) + (when noninteractive + (kill-buffer)))) + ;;; erc-track-tests.el ends here -- 2.46.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 00:56:07 2024 Received: (at 73443) by debbugs.gnu.org; 25 Sep 2024 04:56:08 +0000 Received: from localhost ([127.0.0.1]:42701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stK4N-0000zc-NR for submit@debbugs.gnu.org; Wed, 25 Sep 2024 00:56:07 -0400 Received: from mail-lf1-f50.google.com ([209.85.167.50]:42369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stK4L-0000z3-NO for 73443@debbugs.gnu.org; Wed, 25 Sep 2024 00:56:06 -0400 Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-53659c8d688so430575e87.1 for <73443@debbugs.gnu.org>; Tue, 24 Sep 2024 21:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727240074; x=1727844874; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8GQrPoXMySOvgPDOgqXpzp7KMbdiaifDoytJvST46rw=; b=SHmtgKv+330MEpI4LYSJBalIBqUXLUgsN5iNLxV1dPPCo2MgbOR9Cn1sdgvh+SNq+5 hvcML+FFaTf9QDOPYko9BTY3dhp6IBetNqvoB/O8G+bPIAeIzu/B4sal/lNrH6Bxqrig eZ5VWiKr3QbamxZ/vD7UdsYzjwH76Ufv8KUzc+ywFz4Hh9+qBVYhxqb+XKJVMUssT19o kj/ssVVX8itEkniChoEwa+opBHlfoDmpqZhFLJ8xUF0ujR7diVwRUT1awHtgQO2i0vfL xDGC+dfEW+/XSDjtFZqLRC1j5iIXWUGBQtvBULKxpAMWhJY0qxt7UhFDkpLnS3psIxVN Bvmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727240074; x=1727844874; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8GQrPoXMySOvgPDOgqXpzp7KMbdiaifDoytJvST46rw=; b=SvdCXyP8gkUU4jZcmWbuUYoEeuPPtyOl9zYWileF7FHb3wN31BbcI7LVOeKusWK2ib 1mpzwHXsj7D1wdn0zA6jhIYP5nLzt8hGRIpOCFVXv0XXR81eU1JhrBxLBESwJk6JM460 IJmFc0U8nPg2Gx3MLlO1vLr1zYv1QG5EIfkDbSny0FOAz8Re3mnJILjSJihpWJBGkzVs qXFH9v3C12zz+oq+qZQaOLB6yqj6nYCg3NTTGRgeQEZ55KsHGvviwfayInUQ5ZjjQ27w 4yL70XMVif0pDtZNnkfLowfpoSf7hXUf+Fme80vFJKUR26Kgp2IHE81CPt8gBQaRq4gs Yg0w== X-Gm-Message-State: AOJu0Yzjgi9m/yFRmaw1b5NqWjXOy9h/Pv74gAlRac3YILfU/jhK7B1K a/wfCc6b14csgtjW6zKFTAAAbygCgMp3iwnjxzxI0Xli4Ly7Y4os X-Google-Smtp-Source: AGHT+IGgEcZY1Yywvhcd0jgZx31cbxqifK/uKYXW48vPJqwnB90FuVe/u/UI44f9SA7xzoygZFbnsw== X-Received: by 2002:a05:6512:b02:b0:52f:cc9e:449d with SMTP id 2adb3069b0e04-537a65110cdmr1803553e87.3.1727240073823; Tue, 24 Sep 2024 21:54:33 -0700 (PDT) Received: from trevarch (109-252-33-9.nat.spd-mgts.ru. [109.252.33.9]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-537a8648a55sm409403e87.192.2024.09.24.21.54.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 21:54:32 -0700 (PDT) From: Trevor Arjeski To: "J.P." Subject: Re: Fwd: bug#73443: 29.4; ERC 5.6.1-git: erc-track mode line face color broken with left timestamps In-Reply-To: <87v7ykvabp.fsf@neverwas.me> (J. P.'s message of "Tue, 24 Sep 2024 17:36:10 -0700") References: <87h6a63zmj.fsf@trevarch.mail-host-address-is-not-set> <87tte5zvzl.fsf@neverwas.me> <87r0998tqe.fsf@trevarch.mail-host-address-is-not-set> <871q19y1lz.fsf@neverwas.me> <87ed59o4nq.fsf@gmail.com> <87v7ykvabp.fsf@neverwas.me> Date: Wed, 25 Sep 2024 07:54:30 +0300 Message-ID: <87plosuyd5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73443 Cc: emacs-erc@gnu.org, 73443@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I applied the patch and it's working on my end! Thanks J.P! From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 20:16:38 2024 Received: (at 73443-done) by debbugs.gnu.org; 1 Oct 2024 00:16:38 +0000 Received: from localhost ([127.0.0.1]:47938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svQZC-00020e-J3 for submit@debbugs.gnu.org; Mon, 30 Sep 2024 20:16:38 -0400 Received: from mail-108-mta38.mxroute.com ([136.175.108.38]:43367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svQZA-00020S-Gf for 73443-done@debbugs.gnu.org; Mon, 30 Sep 2024 20:16:37 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta38.mxroute.com (ZoneMTA) with ESMTPSA id 192456f0d6e0003e01.001 for <73443-done@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 01 Oct 2024 00:15:58 +0000 X-Zone-Loop: 1b1edf7eed08d4cdd5ec6d77a57b636b3e19b0ee665b X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+/Da99Xuz8I/eeTL7P5DTREq5MQPZviR537eR4YMViY=; b=b2d/z54okc8VrqN10GI/EfSVbF 6M0I05cGw+dMdG72/bmnomv3XfjLfeHnISdY6cev3zm1B7GKeaqclEJZChcA+4NysToPAUmkeAy0K fvBrMJvt/gkO2FVwALL/RsMckWftzRCK/O8ODzQI3eIKOjN6bZZNxQLsqknF5ExeX0nc4f0kZW8wq 5Hv+AHEtdFhSASqs7kBTlix7gFOUZ/RPnQNirJtH/WI2lE8WBf+ro77unmsK/YvKD5IbKxLmSwmEq fltYtNTsUvlLS/HSwe3jD3xRiiwW+HlUNBwp1yDIZC2RarX0n5OuVXvgrsGUhUE6E/yQlmNF12iCH L89ywyrQ==; From: "J.P." To: Trevor Arjeski Subject: Re: Fwd: bug#73443: 29.4; ERC 5.6.1-git: erc-track mode line face color broken with left timestamps In-Reply-To: <87plosuyd5.fsf@gmail.com> (Trevor Arjeski's message of "Wed, 25 Sep 2024 07:54:30 +0300") References: <87h6a63zmj.fsf@trevarch.mail-host-address-is-not-set> <87tte5zvzl.fsf@neverwas.me> <87r0998tqe.fsf@trevarch.mail-host-address-is-not-set> <871q19y1lz.fsf@neverwas.me> <87ed59o4nq.fsf@gmail.com> <87v7ykvabp.fsf@neverwas.me> <87plosuyd5.fsf@gmail.com> Date: Mon, 30 Sep 2024 17:15:55 -0700 Message-ID: <87wmisoeys.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73443-done Cc: emacs-erc@gnu.org, 73443-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Trevor Arjeski writes: > I applied the patch and it's working on my end! Thanks J.P! This has been installed as https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=df593b5a Thanks and closing. From unknown Mon Jun 16 23:21:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 29 Oct 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator