Subject: Re: [PATCH v5] gnu: libreoffice: Update to 24.8.3.2.

From: Ludovic Courtès <[email-masked]>
Date: Wed, 20 Nov 2024 13:13:43 +0100

Hi,

Nicolas Graves <[email-masked]> skribis:

> * gnu/packages/libreoffice.scm (libreoffice): Update to 24.8.3.2.
> [source]<uri>: Add secondary uri.
> [arguments]<#:phases>: Fix build issue related to issue 43579 in phase
> 'prepare-src.
> [configure-flags]: Add optimising flags --disable-cve-tests,
> --enable-readonly-installset, --disable-dependency-tracking.
> [native-inputs]: Add gcc-toolchain-12.
> [inputs]: Add argon2, zxcvbn-c.
>
> Change-Id: I72e0ebb4d075c47ea168b181f969a97f9249150a
> +              ;; https://issues.guix.gnu.org/43579
> +              (substitute* '("sal/rtl/math.cxx"
> +                               "sc/source/core/tool/math.cxx")
> +                  (("std::(fe[gs]etround|feclearexcept|fetestexcept)" all suffix)
> +                   suffix))

I doubt removing “std:” is necessary, is it?

> +              (let ((gcc-11-dir (dirname
> +                                 (dirname
> +                                  (dirname
> +                                   (search-input-directory
> +                                    inputs "share/doc/gcc-11.4.0"))))))

Or just (search-input-directory inputs "/include/c++") ?

That would be more consistent (and concise :-)) since this is about
setting CPLUS_INCLUDE_PATH.

Otherwise LGTM, thanks!

Ludo’.