GNU bug report logs - #73438
[PATCH] Better error message in checkStoreName

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73438: closed ([PATCH] Better error message in checkStoreName)
Date: Sun, 17 Nov 2024 21:46:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 17 Nov 2024 22:42:58 +0100
with message-id <87mshxiljx.fsf <at> gnu.org>
and subject line Re: [bug#73438] [PATCH] Better error message in checkStoreName
has caused the debbugs.gnu.org bug report #73438,
regarding [PATCH] Better error message in checkStoreName
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73438: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73438
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Brennan Vincent <brennan <at> umanwizard.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Better error message in checkStoreName
Date: Mon, 23 Sep 2024 07:21:07 -0400

When trying to pass a local-file beginning with a dot to something like
home-files-service-type, one gets an error message like:

guix home: error: invalid name: `.vimrc'

which does not explain what went wrong. This update should make it more clear.

Change-Id: I045a663bc6cd9844677c65b38a31d3941cf212b5
---
 nix/libstore/store-api.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nix/libstore/store-api.cc b/nix/libstore/store-api.cc
index 781fb9e693..38a1403a71 100644
--- a/nix/libstore/store-api.cc
+++ b/nix/libstore/store-api.cc
@@ -61,7 +61,7 @@ void checkStoreName(const string & name)
     /* Disallow names starting with a dot for possible security
        reasons (e.g., "." and ".."). */
     if (string(name, 0, 1) == ".")
-        throw Error(format("invalid name: `%1%'") % name);
+        throw Error(format("invalid name: `%1%' (can't begin with dot)") % name);
     foreach (string::const_iterator, i, name)
         if (!((*i >= 'A' && *i <= 'Z') ||
               (*i >= 'a' && *i <= 'z') ||

base-commit: 6ea75bb9bcc52521f0bb3f121799745fdc17f1c9
-- 
2.46.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brennan Vincent <brennan <at> umanwizard.com>
Cc: 73438-done <at> debbugs.gnu.org
Subject: Re: [bug#73438] [PATCH] Better error message in checkStoreName
Date: Sun, 17 Nov 2024 22:42:58 +0100

Brennan Vincent <brennan <at> umanwizard.com> skribis:

> When trying to pass a local-file beginning with a dot to something like
> home-files-service-type, one gets an error message like:
>
> guix home: error: invalid name: `.vimrc'
>
> which does not explain what went wrong. This update should make it more clear.
>
> Change-Id: I045a663bc6cd9844677c65b38a31d3941cf212b5

I tweaked the commit log to match our conventions and applied it,
thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.