From unknown Fri Jun 20 18:14:47 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#73438 <73438@debbugs.gnu.org> To: bug#73438 <73438@debbugs.gnu.org> Subject: Status: [PATCH] Better error message in checkStoreName Reply-To: bug#73438 <73438@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:14:47 +0000 retitle 73438 [PATCH] Better error message in checkStoreName reassign 73438 guix-patches submitter 73438 Brennan Vincent severity 73438 normal tag 73438 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 23 07:21:51 2024 Received: (at submit) by debbugs.gnu.org; 23 Sep 2024 11:21:51 +0000 Received: from localhost ([127.0.0.1]:43293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssh8Y-0007D6-V2 for submit@debbugs.gnu.org; Mon, 23 Sep 2024 07:21:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:54838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssh8X-0007Cy-0X for submit@debbugs.gnu.org; Mon, 23 Sep 2024 07:21:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssh88-0007sq-Ve for guix-patches@gnu.org; Mon, 23 Sep 2024 07:21:25 -0400 Received: from smtp.umanwizard.com ([54.203.248.109]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssh7z-0003zw-5L for guix-patches@gnu.org; Mon, 23 Sep 2024 07:21:23 -0400 Received: from localhost ([98.171.11.233]) by smtp.umanwizard.com ; 23 Sep 2024 11:21:09 +0000 X-Fes-Received-For: guix-patches@gnu.org X-Fes-Received-From: From: Brennan Vincent To: guix-patches@gnu.org Subject: [PATCH] Better error message in checkStoreName X-Envelope-From: b681f718b15b9b38e4d28a653bdf5f5ea974939a Mon Sep 17 00:00:00 2001 Date: Mon, 23 Sep 2024 07:21:07 -0400 Message-ID: <871q1ad3a4.fsf@denver.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain X-Fes-Encrypted: true X-Fes-Ehlo-Domain: localhost Received-SPF: pass client-ip=54.203.248.109; envelope-from=brennan@umanwizard.com; helo=smtp.umanwizard.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) When trying to pass a local-file beginning with a dot to something like home-files-service-type, one gets an error message like: guix home: error: invalid name: `.vimrc' which does not explain what went wrong. This update should make it more clear. Change-Id: I045a663bc6cd9844677c65b38a31d3941cf212b5 --- nix/libstore/store-api.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nix/libstore/store-api.cc b/nix/libstore/store-api.cc index 781fb9e693..38a1403a71 100644 --- a/nix/libstore/store-api.cc +++ b/nix/libstore/store-api.cc @@ -61,7 +61,7 @@ void checkStoreName(const string & name) /* Disallow names starting with a dot for possible security reasons (e.g., "." and ".."). */ if (string(name, 0, 1) == ".") - throw Error(format("invalid name: `%1%'") % name); + throw Error(format("invalid name: `%1%' (can't begin with dot)") % name); foreach (string::const_iterator, i, name) if (!((*i >= 'A' && *i <= 'Z') || (*i >= 'a' && *i <= 'z') || base-commit: 6ea75bb9bcc52521f0bb3f121799745fdc17f1c9 -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 16:45:20 2024 Received: (at 73438-done) by debbugs.gnu.org; 17 Nov 2024 21:45:20 +0000 Received: from localhost ([127.0.0.1]:58864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCn56-0000Et-1d for submit@debbugs.gnu.org; Sun, 17 Nov 2024 16:45:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCn52-0000Ea-M0 for 73438-done@debbugs.gnu.org; Sun, 17 Nov 2024 16:45:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCn2r-0007uT-UU; Sun, 17 Nov 2024 16:43:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=pNg15+oVMNYzfhROgsGFo8JEgv0yVUTCsDqUyb11yNQ=; b=rKTun+JMLgUYkCO1PCiV MYIlB/srW+Oe7+tPxW0pRRfKXRxaRWDw7/xQ35xHur+uRagg+j+qjtsqqbik37q0pi+rJHees+G3T nsuZ1N2vdhdPs5hQ85XudjNFrCb7qHND1PSpQ6jdsXp7DuJ96BJ7BduUoag3x2N/bQkuR5zSlBkCB pObn3G7Z9ecZ0BjbFpvXTqIJm+EnaWce0DNFvV61UtRUHU/oJrBnUkGbBblG37wi+IkJF0iWGjrSH n0EiwPytybkvO/XUgzcbSdkW5Fk2wO9g9UMRdVtdSjUD9tBZbpVNuyAMlFilK4o5TAee0oGpIEv8J rW1tScNAYUzN/w==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Brennan Vincent Subject: Re: [bug#73438] [PATCH] Better error message in checkStoreName In-Reply-To: <871q1ad3a4.fsf@denver.mail-host-address-is-not-set> (Brennan Vincent's message of "Mon, 23 Sep 2024 07:21:07 -0400") References: <871q1ad3a4.fsf@denver.mail-host-address-is-not-set> Date: Sun, 17 Nov 2024 22:42:58 +0100 Message-ID: <87mshxiljx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73438-done Cc: 73438-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Brennan Vincent skribis: > When trying to pass a local-file beginning with a dot to something like > home-files-service-type, one gets an error message like: > > guix home: error: invalid name: `.vimrc' > > which does not explain what went wrong. This update should make it more c= lear. > > Change-Id: I045a663bc6cd9844677c65b38a31d3941cf212b5 I tweaked the commit log to match our conventions and applied it, thanks! Ludo=E2=80=99. From unknown Fri Jun 20 18:14:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 16 Dec 2024 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator