GNU bug report logs - #73430
[PATCH] gnu: Add guile-taglib.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73430: closed ([PATCH] gnu: Add guile-taglib.)
Date: Sun, 17 Nov 2024 21:51:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 17 Nov 2024 22:49:56 +0100
with message-id <87ikslil8b.fsf <at> gnu.org>
and subject line Re: [bug#73430] [PATCH] gnu: Add guile-taglib.
has caused the debbugs.gnu.org bug report #73430,
regarding [PATCH] gnu: Add guile-taglib.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73430: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73430
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alec Barreto <mrh57 <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Alec Barreto <mrh57 <at> posteo.net>
Subject: [PATCH] gnu: Add guile-taglib.
Date: Sun, 22 Sep 2024 20:45:41 +0000

* gnu/packages/guile-xyz.scm (guile-taglib): New variable.

Change-Id: I68cb1945104b64f621c9e6a1689b63f66c59144e
---

This project has neither git tags nor releases, so I just filled in values of "0" for version and revision.
Do let me know if there's something else that would be better.

Separately, is there a reason why the =guile= package doesn't have "GUILE_EXTENSIONS_PATH" set in its =native-search-paths= field so that it can find foreign libs?
The "libtag_c.so" path has to be patched here (and similar patches exist in other guile packages).
Shouldn't the "lib" dir of the profile just be added to that guile path, rendering all these patches unnecessary?

Best,
Alec

 gnu/packages/guile-xyz.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 27a30e6622..b19fd443ea 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -104,6 +104,7 @@ (define-module (gnu packages guile-xyz)
   #:use-module (gnu packages man)
   #:use-module (gnu packages maths)
   #:use-module (gnu packages mes)
+  #:use-module (gnu packages mp3)
   #:use-module (gnu packages multiprecision)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages networking)
@@ -1052,6 +1053,40 @@ (define-public guile-swayer
 events in Guile.")
     (license license:expat)))
 
+(define-public guile-taglib
+  (let ((commit "c056ac9eb375459c53284aa20f35b0778cfa3cea")
+        (version "0")
+        (revision "0"))
+    (package
+      (name "guile-taglib")
+      (version (git-version version revision commit))
+      (home-page "https://github.com/sbarbit/guile-taglib")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/sbarbit/guile-taglib")
+               (commit commit)))
+         (sha256
+          (base32 "07z65hqxjm6rd9cdk2b9dcxj8hgz7c9dg4iprr19jrvj4ymzrbff"))))
+      (build-system guile-build-system)
+      (native-inputs (list guile-3.0))
+      (propagated-inputs (list taglib))
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'fix-taglib-path
+              (lambda* (#:key inputs #:allow-other-keys)
+                (substitute* "taglib.scm"
+                  (("libtag_c.so")
+                   (search-input-file inputs "/lib/libtag_c.so"))))))))
+      (synopsis "Guile bindings for the taglib library")
+      (description
+       "This package provides Guile bindings for the taglib C library.
+It can be used to access and modify metadata for audio files.")
+      (license license:gpl2+))))
+
 (define-public guile-syntax-highlight
   (package
     (name "guile-syntax-highlight")
-- 
2.46.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Alec Barreto <mrh57 <at> posteo.net>
Cc: 73430-done <at> debbugs.gnu.org
Subject: Re: [bug#73430] [PATCH] gnu: Add guile-taglib.
Date: Sun, 17 Nov 2024 22:49:56 +0100

[Message part 4 (text/plain, inline)]

Hi,

Alec Barreto <mrh57 <at> posteo.net> skribis:

> * gnu/packages/guile-xyz.scm (guile-taglib): New variable.
>
> Change-Id: I68cb1945104b64f621c9e6a1689b63f66c59144e

Applied with the change below.

> Separately, is there a reason why the =guile= package doesn't have "GUILE_EXTENSIONS_PATH" set in its =native-search-paths= field so that it can find foreign libs?

No good reason, it should probably have that.

> The "libtag_c.so" path has to be patched here (and similar patches exist in other guile packages).
> Shouldn't the "lib" dir of the profile just be added to that guile path, rendering all these patches unnecessary?

Hmm yes you’re right.  I’m used to specifying absolute file names, but
just setting ‘GUILE_EXTENSIONS_PATH’ would be equally good.

Thanks,
Ludo’.

[Message part 5 (text/x-patch, inline)]

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index c4d06e10f0..044a491259 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1077,6 +1077,7 @@ (define-public guile-taglib
          (uri (git-reference
                (url "https://github.com/sbarbit/guile-taglib")
                (commit commit)))
+         (file-name (git-file-name name version))
          (sha256
           (base32 "07z65hqxjm6rd9cdk2b9dcxj8hgz7c9dg4iprr19jrvj4ymzrbff"))))
       (build-system guile-build-system)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.