From unknown Sat Sep 06 09:27:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#73430] [PATCH] gnu: Add guile-taglib. Resent-From: Alec Barreto Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 Sep 2024 20:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73430 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73430@debbugs.gnu.org Cc: Alec Barreto X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17270386147119 (code B ref -1); Sun, 22 Sep 2024 20:57:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Sep 2024 20:56:54 +0000 Received: from localhost ([127.0.0.1]:42836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssTdW-0001qk-7b for submit@debbugs.gnu.org; Sun, 22 Sep 2024 16:56:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:49108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssTdU-0001qV-0X for submit@debbugs.gnu.org; Sun, 22 Sep 2024 16:56:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssTd7-0006gn-O1 for guix-patches@gnu.org; Sun, 22 Sep 2024 16:56:29 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssTd4-0007Y5-Py for guix-patches@gnu.org; Sun, 22 Sep 2024 16:56:29 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A9445240101 for ; Sun, 22 Sep 2024 22:56:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1727038578; bh=2rJq9Di3f5x9T8mdfzmXlaUW1RaH1h06ba5TH2ghaAw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=pyjI/fCfCyhNagm+UwvuaKmB9ZxEPEyS5WOGnwMBO6etCHFJTcoK6qs0254l9mrk2 c9o8hVbSYq1ay2mKNUfhRHfjLGWaLzp348RprIMEZCZxIPbTKg6jqZHGxBjLdTJrfv ZTnksbdAkOAMpzx+Sm2jOwSqfUPXFdHRahDr8LKmCnJ409D9b3eUSthPHpM+H+k9Eg VZ+M22UdC+VR7OH6LP5x/8EIj+HbDMOwvDoQFjwtJUmmHht7QP4GdNI4A1iR+bRC5L CtlbXrafxAfHcluA7Y6pM5KVy7rDbTZ2gQGk2dGi4wkO2FnRKmo7PoBU5bB9Y1vaf7 fSxDNlmUVfnWg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XBdhK4kPpz6txL; Sun, 22 Sep 2024 22:56:17 +0200 (CEST) From: Alec Barreto Date: Sun, 22 Sep 2024 20:45:41 +0000 Message-ID: <20240922205526.6959-2-mrh57@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=mrh57@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/guile-xyz.scm (guile-taglib): New variable. Change-Id: I68cb1945104b64f621c9e6a1689b63f66c59144e --- This project has neither git tags nor releases, so I just filled in values of "0" for version and revision. Do let me know if there's something else that would be better. Separately, is there a reason why the =guile= package doesn't have "GUILE_EXTENSIONS_PATH" set in its =native-search-paths= field so that it can find foreign libs? The "libtag_c.so" path has to be patched here (and similar patches exist in other guile packages). Shouldn't the "lib" dir of the profile just be added to that guile path, rendering all these patches unnecessary? Best, Alec gnu/packages/guile-xyz.scm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index 27a30e6622..b19fd443ea 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -104,6 +104,7 @@ (define-module (gnu packages guile-xyz) #:use-module (gnu packages man) #:use-module (gnu packages maths) #:use-module (gnu packages mes) + #:use-module (gnu packages mp3) #:use-module (gnu packages multiprecision) #:use-module (gnu packages ncurses) #:use-module (gnu packages networking) @@ -1052,6 +1053,40 @@ (define-public guile-swayer events in Guile.") (license license:expat))) +(define-public guile-taglib + (let ((commit "c056ac9eb375459c53284aa20f35b0778cfa3cea") + (version "0") + (revision "0")) + (package + (name "guile-taglib") + (version (git-version version revision commit)) + (home-page "https://github.com/sbarbit/guile-taglib") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/sbarbit/guile-taglib") + (commit commit))) + (sha256 + (base32 "07z65hqxjm6rd9cdk2b9dcxj8hgz7c9dg4iprr19jrvj4ymzrbff")))) + (build-system guile-build-system) + (native-inputs (list guile-3.0)) + (propagated-inputs (list taglib)) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'fix-taglib-path + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "taglib.scm" + (("libtag_c.so") + (search-input-file inputs "/lib/libtag_c.so")))))))) + (synopsis "Guile bindings for the taglib library") + (description + "This package provides Guile bindings for the taglib C library. +It can be used to access and modify metadata for audio files.") + (license license:gpl2+)))) + (define-public guile-syntax-highlight (package (name "guile-syntax-highlight") -- 2.46.0 From unknown Sat Sep 06 09:27:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Alec Barreto Subject: bug#73430: closed (Re: [bug#73430] [PATCH] gnu: Add guile-taglib.) Message-ID: References: <87ikslil8b.fsf@gnu.org> <20240922205526.6959-2-mrh57@posteo.net> X-Gnu-PR-Message: they-closed 73430 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 73430@debbugs.gnu.org Date: Sun, 17 Nov 2024 21:51:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1731880262-1971-1" This is a multi-part message in MIME format... ------------=_1731880262-1971-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #73430: [PATCH] gnu: Add guile-taglib. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 73430@debbugs.gnu.org. --=20 73430: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73430 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1731880262-1971-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 73430-done) by debbugs.gnu.org; 17 Nov 2024 21:50:08 +0000 Received: from localhost ([127.0.0.1]:58879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCn9k-0000Qf-1O for submit@debbugs.gnu.org; Sun, 17 Nov 2024 16:50:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCn9h-0000Ng-0k for 73430-done@debbugs.gnu.org; Sun, 17 Nov 2024 16:50:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCn9b-0000MB-1l; Sun, 17 Nov 2024 16:49:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=RQDpvNejVW/lWVtcmeP1XTdYLwHdgG/rImLxS8DeJ38=; b=Zq2h6e+nMlf96fL6mFQ1 ynkKJlq08/8mPXeN01eUmgL1LnFykRCJr9T67g0AmS98nV6vOwv78wCc8gnqxHfRz+N+vz/ihUdiW GE5HnCP7vfc5pM9vPE/PgQ3ag/MCSAgWvZ7fb3Wcqz9sSVl6SSAtuUHIVB6qrDPXHJdtvDGa7ox2a yX51ZrOHfyysaCgOJtWFUtmmCsUSNZNN2Oq7iMLKxDqmySLeN7S3AY4mNo0F+/6yjAnPtAsAreZEo ShEHaXtCIRBe9P6H1CkLNMd/SWvTUUJ29R4/dvTrq8lPgvaJkC+Ef4CQfxfML34rqJ4KN+CMWw1PO 7PBsiMP7Hy2NSg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Alec Barreto Subject: Re: [bug#73430] [PATCH] gnu: Add guile-taglib. In-Reply-To: <20240922205526.6959-2-mrh57@posteo.net> (Alec Barreto's message of "Sun, 22 Sep 2024 20:45:41 +0000") References: <20240922205526.6959-2-mrh57@posteo.net> Date: Sun, 17 Nov 2024 22:49:56 +0100 Message-ID: <87ikslil8b.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73430-done Cc: 73430-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Alec Barreto skribis: > * gnu/packages/guile-xyz.scm (guile-taglib): New variable. > > Change-Id: I68cb1945104b64f621c9e6a1689b63f66c59144e Applied with the change below. > Separately, is there a reason why the =3Dguile=3D package doesn't have "G= UILE_EXTENSIONS_PATH" set in its =3Dnative-search-paths=3D field so that it= can find foreign libs? No good reason, it should probably have that. > The "libtag_c.so" path has to be patched here (and similar patches exist = in other guile packages). > Shouldn't the "lib" dir of the profile just be added to that guile path, = rendering all these patches unnecessary? Hmm yes you=E2=80=99re right. I=E2=80=99m used to specifying absolute file= names, but just setting =E2=80=98GUILE_EXTENSIONS_PATH=E2=80=99 would be equally good. Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index c4d06e10f0..044a491259 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -1077,6 +1077,7 @@ (define-public guile-taglib (uri (git-reference (url "https://github.com/sbarbit/guile-taglib") (commit commit))) + (file-name (git-file-name name version)) (sha256 (base32 "07z65hqxjm6rd9cdk2b9dcxj8hgz7c9dg4iprr19jrvj4ymzrbff")))) (build-system guile-build-system) --=-=-=-- ------------=_1731880262-1971-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Sep 2024 20:56:54 +0000 Received: from localhost ([127.0.0.1]:42836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssTdW-0001qk-7b for submit@debbugs.gnu.org; Sun, 22 Sep 2024 16:56:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:49108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssTdU-0001qV-0X for submit@debbugs.gnu.org; Sun, 22 Sep 2024 16:56:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssTd7-0006gn-O1 for guix-patches@gnu.org; Sun, 22 Sep 2024 16:56:29 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssTd4-0007Y5-Py for guix-patches@gnu.org; Sun, 22 Sep 2024 16:56:29 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A9445240101 for ; Sun, 22 Sep 2024 22:56:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1727038578; bh=2rJq9Di3f5x9T8mdfzmXlaUW1RaH1h06ba5TH2ghaAw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=pyjI/fCfCyhNagm+UwvuaKmB9ZxEPEyS5WOGnwMBO6etCHFJTcoK6qs0254l9mrk2 c9o8hVbSYq1ay2mKNUfhRHfjLGWaLzp348RprIMEZCZxIPbTKg6jqZHGxBjLdTJrfv ZTnksbdAkOAMpzx+Sm2jOwSqfUPXFdHRahDr8LKmCnJ409D9b3eUSthPHpM+H+k9Eg VZ+M22UdC+VR7OH6LP5x/8EIj+HbDMOwvDoQFjwtJUmmHht7QP4GdNI4A1iR+bRC5L CtlbXrafxAfHcluA7Y6pM5KVy7rDbTZ2gQGk2dGi4wkO2FnRKmo7PoBU5bB9Y1vaf7 fSxDNlmUVfnWg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XBdhK4kPpz6txL; Sun, 22 Sep 2024 22:56:17 +0200 (CEST) From: Alec Barreto To: guix-patches@gnu.org Subject: [PATCH] gnu: Add guile-taglib. Date: Sun, 22 Sep 2024 20:45:41 +0000 Message-ID: <20240922205526.6959-2-mrh57@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=mrh57@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Alec Barreto X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/guile-xyz.scm (guile-taglib): New variable. Change-Id: I68cb1945104b64f621c9e6a1689b63f66c59144e --- This project has neither git tags nor releases, so I just filled in values of "0" for version and revision. Do let me know if there's something else that would be better. Separately, is there a reason why the =guile= package doesn't have "GUILE_EXTENSIONS_PATH" set in its =native-search-paths= field so that it can find foreign libs? The "libtag_c.so" path has to be patched here (and similar patches exist in other guile packages). Shouldn't the "lib" dir of the profile just be added to that guile path, rendering all these patches unnecessary? Best, Alec gnu/packages/guile-xyz.scm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index 27a30e6622..b19fd443ea 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -104,6 +104,7 @@ (define-module (gnu packages guile-xyz) #:use-module (gnu packages man) #:use-module (gnu packages maths) #:use-module (gnu packages mes) + #:use-module (gnu packages mp3) #:use-module (gnu packages multiprecision) #:use-module (gnu packages ncurses) #:use-module (gnu packages networking) @@ -1052,6 +1053,40 @@ (define-public guile-swayer events in Guile.") (license license:expat))) +(define-public guile-taglib + (let ((commit "c056ac9eb375459c53284aa20f35b0778cfa3cea") + (version "0") + (revision "0")) + (package + (name "guile-taglib") + (version (git-version version revision commit)) + (home-page "https://github.com/sbarbit/guile-taglib") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/sbarbit/guile-taglib") + (commit commit))) + (sha256 + (base32 "07z65hqxjm6rd9cdk2b9dcxj8hgz7c9dg4iprr19jrvj4ymzrbff")))) + (build-system guile-build-system) + (native-inputs (list guile-3.0)) + (propagated-inputs (list taglib)) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'fix-taglib-path + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "taglib.scm" + (("libtag_c.so") + (search-input-file inputs "/lib/libtag_c.so")))))))) + (synopsis "Guile bindings for the taglib library") + (description + "This package provides Guile bindings for the taglib C library. +It can be used to access and modify metadata for audio files.") + (license license:gpl2+)))) + (define-public guile-syntax-highlight (package (name "guile-syntax-highlight") -- 2.46.0 ------------=_1731880262-1971-1--