From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: Gian Domenico Bonazzoli Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 22 Sep 2024 07:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 73418@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172699015032030 (code B ref -1); Sun, 22 Sep 2024 07:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Sep 2024 07:29:10 +0000 Received: from localhost ([127.0.0.1]:40782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssH1q-0008KV-2t for submit@debbugs.gnu.org; Sun, 22 Sep 2024 03:29:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:37024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssFyz-0004f8-Cd for submit@debbugs.gnu.org; Sun, 22 Sep 2024 02:22:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssFyd-0001LB-UH for bug-coreutils@gnu.org; Sun, 22 Sep 2024 02:21:47 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ssFyb-0000dY-7n for bug-coreutils@gnu.org; Sun, 22 Sep 2024 02:21:47 -0400 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a8d64b27c45so589878566b.3 for ; Sat, 21 Sep 2024 23:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bonaz-it.20230601.gappssmtp.com; s=20230601; t=1726986101; x=1727590901; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=thfJ2HZFZfNRCp+50SYElcHsYgGWYIgLiEMxR0u0wRg=; b=fbo3VHrX+eki2/BrBYtmXG2PFI73oHZqFuZWJXrWnqAQ8JnbVZyg9NaDEWkKc2xN9A R2qkd1Y4Cn/2dsTaZb+ypiiqsRSCRBiHsyEvFk+AogF587i5tSeHqC4mRi8vk76AW8oT mDbH0PyUIrH5h4Ny5bOir2sv+OXXXwsIvNcjYCXAsRzvAKCh6qJ93rLNoVTfMntE6MJj nV53r1tKYW0mfkPAHv8mLknmhpDGKRRNjSb9MSzDc+clytdiPfLSbniOeYlAwaiAAcRm Ug5Bya+q3Bzl1zNIp20ijS1mlRwksASjrFq+CIJsr9Pqat3l+0GeITolcj4ZZEE4CfBC njcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726986101; x=1727590901; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=thfJ2HZFZfNRCp+50SYElcHsYgGWYIgLiEMxR0u0wRg=; b=WhGbOME+fjb5QKDfMEWhuCNmcUnZssXOic+J76o2gYtvFIHKKddoydaalFCF/sCAv7 mb4NlEhwKdvar9QREkv7Vh2xi48nPexBPZHmndTDKg1PHOsOEHn4l43s2QiQtf4soPlQ GTPcKZ5VHad10B5RjpFDn5IVP9cnGP5gsyHSgWmMSQL7EdPhOXf9/QC6bblEBS+kvu78 14pV20sKwuZkNFG4MpzQd2vQO1GtiHCHuobUqNlzIncfA3GVbIEcLdoX9pgmdyVS4qS8 M0el80M2hiYzGHKWOC8847a036NOB9wUp7wN16RLr4BVZxFbQSv0pZORdxZDJe9yi2zZ PFIg== X-Gm-Message-State: AOJu0YykVe2UC+59H+53WDoP7fh3nrR7JpXko1cLeuqehHGum3zm+egT LP7VznXTUqG8ZmgONcLgu/OnsgIQkjLWTx5iDTRz7LAYnDfuRaRpJLsk3JU6BYXe+Wvq8IPTSz5 0dVvywMPbwa86+LFP8cRkJqm3mLiE5Pi5yatp5KtfPDhOWEJNPxMGpA== X-Google-Smtp-Source: AGHT+IEHi4boD9rJzvwNbTmw6BIz3t6SR5EhM4fOgeR2bqNBPz5IyILpWa7FMLml/cHd1G57duM3k8iIIKWGCfj5IoM= X-Received: by 2002:a17:906:f5a9:b0:a8a:572c:709f with SMTP id a640c23a62f3a-a90d4fdf2ffmr793946366b.5.1726986101322; Sat, 21 Sep 2024 23:21:41 -0700 (PDT) MIME-Version: 1.0 From: Gian Domenico Bonazzoli Date: Sun, 22 Sep 2024 08:21:30 +0200 Message-ID: Content-Type: multipart/alternative; boundary="0000000000001a0fd70622af4953" Received-SPF: none client-ip=2a00:1450:4864:20::62d; envelope-from=gbonazzoli@bonaz.it; helo=mail-ej1-x62d.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, NUMERIC_HTTP_ADDR=1.242, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Mailman-Approved-At: Sun, 22 Sep 2024 03:29:08 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --0000000000001a0fd70622af4953 Content-Type: text/plain; charset="UTF-8" Hi all, During an upgrade from Ubuntu 22.04 to Ubuntu 24.04 we discovered that "ls (GNU coreutils) 9.4" is extremely slower than "ls (GNU coreutils) 8.32" listing files on a cifs mounted share. Facts to help you in troubleshooting the problem. In the same Ubuntu 24.04 machine I have the vanilla executable in /usr/bin/ls and a copy of Ubuntu 22.04 in /tmp/ls root@kube-node04:~# /usr/bin/ls --version ls (GNU coreutils) 9.4 root@kube-node04:~# /tmp/ls --version ls (GNU coreutils) 8.32 I have also a cifs share mounted by: //172.16.0.100/export /cifs/colom/export cifs vers=2.0,uid=50000,username=teledba,password=***** 0 1 This is what happens: root@kube-node04:~# time /tmp/ls -l /cifs/colom/export >/dev/null real 0m0.232s user 0m0.027s sys 0m0.027s root@kube-node04:~# time /usr/bin/ls -l /cifs/colom/export >/dev/null real 0m5.744s user 0m0.068s sys 0m0.349s So "ls -l" in 9.4 is 50 time slower then "ls -l" in 8.32 If I launch the ls command without the -l parameter the computing times are instead quite similar: root@kube-node04:~# time /tmp/ls /cifs/colom/export >/dev/null real 0m0.198s user 0m0.015s sys 0m0.021s root@kube-node04:~# time /usr/bin/ls /cifs/colom/export >/dev/null real 0m0.174s user 0m0.017s sys 0m0.016s looking at the strace output I saw that the new version is doing for each file processed the adjunctive call listxattr (in my case the directory contains 14500 files): ... statx(AT_FDCWD, "/cifs/colom/export/ARTP000.CSV", AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE, {stx_mask=STATX_TYPE|STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_CTIME|STATX_INO|STATX_SIZE|STATX_BLOCKS|STATX_BTIME|STATX_MNT_ID, stx_attributes=0, stx_mode=S_IFREG|0755, stx_size=840, ...}) = 0 listxattr("/cifs/colom/export/ARTP000.CSV", "", 152) = 0 ... maybe it is the root cause of the elapsed time when the ls command had the "-l" option fired ? Regards --0000000000001a0fd70622af4953 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi all,

During an upgrade from Ubuntu 2= 2.04 to Ubuntu 24.04 we discovered that "ls (GNU coreutils) 9.4" = is extremely slower than "ls (GNU coreutils) 8.32" listing files = on a cifs mounted share.

Facts to help you in trou= bleshooting the problem.

In the same Ubuntu 24.04 = machine I have the vanilla executable in /usr/bin/ls and a copy of Ubuntu 2= 2.04 in /tmp/ls

root@kube= -node04:~# /usr/bin/ls --version
ls (GNU coreutils) 9.4
=

root@kube-node04:~# /tmp/ls --= version
ls (GNU coreutils) 8.32

I ha= ve also a cifs share mounted by:

//172.16.0.100/export /c= ifs/colom/export cifs vers=3D2.0,uid=3D50000,username=3Dteledba,password=3D= ***** 0 1

This is what happens:

root@kube-node04:~# time /tmp/ls= -l =C2=A0/cifs/colom/export >/dev/null
real 0m0.232s
user 0m0.027= s
sys 0m0.027s


root@kube-node04:~# time /usr/bin/ls -l =C2=A0/cifs/colom/export >/d= ev/null
real 0m5.744s
user 0m0.068s
sys 0m0.349s
<= div>
So "ls -l" in 9.4 is 50 time slower then "= ;ls -l" in 8.32

If I launch=C2=A0the ls comma= nd without=C2=A0the -l parameter the computing times are instead quite simi= lar:

root@kube-node04:~# = time /tmp/ls =C2=A0/cifs/colom/export >/dev/null
real 0m0.198s
use= r 0m0.015s
sys 0m0.021s

ro= ot@kube-node04:~# time /usr/bin/ls =C2=A0/cifs/colom/export >/dev/nullreal 0m0.174s
user 0m0.017s
sys 0m0.016s

<= /div>
looking at the strace output I saw that the new version is doing = for each file processed the=C2=A0adjunctive=C2=A0call listxattr (in my case= the directory contains 14500 files):

...
statx(AT_FDCWD, "/cifs/colom/export/ARTP000.CSV", AT_STATX_SYNC= _AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, STATX_MODE|STATX_NLINK|STATX_= UID|STATX_GID|STATX_MTIME|STATX_SIZE, {stx_mask=3DSTATX_TYPE|STATX_MODE|STA= TX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_CTIME|STATX_INO|STATX_SIZE|S= TATX_BLOCKS|STATX_BTIME|STATX_MNT_ID, stx_attributes=3D0, stx_mode=3DS_IFRE= G|0755, stx_size=3D840, ...}) =3D 0
listxattr("/cifs/colom/export/A= RTP000.CSV", "", 152) =3D 0
...

=
maybe it is the root cause of the elapsed time when the ls comma= nd had the "-l" option fired ?

Regards







--0000000000001a0fd70622af4953-- From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 22 Sep 2024 09:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Gian Domenico Bonazzoli , 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172699822527432 (code B ref 73418); Sun, 22 Sep 2024 09:44:02 +0000 Received: (at 73418) by debbugs.gnu.org; 22 Sep 2024 09:43:45 +0000 Received: from localhost ([127.0.0.1]:40888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssJ85-00078O-84 for submit@debbugs.gnu.org; Sun, 22 Sep 2024 05:43:45 -0400 Received: from mail-ej1-f50.google.com ([209.85.218.50]:54378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssJ83-00078A-57 for 73418@debbugs.gnu.org; Sun, 22 Sep 2024 05:43:44 -0400 Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a8d43657255so536353066b.0 for <73418@debbugs.gnu.org>; Sun, 22 Sep 2024 02:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726998136; x=1727602936; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=j6RZB5656DjbqNIUwtZankZPkJMS+Sv10yb4f4b+0TE=; b=gGTxjtBJO4nAILy/g3/01EXTFW1E21rMhLX6G5kRjLBYlg9vvmVVul6LlNOPYyHjiv cLQCVzxPYze6+YUHsBp10Rj9BEmnqJZx4ZgsogNACP4VeTm90rABrvqKkyGt81h/8awc saymh6pLlEXkg5YRUysD0Bas0IwJCfnM0w62IahdP+WeFzR/L7dhh0BDqm/2YijeAd9m OkO4ofxJOmKOA+XsSBDIsg7L5YwggGLVbGqzidztq+odrPg4ojyMxEkS05phM4rq/f6I CyCLaVGoWVv2s/dmncjd85rYX5G8g/rsemCFm/k+7v7N0PDt4TqyLcS7J97QjCgoEqpL Futw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726998136; x=1727602936; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j6RZB5656DjbqNIUwtZankZPkJMS+Sv10yb4f4b+0TE=; b=NHz+DVwE6UhIqKwz2RyelK4jeIJ2znTl5uNl6AOr6UdFi0Dg4oJhwuJUjIEigGMno0 D9YKVSnLgj9dP6jDxWx9qQSw5fl47BuoS8FVSV2qrO9wADH4jQnKI+id4hwrHrMi3bTD s8ORQ8eYrBPrNIfI0mMiaxCokEe2K8jbrQ2gHVkhe1rGq9DsRUKn6rzXQsjWzvu6Ub8a kGp/QYPi+u246HnRpMhNJXCZEy4CVZlnP/aMmZ/pbfh1DyW1PhplS2TA296xsyhfi9II OcD3Ggn6YSx06BLbRUkeiL9flW+SAtfOoVBaFaiUsQH3Ug6o1zt0tfITczzcHQCe8Dad kaIw== X-Forwarded-Encrypted: i=1; AJvYcCUZUaLPkKPXZUYooO7YtN6GQ8MvNp1J7bnST5VZbGWWVz9elr7mEf1BrjsZRLZVvytwJSgJ6A==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwBBss99w7r4wnMkyT8gJ7wpJqFB50oHf1O19ZuqpCbl98F4AtG zw2A66u3qNmQy23wi80MT7itR9KXk0QYxVl8XUpAnOuz8U/soSXgqxVkiA== X-Google-Smtp-Source: AGHT+IH0bsTZkK34uQV5vo/ZGy1ZpDcVhWomzBe9shK356RwH+2EhX43i6UTl43BkK+dZeWeMtF7FA== X-Received: by 2002:a17:907:f783:b0:a90:419f:d8c3 with SMTP id a640c23a62f3a-a90d50d0b18mr816146966b.49.1726998135423; Sun, 22 Sep 2024 02:42:15 -0700 (PDT) Received: from [192.168.1.76] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a90612e519esm1078527166b.176.2024.09.22.02.42.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Sep 2024 02:42:14 -0700 (PDT) Message-ID: <076480fb-269d-486b-9bb8-7966c2adc9f9@draigBrady.com> Date: Sun, 22 Sep 2024 10:42:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta References: Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig?= Brady In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 22/09/2024 07:21, Gian Domenico Bonazzoli wrote: > Hi all, > > During an upgrade from Ubuntu 22.04 to Ubuntu 24.04 we discovered that "ls > (GNU coreutils) 9.4" is extremely slower than "ls (GNU coreutils) 8.32" > listing files on a cifs mounted share. > > Facts to help you in troubleshooting the problem. > > In the same Ubuntu 24.04 machine I have the vanilla executable in > /usr/bin/ls and a copy of Ubuntu 22.04 in /tmp/ls > > root@kube-node04:~# /usr/bin/ls --version > ls (GNU coreutils) 9.4 > > root@kube-node04:~# /tmp/ls --version > ls (GNU coreutils) 8.32 > > I have also a cifs share mounted by: > > //172.16.0.100/export /cifs/colom/export cifs > vers=2.0,uid=50000,username=teledba,password=***** 0 1 > > This is what happens: > > root@kube-node04:~# time /tmp/ls -l /cifs/colom/export >/dev/null > real 0m0.232s > user 0m0.027s > sys 0m0.027s > > > root@kube-node04:~# time /usr/bin/ls -l /cifs/colom/export >/dev/null > real 0m5.744s > user 0m0.068s > sys 0m0.349s > > So "ls -l" in 9.4 is 50 time slower then "ls -l" in 8.32 > > If I launch the ls command without the -l parameter the computing times are > instead quite similar: > > root@kube-node04:~# time /tmp/ls /cifs/colom/export >/dev/null > real 0m0.198s > user 0m0.015s > sys 0m0.021s > > root@kube-node04:~# time /usr/bin/ls /cifs/colom/export >/dev/null > real 0m0.174s > user 0m0.017s > sys 0m0.016s > > looking at the strace output I saw that the new version is doing for each > file processed the adjunctive call listxattr (in my case the directory > contains 14500 files): > > ... > statx(AT_FDCWD, "/cifs/colom/export/ARTP000.CSV", > AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, > STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE, > {stx_mask=STATX_TYPE|STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_CTIME|STATX_INO|STATX_SIZE|STATX_BLOCKS|STATX_BTIME|STATX_MNT_ID, > stx_attributes=0, stx_mode=S_IFREG|0755, stx_size=840, ...}) = 0 > listxattr("/cifs/colom/export/ARTP000.CSV", "", 152) = 0 > ... > > maybe it is the root cause of the elapsed time when the ls command had the > "-l" option fired ? > > Regards You listxattr() above doesn't seem to be returning an error, but perhaps this is another manifestation of https://bugs.gnu.org/68283 ? From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 30 Sep 2024 05:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Gian Domenico Bonazzoli Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172767392916898 (code B ref 73418); Mon, 30 Sep 2024 05:26:01 +0000 Received: (at 73418) by debbugs.gnu.org; 30 Sep 2024 05:25:29 +0000 Received: from localhost ([127.0.0.1]:44467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv8uW-0004OT-K2 for submit@debbugs.gnu.org; Mon, 30 Sep 2024 01:25:29 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:45920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv8uT-0004OJ-FW for 73418@debbugs.gnu.org; Mon, 30 Sep 2024 01:25:26 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id E9BC63C00FA87; Sun, 29 Sep 2024 22:24:46 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id wMIGCN58OeAK; Sun, 29 Sep 2024 22:24:46 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 4D8A03C00FA88; Sun, 29 Sep 2024 22:24:46 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 4D8A03C00FA88 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1727673886; bh=IUGiCY/W7G0C7wFp92uLCWpBIp1eIz+US6qGvrKaJO0=; h=Message-ID:Date:MIME-Version:To:From; b=YnmBLm+TagjDOuHJRFYSdjwCa2xQJhaTXwx6haPcdMqLbBkerk4HNo5sYnKgp8HVP T0460XM8wS9wzKiM6k/29T/ZNpZkctEZoyxJ/QQGn8pnxBrzGOeHNBOSfcgMCNvpYz TTrfEcQ9aBPKTk/ZFNwa4+/tPD7xcLLBwCYBeiGHYQh0V/cFQhDwTr3Xp4Go5rcTDO rxHQLjJcrFAgXwM+8E9txRMGiMx8c0z/sLsrM2bUVDFHCbYLUM1ptjEaN9BMDupcOR Yr52ADcQoUsgNM3S9Nz27b6KJAy9Tn3kmfFinr+z0vy9w0FTHgxQ8a7XtwW0vzpT6/ 8+IUJOGodwNPA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id 1Q0N-ekQGTD8; Sun, 29 Sep 2024 22:24:46 -0700 (PDT) Received: from [192.168.254.12] (unknown [47.150.137.250]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 2F2773C00FA87; Sun, 29 Sep 2024 22:24:46 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------H89EJVIALAtlHWRlPwHZH8lC" Message-ID: Date: Sun, 29 Sep 2024 22:24:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------H89EJVIALAtlHWRlPwHZH8lC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-09-21 23:21, Gian Domenico Bonazzoli wrote: > looking at the strace output I saw that the new version is doing for each > file processed the adjunctive call listxattr (in my case the directory > contains 14500 files): > > ... > statx(AT_FDCWD, "/cifs/colom/export/ARTP000.CSV", > AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, > STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE, > {stx_mask=STATX_TYPE|STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_CTIME|STATX_INO|STATX_SIZE|STATX_BLOCKS|STATX_BTIME|STATX_MNT_ID, > stx_attributes=0, stx_mode=S_IFREG|0755, stx_size=840, ...}) = 0 > listxattr("/cifs/colom/export/ARTP000.CSV", "", 152) = 0 > ... > > maybe it is the root cause of the elapsed time when the ls command had the > "-l" option fired ? What does "strace -r" report? That will tell us about elapsed time. What options are you using with your CIFS mount? The "mount" command can tell you that. What happens if you mount the CIFS file system with the nouser_xattr option? Can you disable extended attributes from the server side? E.g., if it's a Samba server configure with "ea support = no". If so, does that help? See, for example, . Looking at the current coreutils source, I noticed that 'ls' called getxattr when it didn't need to. I installed the attached patch to fix some of the issue; more could be done and perhaps I'll find the time. Among other things this patch should cause GNU ls to use llistxattr instead of listxattr which may make a difference. That being said, it does appear that CIFS is quite slow about getting extended attributes. (I wish Linux attributes weren't such a pain to deal with. Among other things, why aren't there any *at functions?) --------------H89EJVIALAtlHWRlPwHZH8lC Content-Type: text/x-patch; charset=UTF-8; name="0001-ls-use-fewer-xattr-related-syscalls.patch" Content-Disposition: attachment; filename="0001-ls-use-fewer-xattr-related-syscalls.patch" Content-Transfer-Encoding: base64 RnJvbSA0Y2U0MzJhZDg3MzgzODdmMWIyZTgwZTg4M2RjNzA4MGRmM2FmYWJlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTdW4sIDI5IFNlcCAyMDI0IDIyOjA0OjAyIC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gbHM6IHVzZSBmZXdlciB4YXR0ci1yZWxhdGVkIHN5c2NhbGxzCgoqIHNyYy9scy5jOiBE byBub3QgaW5jbHVkZSA8c2VsaW51eC9zZWxpbnV4Lmg+IG9yICJzbWFjay5oIi4KSW5jbHVk ZSA8bGludXgvYXR0ci5oPiBpZiBIQVZFX0xJTlVYX0FUVFJfSCwgZm9yIFhBVFRSX05BTUVf Q0FQUy4KKGZyZWVfZW50KTogVXNlIGFjbGluZm9fc2NvbnRleHRfZnJlZSB0byBmcmVlIGYt PnNjb250ZXh0LgooZ2V0ZmlsZWNvbl9jYWNoZSk6IFJlbW92ZTsgbm8gbG9uZ2VyIG5lZWRl ZC4KKGZpbGVfaGFzX2FjbGluZm9fY2FjaGUpOiBSZW5hbWUgZnJvbSBmaWxlX2hhc19hY2xf Y2FjaGUsCmFuZCB1c2UgZmlsZV9oYXNfYWNsaW5mbyBpbnN0ZWFkIG9mIGZpbGVfaGFzX2Fj bC4gIEFsbCB1c2VzIGNoYW5nZWQuCihnb2JibGVfZmlsZSk6IFVzZSBmaWxlX2hhc19hY2xp bmZvIGluc3RlYWQgb2YgZmlsZV9oYXNfYWNsLCBzbwp0aGF0IHdlIGdldCBtb3JlIGluZm8g YWJvdXQgdGhlIGZpbGUgYmVmb3JlIGRlY2lkaW5nIHdoZXRoZXIgdG8KaXNzdWUgZnVydGhl ciBzeXNjYWxscyBmb3IgaXQuICBMZXQgZmlsZV9oYXNfYWNsaW5mbyB3b3JyeSBhYm91dApz bWFjayBhbmQgU0VMaW51eC4gIENhbGwgaGFzX2NhcGFiaWxpdHkgb25seSBpZiB0aGUgeGF0 dHIgbGlzdAptZW50aW9ucyBYQVRUUl9OQU1FX0NBUFMuCi0tLQogc3JjL2xzLmMgfCAxMjMg KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDgzIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL3NyYy9scy5jIGIvc3JjL2xzLmMKaW5kZXggNDY1ZjM1ZDE5Li4wOTk4 OTNmODYgMTAwNjQ0Ci0tLSBhL3NyYy9scy5jCisrKyBiL3NyYy9scy5jCkBAIC01NSw3ICs1 NSw2IEBACiAjaW5jbHVkZSA8cHdkLmg+CiAjaW5jbHVkZSA8Z2V0b3B0Lmg+CiAjaW5jbHVk ZSA8c2lnbmFsLmg+Ci0jaW5jbHVkZSA8c2VsaW51eC9zZWxpbnV4Lmg+CiAjaW5jbHVkZSA8 dWNoYXIuaD4KIAogI2lmIEhBVkVfTEFOR0lORk9fQ09ERVNFVApAQCAtMTAxLDcgKzEwMCw2 IEBACiAjaW5jbHVkZSAibXBzb3J0LmgiCiAjaW5jbHVkZSAib2JzdGFjay5oIgogI2luY2x1 ZGUgInF1b3RlLmgiCi0jaW5jbHVkZSAic21hY2suaCIKICNpbmNsdWRlICJzdGF0LXNpemUu aCIKICNpbmNsdWRlICJzdGF0LXRpbWUuaCIKICNpbmNsdWRlICJzdHJmdGltZS5oIgpAQCAt MTIyLDYgKzEyMCwxMCBAQAogIyBpbmNsdWRlIDxzeXMvY2FwYWJpbGl0eS5oPgogI2VuZGlm CiAKKyNpZiBIQVZFX0xJTlVYX1hBVFRSX0gKKyMgaW5jbHVkZSA8bGludXgveGF0dHIuaD4K KyNlbmRpZgorCiAjZGVmaW5lIFBST0dSQU1fTkFNRSAobHNfbW9kZSA9PSBMU19MUyA/ICJs cyIgXAogICAgICAgICAgICAgICAgICAgICAgIDogKGxzX21vZGUgPT0gTFNfTVVMVElfQ09M IFwKICAgICAgICAgICAgICAgICAgICAgICAgICA/ICJkaXIiIDogInZkaXIiKSkKQEAgLTMy MzgsMTIgKzMyNDAsNyBAQCBmcmVlX2VudCAoc3RydWN0IGZpbGVpbmZvICpmKQogICBmcmVl IChmLT5saW5rbmFtZSk7CiAgIGZyZWUgKGYtPmFic29sdXRlX25hbWUpOwogICBpZiAoZi0+ c2NvbnRleHQgIT0gVU5LTk9XTl9TRUNVUklUWV9DT05URVhUKQotICAgIHsKLSAgICAgIGlm IChpc19zbWFja19lbmFibGVkICgpKQotICAgICAgICBmcmVlIChmLT5zY29udGV4dCk7Ci0g ICAgICBlbHNlCi0gICAgICAgIGZyZWVjb24gKGYtPnNjb250ZXh0KTsKLSAgICB9CisgICAg YWNsaW5mb19zY29udGV4dF9mcmVlIChmLT5zY29udGV4dCk7CiB9CiAKIC8qIEVtcHR5IHRo ZSB0YWJsZSBvZiBmaWxlcy4gICovCkBAIC0zMjcyLDQ4ICszMjY5LDE5IEBAIGNsZWFyX2Zp bGVzICh2b2lkKQogfQogCiAvKiBSZXR1cm4gdHJ1ZSBpZiBFUlIgaW1wbGllcyBsYWNrLW9m LXN1cHBvcnQgZmFpbHVyZSBieSBhCi0gICBnZXR4YXR0ci1jYWxsaW5nIGZ1bmN0aW9uIGxp a2UgZ2V0ZmlsZWNvbiBvciBmaWxlX2hhc19hY2wuICAqLworICAgZ2V0eGF0dHItY2FsbGlu ZyBmdW5jdGlvbiBsaWtlIGZpbGVfaGFzX2FjbC4gICovCiBzdGF0aWMgYm9vbAogZXJybm9f dW5zdXBwb3J0ZWQgKGludCBlcnIpCiB7CiAgIHJldHVybiAoZXJyID09IEVJTlZBTCB8fCBl cnIgPT0gRU5PU1lTIHx8IGlzX0VOT1RTVVAgKGVycikpOwogfQogCi0vKiBDYWNoZSAqZ2V0 ZmlsZWNvbiBmYWlsdXJlLCB3aGVuIGl0J3MgdHJpdmlhbCB0byBkbyBzby4KLSAgIExpa2Ug Z2V0ZmlsZWNvbi9sZ2V0ZmlsZWNvbiwgYnV0IHdoZW4gRidzIHN0X2RldiBzYXlzIGl0J3Mg ZG9lc24ndAotICAgc3VwcG9ydCBnZXR0aW5nIHRoZSBzZWN1cml0eSBjb250ZXh0LCBmYWls IHdpdGggRU5PVFNVUCBpbW1lZGlhdGVseS4gICovCi1zdGF0aWMgaW50Ci1nZXRmaWxlY29u X2NhY2hlIChjaGFyIGNvbnN0ICpmaWxlLCBzdHJ1Y3QgZmlsZWluZm8gKmYsIGJvb2wgZGVy ZWYpCi17Ci0gIC8qIHN0X2RldiBvZiB0aGUgbW9zdCByZWNlbnRseSBwcm9jZXNzZWQgZGV2 aWNlIGZvciB3aGljaCB3ZSd2ZQotICAgICBmb3VuZCB0aGF0IFtsXWdldGZpbGVjb24gZmFp bHMgaW5kaWNhdGluZyBsYWNrIG9mIHN1cHBvcnQuICAqLwotICBzdGF0aWMgZGV2X3QgdW5z dXBwb3J0ZWRfZGV2aWNlOwotCi0gIGlmIChmLT5zdGF0LnN0X2RldiA9PSB1bnN1cHBvcnRl ZF9kZXZpY2UpCi0gICAgewotICAgICAgZXJybm8gPSBFTk9UU1VQOwotICAgICAgcmV0dXJu IC0xOwotICAgIH0KLSAgaW50IHIgPSAwOwotI2lmZGVmIEhBVkVfU01BQ0sKLSAgaWYgKGlz X3NtYWNrX2VuYWJsZWQgKCkpCi0gICAgciA9IHNtYWNrX25ld19sYWJlbF9mcm9tX3BhdGgg KGZpbGUsICJzZWN1cml0eS5TTUFDSzY0IiwgZGVyZWYsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICZmLT5zY29udGV4dCk7Ci0gIGVsc2UKLSNlbmRpZgotICAgIHIg PSAoZGVyZWYKLSAgICAgICAgID8gZ2V0ZmlsZWNvbiAoZmlsZSwgJmYtPnNjb250ZXh0KQot ICAgICAgICAgOiBsZ2V0ZmlsZWNvbiAoZmlsZSwgJmYtPnNjb250ZXh0KSk7Ci0gIGlmIChy IDwgMCAmJiBlcnJub191bnN1cHBvcnRlZCAoZXJybm8pKQotICAgIHVuc3VwcG9ydGVkX2Rl dmljZSA9IGYtPnN0YXQuc3RfZGV2OwotICByZXR1cm4gcjsKLX0KLQotLyogQ2FjaGUgZmls ZV9oYXNfYWNsIGZhaWx1cmUsIHdoZW4gaXQncyB0cml2aWFsIHRvIGRvLgotICAgTGlrZSBm aWxlX2hhc19hY2wsIGJ1dCB3aGVuIEYncyBzdF9kZXYgc2F5cyBpdCdzIG9uIGEgZmlsZQor LyogQ2FjaGUgZmlsZV9oYXNfYWNsaW5mbyBmYWlsdXJlLCB3aGVuIGl0J3MgdHJpdmlhbCB0 byBkby4KKyAgIExpa2UgZmlsZV9oYXNfYWNsaW5mbywgYnV0IHdoZW4gRidzIHN0X2RldiBz YXlzIGl0J3Mgb24gYSBmaWxlCiAgICBzeXN0ZW0gbGFja2luZyBBQ0wgc3VwcG9ydCwgcmV0 dXJuIDAgd2l0aCBFTk9UU1VQIGltbWVkaWF0ZWx5LiAgKi8KIHN0YXRpYyBpbnQKLWZpbGVf aGFzX2FjbF9jYWNoZSAoY2hhciBjb25zdCAqZmlsZSwgc3RydWN0IGZpbGVpbmZvICpmKQor ZmlsZV9oYXNfYWNsaW5mb19jYWNoZSAoY2hhciBjb25zdCAqZmlsZSwgc3RydWN0IGZpbGVp bmZvICpmLAorICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGFjbGluZm8gKmFpLCBp bnQgZmxhZ3MpCiB7CiAgIC8qIHN0X2RldiBvZiB0aGUgbW9zdCByZWNlbnRseSBwcm9jZXNz ZWQgZGV2aWNlIGZvciB3aGljaCB3ZSd2ZQogICAgICBmb3VuZCB0aGF0IGZpbGVfaGFzX2Fj bCBmYWlscyBpbmRpY2F0aW5nIGxhY2sgb2Ygc3VwcG9ydC4gICovCkBAIC0zMzI1LDExICsz MjkzLDggQEAgZmlsZV9oYXNfYWNsX2NhY2hlIChjaGFyIGNvbnN0ICpmaWxlLCBzdHJ1Y3Qg ZmlsZWluZm8gKmYpCiAgICAgICByZXR1cm4gMDsKICAgICB9CiAKLSAgLyogWmVybyBlcnJu byBzbyB0aGF0IHdlIGNhbiBkaXN0aW5ndWlzaCBiZXR3ZWVuIHR3byAwLXJldHVybmluZyBj YXNlczoKLSAgICAgImhhcy1BQ0wtc3VwcG9ydCwgYnV0IG9ubHkgYSBkZWZhdWx0IEFDTCIg YW5kICJubyBBQ0wgc3VwcG9ydCIuICovCi0gIGVycm5vID0gMDsKLSAgaW50IG4gPSBmaWxl X2hhc19hY2wgKGZpbGUsICZmLT5zdGF0KTsKLSAgaWYgKG4gPD0gMCAmJiBlcnJub191bnN1 cHBvcnRlZCAoZXJybm8pKQorICBpbnQgbiA9IGZpbGVfaGFzX2FjbGluZm8gKGZpbGUsICZm LT5zdGF0LCBhaSwgZmxhZ3MpOworICBpZiAobiA8PSAwICYmIGVycm5vX3Vuc3VwcG9ydGVk IChhaS0+dS5lcnIpKQogICAgIHVuc3VwcG9ydGVkX2RldmljZSA9IGYtPnN0YXQuc3RfZGV2 OwogICByZXR1cm4gbjsKIH0KQEAgLTM1MTksNTMgKzM0ODQsNDUgQEAgZ29iYmxlX2ZpbGUg KGNoYXIgY29uc3QgKm5hbWUsIGVudW0gZmlsZXR5cGUgdHlwZSwgaW5vX3QgaW5vZGUsCiAK ICAgICAgIGYtPnN0YXRfb2sgPSB0cnVlOwogCi0gICAgICAvKiBOb3RlIGhhc19jYXBhYmls aXR5KCkgYWRkcyBhcm91bmQgMzAlIHJ1bnRpbWUgdG8gJ2xzIC0tY29sb3InICAqLwotICAg ICAgaWYgKCh0eXBlID09IG5vcm1hbCB8fCBTX0lTUkVHIChmLT5zdGF0LnN0X21vZGUpKQot ICAgICAgICAgICYmIHByaW50X3dpdGhfY29sb3IgJiYgaXNfY29sb3JlZCAoQ19DQVApKQot ICAgICAgICBmLT5oYXNfY2FwYWJpbGl0eSA9IGhhc19jYXBhYmlsaXR5X2NhY2hlIChmdWxs X25hbWUsIGYpOwotCiAgICAgICBpZiAoZm9ybWF0ID09IGxvbmdfZm9ybWF0IHx8IHByaW50 X3Njb250ZXh0KQogICAgICAgICB7Ci0gICAgICAgICAgYm9vbCBoYXZlX3Njb250ZXh0ID0g ZmFsc2U7Ci0gICAgICAgICAgYm9vbCBoYXZlX2FjbCA9IGZhbHNlOwotICAgICAgICAgIGlu dCBhdHRyX2xlbiA9IGdldGZpbGVjb25fY2FjaGUgKGZ1bGxfbmFtZSwgZiwgZG9fZGVyZWYp OwotICAgICAgICAgIGVyciA9IChhdHRyX2xlbiA8IDApOworICAgICAgICAgIHN0cnVjdCBh Y2xpbmZvIGFpOworICAgICAgICAgIGludCBuID0gZmlsZV9oYXNfYWNsaW5mb19jYWNoZSAo ZnVsbF9uYW1lLCBmLCAmYWksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBkb19kZXJlZiA/IEFDTF9TWU1MSU5LX0ZPTExPVyA6IDApOworICAgICAgICAg IGJvb2wgaGF2ZV9hY2wgPSAwIDwgbjsKKyAgICAgICAgICBib29sIGhhdmVfc2NvbnRleHQg PSAhYWkuc2NvbnRleHRfZXJyOworICAgICAgICAgIGYtPmFjbF90eXBlID0gKCFoYXZlX3Nj b250ZXh0ICYmICFoYXZlX2FjbAorICAgICAgICAgICAgICAgICAgICAgICAgID8gQUNMX1Rf Tk9ORQorICAgICAgICAgICAgICAgICAgICAgICAgIDogKGhhdmVfc2NvbnRleHQgJiYgIWhh dmVfYWNsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgPyBBQ0xfVF9MU01fQ09OVEVY VF9PTkxZCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiBBQ0xfVF9ZRVMpKTsKKyAg ICAgICAgICBhbnlfaGFzX2FjbCB8PSBmLT5hY2xfdHlwZSAhPSBBQ0xfVF9OT05FOwogCi0g ICAgICAgICAgaWYgKGVyciA9PSAwKQotICAgICAgICAgICAgewotICAgICAgICAgICAgICBp ZiAoaXNfc21hY2tfZW5hYmxlZCAoKSkKLSAgICAgICAgICAgICAgICBoYXZlX3Njb250ZXh0 ID0gISBTVFJFUSAoIl8iLCBmLT5zY29udGV4dCk7Ci0gICAgICAgICAgICAgIGVsc2UKLSAg ICAgICAgICAgICAgICBoYXZlX3Njb250ZXh0ID0gISBTVFJFUSAoInVubGFiZWxlZCIsIGYt PnNjb250ZXh0KTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICBpZiAoZm9ybWF0ID09IGxv bmdfZm9ybWF0ICYmIG4gPCAwKQorICAgICAgICAgICAgZXJyb3IgKDAsIGFpLnUuZXJyLCAi JXMiLCBxdW90ZWYgKGZ1bGxfbmFtZSkpOwogICAgICAgICAgIGVsc2UKICAgICAgICAgICAg IHsKLSAgICAgICAgICAgICAgZi0+c2NvbnRleHQgPSBVTktOT1dOX1NFQ1VSSVRZX0NPTlRF WFQ7Ci0KICAgICAgICAgICAgICAgLyogV2hlbiByZXF1ZXN0aW5nIHNlY3VyaXR5IGNvbnRl eHQgaW5mb3JtYXRpb24sIGRvbid0IG1ha2UKICAgICAgICAgICAgICAgICAgbHMgZmFpbCBq dXN0IGJlY2F1c2UgdGhlIGZpbGUgKGV2ZW4gYSBjb21tYW5kIGxpbmUgYXJndW1lbnQpCiAg ICAgICAgICAgICAgICAgIGlzbid0IG9uIHRoZSByaWdodCB0eXBlIG9mIGZpbGUgc3lzdGVt LiAgSS5lLiwgYSBnZXRmaWxlY29uCiAgICAgICAgICAgICAgICAgIGZhaWx1cmUgaXNuJ3Qg aW4gdGhlIHNhbWUgY2xhc3MgYXMgYSBzdGF0IGZhaWx1cmUuICAqLwotICAgICAgICAgICAg ICBpZiAoaXNfRU5PVFNVUCAoZXJybm8pIHx8IGVycm5vID09IEVOT0RBVEEpCi0gICAgICAg ICAgICAgICAgZXJyID0gMDsKKyAgICAgICAgICAgICAgaWYgKHByaW50X3Njb250ZXh0Cisg ICAgICAgICAgICAgICAgICAmJiAoISAoaXNfRU5PVFNVUCAoYWkuc2NvbnRleHRfZXJyKQor ICAgICAgICAgICAgICAgICAgICAgICAgIHx8IGFpLnNjb250ZXh0X2VyciA9PSBFTk9EQVRB KSkpCisgICAgICAgICAgICAgICAgZXJyb3IgKDAsIGFpLnNjb250ZXh0X2VyciwgIiVzIiwg cXVvdGVmIChmdWxsX25hbWUpKTsKICAgICAgICAgICAgIH0KIAotICAgICAgICAgIGlmIChl cnIgPT0gMCAmJiBmb3JtYXQgPT0gbG9uZ19mb3JtYXQpCi0gICAgICAgICAgICB7Ci0gICAg ICAgICAgICAgIGludCBuID0gZmlsZV9oYXNfYWNsX2NhY2hlIChmdWxsX25hbWUsIGYpOwot ICAgICAgICAgICAgICBlcnIgPSAobiA8IDApOwotICAgICAgICAgICAgICBoYXZlX2FjbCA9 ICgwIDwgbik7Ci0gICAgICAgICAgICB9Ci0KLSAgICAgICAgICBmLT5hY2xfdHlwZSA9ICgh aGF2ZV9zY29udGV4dCAmJiAhaGF2ZV9hY2wKLSAgICAgICAgICAgICAgICAgICAgICAgICA/ IEFDTF9UX05PTkUKLSAgICAgICAgICAgICAgICAgICAgICAgICA6IChoYXZlX3Njb250ZXh0 ICYmICFoYXZlX2FjbAotICAgICAgICAgICAgICAgICAgICAgICAgICAgID8gQUNMX1RfTFNN X0NPTlRFWFRfT05MWQotICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogQUNMX1RfWUVT KSk7Ci0gICAgICAgICAgYW55X2hhc19hY2wgfD0gZi0+YWNsX3R5cGUgIT0gQUNMX1RfTk9O RTsKLQotICAgICAgICAgIGlmIChlcnIpCi0gICAgICAgICAgICBlcnJvciAoMCwgZXJybm8s ICIlcyIsIHF1b3RlZiAoZnVsbF9uYW1lKSk7CisgICAgICAgICAgLyogaGFzX2NhcGFiaWxp dHkgYWRkcyBhcm91bmQgMzAlIHJ1bnRpbWUgdG8gJ2xzIC0tY29sb3InLAorICAgICAgICAg ICAgIHNvIGNhbGwgaXQgb25seSBpZiByZWFsbHkgbmVlZGVkLiAgKi8KKyAgICAgICAgICBp ZiAoMCA8IGFpLnNpemUKKyAgICAgICAgICAgICAgJiYgKHR5cGUgPT0gbm9ybWFsIHx8IFNf SVNSRUcgKGYtPnN0YXQuc3RfbW9kZSkpCisgICAgICAgICAgICAgICYmIHByaW50X3dpdGhf Y29sb3IgJiYgaXNfY29sb3JlZCAoQ19DQVApCisgICAgICAgICAgICAgICYmIGFjbGluZm9f aGFzX3hhdHRyICgmYWksIFhBVFRSX05BTUVfQ0FQUykpCisgICAgICAgICAgICBmLT5oYXNf Y2FwYWJpbGl0eSA9IGhhc19jYXBhYmlsaXR5X2NhY2hlIChmdWxsX25hbWUsIGYpOworCisg ICAgICAgICAgZi0+c2NvbnRleHQgPSBhaS5zY29udGV4dDsKKyAgICAgICAgICBhaS5zY29u dGV4dCA9IG51bGxwdHI7CisgICAgICAgICAgYWNsaW5mb19mcmVlICgmYWkpOwogICAgICAg ICB9CiAKICAgICAgIGlmIChTX0lTTE5LIChmLT5zdGF0LnN0X21vZGUpCi0tIAoyLjQzLjAK Cg== --------------H89EJVIALAtlHWRlPwHZH8lC-- From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: Gian Domenico Bonazzoli Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 30 Sep 2024 07:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172768133723531 (code B ref 73418); Mon, 30 Sep 2024 07:29:01 +0000 Received: (at 73418) by debbugs.gnu.org; 30 Sep 2024 07:28:57 +0000 Received: from localhost ([127.0.0.1]:44568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svAps-00067B-1p for submit@debbugs.gnu.org; Mon, 30 Sep 2024 03:28:57 -0400 Received: from mail-ej1-f51.google.com ([209.85.218.51]:51262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svAip-0005pH-Qs for 73418@debbugs.gnu.org; Mon, 30 Sep 2024 03:21:46 -0400 Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a7a843bef98so571299766b.2 for <73418@debbugs.gnu.org>; Mon, 30 Sep 2024 00:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bonaz-it.20230601.gappssmtp.com; s=20230601; t=1727680786; x=1728285586; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ROZzPoAt6584v5t0Rf9hd/gxNFD0nZv4DevoU+EF2P4=; b=mL6DuEEAtZPXJW8CVr9cTH1b6CEgl7VwkPMo2d3cpGT3B7iMAp6FIlOzhonk6+hv+/ LjwG2Z17qwbkzvHD7G7XPfQnK56JQhe25Gu2+TFemvr1/gl14qP8NPxerWfVE36zZaWI TgPt7aNJzh9J8MMsAMkHQcdo1mgHhBdsS4AWU5iSLyJ+aFeMPZ4kZBbDdZ0QIavZfZuo kc2AGJKr6+YpwRO4qAz6jJHvqQ7m6bbfWpZYUp2FUvJsv1rxWbRV6XMMgXuYjjmk9CHS LeK1UVWNmDfmbglfm1mtc/xCgOF+3QRo9kuHcrhYrks3MleHXPWHb1Cqo8JarySyF472 TzxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727680786; x=1728285586; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ROZzPoAt6584v5t0Rf9hd/gxNFD0nZv4DevoU+EF2P4=; b=g672or6WDzhVQCC0JWc4cQpawVCdTvKlDkpml2nBgpdAH6SpbXlidKXcxOQVkymAsy zc1N7FDDIB/PW/b/xVc61Df9olJHKY8E52w4pv6uV7m3/KCqJPmz04FHN1a+zpi4axpT n1iBoQpCSsneU9pz0bgsrsT7SwZilrqpRaSyp8F6PDvmtkPyyKExPbSGocPgCdrJH31Y dgx5yTHxhmvJ5R4WhTVqzsh7I6Zwc04yZKTXuz8Vaj6xlIMLTuDr3xbMORb3XWbGJmby wLjrF8++R3eAXuS2io0tM1YLK84n7e7LQsuxdmhlRx6m2yfXv72Zn2hZtOTl1lGIpd13 kyYA== X-Gm-Message-State: AOJu0YzuEqllJf0JS7xt5hrCcgynC63B7hA+Gu9PoBcEKNrJ1G7Y27qe VIIU//IONrTox+t5a7G88b3YAFTVDGctA97TLG7LdcX+N0x9lL/TfSASkd1qmfoQ7byuLchVNI1 /RHj04eOYAsKKy1E5xQpA/Joq5cjIaHLS4TfRdeQQZEtJeT4bLTirhQ== X-Google-Smtp-Source: AGHT+IFWIXFvFc505kfRUfE5DOIZ1bieQcr2Fwbg+4MB9d6tEHBx9GC6cZjD75riGooPSh2/ROsu+LBwkcrxnkmtCDE= X-Received: by 2002:a17:907:7295:b0:a8d:3338:a48c with SMTP id a640c23a62f3a-a93c48f0ad5mr1400600766b.7.1727680785804; Mon, 30 Sep 2024 00:19:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Gian Domenico Bonazzoli Date: Mon, 30 Sep 2024 09:19:34 +0200 Message-ID: Content-Type: multipart/alternative; boundary="000000000000860cf90623510756" X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Mon, 30 Sep 2024 03:28:31 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000860cf90623510756 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Paul: These are the mount options on Ubuntu 24.04: //172.16.0.100/export on /cifs/colom/export type cifs (rw,relatime,vers=3D2.0,cache=3Dstrict,username=3Dteledba,uid=3D50000,force= uid,gid=3D0,noforcegid,addr=3D172.16.0.100,file_mode=3D0755,dir_mode=3D0755= ,soft,nounix,mapposix,rsize=3D65536,wsize=3D65536,bsize=3D1048576,retrans= =3D1,echo_interval=3D60,actimeo=3D1,closetimeo=3D1) instead on Ubuntu 22.04: //172.20.150.103/External on /cifs/colom/export type cifs (rw,relatime,vers=3D1.0,cache=3Dstrict,username=3Dteledba,domain=3DWORKGROU= P,uid=3D50000,forceuid,gid=3D0,noforcegid,addr=3D172.20.150.103,file_mode= =3D0755,dir_mode=3D0755,soft,nounix,mapposix,rsize=3D61440,wsize=3D4096,bsi= ze=3D1048576,retrans=3D1,echo_interval=3D60,actimeo=3D1,closetimeo=3D1) mentre lo strace -r shows: 0.000105 listxattr("/cifs/colom/export/M606219.CSV", "", 152) =3D 0 0.000630 statx(AT_FDCWD, "/cifs/colom/export/M606220.CSV", AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE, {stx_mask=3DSTATX_TYPE|STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTI= ME|STATX_CTIME|STATX_INO|STATX_SIZE|STATX_BLOCKS|STATX_BTIME|STATX_MNT_ID, stx_attributes=3D0, stx_mode=3DS_IFREG|0755, stx_size=3D4992, ...}) =3D 0 0.000077 listxattr("/cifs/colom/export/M606220.CSV", "", 152) =3D 0 0.000464 statx(AT_FDCWD, "/cifs/colom/export/M606221.CSV", AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE, {stx_mask=3DSTATX_TYPE|STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTI= ME|STATX_CTIME|STATX_INO|STATX_SIZE|STATX_BLOCKS|STATX_BTIME|STATX_MNT_ID, stx_attributes=3D0, stx_mode=3DS_IFREG|0755, stx_size=3D0, ...}) =3D 0 0.000076 listxattr("/cifs/colom/export/M606221.CSV", "", 152) =3D 0 0.000542 statx(AT_FDCWD, "/cifs/colom/export/M606222.CSV", AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE, {stx_mask=3DSTATX_TYPE|STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTI= ME|STATX_CTIME|STATX_INO|STATX_SIZE|STATX_BLOCKS|STATX_BTIME|STATX_MNT_ID, stx_attributes=3D0, stx_mode=3DS_IFREG|0755, stx_size=3D0, ...}) =3D 0 Sorry but I can't change anything on the cifs server side, it is a closed system (IBM AS/400) On Mon, Sep 30, 2024 at 7:24=E2=80=AFAM Paul Eggert wr= ote: > On 2024-09-21 23:21, Gian Domenico Bonazzoli wrote: > > looking at the strace output I saw that the new version is doing for ea= ch > > file processed the adjunctive call listxattr (in my case the directory > > contains 14500 files): > > > > ... > > statx(AT_FDCWD, "/cifs/colom/export/ARTP000.CSV", > > AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, > > STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE, > > > {stx_mask=3DSTATX_TYPE|STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_M= TIME|STATX_CTIME|STATX_INO|STATX_SIZE|STATX_BLOCKS|STATX_BTIME|STATX_MNT_ID= , > > stx_attributes=3D0, stx_mode=3DS_IFREG|0755, stx_size=3D840, ...}) =3D = 0 > > listxattr("/cifs/colom/export/ARTP000.CSV", "", 152) =3D 0 > > ... > > > > maybe it is the root cause of the elapsed time when the ls command had > the > > "-l" option fired ? > > What does "strace -r" report? That will tell us about elapsed time. > > What options are you using with your CIFS mount? The "mount" command can > tell you that. > > What happens if you mount the CIFS file system with the nouser_xattr > option? > > Can you disable extended attributes from the server side? E.g., if it's > a Samba server configure with "ea support =3D no". If so, does that help? > See, for example, > < > https://www.truenas.com/community/threads/cifs-directory-browsing-slow-tr= y-this.27751/ > >. > > Looking at the current coreutils source, I noticed that 'ls' called > getxattr when it didn't need to. I installed the attached patch to fix > some of the issue; more could be done and perhaps I'll find the time. > Among other things this patch should cause GNU ls to use llistxattr > instead of listxattr which may make a difference. > > That being said, it does appear that CIFS is quite slow about getting > extended attributes. > > (I wish Linux attributes weren't such a pain to deal with. Among other > things, why aren't there any *at functions?) --000000000000860cf90623510756 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Paul:

These are the mount options on= Ubuntu 24.04:

//172.16.0.100/export on /cifs/colom/export type cifs (rw,relatime,= vers=3D2.0,cache=3Dstrict,username=3Dteledba,uid=3D50000,forceuid,gid=3D0,n= oforcegid,addr=3D172.16.0.100,file_mode=3D0755,dir_mode=3D0755,soft,nounix,= mapposix,rsize=3D65536,wsize=3D65536,bsize=3D1048576,retrans=3D1,echo_inter= val=3D60,actimeo=3D1,closetimeo=3D1)

instead o= n Ubuntu 22.04:

//172.20.150.103/External on /cifs/colom/export type cifs (rw,= relatime,vers=3D1.0,cache=3Dstrict,username=3Dteledba,domain=3DWORKGROUP,ui= d=3D50000,forceuid,gid=3D0,noforcegid,addr=3D172.20.150.103,file_mode=3D075= 5,dir_mode=3D0755,soft,nounix,mapposix,rsize=3D61440,wsize=3D4096,bsize=3D1= 048576,retrans=3D1,echo_interval=3D60,actimeo=3D1,closetimeo=3D1)
=

mentre lo strace -r shows:

=C2= =A0 =C2=A0 =C2=A00.000105 listxattr("/cifs/colom/export/M606219.CSV&qu= ot;, "", 152) =3D 0
=C2=A0 =C2=A0 =C2=A00.000630 statx(AT_FDCW= D, "/cifs/colom/export/M606220.CSV", AT_STATX_SYNC_AS_STAT|AT_SYM= LINK_NOFOLLOW|AT_NO_AUTOMOUNT, STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|S= TATX_MTIME|STATX_SIZE, {stx_mask=3DSTATX_TYPE|STATX_MODE|STATX_NLINK|STATX_= UID|STATX_GID|STATX_MTIME|STATX_CTIME|STATX_INO|STATX_SIZE|STATX_BLOCKS|STA= TX_BTIME|STATX_MNT_ID, stx_attributes=3D0, stx_mode=3DS_IFREG|0755, stx_siz= e=3D4992, ...}) =3D 0
=C2=A0 =C2=A0 =C2=A00.000077 listxattr("/cifs= /colom/export/M606220.CSV", "", 152) =3D 0
=C2=A0 =C2=A0 = =C2=A00.000464 statx(AT_FDCWD, "/cifs/colom/export/M606221.CSV", = AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, STATX_MODE|STATX= _NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE, {stx_mask=3DSTATX_TYPE|S= TATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_CTIME|STATX_INO= |STATX_SIZE|STATX_BLOCKS|STATX_BTIME|STATX_MNT_ID, stx_attributes=3D0, stx_= mode=3DS_IFREG|0755, stx_size=3D0, ...}) =3D 0
=C2=A0 =C2=A0 =C2=A00.000= 076 listxattr("/cifs/colom/export/M606221.CSV", "", 152= ) =3D 0
=C2=A0 =C2=A0 =C2=A00.000542 statx(AT_FDCWD, "/cifs/colom/e= xport/M606222.CSV", AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AU= TOMOUNT, STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE,= {stx_mask=3DSTATX_TYPE|STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MT= IME|STATX_CTIME|STATX_INO|STATX_SIZE|STATX_BLOCKS|STATX_BTIME|STATX_MNT_ID,= stx_attributes=3D0, stx_mode=3DS_IFREG|0755, stx_size=3D0, ...}) =3D 0
=


Sorry but I can't change anyth= ing on the cifs server side, it is a closed system (IBM AS/400)
<= br>

On Mon, Sep 30, 2024 at 7:24=E2=80=AFAM Paul Eggert <eggert@cs.ucla.edu> wrote:
On 2024-09-21 23:21, Gian Dom= enico Bonazzoli wrote:
> looking at the strace output I saw that the new version is doing for e= ach
> file processed the adjunctive call listxattr (in my case the directory=
> contains 14500 files):
>
> ...
> statx(AT_FDCWD, "/cifs/colom/export/ARTP000.CSV",
> AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT,
> STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE,
> {stx_mask=3DSTATX_TYPE|STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STAT= X_MTIME|STATX_CTIME|STATX_INO|STATX_SIZE|STATX_BLOCKS|STATX_BTIME|STATX_MNT= _ID,
> stx_attributes=3D0, stx_mode=3DS_IFREG|0755, stx_size=3D840, ...}) =3D= 0
> listxattr("/cifs/colom/export/ARTP000.CSV", "", 15= 2) =3D 0
> ...
>
> maybe it is the root cause of the elapsed time when the ls command had= the
> "-l" option fired ?

What does "strace -r" report? That will tell us about elapsed tim= e.

What options are you using with your CIFS mount? The "mount" comm= and can
tell you that.

What happens if you mount the CIFS file system with the nouser_xattr option= ?

Can you disable extended attributes from the server side? E.g., if it's=
a Samba server configure with "ea support =3D no". If so, does th= at help?
See, for example,
<https://ww= w.truenas.com/community/threads/cifs-directory-browsing-slow-try-this.27751= />.

Looking at the current coreutils source, I noticed that 'ls' called=
getxattr when it didn't need to. I installed the attached patch to fix =
some of the issue; more could be done and perhaps I'll find the time. <= br> Among other things this patch should cause GNU ls to use llistxattr
instead of listxattr which may make a difference.

That being said, it does appear that CIFS is quite slow about getting
extended attributes.

(I wish Linux attributes weren't such a pain to deal with. Among other =
things, why aren't there any *at functions?)
--000000000000860cf90623510756-- From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 30 Sep 2024 08:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert , Gian Domenico Bonazzoli Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172768489510883 (code B ref 73418); Mon, 30 Sep 2024 08:29:02 +0000 Received: (at 73418) by debbugs.gnu.org; 30 Sep 2024 08:28:15 +0000 Received: from localhost ([127.0.0.1]:44675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svBlJ-0002oc-QX for submit@debbugs.gnu.org; Mon, 30 Sep 2024 04:28:15 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:45847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svBlG-0002nE-TP for 73418@debbugs.gnu.org; Mon, 30 Sep 2024 04:28:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bernhard-voelker.de; s=s1-ionos; t=1727684832; x=1728289632; i=mail@bernhard-voelker.de; bh=2LuTMRHT13PmLZwHcb65I3xx33Srg/DOqkyEcqULNEU=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=u18S+l0mn7Cuje+CVCAQ6Rm/FJj7XHfvihWrSXPemxiyd6uGwkqT8+OCO2/x91za qHMrztNSdhhtpyeqtUzudSvUSKkdfZi8rC5xGIIEtA0rGGThBE/gs/uaTSvASixcL 8uOjZeF0ngiLqnhkm25c7tfid3pwxK5u7CiNJ8INNKVRl+lI6ITgEgjv6z9h89twj Vkxf5eOt8Y13cNFPAoYHMN1Fq5QgpNaSlBvQ7OYI/V6sV/9rums3pfe4NmIC6Ozs7 zy7C3rAidumEFgdpOwLxjCbKEoRqe20x30zoM+Hg+qvTfhbYnDrA4BOl5aC7YJB7m U7YhHojOZyhVqsVamg== X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from [10.0.2.15] ([62.169.80.18]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MGQf5-1shA3O2APN-00Dp5t; Mon, 30 Sep 2024 10:27:11 +0200 Message-ID: <57189234-b3c9-46ca-ae1e-1f31c0188767@bernhard-voelker.de> Date: Mon, 30 Sep 2024 10:26:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: Content-Language: en-US From: Bernhard Voelker In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:pqtFG8dXLpv13tMCubWErhmic1C0kBBxJbjy/FTvz5qnuIdVYSk xXZtOwMxOAYHpUio5O0iFKWbvcRwinrki74f3rPdG+WdiFeXLRbAB5eifg87zdzQESW53B2 F7M3Z59sK40zi5JOcTiKHayuvtk+YErq4BgYPsJTFBp6T5Y4m3nYRrUdfT557m4QJOexfVF PcSY+6KpXP+/U7lhmWCgA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:n6ehXk549yI=;OsWEHkEKlu13e60Yi6zqcvNSeAD kOaDUxiSbmL9LZ5TVpWdGoRX3ZCdqf1wuBQgag+lJ3E4EJ/krp3Fl2oqdLvD0ug6adxMzLqSv ZJaIwvsXTzDhLKfRMTMiAzb8Zgd6DA5fkKuQBgkNHYTPxRhp6PH7MsCFkv4kSeIQTgF5LxRqc aQDr5UhTTxWISErZaDhCttSmKwFfGR82D9dZcBsg0vOULOKGiH7bnh6MFUABPZnGRZtnN9Y1P CZb4zKfqWgnGTVcIflRIS2FOlTeRpv4Yphwq6ehGQz2/VHE/3E9dfLvO+D8T5OfP92mRZB2ea fqPcb4tYAF5DESc+Fp2JtyWz0DKl8dhmzHW4qZ5Z5xUCdCtuX56DfbDBsjzRX4xA7uI91juIG O8sLrM39zvyLZC60X676YXLRAG9+Bela7WEHTJmhuMP2akcIFkcK1UY6EXZoX3wSgwQJzt6BX 8yV6lZUJMxUJ3+eC/D8LN91DEAO9Y+4Sbzy9x6yXHLgD65Aps+2pnLyNBdVjOMFwfww78zCaD RH28pSlG6HPOxvfIy8+LST+maj5p2fz2LUfzpNyz3DhYXjHqOt4809Xs1FoKWufUqyGeBwwk2 6c8xD4piNVYH3Ayg2emE8oNy6nlwMZhaGMQibHrZ3TiEGdKzz8JU3WegBmv/zwr/YH7TCyxCo 2a39AFw8IDm5C5cHQ44yE3VxH63cHmm8W2QklzRTsx1OaZWMK8pH8M5OvayXx0+C+WmaTKFqI vb6pNjSQ8Q8MdNMCZDIAOKB7XOijKwfXQ== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 9/30/24 7:24 AM, Paul Eggert wrote: > I installed the attached patch to fix some of the issue There's a new syntax-check failure for a require_root_ test here: FAIL: tests/ls/capability =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D ++ initial_cwd_=3D/home/berny/git/coreutils +++ testdir_prefix_ +++ printf gt ++ pfx_=3Dgt +++ mktempd_ /home/berny/git/coreutils gt-capability.sh.XXXX +++ case $# in +++ destdir_=3D/home/berny/git/coreutils +++ template_=3Dgt-capability.sh.XXXX +++ MAX_TRIES_=3D4 +++ case $destdir_ in +++ destdir_slash_=3D/home/berny/git/coreutils/ +++ case $template_ in ++++ unset TMPDIR +++ d=3D/home/berny/git/coreutils/gt-capability.sh.h8yJ +++ case $d in +++ : +++ test -d /home/berny/git/coreutils/gt-capability.sh.h8yJ ++++ ls -dgo /home/berny/git/coreutils/gt-capability.sh.h8yJ +++ perms=3D'drwx------ 2 4096 Sep 30 10:14 /home/berny/git/coreutils/gt-c= apability.sh.h8yJ' +++ case $perms in +++ : +++ echo /home/berny/git/coreutils/gt-capability.sh.h8yJ +++ return ++ test_dir_=3D/home/berny/git/coreutils/gt-capability.sh.h8yJ ++ cd /home/berny/git/coreutils/gt-capability.sh.h8yJ ++ case $srcdir in ++ srcdir=3D../. ++ builddir=3D.. ++ export srcdir builddir ++ gl_init_sh_nl_=3D' ' ++ IFS=3D' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ saved_IFS=3D' ' ++ IFS=3D: ++ new_PATH=3D ++ for dir in $PATH ++ IFS=3D' ' ++ case "$dir" in ++ test -d /home/berny/coreutils/src/. ++ new_PATH=3D/home/berny/coreutils/src ++ for dir in $PATH ++ IFS=3D' ' ++ case "$dir" in ++ test -d /home/berny/bin/. ++ new_PATH=3D/home/berny/coreutils/src:/home/berny/bin ++ for dir in $PATH ++ IFS=3D' ' ++ case "$dir" in ++ test -d /usr/local/bin/. ++ new_PATH=3D/home/berny/coreutils/src:/home/berny/bin:/usr/local/bin ++ for dir in $PATH ++ IFS=3D' ' ++ case "$dir" in ++ test -d /usr/bin/. ++ new_PATH=3D/home/berny/coreutils/src:/home/berny/bin:/usr/local/bin:/us= r/bin ++ for dir in $PATH ++ IFS=3D' ' ++ case "$dir" in ++ test -d /bin/. ++ new_PATH=3D/home/berny/coreutils/src:/home/berny/bin:/usr/local/bin:/us= r/bin:/bin ++ for dir in $PATH ++ IFS=3D' ' ++ case "$dir" in ++ test -d /sbin/. ++ new_PATH=3D/home/berny/coreutils/src:/home/berny/bin:/usr/local/bin:/us= r/bin:/bin:/sbin ++ for dir in $PATH ++ IFS=3D' ' ++ case "$dir" in ++ test -d /usr/sbin/. ++ new_PATH=3D/home/berny/coreutils/src:/home/berny/bin:/usr/local/bin:/us= r/bin:/bin:/sbin:/usr/sbin ++ IFS=3D' ' ++ PATH=3D/home/berny/coreutils/src:/home/berny/bin:/usr/local/bin:/usr/bi= n:/bin:/sbin:/usr/sbin ++ export PATH ++ trap remove_tmp_ EXIT + path_prepend_ ./src + test 1 '!=3D' 0 + path_dir_=3D./src + case $path_dir_ in + abs_path_dir_=3D/home/berny/git/coreutils/./src + case $abs_path_dir_ in + PATH=3D/home/berny/git/coreutils/./src:/home/berny/coreutils/src:/home/b= erny/bin:/usr/local/bin:/usr/bin:/bin:/sbin:/usr/sbin + create_exe_shims_ /home/berny/git/coreutils/./src + case $EXEEXT in + return 0 + shift + test 0 '!=3D' 0 + export PATH + print_ver_ ls printf + require_built_ ls printf + skip_=3Dno + for i in "$@" + case " $built_programs " in + for i in "$@" + case " $built_programs " in + test no =3D yes + test yes =3D yes + local i + for i in $* + env ls --version ls (GNU coreutils) 9.5.121-e71b24 Copyright (C) 2024 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Richard M. Stallman and David MacKenzie. + for i in $* + env printf --version printf (GNU coreutils) 9.5.121-e71b24 Copyright (C) 2024 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by David MacKenzie. + require_root_ + uid_is_privileged_ ++ id -u + my_uid=3D0 + case $my_uid in + NON_ROOT_USERNAME=3Dberny ++ id -g berny + NON_ROOT_GID=3D1000 + grep '^[ ]*chroot' .././tests/ls/capability.sh + grep '^#define HAVE_CAP 1' /home/berny/coreutils/lib/config.h + grep 'usage: setcap' + umask 22 + mkdir test test/dir + cd test + touch cap_pos dir/cap_pos dir/cap_neg + for file in cap_pos dir/cap_neg + setcap cap_net_bind_service=3Dep cap_pos + for file in cap_pos dir/cap_neg + setcap cap_net_bind_service=3Dep dir/cap_neg + code=3D'30;41' + for ex in '' ex=3D: + LS_COLORS=3D'di=3D:ca=3D30;41' + ls --color=3Dalways cap_pos dir + env printf '\e[0m\e[30;41mcap_pos\e[0m dir: \e[30;41mcap_neg\e[0m cap_pos ' + compare out out_ok + compare_dev_null_ out out_ok + test 2 =3D 2 + test xout =3D x/dev/null + test xout_ok =3D x/dev/null + return 2 + case $? in + compare_ out out_ok + LC_ALL=3DC + diff -u out out_ok =2D-- out 2024-09-30 10:14:06.161475391 +0200 +++ out_ok 2024-09-30 10:14:06.164810391 +0200 @@ -1,5 +1,5 @@ -cap_pos +=1B[0m=1B[30;41mcap_pos=1B[0m dir: -cap_neg +=1B[30;41mcap_neg=1B[0m cap_pos + fail=3D1 + for ex in '' ex=3D: + LS_COLORS=3D'di=3D:ex=3D:ca=3D30;41' + ls --color=3Dalways cap_pos dir + env printf '\e[0m\e[30;41mcap_pos\e[0m dir: \e[30;41mcap_neg\e[0m cap_pos ' + compare out out_ok + compare_dev_null_ out out_ok + test 2 =3D 2 + test xout =3D x/dev/null + test xout_ok =3D x/dev/null + return 2 + case $? in + compare_ out out_ok + LC_ALL=3DC + diff -u out out_ok =2D-- out 2024-09-30 10:14:06.164810391 +0200 +++ out_ok 2024-09-30 10:14:06.168145391 +0200 @@ -1,5 +1,5 @@ -cap_pos +=1B[0m=1B[30;41mcap_pos=1B[0m dir: -cap_neg +=1B[30;41mcap_neg=1B[0m cap_pos + fail=3D1 + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=3D1 + cleanup_ + : + test '' =3D yes + cd /home/berny/git/coreutils + chmod -R u+rwx /home/berny/git/coreutils/gt-capability.sh.h8yJ + rm -rf /home/berny/git/coreutils/gt-capability.sh.h8yJ + exit 1 FAIL tests/ls/capability.sh (exit status: 1) Have a nice day, Berny From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 02 Oct 2024 22:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker , Paul Eggert , Gian Domenico Bonazzoli Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172790713718277 (code B ref 73418); Wed, 02 Oct 2024 22:13:02 +0000 Received: (at 73418) by debbugs.gnu.org; 2 Oct 2024 22:12:17 +0000 Received: from localhost ([127.0.0.1]:59452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw7Zx-0004ki-Di for submit@debbugs.gnu.org; Wed, 02 Oct 2024 18:12:17 -0400 Received: from mail-lj1-f177.google.com ([209.85.208.177]:50427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw7Zu-0004kW-PT for 73418@debbugs.gnu.org; Wed, 02 Oct 2024 18:12:16 -0400 Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2facf48166bso3918381fa.0 for <73418@debbugs.gnu.org>; Wed, 02 Oct 2024 15:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727907073; x=1728511873; darn=debbugs.gnu.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=enTfsVBbQzcfxZQcPldMau4nV6piUVbE+wcfvOzzPIo=; b=cgRT5CBvFfTcI33JkqiQrlDFiqieB2iLM4cJkJEP0aVLZt4nQdUYfzKiQ5SWMIrnFh qKSuOhXSwb5BuSZoMGA800U0KZ0IranN89ZVswWFviGCwzIRUtxdMQBJq6ZXqvjMY0VX rHhZFThL2OEbcia25hyX/rirQqmfg3U+HFKDv/km+lx8h4IrFLFoMeQhtSE0HUPJwZvo CeQa6YyPOK/rXLYIsBujDi2Y+0gPBwczF81gl8WTSA2FIniOx9Bq5Dgn2zKAJs5VKLxy otxqvh8DVNSgmuCsaTvT3SFMf8GiF+s70NOrc8OHeXJJsAB10L3tKW0cqXAJu4lq+jPN sjxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727907073; x=1728511873; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=enTfsVBbQzcfxZQcPldMau4nV6piUVbE+wcfvOzzPIo=; b=WIBjD5VoH+tIPCCXBSKqulHei/H4N7ctpQHHLz4jIRGEmWh/G9h4Z9io92OfeakLiD gQyP4N+Txi56SVUjbYPSVrThribIdTRfL8x5pKLfw5XQ5aLyBOWLMJe33O1x9+QTBPHG VcuTF6fm2S3LWfI/mrSy0QjFD77KcBQQWm6iUlx7wA0ACLRKKlAChSAoK0NukBJy6DJl e7o9hs/JmcrbfapPjM2Kghk1iO7cEimUl/fjfr9A8ib1v/85+jatEarCEAEDWG7bQsd2 i/ryQRZFPwAGGr+HokkNIWZzYgvskNl+Gy+YT/TgCDFjuuYHUPFUPem78AUsL4hdQIi6 1yqA== X-Gm-Message-State: AOJu0YxpTyBHrdmAjnPTZ1tK3u1lg6QX7aZNixpTkdLE+eXyQpAe863Z ml4gDrsKlAFh8ECbxlIOg2gQBe7R0qZZCIiCl1E0zOQ8FXhN0zw//7p5YQ== X-Google-Smtp-Source: AGHT+IHduirPKMJLaKScgt/vVdms7wU4Ywco6rlr89w6lqcXTbo2o/Sp399G3YeDffOguNegTneVmQ== X-Received: by 2002:a2e:b8cd:0:b0:2fa:d4ad:f4db with SMTP id 38308e7fff4ca-2fae1016594mr32421781fa.15.1727907072532; Wed, 02 Oct 2024 15:11:12 -0700 (PDT) Received: from [192.168.1.156] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5c88245e990sm8048045a12.52.2024.10.02.15.11.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Oct 2024 15:11:11 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------KfN1acoPVzDT4MGuTeXWadC0" Message-ID: <404c8151-692d-4447-ab60-30c9583b23e2@draigBrady.com> Date: Wed, 2 Oct 2024 23:11:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta References: <57189234-b3c9-46ca-ae1e-1f31c0188767@bernhard-voelker.de> Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig?= Brady In-Reply-To: <57189234-b3c9-46ca-ae1e-1f31c0188767@bernhard-voelker.de> X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------KfN1acoPVzDT4MGuTeXWadC0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 30/09/2024 09:26, Bernhard Voelker wrote: > On 9/30/24 7:24 AM, Paul Eggert wrote: >> I installed the attached patch to fix some of the issue > > There's a new test failure for a require_root_ test here: > > FAIL: tests/ls/capability > ========================= That should be fixed by the attached. thanks, Pádraig --------------KfN1acoPVzDT4MGuTeXWadC0 Content-Type: text/x-patch; charset=UTF-8; name="ls-capability-fix.patch" Content-Disposition: attachment; filename="ls-capability-fix.patch" Content-Transfer-Encoding: base64 RnJvbSA1OGRmOTIyNTlmYWMyYTg2MTNiYmQ4ZGYwM2M2MWVmNWMzN2RjNDM2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/UD1DMz1BMWRyYWlnPTIwQnJhZHk/ PSA8UEBkcmFpZ0JyYWR5LmNvbT4KRGF0ZTogV2VkLCAyIE9jdCAyMDI0IDIyOjU3OjE2ICsw MTAwClN1YmplY3Q6IFtQQVRDSF0gbHM6IHJlaW5zdGF0ZSBjYXBhYmlsaXR5IGNoZWNraW5n IGluIG1vcmUgY2FzZXMKClRoZSByZWNlbnQgY29tbWl0IHY5LjUtMTE5LWc0Y2U0MzJhZDgg cmVzdHJpY3RlZCBjYXBhYmlsaXR5IGNoZWNraW5nCnRvIG9ubHkgZmlsZXMgd2l0aCBYQVRU Ul9OQU1FX0NBUFMgc2V0LiAgSWYgdGhpcyBpcyBkb25lIHRoZW4gd2UgbmVlZAp0byBhZGp1 c3QgdGVzdHMvbHMvbm8tY2FwLnNoIHNvIHRoYXQgaXQgZG9lc24ndCBhbHdheXMgc2tpcC4g IE1vcmUKcHJvYmxlbWF0aWNhbGx5IFhBVFRSX05BTUVfQ0FQUyB3YXMgb25seSBkZXRlcm1p bmVkIGluIGxvbmcgbGlzdGluZwptb2RlLCB0aHVzIGJyZWFraW5nIGNhcGFiaWxpdHkgY29s b3JpbmcgaW4gc2hvcnQgbGlzdGluZyBtb2RlCmFzIGV2aWRlbmNlZCBieSB0aGUgZmFpbGlu ZyB0ZXN0cy9scy9jYXBhYmlsaXR5LnNoIHRlc3QuCgpOb3RlIGNhcGFiaWxpdHkgY2hlY2tp bmcgZG9lcyBoYXZlIGEgbGFyZ2Ugb3ZlcmhlYWQsIGJ1dCB3ZSd2ZQpkaXNhYmxlZCBjYXBh YmlsaXR5IGNoZWNraW5nIGJ5IGRlZmF1bHQgYW55d2F5IHRocm91Z2ggdGhlIGRlZmF1bHQK Y29sb3IgY29uZmlndXJhdGlvbiBzaW5jZSB2OS4wLTE4Ny1nNmI1MTM0NzcwCgpTbyBmb3Ig dGhlc2UgcmVhc29ucyByZXZlcnQgdG8gY2hlY2tpbmcgY2FwYWJpbGl0aWVzIGFzIGJlZm9y ZS4KCiogc3JjL2xzLmMgKGdvYmJsZV9maWxlKTogQ2hlY2sgZm9yIGNhcGFiaWxpdGllcyBp biBhbGwgbW9kZXMKaWYgZW5hYmxlZCBpbiBjb2xvciBjb25maWcuCi0tLQogc3JjL2xzLmMg fCAxNCArKysrKystLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwg OCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvbHMuYyBiL3NyYy9scy5jCmluZGV4 IDA5OTg5M2Y4Ni4uOGQwYWUxMWY0IDEwMDY0NAotLS0gYS9zcmMvbHMuYworKysgYi9zcmMv bHMuYwpAQCAtMzQ4NCw2ICszNDg0LDEyIEBAIGdvYmJsZV9maWxlIChjaGFyIGNvbnN0ICpu YW1lLCBlbnVtIGZpbGV0eXBlIHR5cGUsIGlub190IGlub2RlLAogCiAgICAgICBmLT5zdGF0 X29rID0gdHJ1ZTsKIAorICAgICAgLyogaGFzX2NhcGFiaWxpdHkgYWRkcyBhcm91bmQgMzAl IHJ1bnRpbWUgdG8gJ2xzIC0tY29sb3InLAorICAgICAgICAgIHNvIGNhbGwgaXQgb25seSBp ZiByZWFsbHkgbmVlZGVkLiAgKi8KKyAgICAgIGlmICgodHlwZSA9PSBub3JtYWwgfHwgU19J U1JFRyAoZi0+c3RhdC5zdF9tb2RlKSkKKyAgICAgICAgICAmJiBwcmludF93aXRoX2NvbG9y ICYmIGlzX2NvbG9yZWQgKENfQ0FQKSkKKyAgICAgICAgZi0+aGFzX2NhcGFiaWxpdHkgPSBo YXNfY2FwYWJpbGl0eV9jYWNoZSAoZnVsbF9uYW1lLCBmKTsKKwogICAgICAgaWYgKGZvcm1h dCA9PSBsb25nX2Zvcm1hdCB8fCBwcmludF9zY29udGV4dCkKICAgICAgICAgewogICAgICAg ICAgIHN0cnVjdCBhY2xpbmZvIGFpOwpAQCAtMzUxMiwxNCArMzUxOCw2IEBAIGdvYmJsZV9m aWxlIChjaGFyIGNvbnN0ICpuYW1lLCBlbnVtIGZpbGV0eXBlIHR5cGUsIGlub190IGlub2Rl LAogICAgICAgICAgICAgICAgIGVycm9yICgwLCBhaS5zY29udGV4dF9lcnIsICIlcyIsIHF1 b3RlZiAoZnVsbF9uYW1lKSk7CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAvKiBoYXNf Y2FwYWJpbGl0eSBhZGRzIGFyb3VuZCAzMCUgcnVudGltZSB0byAnbHMgLS1jb2xvcicsCi0g ICAgICAgICAgICAgc28gY2FsbCBpdCBvbmx5IGlmIHJlYWxseSBuZWVkZWQuICAqLwotICAg ICAgICAgIGlmICgwIDwgYWkuc2l6ZQotICAgICAgICAgICAgICAmJiAodHlwZSA9PSBub3Jt YWwgfHwgU19JU1JFRyAoZi0+c3RhdC5zdF9tb2RlKSkKLSAgICAgICAgICAgICAgJiYgcHJp bnRfd2l0aF9jb2xvciAmJiBpc19jb2xvcmVkIChDX0NBUCkKLSAgICAgICAgICAgICAgJiYg YWNsaW5mb19oYXNfeGF0dHIgKCZhaSwgWEFUVFJfTkFNRV9DQVBTKSkKLSAgICAgICAgICAg IGYtPmhhc19jYXBhYmlsaXR5ID0gaGFzX2NhcGFiaWxpdHlfY2FjaGUgKGZ1bGxfbmFtZSwg Zik7Ci0KICAgICAgICAgICBmLT5zY29udGV4dCA9IGFpLnNjb250ZXh0OwogICAgICAgICAg IGFpLnNjb250ZXh0ID0gbnVsbHB0cjsKICAgICAgICAgICBhY2xpbmZvX2ZyZWUgKCZhaSk7 Ci0tIAoyLjQ2LjAKCg== --------------KfN1acoPVzDT4MGuTeXWadC0-- From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 02 Oct 2024 22:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert , Gian Domenico Bonazzoli Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172790733419125 (code B ref 73418); Wed, 02 Oct 2024 22:16:01 +0000 Received: (at 73418) by debbugs.gnu.org; 2 Oct 2024 22:15:34 +0000 Received: from localhost ([127.0.0.1]:59458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw7d8-0004yP-4u for submit@debbugs.gnu.org; Wed, 02 Oct 2024 18:15:34 -0400 Received: from mail-lj1-f177.google.com ([209.85.208.177]:52396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw7d6-0004yH-Gb for 73418@debbugs.gnu.org; Wed, 02 Oct 2024 18:15:32 -0400 Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2fad6de2590so4760441fa.0 for <73418@debbugs.gnu.org>; Wed, 02 Oct 2024 15:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727907271; x=1728512071; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Hb+xvZOzfblDC8sIIbUl4LWrPtA326Q9LlthlsfTdss=; b=LX6+wsRmiMuRbh3SuI6VfAGYrHcNXxz6h1Yae/DVwuEzzi0k50cc7D46m8f1Op3QRh CZUu8YyTYy544wZJOqpUGIipn2sVXwWJwCrtBqiRg74lMOlLDWC1FLkakc2fy9dbukUu 8Bgm/QbNMeKbXGcbN4l4UMwuwWgYBG2bylDsz5C9zIRGe+BYuyLdcAECkHc+aA9QScjr dewuZIYHKyn7UHxH4v9OTOeX4liUGOw7tGPvEP4FV2s/srhZ9T8jT4HaR/C7lJNuKwNL lCIg+nBc/SNY1Q3WLnkwp5wgITne2apX//L/L0Z6Rl9U2irWfq1CntX7nxWZch7HHVJh xxKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727907271; x=1728512071; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hb+xvZOzfblDC8sIIbUl4LWrPtA326Q9LlthlsfTdss=; b=Rbt/yyLwyCwTVpWkn+l/zuBstSDqHiEC+1h1qBYYDl8eGS9tlrh1z/pOg6xF+aE2IT E33C+mJPs+sJ4DPMCayRwdz7e3iUl2siL3PNXLLsRJJkiWc0GBCYfgLlHW75WOV4i28v dFt0oUpck5H5NpMaecmvZiE9WvOabJYRn9fGTzxXsGzfxc0Gk8lui3N21/ZQnMvdlyGK 66PpGnY4uHrG2SjAcD+Jf9Yh1IbkCydnY0GaVAVgrK8g145/avMg7PByZn3Apaqe0zka ytAGFsirKa8iz16qahXCO8kh65Y3D4yxMuoLchKZFgD+nzsRBCxTs1lfpzsxVD1WBEx2 5QMw== X-Gm-Message-State: AOJu0Yw/PvqnQh+RyWs/SHCKiU4GXGuId26icZjnucunBJhjL3L02R/B XLFoMEtn3LKD7G3ePushs0pf1L/f5uFGRP2P7vvibmYQ7mN/0Hh2 X-Google-Smtp-Source: AGHT+IE3Ix/Oe9IvGVIUmkSbx+MYUT7GKozscrrAB9B9jdLRHGhNFqgp2kpK5E+3UIQyK3QZrdQ9qg== X-Received: by 2002:a05:6512:250c:b0:539:8f3c:4586 with SMTP id 2adb3069b0e04-539a07a635emr4113455e87.55.1727907270389; Wed, 02 Oct 2024 15:14:30 -0700 (PDT) Received: from [192.168.1.156] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a9909e1a883sm42502566b.91.2024.10.02.15.14.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Oct 2024 15:14:29 -0700 (PDT) Message-ID: <2b9f18dd-a0a6-4486-887f-e22f08493e0e@draigBrady.com> Date: Wed, 2 Oct 2024 23:14:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta References: Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig?= Brady In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 30/09/2024 06:24, Paul Eggert wrote: > Looking at the current coreutils source, I noticed that 'ls' called > getxattr when it didn't need to. I installed the attached patch to fix > some of the issue; more could be done and perhaps I'll find the time. > Among other things this patch should cause GNU ls to use llistxattr > instead of listxattr which may make a difference. I notice that tests/ls/getxattr-speedup.sh is failing now, which I've not looked into yet. cheers, Pádraig From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 02 Oct 2024 22:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , Bernhard Voelker , Gian Domenico Bonazzoli Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172790789720707 (code B ref 73418); Wed, 02 Oct 2024 22:25:02 +0000 Received: (at 73418) by debbugs.gnu.org; 2 Oct 2024 22:24:57 +0000 Received: from localhost ([127.0.0.1]:59469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw7mC-0005Nv-UG for submit@debbugs.gnu.org; Wed, 02 Oct 2024 18:24:57 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:55512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw7m8-0005NY-GJ for 73418@debbugs.gnu.org; Wed, 02 Oct 2024 18:24:55 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 1A7CB3C011BC5; Wed, 2 Oct 2024 15:24:42 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id p1RrKGjWDHbS; Wed, 2 Oct 2024 15:24:41 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id D142F3C011BD8; Wed, 2 Oct 2024 15:24:41 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu D142F3C011BD8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1727907881; bh=SGf7u2MgRAq8XcZsk5zRhDuoaxqPrzUYd6Xb3hU1XjA=; h=Message-ID:Date:MIME-Version:To:From; b=Xyb322an0ZMbt5AIy3FjkmhQhkcZb8L9TJGANh5TgjDYmqxpzvAXKUorTyGfFUHjK 4kfFTfCoSPHyUZCDur/WOxtWwqa+Ukrh6NtFWPccx4FavT9/8zCW2YIBsDwIprayJO tnv7jox69Pv2IFo/GgiXitoPGAfjbTqeKQjT02zhu/Z9ELNWfGowMRpjbppLZVLcKU v7XHe0LCCSc4oNRkOInog3+ijTWujsFmy6X4TEaIXFfBiOOcc4y8CecdPC31Mg20tQ Bbz3ZlyHSHu+TD94/jzQLgrCd2mwVVlZ1qqklxX+7cX/E6ZeF83aonM+uFUoIwriZm ysqb8V9PaZEAQ== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id qewXgaHRk3HZ; Wed, 2 Oct 2024 15:24:41 -0700 (PDT) Received: from [192.168.254.12] (unknown [47.150.137.250]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id B3D973C011BC5; Wed, 2 Oct 2024 15:24:41 -0700 (PDT) Message-ID: Date: Wed, 2 Oct 2024 15:24:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <57189234-b3c9-46ca-ae1e-1f31c0188767@bernhard-voelker.de> <404c8151-692d-4447-ab60-30c9583b23e2@draigBrady.com> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <404c8151-692d-4447-ab60-30c9583b23e2@draigBrady.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2024-10-02 15:11, P=C3=A1draig Brady wrote: > That should be fixed by the attached. A quick look suggests that would be an improvement, yes. I'm also working on a more comprehensive fix. This will require Gnulib=20 changes. From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 03 Oct 2024 06:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , Bernhard Voelker , Gian Domenico Bonazzoli Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172793548521122 (code B ref 73418); Thu, 03 Oct 2024 06:05:01 +0000 Received: (at 73418) by debbugs.gnu.org; 3 Oct 2024 06:04:45 +0000 Received: from localhost ([127.0.0.1]:59743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swEx9-0005UZ-Ov for submit@debbugs.gnu.org; Thu, 03 Oct 2024 02:04:44 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:55776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swEx4-0005U5-Q1 for 73418@debbugs.gnu.org; Thu, 03 Oct 2024 02:04:40 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id E612C3C011BD8; Wed, 2 Oct 2024 23:04:30 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id D9hbb6KjKyfg; Wed, 2 Oct 2024 23:04:30 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 0C0C73C011BD9; Wed, 2 Oct 2024 23:04:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 0C0C73C011BD9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1727935470; bh=zXdJTuP8ANnEmGarVQNEhU7uq459IB2qgz36rOdzU8A=; h=Message-ID:Date:MIME-Version:From:To; b=Pjs6Gkm/O9pvhTfKWeOucgA/4WsdeFnRwVkoNGNPah932AsWDrPV6vByk5jYi/Qm6 PrnPbUhg1my5zHOtuwTMWESYB9HKa9bWx1xeEViX85bJyReibKuknzFXnOvPixuTQH vHJdRsPhUZHOBiUlLpknkGxnH3pzncP0OaGjJlkcHD6yhxpecsU9wDZQi+vXsQAXNF wt2Q0gRqZm3Ol5VMGK2lP+om7hkl83c8SwwQYz4uajIjKBFwao6dbzbCkBlFrRGUJx BAHUekWVps0CyF6BVt8pfU5zkctOXwDb7BSQiLgM8XijCRN2/UVjMSnGH1cMKKfqmN 9KzlIplh+ugtQ== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id A_JIkTXEy2AK; Wed, 2 Oct 2024 23:04:29 -0700 (PDT) Received: from [192.168.254.12] (unknown [47.150.137.250]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id D2FFD3C011BD8; Wed, 2 Oct 2024 23:04:29 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------vriBVwU0XsfLk9HjGqiB01Qr" Message-ID: Date: Wed, 2 Oct 2024 23:04:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Paul Eggert References: <57189234-b3c9-46ca-ae1e-1f31c0188767@bernhard-voelker.de> <404c8151-692d-4447-ab60-30c9583b23e2@draigBrady.com> Content-Language: en-US Organization: UCLA Computer Science Department In-Reply-To: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------vriBVwU0XsfLk9HjGqiB01Qr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-10-02 15:24, Paul Eggert wrote: > I'm also working on a more comprehensive fix. This will require Gnulib > changes. I installed the attached (plus some other refactorings) to do that. --------------vriBVwU0XsfLk9HjGqiB01Qr Content-Type: text/x-patch; charset=UTF-8; name="0001-ls-tune-usage-of-getxattr-stat-syscalls.patch" Content-Disposition: attachment; filename="0001-ls-tune-usage-of-getxattr-stat-syscalls.patch" Content-Transfer-Encoding: base64 RnJvbSAyYTZiZWQ5MzMyYmQ1ODI2MDkyM2YxN2E5ZmNmYTM3MmIyMzQ5ZGIxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDIgT2N0IDIwMjQgMjE6MTE6MDIgLTA3MDAKU3ViamVjdDogW1BBVENI XSBsczogdHVuZSB1c2FnZSBvZiBnZXR4YXR0ci9zdGF0IHN5c2NhbGxzCk1JTUUtVmVyc2lv bjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50 LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgpVcGRhdGUgZ251bGliIHN1Ym1vZHVsZSB0byBs YXRlc3QuICBUaGlzIGNoYW5nZXMgdGhlIGZpbGVfaGFzX2FjbGluZm8KQVBJLCBzbyBhdCB0 aGUgc2FtZSB0aW1lIGRvIHRoZSBmb2xsb3dpbmcgY2hhbmdlcyB0byBscy5jLCB3aGljaAph ZGp1c3RzIHRvIHRoZXNlIGNoYW5nZXMgYW1vbmcgb3RoZXIgdGhpbmdzLgoqIHNyYy9scy5j IChmaWxldHlwZV9kX3R5cGUsIGRfdHlwZV9maWxldHlwZSk6IE5ldyBzdGF0aWMgY29uc3Rh bnRzLgooZm9ybWF0X25lZWRzX2NhcGFiaWxpdHkpOiBOZXcgc3RhdGljIHZhci4KKG1haW4p OiBTZXQgYW5kIHVzZSBpdC4gIERvbuKAmXQgc2V0IGZvcm1hdF9uZWVkc19zdGF0IG1lcmVs eQpiZWNhdXNlIHByaW50X3Njb250ZXh0LCBhcyB3ZSBuZWVkbuKAmXQgY2FsbCBzdGF0IHRv IGdldCB0aGUKc2NvbnRleHQuICBJbnN0ZWFkLCBzZXQgZm9ybWF0X25lZWRzX3R5cGUgaWYg cHJpbnRfc2NvbnRleHQgYnV0Cm5vdCBmb3JtYXRfbmVlZHNfc3RhdC4KKHByaW50X2Rpcik6 IFVzZSBuZXcgc3RhdGljIHRhYmxlcyB0byBkZXRlcm1pbmUgZmlsZXR5cGUKbW9yZSBlZmZp Y2llbnRseS4KKGZpbGVfaGFzX2FjbGluZm9fY2FjaGUpOiBBZGp1c3QgdG8gR251bGliIGZp bGVfaGFzX2FjbGluZm8gQVBJIGNoYW5nZS4KKGdvYmJsZV9maWxlKTogQ2hlY2sgc3RhdCBp ZiBmb3JtYXRfbmVlZHNfdHlwZSBidXQgdGhlIHR5cGUgaXMKdW5rbm93bi4gIEJlIGNvbnNl cnZhdGl2ZSwgYW5kIHdoZW4gZGVjaWRpbmcgd2hldGhlciB0byBjaGVjayBzdGF0CmJ1dCB0 aGUgdHlwZSBpcyB1bmtub3duLCBhc3N1bWUgaXQgbWlnaHQgYmUgZGlyZWN0b3J5LiAgU2lt aWxhcmx5CmZvciBub3JtYWwgZmlsZXMgd2hlbiBjbGFzc2lmeWluZzsgaWYgdGhlIHR5cGUg aXMgdW5rbm93biBhc3N1bWUKaXQgbWlnaHQgYmUgbm9ybWFsLiAgVXNlIG5ldyBzdGF0aWMg Y29uc3RhbnRzIGFuZCBJRlRPRFQgdG8KY29tcHV0ZSBmaWxldHlwZSBtb3JlIHN0cmFpZ2h0 Zm9yd2FyZGx5LiAgR2V0IEFDTHMgYW5kIGNoZWNrIGZvcgpjYXBhYmlsaXR5IGxlc3Mgb2Z0 ZW4uCihnZXRfY29sb3JfaW5kaWNhdG9yKTogT21pdCB1bm5lY2Vzc2FyeSBjYWxsIHRvIGlz X2NvbG9yZWQgKENfQ0FQKSwKc2luY2UgZi0+aGFzX2NhcGFiaWxpdHkgY2FuIGJlIHRydWUg b25seSBpZiBpc19jb2xvcmVkIChDX0NBUCkuCi0tLQogZ251bGliICAgfCAgIDIgKy0KIHNy Yy9scy5jIHwgMzcyICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTg1IGluc2VydGlvbnMoKyksIDE4 OSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnVsaWIgYi9nbnVsaWIKaW5kZXggY2Nj MjZhZGQ0Li5iYTkxMzZiNzYgMTYwMDAwCi0tLSBhL2dudWxpYgorKysgYi9nbnVsaWIKQEAg LTEgKzEgQEAKLVN1YnByb2plY3QgY29tbWl0IGNjYzI2YWRkNGUxZGNhNzZlN2EzZGVkNDY1 Yzk0ZGI0MDY0YmMyMGQKK1N1YnByb2plY3QgY29tbWl0IGJhOTEzNmI3NjQ2ZWY5ZTAxZmZh ZDNkZGNmMjMyMDAyMzU0NTMxZDAKZGlmZiAtLWdpdCBhL3NyYy9scy5jIGIvc3JjL2xzLmMK aW5kZXggNTdmMTYyMWZmLi4xMDFmZmE4MTggMTAwNjQ0Ci0tLSBhL3NyYy9scy5jCisrKyBi L3NyYy9scy5jCkBAIC0xODAsNiArMTgwLDIyIEBAIHN0YXRpYyBjaGFyIGNvbnN0IGZpbGV0 eXBlX2xldHRlcltdID0KICAgeyc/JywgJ3AnLCAnYycsICdkJywgJ2InLCAnLScsICdsJywg J3MnLCAndycsICdkJ307CiBzdGF0aWNfYXNzZXJ0IChBUlJBWV9DQVJESU5BTElUWSAoZmls ZXR5cGVfbGV0dGVyKSA9PSBmaWxldHlwZV9jYXJkaW5hbGl0eSk7CiAKKy8qIE1hcCBlbnVt IGZpbGV0eXBlIHRvIDxkaXJlbnQuaD4gZF90eXBlIHZhbHVlcy4gICovCitzdGF0aWMgdW5z aWduZWQgY2hhciBjb25zdCBmaWxldHlwZV9kX3R5cGVbXSA9CisgIHsKKyAgICBEVF9VTktO T1dOLCBEVF9GSUZPLCBEVF9DSFIsIERUX0RJUiwgRFRfQkxLLCBEVF9SRUcsIERUX0xOSywg RFRfU09DSywKKyAgICBEVF9XSFQsIERUX0RJUgorICB9Oworc3RhdGljX2Fzc2VydCAoQVJS QVlfQ0FSRElOQUxJVFkgKGZpbGV0eXBlX2RfdHlwZSkgPT0gZmlsZXR5cGVfY2FyZGluYWxp dHkpOworCisvKiBNYXAgZF90eXBlIHZhbHVlcyB0byBlbnVtIGZpbGV0eXBlLiAgKi8KK3N0 YXRpYyBjaGFyIGNvbnN0IGRfdHlwZV9maWxldHlwZVtVQ0hBUl9NQVggKyAxXSA9CisgIHsK KyAgICBbRFRfQkxLXSA9IGJsb2NrZGV2LCBbRFRfQ0hSXSA9IGNoYXJkZXYsIFtEVF9ESVJd ID0gZGlyZWN0b3J5LAorICAgIFtEVF9GSUZPXSA9IGZpZm8sIFtEVF9MTktdID0gc3ltYm9s aWNfbGluaywgW0RUX1JFR10gPSBub3JtYWwsCisgICAgW0RUX1NPQ0tdID0gc29jaywgW0RU X1dIVF0gPSB3aGl0ZW91dAorICB9OworCiBlbnVtIGFjbF90eXBlCiAgIHsKICAgICBBQ0xf VF9OT05FLApAQCAtNzUxLDYgKzc2NywxMCBAQCBzdGF0aWMgYm9vbCBmb3JtYXRfbmVlZHNf c3RhdDsKIAogc3RhdGljIGJvb2wgZm9ybWF0X25lZWRzX3R5cGU7CiAKKy8qIExpa2UgJ2Zv cm1hdF9uZWVkc19zdGF0JywgYnV0IHNldCBvbmx5IGlmIGNhcGFiaWxpdHkgY29sb3JzIGFy ZSBuZWVkZWQuICAqLworCitzdGF0aWMgYm9vbCBmb3JtYXRfbmVlZHNfY2FwYWJpbGl0eTsK KwogLyogQW4gYXJiaXRyYXJ5IGxpbWl0IG9uIHRoZSBudW1iZXIgb2YgYnl0ZXMgaW4gYSBw cmludGVkIHRpbWVzdGFtcC4KICAgIFRoaXMgaXMgc2V0IHRvIGEgcmVsYXRpdmVseSBzbWFs bCB2YWx1ZSB0byBhdm9pZCB0aGUgbmVlZCB0byB3b3JyeQogICAgYWJvdXQgZGVuaWFsLW9m LXNlcnZpY2UgYXR0YWNrcyBvbiBzZXJ2ZXJzIHRoYXQgcnVuICJscyIgb24gYmVoYWxmCkBA IC0xNzMyLDE1ICsxNzUyLDE0IEBAIG1haW4gKGludCBhcmdjLCBjaGFyICoqYXJndikKIAog ICBsb2NhbHR6ID0gdHphbGxvYyAoZ2V0ZW52ICgiVFoiKSk7CiAKLSAgZm9ybWF0X25lZWRz X3N0YXQgPSBzb3J0X3R5cGUgPT0gc29ydF90aW1lIHx8IHNvcnRfdHlwZSA9PSBzb3J0X3Np emUKLSAgICB8fCBmb3JtYXQgPT0gbG9uZ19mb3JtYXQKLSAgICB8fCBwcmludF9zY29udGV4 dAotICAgIHx8IHByaW50X2Jsb2NrX3NpemU7Ci0gIGZvcm1hdF9uZWVkc190eXBlID0gKCEg Zm9ybWF0X25lZWRzX3N0YXQKLSAgICAgICAgICAgICAgICAgICAgICAgJiYgKHJlY3Vyc2l2 ZQotICAgICAgICAgICAgICAgICAgICAgICAgICAgfHwgcHJpbnRfd2l0aF9jb2xvcgotICAg ICAgICAgICAgICAgICAgICAgICAgICAgfHwgaW5kaWNhdG9yX3N0eWxlICE9IG5vbmUKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgIHx8IGRpcmVjdG9yaWVzX2ZpcnN0KSk7CisgIGZv cm1hdF9uZWVkc19zdGF0ID0gKChzb3J0X3R5cGUgPT0gc29ydF90aW1lKSB8IChzb3J0X3R5 cGUgPT0gc29ydF9zaXplKQorICAgICAgICAgICAgICAgICAgICAgICB8IChmb3JtYXQgPT0g bG9uZ19mb3JtYXQpCisgICAgICAgICAgICAgICAgICAgICAgIHwgcHJpbnRfYmxvY2tfc2l6 ZSB8IHByaW50X2h5cGVybGluayk7CisgIGZvcm1hdF9uZWVkc190eXBlID0gKCghIGZvcm1h dF9uZWVkc19zdGF0KQorICAgICAgICAgICAgICAgICAgICAgICAmIChyZWN1cnNpdmUgfCBw cmludF93aXRoX2NvbG9yIHwgcHJpbnRfc2NvbnRleHQKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgfCBkaXJlY3Rvcmllc19maXJzdAorICAgICAgICAgICAgICAgICAgICAgICAgICB8 IChpbmRpY2F0b3Jfc3R5bGUgIT0gbm9uZSkpKTsKKyAgZm9ybWF0X25lZWRzX2NhcGFiaWxp dHkgPSBwcmludF93aXRoX2NvbG9yICYmIGlzX2NvbG9yZWQgKENfQ0FQKTsKIAogICBpZiAo ZGlyZWQpCiAgICAgewpAQCAtMzA2NiwyMiArMzA4NSwxMSBAQCBwcmludF9kaXIgKGNoYXIg Y29uc3QgKm5hbWUsIGNoYXIgY29uc3QgKnJlYWxuYW1lLCBib29sIGNvbW1hbmRfbGluZV9h cmcpCiAgICAgICAgIHsKICAgICAgICAgICBpZiAoISBmaWxlX2lnbm9yZWQgKG5leHQtPmRf bmFtZSkpCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgIGVudW0gZmlsZXR5cGUgdHlw ZSA9IHVua25vd247Ci0KKyAgICAgICAgICAgICAgZW51bSBmaWxldHlwZSB0eXBlOwogI2lm IEhBVkVfU1RSVUNUX0RJUkVOVF9EX1RZUEUKLSAgICAgICAgICAgICAgc3dpdGNoIChuZXh0 LT5kX3R5cGUpCi0gICAgICAgICAgICAgICAgewotICAgICAgICAgICAgICAgIGNhc2UgRFRf QkxLOiAgdHlwZSA9IGJsb2NrZGV2OwkJYnJlYWs7Ci0gICAgICAgICAgICAgICAgY2FzZSBE VF9DSFI6ICB0eXBlID0gY2hhcmRldjsJCWJyZWFrOwotICAgICAgICAgICAgICAgIGNhc2Ug RFRfRElSOiAgdHlwZSA9IGRpcmVjdG9yeTsJCWJyZWFrOwotICAgICAgICAgICAgICAgIGNh c2UgRFRfRklGTzogdHlwZSA9IGZpZm87CQlicmVhazsKLSAgICAgICAgICAgICAgICBjYXNl IERUX0xOSzogIHR5cGUgPSBzeW1ib2xpY19saW5rOwlicmVhazsKLSAgICAgICAgICAgICAg ICBjYXNlIERUX1JFRzogIHR5cGUgPSBub3JtYWw7CQlicmVhazsKLSAgICAgICAgICAgICAg ICBjYXNlIERUX1NPQ0s6IHR5cGUgPSBzb2NrOwkJYnJlYWs7Ci0jIGlmZGVmIERUX1dIVAot ICAgICAgICAgICAgICAgIGNhc2UgRFRfV0hUOiAgdHlwZSA9IHdoaXRlb3V0OwkJYnJlYWs7 Ci0jIGVuZGlmCi0gICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICB0eXBlID0gZF90 eXBlX2ZpbGV0eXBlW25leHQtPmRfdHlwZV07CisjZWxzZQorICAgICAgICAgICAgICB0eXBl ID0gdW5rbm93bjsKICNlbmRpZgogICAgICAgICAgICAgICB0b3RhbF9ibG9ja3MgKz0gZ29i YmxlX2ZpbGUgKG5leHQtPmRfbmFtZSwgdHlwZSwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBSRUxJQUJMRV9EX0lOTyAobmV4dCksCkBAIC0zMjk0LDcg KzMzMDIsNyBAQCBmaWxlX2hhc19hY2xpbmZvX2NhY2hlIChjaGFyIGNvbnN0ICpmaWxlLCBz dHJ1Y3QgZmlsZWluZm8gKmYsCiAgICAgICByZXR1cm4gMDsKICAgICB9CiAKLSAgaW50IG4g PSBmaWxlX2hhc19hY2xpbmZvIChmaWxlLCAmZi0+c3RhdCwgYWksIGZsYWdzKTsKKyAgaW50 IG4gPSBmaWxlX2hhc19hY2xpbmZvIChmaWxlLCBhaSwgZmxhZ3MpOwogICBpZiAobiA8PSAw ICYmIGVycm5vX3Vuc3VwcG9ydGVkIChhaS0+dS5lcnIpKQogICAgIHVuc3VwcG9ydGVkX2Rl dmljZSA9IGYtPnN0YXQuc3RfZGV2OwogICByZXR1cm4gbjsKQEAgLTMzNTUsNiArMzM2Myw3 IEBAIGdvYmJsZV9maWxlIChjaGFyIGNvbnN0ICpuYW1lLCBlbnVtIGZpbGV0eXBlIHR5cGUs IGlub190IGlub2RlLAogICBtZW1zZXQgKGYsICdcMCcsIHNpemVvZiAqZik7CiAgIGYtPnN0 YXQuc3RfaW5vID0gaW5vZGU7CiAgIGYtPmZpbGV0eXBlID0gdHlwZTsKKyAgZi0+c2NvbnRl eHQgPSBVTktOT1dOX1NFQ1VSSVRZX0NPTlRFWFQ7CiAKICAgZi0+cXVvdGVkID0gLTE7CiAg IGlmICgoISBjd2Rfc29tZV9xdW90ZWQpICYmIGFsaWduX3ZhcmlhYmxlX291dGVyX3F1b3Rl cykKQEAgLTMzNjUsMTMgKzMzNzQsMTQgQEAgZ29iYmxlX2ZpbGUgKGNoYXIgY29uc3QgKm5h bWUsIGVudW0gZmlsZXR5cGUgdHlwZSwgaW5vX3QgaW5vZGUsCiAgICAgICAgIGN3ZF9zb21l X3F1b3RlZCA9IDE7CiAgICAgfQogCi0gIGlmIChjb21tYW5kX2xpbmVfYXJnCisgIGJvb2wg Y2hlY2tfc3RhdCA9CisgICAgIChjb21tYW5kX2xpbmVfYXJnCiAgICAgICB8fCBwcmludF9o eXBlcmxpbmsKICAgICAgIHx8IGZvcm1hdF9uZWVkc19zdGF0Ci0gICAgICAvKiBXaGVuIGNv bG9yaW5nIGEgZGlyZWN0b3J5ICh3ZSBtYXkga25vdyB0aGUgdHlwZSBmcm9tCi0gICAgICAg ICBkaXJlY3QuZF90eXBlKSwgd2UgaGF2ZSB0byBzdGF0IGl0IGluIG9yZGVyIHRvIGluZGlj YXRlCisgICAgICB8fCAoZm9ybWF0X25lZWRzX3R5cGUgJiYgdHlwZSA9PSB1bmtub3duKQor ICAgICAgLyogV2hlbiBjb2xvcmluZyBhIGRpcmVjdG9yeSwgc3RhdCBpdCB0byBpbmRpY2F0 ZQogICAgICAgICAgc3RpY2t5IGFuZC9vciBvdGhlci13cml0YWJsZSBhdHRyaWJ1dGVzLiAg Ki8KLSAgICAgIHx8ICh0eXBlID09IGRpcmVjdG9yeSAmJiBwcmludF93aXRoX2NvbG9yCisg ICAgICB8fCAoKHR5cGUgPT0gZGlyZWN0b3J5IHx8IHR5cGUgPT0gdW5rbm93bikgJiYgcHJp bnRfd2l0aF9jb2xvcgogICAgICAgICAgICYmIChpc19jb2xvcmVkIChDX09USEVSX1dSSVRB QkxFKQogICAgICAgICAgICAgICB8fCBpc19jb2xvcmVkIChDX1NUSUNLWSkKICAgICAgICAg ICAgICAgfHwgaXNfY29sb3JlZCAoQ19TVElDS1lfT1RIRVJfV1JJVEFCTEUpKSkKQEAgLTMz ODQsNDAgKzMzOTQsMzQgQEAgZ29iYmxlX2ZpbGUgKGNoYXIgY29uc3QgKm5hbWUsIGVudW0g ZmlsZXR5cGUgdHlwZSwgaW5vX3QgaW5vZGUsCiAgICAgICAvKiBDb21tYW5kIGxpbmUgZGVy ZWZlcmVuY2VzIGFyZSBhbHJlYWR5IHRha2VuIGNhcmUgb2YgYnkgdGhlIGFib3ZlCiAgICAg ICAgICBhc3NlcnRpb24gdGhhdCB0aGUgaW5vZGUgbnVtYmVyIGlzIG5vdCB5ZXQga25vd24u ICAqLwogICAgICAgfHwgKHByaW50X2lub2RlICYmIGlub2RlID09IE5PVF9BTl9JTk9ERV9O VU1CRVIpCi0gICAgICB8fCAoZm9ybWF0X25lZWRzX3R5cGUKLSAgICAgICAgICAmJiAodHlw ZSA9PSB1bmtub3duCi0gICAgICAgICAgICAgIC8qIC0taW5kaWNhdG9yLXN0eWxlPWNsYXNz aWZ5IChha2EgLUYpCi0gICAgICAgICAgICAgICAgIHJlcXVpcmVzIHRoYXQgd2Ugc3RhdCBl YWNoIHJlZ3VsYXIgZmlsZQotICAgICAgICAgICAgICAgICB0byBzZWUgaWYgaXQncyBleGVj dXRhYmxlLiAgKi8KLSAgICAgICAgICAgICAgfHwgKHR5cGUgPT0gbm9ybWFsICYmIChpbmRp Y2F0b3Jfc3R5bGUgPT0gY2xhc3NpZnkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAvKiBUaGlzIGlzIHNvIHRoYXQgLS1jb2xvciBlbmRzIHVwCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaGlnaGxpZ2h0aW5nIGZpbGVzIHdpdGgg dGhlc2UgbW9kZQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJp dHMgc2V0IGV2ZW4gd2hlbiBvcHRpb25zIGxpa2UgLUYgYXJlCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbm90IHNwZWNpZmllZC4gIE5vdGUgd2UgZG8gYSBy ZWR1bmRhbnQKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0 IGluIHRoZSB2ZXJ5IHVubGlrZWx5IGNhc2Ugd2hlcmUKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBDX0NBUCBpcyBzZXQgYnV0IG5vdCB0aGUgb3RoZXJzLiAq LwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHx8IChwcmludF93aXRo X2NvbG9yCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICYmIChp c19jb2xvcmVkIChDX0VYRUMpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8fCBpc19jb2xvcmVkIChDX1NFVFVJRCkKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHx8IGlzX2NvbG9yZWQgKENfU0VUR0lEKQot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfHwgaXNfY29s b3JlZCAoQ19DQVApKSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAp KSkpKQorICAgICAgLyogLS1pbmRpY2F0b3Itc3R5bGU9Y2xhc3NpZnkgKGFrYSAtRikgcmVx dWlyZXMgc3RhdHRpbmcgZWFjaAorICAgICAgICAgcmVndWxhciBmaWxlIHRvIHNlZSB3aGV0 aGVyIGl0J3MgZXhlY3V0YWJsZS4gICovCisgICAgICB8fCAoKHR5cGUgPT0gbm9ybWFsIHx8 IHR5cGUgPT0gdW5rbm93bikKKyAgICAgICAgICAmJiAoaW5kaWNhdG9yX3N0eWxlID09IGNs YXNzaWZ5CisgICAgICAgICAgICAgIC8qIFRoaXMgaXMgc28gdGhhdCAtLWNvbG9yIGVuZHMg dXAgaGlnaGxpZ2h0aW5nIGZpbGVzIHdpdGggdGhlc2UKKyAgICAgICAgICAgICAgICAgbW9k ZSBiaXRzIHNldCBldmVuIHdoZW4gb3B0aW9ucyBsaWtlIC1GIGFyZSBub3Qgc3BlY2lmaWVk LiAgKi8KKyAgICAgICAgICAgICAgfHwgKHByaW50X3dpdGhfY29sb3IgJiYgKGlzX2NvbG9y ZWQgKENfRVhFQykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHx8 IGlzX2NvbG9yZWQgKENfU0VUVUlEKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgfHwgaXNfY29sb3JlZCAoQ19TRVRHSUQpKSkpKSk7CisKKyAgLyogQWJzb2x1 dGUgbmFtZSBvZiB0aGlzIGZpbGUsIGlmIG5lZWRlZC4gICovCisgIGNoYXIgY29uc3QgKmZ1 bGxfbmFtZSA9IG5hbWU7CisgIGlmIChjaGVja19zdGF0IHwgcHJpbnRfc2NvbnRleHQgfCBm b3JtYXRfbmVlZHNfY2FwYWJpbGl0eQorICAgICAgJiYgbmFtZVswXSAhPSAnLycgJiYgZGly bmFtZSkKKyAgICB7CisgICAgICBjaGFyICpwID0gYWxsb2NhIChzdHJsZW4gKG5hbWUpICsg c3RybGVuIChkaXJuYW1lKSArIDIpOworICAgICAgYXR0YWNoIChwLCBkaXJuYW1lLCBuYW1l KTsKKyAgICAgIGZ1bGxfbmFtZSA9IHA7CisgICAgfQorCisgIGJvb2wgZG9fZGVyZWY7CiAK KyAgaWYgKCFjaGVja19zdGF0KQorICAgIGRvX2RlcmVmID0gZGVyZWZlcmVuY2UgPT0gREVS RUZfQUxXQVlTOworICBlbHNlCiAgICAgewotICAgICAgLyogQWJzb2x1dGUgbmFtZSBvZiB0 aGlzIGZpbGUuICAqLwotICAgICAgY2hhciBjb25zdCAqZnVsbF9uYW1lOwotICAgICAgYm9v bCBkb19kZXJlZjsKICAgICAgIGludCBlcnI7CiAKLSAgICAgIGlmIChuYW1lWzBdID09ICcv JyB8fCAhZGlybmFtZSkKLSAgICAgICAgZnVsbF9uYW1lID0gbmFtZTsKLSAgICAgIGVsc2UK LSAgICAgICAgewotICAgICAgICAgIGNoYXIgKnAgPSBhbGxvY2EgKHN0cmxlbiAobmFtZSkg KyBzdHJsZW4gKGRpcm5hbWUpICsgMik7Ci0gICAgICAgICAgYXR0YWNoIChwLCBkaXJuYW1l LCBuYW1lKTsKLSAgICAgICAgICBmdWxsX25hbWUgPSBwOwotICAgICAgICB9Ci0KICAgICAg IGlmIChwcmludF9oeXBlcmxpbmspCiAgICAgICAgIHsKICAgICAgICAgICBmLT5hYnNvbHV0 ZV9uYW1lID0gY2Fub25pY2FsaXplX2ZpbGVuYW1lX21vZGUgKGZ1bGxfbmFtZSwKQEAgLTM0 NzMsOCArMzQ3Nyw2IEBAIGdvYmJsZV9maWxlIChjaGFyIGNvbnN0ICpuYW1lLCBlbnVtIGZp bGV0eXBlIHR5cGUsIGlub190IGlub2RlLAogICAgICAgICAgIGZpbGVfZmFpbHVyZSAoY29t bWFuZF9saW5lX2FyZywKICAgICAgICAgICAgICAgICAgICAgICAgIF8oImNhbm5vdCBhY2Nl c3MgJXMiKSwgZnVsbF9uYW1lKTsKIAotICAgICAgICAgIGYtPnNjb250ZXh0ID0gVU5LTk9X Tl9TRUNVUklUWV9DT05URVhUOwotCiAgICAgICAgICAgaWYgKGNvbW1hbmRfbGluZV9hcmcp CiAgICAgICAgICAgICByZXR1cm4gMDsKIApAQCAtMzQ4NSwxNTUgKzM0ODcsMTQ5IEBAIGdv YmJsZV9maWxlIChjaGFyIGNvbnN0ICpuYW1lLCBlbnVtIGZpbGV0eXBlIHR5cGUsIGlub190 IGlub2RlLAogICAgICAgICB9CiAKICAgICAgIGYtPnN0YXRfb2sgPSB0cnVlOworICAgICAg Zi0+ZmlsZXR5cGUgPSB0eXBlID0gZF90eXBlX2ZpbGV0eXBlW0lGVE9EVCAoZi0+c3RhdC5z dF9tb2RlKV07CisgICAgfQogCi0gICAgICAvKiBoYXNfY2FwYWJpbGl0eSBhZGRzIGFyb3Vu ZCAzMCUgcnVudGltZSB0byAnbHMgLS1jb2xvcicsCi0gICAgICAgICAgc28gY2FsbCBpdCBv bmx5IGlmIHJlYWxseSBuZWVkZWQuICBOb3RlIGNhcGFiaWxpdHkgY29sb3JpbmcKLSAgICAg ICAgICBpcyBkaXNhYmxlZCBpbiB0aGUgZGVmYXVsdCBjb2xvciBjb25maWcuICAqLwotICAg ICAgaWYgKCh0eXBlID09IG5vcm1hbCB8fCBTX0lTUkVHIChmLT5zdGF0LnN0X21vZGUpKQot ICAgICAgICAgICYmIHByaW50X3dpdGhfY29sb3IgJiYgaXNfY29sb3JlZCAoQ19DQVApKQot ICAgICAgICBmLT5oYXNfY2FwYWJpbGl0eSA9IGhhc19jYXBhYmlsaXR5X2NhY2hlIChmdWxs X25hbWUsIGYpOworICBpZiAodHlwZSA9PSBkaXJlY3RvcnkgJiYgY29tbWFuZF9saW5lX2Fy ZyAmJiAhaW1tZWRpYXRlX2RpcnMpCisgICAgZi0+ZmlsZXR5cGUgPSB0eXBlID0gYXJnX2Rp cmVjdG9yeTsKIAotICAgICAgaWYgKGZvcm1hdCA9PSBsb25nX2Zvcm1hdCB8fCBwcmludF9z Y29udGV4dCkKLSAgICAgICAgewotICAgICAgICAgIHN0cnVjdCBhY2xpbmZvIGFpOwotICAg ICAgICAgIGludCBuID0gZmlsZV9oYXNfYWNsaW5mb19jYWNoZSAoZnVsbF9uYW1lLCBmLCAm YWksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb19kZXJl ZiA/IEFDTF9TWU1MSU5LX0ZPTExPVyA6IDApOwotICAgICAgICAgIGJvb2wgaGF2ZV9hY2wg PSAwIDwgbjsKLSAgICAgICAgICBib29sIGhhdmVfc2NvbnRleHQgPSAhYWkuc2NvbnRleHRf ZXJyOwotICAgICAgICAgIGYtPmFjbF90eXBlID0gKCFoYXZlX3Njb250ZXh0ICYmICFoYXZl X2FjbAotICAgICAgICAgICAgICAgICAgICAgICAgID8gQUNMX1RfTk9ORQotICAgICAgICAg ICAgICAgICAgICAgICAgIDogKGhhdmVfc2NvbnRleHQgJiYgIWhhdmVfYWNsCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgPyBBQ0xfVF9MU01fQ09OVEVYVF9PTkxZCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgOiBBQ0xfVF9ZRVMpKTsKLSAgICAgICAgICBhbnlfaGFz X2FjbCB8PSBmLT5hY2xfdHlwZSAhPSBBQ0xfVF9OT05FOwotCi0gICAgICAgICAgaWYgKGZv cm1hdCA9PSBsb25nX2Zvcm1hdCAmJiBuIDwgMCkKLSAgICAgICAgICAgIGVycm9yICgwLCBh aS51LmVyciwgIiVzIiwgcXVvdGVmIChmdWxsX25hbWUpKTsKLSAgICAgICAgICBlbHNlCi0g ICAgICAgICAgICB7Ci0gICAgICAgICAgICAgIC8qIFdoZW4gcmVxdWVzdGluZyBzZWN1cml0 eSBjb250ZXh0IGluZm9ybWF0aW9uLCBkb24ndCBtYWtlCi0gICAgICAgICAgICAgICAgIGxz IGZhaWwganVzdCBiZWNhdXNlIHRoZSBmaWxlIChldmVuIGEgY29tbWFuZCBsaW5lIGFyZ3Vt ZW50KQotICAgICAgICAgICAgICAgICBpc24ndCBvbiB0aGUgcmlnaHQgdHlwZSBvZiBmaWxl IHN5c3RlbS4gIEkuZS4sIGEgZ2V0ZmlsZWNvbgotICAgICAgICAgICAgICAgICBmYWlsdXJl IGlzbid0IGluIHRoZSBzYW1lIGNsYXNzIGFzIGEgc3RhdCBmYWlsdXJlLiAgKi8KLSAgICAg ICAgICAgICAgaWYgKHByaW50X3Njb250ZXh0Ci0gICAgICAgICAgICAgICAgICAmJiAoISAo aXNfRU5PVFNVUCAoYWkuc2NvbnRleHRfZXJyKQotICAgICAgICAgICAgICAgICAgICAgICAg IHx8IGFpLnNjb250ZXh0X2VyciA9PSBFTk9EQVRBKSkpCi0gICAgICAgICAgICAgICAgZXJy b3IgKDAsIGFpLnNjb250ZXh0X2VyciwgIiVzIiwgcXVvdGVmIChmdWxsX25hbWUpKTsKLSAg ICAgICAgICAgIH0KKyAgYm9vbCBjaGVja19jYXBhYmlsaXR5ID0gZm9ybWF0X25lZWRzX2Nh cGFiaWxpdHkgJiAodHlwZSA9PSBub3JtYWwpOwogCi0gICAgICAgICAgZi0+c2NvbnRleHQg PSBhaS5zY29udGV4dDsKLSAgICAgICAgICBhaS5zY29udGV4dCA9IG51bGxwdHI7Ci0gICAg ICAgICAgYWNsaW5mb19mcmVlICgmYWkpOworICBpZiAoKGZvcm1hdCA9PSBsb25nX2Zvcm1h dCkgfCBwcmludF9zY29udGV4dCB8IGNoZWNrX2NhcGFiaWxpdHkpCisgICAgeworICAgICAg c3RydWN0IGFjbGluZm8gYWk7CisgICAgICBpbnQgbiA9IGZpbGVfaGFzX2FjbGluZm9fY2Fj aGUgKGZ1bGxfbmFtZSwgZiwgJmFpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoKGRvX2RlcmVmID8gQUNMX1NZTUxJTktfRk9MTE9XIDogMCkKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgZmlsZXR5cGVfZF90eXBlW3R5cGVd KSk7CisgICAgICBib29sIGhhdmVfYWNsID0gMCA8IG47CisgICAgICBib29sIGhhdmVfc2Nv bnRleHQgPSAhYWkuc2NvbnRleHRfZXJyOworICAgICAgZi0+YWNsX3R5cGUgPSAoIWhhdmVf c2NvbnRleHQgJiYgIWhhdmVfYWNsCisgICAgICAgICAgICAgICAgICAgICA/IEFDTF9UX05P TkUKKyAgICAgICAgICAgICAgICAgICAgIDogKGhhdmVfc2NvbnRleHQgJiYgIWhhdmVfYWNs CisgICAgICAgICAgICAgICAgICAgICAgICA/IEFDTF9UX0xTTV9DT05URVhUX09OTFkKKyAg ICAgICAgICAgICAgICAgICAgICAgIDogQUNMX1RfWUVTKSk7CisgICAgICBhbnlfaGFzX2Fj bCB8PSBmLT5hY2xfdHlwZSAhPSBBQ0xfVF9OT05FOworCisgICAgICBpZiAoZm9ybWF0ID09 IGxvbmdfZm9ybWF0ICYmIG4gPCAwKQorICAgICAgICBlcnJvciAoMCwgYWkudS5lcnIsICIl cyIsIHF1b3RlZiAoZnVsbF9uYW1lKSk7CisgICAgICBlbHNlCisgICAgICAgIHsKKyAgICAg ICAgICAvKiBXaGVuIHJlcXVlc3Rpbmcgc2VjdXJpdHkgY29udGV4dCBpbmZvcm1hdGlvbiwg ZG9uJ3QgbWFrZQorICAgICAgICAgICAgIGxzIGZhaWwganVzdCBiZWNhdXNlIHRoZSBmaWxl IChldmVuIGEgY29tbWFuZCBsaW5lIGFyZ3VtZW50KQorICAgICAgICAgICAgIGlzbid0IG9u IHRoZSByaWdodCB0eXBlIG9mIGZpbGUgc3lzdGVtLiAgSS5lLiwgYSBnZXRmaWxlY29uCisg ICAgICAgICAgICAgZmFpbHVyZSBpc24ndCBpbiB0aGUgc2FtZSBjbGFzcyBhcyBhIHN0YXQg ZmFpbHVyZS4gICovCisgICAgICAgICAgaWYgKHByaW50X3Njb250ZXh0CisgICAgICAgICAg ICAgICYmICghIChpc19FTk9UU1VQIChhaS5zY29udGV4dF9lcnIpCisgICAgICAgICAgICAg ICAgICAgICB8fCBhaS5zY29udGV4dF9lcnIgPT0gRU5PREFUQSkpKQorICAgICAgICAgICAg ZXJyb3IgKDAsIGFpLnNjb250ZXh0X2VyciwgIiVzIiwgcXVvdGVmIChmdWxsX25hbWUpKTsK ICAgICAgICAgfQogCi0gICAgICBpZiAoU19JU0xOSyAoZi0+c3RhdC5zdF9tb2RlKQotICAg ICAgICAgICYmIChmb3JtYXQgPT0gbG9uZ19mb3JtYXQgfHwgY2hlY2tfc3ltbGlua19tb2Rl KSkKLSAgICAgICAgewotICAgICAgICAgIHN0cnVjdCBzdGF0IGxpbmtzdGF0czsKKyAgICAg IC8qIGhhc19jYXBhYmlsaXR5IGFkZHMgYXJvdW5kIDMwJSBydW50aW1lIHRvICdscyAtLWNv bG9yJywKKyAgICAgICAgIHNvIGNhbGwgaXQgb25seSBpZiByZWFsbHkgbmVlZGVkLiAgTm90 ZSBjYXBhYmlsaXR5IGNvbG9yaW5nCisgICAgICAgICBpcyBkaXNhYmxlZCBpbiB0aGUgZGVm YXVsdCBjb2xvciBjb25maWcuICAqLworICAgICAgaWYgKGNoZWNrX2NhcGFiaWxpdHkgJiYg YWNsaW5mb19oYXNfeGF0dHIgKCZhaSwgWEFUVFJfTkFNRV9DQVBTKSkKKyAgICAgICAgZi0+ aGFzX2NhcGFiaWxpdHkgPSBoYXNfY2FwYWJpbGl0eV9jYWNoZSAoZnVsbF9uYW1lLCBmKTsK KworICAgICAgZi0+c2NvbnRleHQgPSBhaS5zY29udGV4dDsKKyAgICAgIGFpLnNjb250ZXh0 ID0gbnVsbHB0cjsKKyAgICAgIGFjbGluZm9fZnJlZSAoJmFpKTsKKyAgICB9CiAKLSAgICAg ICAgICBnZXRfbGlua19uYW1lIChmdWxsX25hbWUsIGYsIGNvbW1hbmRfbGluZV9hcmcpOwor ICBpZiAoKHR5cGUgPT0gc3ltYm9saWNfbGluaykKKyAgICAgICYgKChmb3JtYXQgPT0gbG9u Z19mb3JtYXQpIHwgY2hlY2tfc3ltbGlua19tb2RlKSkKKyAgICB7CisgICAgICBzdHJ1Y3Qg c3RhdCBsaW5rc3RhdHM7CiAKLSAgICAgICAgICAvKiBVc2UgdGhlIHNsb3dlciBxdW90aW5n IHBhdGggZm9yIHRoaXMgZW50cnksIHRob3VnaAotICAgICAgICAgICAgIGRvbid0IHVwZGF0 ZSBDV0RfU09NRV9RVU9URUQgc2luY2UgYWxpZ25tZW50IG5vdCBhZmZlY3RlZC4gICovCi0g ICAgICAgICAgaWYgKGYtPmxpbmtuYW1lICYmIGYtPnF1b3RlZCA9PSAwICYmIG5lZWRzX3F1 b3RpbmcgKGYtPmxpbmtuYW1lKSkKLSAgICAgICAgICAgIGYtPnF1b3RlZCA9IC0xOworICAg ICAgZ2V0X2xpbmtfbmFtZSAoZnVsbF9uYW1lLCBmLCBjb21tYW5kX2xpbmVfYXJnKTsKIAot ICAgICAgICAgIC8qIEF2b2lkIGZvbGxvd2luZyBzeW1ib2xpYyBsaW5rcyB3aGVuIHBvc3Np YmxlLCBpLmUuLCB3aGVuCi0gICAgICAgICAgICAgdGhleSB3b24ndCBiZSB0cmFjZWQgYW5k IHdoZW4gbm8gaW5kaWNhdG9yIGlzIG5lZWRlZC4gICovCi0gICAgICAgICAgaWYgKGYtPmxp bmtuYW1lCi0gICAgICAgICAgICAgICYmIChmaWxlX3R5cGUgPD0gaW5kaWNhdG9yX3N0eWxl IHx8IGNoZWNrX3N5bWxpbmtfbW9kZSkKLSAgICAgICAgICAgICAgJiYgc3RhdF9mb3JfbW9k ZSAoZnVsbF9uYW1lLCAmbGlua3N0YXRzKSA9PSAwKQotICAgICAgICAgICAgewotICAgICAg ICAgICAgICBmLT5saW5rb2sgPSB0cnVlOwotICAgICAgICAgICAgICBmLT5saW5rbW9kZSA9 IGxpbmtzdGF0cy5zdF9tb2RlOwotICAgICAgICAgICAgfQorICAgICAgLyogVXNlIHRoZSBz bG93ZXIgcXVvdGluZyBwYXRoIGZvciB0aGlzIGVudHJ5LCB0aG91Z2gKKyAgICAgICAgIGRv bid0IHVwZGF0ZSBDV0RfU09NRV9RVU9URUQgc2luY2UgYWxpZ25tZW50IG5vdCBhZmZlY3Rl ZC4gICovCisgICAgICBpZiAoZi0+bGlua25hbWUgJiYgZi0+cXVvdGVkID09IDAgJiYgbmVl ZHNfcXVvdGluZyAoZi0+bGlua25hbWUpKQorICAgICAgICBmLT5xdW90ZWQgPSAtMTsKKwor ICAgICAgLyogQXZvaWQgZm9sbG93aW5nIHN5bWJvbGljIGxpbmtzIHdoZW4gcG9zc2libGUs IGkuZS4sIHdoZW4KKyAgICAgICAgIHRoZXkgd29uJ3QgYmUgdHJhY2VkIGFuZCB3aGVuIG5v IGluZGljYXRvciBpcyBuZWVkZWQuICAqLworICAgICAgaWYgKGYtPmxpbmtuYW1lCisgICAg ICAgICAgJiYgKGZpbGVfdHlwZSA8PSBpbmRpY2F0b3Jfc3R5bGUgfHwgY2hlY2tfc3ltbGlu a19tb2RlKQorICAgICAgICAgICYmIHN0YXRfZm9yX21vZGUgKGZ1bGxfbmFtZSwgJmxpbmtz dGF0cykgPT0gMCkKKyAgICAgICAgeworICAgICAgICAgIGYtPmxpbmtvayA9IHRydWU7Cisg ICAgICAgICAgZi0+bGlua21vZGUgPSBsaW5rc3RhdHMuc3RfbW9kZTsKICAgICAgICAgfQor ICAgIH0KKworICBibG9ja3MgPSBTVFBfTkJMT0NLUyAoJmYtPnN0YXQpOworICBpZiAoZm9y bWF0ID09IGxvbmdfZm9ybWF0IHx8IHByaW50X2Jsb2NrX3NpemUpCisgICAgeworICAgICAg Y2hhciBidWZbTE9OR0VTVF9IVU1BTl9SRUFEQUJMRSArIDFdOworICAgICAgaW50IGxlbiA9 IG1ic3dpZHRoIChodW1hbl9yZWFkYWJsZSAoYmxvY2tzLCBidWYsIGh1bWFuX291dHB1dF9v cHRzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU1RfTkJM T0NLU0laRSwgb3V0cHV0X2Jsb2NrX3NpemUpLAorICAgICAgICAgICAgICAgICAgICAgICAg ICBNQlNXSURUSF9GTEFHUyk7CisgICAgICBpZiAoYmxvY2tfc2l6ZV93aWR0aCA8IGxlbikK KyAgICAgICAgYmxvY2tfc2l6ZV93aWR0aCA9IGxlbjsKKyAgICB9CiAKLSAgICAgIGlmIChT X0lTTE5LIChmLT5zdGF0LnN0X21vZGUpKQotICAgICAgICBmLT5maWxldHlwZSA9IHN5bWJv bGljX2xpbms7Ci0gICAgICBlbHNlIGlmIChTX0lTRElSIChmLT5zdGF0LnN0X21vZGUpKQor ICBpZiAoZm9ybWF0ID09IGxvbmdfZm9ybWF0KQorICAgIHsKKyAgICAgIGlmIChwcmludF9v d25lcikKICAgICAgICAgewotICAgICAgICAgIGlmIChjb21tYW5kX2xpbmVfYXJnICYmICFp bW1lZGlhdGVfZGlycykKLSAgICAgICAgICAgIGYtPmZpbGV0eXBlID0gYXJnX2RpcmVjdG9y eTsKLSAgICAgICAgICBlbHNlCi0gICAgICAgICAgICBmLT5maWxldHlwZSA9IGRpcmVjdG9y eTsKKyAgICAgICAgICBpbnQgbGVuID0gZm9ybWF0X3VzZXJfd2lkdGggKGYtPnN0YXQuc3Rf dWlkKTsKKyAgICAgICAgICBpZiAob3duZXJfd2lkdGggPCBsZW4pCisgICAgICAgICAgICBv d25lcl93aWR0aCA9IGxlbjsKICAgICAgICAgfQotICAgICAgZWxzZQotICAgICAgICBmLT5m aWxldHlwZSA9IG5vcm1hbDsKIAotICAgICAgYmxvY2tzID0gU1RQX05CTE9DS1MgKCZmLT5z dGF0KTsKLSAgICAgIGlmIChmb3JtYXQgPT0gbG9uZ19mb3JtYXQgfHwgcHJpbnRfYmxvY2tf c2l6ZSkKKyAgICAgIGlmIChwcmludF9ncm91cCkKICAgICAgICAgewotICAgICAgICAgIGNo YXIgYnVmW0xPTkdFU1RfSFVNQU5fUkVBREFCTEUgKyAxXTsKLSAgICAgICAgICBpbnQgbGVu ID0gbWJzd2lkdGggKGh1bWFuX3JlYWRhYmxlIChibG9ja3MsIGJ1ZiwgaHVtYW5fb3V0cHV0 X29wdHMsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg U1RfTkJMT0NLU0laRSwgb3V0cHV0X2Jsb2NrX3NpemUpLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgTUJTV0lEVEhfRkxBR1MpOwotICAgICAgICAgIGlmIChibG9ja19zaXpl X3dpZHRoIDwgbGVuKQotICAgICAgICAgICAgYmxvY2tfc2l6ZV93aWR0aCA9IGxlbjsKKyAg ICAgICAgICBpbnQgbGVuID0gZm9ybWF0X2dyb3VwX3dpZHRoIChmLT5zdGF0LnN0X2dpZCk7 CisgICAgICAgICAgaWYgKGdyb3VwX3dpZHRoIDwgbGVuKQorICAgICAgICAgICAgZ3JvdXBf d2lkdGggPSBsZW47CiAgICAgICAgIH0KIAotICAgICAgaWYgKGZvcm1hdCA9PSBsb25nX2Zv cm1hdCkKKyAgICAgIGlmIChwcmludF9hdXRob3IpCiAgICAgICAgIHsKLSAgICAgICAgICBp ZiAocHJpbnRfb3duZXIpCi0gICAgICAgICAgICB7Ci0gICAgICAgICAgICAgIGludCBsZW4g PSBmb3JtYXRfdXNlcl93aWR0aCAoZi0+c3RhdC5zdF91aWQpOwotICAgICAgICAgICAgICBp ZiAob3duZXJfd2lkdGggPCBsZW4pCi0gICAgICAgICAgICAgICAgb3duZXJfd2lkdGggPSBs ZW47Ci0gICAgICAgICAgICB9CisgICAgICAgICAgaW50IGxlbiA9IGZvcm1hdF91c2VyX3dp ZHRoIChmLT5zdGF0LnN0X2F1dGhvcik7CisgICAgICAgICAgaWYgKGF1dGhvcl93aWR0aCA8 IGxlbikKKyAgICAgICAgICAgIGF1dGhvcl93aWR0aCA9IGxlbjsKKyAgICAgICAgfQorICAg IH0KIAotICAgICAgICAgIGlmIChwcmludF9ncm91cCkKLSAgICAgICAgICAgIHsKLSAgICAg ICAgICAgICAgaW50IGxlbiA9IGZvcm1hdF9ncm91cF93aWR0aCAoZi0+c3RhdC5zdF9naWQp OwotICAgICAgICAgICAgICBpZiAoZ3JvdXBfd2lkdGggPCBsZW4pCi0gICAgICAgICAgICAg ICAgZ3JvdXBfd2lkdGggPSBsZW47Ci0gICAgICAgICAgICB9CisgIGlmIChwcmludF9zY29u dGV4dCkKKyAgICB7CisgICAgICBpbnQgbGVuID0gc3RybGVuIChmLT5zY29udGV4dCk7Cisg ICAgICBpZiAoc2NvbnRleHRfd2lkdGggPCBsZW4pCisgICAgICAgIHNjb250ZXh0X3dpZHRo ID0gbGVuOworICAgIH0KIAotICAgICAgICAgIGlmIChwcmludF9hdXRob3IpCi0gICAgICAg ICAgICB7Ci0gICAgICAgICAgICAgIGludCBsZW4gPSBmb3JtYXRfdXNlcl93aWR0aCAoZi0+ c3RhdC5zdF9hdXRob3IpOwotICAgICAgICAgICAgICBpZiAoYXV0aG9yX3dpZHRoIDwgbGVu KQotICAgICAgICAgICAgICAgIGF1dGhvcl93aWR0aCA9IGxlbjsKLSAgICAgICAgICAgIH0K LSAgICAgICAgfQorICBpZiAoZm9ybWF0ID09IGxvbmdfZm9ybWF0KQorICAgIHsKKyAgICAg IGNoYXIgYltJTlRfQlVGU0laRV9CT1VORCAodWludG1heF90KV07CisgICAgICBpbnQgYl9s ZW4gPSBzdHJsZW4gKHVtYXh0b3N0ciAoZi0+c3RhdC5zdF9ubGluaywgYikpOworICAgICAg aWYgKG5saW5rX3dpZHRoIDwgYl9sZW4pCisgICAgICAgIG5saW5rX3dpZHRoID0gYl9sZW47 CiAKLSAgICAgIGlmIChwcmludF9zY29udGV4dCkKKyAgICAgIGlmICgodHlwZSA9PSBjaGFy ZGV2KSB8ICh0eXBlID09IGJsb2NrZGV2KSkKICAgICAgICAgewotICAgICAgICAgIGludCBs ZW4gPSBzdHJsZW4gKGYtPnNjb250ZXh0KTsKLSAgICAgICAgICBpZiAoc2NvbnRleHRfd2lk dGggPCBsZW4pCi0gICAgICAgICAgICBzY29udGV4dF93aWR0aCA9IGxlbjsKKyAgICAgICAg ICBjaGFyIGJ1ZltJTlRfQlVGU0laRV9CT1VORCAodWludG1heF90KV07CisgICAgICAgICAg aW50IGxlbiA9IHN0cmxlbiAodW1heHRvc3RyIChtYWpvciAoZi0+c3RhdC5zdF9yZGV2KSwg YnVmKSk7CisgICAgICAgICAgaWYgKG1ham9yX2RldmljZV9udW1iZXJfd2lkdGggPCBsZW4p CisgICAgICAgICAgICBtYWpvcl9kZXZpY2VfbnVtYmVyX3dpZHRoID0gbGVuOworICAgICAg ICAgIGxlbiA9IHN0cmxlbiAodW1heHRvc3RyIChtaW5vciAoZi0+c3RhdC5zdF9yZGV2KSwg YnVmKSk7CisgICAgICAgICAgaWYgKG1pbm9yX2RldmljZV9udW1iZXJfd2lkdGggPCBsZW4p CisgICAgICAgICAgICBtaW5vcl9kZXZpY2VfbnVtYmVyX3dpZHRoID0gbGVuOworICAgICAg ICAgIGxlbiA9IG1ham9yX2RldmljZV9udW1iZXJfd2lkdGggKyAyICsgbWlub3JfZGV2aWNl X251bWJlcl93aWR0aDsKKyAgICAgICAgICBpZiAoZmlsZV9zaXplX3dpZHRoIDwgbGVuKQor ICAgICAgICAgICAgZmlsZV9zaXplX3dpZHRoID0gbGVuOwogICAgICAgICB9Ci0KLSAgICAg IGlmIChmb3JtYXQgPT0gbG9uZ19mb3JtYXQpCisgICAgICBlbHNlCiAgICAgICAgIHsKLSAg ICAgICAgICBjaGFyIGJbSU5UX0JVRlNJWkVfQk9VTkQgKHVpbnRtYXhfdCldOwotICAgICAg ICAgIGludCBiX2xlbiA9IHN0cmxlbiAodW1heHRvc3RyIChmLT5zdGF0LnN0X25saW5rLCBi KSk7Ci0gICAgICAgICAgaWYgKG5saW5rX3dpZHRoIDwgYl9sZW4pCi0gICAgICAgICAgICBu bGlua193aWR0aCA9IGJfbGVuOwotCi0gICAgICAgICAgaWYgKFNfSVNDSFIgKGYtPnN0YXQu c3RfbW9kZSkgfHwgU19JU0JMSyAoZi0+c3RhdC5zdF9tb2RlKSkKLSAgICAgICAgICAgIHsK LSAgICAgICAgICAgICAgY2hhciBidWZbSU5UX0JVRlNJWkVfQk9VTkQgKHVpbnRtYXhfdCld OwotICAgICAgICAgICAgICBpbnQgbGVuID0gc3RybGVuICh1bWF4dG9zdHIgKG1ham9yIChm LT5zdGF0LnN0X3JkZXYpLCBidWYpKTsKLSAgICAgICAgICAgICAgaWYgKG1ham9yX2Rldmlj ZV9udW1iZXJfd2lkdGggPCBsZW4pCi0gICAgICAgICAgICAgICAgbWFqb3JfZGV2aWNlX251 bWJlcl93aWR0aCA9IGxlbjsKLSAgICAgICAgICAgICAgbGVuID0gc3RybGVuICh1bWF4dG9z dHIgKG1pbm9yIChmLT5zdGF0LnN0X3JkZXYpLCBidWYpKTsKLSAgICAgICAgICAgICAgaWYg KG1pbm9yX2RldmljZV9udW1iZXJfd2lkdGggPCBsZW4pCi0gICAgICAgICAgICAgICAgbWlu b3JfZGV2aWNlX251bWJlcl93aWR0aCA9IGxlbjsKLSAgICAgICAgICAgICAgbGVuID0gbWFq b3JfZGV2aWNlX251bWJlcl93aWR0aCArIDIgKyBtaW5vcl9kZXZpY2VfbnVtYmVyX3dpZHRo OwotICAgICAgICAgICAgICBpZiAoZmlsZV9zaXplX3dpZHRoIDwgbGVuKQotICAgICAgICAg ICAgICAgIGZpbGVfc2l6ZV93aWR0aCA9IGxlbjsKLSAgICAgICAgICAgIH0KLSAgICAgICAg ICBlbHNlCi0gICAgICAgICAgICB7Ci0gICAgICAgICAgICAgIGNoYXIgYnVmW0xPTkdFU1Rf SFVNQU5fUkVBREFCTEUgKyAxXTsKLSAgICAgICAgICAgICAgdWludG1heF90IHNpemUgPSB1 bnNpZ25lZF9maWxlX3NpemUgKGYtPnN0YXQuc3Rfc2l6ZSk7Ci0gICAgICAgICAgICAgIGlu dCBsZW4gPSBtYnN3aWR0aCAoaHVtYW5fcmVhZGFibGUgKHNpemUsIGJ1ZiwKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsZV9odW1hbl9v dXRwdXRfb3B0cywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgMSwgZmlsZV9vdXRwdXRfYmxvY2tfc2l6ZSksCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgTUJTV0lEVEhfRkxBR1MpOwotICAgICAgICAgICAgICBpZiAo ZmlsZV9zaXplX3dpZHRoIDwgbGVuKQotICAgICAgICAgICAgICAgIGZpbGVfc2l6ZV93aWR0 aCA9IGxlbjsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICBjaGFyIGJ1ZltMT05HRVNUX0hV TUFOX1JFQURBQkxFICsgMV07CisgICAgICAgICAgdWludG1heF90IHNpemUgPSB1bnNpZ25l ZF9maWxlX3NpemUgKGYtPnN0YXQuc3Rfc2l6ZSk7CisgICAgICAgICAgaW50IGxlbiA9IG1i c3dpZHRoIChodW1hbl9yZWFkYWJsZSAoc2l6ZSwgYnVmLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpbGVfaHVtYW5fb3V0cHV0X29wdHMsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMSwgZmlsZV9v dXRwdXRfYmxvY2tfc2l6ZSksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBNQlNX SURUSF9GTEFHUyk7CisgICAgICAgICAgaWYgKGZpbGVfc2l6ZV93aWR0aCA8IGxlbikKKyAg ICAgICAgICAgIGZpbGVfc2l6ZV93aWR0aCA9IGxlbjsKICAgICAgICAgfQogICAgIH0KIApA QCAtNDk2OSw3ICs0OTY1LDcgQEAgZ2V0X2NvbG9yX2luZGljYXRvciAoY29uc3Qgc3RydWN0 IGZpbGVpbmZvICpmLCBib29sIHN5bWxpbmtfdGFyZ2V0KQogICAgICAgICAgICAgdHlwZSA9 IENfU0VUVUlEOwogICAgICAgICAgIGVsc2UgaWYgKChtb2RlICYgU19JU0dJRCkgIT0gMCAm JiBpc19jb2xvcmVkIChDX1NFVEdJRCkpCiAgICAgICAgICAgICB0eXBlID0gQ19TRVRHSUQ7 Ci0gICAgICAgICAgZWxzZSBpZiAoaXNfY29sb3JlZCAoQ19DQVApICYmIGYtPmhhc19jYXBh YmlsaXR5KQorICAgICAgICAgIGVsc2UgaWYgKGYtPmhhc19jYXBhYmlsaXR5KQogICAgICAg ICAgICAgdHlwZSA9IENfQ0FQOwogICAgICAgICAgIGVsc2UgaWYgKChtb2RlICYgU19JWFVH TykgIT0gMCAmJiBpc19jb2xvcmVkIChDX0VYRUMpKQogICAgICAgICAgICAgdHlwZSA9IENf RVhFQzsKLS0gCjIuNDMuMAoK --------------vriBVwU0XsfLk9HjGqiB01Qr-- From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 03 Oct 2024 06:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , Gian Domenico Bonazzoli Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172793760730014 (code B ref 73418); Thu, 03 Oct 2024 06:41:02 +0000 Received: (at 73418) by debbugs.gnu.org; 3 Oct 2024 06:40:07 +0000 Received: from localhost ([127.0.0.1]:59781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swFVP-0007n7-44 for submit@debbugs.gnu.org; Thu, 03 Oct 2024 02:40:07 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:44542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swFVM-0007kj-8J for 73418@debbugs.gnu.org; Thu, 03 Oct 2024 02:40:05 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id B33CE3C011BD8; Wed, 2 Oct 2024 23:39:56 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id i84zlDL5lJB3; Wed, 2 Oct 2024 23:39:56 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 62FB83C011BD9; Wed, 2 Oct 2024 23:39:56 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 62FB83C011BD9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1727937596; bh=F2QDRDoNVR723rbPw0sr5DBxYQWV5hh3zQLrrWaMFx4=; h=Message-ID:Date:MIME-Version:To:From; b=rJQQWjvscc98mDyyTUldSM7lq9qxr79M8BaqKehAK2BuTWCE0hua8smsgGkjteczd xgg3qXXLZGRCz6HHzzQWW9bdQDnxLlfWmuMMCJL2tLz7gYVsxzDrSpfkjMf3c9mxqs JZCs8qHnAc3hHdNMLoNCFM3rmA+Q9KJwGRySDrUShuNPZhP9HYXrlmSfSyqBJeMo8q gCmP+7ZXoGGA5zjhomM/WnfIirp4GqdFsMr1bKFApamtJhWuqJVL1YrC+lvIESprfP vTWsM11sPr8b4oizh8ux1X84vS/l/EjANzXIsgAZa5w5UAPhzgLv9uA55eSp/CW6qT Q4VTLjGTHhn5Q== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id Qg2BiGW3p1tA; Wed, 2 Oct 2024 23:39:56 -0700 (PDT) Received: from [192.168.254.12] (unknown [47.150.137.250]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 48F143C011BD8; Wed, 2 Oct 2024 23:39:56 -0700 (PDT) Message-ID: <016cece3-ea48-4f1a-b8f3-defba1cde286@cs.ucla.edu> Date: Wed, 2 Oct 2024 23:39:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <2b9f18dd-a0a6-4486-887f-e22f08493e0e@draigBrady.com> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <2b9f18dd-a0a6-4486-887f-e22f08493e0e@draigBrady.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2024-10-02 15:14, P=C3=A1draig Brady wrote: >=20 > I notice that tests/ls/getxattr-speedup.sh is failing now, > which I've not looked into yet. I'm not seeing that after the changes I committed this evening. If you=20 can still reproduce it please let us know the details. From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 03 Oct 2024 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert , Gian Domenico Bonazzoli Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172796580628541 (code B ref 73418); Thu, 03 Oct 2024 14:31:02 +0000 Received: (at 73418) by debbugs.gnu.org; 3 Oct 2024 14:30:06 +0000 Received: from localhost ([127.0.0.1]:33665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swMqE-0007Q9-3S for submit@debbugs.gnu.org; Thu, 03 Oct 2024 10:30:06 -0400 Received: from mail-ej1-f54.google.com ([209.85.218.54]:56668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swMqB-0007PK-MY for 73418@debbugs.gnu.org; Thu, 03 Oct 2024 10:30:04 -0400 Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a90188ae58eso133218866b.1 for <73418@debbugs.gnu.org>; Thu, 03 Oct 2024 07:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727965741; x=1728570541; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=DsofRsKfZ7h3fCd+3VDF4uGMT4Kb+nZTNyeqLFDeDpY=; b=aiSRSqN8PGSmRJ5183kjsD3bFWYPw/c7qTKnF1P0xHCDqbIjGWdzgxGoGSgFR5/6BN i3kHSO1KKy6gfpTY7+3YyrcO7BG2LLQ0ccq3UBSfpE8oeANEbmQTRFsWPuTfMFXGcq4V lz77jbd8HK1DXywAvsOON2cZlZokOcP0zlgXyPQtZNc+5eTR0ReFFZyB+eluBryMmaYY 2aruboa+XW0OrwYSyZ7+HNEOvdGENLvtFVeTMdRskwl+sfy20M/uxr3GED4MAUjcByB8 I5ArhJEvyRmlLEF+WuNlCPWqCajmOvpVPcWmYhBdPYDU7Hv6QaS0/tkp6tpIvxHlK+ZS mBLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727965741; x=1728570541; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DsofRsKfZ7h3fCd+3VDF4uGMT4Kb+nZTNyeqLFDeDpY=; b=Y4b7qE1FfaRsW2I5JVE5RIQevFAc2N5yDPfos0zACo2HNQehGEEgxB+Cugqn+5YMXW JX5gxdFb3JQ9phloKwAm/fTIWeL0sOZci8CbRA7I42/GW8nYWciZIsD5e8vaAQqCDbRt tEAMpE/+VESq5AEmsFqfFSkusnqMn7bfF3BFJKmM9PPY/X9xbYVvlm8MyOdwM3iDvBJz 1WYd2BezFsivzSAnIdx9blFU5Bb0Agm1wLc8An208L0mNTzDKuSFNLBKBMCRp7VZyDSQ 7fdxhIfUd+wDPXPaT0SOaxBVSIHwiRMJNwanc2oTihlGbGG1iFCcFIr1ItrOTG7J5eYY FHyw== X-Gm-Message-State: AOJu0Yw6wnEk/PVuoPmC+cvYHdxDjhgAP7LDs1gVAGpM8KYm7T9FetCk rPB95DO1Qw9uaGhy/6VRc8NPaEl3ENP89hAaD1koIOBouwCrQ6N2FWNH0w== X-Google-Smtp-Source: AGHT+IGq/DiTvkLlVU9GRI2vjCsxmNRQzmgYxyuE5hKQwpVlNHMoMHPngHDf7ODVtGc0eojZbUWvnw== X-Received: by 2002:a17:907:743:b0:a86:8f8f:4761 with SMTP id a640c23a62f3a-a98f8234520mr673813366b.25.1727965740707; Thu, 03 Oct 2024 07:29:00 -0700 (PDT) Received: from [192.168.1.156] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a991047312bsm91517866b.157.2024.10.03.07.28.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2024 07:29:00 -0700 (PDT) Message-ID: <5de222eb-3e53-46ba-8d1c-c5a718abb750@draigBrady.com> Date: Thu, 3 Oct 2024 15:28:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta References: <2b9f18dd-a0a6-4486-887f-e22f08493e0e@draigBrady.com> <016cece3-ea48-4f1a-b8f3-defba1cde286@cs.ucla.edu> Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig?= Brady In-Reply-To: <016cece3-ea48-4f1a-b8f3-defba1cde286@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 03/10/2024 07:39, Paul Eggert wrote: > On 2024-10-02 15:14, Pádraig Brady wrote: >> >> I notice that tests/ls/getxattr-speedup.sh is failing now, >> which I've not looked into yet. > > I'm not seeing that after the changes I committed this evening. If you > can still reproduce it please let us know the details. I can still repro. I'm on BTRFS though I don't think that matters for this test. I suspect the caching is being bypassed as we don't return ENOTSUP in all cases where the underlying lgetxattr() returns ENOTSUP. Actually in cases where the caching in file_has_aclinfo_cache() is effective, and file_has_aclinfo() is bypassed, we get UMR due to the uninitialized aclinfo struct. So the whole interaction with file_has_aclinfo_cache() needs looking at. If I remove the caching I also see issues with symlink handling, where security contexts aren't read for symlinks. Comparing system ls, with latest: $ ls -lZ INSTALL lrwxrwxrwx. 1 padraig padraig unconfined_u:object_r:user_home_t:s0 ... $ src/ls -lZ INSTALL lrwxrwxrwx 1 padraig padraig ? ... I pushed two other fixes: 1. Since tests/ls/no-cap.sh is now always skipped. I adjusted the test to avoid that. 2. ls -Z always output an error, so fixed up the condition around the error() call in that case. cheers, Pádraig From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 06 Oct 2024 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert , =?UTF-8?Q?P=C3=A1draig?= Brady , Gian Domenico Bonazzoli Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172823722728253 (code B ref 73418); Sun, 06 Oct 2024 17:54:02 +0000 Received: (at 73418) by debbugs.gnu.org; 6 Oct 2024 17:53:47 +0000 Received: from localhost ([127.0.0.1]:42278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxVRz-0007Lc-3n for submit@debbugs.gnu.org; Sun, 06 Oct 2024 13:53:47 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:40575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxVRu-0007LI-OD for 73418@debbugs.gnu.org; Sun, 06 Oct 2024 13:53:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bernhard-voelker.de; s=s1-ionos; t=1728237196; x=1728841996; i=mail@bernhard-voelker.de; bh=mNoWa9mUc9rtPlxfE/5PUwXFptX6muGc5Bw0De8nKe0=; h=X-UI-Sender-Class:Content-Type:Message-ID:Date:MIME-Version: Subject:To:Cc:References:From:In-Reply-To:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=14SB9/oQApUotqYZ2j1NZ5po4nUrReXWX9C/Y8LmaZBFJnED3Zaj/8UDRoC7hsBG wGfo6f1gfaSdNtHQWdMjPYZv/wy5GfPlpYFUrHrwRSCS1DwDpwnuiY0MHyWXeRZDk ggb0bKA2GgsGbZJIi3jRKj1tzwKPQYSt7UrGJ1ZbihB51lUgiYFDmypF4fZgt+RFm MXPmfJEXJXTnoNhJALYjlP9+X75Rq2W4/8JsKh25Oe+fXSSN8hUXy8ThiuK+1vrD1 WGSec+C9q9OqXdTjomEg9yJxGFKJRNE5uEauWn5SVNg8QC5XcIW7vHgn+VNAJaYBS cwb0gsMFYJoRwNG/bw== X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from [192.168.101.10] ([91.12.164.157]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MYeV1-1tS0lj1HPf-00QFV4; Sun, 06 Oct 2024 19:53:16 +0200 Content-Type: multipart/mixed; boundary="------------RXoq4cmztfU0322aGeEwv7DQ" Message-ID: <746f147a-5e04-438e-93bf-c5ecc933b93b@bernhard-voelker.de> Date: Sun, 6 Oct 2024 19:53:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <57189234-b3c9-46ca-ae1e-1f31c0188767@bernhard-voelker.de> <404c8151-692d-4447-ab60-30c9583b23e2@draigBrady.com> Content-Language: en-US From: Bernhard Voelker In-Reply-To: X-Provags-ID: V03:K1:rD1rW3fWZ0NLLvTMF+vazy+FQWjVWjRwfuVrcHN4I4FvqEpBylq YPbzxX0ByhypVuLBFZ1h7VnjeEEnG6TqUrDXfArCKqyoloka8CtbX/8FKOcpKibb3Qxtp5l ln2JNzPHIxADrWt49tAcwgZAU24r3Bj22gq5+Czy3O9Gm14ZJzLL+fPweweZvhz8mneDNqc PQNDBMDw5MTG60mKLOfsA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:6PQUeDzy3FQ=;epdVCWkGYVTtZKD92PJ87AJuo5Y PQzV8o/8sGMySPWygSbPSDJjm8a4Wa63amZ+xPzrQ/m7Lb99qyAF6rvauEOyUu+eBNOg+BFvI xsA/TeC9d73lwKoI4cRv/8qSdwB88dONrXatgqAT+thkcpNUvDQYYveM+fDXsaBtzqLx8t2wN zLZqxQQ/Uedz8csmZ91vAZ09QALDtvYIV0hfetpflbYOFKPYQnWn9sTQlXi+rbc6dN4kOksZz pX90Rvz0ynI7Wf5iwkvtapBwRpxE4cW7n0C8oSMbPCdWi5UZJ5aOjVMvGZDSsNAbVr0vWv6OC V3b1KgY6i+skh4/x7/K5yik2zDpjonC8iwZlYtzD37DB33lbYKRDyiSwBC5B4eMVSduXp4gvD EGGeouyeiVX67NwdIC1/xPqaOkKi6q1m/fTeXfRGId/b7Vm2FLTmYvSJas83yamn4kc8tXFeg MJqY7SmBRYC+T66eUTr4ASF6Ua3P2a2texlcRMsKq52nizJnuiReklgjypUgNpP+bo6Z7S9Y4 /Ft0R6gfnb1tI+TMKf7JYkq48/wTQZ2LoL2aZmk4giFE1eh3oLXZciGuJKO9wueOKin+YLzkg xh+LKYtHXKQWdkyb8iw6fQvVvHx+l0VcVUEUIHVGHMOAsWaeMU3NRrJ/i/ZFp1+gQnt3jgqzM CAtUKh/apsBaol8R1a5BJwntqU1GwZobfZeKuouRpbIofpQTHMaYKcJew9Lr4wchAT8D2nu/J RYEYyhjSj8hnzYa2fmbsfRtulFqFrem1g== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------RXoq4cmztfU0322aGeEwv7DQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/3/24 08:04, Paul Eggert wrote: > I installed the attached (plus some other refactorings) to do that. I don't see test-suite failures anymore, thanks. > [PATCH] ls: tune indicator_name This change makes 'check-ls-dircolors' and therefore 'distcheck' fail. The attached fixes the check. Have a nice day, Berny --------------RXoq4cmztfU0322aGeEwv7DQ Content-Type: text/x-patch; charset=UTF-8; name="0001-maint-adjust-check-ls-dircolors-to-recent-change-in-.patch" Content-Disposition: attachment; filename*0="0001-maint-adjust-check-ls-dircolors-to-recent-change-in-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAwOTExMzYxZTc5Y2RkYzJmZmVhYjA0M2Y5ZmYxMjBjMTk0MzEzODRhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuaGFyZCBWb2Vsa2VyIDxtYWlsQGJlcm5oYXJk LXZvZWxrZXIuZGU+CkRhdGU6IFN1biwgNiBPY3QgMjAyNCAxNjowOToyNiArMDIwMApTdWJq ZWN0OiBbUEFUQ0hdIG1haW50OiBhZGp1c3QgY2hlY2stbHMtZGlyY29sb3JzIHRvIHJlY2Vu dCBjaGFuZ2UgaW4gbHMuYwoKJ21ha2UgZGlzdGNoZWNrJyB3b3VsZCBmYWlsIHNpbmNlIGNv bW1pdCA3NWIzNGM3N2U0M2EsIGJlY2F1c2UgdGhlCmNvbXBhcmlzb24gYnkgY2hlY2stbHMt ZGlyY29sb3JzIGZhaWxzLgoKKiBNYWtlZmlsZS5hbSAoY2hlY2stbHMtZGlyY29sb3JzKTog QWRqdXN0IHNlZCgxKSBleHByZXNzaW9uIHRvIHRoZQpjaGFuZ2VkIGRhdGEgaW5pdGlhbGl6 YXRpb24uCi0tLQogTWFrZWZpbGUuYW0gfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL01ha2VmaWxlLmFtIGIv TWFrZWZpbGUuYW0KaW5kZXggM2ZkNTQ2NTk5Li5kMTczNTNlMWMgMTAwNjQ0Ci0tLSBhL01h a2VmaWxlLmFtCisrKyBiL01ha2VmaWxlLmFtCkBAIC0xMzMsNyArMTMzLDggQEAgY2hlY2st bHMtZGlyY29sb3JzOgogCSAgfHNlZCAtbiAncy9eIlwoLi5cKSIvXDEvcCd8c29ydCAtdSk7 CQkJXAogCWxzPSQkKHNlZCAtbiAnL3N0YXRpYy4qaW5kaWNhdG9yX25hbWVcWy8sL307Jy9c cAlcCiAJICAgICQoc3JjZGlyKS9zcmMvbHMuYwkJCQkJXAotCSAgfHNlZCAtbiAnL14gICoi L3AnfHRyICwgJ1xuJ3xzZWQgJ3MvXiAgKi8vJwkJXAorCSAgfHNlZCAtbiAnL14gICp7LyB7 IHMvey5cKFthLXpdXCkuLC5cKFthLXpdXCkufS8iXDFcMiIvZzsgcDsgfScgXAorCSAgfHRy ICwgJ1xuJ3xzZWQgJ3MvXiAgKi8vJwkJXAogCSAgfHNlZCAtbiAncy9eIlwoLi5cKSIvXDEv cCd8c29ydCAtdSk7CQkJXAogCXRlc3QgIiQkZGMiID0gIiQkbHMiCiAKLS0gCjIuNDYuMAoK --------------RXoq4cmztfU0322aGeEwv7DQ-- From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 06 Oct 2024 20:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker , Paul Eggert , Gian Domenico Bonazzoli Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.172824630626728 (code B ref 73418); Sun, 06 Oct 2024 20:26:02 +0000 Received: (at 73418) by debbugs.gnu.org; 6 Oct 2024 20:25:06 +0000 Received: from localhost ([127.0.0.1]:42456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxXoQ-0006x2-62 for submit@debbugs.gnu.org; Sun, 06 Oct 2024 16:25:06 -0400 Received: from mail-ej1-f43.google.com ([209.85.218.43]:48348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxXoO-0006wu-6H for 73418@debbugs.gnu.org; Sun, 06 Oct 2024 16:25:05 -0400 Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a99422929b2so156725966b.0 for <73418@debbugs.gnu.org>; Sun, 06 Oct 2024 13:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728246237; x=1728851037; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=8Ls6D/fHawpd7fTYo2+IWAMMy1oNTNfzm1uiXL6ccOA=; b=j2f9e5wsvBM1wV+0MXB8x75gXz6t1i4NPS8y6wwHMsYUKpnSzUNaJzOcUkAJKxlZXY WdL4uidi6zOqeG/oY8YCV8LIjSWbMX+he/ffnuiTy8XB9zcNYJCWTuixpoEVhXOIFZCs hEhigRknJaFF/76hrRKkPSox3shKzwTPwwCmXAVFrpkhXYtKojRqqyfbzt3879ts4D/K QxVNsjCStseXTuyPV2XKWBkxFQ2Rm4Jggcx2k2JQhscWkwgzj6oc3okrkUAbqlX5m+UJ m9tB4uhB695dbkNUP126lv3cnyRXuOiZ0Q8GTpfXNq4hLdsLYZ225mCEi1CqfrvzU7jN nsjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728246237; x=1728851037; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Ls6D/fHawpd7fTYo2+IWAMMy1oNTNfzm1uiXL6ccOA=; b=qbh5yRKHCvXac+76ZpTP6MT+dpHPR2EPexu4fyFf1eX2Apk7Ad46nyaoHdMGrEIZCZ dY/PlnRWWfIrG5yez6UyHaLXxLCu/ys6CRawe+S8pkS7B/4AgDpxEGtwLW5ce0MyUxds 0WALpWvtUI5n6qMs5p5SI86hKjmRucc3FxbmvBFxTrhQkMz/KRoJ2eJyANB2gH0K8dkL 4UcQak7Q+Wa0Q7UyfS17iOqdZJagNDl+Sxu8QUTxd5oCweJmt11b/GMOJ7y0oHP1o2KF d73B9iSQPN+18W89sIruHugBo742KWjNV+9S4jnsIM7hr41XZdzvgSa+Ug94spxdw2fG 0L6Q== X-Gm-Message-State: AOJu0YxsqKHGtycGFXsSV6Xw8jN0lDWpqct/Y3uHeHTB5IosC79iBwx8 igUhMGnQ9qEUOl8+7puK3W+seTaPVV9QwvAVAI4vbvcnVT5ug6Pg X-Google-Smtp-Source: AGHT+IEUTYCsI86GVE20twlZ6UWDYjFnkyUCNQWPMLsmbUwn9PuXE3b1BfUBtYPcGi2ou10APiEx5w== X-Received: by 2002:a17:907:7f87:b0:a99:5ad9:b68f with SMTP id a640c23a62f3a-a995ad9d5d9mr10908666b.7.1728246236682; Sun, 06 Oct 2024 13:23:56 -0700 (PDT) Received: from [192.168.1.156] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a992e664fb9sm297957266b.88.2024.10.06.13.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Oct 2024 13:23:56 -0700 (PDT) Message-ID: <5b886484-8feb-4640-ac51-523c82bba18d@draigBrady.com> Date: Sun, 6 Oct 2024 21:23:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta References: <57189234-b3c9-46ca-ae1e-1f31c0188767@bernhard-voelker.de> <404c8151-692d-4447-ab60-30c9583b23e2@draigBrady.com> <746f147a-5e04-438e-93bf-c5ecc933b93b@bernhard-voelker.de> Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig?= Brady In-Reply-To: <746f147a-5e04-438e-93bf-c5ecc933b93b@bernhard-voelker.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/10/2024 18:53, Bernhard Voelker wrote: > On 10/3/24 08:04, Paul Eggert wrote: >> I installed the attached (plus some other refactorings) to do that. > > I don't see test-suite failures anymore, thanks. > > > [PATCH] ls: tune indicator_name > > This change makes 'check-ls-dircolors' and therefore 'distcheck' fail. > The attached fixes the check. +1 thanks! Pádraig From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 09 Nov 2024 17:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert , Gian Domenico Bonazzoli Cc: 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.173117264323321 (code B ref 73418); Sat, 09 Nov 2024 17:18:01 +0000 Received: (at 73418) by debbugs.gnu.org; 9 Nov 2024 17:17:23 +0000 Received: from localhost ([127.0.0.1]:54317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9p5P-000645-E0 for submit@debbugs.gnu.org; Sat, 09 Nov 2024 12:17:23 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:54284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9p5N-00063m-Mt for 73418@debbugs.gnu.org; Sat, 09 Nov 2024 12:17:22 -0500 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43155abaf0bso28449035e9.0 for <73418@debbugs.gnu.org>; Sat, 09 Nov 2024 09:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731172576; x=1731777376; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:sender :from:to:cc:subject:date:message-id:reply-to; bh=iYyXvh4N9INwBug/u52c8JkMKXxC08SciFad1Ix5hqY=; b=RNL2OmCSkKoXDJZXUcB9PyWk9FM6t1ty1IfTZk1/wEUfp/CVZHlmRp1sU452Kpi9ar 83kN8gd6blomaSdIIhaEUGGK5ye+KgHp2g1AUWlvDM3QkGTAaH3rj5P1BJVECnY7rm11 CgyLAc00g0MwyNTw6AUTM7AzrVsb8H2WKmNEBrM5F9T1NF02sZnMlWmkGjpEFHSRFx20 Si91WD79qZYQfhiFCmGBgXMknvf+fp3ZLBEE9Uctc7lJqtLwwTBwidHWC4oxuv9xanne 7Lp/Zh+OY2gMVST1dHDylzQa2E62LH59DN7QLRPG6XMl8lwtgzgdNfp06XWpelR8H1sl EVMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731172576; x=1731777376; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iYyXvh4N9INwBug/u52c8JkMKXxC08SciFad1Ix5hqY=; b=ASyazNZibwaXBUZCAy7gEMJkOJhm+LBtPdjoYRkuWgXMEhHTosKQmAMKktbV3/6p9z Jjal5RpDMYwwUre2CPKZ0mu6sZBPXVITSP/1iJNoaA9ncgtKeSZ+vXsiUaVwWtdHHEVE ZMgjI+ZtAKC0Ul+ZMrE9SVoSh0/pjT2tU48QunsKh6x9rizF9m3ARbRwBEfwpK0bGL+0 WWabuhWPQJ/CIoOGwzyzBBYZzmY/hdIs05NkXVOkQfIxOd2o5C/BJyLml96Cebz3Rr6A vogZcneiJGbKVpUqdHTA4keIKqBEjSguQQqt7oR2OzOsxSeWDaBZ4AsJWW0h9x3XX7jN Kv1A== X-Gm-Message-State: AOJu0YwvAjNICqAFAl/OmIr211++KMrNtu42FdUcVNFdJrleRXwQDkMU 7oasM6q6RInligmuN9wVfYJWXUqComscHKvYfmBqZt2Yi9fSN42h X-Google-Smtp-Source: AGHT+IExUWOspIYjp141iwredE40jrb3d8JS2HM8jfqQcfz5Hnwut/BeqI7kARk76SNRXNZawdBBNw== X-Received: by 2002:a05:600c:3ca0:b0:431:586e:7e7 with SMTP id 5b1f17b1804b1-432b74fd8f0mr60781865e9.1.1731172575649; Sat, 09 Nov 2024 09:16:15 -0800 (PST) Received: from [192.168.1.78] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-432b0530694sm116491605e9.7.2024.11.09.09.16.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Nov 2024 09:16:15 -0800 (PST) Message-ID: Date: Sat, 9 Nov 2024 17:16:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta From: =?UTF-8?Q?P=C3=A1draig?= Brady References: <2b9f18dd-a0a6-4486-887f-e22f08493e0e@draigBrady.com> <016cece3-ea48-4f1a-b8f3-defba1cde286@cs.ucla.edu> <5de222eb-3e53-46ba-8d1c-c5a718abb750@draigBrady.com> Content-Language: en-US In-Reply-To: <5de222eb-3e53-46ba-8d1c-c5a718abb750@draigBrady.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 03/10/2024 15:28, Pádraig Brady wrote: > On 03/10/2024 07:39, Paul Eggert wrote: >> On 2024-10-02 15:14, Pádraig Brady wrote: >>> >>> I notice that tests/ls/getxattr-speedup.sh is failing now, >>> which I've not looked into yet. >> >> I'm not seeing that after the changes I committed this evening. If you >> can still reproduce it please let us know the details. > > I can still repro. > I'm on BTRFS though I don't think that matters for this test. > I suspect the caching is being bypassed as we don't return ENOTSUP > in all cases where the underlying lgetxattr() returns ENOTSUP. > Actually in cases where the caching in file_has_aclinfo_cache() > is effective, and file_has_aclinfo() is bypassed, we get UMR > due to the uninitialized aclinfo struct. > So the whole interaction with file_has_aclinfo_cache() needs looking at. I can confirm that the following commit fixes both issues above: https://github.com/coreutils/coreutils/commit/b857d66b5 > I also see issues with symlink handling, > where security contexts aren't read for symlinks. > Comparing system ls, with latest: > $ ls -lZ INSTALL > lrwxrwxrwx. 1 padraig padraig unconfined_u:object_r:user_home_t:s0 ... > > $ src/ls -lZ INSTALL > lrwxrwxrwx 1 padraig padraig ? ... This is still an issue here. thanks, Pádraig From unknown Tue Jun 17 01:47:00 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Gian Domenico Bonazzoli Subject: bug#73418: closed (Re: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share) Message-ID: References: <30cd6bcd-f56c-4b9d-9438-c00352fa5b0e@cs.ucla.edu> X-Gnu-PR-Message: they-closed 73418 X-Gnu-PR-Package: coreutils Reply-To: 73418@debbugs.gnu.org Date: Sun, 10 Nov 2024 00:58:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1731200283-4415-1" This is a multi-part message in MIME format... ------------=_1731200283-4415-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) = 8.32 listing files on a cifs mounted share which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 73418@debbugs.gnu.org. --=20 73418: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73418 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1731200283-4415-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 73418-done) by debbugs.gnu.org; 10 Nov 2024 00:57:55 +0000 Received: from localhost ([127.0.0.1]:54946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9wH4-00018i-Cy for submit@debbugs.gnu.org; Sat, 09 Nov 2024 19:57:54 -0500 Received: from mail.cs.ucla.edu ([131.179.128.66]:52048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9wH2-00018Q-Bz for 73418-done@debbugs.gnu.org; Sat, 09 Nov 2024 19:57:53 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 5A17A3C00FA89; Sat, 9 Nov 2024 16:57:46 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id OmaZZJSD0gSP; Sat, 9 Nov 2024 16:57:46 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id F3ED43C00FA92; Sat, 9 Nov 2024 16:57:45 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu F3ED43C00FA92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1731200266; bh=CSGpdh7IQ/nWSTpLxazoYi8VhghehVpc00oWFD3EjP4=; h=Message-ID:Date:MIME-Version:To:From; b=eXQ5IAUdtlm3skRxRSlfYplQKvb9vvnCvrelH5LG50Z9+b+9MLh4/6OrfLDVfKNsH i1UIpYODjdXvhKZm30VnIRZ/auTHupb5Q23p1b62Ih8At3o0bQCLBbOcQS0XnGZXLZ fwtjj6QLnY2mjqZLAAsrydm6FcA9BSmqAO6szf/0Ok8gtGah8/Ev7pTDcfUMXv3Cv/ Ta38eDdxqLcjbmoBWIuochMrX1gVbInuVDwzUmXqtqq2voJv2z2O4ic95ey3rwqRxU pQtOW47jJCyPBYQDUk9lU63fD8H7PClOlPMmUjaYNCwsw14kQthqPJYX2i1q3pugxn UuXqQPzYc+Omg== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id bx3KpYEWEQ_u; Sat, 9 Nov 2024 16:57:45 -0800 (PST) Received: from [192.168.254.12] (unknown [47.150.137.250]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id CF8A33C00FA89; Sat, 9 Nov 2024 16:57:45 -0800 (PST) Content-Type: multipart/mixed; boundary="------------JdK6f7BH7jMzEbDFKyLvN31q" Message-ID: <30cd6bcd-f56c-4b9d-9438-c00352fa5b0e@cs.ucla.edu> Date: Sat, 9 Nov 2024 16:57:45 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share To: =?UTF-8?Q?P=C3=A1draig_Brady?= References: <2b9f18dd-a0a6-4486-887f-e22f08493e0e@draigBrady.com> <016cece3-ea48-4f1a-b8f3-defba1cde286@cs.ucla.edu> <5de222eb-3e53-46ba-8d1c-c5a718abb750@draigBrady.com> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73418-done Cc: Gian Domenico Bonazzoli , 73418-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------JdK6f7BH7jMzEbDFKyLvN31q Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2024-11-09 09:16, P=C3=A1draig Brady wrote: >> =C2=A0=C2=A0=C2=A0 $ src/ls -lZ INSTALL >> =C2=A0=C2=A0=C2=A0 lrwxrwxrwx 1 padraig padraig ? ... >=20 > This is still an issue here. Oh, thanks for reminding me. That's a Gnulib bug, fixed here: https://lists.gnu.org/r/bug-gnulib/2024-11/msg00075.html with the fix propagated into Coreutils by installing the attached. I thinks this closes out all the problems mentioned in this bug report,=20 so I'm boldly closing it. We can reopen it if I'm wrong. --------------JdK6f7BH7jMzEbDFKyLvN31q Content-Type: text/x-patch; charset=UTF-8; name="0001-build-update-gnulib-submodule-to-latest.patch" Content-Disposition: attachment; filename="0001-build-update-gnulib-submodule-to-latest.patch" Content-Transfer-Encoding: base64 RnJvbSBiMDQ4YzRkMzdmNGYxYjMxM2M2MzM0NTI1YWQzZjQ1ODllZmRhMWE0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDkgTm92IDIwMjQgMTA6Mjk6MTQgLTA4MDAKU3ViamVjdDogW1BBVENI IDEvMl0gYnVpbGQ6IHVwZGF0ZSBnbnVsaWIgc3VibW9kdWxlIHRvIGxhdGVzdAoKLS0tCiBn bnVsaWIgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9nbnVsaWIgYi9nbnVsaWIKaW5kZXggYmE5MTM2Yjc2Li43 NGI2YTJhNzMgMTYwMDAwCi0tLSBhL2dudWxpYgorKysgYi9nbnVsaWIKQEAgLTEgKzEgQEAK LVN1YnByb2plY3QgY29tbWl0IGJhOTEzNmI3NjQ2ZWY5ZTAxZmZhZDNkZGNmMjMyMDAyMzU0 NTMxZDAKK1N1YnByb2plY3QgY29tbWl0IDc0YjZhMmE3Mzg2Y2Y4NTg2YzEyNDQyOTdkNGQ4 N2RkZTEyM2RiNDIKLS0gCjIuNDcuMAoK --------------JdK6f7BH7jMzEbDFKyLvN31q Content-Type: text/x-patch; charset=UTF-8; name="0002-ls-add-test-case-for-ls-Z-bug.patch" Content-Disposition: attachment; filename="0002-ls-add-test-case-for-ls-Z-bug.patch" Content-Transfer-Encoding: base64 RnJvbSA0NWJhNmM2ZjU0Yzc3MTc3ODc2MTc3NmU0OTZlZDNkNmE0NjIyYjE5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDkgTm92IDIwMjQgMTY6NTE6MDIgLTA4MDAKU3ViamVjdDogW1BBVENI IDIvMl0gbHM6IGFkZCB0ZXN0IGNhc2UgZm9yIGxzIC1aIGJ1ZwpNSU1FLVZlcnNpb246IDEu MApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29udGVudC1UcmFu c2Zlci1FbmNvZGluZzogOGJpdAoKUHJvYmxlbSByZXBvcnRlZCBieSBQw6FkcmFpZyBCcmFk eSA8aHR0cHM6Ly9idWdzLmdudS5vcmcvNzM0MTgjMzU+LgpUaGlzIGJ1ZyB3YXMgZml4ZWQg YnkgdGhlIHJlY2VudCBnbnVsaWIgdXBkYXRlLgoqIHRlc3RzL2xzL3NlbGludXgtc2VnZmF1 bHQuc2g6CkFsc28gdGVzdCBmb3IgbHMgLVogb24gYnJva2VuIHN5bWxpbmtzLgotLS0KIHRl c3RzL2xzL3NlbGludXgtc2VnZmF1bHQuc2ggfCAxNSArKysrKysrKysrKysrKysKIDEgZmls ZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvdGVzdHMvbHMvc2Vs aW51eC1zZWdmYXVsdC5zaCBiL3Rlc3RzL2xzL3NlbGludXgtc2VnZmF1bHQuc2gKaW5kZXgg ZWJjZmJmZTEzLi45YWMxZDk1MGMgMTAwNzU1Ci0tLSBhL3Rlc3RzL2xzL3NlbGludXgtc2Vn ZmF1bHQuc2gKKysrIGIvdGVzdHMvbHMvc2VsaW51eC1zZWdmYXVsdC5zaApAQCAtMzAsNCAr MzAsMTkgQEAgbWtkaXIgc2VkaXIgfHwgZnJhbWV3b3JrX2ZhaWx1cmVfCiBsbiAtc2YgbWlz c2luZyBzZWRpci9icm9rZW4gfHwgZnJhbWV3b3JrX2ZhaWx1cmVfCiByZXR1cm5zXyAxIGxz IC1MIC1SIC1aIC1tIHNlZGlyID4gb3V0IHx8IGZhaWw9MQogCitubD0nCisnCitpZiBzZXN0 YXR1cz0kKExDX0FMTD1DIHNlc3RhdHVzKTsgdGhlbgorICBzZXN0YXR1c19saW5lXzE9JHtz ZXN0YXR1cyUlJG5sKn0KKyAgY2FzZSAkc2VzdGF0dXNfbGluZV8xIGluCisgICAgJ1NFTGlu dXggc3RhdHVzOicqJyBlbmFibGVkJykKKyAgICAgIGxzX291dHB1dD0kKExDX0FMTD1DIGxz IC1sblogc2VkaXIvYnJva2VuKSB8fCBmYWlsPTEKKyAgICAgIHNldCB4ICRsc19vdXRwdXQK KyAgICAgIGNhc2UgJDYgaW4KKyAgICAgICAgKjoqOio6KikgOzsKKyAgICAgICAgKikgZmFp bD0xOworICAgICAgZXNhYworICBlc2FjCitmaQorCiBFeGl0ICRmYWlsCi0tIAoyLjQ3LjAK Cg== --------------JdK6f7BH7jMzEbDFKyLvN31q-- ------------=_1731200283-4415-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Sep 2024 07:29:10 +0000 Received: from localhost ([127.0.0.1]:40782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssH1q-0008KV-2t for submit@debbugs.gnu.org; Sun, 22 Sep 2024 03:29:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:37024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssFyz-0004f8-Cd for submit@debbugs.gnu.org; Sun, 22 Sep 2024 02:22:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssFyd-0001LB-UH for bug-coreutils@gnu.org; Sun, 22 Sep 2024 02:21:47 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ssFyb-0000dY-7n for bug-coreutils@gnu.org; Sun, 22 Sep 2024 02:21:47 -0400 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a8d64b27c45so589878566b.3 for ; Sat, 21 Sep 2024 23:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bonaz-it.20230601.gappssmtp.com; s=20230601; t=1726986101; x=1727590901; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=thfJ2HZFZfNRCp+50SYElcHsYgGWYIgLiEMxR0u0wRg=; b=fbo3VHrX+eki2/BrBYtmXG2PFI73oHZqFuZWJXrWnqAQ8JnbVZyg9NaDEWkKc2xN9A R2qkd1Y4Cn/2dsTaZb+ypiiqsRSCRBiHsyEvFk+AogF587i5tSeHqC4mRi8vk76AW8oT mDbH0PyUIrH5h4Ny5bOir2sv+OXXXwsIvNcjYCXAsRzvAKCh6qJ93rLNoVTfMntE6MJj nV53r1tKYW0mfkPAHv8mLknmhpDGKRRNjSb9MSzDc+clytdiPfLSbniOeYlAwaiAAcRm Ug5Bya+q3Bzl1zNIp20ijS1mlRwksASjrFq+CIJsr9Pqat3l+0GeITolcj4ZZEE4CfBC njcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726986101; x=1727590901; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=thfJ2HZFZfNRCp+50SYElcHsYgGWYIgLiEMxR0u0wRg=; b=WhGbOME+fjb5QKDfMEWhuCNmcUnZssXOic+J76o2gYtvFIHKKddoydaalFCF/sCAv7 mb4NlEhwKdvar9QREkv7Vh2xi48nPexBPZHmndTDKg1PHOsOEHn4l43s2QiQtf4soPlQ GTPcKZ5VHad10B5RjpFDn5IVP9cnGP5gsyHSgWmMSQL7EdPhOXf9/QC6bblEBS+kvu78 14pV20sKwuZkNFG4MpzQd2vQO1GtiHCHuobUqNlzIncfA3GVbIEcLdoX9pgmdyVS4qS8 M0el80M2hiYzGHKWOC8847a036NOB9wUp7wN16RLr4BVZxFbQSv0pZORdxZDJe9yi2zZ PFIg== X-Gm-Message-State: AOJu0YykVe2UC+59H+53WDoP7fh3nrR7JpXko1cLeuqehHGum3zm+egT LP7VznXTUqG8ZmgONcLgu/OnsgIQkjLWTx5iDTRz7LAYnDfuRaRpJLsk3JU6BYXe+Wvq8IPTSz5 0dVvywMPbwa86+LFP8cRkJqm3mLiE5Pi5yatp5KtfPDhOWEJNPxMGpA== X-Google-Smtp-Source: AGHT+IEHi4boD9rJzvwNbTmw6BIz3t6SR5EhM4fOgeR2bqNBPz5IyILpWa7FMLml/cHd1G57duM3k8iIIKWGCfj5IoM= X-Received: by 2002:a17:906:f5a9:b0:a8a:572c:709f with SMTP id a640c23a62f3a-a90d4fdf2ffmr793946366b.5.1726986101322; Sat, 21 Sep 2024 23:21:41 -0700 (PDT) MIME-Version: 1.0 From: Gian Domenico Bonazzoli Date: Sun, 22 Sep 2024 08:21:30 +0200 Message-ID: Subject: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share To: bug-coreutils@gnu.org Content-Type: multipart/alternative; boundary="0000000000001a0fd70622af4953" Received-SPF: none client-ip=2a00:1450:4864:20::62d; envelope-from=gbonazzoli@bonaz.it; helo=mail-ej1-x62d.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, NUMERIC_HTTP_ADDR=1.242, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 22 Sep 2024 03:29:08 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --0000000000001a0fd70622af4953 Content-Type: text/plain; charset="UTF-8" Hi all, During an upgrade from Ubuntu 22.04 to Ubuntu 24.04 we discovered that "ls (GNU coreutils) 9.4" is extremely slower than "ls (GNU coreutils) 8.32" listing files on a cifs mounted share. Facts to help you in troubleshooting the problem. In the same Ubuntu 24.04 machine I have the vanilla executable in /usr/bin/ls and a copy of Ubuntu 22.04 in /tmp/ls root@kube-node04:~# /usr/bin/ls --version ls (GNU coreutils) 9.4 root@kube-node04:~# /tmp/ls --version ls (GNU coreutils) 8.32 I have also a cifs share mounted by: //172.16.0.100/export /cifs/colom/export cifs vers=2.0,uid=50000,username=teledba,password=***** 0 1 This is what happens: root@kube-node04:~# time /tmp/ls -l /cifs/colom/export >/dev/null real 0m0.232s user 0m0.027s sys 0m0.027s root@kube-node04:~# time /usr/bin/ls -l /cifs/colom/export >/dev/null real 0m5.744s user 0m0.068s sys 0m0.349s So "ls -l" in 9.4 is 50 time slower then "ls -l" in 8.32 If I launch the ls command without the -l parameter the computing times are instead quite similar: root@kube-node04:~# time /tmp/ls /cifs/colom/export >/dev/null real 0m0.198s user 0m0.015s sys 0m0.021s root@kube-node04:~# time /usr/bin/ls /cifs/colom/export >/dev/null real 0m0.174s user 0m0.017s sys 0m0.016s looking at the strace output I saw that the new version is doing for each file processed the adjunctive call listxattr (in my case the directory contains 14500 files): ... statx(AT_FDCWD, "/cifs/colom/export/ARTP000.CSV", AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_SIZE, {stx_mask=STATX_TYPE|STATX_MODE|STATX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_CTIME|STATX_INO|STATX_SIZE|STATX_BLOCKS|STATX_BTIME|STATX_MNT_ID, stx_attributes=0, stx_mode=S_IFREG|0755, stx_size=840, ...}) = 0 listxattr("/cifs/colom/export/ARTP000.CSV", "", 152) = 0 ... maybe it is the root cause of the elapsed time when the ls command had the "-l" option fired ? Regards --0000000000001a0fd70622af4953 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi all,

During an upgrade from Ubuntu 2= 2.04 to Ubuntu 24.04 we discovered that "ls (GNU coreutils) 9.4" = is extremely slower than "ls (GNU coreutils) 8.32" listing files = on a cifs mounted share.

Facts to help you in trou= bleshooting the problem.

In the same Ubuntu 24.04 = machine I have the vanilla executable in /usr/bin/ls and a copy of Ubuntu 2= 2.04 in /tmp/ls

root@kube= -node04:~# /usr/bin/ls --version
ls (GNU coreutils) 9.4
=

root@kube-node04:~# /tmp/ls --= version
ls (GNU coreutils) 8.32

I ha= ve also a cifs share mounted by:

//172.16.0.100/export /c= ifs/colom/export cifs vers=3D2.0,uid=3D50000,username=3Dteledba,password=3D= ***** 0 1

This is what happens:

root@kube-node04:~# time /tmp/ls= -l =C2=A0/cifs/colom/export >/dev/null
real 0m0.232s
user 0m0.027= s
sys 0m0.027s


root@kube-node04:~# time /usr/bin/ls -l =C2=A0/cifs/colom/export >/d= ev/null
real 0m5.744s
user 0m0.068s
sys 0m0.349s
<= div>
So "ls -l" in 9.4 is 50 time slower then "= ;ls -l" in 8.32

If I launch=C2=A0the ls comma= nd without=C2=A0the -l parameter the computing times are instead quite simi= lar:

root@kube-node04:~# = time /tmp/ls =C2=A0/cifs/colom/export >/dev/null
real 0m0.198s
use= r 0m0.015s
sys 0m0.021s

ro= ot@kube-node04:~# time /usr/bin/ls =C2=A0/cifs/colom/export >/dev/nullreal 0m0.174s
user 0m0.017s
sys 0m0.016s

<= /div>
looking at the strace output I saw that the new version is doing = for each file processed the=C2=A0adjunctive=C2=A0call listxattr (in my case= the directory contains 14500 files):

...
statx(AT_FDCWD, "/cifs/colom/export/ARTP000.CSV", AT_STATX_SYNC= _AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, STATX_MODE|STATX_NLINK|STATX_= UID|STATX_GID|STATX_MTIME|STATX_SIZE, {stx_mask=3DSTATX_TYPE|STATX_MODE|STA= TX_NLINK|STATX_UID|STATX_GID|STATX_MTIME|STATX_CTIME|STATX_INO|STATX_SIZE|S= TATX_BLOCKS|STATX_BTIME|STATX_MNT_ID, stx_attributes=3D0, stx_mode=3DS_IFRE= G|0755, stx_size=3D840, ...}) =3D 0
listxattr("/cifs/colom/export/A= RTP000.CSV", "", 152) =3D 0
...

=
maybe it is the root cause of the elapsed time when the ls comma= nd had the "-l" option fired ?

Regards







--0000000000001a0fd70622af4953-- ------------=_1731200283-4415-1-- From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 10 Nov 2024 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert Cc: Gian Domenico Bonazzoli , 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.173124656010398 (code B ref 73418); Sun, 10 Nov 2024 13:50:02 +0000 Received: (at 73418) by debbugs.gnu.org; 10 Nov 2024 13:49:20 +0000 Received: from localhost ([127.0.0.1]:56173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA8Jc-0002he-6K for submit@debbugs.gnu.org; Sun, 10 Nov 2024 08:49:20 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:48157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA8JY-0002hQ-0Z for 73418@debbugs.gnu.org; Sun, 10 Nov 2024 08:49:17 -0500 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4315e9e9642so30050905e9.0 for <73418@debbugs.gnu.org>; Sun, 10 Nov 2024 05:49:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731246495; x=1731851295; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Y9bSUeEUYrSa0ihkUPjc5nYcN6A8cAdp+M1idZmW2mA=; b=MxrP8hs5oeqqXyZmDhLmyPwGN+4SOruL8ztwGQn73spQh2TW+b5qXBH0KlAmQROqt6 uTiWc/rRJl+Fxm0x6+1fb2yVIF5n2sX6gTHh82eKxCUnvc3sJBS1MeE+NsRf1ZJQD6Uw dA8+fnMVGDD1WPzPM3WrJSDbQsKm8FzZuTSWPMv5vzvRMowMJVlsdnTrENU7mUR5xXlE e3skKBirB47C/MiEBFCQCIFmPyVgpKfKJD+eEvN8Q9iM5ythboe2w+JQDzQWAq77H5d8 WHWYjO6efl5A7HE/bKhkMiT8BugMwp26KvpioMwSYcAo5Npqy0hBM3gaREeoMpHRgEBY p/4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731246495; x=1731851295; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y9bSUeEUYrSa0ihkUPjc5nYcN6A8cAdp+M1idZmW2mA=; b=vZe5zWt/1vhu3Z72fKnZ3SpwIfWmffLLJytgRFoW184/l9ve6FECYJya8EiRPi7hIS S775VbnSykMY8Vs7eXoOt461BeKHz6N5ZOlm4WzgsDFxX3vSQpcxZHrXgba2/Ug+fVs+ GMpKtejRItQZLhEMtcQF8Fw9ZjWecik0D5vP2nsh4mqqkMTVxvNkiHTetX1/JpbYZQsC BZn+Mkj1Z9vdGvNyUK1xIpEzoZnq5KPiWUJvlko5hatC/TcbEiPitrX2gFLiRYQLTqhq eGFdU7CVyJuimpy+86EcG7cMu1x4EICLYHU4Zl8cXdpFmdgztb98ECaVacT/W2g8YAUN kpKw== X-Gm-Message-State: AOJu0YwV4R7hlcX8oLQTfRjbQoH+Vl1RsX3h53E8Vqt6d5YnPSzivjPm vcSuCmPAmJ7xkhIW3ZbXIoMHLtDlf4kmkpIsF0KYBsOiPahHiNJ47hvnsQ== X-Google-Smtp-Source: AGHT+IERTqXYC+XtRpUoW6xN7iclT+is5UBvO9b9ufUx/vULzJS8fT5cn/9KOr2+eoUjhtthLSkn+g== X-Received: by 2002:a05:6000:156a:b0:37d:43e5:a013 with SMTP id ffacd0b85a97d-381f1726273mr7945671f8f.8.1731246494880; Sun, 10 Nov 2024 05:48:14 -0800 (PST) Received: from [192.168.1.78] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-381ed9ea5d9sm10499842f8f.75.2024.11.10.05.48.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Nov 2024 05:48:13 -0800 (PST) Message-ID: Date: Sun, 10 Nov 2024 13:48:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta References: <2b9f18dd-a0a6-4486-887f-e22f08493e0e@draigBrady.com> <016cece3-ea48-4f1a-b8f3-defba1cde286@cs.ucla.edu> <5de222eb-3e53-46ba-8d1c-c5a718abb750@draigBrady.com> <30cd6bcd-f56c-4b9d-9438-c00352fa5b0e@cs.ucla.edu> Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig?= Brady In-Reply-To: <30cd6bcd-f56c-4b9d-9438-c00352fa5b0e@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 10/11/2024 00:57, Paul Eggert wrote: > On 2024-11-09 09:16, Pádraig Brady wrote: >>>     $ src/ls -lZ INSTALL >>>     lrwxrwxrwx 1 padraig padraig ? ... >> >> This is still an issue here. > > Oh, thanks for reminding me. That's a Gnulib bug, fixed here: > > https://lists.gnu.org/r/bug-gnulib/2024-11/msg00075.html > > with the fix propagated into Coreutils by installing the attached. > > I thinks this closes out all the problems mentioned in this bug report, > so I'm boldly closing it. We can reopen it if I'm wrong. Thank you for the fixes. There are some issues though with `./configure --disable-acl`. In that case we no longer output security context with ls -lZ, when previously we did. We should document that change at least, but we may want to uncouple these also? Note consequently the new test fails with --disable-acl. As an aside, the new test would be best in its own test file that then used require_selinux_, rather than messing with sestatus etc. BTW I've pushed a tweak to gnulib to avoid a -Werror=unused-variable issue with --disable-acl thanks! Pádraig. From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 11 Nov 2024 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: Gian Domenico Bonazzoli , Gnulib bugs , 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.17313436383005 (code B ref 73418); Mon, 11 Nov 2024 16:48:02 +0000 Received: (at 73418) by debbugs.gnu.org; 11 Nov 2024 16:47:18 +0000 Received: from localhost ([127.0.0.1]:58996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAXZN-0000mP-Tb for submit@debbugs.gnu.org; Mon, 11 Nov 2024 11:47:18 -0500 Received: from mail.cs.ucla.edu ([131.179.128.66]:44262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAXZM-0000mC-5T for 73418@debbugs.gnu.org; Mon, 11 Nov 2024 11:47:16 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id A29FE3C00FA87; Mon, 11 Nov 2024 08:47:10 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id 3m2i2kuQLmDE; Mon, 11 Nov 2024 08:47:10 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 56F663C00FAA6; Mon, 11 Nov 2024 08:47:10 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 56F663C00FAA6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1731343630; bh=V4z0nHdgF7XUbTvRe1t/Ksx6vLVZZkEXSm0XEhCxmbk=; h=Message-ID:Date:MIME-Version:To:From; b=F2T/PkMc6NtY1HXc0qFqW8lk/36Ac3NB3+J7bmKZQec9Rh8eQl1WZd5GfI88T72hb wNGtLKAEYuL27OzNpYFeOoGuimZSlzaWIfPk1qHer2B0heU/rW4kNGlpDuoUh5RLYV l+4EbDNhWQsoC/ISujZDO1/sN3ZOPGe8vDaWeyuYCGmeo7hbe4ArlkP+y2xTeSC6x3 8JnyNeAnSgIsEMjtsv3JjdYIrws8vKeMqzR5oNzQYEhxxgPqe+CccyQ9kdn7/gWSh8 CGW06DKkCOIUlMo7KFTiu2WKAWqehmOrqqcs0sMOrn5lVYsjXvUEPjxpOGAAdL79od fs4qMDYRjZiag== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id QMpd5vjjLEMj; Mon, 11 Nov 2024 08:47:10 -0800 (PST) Received: from [192.168.254.12] (unknown [47.150.137.250]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 33AD63C00FA87; Mon, 11 Nov 2024 08:47:10 -0800 (PST) Content-Type: multipart/mixed; boundary="------------cJ5y0dlJWoRoX2kEjdeLdofi" Message-ID: <1ea51443-9157-4dd7-a104-b3033b963955@cs.ucla.edu> Date: Mon, 11 Nov 2024 08:47:09 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <2b9f18dd-a0a6-4486-887f-e22f08493e0e@draigBrady.com> <016cece3-ea48-4f1a-b8f3-defba1cde286@cs.ucla.edu> <5de222eb-3e53-46ba-8d1c-c5a718abb750@draigBrady.com> <30cd6bcd-f56c-4b9d-9438-c00352fa5b0e@cs.ucla.edu> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------cJ5y0dlJWoRoX2kEjdeLdofi Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2024-11-10 05:48, P=C3=A1draig Brady wrote: > BTW I've pushed a tweak to gnulib to avoid a -Werror=3Dunused-variable > issue with --disable-acl Thanks, I installed the attached further patch, since the res5t of the=20 file uses MAYBE_UNUSED. --------------cJ5y0dlJWoRoX2kEjdeLdofi Content-Type: text/x-patch; charset=UTF-8; name="0001-file-has-acl-_GL_UNUSED-MAYBE_UNUSED.patch" Content-Disposition: attachment; filename="0001-file-has-acl-_GL_UNUSED-MAYBE_UNUSED.patch" Content-Transfer-Encoding: base64 RnJvbSA2YTAxOGQwNDkyMjM5ZDAxYzJjYzhmZDU2YTFhY2VjNGQ2ZmNkNDRkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTdW4sIDEwIE5vdiAyMDI0IDIxOjE4OjAyIC0wODAwClN1YmplY3Q6IFtQQVRD SF0gPT9VVEYtOD9xP2ZpbGUtaGFzLWFjbDo9MjA9NUZHTD01RlVOVVNFRD0yMD1FMj04Nj05 Mj0yME1BPz0KID0/VVRGLTg/cT9ZQkU9NUZVTlVTRUQ/PQpNSU1FLVZlcnNpb246IDEuMApD b250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zl ci1FbmNvZGluZzogOGJpdAoKLS0tCiBsaWIvZmlsZS1oYXMtYWNsLmMgfCAyICstCiAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQg YS9saWIvZmlsZS1oYXMtYWNsLmMgYi9saWIvZmlsZS1oYXMtYWNsLmMKaW5kZXggMWNkOTc5 NTQxNi4uM2NmZmY3ZWM3NSAxMDA2NDQKLS0tIGEvbGliL2ZpbGUtaGFzLWFjbC5jCisrKyBi L2xpYi9maWxlLWhhcy1hY2wuYwpAQCAtMzQxLDcgKzM0MSw3IEBAIGludAogZmlsZV9oYXNf YWNsaW5mbyAoTUFZQkVfVU5VU0VEIGNoYXIgY29uc3QgKnJlc3RyaWN0IG5hbWUsCiAgICAg ICAgICAgICAgICAgICBzdHJ1Y3QgYWNsaW5mbyAqcmVzdHJpY3QgYWksIGludCBmbGFncykK IHsKLSAgX0dMX1VOVVNFRCB1bnNpZ25lZCBjaGFyIGRfdHlwZSA9IGZsYWdzICYgVUNIQVJf TUFYOworICBNQVlCRV9VTlVTRUQgdW5zaWduZWQgY2hhciBkX3R5cGUgPSBmbGFncyAmIFVD SEFSX01BWDsKIAogI2lmIFVTRV9MSU5VWF9YQVRUUgogICBpbnQgaW5pdGlhbF9lcnJubyA9 IGVycm5vOwotLSAKMi40My4wCgo= --------------cJ5y0dlJWoRoX2kEjdeLdofi-- From unknown Tue Jun 17 01:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#73418: ls (GNU coreutils) 9.4 is extremely slower than ls (GNU coreutils) 8.32 listing files on a cifs mounted share Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 11 Nov 2024 20:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73418 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert Cc: Gian Domenico Bonazzoli , Gnulib bugs , 73418@debbugs.gnu.org Received: via spool by 73418-submit@debbugs.gnu.org id=B73418.17313559946217 (code B ref 73418); Mon, 11 Nov 2024 20:14:01 +0000 Received: (at 73418) by debbugs.gnu.org; 11 Nov 2024 20:13:14 +0000 Received: from localhost ([127.0.0.1]:59307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAamf-0001cB-EE for submit@debbugs.gnu.org; Mon, 11 Nov 2024 15:13:14 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:52243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAamc-0001c1-08 for 73418@debbugs.gnu.org; Mon, 11 Nov 2024 15:13:12 -0500 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43162cf1eaaso62186625e9.0 for <73418@debbugs.gnu.org>; Mon, 11 Nov 2024 12:13:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731355929; x=1731960729; darn=debbugs.gnu.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=0b/TZwxA4HihiKgcikMwis/SF4XvKbt49Prd5OQ6dWE=; b=N7y50TbDJCDidK5+PwmYinShscSbfAHWxqaZ3MpJTJqwOU1HmeYFHyI2Ruxm99KmGS 1Yu0v6wXyy06fFPA1cN+pHqCe9VhKFUFkU98a3zhJmRgbMpZL85NAcNwMm97BZsexR8z SRZZJaMrgxsFrzJaOcRTnI8lDvkFEQiVrfpt927ozhhOONHYIKKoXTlzXckEuz11f/NQ tQwhrFIglmXjvD2ZItiKszWUfPPEqlci/N78jUuNKAp9z4tftfwYuN7CosNk3JwgBLcY KCbZ2QuNShh9oYChqdWUeNSDe3R6NETrotcWWsTK7rH1gjtBoVYS5zq7cHa6ey6fWLDx DWrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731355929; x=1731960729; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0b/TZwxA4HihiKgcikMwis/SF4XvKbt49Prd5OQ6dWE=; b=O0j8qpev20gMut6pMXw7xVmBEimDuI2BoP9WGIv+w18GgU+Wrb5t0QZMJK9jIomDL+ 1LmhQ/xFiKMdq3HF9jQWkWeVGNrVDLIZU8fwSWoORgZDeMazdIwOIAloExIsFaZOYmcL WE2IP8qusvFEQ7HNhm2HOLD/HJKNmY7yv/OFHeZ5VMYvkZ+RLRZj2RZedhJYd4P6U6Ex /Ut9+nc3igVY9IhlWyTORCnr3Ke5qc2ZTwvKQlBZIcFl2s8kvv8Vh60GdozdpZoF9+FM 70xscCZ0dIr/PQ6dbyCDBA8KCcYE2tw/99TvoXZa7V0+okZCenq/l3Mnj3+cdCujHXjn ehkA== X-Gm-Message-State: AOJu0YwQSnDyFr9SFKNkt5wbdSr3CXaOoXJ/VKUREkmhNbEPGSfEI2BW BsmNMkxZ6EqAZKjgx2gr3aJdjpetmLtW+wBUHFvbub2LyYxeyJJ8 X-Google-Smtp-Source: AGHT+IFskuUpb2NOmWGzz4j5xeUGlJwGJ1jOrM+VviMAakmZY03U8JjZUSWI0zHsjhcfdGDXlOR2IA== X-Received: by 2002:a05:600c:474e:b0:42f:75e0:780e with SMTP id 5b1f17b1804b1-432b7505822mr145068435e9.10.1731355928781; Mon, 11 Nov 2024 12:12:08 -0800 (PST) Received: from [192.168.1.78] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-381ed970d4fsm13951552f8f.5.2024.11.11.12.12.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Nov 2024 12:12:08 -0800 (PST) Content-Type: multipart/mixed; boundary="------------zx0un3s6lEz6hsqzkFk7lk8d" Message-ID: <8756e236-7c53-4edb-8c85-0252b946101f@draigBrady.com> Date: Mon, 11 Nov 2024 20:12:06 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta References: <2b9f18dd-a0a6-4486-887f-e22f08493e0e@draigBrady.com> <016cece3-ea48-4f1a-b8f3-defba1cde286@cs.ucla.edu> <5de222eb-3e53-46ba-8d1c-c5a718abb750@draigBrady.com> <30cd6bcd-f56c-4b9d-9438-c00352fa5b0e@cs.ucla.edu> <1ea51443-9157-4dd7-a104-b3033b963955@cs.ucla.edu> Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig?= Brady In-Reply-To: <1ea51443-9157-4dd7-a104-b3033b963955@cs.ucla.edu> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------zx0un3s6lEz6hsqzkFk7lk8d Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/11/2024 16:47, Paul Eggert wrote: > On 2024-11-10 05:48, Pádraig Brady wrote: >> BTW I've pushed a tweak to gnulib to avoid a -Werror=unused-variable >> issue with --disable-acl > > Thanks, I installed the attached further patch, since the res5t of the > file uses MAYBE_UNUSED. Thanks for all the fixes. With the attached two small changes, it all looks good here now. I'll wait until tomorrow to apply these, in case it overlaps with any changes you're making. cheers, Pádraig --------------zx0un3s6lEz6hsqzkFk7lk8d Content-Type: text/x-patch; charset=UTF-8; name="0001-ls-fix-security-context-indication-in-long-mode.patch" Content-Disposition: attachment; filename*0="0001-ls-fix-security-context-indication-in-long-mode.patch" Content-Transfer-Encoding: base64 RnJvbSAwMGM0NWJlNzg3NWUxNTliMzVhYjZjZDlmY2ZiMjczM2ZkZTk1ZDQxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/UD1DMz1BMWRyYWlnPTIwQnJhZHk/ PSA8UEBkcmFpZ0JyYWR5LmNvbT4KRGF0ZTogTW9uLCAxMSBOb3YgMjAyNCAxODo1NToxOSAr MDAwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSBsczogZml4IHNlY3VyaXR5IGNvbnRleHQgaW5k aWNhdGlvbiBpbiAtLWxvbmcgbW9kZQoKKiBzcmMvbHMuYyAoZ29iYmxlX2ZpbGUpOiBBbHdh eXMgZ2V0IHRoZSBzZWN1cml0eSBjb250ZXh0IHdpdGggLWwKc28gdGhhdCB3ZSBjYW4gaW5k aWNhdGUgYSBjb250ZXh0IHdpdGggJy4nIGlmIHByZXNlbnQuCi0tLQogc3JjL2xzLmMgfCAz ICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoK ZGlmZiAtLWdpdCBhL3NyYy9scy5jIGIvc3JjL2xzLmMKaW5kZXggNmZmMGY0MTBmLi42NDIy MDIyZDIgMTAwNjQ0Ci0tLSBhL3NyYy9scy5jCisrKyBiL3NyYy9scy5jCkBAIC0zNTAxLDgg KzM1MDEsOSBAQCBnb2JibGVfZmlsZSAoY2hhciBjb25zdCAqbmFtZSwgZW51bSBmaWxldHlw ZSB0eXBlLCBpbm9fdCBpbm9kZSwKICAgaWYgKChmb3JtYXQgPT0gbG9uZ19mb3JtYXQpIHwg cHJpbnRfc2NvbnRleHQgfCBjaGVja19jYXBhYmlsaXR5KQogICAgIHsKICAgICAgIHN0cnVj dCBhY2xpbmZvIGFpOworICAgICAgYm9vbCBnZXRfc2NvbnRleHQgPSAoZm9ybWF0ID09IGxv bmdfZm9ybWF0KSB8IHByaW50X3Njb250ZXh0OwogICAgICAgaW50IGFjbGluZm9fZmxhZ3Mg PSAoKGRvX2RlcmVmID8gQUNMX1NZTUxJTktfRk9MTE9XIDogMCkKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgKHByaW50X3Njb250ZXh0ID8gQUNMX0dFVF9TQ09OVEVYVCA6IDAp CisgICAgICAgICAgICAgICAgICAgICAgICAgICB8IChnZXRfc2NvbnRleHQgPyBBQ0xfR0VU X1NDT05URVhUIDogMCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgZmlsZXR5cGVf ZF90eXBlW3R5cGVdKTsKICAgICAgIGludCBuID0gZmlsZV9oYXNfYWNsaW5mb19jYWNoZSAo ZnVsbF9uYW1lLCBmLCAmYWksIGFjbGluZm9fZmxhZ3MpOwogICAgICAgYm9vbCBoYXZlX2Fj bCA9IDAgPCBuOwotLSAKMi40Ny4wCgo= --------------zx0un3s6lEz6hsqzkFk7lk8d Content-Type: text/x-patch; charset=UTF-8; name="0002-tests-avoid-false-failure-with-disable-selinux.patch" Content-Disposition: attachment; filename*0="0002-tests-avoid-false-failure-with-disable-selinux.patch" Content-Transfer-Encoding: base64 RnJvbSA4YmU4YjNkMWU0Y2E5N2RlMTUxZTUwNzBjNWFlNWY0MmMwZjhmODk2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/UD1DMz1BMWRyYWlnPTIwQnJhZHk/ PSA8UEBkcmFpZ0JyYWR5LmNvbT4KRGF0ZTogTW9uLCAxMSBOb3YgMjAyNCAxOTo1NDoxOCAr MDAwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSB0ZXN0czogYXZvaWQgZmFsc2UgZmFpbHVyZSB3 aXRoIC0tZGlzYWJsZS1zZWxpbnV4CgoqIHRlc3RzL2xzL3NlbGludXgtc2VnZmF1bHQuc2g6 IE1vdmUgcmVjZW50IGFkZGl0aW9uIHRvIC4uLgoqIHRlc3RzL2xzL3NlbGludXguc2g6IC4u LiB0aGlzIG5ldyB0ZXN0IHRoYXQgdXNlcyByZXF1aXJlX3NlbGludXhfCnRvIHNraXAgYXBw cm9wcmlhdGVseSB3aGVuIHdlJ3ZlIGJ1aWx0IHdpdGhvdXQgc2VsaW51eCBzdXBwb3J0LgpB bHNvIGFkZCBhIG5vbiByb290IHRlc3QgdGhhdCBjaGVja3Mgd2Ugb3V0cHV0ICcuJyBhbG9u ZyB3aXRoIHRoZQptb2RlIGZvciBmaWxlcywgdG8gaW5kaWNhdGUgYSBzZWN1cml0eSBjb250 ZXh0IGlzIHByZXNlbnQuCiogdGVzdHMvbG9jYWwubWsgKFJlZmVyZW5jZSB0aGUgbmV3IHRl c3QpLgotLS0KIHRlc3RzL2xvY2FsLm1rICAgICAgICAgICAgICAgfCAgMSArCiB0ZXN0cy9s cy9zZWxpbnV4LXNlZ2ZhdWx0LnNoIHwgMTUgLS0tLS0tLS0tLS0tLS0KIHRlc3RzL2xzL3Nl bGludXguc2ggICAgICAgICAgfCA0MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNDEgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25z KC0pCiBjcmVhdGUgbW9kZSAxMDA3NTUgdGVzdHMvbHMvc2VsaW51eC5zaAoKZGlmZiAtLWdp dCBhL3Rlc3RzL2xvY2FsLm1rIGIvdGVzdHMvbG9jYWwubWsKaW5kZXggMzIyM2I1OGFhLi5m NGU2ODdmZTggMTAwNjQ0Ci0tLSBhL3Rlc3RzL2xvY2FsLm1rCisrKyBiL3Rlc3RzL2xvY2Fs Lm1rCkBAIC02NDcsNiArNjQ3LDcgQEAgYWxsX3Rlc3RzID0JCQkJCVwKICAgdGVzdHMvbHMv cmVtb3ZlZC1kaXJlY3Rvcnkuc2gJCQlcCiAgIHRlc3RzL2xzL3Jvb3QtcmVsLXN5bWxpbmst Y29sb3Iuc2gJCVwKICAgdGVzdHMvbHMvcnQtMS5zaAkJCQlcCisgIHRlc3RzL2xzL3NlbGlu dXguc2gJCQkJXAogICB0ZXN0cy9scy9zbGluay1hY2wuc2gJCQkJXAogICB0ZXN0cy9scy9z dGF0LWR0eXBlLnNoCQkJXAogICB0ZXN0cy9scy9zdGF0LWZhaWxlZC5zaAkJCVwKZGlmZiAt LWdpdCBhL3Rlc3RzL2xzL3NlbGludXgtc2VnZmF1bHQuc2ggYi90ZXN0cy9scy9zZWxpbnV4 LXNlZ2ZhdWx0LnNoCmluZGV4IDlhYzFkOTUwYy4uZWJjZmJmZTEzIDEwMDc1NQotLS0gYS90 ZXN0cy9scy9zZWxpbnV4LXNlZ2ZhdWx0LnNoCisrKyBiL3Rlc3RzL2xzL3NlbGludXgtc2Vn ZmF1bHQuc2gKQEAgLTMwLDE5ICszMCw0IEBAIG1rZGlyIHNlZGlyIHx8IGZyYW1ld29ya19m YWlsdXJlXwogbG4gLXNmIG1pc3Npbmcgc2VkaXIvYnJva2VuIHx8IGZyYW1ld29ya19mYWls dXJlXwogcmV0dXJuc18gMSBscyAtTCAtUiAtWiAtbSBzZWRpciA+IG91dCB8fCBmYWlsPTEK IAotbmw9JwotJwotaWYgc2VzdGF0dXM9JChMQ19BTEw9QyBzZXN0YXR1cyk7IHRoZW4KLSAg c2VzdGF0dXNfbGluZV8xPSR7c2VzdGF0dXMlJSRubCp9Ci0gIGNhc2UgJHNlc3RhdHVzX2xp bmVfMSBpbgotICAgICdTRUxpbnV4IHN0YXR1czonKicgZW5hYmxlZCcpCi0gICAgICBsc19v dXRwdXQ9JChMQ19BTEw9QyBscyAtbG5aIHNlZGlyL2Jyb2tlbikgfHwgZmFpbD0xCi0gICAg ICBzZXQgeCAkbHNfb3V0cHV0Ci0gICAgICBjYXNlICQ2IGluCi0gICAgICAgICo6KjoqOiop IDs7Ci0gICAgICAgICopIGZhaWw9MTsKLSAgICAgIGVzYWMKLSAgZXNhYwotZmkKLQogRXhp dCAkZmFpbApkaWZmIC0tZ2l0IGEvdGVzdHMvbHMvc2VsaW51eC5zaCBiL3Rlc3RzL2xzL3Nl bGludXguc2gKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5kZXggMDAwMDAwMDAwLi5lOWFjYTRi YjcKLS0tIC9kZXYvbnVsbAorKysgYi90ZXN0cy9scy9zZWxpbnV4LnNoCkBAIC0wLDAgKzEs NDAgQEAKKyMhL2Jpbi9zaAorIyBUZXN0IGJhc2ljIHNlbGludXggb3V0cHV0CisKKyMgQ29w eXJpZ2h0IChDKSAyMDI0IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCisjIFRo aXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOiB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBh bmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwg UHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJlIEZv dW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5 b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKyMgVGhpcyBwcm9ncmFtIGlzIGRp c3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisjIGJ1dCBX SVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5 IG9mCisjIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVS UE9TRS4gIFNlZSB0aGUKKyMgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUg ZGV0YWlscy4KKworIyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBH TlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorIyBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbS4g IElmIG5vdCwgc2VlIDxodHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisKKy4gIiR7 c3JjZGlyPS59L3Rlc3RzL2luaXQuc2giOyBwYXRoX3ByZXBlbmRfIC4vc3JjCitwcmludF92 ZXJfIGxzCityZXF1aXJlX3NlbGludXhfCisKK3RvdWNoIGYgfHwgZnJhbWV3b3JrX2ZhaWx1 cmVfCitjYXNlICQoc3RhdCAtLXByaW50Zj0nJUMnIGYpIGluCisgICo6KjoqOiopIDs7Cisg ICopIHNraXBfICd1bmFibGUgdG8gbWF0Y2ggZGVmYXVsdCBzZWN1cml0eSBjb250ZXh0Jzs7 Citlc2FjCisKKyMgZW5zdXJlIHRoYXQgbHMgLWwgb3V0cHV0IGluY2x1ZGVzIHRoZSAiLiIK K3Rlc3QgIiQobHMgLWwgZnxjdXQgLWMxMSkiID0gLiB8fCBmYWlsPTEKKworIyBlbnN1cmUg dGhhdCBscyAtbFogb3V0cHV0IGluY2x1ZGVzIGNvbnRleHQKK2xzX291dHB1dD0kKExDX0FM TD1DIGxzIC1sblogZikgfHwgZmFpbD0xCitzZXQgeCAkbHNfb3V0cHV0CitjYXNlICQ2IGlu CisgICo6KjoqOiopIDs7CisgICopIGZhaWw9MSA7OworZXNhYworCitFeGl0ICRmYWlsCi0t IAoyLjQ3LjAKCg== --------------zx0un3s6lEz6hsqzkFk7lk8d--