GNU bug report logs - #73404
30.0.50; [forward/kill/etc]-sexp commands do not behave as expected in tree-sitter modes

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juri Linkov <juri <at> linkov.net>
Cc: Theodor Thornhill <theo <at> thornhill.no>, Yuan Fu <casouri <at> gmail.com>, Mickey Petersen <mickey <at> masteringemacs.org>, Eli Zaretskii <eliz <at> gnu.org>, 73404 <at> debbugs.gnu.org
Subject: bug#73404: 30.0.50; [forward/kill/etc]-sexp commands do not behave as expected in tree-sitter modes
Date: Tue, 07 Jan 2025 14:25:24 -0500

> Indeed, symbols are more traditional.
>
> However, the problem arose only because
> 'treesit_traverse_validate_predicate' accepts a symbol
> for both a function and a thing, that caused ambiguity.
>
> So there are two variants to resolve this ambiguity:
>
> 1. use keywords like
>
>   (setq-local treesit-thing-settings
>               `((html
>                  (:sexp ,(regexp-opt '("element" "text" "attribute" "value")))
>                  (:list ,(regexp-opt '("element"")))
>                  (:sentence "tag")
>                  (:text ,(regexp-opt '("comment" "text"))))))
>
> 2. use a symbol property like (put 'list 'treesit-thing t)
>
> You decide ;-)

Of course, there are more alternatives:

- Use a symbol property like (put 'list 'treesit--this-is-a-function t)
- Refuse functions represented as symbols (callers need to use an
  eta-wrapper).
- Distinguish the two cases via a more verbose representation like
  `(thing list)` vs `(function list)`.
- Use a string rather than a symbol.
- <I'm sure you can come up with more options>


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.