GNU bug report logs - #73387
30.0.90; C-x v v in diff-mode doesn't work after C-c C-n

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73387: closed (30.0.90; C-x v v in diff-mode doesn't work
 after C-c C-n)
Date: Wed, 02 Oct 2024 01:25:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 02 Oct 2024 09:24:21 +0800
with message-id <87frpffgai.fsf <at> melete.silentflame.com>
and subject line Re: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n
has caused the debbugs.gnu.org bug report #73387,
regarding 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73387: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73387
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n
Date: Fri, 20 Sep 2024 17:08:37 +0100

X-debbugs-cc: monnier <at> iro.umontreal.ca, dgutov <at> yandex.ru, juri <at> linkov.net

Hello,

If you do C-c C-n in a diff-mode buffer with multiple hunks, a
subsequent C-x v v signals a user-error from diff-file-next.  I think
that the bug is in how diff-vc-deduce-fileset invokes diff-file-next.
I'm not sure exactly how to rework diff-vc-deduce-fileset.

It would be nice to fix this because then C-c C-n C-x v v would be a
convenient way to commit just a single hunk.

-- 
Sean Whitton

[Message part 3 (message/rfc822, inline)]

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Dmitry Gutov <dgutov <at> yandex.ru>, 73387-done <at> debbugs.gnu.org
Subject: Re: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c
 C-n
Date: Wed, 02 Oct 2024 09:24:21 +0800

Hello,

On Tue 01 Oct 2024 at 04:57am +03, Dmitry Gutov wrote:

> On 01/10/2024 04:40, Sean Whitton wrote:
>> Is it right that diff-vc-deduce-fileset will only ever be called in the
>> context of using C-x v v to commit a patch?  The name of the function
>> suggests that it might be used for something else, if not now then in
>> the future.
>
> It's not a 100% guarantee but for now that's how things stand, and it doesn't
> work in a narrowed buffer. So for simplicity's sake we can make it show an
> error with such instructions, I think.
>
> I don't mind doing it the another way too, but if its return value is not
> used, that's not a very intuitive design.

Okay, done that now, and closing the bug.  Thanks!

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.