From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 20 10:53:24 2024 Received: (at submit) by debbugs.gnu.org; 20 Sep 2024 14:53:24 +0000 Received: from localhost ([127.0.0.1]:36082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srf0e-0007dB-5R for submit@debbugs.gnu.org; Fri, 20 Sep 2024 10:53:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:43642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srf0c-0007d4-D1 for submit@debbugs.gnu.org; Fri, 20 Sep 2024 10:53:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srf0I-0002q6-Uv for bug-auctex@gnu.org; Fri, 20 Sep 2024 10:53:02 -0400 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srf0H-0001Wf-D4 for bug-auctex@gnu.org; Fri, 20 Sep 2024 10:53:02 -0400 Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-82cd872755dso94784939f.1 for ; Fri, 20 Sep 2024 07:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726843979; x=1727448779; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=u94LFQVXfqcGHkLXxAEBC/oJgKaTpgPIR4tXVNWDmWs=; b=f7EdKlofor4iHG62Wkxx1ZqK+DeIoWOtwGrHCIu7fN8ImYB4271ymFQgn4HpWv3f/U 2r81lKC35kMTb7O3oWkQDiCrPUNBCRiLHxjdFDDPzEoKBNcX2CJZEVj48paUModyVUma 3TSKv7MHeBM52VHk3JCZNLgLYG0lkUAGOgwXln0mWVN8E5L63x2bDMcq3SRVgpiRWGEi 1uxrnBlg51XOxd4+klK5wjq83NYHIKtYa8rSGuRKJRnD/JZwhIt0X5OpMPAaw1i7zsbt XZ8KIutblzTdt3DuBSxRfbHB+bkSaSIXfAHCUM3WFSNsrTJlLQciuxiq5EaA3Mz1DoXV YNBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726843979; x=1727448779; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=u94LFQVXfqcGHkLXxAEBC/oJgKaTpgPIR4tXVNWDmWs=; b=etciCSVl8HOYa5HqZTXpwsKmhFczpP32tXXpvNSzJKfU0WUjvyB0HDTyx93P3uPZqa RLBIFwGJ+Czx85AYICj0Q1Yr19HMvXWNsfZevVf8gHRmJWpA/ytenPT6AfnX94i2G6K/ 7G/01Ip7s8DEgbKV+/BUXGL/8hktHuAF+MCKz4JrEfbPvgamTjyaGpR0ZfIMPfJXZx5x CosdKU9ELYpzqw20ZJXvUSJVS4Z1+99l52uKr+7VNu6+d4hV59KFPv8VTcutN/Ed6jgg 5GoFuPkVoidkLuZyZ/ScJBzoIJVt2sToVYK6E+mbVA0OC0opEmchuMRS0Y1A0K6tYJGp IVOQ== X-Gm-Message-State: AOJu0YwjVT9BveOWEhPLTzNLwfH/YR/yH9mpS4eYIQZZzdiRNH55ZIGs OXCDF+bktV1SoOScTVaR1zDc6Iw7wKeHnfcIZleHeJqp5NQIdFnWLrfoC6e2Ws/qmZHJ1q0cOCe dNVW0qEKP3p7JUyJLxwyirBhGgb2kdZ7mL20= X-Google-Smtp-Source: AGHT+IETTn8cRS+3320uAMvezvEUxVzqG++1wnRZiI4cHcrJ9JzybrU6WMMDd5H3xG8GVqfIWvYYixx7AOnAOdrdhUU= X-Received: by 2002:a05:6602:2cc7:b0:82c:f05f:6c7a with SMTP id ca18e2360f4ac-83209c53265mr373335739f.0.1726843979368; Fri, 20 Sep 2024 07:52:59 -0700 (PDT) MIME-Version: 1.0 From: Paul Nelson Date: Fri, 20 Sep 2024 16:52:48 +0200 Message-ID: Subject: [PATCH] Fix keybinding support for *-auto-reveal To: bug-auctex@gnu.org Content-Type: multipart/mixed; boundary="000000000000f92f5106228e31f9" Received-SPF: pass client-ip=2607:f8b0:4864:20::d29; envelope-from=ultrono@gmail.com; helo=mail-io1-xd29.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000f92f5106228e31f9 Content-Type: text/plain; charset="UTF-8" Hello, I just realized that my earlier patch 8db1e90b6d25beb72b5ebbc706b6def64794dcf8 broke key-binding support for auto-reveal (i.e., using left/right rather than C-f/b to open previews and folds). The attached patch remedies this. Details below. Thanks, best, Paul --- The user option *-auto-reveal-commands consists of both functions and lists for keybinding: (defcustom preview-auto-reveal-commands '((key-binding [left]) (key-binding [right]) backward-char forward-char pop-to-mark-command undo) "List of commands that may cause a preview to be revealed. This list is consulted by the default value of `preview-auto-reveal'." :type '(repeat (choice (function :tag "Function") (sexp :tag "Key binding")))) When we call (apply #'preview-arrived-via preview-auto-reveal-commands), the lists for keybinding are not evaluated, so we never pick up the command to which left/right are bound. The attach patch remedies this issue by first evaluating any keybinding. In retrospect, a more uniform approach would have been to have all elements of *-auto-reveal-commands be "something that gets evaluated", i.e., (defcustom preview-auto-reveal-commands '((key-binding [left]) (key-binding [right]) #'backward-char #'forward-char #'pop-to-mark-command #'undo) ...) This would allow a more uniform default implementation of *-auto-reveal. Given that the docstring for *-auto-reveal-commands says that it should consist of either functions or key bindings, I think the proposed solution is acceptable. It's also a bit simpler for me, since I have a couple packages that add functions (rather than function symbols) to *-auto-reveal-commands. --000000000000f92f5106228e31f9 Content-Type: application/octet-stream; name="0001-Fix-keybinding-support-for-auto-reveal.patch" Content-Disposition: attachment; filename="0001-Fix-keybinding-support-for-auto-reveal.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m1au9q840 RnJvbSA1NjIzNjc1YTE5MDQzZjYyNTlkMDQ3OTQ2MjM1NjY3YmM5Y2JlZmYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIE5lbHNvbiA8dWx0cm9ub0BnbWFpbC5jb20+CkRhdGU6 IEZyaSwgMjAgU2VwIDIwMjQgMTY6NDg6MDIgKzAyMDAKU3ViamVjdDogW1BBVENIXSBGaXgga2V5 YmluZGluZyBzdXBwb3J0IGZvciAqLWF1dG8tcmV2ZWFsCgoqIHByZXZpZXcuZWwgKHByZXZpZXct YXV0by1yZXZlYWwpOgoqIHRleC1mb2xkLmVsIChUZVgtZm9sZC1hdXRvLXJldmVhbCk6IEV2YWx1 YXRlIGFueSBrZXliaW5kaW5ncwpiZWZvcmUgY2FsbGluZyAqLWFycml2ZWQtdmlhLgotLS0KIHBy ZXZpZXcuZWwgIHwgNyArKysrKystCiB0ZXgtZm9sZC5lbCB8IDcgKysrKysrLQogMiBmaWxlcyBj aGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3By ZXZpZXcuZWwgYi9wcmV2aWV3LmVsCmluZGV4IGQ3NjAzMDA0Li4zZDUxODdiYiAxMDA2NDQKLS0t IGEvcHJldmlldy5lbAorKysgYi9wcmV2aWV3LmVsCkBAIC0xNjU0LDcgKzE2NTQsMTIgQEAgVGhp cyBsaXN0IGlzIGNvbnN1bHRlZCBieSB0aGUgZGVmYXVsdCB2YWx1ZSBvZiBgcHJldmlldy1hdXRv LXJldmVhbCcuIgogICAgICAgICAgICAgICAgICAgICAgICAgIChzZXhwIDp0YWcgIktleSBiaW5k aW5nIikpKSkKIAogKGRlZmN1c3RvbSBwcmV2aWV3LWF1dG8tcmV2ZWFsCi0gICcoZXZhbCAoYXBw bHkgIydwcmV2aWV3LWFycml2ZWQtdmlhIHByZXZpZXctYXV0by1yZXZlYWwtY29tbWFuZHMpKQor ICAnKGV2YWwgKGFwcGx5ICMncHJldmlldy1hcnJpdmVkLXZpYQorICAgICAgICAgICAgICAgICht YXBjYXIgKGxhbWJkYSAoY21kKQorICAgICAgICAgICAgICAgICAgICAgICAgICAoaWYgKGFuZCAo bGlzdHAgY21kKSAoZXEgKGNhciBjbWQpICdrZXktYmluZGluZykpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoZXZhbCBjbWQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgY21k KSkKKyAgICAgICAgICAgICAgICAgICAgICAgIHByZXZpZXctYXV0by1yZXZlYWwtY29tbWFuZHMp KSkKICAgIkNhdXNlIHByZXZpZXdzIHRvIG9wZW4gYXV0b21hdGljYWxseSB3aGVuIGVudGVyZWQu CiBQb3NzaWJpbGl0aWVzIGFyZToKIHQgYXV0b29wZW5zLApkaWZmIC0tZ2l0IGEvdGV4LWZvbGQu ZWwgYi90ZXgtZm9sZC5lbAppbmRleCA4YmYxMGJlNy4uZjFhYWYxYWMgMTAwNjQ0Ci0tLSBhL3Rl eC1mb2xkLmVsCisrKyBiL3RleC1mb2xkLmVsCkBAIC0yNjYsNyArMjY2LDEyIEBAIFRoaXMgbGlz dCBpcyBjb25zdWx0ZWQgYnkgdGhlIGRlZmF1bHQgdmFsdWUgb2YgYFRlWC1mb2xkLWF1dG8tcmV2 ZWFsJy4iCiAgICAgICAgICAgICAgICAgICAgICAgICAgKHNleHAgOnRhZyAiS2V5IGJpbmRpbmci KSkpKQogCiAoZGVmY3VzdG9tIFRlWC1mb2xkLWF1dG8tcmV2ZWFsCi0gICcoZXZhbCAoYXBwbHkg IydUZVgtZm9sZC1hcnJpdmVkLXZpYSBUZVgtZm9sZC1hdXRvLXJldmVhbC1jb21tYW5kcykpCisg ICcoZXZhbCAoYXBwbHkgIydUZVgtZm9sZC1hcnJpdmVkLXZpYQorICAgICAgICAgICAgICAgICht YXBjYXIgKGxhbWJkYSAoY21kKQorICAgICAgICAgICAgICAgICAgICAgICAgICAoaWYgKGFuZCAo bGlzdHAgY21kKSAoZXEgKGNhciBjbWQpICdrZXktYmluZGluZykpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoZXZhbCBjbWQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgY21k KSkKKyAgICAgICAgICAgICAgICAgICAgICAgIFRlWC1mb2xkLWF1dG8tcmV2ZWFsLWNvbW1hbmRz KSkpCiAgICJQcmVkaWNhdGUgdG8gb3BlbiBhIGZvbGQgd2hlbiBlbnRlcmVkLgogUG9zc2liaWxp dGllcyBhcmU6CiB0IGF1dG9vcGVucywKLS0gCjIuMzkuMyAoQXBwbGUgR2l0LTE0NSkKCg== --000000000000f92f5106228e31f9-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 03:22:32 2024 Received: (at 73386) by debbugs.gnu.org; 25 Sep 2024 07:22:32 +0000 Received: from localhost ([127.0.0.1]:42909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stMM3-0000yr-Mw for submit@debbugs.gnu.org; Wed, 25 Sep 2024 03:22:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stMM1-0000yY-Jv for 73386@debbugs.gnu.org; Wed, 25 Sep 2024 03:22:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stMLW-00078U-Lg; Wed, 25 Sep 2024 03:21:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lkf7mtIx4gLrtZvmgvLtNoL9o4pBQGbioEJaf/8H0Jk=; b=leJNchyQPdA0/LEdKDWi KuEfBMDyvn33eOD3qmqHx2CH5uFCYGFvZCoXNI9hHmBdNaxP4s/Tdwo82SFJPrgpAbvUMZ4Bz5UeT SGiPvOxC9S7au9pT5279V6rs7VYgkgRqQ/RmjotO9w5RpPGcaTPKkdouI2nttj8bB0NTa85UZ0tjV X7HwlsLtx67122JM5DMJ9OLzRTikA3hwJkazG4GCHtl/g/Bt0cNL6wcvaSctcmA4+T9XncjwyGcA6 LGTg4LAot197OiZc2d5TuXkiTzNdSux4i3KvYRzrznLIs7BNiaqKk+wjFQY+MB1Mj6UnvZ/AWZ76g Mwt8eIzqu7yQ4w==; From: Arash Esbati To: Paul Nelson Subject: Re: bug#73386: [PATCH] Fix keybinding support for *-auto-reveal In-Reply-To: (Paul Nelson's message of "Fri, 20 Sep 2024 16:52:48 +0200") References: Date: Wed, 25 Sep 2024 09:21:31 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73386 Cc: 73386@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Paul, Paul Nelson writes: > I just realized that my earlier patch > 8db1e90b6d25beb72b5ebbc706b6def64794dcf8 broke key-binding support for > auto-reveal (i.e., using left/right rather than C-f/b to open previews > and folds). The attached patch remedies this. Details below. Thanks. I have one question: Is it possible to set the LEXICAL argument of `eval' to t? ,----[ C-h f eval RET ] | eval is a primitive-function in =E2=80=98C source code=E2=80=99. |=20 | (eval FORM &optional LEXICAL) |=20 | Evaluate FORM and return its value. | If LEXICAL is =E2=80=98t=E2=80=99, evaluate using lexical binding by defa= ult. | This is the recommended value. |=20 | If absent or =E2=80=98nil=E2=80=99, use dynamic scoping only.=20 `---- I didn't test your change, but think it should work as well with my request. Best, Arash From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 03:49:21 2024 Received: (at 73386) by debbugs.gnu.org; 25 Sep 2024 07:49:21 +0000 Received: from localhost ([127.0.0.1]:43841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stMm1-0002e6-8y for submit@debbugs.gnu.org; Wed, 25 Sep 2024 03:49:21 -0400 Received: from mail-io1-f48.google.com ([209.85.166.48]:58372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stMly-0002dh-Q9 for 73386@debbugs.gnu.org; Wed, 25 Sep 2024 03:49:19 -0400 Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-82aa93774ceso345351739f.0 for <73386@debbugs.gnu.org>; Wed, 25 Sep 2024 00:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727250468; x=1727855268; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Vz/2cghYaqfcf3PrDNPabG25mkb4d3XKRSkMTqb+vi0=; b=kUb+YgenBCMJWk+DHTv/darLpXudwU3WvSd+kGciTX78hYYTtXFZKrALMmqfk8i3b+ 9+Cf8D7tKZ1G49cWHanEC3siq0rVjA++QR5yL5CtZJLbwWX2vmOVs8fzmWlrhiMOPNHE 7FpdWhpH7bfndApbe2JFt5mX5/LlXSaA9Fn/emNfWA/9O6Cq+S3Rwn0JIMe2oiyQ8ZYS yO7EqRlz3R9jPYYZ8tcTthYqWj/fkhCirAAtxP3qMvEx2z2CPTEsAMqoXfN49kJwNQOS 3TmsszfZ3hVinNX50IzNEiLRlFsnyPZcdr7Ufbkc/YOA5rjBIgRQufpsweXe5Qdtcbwy uwWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727250468; x=1727855268; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vz/2cghYaqfcf3PrDNPabG25mkb4d3XKRSkMTqb+vi0=; b=g8bbZJKGzV30mxEaGJxtiYX+IrwEXPowFwuxs1cGAN9MiVEm1/vQ2BJZ97VzQheRGV hhD053xoX40VQZc+xI86I0LA/0EATSxaz0Sd4zyju5Fj6Y101ak9jB1K3HU0EEn+mslA Wjoop5ZHITYCb8bpEN9lona12wcd6biM0++5aH52rJUw+ZApE/35VHO6LJVqyA10QbSy 2VFlfVrvtPQjFmjyzCydxLnoTxE6ZuZ2n8ubSd/fjSVS00QAzwJ5rhjYCO9s8c9ShFMn r+IvvOOrBiU25sd7BuGIwDyB+CUCH9vENw/9UdYNZwBKbtEv8Xng23yXV6jzU5jmkXLV z9fQ== X-Gm-Message-State: AOJu0YwnsWbshFka30Ct7nJSe/hm2BpFnLdjv1QqR0upnSwk9LhmKiu/ i68EUoF7SXFa5+VXK8WoBKiG+qAGtD4fLg4lsuI0/F5y/lzJ2rttjDoqNrl+C01fI2CqtV0Lsrn s0ioAL7T6lB2QITo9OUDMSNhn5LycOYqC X-Google-Smtp-Source: AGHT+IFxTzzm+VpyaX3+eL2dy2nE5A5lYLnaYvD9qg8uLv1O/OiClulTvbrTmrsOvnEQA/sLhjMsj91YMpn/hYmc0hw= X-Received: by 2002:a05:6602:2c10:b0:82d:8a8:b97 with SMTP id ca18e2360f4ac-83247e56b32mr282212439f.10.1727250467643; Wed, 25 Sep 2024 00:47:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Nelson Date: Wed, 25 Sep 2024 09:47:35 +0200 Message-ID: Subject: Re: bug#73386: [PATCH] Fix keybinding support for *-auto-reveal To: Arash Esbati Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73386 Cc: 73386@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Arash, > Thanks. I have one question: Is it possible to set the LEXICAL argument > of `eval' to t? If I understand correctly, your suggestion is to use something like the following? (defcustom preview-auto-reveal '(eval . ((apply #'preview-arrived-via (mapcar (lambda (cmd) (if (and (listp cmd) (eq (car cmd) 'key-binding)) (eval cmd) cmd)) preview-auto-reveal-commands)) t)) ...) I assume this will have no effect, but would be happy to test it out for a couple days. Thanks, best, Paul From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 04:06:14 2024 Received: (at 73386) by debbugs.gnu.org; 25 Sep 2024 08:06:15 +0000 Received: from localhost ([127.0.0.1]:44788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stN2M-0003zt-LP for submit@debbugs.gnu.org; Wed, 25 Sep 2024 04:06:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stN2K-0003ze-JP for 73386@debbugs.gnu.org; Wed, 25 Sep 2024 04:06:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stN1p-0004mB-Cs; Wed, 25 Sep 2024 04:05:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=FvHaZ3f7C0MZKAeWS0SXNpo0YsKEsjpTtQPsspb/ttw=; b=ge9GNhah58HfcQ0kQ5OH GeGbrVlAtZIVwsx8O4UdxDBW7mU3xPNnEINZ6CDpjlVOgY6vhk2FzPUHnf+p8Pk4wmFhphzruvmba UtvwB1mC65FyJ1yM0tHPTAFC1Dtw3CVEZynFpSAxHm1+reZBAHr3eFkgXOyHQZiqB5o8j47wNMWw6 /vdDFb6i5IDUv4bwsjXqDC7nbMyUQVPUA3FncxcNT+KEROoH547RrC3kg6Wy52A1yuFGf5MfF0Kif lo9jqXwMq0XVyYN1VCu96GOw8eByEtIwLaUvZkcWA37uTQHQcMEXvnvJ+4g/XPQbTtdp6ubmVMWrF 390Lgz7nUhHDNQ==; From: Arash Esbati To: Paul Nelson Subject: Re: bug#73386: [PATCH] Fix keybinding support for *-auto-reveal In-Reply-To: (Paul Nelson's message of "Wed, 25 Sep 2024 09:47:35 +0200") References: Date: Wed, 25 Sep 2024 10:05:25 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73386 Cc: 73386@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Paul Nelson writes: >> Thanks. I have one question: Is it possible to set the LEXICAL argument >> of `eval' to t? > > If I understand correctly, your suggestion is to use something like > the following? Yes, plus the one addition below. > (defcustom preview-auto-reveal > '(eval . ((apply #'preview-arrived-via > (mapcar (lambda (cmd) > (if (and (listp cmd) (eq (car cmd) 'key-binding)) > (eval cmd) (eval cmd t) > cmd)) > preview-auto-reveal-commands)) > t)) > ...) > > I assume this will have no effect, but would be happy to test it out > for a couple days. Great, thanks, looking forward to your feedback. Best, Arash From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 14:44:51 2024 Received: (at 73386) by debbugs.gnu.org; 26 Sep 2024 18:44:51 +0000 Received: from localhost ([127.0.0.1]:49801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sttTv-0005Gh-6d for submit@debbugs.gnu.org; Thu, 26 Sep 2024 14:44:51 -0400 Received: from mail-io1-f45.google.com ([209.85.166.45]:43471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sttTs-0005G3-JJ for 73386@debbugs.gnu.org; Thu, 26 Sep 2024 14:44:49 -0400 Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-83493f2dda4so3678739f.1 for <73386@debbugs.gnu.org>; Thu, 26 Sep 2024 11:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727376195; x=1727980995; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7NPwqvCLMlAR4QITXy5SPsiojJuf6L2BTZr5vVShzmw=; b=eZ2xSMKpS8AlygJ+Wi0EvGcTpdu2hiDiqf19xKFgmp62fVyI8Q+bII8RFnS3YlRcaV aYnarUuAEF/LvMZkLGvmgJPY/wA0y6I3qS1hrycu806CdBw1ASspgZacQHbMAcTtrz3V Kx0o0DW5PhxD2cj4AI5N64PsiFn7gNF7gpAbHCp2FzoWms0iaVRXbpri+F9pPlgl0ciS 3mHlnbBIjrCgff6LCuG2XSXkWuyYvABmu9XMxoDxcDrpgp6ovjyO08GTjpNBwmSpRF6t rbLcse4MWOUtfzLmZ9UzwKuCIcaaCGhAlRgzUiO7nuvUGttsieO9BsXbkb0LMyayGRm/ z60g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727376195; x=1727980995; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7NPwqvCLMlAR4QITXy5SPsiojJuf6L2BTZr5vVShzmw=; b=PqL+Hq1tyZFZdEyKaeb7RD0jaU/dLGqyjfm/vILa1PeHkMdncHJ8uYUr0SDsHCypIh 5y3+yGE8lWIF6MOhwmiVhRGMhvEya7cKe7MmRa++xDpBqPTexYaHlEbEs6O4kBL3e8Oi b7dPV8EdHjextTn0Hw5hLFv4mBJJGrAu7poVUZaYENJD3r4xCNhJ9bcwiheGxJJVh0XJ XiWfYlLL8zPytYjY2AE8/2CqCawNFIZuiQV18KeveJrPNTRQKx1PTeUem583/KZPXSJs h6sCjR5qlI+gjZRBOA71WE2LaknOrqj8uLd5SLjOxxstCudpUpWApuBvbn4KnZjNrlTi Bieg== X-Gm-Message-State: AOJu0YyRbVkKw9oAx09FC/x5pA+A+PoGXomwsb+tfBzBNFBIbTFjII2Q JZsy36de0H4IajBTbbpkp1pWDi36boTGvw8w5emsOJW6h/Bn3RZzTIOq+kgg8c5tmQtAAJpcueq 11erDYhZBvzs1dwbrdj97iR2xGCLDHw== X-Google-Smtp-Source: AGHT+IFyoimG6qIJwhlRdAISgYkgbodd7uyNn48nx6NRbFdhSt25RB/iy7tnnmrDXbzGPM/XNSLyvs3+x2CQB9DNUok= X-Received: by 2002:a92:cd83:0:b0:3a1:92bb:1e70 with SMTP id e9e14a558f8ab-3a27687c994mr29027545ab.7.1727376195222; Thu, 26 Sep 2024 11:43:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Nelson Date: Thu, 26 Sep 2024 20:43:04 +0200 Message-ID: Subject: Re: bug#73386: [PATCH] Fix keybinding support for *-auto-reveal To: Arash Esbati Content-Type: multipart/mixed; boundary="00000000000082a48306230a1c07" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73386 Cc: 73386@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000082a48306230a1c07 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Seems fine on my end, so I've attached the updated patch. Thanks, best, Paul On Wed, Sep 25, 2024 at 10:05=E2=80=AFAM Arash Esbati wrote= : > > Paul Nelson writes: > > >> Thanks. I have one question: Is it possible to set the LEXICAL argume= nt > >> of `eval' to t? > > > > If I understand correctly, your suggestion is to use something like > > the following? > > Yes, plus the one addition below. > > > (defcustom preview-auto-reveal > > '(eval . ((apply #'preview-arrived-via > > (mapcar (lambda (cmd) > > (if (and (listp cmd) (eq (car cmd) 'ke= y-binding)) > > (eval cmd) > (eval cmd t) > > cmd)) > > preview-auto-reveal-commands)) > > t)) > > ...) > > > > I assume this will have no effect, but would be happy to test it out > > for a couple days. > > Great, thanks, looking forward to your feedback. > > Best, Arash --00000000000082a48306230a1c07 Content-Type: application/octet-stream; name="0001-Fix-keybinding-support-for-auto-reveal.patch" Content-Disposition: attachment; filename="0001-Fix-keybinding-support-for-auto-reveal.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m1jn6c340 RnJvbSA3MjMzZDZhOWVjZTA3NTE0MDkwOGIyMDZkY2ExNGI2YjQ3ODRiZTc4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIE5lbHNvbiA8dWx0cm9ub0BnbWFpbC5jb20+CkRhdGU6 IEZyaSwgMjAgU2VwIDIwMjQgMTY6NDg6MDIgKzAyMDAKU3ViamVjdDogW1BBVENIXSBGaXgga2V5 YmluZGluZyBzdXBwb3J0IGZvciAqLWF1dG8tcmV2ZWFsCgoqIHByZXZpZXcuZWwgKHByZXZpZXct YXV0by1yZXZlYWwpOgoqIHRleC1mb2xkLmVsIChUZVgtZm9sZC1hdXRvLXJldmVhbCk6IEV2YWx1 YXRlIGFueSBrZXliaW5kaW5ncwpiZWZvcmUgY2FsbGluZyAqLWFycml2ZWQtdmlhLgotLS0KIHBy ZXZpZXcuZWwgIHwgOCArKysrKysrLQogdGV4LWZvbGQuZWwgfCA4ICsrKysrKystCiAyIGZpbGVz IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv cHJldmlldy5lbCBiL3ByZXZpZXcuZWwKaW5kZXggZDc2MDMwMDQuLjFkNmIyN2FjIDEwMDY0NAot LS0gYS9wcmV2aWV3LmVsCisrKyBiL3ByZXZpZXcuZWwKQEAgLTE2NTQsNyArMTY1NCwxMyBAQCBU aGlzIGxpc3QgaXMgY29uc3VsdGVkIGJ5IHRoZSBkZWZhdWx0IHZhbHVlIG9mIGBwcmV2aWV3LWF1 dG8tcmV2ZWFsJy4iCiAgICAgICAgICAgICAgICAgICAgICAgICAgKHNleHAgOnRhZyAiS2V5IGJp bmRpbmciKSkpKQogCiAoZGVmY3VzdG9tIHByZXZpZXctYXV0by1yZXZlYWwKLSAgJyhldmFsIChh cHBseSAjJ3ByZXZpZXctYXJyaXZlZC12aWEgcHJldmlldy1hdXRvLXJldmVhbC1jb21tYW5kcykp CisgICcoZXZhbCAuICgoYXBwbHkgIydwcmV2aWV3LWFycml2ZWQtdmlhCisgICAgICAgICAgICAg ICAgICAgKG1hcGNhciAobGFtYmRhIChjbWQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChpZiAoYW5kIChsaXN0cCBjbWQpIChlcSAoY2FyIGNtZCkgJ2tleS1iaW5kaW5nKSkKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChldmFsIGNtZCB0KQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGNtZCkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICBwcmV2aWV3 LWF1dG8tcmV2ZWFsLWNvbW1hbmRzKSkKKyAgICAgICAgICAgIHQpKQogICAiQ2F1c2UgcHJldmll d3MgdG8gb3BlbiBhdXRvbWF0aWNhbGx5IHdoZW4gZW50ZXJlZC4KIFBvc3NpYmlsaXRpZXMgYXJl OgogdCBhdXRvb3BlbnMsCmRpZmYgLS1naXQgYS90ZXgtZm9sZC5lbCBiL3RleC1mb2xkLmVsCmlu ZGV4IDhiZjEwYmU3Li4xMmY3YzJmNyAxMDA2NDQKLS0tIGEvdGV4LWZvbGQuZWwKKysrIGIvdGV4 LWZvbGQuZWwKQEAgLTI2Niw3ICsyNjYsMTMgQEAgVGhpcyBsaXN0IGlzIGNvbnN1bHRlZCBieSB0 aGUgZGVmYXVsdCB2YWx1ZSBvZiBgVGVYLWZvbGQtYXV0by1yZXZlYWwnLiIKICAgICAgICAgICAg ICAgICAgICAgICAgICAoc2V4cCA6dGFnICJLZXkgYmluZGluZyIpKSkpCiAKIChkZWZjdXN0b20g VGVYLWZvbGQtYXV0by1yZXZlYWwKLSAgJyhldmFsIChhcHBseSAjJ1RlWC1mb2xkLWFycml2ZWQt dmlhIFRlWC1mb2xkLWF1dG8tcmV2ZWFsLWNvbW1hbmRzKSkKKyAgJyhldmFsIC4gKChhcHBseSAj J1RlWC1mb2xkLWFycml2ZWQtdmlhCisgICAgICAgICAgICAgICAgICAgKG1hcGNhciAobGFtYmRh IChjbWQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChpZiAoYW5kIChsaXN0cCBjbWQp IChlcSAoY2FyIGNtZCkgJ2tleS1iaW5kaW5nKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChldmFsIGNtZCB0KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNtZCkp CisgICAgICAgICAgICAgICAgICAgICAgICAgICBUZVgtZm9sZC1hdXRvLXJldmVhbC1jb21tYW5k cykpCisgICAgICAgICAgICB0KSkKICAgIlByZWRpY2F0ZSB0byBvcGVuIGEgZm9sZCB3aGVuIGVu dGVyZWQuCiBQb3NzaWJpbGl0aWVzIGFyZToKIHQgYXV0b29wZW5zLAotLSAKMi4zOS4zIChBcHBs ZSBHaXQtMTQ1KQoK --00000000000082a48306230a1c07-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 16:59:51 2024 Received: (at 73386-done) by debbugs.gnu.org; 26 Sep 2024 20:59:51 +0000 Received: from localhost ([127.0.0.1]:51952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stvaZ-0004ss-BM for submit@debbugs.gnu.org; Thu, 26 Sep 2024 16:59:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stvaX-0004sU-5T for 73386-done@debbugs.gnu.org; Thu, 26 Sep 2024 16:59:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stvXu-0006aI-Uj; Thu, 26 Sep 2024 16:57:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=1kMGjjvKvkCsLv8JKKW0lNAmGFEzehLUn82k7eP22pg=; b=gpJHMPjHzJOb3wxl+8I4 BQ/MdCIMoGvHAn7ZEXjBqdeBbk6TH6aRdewfrsGzXPTeKt0TMvaWEt81jFkNRq+D893Vy3VZg/tau KsE2WuEo/OUZBn6eMB6HS6YRfuPsEBH6tLKtU2b2GbuYf1jg+eEWiTGA3/PoRLVfm6YD3euUEnAiJ 5aQrH00Qg/SF8Xw5z0mbnfcKw6vicDoOiJhj06kfM05l4KWOpTe9mMSzINPdus9EcVv4otVmlVW/9 PevwVyYEeJCfpdodW6WazLqLj5ivsf36DtXrn9JHi0oCRUlMhxyvhar+E6PyDb2q9xXshAkQaSZu6 Xh+PMkRxTBw5yA==; From: Arash Esbati To: Paul Nelson Subject: Re: bug#73386: [PATCH] Fix keybinding support for *-auto-reveal In-Reply-To: (Paul Nelson's message of "Thu, 26 Sep 2024 20:43:04 +0200") References: Date: Thu, 26 Sep 2024 22:57:03 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73386-done Cc: 73386-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Paul Nelson writes: > Seems fine on my end, so I've attached the updated patch. Thanks, I installed your patch. Closing. Best, Arash From unknown Sat Jun 21 03:26:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Oct 2024 11:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator