GNU bug report logs - #73384
[PATCH] Draw coloured stipples on NS

Previous Next

Full log

Message #53 received at 73384 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Ben Simms <bsimms.simms <at> gmail.com>
Cc: Rudolf Adamkovič <rudolf <at> adamkovic.org>,
 73384 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>,
 JD Smith <jdtsmith <at> gmail.com>
Subject: Re: bug#73384: [PATCH] Draw coloured stipples on NS
Date: Mon, 21 Oct 2024 21:26:52 +0200

[Message part 1 (text/plain, inline)]

Ben Simms <bsimms.simms <at> gmail.com> writes:

> I'm not sure, I've attached the patch instead of including it in the
> email body, perhaps this is better.

Yes, thanks, now it works.  I think it was due to a trailing whitespace
after else in this part:

+      [[NSGraphicsContext currentContext] restoreGraphicsState];
+#else
+      [[dpyinfo->bitmaps[s->face->stipple - 1].img stippleMask] set];

which was removed in the body.  At any rate, I applied your change,
built emacs anew from scratch, and it looks like this:

[stipples-patch.png (image/png, inline)]

[Message part 3 (text/plain, inline)]

I'd say it works.  What do others think?  Many thanks for this.

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.