GNU bug report logs - #73373
[PATCH] gnu: Add AntiMicroX.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73373 in the body.
You can then email your comments to 73373 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Eric Bavier <bavier <at> posteo.net>
Subject: [PATCH] gnu: Add AntiMicroX.
Date: Fri, 20 Sep 2024 02:05:07 +0000

* gnu/packages/games.scm (antimicrox): New variable.

Change-Id: Ie159edf259bba0aa06ff60c074fec4457b409d12
---
 gnu/packages/games.scm | 52 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 51 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 213c4c598d..a1b27306d2 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -2,7 +2,7 @@
 ;;; Copyright © 2013 John Darrington <jmd <at> gnu.org>
 ;;; Copyright © 2013 Nikita Karetnikov <nikita <at> karetnikov.org>
 ;;; Copyright © 2014, 2015 David Thompson <dthompson2 <at> worcester.edu>
-;;; Copyright © 2014-2023 Eric Bavier <bavier <at> posteo.net>
+;;; Copyright © 2014-2024 Eric Bavier <bavier <at> posteo.net>
 ;;; Copyright © 2014 Cyrill Schenkel <cyrill.schenkel <at> gmail.com>
 ;;; Copyright © 2014 Sylvain Beucler <beuc <at> beuc.net>
 ;;; Copyright © 2014, 2015, 2018, 2019, 2021 Ludovic Courtès <ludo <at> gnu.org>
@@ -170,6 +170,7 @@ (define-module (gnu packages games)
   #:use-module (gnu packages image)
   #:use-module (gnu packages imagemagick)
   #:use-module (gnu packages javascript)
+  #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages less)
   #:use-module (gnu packages lesstif)
   #:use-module (gnu packages libcanberra)
@@ -485,6 +486,55 @@ (define-public anarch
 Doom clone shooter game.")
       (license license:cc0))))
 
+(define-public antimicrox
+  (package
+   (name "antimicrox")
+   (version "3.4.1")
+   (home-page "https://github.com/AntiMicroX/antimicrox")
+   (source
+    (origin
+     (method git-fetch)
+     (uri (git-reference
+           (url home-page)
+           (commit version)))
+     (file-name (git-file-name name version))
+     (sha256
+      (base32
+       "04yb5nppn751asbihr90sqk5imamc937886lc24cihhgp0sila8y"))))
+   (build-system cmake-build-system)
+   (arguments
+    (list
+     #:tests? #f                        ; Tests require Qt5
+     #:configure-flags
+     #~(list "-DCHECK_FOR_UPDATES=NO"
+             "-DWITH_TESTS=NO"
+             #$(string-append "-DANTIMICROX_PKG_VERSION=" version))
+     #:phases
+     #~(modify-phases %standard-phases
+         (add-after 'unpack 'patch-installation-target
+           (lambda _
+             (substitute* "CMakeLists.txt"
+               (("/usr(/lib/udev/rules.d)" _ lib)
+                (string-append #$output lib))))))))
+   (native-inputs
+    (list extra-cmake-modules
+          gettext-minimal
+          itstool
+          qttools))
+   (inputs
+    (list libxtst
+          libx11
+          qtbase
+          sdl2))
+   (synopsis "Control your system with a gamepad")
+   (description
+    "AntiMicroX is a graphical program used to map gamepad keys to keyboard, mouse,
+scripts, and macros.  Useful for controlling your system with a gamepad or
+playing games that don't natively support gamepads.  It can also be used for
+generating SDL2 configuration (useful for mapping atypical gamepads to generic
+ones).  It support X.org and Wayland.")
+   (license license:gpl3+)))
+
 (define-public armagetronad
   (package
     (name "armagetronad")

base-commit: 6ea75bb9bcc52521f0bb3f121799745fdc17f1c9
-- 
2.46.0

Message #8 received at 73373 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Eric Bavier <bavier <at> posteo.net>, 73373 <at> debbugs.gnu.org
Cc: 宋文武 <iyzsong <at> envs.net>,
 Adam Faiz <adam.faiz <at> disroot.org>
Subject: Re: [bug#73373] [PATCH] gnu: Add AntiMicroX.
Date: Fri, 20 Sep 2024 07:24:05 +0200

Am Freitag, dem 20.09.2024 um 02:05 +0000 schrieb Eric Bavier:
> * gnu/packages/games.scm (antimicrox): New variable.
> 
> Change-Id: Ie159edf259bba0aa06ff60c074fec4457b409d12
> ---
>  gnu/packages/games.scm | 52
> +++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 51 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 213c4c598d..a1b27306d2 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -2,7 +2,7 @@
>  ;;; Copyright © 2013 John Darrington <jmd <at> gnu.org>
>  ;;; Copyright © 2013 Nikita Karetnikov <nikita <at> karetnikov.org>
>  ;;; Copyright © 2014, 2015 David Thompson <dthompson2 <at> worcester.edu>
> -;;; Copyright © 2014-2023 Eric Bavier <bavier <at> posteo.net>
> +;;; Copyright © 2014-2024 Eric Bavier <bavier <at> posteo.net>
>  ;;; Copyright © 2014 Cyrill Schenkel <cyrill.schenkel <at> gmail.com>
>  ;;; Copyright © 2014 Sylvain Beucler <beuc <at> beuc.net>
>  ;;; Copyright © 2014, 2015, 2018, 2019, 2021 Ludovic Courtès
> <ludo <at> gnu.org>
> @@ -170,6 +170,7 @@ (define-module (gnu packages games)
>    #:use-module (gnu packages image)
>    #:use-module (gnu packages imagemagick)
>    #:use-module (gnu packages javascript)
> +  #:use-module (gnu packages kde-frameworks)
>    #:use-module (gnu packages less)
>    #:use-module (gnu packages lesstif)
>    #:use-module (gnu packages libcanberra)
> @@ -485,6 +486,55 @@ (define-public anarch
>  Doom clone shooter game.")
>        (license license:cc0))))
>  
> +(define-public antimicrox
> +  (package
> +   (name "antimicrox")
> +   (version "3.4.1")
> +   (home-page "https://github.com/AntiMicroX/antimicrox")
> +   (source
> +    (origin
> +     (method git-fetch)
> +     (uri (git-reference
> +           (url home-page)
> +           (commit version)))
> +     (file-name (git-file-name name version))
> +     (sha256
> +      (base32
> +       "04yb5nppn751asbihr90sqk5imamc937886lc24cihhgp0sila8y"))))
> +   (build-system cmake-build-system)
> +   (arguments
> +    (list
> +     #:tests? #f                        ; Tests require Qt5
Is there a reason to build it with Qt 6 then? 🤔
Alternatively, we might want to check if the tests can be built with Qt
6.  This requires a little more work.
> +     #:configure-flags
> +     #~(list "-DCHECK_FOR_UPDATES=NO"
> +             "-DWITH_TESTS=NO"
> +             #$(string-append "-DANTIMICROX_PKG_VERSION=" version))
> +     #:phases
> +     #~(modify-phases %standard-phases
> +         (add-after 'unpack 'patch-installation-target
> +           (lambda _
> +             (substitute* "CMakeLists.txt"
> +               (("/usr(/lib/udev/rules.d)" _ lib)
> +                (string-append #$output lib))))))))
> +   (native-inputs
> +    (list extra-cmake-modules
> +          gettext-minimal
> +          itstool
> +          qttools))
> +   (inputs
> +    (list libxtst
> +          libx11
> +          qtbase
> +          sdl2))
> +   (synopsis "Control your system with a gamepad")
> +   (description
> +    "AntiMicroX is a graphical program used to map gamepad keys to
> keyboard, mouse,
> +scripts, and macros.  Useful for controlling your system with a
> gamepad or
> +playing games that don't natively support gamepads.  It can also be
> used for
> +generating SDL2 configuration (useful for mapping atypical gamepads
> to generic
> +ones).  It support X.org and Wayland.")
> +   (license license:gpl3+)))
The description could use some polishing.  It should consist of
complete sentences and there are some minor grammar mistakes as well. 
Also, I don't see a home-page (how does guix not complain about this?)

Cheers

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Eric Bavier <bavier <at> posteo.net>, 73373 <at> debbugs.gnu.org
Cc: Adam Faiz <adam.faiz <at> disroot.org>,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#73373] [PATCH] gnu: Add AntiMicroX.
Date: Fri, 20 Sep 2024 05:58:44 +0000

On 20 September 2024 05:24:05 UTC, Liliana Marie Prikler <liliana.prikler <at> gmail.com> wrote:
>Also, I don't see a home-page (how does guix not complain about this?)

It's there, under version, but I prefer seeing it in its conventional spot above synopsis too.



Kind regards,

T G-R

Sent on the go.  Excuse or enjoy my brevity.

Message #17 received at 73373 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> posteo.net>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 73373 <at> debbugs.gnu.org,
 宋文武 <iyzsong <at> envs.net>,
 Adam Faiz <adam.faiz <at> disroot.org>
Subject: Re: [bug#73373] [PATCH] gnu: Add AntiMicroX.
Date: Fri, 20 Sep 2024 16:39:51 +0000

[Message part 1 (text/plain, inline)]

Hi, thanks for reviewing.

On 20.09.2024 00:24, Liliana Marie Prikler wrote:
> Am Freitag, dem 20.09.2024 um 02:05 +0000 schrieb Eric Bavier:
>> +   (arguments
>> +    (list
>> +     #:tests? #f                        ; Tests require Qt5
> Is there a reason to build it with Qt 6 then? 🤔
> Alternatively, we might want to check if the tests can be built with Qt
> 6.  This requires a little more work.

I looked into this a little more.  It appears that the tests themselves 
are not maintained.  E.g. the most recent changes are several years 
behind other changes to the codebase, and there is at least one 
egregious typo ("#inlude") that prevents them from compiling even with 
Qt5.  So maybe we disable with "Tests unmaintained" as the reason 
instead.

>> +   (description
>> +    "AntiMicroX is a graphical program used to map gamepad keys to
>> keyboard, mouse,
>> +scripts, and macros.  Useful for controlling your system with a
>> gamepad or
>> +playing games that don't natively support gamepads.  It can also be
>> used for
>> +generating SDL2 configuration (useful for mapping atypical gamepads
>> to generic
>> +ones).  It support X.org and Wayland.")
>> +   (license license:gpl3+)))
> The description could use some polishing.  It should consist of
> complete sentences and there are some minor grammar mistakes as well.

Thanks, I've revised the description a bit in the attached updated 
patch.

> Also, I don't see a home-page (how does guix not complain about this?)

I placed home-page above source to avoid having to duplicate the github 
address.  There are about 452 other packages that do this.

-- 
`~Eric

[0001-gnu-Add-AntiMicroX.patch (text/x-patch, attachment)]

Message #22 received at 73373-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> posteo.net>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 73373-done <at> debbugs.gnu.org, Adam Faiz <adam.faiz <at> disroot.org>,
 宋文武 <iyzsong <at> envs.net>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, guix-patches <at> gnu.org
Subject: Re: [bug#73373] [PATCH] gnu: Add AntiMicroX.
Date: Wed, 02 Oct 2024 04:11:22 +0000

Hearing no more comments, I've pushed the latest patch with a slightly 
reworded description in commit b9f2ff6b8d361fa40f6db08378cb47afa2652c4e

Thanks for reviewing,
-- 
`~Eric

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.