Subject: RE: bug#73369: 31.0.50; csharp-ts-mode does not have any syntax highlighting apart

From: <[email-masked]>
Date: Tue, 24 Sep 2024 19:52:05 -0700

Hi all:

Confirmed that the patch that was provided works well and I can now activate `csharp-ts-mode` without any further issues. 

Thanks so much for this!

Yours sincerely,
Siew Yi Liang

-----Original Message-----
From: Yuan Fu <[email-masked]> 
Sent: Friday, September 20, 2024 1:26 AM
To: Eli Zaretskii <[email-masked]>
Cc: [email-masked]; Theodor Thornhill <[email-masked]>; [email-masked]
Subject: Re: bug#73369: 31.0.50; csharp-ts-mode does not have any syntax highlighting apart

> On Sep 19, 2024, at 11:07 PM, Eli Zaretskii <[email-masked]> wrote:
> 
>> From: <[email-masked]>
>> Date: Thu, 19 Sep 2024 12:33:13 -0700
>> 
>> Normal `csharp-mode` works fine to display C# files with syntax 
>> highlighting - if you use `csharp-ts-mode`, however, all syntax 
>> highlighting is lost.
> 
> Do you see any error messages in *Messages* when you use 
> csharp-ts-mode?
> 
> Theo and Yuan, it sounds like the C# grammar made some incompatible 
> change?  Can we fix this ASAP (on the release branch), please?

Tree-sitter-csharp devs changed so many things, it’s crazy. Anyway, here’s a patch that works with the latest grammar. Theo, can you use a test C# file and see if the new rules cover everything the old rules cover?

Yuan